GitLab

These pass on Windows.

Bug: 824418, 905508
Change-Id: Ib6420284643a430cc43a76de3afbb5c2e3de6099
Reviewed-on: https://chromium-review.googlesource.com/c/1333119
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611421}

Bug: 895886
Change-Id: I8e9bfd692e49cde029cb6fd8df1660713be45e05
Reviewed-on: https://chromium-review.googlesource.com/c/1341772Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611420}

0002-Use-seperate-page-cache-pools-for-each-sqlite-connec.patch is no
longer used after https://crrev.com/c/1343789

0006-fts3-Fix-uninit-variable-in-fts3EvalDeferredPhrase.patch is
reworked. The new version is a more self-contained patch.

Change-Id: I448783656d1f5942e4c14a6b284ddcc33ef262a7
Reviewed-on: https://chromium-review.googlesource.com/c/1350311Reviewed-by: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611419}

Prefix-based calls make it hard to search the code-base. They save some
typing but at the cost of readability.

There will be a set of follow-up CLs that reintroduce CallJS that does
not use a prefix. Then, CallJSWithPrefix will be removed.

Bug: 908498
Change-Id: I495c097be210ece3ef2f7144e1b5371fe13c7406
Reviewed-on: https://chromium-review.googlesource.com/c/1351455Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611418}

In crrev.com/c/1296679 we removed unnecessary code given the assumption that
backdrop_texture could never be 0.

Unfortunately we missed the case where background_rect is empty, and we still
can have params->background_texture equal to 0.

This patch brings back that check.

Bug: 908293, 904981
Change-Id: I94a1109c839337b77589c69fa607d7dc074c0daf
Reviewed-on: https://chromium-review.googlesource.com/c/1351711Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611417}

Extensive logging during PS autologin is needed to debug
https://crbug.com/902315 which is reproducible only on official builds.
The plan is to temporary enable these logs on canary/dev channel.

Bug: 902315
Test: Manual
Change-Id: Ia4a9ae68e442f1eaa404dbc4408ecb5a8662a8f0
Reviewed-on: https://chromium-review.googlesource.com/c/1349346Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611416}

This CL is a follow-up for improving overall readability for
TouchSelectionMenuRUnnerChromeOS.

Bug: b/119794258
Test: Build.
Change-Id: I5ec16deac092e8fb1a493634e871f5ef683fb6da
Reviewed-on: https://chromium-review.googlesource.com/c/1351388Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: David Jacobo <djacobo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611415}

Looks like crrev.com/610236 changes some fuzz-related file in base/test
but these chromeos-specific fuzzers are missed from the refactoring.

TBR=achuith@chromium.org

Bug: 908915
Test: build passes
Change-Id: Ib78c7b1c5bde30ca007c6ae6e13526299be9f9d5
Reviewed-on: https://chromium-review.googlesource.com/c/1351086
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611414}

https://android.googlesource.com/platform/external/perfetto.git/+log/05744b47d94a..1561e23284f1


git log 05744b47d94a..1561e23284f1 --date=short --no-merges --format='%ad %ae %s'
2018-11-27 fmayer@google.com Merge "profiling: Add management for system properties."
2018-11-27 lalitm@google.com Merge "perfetto: add script to quickly add traces to test data"


Created with:
  gclient setdep -r src/third_party/perfetto@1561e23284f1

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Ia2db20d319f482a9af34f91d942adee7b8b51d1a
Reviewed-on: https://chromium-review.googlesource.com/c/1352061Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611413}

It is to easy to accidentally trigger the scrubbing otherwise according
to the VR team.

Bug: 827569
Change-Id: I55236c36c4759e64eea8f3ae2a49de452f95fc45
Reviewed-on: https://chromium-review.googlesource.com/1071714
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562131}
Reviewed-on: https://chromium-review.googlesource.com/c/1076374Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611412}

Bug: 908790
Change-Id: I7b8fe648f2190a83954d0eba08d636fa5055e6c6
Reviewed-on: https://chromium-review.googlesource.com/c/1352409
Commit-Queue: Katie Dektar <katie@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611411}

Refactor zaura_shell and wl_output out of server.cc to isolate generic
Wayland API implementations from ChromeOS specific ones. This will allow
ChromeOS specific APIs to be conditionally compiled on builds that don't
need them. This helps port EXO to Chromecast where Ash (ChromeOS' window
manager) isn't present.

Changes:
 * Move zaura_shell into its own file since this won't be compiled on
 Chromecast.
 * Move Output and WaylandDisplayObserver into their own files since
 these are shared between zaura_shell, wl_output and Server.
 * Move wl_output into its own file since all its dependencies have been
 refactored out of server.cc.

Bug: 896710
Test: Run exo_unittests
Change-Id: I51b42301b5b7fcf53b1879373a2b50db6e799dd1
Reviewed-on: https://chromium-review.googlesource.com/c/1328233Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611410}

- Adds vectors for both discovery and share callbacks.
- Solves the race condition in which multiple
  dialogs of "Add Smb Share" would use a shared instance of each
  HostLocator.
- If a SmbShareFinder::GatherSharesInNetwork call comes in when one is
  already running, the callbacks are stored and run when the original
  GatherSharesInNetwork call finishes.
- Adds additional unit test to reflect on the changes.

Bug: chromium:892287
Test: end-to-end
Change-Id: I9551532dc08fd9338803786bdd89f0398f4ce7db
Reviewed-on: https://chromium-review.googlesource.com/c/1336435Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611409}

This adds a win-angle-rel try config to cr-buildbucket.cfg. It
also adds dummy no-op builders to luci-scheduler.cfg. This will
allow ANGLE to define a set of test distinct from the set of
tests run on the GPU FYI bots.

Bug: 822310
Change-Id: Ie42166d35ab01ddcce8d0ad637e02ba10629917d
Reviewed-on: https://chromium-review.googlesource.com/c/1341216Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611408}

The parameter isn't needed because the other object already carries the
key system information. This CL extends the interface so the Blink
object can get the key system from the implementation through it.

This is needed to reduce the boilerplate in the Media Capabilities
Encrypted Media implementation.

Bug: 907909
Change-Id: If59a6fc0ef47292696b5538a70b7fd22fbf024ca
Reviewed-on: https://chromium-review.googlesource.com/c/1348731
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611407}

Update TabModelWebStateListDelegate so it doesn't need TabModel
 object as there is no need to set parentModel for the tab anymore.

Bug: 899839, 228575
Change-Id: I68ff2d4672423b36fbbb171d9f183f3506d39be5
Reviewed-on: https://chromium-review.googlesource.com/c/1320792
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611406}

Enables VR tests on the standalone vega device on Oreo Phone Tester.

These were tested to work locally several months ago, but new issues may
have popped up in the meantime, so they are currently marked as
experimental.

Bug: 876946
Change-Id: Ib3d9054ef265d3290987e819043ddb9477ad32b4
Reviewed-on: https://chromium-review.googlesource.com/c/1347609Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611405}

This will be used to allow a kill-switch for the feature post-launch as
well as help debugging.

Bug: 903263
Change-Id: Icaf0b9ea4f28f9abddfa67f88fc6759aca812ec3
Reviewed-on: https://chromium-review.googlesource.com/c/1349476Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611404}

Change-Id: I506eacb30f4ca3180f175042aa3e442a728e9584
Reviewed-on: https://chromium-review.googlesource.com/c/1352517
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#611403}

This reverts commit 7fbb7857.

Reason for revert: Persistent failures on https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20ASAN/ - see https://crbug.com/909021

Original change's description:
> [LayoutNG] Support non-horizontal flows in Flexbox
> 
> Meaning: column containers, ortho children, and non-horizontal
> writing modes
> 
> Bug: 845235
> Change-Id: Iba6525752d0c14a77bc9a13cc75a484cdf3a711d
> Reviewed-on: https://chromium-review.googlesource.com/c/1332247
> Commit-Queue: David Grogan <dgrogan@chromium.org>
> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611268}

TBR=cbiesinger@chromium.org,dgrogan@chromium.org

Change-Id: Ib66afedb725af13acd85a298c4fd565f02b32019
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 845235,909021
Reviewed-on: https://chromium-review.googlesource.com/c/1352670Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#611402}

Create a new API for subscribing to notification or indication smartly
based on the availability of both options.

Note that notification has higher priority over indication.

Bug: internal 118329438
Change-Id: I610477424e2e0a2877e41c3bfd4dd1493e02f8f7
Reviewed-on: https://chromium-review.googlesource.com/c/1352492Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Wai Hon Law <whhone@google.com>
Cr-Commit-Position: refs/heads/master@{#611401}

This functionality is based on the Selection API draft specification and is already supported in Blink by other types of user initiated selection actions:
https://w3c.github.io/selection-api/#selectstart-event

Tests are in the following patch:
https://chromium-review.googlesource.com/c/chromium/src/+/1350195/

R=dmazzoni@chromium.org

Bug: 639340
Change-Id: I5a7793c71b02f2e92fafb7fb9731b6ebf288a412
Tested: with unit tests in another patch
Reviewed-on: https://chromium-review.googlesource.com/c/1347214
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611400}

Added android utility functions to export/import sync FD from/to a
vulkan semaphore. Added unittests.

Bug: 891060
Change-Id: I2fcac73018fe91afae0ac141fdd5e40244451b15
Reviewed-on: https://chromium-review.googlesource.com/c/1332608Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611399}

This improves Web UI load times with Polymer 2 by 11-14%.

Bug: 738611
Change-Id: I2bf47a8b72730d019772824f8af9359dad30b364
Reviewed-on: https://chromium-review.googlesource.com/c/1351421
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611398}

This change should be committed right away per go/perfbot-sheriff
since this is failing on the waterfall.

r610618 didn't work since
TYPED_TEST(ObserverListPerfTest, MAYBE_NotifyPerformance) {
is preprocessed to
something_MAYBE_NotifyPerformance
So then the directive
#define MAYBE_NotifyPerformance DISABLED_NotifyPerformance
is not applied.

This will fix both 908490 and 906686.

Bug: 906686,908490
Change-Id: Ib2adc016fbef79bb889a076e452534f893fb09b5
Reviewed-on: https://chromium-review.googlesource.com/c/1352481Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611397}

RasterDecoder uses skia to do rendering, and skia can restore texure
and sampler bindings by itself. So we don't need use ContextState to
do it.

Bug: 902904
Change-Id: I5ce2510b4616aab9087cd61bfbfb88368c6e34ab
Reviewed-on: https://chromium-review.googlesource.com/c/1338159
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611396}

SendResults can't be called on GpuMain thread or we crash. This CL
calls it from display compositor thread after we've ensured that
the appropriate GL context is current.

Change-Id: Ifa5c2cffafb5cfa55e5b21b1b93b6f1bc8d6e1e1
Reviewed-on: https://chromium-review.googlesource.com/c/1351577
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611395}

Underlying infrastructure might check fail if SetNextDelayedDoWork is
called for a run_time in the past. Which should be expected given that
we have a ScheduleWork method for that case.

ThreadControllerWithMessagePumpImpl checkfails on this.

Bug: 891670
Change-Id: I60f5142eba3ff71babe976c749cec4a504408eed
Reviewed-on: https://chromium-review.googlesource.com/c/1350960
Commit-Queue: Carlos Caballero <carlscab@google.com>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611394}

This CL sampling the current process priority and add an instant event
to report it.

This will be used to figure out some priority inversion related to the
GPU process and background renderers.

R=oysteine@chromium.org

Change-Id: I9e2f9b4b48379ade4d476dd7c7fd2b2fe52639d7
Reviewed-on: https://chromium-review.googlesource.com/c/1350189Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611393}

This codepath was using the deprecated CryptAuthDeviceManager, which causes
crashes on M71+.

R=jhawkins@chromium.org

Bug: 908579
Change-Id: I52bd659b43cb851caa696fb77bcf0536396ba214
Reviewed-on: https://chromium-review.googlesource.com/c/1351877Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611392}

In order to ensure that we're reporting embedding time for all
production clients, this CL verifies that the allocation timestamp is
not null on serialization/deserialization of CompositorFrameMetadata.

Clients that didn't report LocalSurfaceId allocation time have been updated
to do so.

Change-Id: If4a3f744ec8894932c8b63a2850d76fca37a2300
Bug: 655231
Reviewed-on: https://chromium-review.googlesource.com/c/1327534
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611391}

- Add a equivalent_result_id field to search result;
- OmniboxResult uses stripped search url as its id;
- AnswerCardResult sets equivalent_result_id to a stripped search
  url that is used by search-what-user-typed omnibox result;
- SearchAnswerCardView use the equivalent_result_id to delete
  relevant result when the card is loaded;
- Remove the unused comparable_id from ChromeSearchResult;

Bug: 906890
Test: SearchResultAnswerCardViewTest.RemoveEquivalent
Change-Id: I16529724c8a86790ed1b5366095e2701118f9231
Reviewed-on: https://chromium-review.googlesource.com/c/1351714Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611390}

When the tab is brought to the foreground, preconnect to the
origin of the main frame request. This preconnection is done
at most once, and is helpful in case user clicks on a link.

Bug: 908725
Change-Id: Ic4c35c881e6b1a99bdccaac1bbfd585cfab8cb48
Reviewed-on: https://chromium-review.googlesource.com/c/1352490Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611389}

Show error message for URLs with invalid schemes, and remove leftover
function that was removed.

Bug: 906607
Change-Id: I6cd5a7267de3d439c1e54c01f846f03fd9247f62
Reviewed-on: https://chromium-review.googlesource.com/c/1343365Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611388}

Bug: 889247
Change-Id: I0c22f77bc254695ae0c9dcaa5cbf70c9cc5e0c04
Reviewed-on: https://chromium-review.googlesource.com/c/1311774
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611387}

Bug: 905386
Change-Id: I98ab459357dbb9d7043ad5fb5dd0b8084c3f7434
Reviewed-on: https://chromium-review.googlesource.com/c/1351784Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611386}

TBR=dmazzoni@chromium.org

Bug: 908942
Change-Id: I46cfb9b916f0d06421dfc159e7aee4e61e818589
Reviewed-on: https://chromium-review.googlesource.com/c/1352266
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611385}

Change-Id: I85838b853bffdc17edd1418a39a2dd6440aa63b7
Reviewed-on: https://chromium-review.googlesource.com/c/1342775Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Shubhie Panicker <panicker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611384}

There are two changes based on discussion with iOS Chrome team and the
security team:

1. Loop in iOS Chrome team on WebKit security bugs so they can monitor
   status, in case a workaround was landed in iOS Chrome for that bug.
2. Update the mechanism to notify Apple friends per request from
   ddkilzer@apple.com.

Change-Id: I5141a0af8374ee35b2953587bd647cab431600d7
Reviewed-on: https://chromium-review.googlesource.com/c/1337485Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Andrew Whalley <awhalley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611383}

This is one step in unifying LazyContextTaskQueue::PendingTask and LazyBackgroundTaskQueue::PendingTask.

Change-Id: Icf383aa3a3c91a7b9e371cef7a2ee24c8dd55c1d
Reviewed-on: https://chromium-review.googlesource.com/c/1347734
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611382}