- 21 Mar, 2018 40 commits
-
-
Tom Anderson authored
BUG=812950 Change-Id: Ic729b195d151480e2123fe490df8d6cce89a3198 Reviewed-on: https://chromium-review.googlesource.com/969333Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#544694}
-
Becca Hughes authored
Adds sort key handler for isHigh which will allow users to sort by "isHigh" when using chrome://media-engagement. BUG=792906 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I11db5ddf4843faca361eb9016535d582e6230fa5 Reviewed-on: https://chromium-review.googlesource.com/970584Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#544693}
-
Matthew Cary authored
Starting from Android O it is no longer possible to run any of the processes isolated. However, it is not necessary if SELinux is in permissive mode, which the orderfile generator sets (see tools/cygprofile/profile_android_startup.py in _SetUpDevice). This CL therefore removes the orderfile-specific changes to the android manifest for all builds. Bug: 758566 Change-Id: If3a8e0a3f0dfe81b034b4e0b080db53f661ef265 Reviewed-on: https://chromium-review.googlesource.com/970660Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#544692}
-
David Bokan authored
This prevents ScrollbarTestWithVirtualTimer from polluting global state for tests following it. Bug: 791742 Change-Id: Iae3440451833408a6a5bd24b3319b307cd6d3547 Reviewed-on: https://chromium-review.googlesource.com/969582 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#544691}
-
Florin Malita authored
virtual/gpu-rasterization/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html virtual/gpu/fast/canvas/canvas-composite-video-shadow.html virtual/gpu/fast/canvas/canvas-composite-video.html BUG=785931 TBR= Change-Id: I57a89b21d76cf69b1608b7cac79fc785a5e0b0de Reviewed-on: https://chromium-review.googlesource.com/971834Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#544690}
-
edchin authored
This CL updates the correct page scroll offset and toolbar configuration upon rotation. Bug: 804603 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I055ce3f63204393bdc8ced23f8ed3ec212b0eab8 Reviewed-on: https://chromium-review.googlesource.com/972666Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544689}
-
https://pdfium.googlesource.com/pdfium.git/+log/765d1ebe41de..9a635e812788 $ git log 765d1ebe4..9a635e812 --date=short --no-merges --format='%ad %ae %s' 2018-03-21 franzih Replace deprecated SetNamedPropertyHandler Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id4d62d88ed3bf6f07b3482259c400f982ad2b47c Reviewed-on: https://chromium-review.googlesource.com/973182 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544688}
-
Mark Cogan authored
In some cases, there may be no visible items in a grid, so the selected item will be nil, which is never a member of any collection. This CL updates the DCHECK condition in [GridTransitionLayout setSelectedItem:] to not trigger in this case. Bug: 822912 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I845355feee5f4af1d3443ff3d362aae45c05d9c9 Reviewed-on: https://chromium-review.googlesource.com/973121Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#544687}
-
Thiemo Nagel authored
Add per-request metrics for cookie age based on individual cookies (not just for the oldest cookie in the request) and split by {secure,non-secure} x {same-site,cross-site}. Bug: 749059 Change-Id: I0ef5fba95df226da05ea56537984264a0bce5941 Reviewed-on: https://chromium-review.googlesource.com/962601 Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Reviewed-by:Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#544686}
-
qi1988.yang authored
Fix the TODO(crbug.com/822317): Rename to Allowlist Bug:822317 Signed-off-by:
qi1988.yang <qi1988.yang@samsung.com> Change-Id: I1dd676fd5953b4cfc90e6b24d75ab9e3d69bc4da Reviewed-on: https://chromium-review.googlesource.com/968043Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Luna Lu <loonybear@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#544685}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/09e7152e..ad47b297 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I877790dfd8f5bb906ee2ccb903b1ef8a6d70a051 Reviewed-on: https://chromium-review.googlesource.com/972866Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#544684}
-
Alexander Potapenko authored
It has been flaky for too long. BUG=823484 TBR=nyquist@chromium.org,mamir@chromium.org Change-Id: Iee085516ea05d98d3fddd6620005818a822bc0ab Reviewed-on: https://chromium-review.googlesource.com/973223Reviewed-by:
Alexander Potapenko <glider@chromium.org> Commit-Queue: Alexander Potapenko <glider@chromium.org> Cr-Commit-Position: refs/heads/master@{#544683}
-
Becca Hughes authored
Add a 'AutoplayOriginsWhitelist' managed policy setting that allows autoplay on these origins (e.g. for internal enterprise websites). BUG=821379 Change-Id: I7bde18ef1c68741af5645f184c910b779002fdf7 Reviewed-on: https://chromium-review.googlesource.com/960666Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
Manuel Rego Casasnovas authored
We have been calling testGridTemplateColumnsRows() with and without arrays. Arrays are needed because the serialization of 2 tracks of the same size can be "100px 100px" or "repeat(2, 100px)". But in the rest of the cases we don't need an array, so we call the method with a single value. testGridTemplateColumnsRows() was not ready to support that, and it wasn't actually checking anything in that case. The patch modifies testing-utils.js, so it wraps values in an array when required. Now testGridTemplateColumnsRows() will be actually checking things. Change-Id: I7e360677c391df74dedb474922bf5c04247141c5 Reviewed-on: https://chromium-review.googlesource.com/973063Reviewed-by:
Sergio Villar <svillar@igalia.com> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#544681}
-
Olivier Robin authored
Material components marks some of its API as deprecated but still use them internally and recommends not treating those warning as error [1]. Disable the warnings when compiling material_components_ios. [1]: https://github.com/material-components/material-components-ios/tree/develop/howto/build-env Bug: 823767 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I377c971130372e80109e54cd29dd21def29067d2 Reviewed-on: https://chromium-review.googlesource.com/973002 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Stephen McGruer authored
This is a reland of c838bf40 The original CL contained two subtle bugs from a comparison of compositor_state_->start_time to start_time_. Previously if both were 'null' (represented by NaN), the comparison would still say they were inequal because NaN != NaN. The original CL 'fixed' those comparisons, but it turns out the behavior was intentional. This version of the CL restores the intentional behavior, adds a test for it, and documents it. Bug: 791086, 819591 Change-Id: I6587d028e66c6f6a9213b60f8d5f51b1dac3f899 Reviewed-on: https://chromium-review.googlesource.com/956280Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#544679}
-
Brian White authored
Bug: 810766 Change-Id: Ib2804c6218211e75ca2f98d6ddc345740e599d32 Reviewed-on: https://chromium-review.googlesource.com/969406Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#544678}
-
Alexander Potapenko authored
This reverts commit e944fadd. Reason for revert: https://crbug.com/653609 (tl;dr tests are still flaky) BUG=653609 TBR=yolandyan@chromium.org, dtrainor@chromium.org Original change's description: > Try runnining flaky download notification tests > > This flake might be caused by the test not properly set up, which > is fixed in the upstream CL. Please revert if the flake comes back > > Bug: 773346 > Change-Id: Ifae64c5e1cbf1319501f281162692d2dcfb22e07 > Reviewed-on: https://chromium-review.googlesource.com/894639 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Joy Ming <jming@chromium.org> > Commit-Queue: Yoland Yan <yolandyan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533430} TBR=dtrainor@chromium.org,yolandyan@chromium.org,jming@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 773346 Change-Id: Iab1f7b6d07dda46ae34c935604ac87c6f4901cb3 Reviewed-on: https://chromium-review.googlesource.com/973281Reviewed-by:
-
Fady Samuel authored
This reverts commit ab34a899. Reason for revert: This CL broke resize when surface sync is enabled (by default on M66+). Most quads seem to be dropped during resize. Original change's description: > Draw Occlusion: Enable Draw Occlusion by Default > > Draw Occlusion is turned on by default for 50% of Canary and Dev > users on Mac, Linux, ChromeOS and Windows in a Finch trial. It shows > that it can save over 1M pixels of overdraw for the top 1 percent > users and helped with overall DrawFrame time as well. Since it did > not cause any regression or any bug during the finch trial, this > patch is desired to turn it on by default. > > Bug: 672929 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel > Change-Id: I1952e38347207a9dbdd26e545dadfef00239c48e > Reviewed-on: https://chromium-review.googlesource.com/969412 > Reviewed-by: danakj <danakj@chromium.org> > Commit-Queue: Yi Xu <yiyix@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544500} TBR=danakj@chromium.org,yiyix@chromium.org Change-Id: I9cfbe739efdee24749be05a1f67ebb656a00b9d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 672929 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/973341Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#544676}
-
Yuhong Sha authored
NetworkChangeNotifier::IPAddressObserver is being deprecated. This CL migrates PepperNetworkMonitorHost to use NetworkChangeObserver instead of the deprecated IPAddressObserver. For more information, please see linked design doc in the bug below. Bug: 754695 Signed-off-by:
Yuhong Sha <yuhong.sha@samsung.com> Change-Id: I2b6e96a1b3a1fcc14edb096401041c28b3052ab1 Reviewed-on: https://chromium-review.googlesource.com/945186Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#544675}
-
https://skia.googlesource.com/skia.git/+log/ba7b7abda177..f3015114b51e $ git log ba7b7abda..f3015114b --date=short --no-merges --format='%ad %ae %s' 2018-03-21 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 427071ea3..b2c60b1a1 (2 commits) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I8c4b5c97e6114df05107b6acea1c2c4826b67a91 Reviewed-on: https://chromium-review.googlesource.com/972846Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544674}
-
Charles Harrison authored
This is the configuration that we want to ship, but we probably aren't ready to add it to the fieldtrial testing configs yet. Bug: 807640 Change-Id: Ic76af75e776466808e5c3578c242a4b26f317ad7 Reviewed-on: https://chromium-review.googlesource.com/972362Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#544673}
-
Elly Fong-Jones authored
Since BaseWindow already has Show and Hide, it seems fitting. This also lets ForcedReauthenticationDialogViewBrowserTest work with non-Views windows. TBR=karandeepb@chromium.org Bug: 817408 Change-Id: I7c49c687663cfa871c8c8175bc2d82f4e54790f7 Reviewed-on: https://chromium-review.googlesource.com/970903 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Alex Clarke authored
Bug: 791742 Change-Id: Idc2e85972893dddf7ae62eefe5e99859f96e9a14 Reviewed-on: https://chromium-review.googlesource.com/970473 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544671}
-
Jan Krcal authored
The CL takes one step in the direction to make ModelTypeSyncBridge an implementation detail of the datatype that is not exposed anywhere else than to the corresponding processor. This CL simplifies the initialization of the Processor and the Bridge and also pulls the factory function into the implementation (ClientTagBasedModelTypeProcessor). Bug: 807621 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I68d1c79551bc9c86c9b62138c9cc7dae52b23f21 Reviewed-on: https://chromium-review.googlesource.com/923982Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#544670}
-
Raphael Kubo da Costa authored
|index| was added in 6ca7f1c9 ("Limit the maximum length of frame unique names"), and it's never been used anywhere. Change-Id: I4403f58e4871e2011ccb5eddc8b596b9a209a1d3 Reviewed-on: https://chromium-review.googlesource.com/968248 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#544669}
-
Jan Wilken Dörrie authored
This change adds calls to PostTask to BluetoothAdapterMac's AddDiscoverySession(), so that its callbacks are run asynchronously. Bug: 823686 Change-Id: If480e4cec792d1aee38fb7586d010aa3df009ca6 Reviewed-on: https://chromium-review.googlesource.com/970645 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#544668}
-
Guido Urdaneta authored
This fixes the issue for audio devices which always report the same echoCancellation capabilities without permission checks. Bug: 823826 Change-Id: I2ac336760a843d1ff11f25a1a40fe22a57f356a2 Reviewed-on: https://chromium-review.googlesource.com/971482 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Chandan Padhi <c.padhi@samsung.com> Cr-Commit-Position: refs/heads/master@{#544667}
-
Thomas Tangl authored
This CL changes the activation of HoverButton to on mouse released instead of on mouse pressed, which was inherited from MenuButton. Also, unlike MenuButton, HoverButton should not be pressed on key up or down. This CL fixes this. Bug: 822147 Change-Id: Ia336a3f0e6b6f4f618c9cb2e6f4009d2fa0a826b Reviewed-on: https://chromium-review.googlesource.com/966286 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#544666}
-
Colin Blundell authored
The chrome.identity.onSigninChanged extension API event is defined as follows: "Fired when signin state changes for an account on the user's profile." (https://developer.chrome.com/apps/identity#event-onSignInChanged) The current browser-side implementation uses gaia::AccountTracker, which ignores events for secondary accounts if there is no primary account (i.e., syncing account) present. Thus, this browser-side implementation also fires events for secondary accounts only if there is a primary account present. However: (1) This behavior is not defined in the documented semantics above (2) In practice, this case has historically never been encountered by end users, as it has been impossible in desktop Chrome to have a secondary account without a primary account present. In this CL, we are removing browsertests that enforce this undocumented behavior (note that we ourselves added these browsertests merely to document the existing implementation's behavior before refactoring it). By removing the requirement that the implementation behave in a specific way in this case, we will ease the upcoming refactoring significantly. Note that post-project DICE, it will be possible for this case to be encountered by end users. In that world, it will actually be more sensible for events to fire for secondary accounts regardless of whether or not the user has designated a syncing account. This behavior is what will occur post the refactoring that will follow this CL. Bug: 729542 Change-Id: I02c1ffbcbfd732ba17056e939eb6f86ab3b26576 Reviewed-on: https://chromium-review.googlesource.com/966035Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#544665}
-
Alexander Potapenko authored
This reverts commit 8ce1863f. Reason for revert: speculative revert to fix CrOS MSan build, see crbug.com/824097. Original change's description: > Turn on native notifications by default for Chrome OS. > > They're already on by default for Mash. This makes Chrome use the mojo > ("native") interface for notifications even in non-Mash. > > Bug: 578868 > Change-Id: If1ee85e2136dc0480ccee9a57835b0ffb9b47b8b > Reviewed-on: https://chromium-review.googlesource.com/963518 > Commit-Queue: Evan Stade <estade@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544395} TBR=stevenjb@chromium.org,estade@chromium.org Change-Id: I044bbe505034ccb6da615163f6cbe74e7b164f6a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 578868 Reviewed-on: https://chromium-review.googlesource.com/973006Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 13dc6be4. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/14289 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=robertma No-Export: true Change-Id: Iea8f46da2b76d93b7e80c620609b52cd4b786242 Reviewed-on: https://chromium-review.googlesource.com/972863 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#544663}
-
Hans Wennborg authored
modetest is a new target added in #544442, but it was missing the dependency on //build/config:exe_and_shlib_deps, causing link failures in e.g. ASan builds. TBR=dnicoara,spang Bug: none Change-Id: I6f66333f89a0d5d828c417d7d4b9dc9c1b5e364a Reviewed-on: https://chromium-review.googlesource.com/972046Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#544662}
-
jdoerrie authored
This change clarifies the wording around the password saving and autofill toggles. Bug: 822465 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I91b31fe61cd0754239f7908e8c04c7e69b72f670 Reviewed-on: https://chromium-review.googlesource.com/970541 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#544661}
-
Olivier Robin authored
The previous implementation uses a temporary folder to fetch favicon then move it to the current icon folder. Should any favicon arrive out of a normal fetch operation, an empty temporary folder replace the normal one. As |favicon_provider fetchFaviconAttributesForURL:completion:| can call completion multiple times (once for the cached icon, once for the newly fetched one) , this implementation is not reliable. Change logic removing temporary folder. All icons are saved in the icon folder. When a new list is received, icons that correspond to no URL in the list are deleted. Whenever a new icon is received, it replaces the previous one. Bug: 818204 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iaf51c4336e55cbc9d1d0093faa6a70d470b66a4d Reviewed-on: https://chromium-review.googlesource.com/970472 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0ddc6a12..09e7152e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I2a63269af21221d14c6fc5444ff2e4ebde105d7c Reviewed-on: https://chromium-review.googlesource.com/972861Reviewed-by:
-
Zhuoyu Qian authored
This patch makes HistogramCategories, ContentSuggestionsService::State, RemoteSuggestion::ContentType, ReceivedMessageAction and TestType to enum class instead of plain C++ enum for better type safety. Bug: 710254 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: I40ff10809aa5e135b3ac9380ba54e97170eed02d Reviewed-on: https://chromium-review.googlesource.com/970049Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#544658}
-
stkhapugin@chromium.org authored
Fixes the layout of the omnibox when the input is short. Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib5fa70364d805b62d10b9e5e4a4a4b519c341759 Tested: iPhone, iPad, editing and not, rotating, in multitasking. Reviewed-on: https://chromium-review.googlesource.com/971421Reviewed-by:
-
Henrik Grunell authored
Bug: 819406 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9ec4028146c3a561f847a649848c5c16dde6e2a8 Reviewed-on: https://chromium-review.googlesource.com/951684Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#544656}
-
Gauthier Ambard authored
This CL creates the items to be used by the tools menu. It also creates the actions associated with the items. Bug: 804773 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id34c8fb33daceaa34276aa4c42cf39ce0d3a5eb1 Reviewed-on: https://chromium-review.googlesource.com/970583Reviewed-by:
-
