GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271348 0039d316-1c4b-4281-b951-d872f2087c98

The compiler file unconditionally depenended on the GCC version.

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/292703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271347 0039d316-1c4b-4281-b951-d872f2087c98

This patch fixes the regression, which is that the selection change by keyboard is not handled.

BUG=371715
TEST=manually tested

Review URL: https://codereview.chromium.org/279873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271346 0039d316-1c4b-4281-b951-d872f2087c98

> Build remoting for PNaCl
> 
> BUG=276739
> R=jamiewalch@chromium.org, rsleevi@chromium.org
> 
> Review URL: https://codereview.chromium.org/234023003

TBR=sergeyu@chromium.org

Review URL: https://codereview.chromium.org/285243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271344 0039d316-1c4b-4281-b951-d872f2087c98

BUG=276739
R=jamiewalch@chromium.org, rsleevi@chromium.org

Review URL: https://codereview.chromium.org/234023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271343 0039d316-1c4b-4281-b951-d872f2087c98

Part1: https://codereview.chromium.org/275103004/
Part2: https://codereview.chromium.org/287843002/

This change makes all remaining functions return status code instead of boolean.


BUG=372704
TEST=should pass all existing tests

Review URL: https://codereview.chromium.org/284123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271342 0039d316-1c4b-4281-b951-d872f2087c98

We are removing the dependency of ChromeOS on Chrome to send metrics.
If Chrome is not install on a system, we will provide a simple service that will
upload the metrics. This module will need to read the same logs and use the same
parsing mechanism as Chrome does now. The common serialization code will be kept
in base to make it accessible to both Chrome and ChromeOS.

The code in chrome/browser/chromeos/ will be migrated to use this in an other
CL.

BUG=chromium:358371
TEST=unittest included

Review URL: https://codereview.chromium.org/227873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271341 0039d316-1c4b-4281-b951-d872f2087c98

Allowed revoking of file permissions for apps that required file permissions.
This button appears in the 'expanded' section of the app info dialog under
'Files'.

BUG=371691

Review URL: https://codereview.chromium.org/278773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271340 0039d316-1c4b-4281-b951-d872f2087c98

BUG=28909
TEST=visual

Review URL: https://codereview.chromium.org/289903010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271339 0039d316-1c4b-4281-b951-d872f2087c98

This call was removed in crrev.com/132343006.

BUG=374473

Review URL: https://codereview.chromium.org/284303008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271338 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271332 0039d316-1c4b-4281-b951-d872f2087c98

Part1: https://codereview.chromium.org/275103004/

This change makes the following functions return status code instead of boolean.
- GetRegistrationsForOrigin()
- GetAllRegistrations()
- LazyOpen()
- ReadDatabaseVersion()

Other remaining functions will be fixed in the following CLs.


BUG=372704
TEST=should pass all existing tests

Review URL: https://codereview.chromium.org/287843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271329 0039d316-1c4b-4281-b951-d872f2087c98

This CL moves the creation of RenderFrameProxyHost earlier in the timeline of cross-process navigation. Instead of waiting until commit time, it creates it at the time SwapOut message is sent to the old RenderFrameHost.
It also creates the renderer-side RenderFrameProxy object. Since now both sides have proxies, when in swapped out state, RenderFrameHost and RenderFrame send their messages through the proxies. This both helps verify proxies exist and paves the way of removing the notion of swapping out frames.

BUG=357747

Review URL: https://codereview.chromium.org/281663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271325 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94925
TBR=willchan@chromium.org

Review URL: https://codereview.chromium.org/293503004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271324 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Revert of Elimate NOTIFICATION_GOOGLE_URL_UPDATED (https://codereview.chromium.org/294563002/)

Reason for revert:
Things cycled green before this revert became active on the testers.

Original issue's description:
> Revert of Elimate NOTIFICATION_GOOGLE_URL_UPDATED (https://codereview.chromium.org/284343003/)
> 
> Reason for revert:
> speculative, browser_tests stated timing out on all non-dbg win main waterfall test bots, with a message such as
> 
> 
> E:\b\depot_tools\python276_bin\python_slave.exe E:\b\build\scripts\slave\runisolatedtest.py --test_name browser_tests --builder_name "Win7 Tests (1)" --checkout_dir E:\b\build\slave\Win7_Tests__1_\build E:\b\build\slave\Win7_Tests__1_\build\src\out\Release\browser_tests.exe -- E:\b\build\slave\Win7_Tests__1_\build\src\out\Release\browser_tests.exe --brave-new-test-launcher --test-launcher-bot-mode --test-launcher-total-shards=3 --test-launcher-shard-index=0 --lib=browser_tests --gtest_print_time --gtest_output=xml:E:\b\build\slave\Win7_Tests__1_\build\gtest-results\browser_tests\browser_tests.xml --test-launcher-summary-output=c:\users\chrome~2\appdata\local\temp\tmpfbmzn9
> 
> E:\b\depot_tools\python276_bin\python_slave.exe E:\b\build\slave\Win7_Tests__1_\build\src\tools\swarming_client\isolate.py run --isolated E:\b\build\slave\Win7_Tests__1_\build\src\out\Release\browser_tests.isolated -v -- --no-cr --test-launcher-bot-mode --test-launcher-total-shards=3 --test-launcher-shard-index=0 --gtest_output=xml:E:\b\build\slave\Win7_Tests__1_\build\gtest-results\browser_tests\browser_tests.xml --test-launcher-summary-output=c:\users\chrome~2\appdata\local\temp\tmpfbmzn9
>  INFO         isolate(685): CompleteState.load_isolate(E:\b\build\slave\Win7_Tests__1_\build, E:\b\build\slave\Win7_Tests__1_\build\src\chrome\browser_tests.isolate, {}, {}, {'EXECUTABLE_SUFFIX': '.exe'}, False)
>  INFO         isolate(156): normalize_path_variables(E:\b\build\slave\Win7_Tests__1_\build, {}, E:\b\build\slave\Win7_Tests__1_\build\src\chrome)
>  INFO  isolate_format( 57): determine_root_dir(E:\b\build\slave\Win7_Tests__1_\build\src\chrome, 80 files) -> E:\b\build\slave\Win7_Tests__1_\build\src
>  INFO         isolate( 84): recreate_tree(outdir=E:\b\build\slave\Win7_Tests__1_\isolate-2014-05-18gqemnl, indir=E:\b\build\slave\Win7_Tests__1_\build\src, files=9443, action=4, as_hash=False)
>  INFO         isolate(1266): Running ['E:\\b\\depot_tools\\python276_bin\\python_slave.exe', '../testing/test_env.py', u'..\\out\\Release/browser_tests.exe', '--test-launcher-bot-mode', '--no-cr', '--test-launcher-bot-mode', '--test-launcher-total-shards=3', '--test-launcher-shard-index=0', '--gtest_output=xml:E:\\b\\build\\slave\\Win7_Tests__1_\\build\\gtest-results\\browser_tests\\browser_tests.xml', '--test-launcher-summary-output=c:\\users\\chrome~2\\appdata\\local\\temp\\tmpfbmzn9'], cwd=E:\b\build\slave\Win7_Tests__1_\isolate-2014-05-18gqemnl\chrome
> 
> command timed out: 600 seconds without output, attempting to kill
> program finished with exit code 1
> 
> Original issue's description:
> > Elimate NOTIFICATION_GOOGLE_URL_UPDATED
> > 
> > This CL moves the remaining client of the NOTIFICATION_GOOGLE_URL_UPDATED
> > notification to instead register a callback with GoogleURLTracker and
> > eliminates the notification. It also migrate the GoogleURLTracker unittest from
> > listening for the notification to listening for the callback.
> > 
> > BUG=373261,373237
> > TBR=thakis
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271313
> 
> TBR=pkasting@chromium.org,blundell@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=373261,373237
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271320

TBR=pkasting@chromium.org,blundell@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=373261,373237

Review URL: https://codereview.chromium.org/287233007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271323 0039d316-1c4b-4281-b951-d872f2087c98

Also add rsleevi to c/b/net/OWNERS

BUG=none

Review URL: https://codereview.chromium.org/291553004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271322 0039d316-1c4b-4281-b951-d872f2087c98

tcmalloc's cpu profiler code introduces several static initializers, and it's never
used on user machines.  So only include it in profiling=1 builds.
(The comment for profiling% in build/common.gypi even says that this
flag controls if cpuprofiler is used.)

BUG=94925
R=willchan@chromium.org

Review URL: https://codereview.chromium.org/287333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271321 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
speculative, browser_tests stated timing out on all non-dbg win main waterfall test bots, with a message such as


E:\b\depot_tools\python276_bin\python_slave.exe E:\b\build\scripts\slave\runisolatedtest.py --test_name browser_tests --builder_name "Win7 Tests (1)" --checkout_dir E:\b\build\slave\Win7_Tests__1_\build E:\b\build\slave\Win7_Tests__1_\build\src\out\Release\browser_tests.exe -- E:\b\build\slave\Win7_Tests__1_\build\src\out\Release\browser_tests.exe --brave-new-test-launcher --test-launcher-bot-mode --test-launcher-total-shards=3 --test-launcher-shard-index=0 --lib=browser_tests --gtest_print_time --gtest_output=xml:E:\b\build\slave\Win7_Tests__1_\build\gtest-results\browser_tests\browser_tests.xml --test-launcher-summary-output=c:\users\chrome~2\appdata\local\temp\tmpfbmzn9

E:\b\depot_tools\python276_bin\python_slave.exe E:\b\build\slave\Win7_Tests__1_\build\src\tools\swarming_client\isolate.py run --isolated E:\b\build\slave\Win7_Tests__1_\build\src\out\Release\browser_tests.isolated -v -- --no-cr --test-launcher-bot-mode --test-launcher-total-shards=3 --test-launcher-shard-index=0 --gtest_output=xml:E:\b\build\slave\Win7_Tests__1_\build\gtest-results\browser_tests\browser_tests.xml --test-launcher-summary-output=c:\users\chrome~2\appdata\local\temp\tmpfbmzn9
 INFO         isolate(685): CompleteState.load_isolate(E:\b\build\slave\Win7_Tests__1_\build, E:\b\build\slave\Win7_Tests__1_\build\src\chrome\browser_tests.isolate, {}, {}, {'EXECUTABLE_SUFFIX': '.exe'}, False)
 INFO         isolate(156): normalize_path_variables(E:\b\build\slave\Win7_Tests__1_\build, {}, E:\b\build\slave\Win7_Tests__1_\build\src\chrome)
 INFO  isolate_format( 57): determine_root_dir(E:\b\build\slave\Win7_Tests__1_\build\src\chrome, 80 files) -> E:\b\build\slave\Win7_Tests__1_\build\src
 INFO         isolate( 84): recreate_tree(outdir=E:\b\build\slave\Win7_Tests__1_\isolate-2014-05-18gqemnl, indir=E:\b\build\slave\Win7_Tests__1_\build\src, files=9443, action=4, as_hash=False)
 INFO         isolate(1266): Running ['E:\\b\\depot_tools\\python276_bin\\python_slave.exe', '../testing/test_env.py', u'..\\out\\Release/browser_tests.exe', '--test-launcher-bot-mode', '--no-cr', '--test-launcher-bot-mode', '--test-launcher-total-shards=3', '--test-launcher-shard-index=0', '--gtest_output=xml:E:\\b\\build\\slave\\Win7_Tests__1_\\build\\gtest-results\\browser_tests\\browser_tests.xml', '--test-launcher-summary-output=c:\\users\\chrome~2\\appdata\\local\\temp\\tmpfbmzn9'], cwd=E:\b\build\slave\Win7_Tests__1_\isolate-2014-05-18gqemnl\chrome

command timed out: 600 seconds without output, attempting to kill
program finished with exit code 1

Original issue's description:
> Elimate NOTIFICATION_GOOGLE_URL_UPDATED
> 
> This CL moves the remaining client of the NOTIFICATION_GOOGLE_URL_UPDATED
> notification to instead register a callback with GoogleURLTracker and
> eliminates the notification. It also migrate the GoogleURLTracker unittest from
> listening for the notification to listening for the callback.
> 
> BUG=373261,373237
> TBR=thakis
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271313

TBR=pkasting@chromium.org,blundell@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=373261,373237

Review URL: https://codereview.chromium.org/294563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271320 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271316 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174234:174238&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/295563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271315 0039d316-1c4b-4281-b951-d872f2087c98

This was replaced by the stub in apps/shell/browser/api/shell/ and the
chrome.shell.createWindow implementation.

BUG=none
TEST=compiles

Review URL: https://codereview.chromium.org/284393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271314 0039d316-1c4b-4281-b951-d872f2087c98

This CL moves the remaining client of the NOTIFICATION_GOOGLE_URL_UPDATED
notification to instead register a callback with GoogleURLTracker and
eliminates the notification. It also migrate the GoogleURLTracker unittest from
listening for the notification to listening for the callback.

BUG=373261,373237
TBR=thakis

Review URL: https://codereview.chromium.org/284343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271313 0039d316-1c4b-4281-b951-d872f2087c98

r271281 reverted the first r271249 for Win XP test failures:

http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/31239/steps/interactive_ui_tests/logs/stdio
[ RUN      ] ConstrainedWindowViewTest.ClosesOnEscape
[216:3316:0517/130516:ERROR:gpu_info_collector_win.cc(103)] Can't retrieve a valid WinSAT assessment.
c:\b\build\slave\cr-win-rel\build\src\chrome\browser\ui\views\constrained_window_views_browsertest.cc(206): error: Value of: dialog->GetWidget()
  Actual: 08C1F9C0
Expected: 0
Which is: NULL

This CL makes that test no-op on XP; I'll follow up in Issue 177482.

------------------------------------------------------------
Mimic [Desktop]NativeWidgetAura::OnWindowActivated.
Simplify OnNativeBlur calls and OnNative[Blur|Focus] impls.
(View focus changes update the TextInputClient as needed)
Rewrite and enable related ConstrainedWindowViewTests.

Print GetLastError() in SendInput() error case for tests.
(key presses get 5/ERROR_ACCESS_DENIED on locked desktops?)

BUG=368691, 170331, 177482, 163931
TEST=Automated tests; the focused Views change as expected between the browser, web contents, and web content modal dialogs (print preview, collected cookies, etc.).
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/285403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271312 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94925
TBR=willchan@chromium.org

Review URL: https://codereview.chromium.org/290843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271311 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271310 0039d316-1c4b-4281-b951-d872f2087c98

Lazily alloc/init the HPACK encoder/decoder. 

This lands server change 66441587 by hkhalil. 
https://codereview.chromium.org/292543002/ 

Cleanup: Remove redundant SpdyFramerTest string conversions. 

This lands server change 66517765 by hwright. 
https://codereview.chromium.org/283343003/ 

Adds reporting of total header block bytes to SpdyHeadersBlockParser. 

This lands server change 66798542 by birenroy. 
https://codereview.chromium.org/288313006/ 

Moves HpackEntry index computation into the container class HpackHeaderTable. 
No functional change. 

This lands server change 66892433 by birenroy. 
https://codereview.chromium.org/289843007/ 

Add handling + parsing for HTTP/2 ALTSVC frame. 
Also change frame type number and add an extra version check for BLOCKED frame. 

This lands server change 66925490 by mlavan. 
https://codereview.chromium.org/288373004/ 

Update SPDY4 flags for '12 specification draft 
Renumbers existing PAD_LOW, PAD_HIGH, and PRIORITY flags. Adds remaining 
PAD_LOW, PAD_HIGH, END_SEGMENT, and COMPRESSED flags. No behavior changes. 

This lands server change 67012065 by jgraettinger. 
https://codereview.chromium.org/284283006/ 

Accept and ignore PRIORITY frames in SPDY4+. 
Proper parsing/handling coming in a later CL. 

This lands server change 67153714 by hkhalil. 
https://codereview.chromium.org/286313002/ 

Accept SETTINGS_COMPRESS_DATA frames for HTTP2. 
Currently do nothing with them. 

This lands server change 67271146 by mlavan. 
https://codereview.chromium.org/286143011/ 

HTTP/2 framer support for reading headers with padding, and for segments. 
Header padding may be read, but serialization support is TODO. Segment 
boundaries are likewise accepted, but discarded. 

This lands server change 67282679 by jgraettinger. 
https://codereview.chromium.org/290203003/ 

BUG=345769

Review URL: https://codereview.chromium.org/290003006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271309 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174227:174234&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/287343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271308 0039d316-1c4b-4281-b951-d872f2087c98

DEFINE_string is used in 3 files in tcmalloc, but we only compile one of
these.  In this one file, the string is converted to char every time it's used,
and since the string is used after global destructors have run it needs to be
copied to a second string in a static initializer.

Instead of all that silliness, just let DEFINE_string define a const char*
(like it does in v8 or webrtc).

BUG=94925
R=willchan@chromium.org

Review URL: https://codereview.chromium.org/286953011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271307 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Only dispatch menu events if they have a valid target. (https://codereview.chromium.org/284903002/)

Reason for revert:
Made the asan bot red:

Direct leak of 664 byte(s) in 1 object(s) allocated from:
    #0 0x4b7c7b in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62
    #1 0x5a4ffc in RunMenu ui/views/controls/menu/menu_controller_unittest.cc:158
    #2 0x5a4ffc in views::MenuControllerTest_EventTargeter_Test::TestBody() ui/views/controls/menu/menu_controller_unittest.cc:218
    #3 0xb2b838 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045
    #4 0xb2b838 in testing::Test::Run() testing/gtest/src/gtest.cc:2061
    #5 0xb2d2c8 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237
    #6 0xb2e006 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344
    #7 0xb3e7fa in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065
    #8 0xb3de40 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045
    #9 0xb3de40 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697
    #10 0xafaee4 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231
    #11 0xafaee4 in base::TestSuite::Run() base/test/test_suite.cc:206
    #12 0xaf2656 in Run base/callback.h:401
    #13 0xaf2656 in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback\u003Cint ()> const&, int) base/test/launcher/unit_test_launcher.cc:494
    #14 0x83846a in main ui/views/run_all_unittests.cc:43
    #15 0x7ff88421176c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226



Probably easy to fix (and thus easy to reland), but from skimming the test it's not obvious to me what's supposed to free controller_. I'm guessing the second block in the new test just needs an explicit delete? (An "Owned by X" comment close to controller_ would've helped me)

Original issue's description:
> Only dispatch menu events if they have a valid target.
> 
> BUG=370162
> TEST=In touchview, open wrench menu and press a key (i.e. 'T'), nothing should happen.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271283

TBR=sadrul@chromium.org,flackr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=370162

Review URL: https://codereview.chromium.org/287233005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271306 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374558
TBR=jamescook@chromium.org

Review URL: https://codereview.chromium.org/293543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271302 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271299 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374558
TBR=jamescook@chromium.org

Review URL: https://codereview.chromium.org/293533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271297 0039d316-1c4b-4281-b951-d872f2087c98

TBR=caseq,yurys
BUG=374411

Review URL: https://codereview.chromium.org/288423004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271296 0039d316-1c4b-4281-b951-d872f2087c98

Currently, the lint warns against using the implicit default locale in String.format().
We should use the explicit locale instead of it.

BUG=327768

Review URL: https://codereview.chromium.org/287323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271295 0039d316-1c4b-4281-b951-d872f2087c98

This is happening when running the following command line:

$ gn gen out/Debug --args='is_component_build=true'
ERROR at //net/third_party/nss/ssl/BUILD.gn:122:18: Item not found
    configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
                     ^--------------------------------------------
You were trying to remove "//build/config/gcc:symbol_visibility_hidden"
from the list but it wasn't there.

BUG=None
TEST=above
R=brettw@chromium.org,wtc@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/285293009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271294 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372578
NOTRY=true

Review URL: https://codereview.chromium.org/272013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271293 0039d316-1c4b-4281-b951-d872f2087c98

This change is mostly mechanical. There were no functional changes made other than updating the paths to the new location.

This moves the translation files (xtb) out of ui/base/ to ui/strings/translations.

BUG=369881
TEST=build locally + green trybots, no functional changes.
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/269363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271292 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271291 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174203:174227&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/291733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271290 0039d316-1c4b-4281-b951-d872f2087c98

This file used to be in /tmp, but then the security folks
decided that /tmp was too dangerous and it got moved to
/var/log, but that's the wrong place for it.
The corresponding Chrome OS change has just been pushed at
https://chromium-review.googlesource.com/#/c/200091/

BUG=chromium:373833
TEST=none

Review URL: https://codereview.chromium.org/292433009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271289 0039d316-1c4b-4281-b951-d872f2087c98