- 28 Feb, 2019 40 commits
-
-
Adam Rice authored
https://chromium-review.googlesource.com/c/chromium/src/+/1481144 modified the declaration order of some of the WritableStream C++ implementation methods. Update the order of the definitions in the .cc files to match the declaration order. This CL only moves methods around and doesn't change their contents in any way. Bug: 902633 Change-Id: Ie4ef96014e8825dc57ecf03c2693ed9cc66347a7 Reviewed-on: https://chromium-review.googlesource.com/c/1481273 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#636344}
-
Peter Kasting authored
This will be used by drag and drop tests to take action on dragging over various views (typically, sending a mouse release event to end the drag). Bug: 923188 Change-Id: I40a3885cf8076f9e0a5f0490ca1eda3f32907086 Reviewed-on: https://chromium-review.googlesource.com/c/1493435 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#636343}
-
Nigel Tao authored
The "5" became "4" in https://codereview.chromium.org/1497193002/patch/60001/70050 Change-Id: I8be0f9580cf6262b5dcd8443d46a9e30d94cc8f0 Reviewed-on: https://chromium-review.googlesource.com/c/1491746Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#636342}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0d26ace5d6eb..bde49c93c205 Created with: gclient setdep -r src-internal@bde49c93c205 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:920652 TBR=mmoss@chromium.org Change-Id: I72202664ec3d534f4182669bff72f352a466c0db Reviewed-on: https://chromium-review.googlesource.com/c/1493102Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636341}
-
Esmael El-Moslimany authored
Bug: 928729 Change-Id: Ia5269a1f26742cd0a9d7fdf0fbe12aeccaafa65b Reviewed-on: https://chromium-review.googlesource.com/c/1455678Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#636340}
-
Darwin Huang authored
Bug: 936195 Change-Id: I14242f3174675616ee8d7867169eb023bcb27a94 Reviewed-on: https://chromium-review.googlesource.com/c/1493390 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#636339}
-
Darwin Huang authored
Update bash variables to use brace expansion, as it's more versatile and would make things more consistent if/when we use more fancy bash in the future. Reference: https://stackoverflow.com/questions/8748831/when-do-we-need-curly-braces-around-shell-variables Bug: 936694 Change-Id: Iafcefd60405ac9564a7b36af893fdb5d72e6893d Reviewed-on: https://chromium-review.googlesource.com/c/1493207 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Kunihiko Sakamoto authored
After this patch, SignedExchangeHandler causes a redirect fallback if Signed Exchange's Variants / Variant-Key headers don't match the browser request. Because the Accept-Language header is not set in SignedExchangeLoader::outer_request_ (it's set in the net/ layer), a list of accept languages is passed as another argument to SignedExchangeRequestMatcher. In order to observe updates of accept languages in the preferences, this makes PrefetchURLLoaderService a RendererPreferenceWatcher. Spec: https://wicg.github.io/webpackage/loading.html#request-matching Bug: 923229 Change-Id: Idd81c1c394dd70fdf91d475b7985422fee617740 Reviewed-on: https://chromium-review.googlesource.com/c/1465555 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#636337}
-
Eliot Courtney authored
This change fixes some errors in conversions between Screen and root window coordinates. It also makes the PIP window layout tests run for multiple display configurations. Test: unit test Bug: b/124689893 Change-Id: I764c48d951e36c2b4bcf1d4334bf0b36a4966e64 Reviewed-on: https://chromium-review.googlesource.com/c/1477463 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Mitsuru Oshima (Slow) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#636336}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/83fc5445e748..dfc0f3b7a757 git log 83fc5445e748..dfc0f3b7a757 --date=short --no-merges --format='%ad %ae %s' 2019-02-28 headlessclayton@gmail.com SpirvShader: Move emit() instructions to their own functions 2019-02-28 headlessclayton@gmail.com SpirvShader: Debug print human readable opcode names 2019-02-28 headlessclayton@gmail.com SpirvShader: Move type declaration out to its own function 2019-02-28 headlessclayton@gmail.com SpirvShader: Add support for DescriptorSet and Binding decorations 2019-02-28 headlessclayton@gmail.com SpirvShader: Add SIMD namespace. Created with: gclient setdep -r src/third_party/swiftshader@dfc0f3b7a757 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/126126820,chromium:b/126126820,chromium:b/126330097,chromium:b/126126820 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Id01d120f835a7f1c385e85577a3c9bb294cf031f Reviewed-on: https://chromium-review.googlesource.com/c/1492996Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636335}
-
Justin Cohen authored
Even behind a dispatch_once, WelcomeToChromeViewController can be displayed multiple times -- such as if the app is quit before accepting the tos, or by test when using experiment settings. Bug: 741003 Change-Id: I54c7ff333ba8c8b48ecb55dfc7fab649ed667243 Reviewed-on: https://chromium-review.googlesource.com/c/1489099 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#636334}
-
François Beaufort authored
Change-Id: I254c77fdfd239e4f7c5b8838d63e9fd3fc03db8c Reviewed-on: https://chromium-review.googlesource.com/c/1483080 Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#636333}
-
Eric Willigers authored
BUG=936687 Change-Id: I716ba65f524ad81a18ddfc372f3694b72b17495d Reviewed-on: https://chromium-review.googlesource.com/c/1493334Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#636332}
-
Tsuyoshi Horo authored
Bug: 935050 Change-Id: Ibca81508ba52743695d170281ff06670f83923e4 Reviewed-on: https://chromium-review.googlesource.com/c/1493338Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/827da8450d9c..ca6432e20dc4 git log 827da8450d9c..ca6432e20dc4 --date=short --no-merges --format='%ad %ae %s' 2019-02-27 dberris@chromium.org HistogramSets: Validate loop index 2019-02-27 perezju@chromium.org [Telemetry] Remove redundant tracing tests 2019-02-27 benjhayden@chromium.org Move v2spa_dev.yaml to dev.yaml 2019-02-27 thomasanderson@chromium.org Send SIGINT instead of SIGTERM to shutdown browser Created with: gclient setdep -r src/third_party/catapult@ca6432e20dc4 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:933096,chromium:933343,chromium:920454,chromium:628836,chromium:918193,chromium:429404 TBR=sullivan@chromium.org Change-Id: I9e76002135cc2403ed082e10abba409b0a02d199 Reviewed-on: https://chromium-review.googlesource.com/c/1492994Reviewed-by:
-
Lei Zhang authored
https://chromium.googlesource.com/breakpad/breakpad.git/+log/2853d21e2061..19a8433a604e $ git log 2853d21e2..19a8433a6 --date=short --no-merges --format='%ad %ae %s' 2019-02-27 thestig Replace TYPED_TEST_CASE with TYPED_TEST_SUITE. 2019-02-27 thestig Roll DEPS for googletest to 5ec7f0c4. Created with: roll-dep src/third_party/breakpad/breakpad TBR=mark@chromium.org BUG=936654 Change-Id: Idd3ae64122de3bd8b378cb12f9732b5d51545a5e Reviewed-on: https://chromium-review.googlesource.com/c/1493447Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#636329}
-
wutao authored
When Hotword is detected, it will show Assistant UI in Launcher. However, we call CloseAssistantUi which will interrupt with the voice interaction therefore the mic will be closed. This patch limits the condition that only close ui if not in kLauncherEmbeddedUi. We also need to correct the app list state when close the embedded ui, which is required because the app list state is global. Bug: 924624 Test: manual Change-Id: I9d5bfc3dbdfa504f06dca2fdde6163a3c46beebe Reviewed-on: https://chromium-review.googlesource.com/c/1487794 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#636328}
-
chrome://mobilesetupdpapad authored
Typo was accidentally introduced at crrev.com/c/1490852 Bug: 677338 Change-Id: I1ba3e587d58346de1a41dfe9520e0decf23f0e6f Reviewed-on: https://chromium-review.googlesource.com/c/1492776Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#636327}
-
Darwin Huang authored
- Add huangdarwin@ as Primary OWNER. - Add pwnall@ and dcheng@ as Secondary OWNERS where missing. - Add new OWNERS file. Change-Id: I557b619c280f6cc4825af3f67c2fc55693e6187e Reviewed-on: https://chromium-review.googlesource.com/c/1488063 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#636326}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/af5d1865b721..31ac9850ad0f git log af5d1865b721..31ac9850ad0f --date=short --no-merges --format='%ad %ae %s' 2019-02-28 shaobo.yan@intel.com Using split copy to fix metal issue on uploading texture from an unpacked buffer Created with: gclient setdep -r src/third_party/dawn@31ac9850ad0f The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I61f8744cb66887f2074ee4b631bf0a83ceb448df Reviewed-on: https://chromium-review.googlesource.com/c/1493099Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d29dda9d..5b980fbc Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I60f3180013b39a587950fd41e1609e5f3d0bb0df Reviewed-on: https://chromium-review.googlesource.com/c/1493442Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636324}
-
Kenichi Ishibashi authored
Bug: N/A Change-Id: I9b9b79631024c338c139600fb3b35d9fce6ed43c Reviewed-on: https://chromium-review.googlesource.com/c/1491745 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#636323}
-
Zhenyao Mo authored
They are only failing on the experimental bot, which is Mesa 18.0.5, and are passing on Mesa 17.1.4. Unfortunately our test expectations don't support driver versions. BUG=928530 TEST=Linux Intel experimental bot R=kbr@chromium.org Change-Id: I03f64ec71e2c59541a9b44257128f1ec22293ac5 Reviewed-on: https://chromium-review.googlesource.com/c/1493443 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#636322}
-
Dan Beam authored
R=dpapad@chromium.org BUG=926918 Change-Id: Ibd680a043eeface9bcf76c2c93cbb1c51a8437c1 Reviewed-on: https://chromium-review.googlesource.com/c/1493205 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
-
Joel Hockey authored
During the creation of Drive volume, it makes calls to window.webkitResolveFileSystemURL to synchronously get the entries for /root, /team_drives and /Computers. This change creates the Drive FS before creating the volume and populates the roots. Then it mocks webkitResolve... to provide resolution of the entries during the volume creation. Remove VolumeInfoImpl.restartResolveDisplayRootForTest and other unneeded calls to setup Drive. Change-Id: Ib70047a72fb1ccbb910245c6955e4726d8f2c538 Reviewed-on: https://chromium-review.googlesource.com/c/1490988 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#636320}
-
Min Qin authored
For download that are content Uri, we need to use contentResolver to delete them. Bug: 931021 Change-Id: I75e7b73b0cc65981359b8f1c330f74a8b795a89c Reviewed-on: https://chromium-review.googlesource.com/c/1480276 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#636319}
-
Yoichi Osato authored
This patch refactors the function to receive only const Text& rather than Node* because the function does only on text node. Bug: 868229 Change-Id: I153747752534f91a96305b72b2fce67ba3f39430 Reviewed-on: https://chromium-review.googlesource.com/c/1491163 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#636318}
-
Jonathan Metzman authored
https://chromium.googlesource.com/chromium/llvm-project/compiler-rt/lib/fuzzer.git/+log/538f9f9de3d6..e847d8a9b471 $ git log 538f9f9de..e847d8a9b --date=short --no-merges --format='%ad %ae %s' 2019-02-27 metzman [libFuzzer][Windows] Port fork mode to Windows 2019-02-26 vitalybuka [libFuzzer] fix missing close on opened file Created with: roll-dep src/third_party/libFuzzer/src Change-Id: I2291b2ee13aaab96eaa325f1fbdc3e2a066083de Reviewed-on: https://chromium-review.googlesource.com/c/1493098 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Auto-Submit: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#636317}
-
bsheedy authored
Adds the option for the Skia Gold GPU pixel tests to always report that the test passed even if the Skia Gold image comparison reported a failure. This is currently useful because we want to report a constant stream of data to Gold from the bots, but don't want the failures to be visible in Milo and confuse developers. Also enables this functionality on the Skia Gold-enabled pixel tests. Bug: 850107 Change-Id: I6bd4a1efc26de46048dc1acac9449b497ba39046 Reviewed-on: https://chromium-review.googlesource.com/c/1493436 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
Takumi Fujimoto authored
MediaRouterAction, the only component action, was removed here [1], so support for component actions can be removed from the toolbar. [1] https://chromium-review.googlesource.com/c/1395419 TBR-ing for removing an #include TBR=battre TBR-ing for removing ComponentActionDelegate which should've been owned by Devlin (and was before a rename) TBR=msw Bug: 934464 Change-Id: I9a225b0a753648e4a97a31beea8bb0f5baf667ba Reviewed-on: https://chromium-review.googlesource.com/c/1484632Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#636315}
-
Austin Eng authored
This is a reland of a42e652c. It corrects initialization of GLenums in the MultiDrawManager ResultData. Original change's description: > Add MultiDrawManager state invariants and unittests > > The gles2_cmd_decoder receives untrusted commands from the client and must > validate that the MultiDrawManager is always used with a valid sequence of > commands. > > Bug: 923282 > Change-Id: Ic61e8d61fce61431d7aa939261608f5f4f06792d > Reviewed-on: https://chromium-review.googlesource.com/c/1423422 > Commit-Queue: Austin Eng <enga@chromium.org> > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#630083} Bug: 923282 Change-Id: Iea05087d777e294a90f54623075b8ae4cbb1ed31 Reviewed-on: https://chromium-review.googlesource.com/c/1471216 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
-
Sergey Ulanov authored
This reverts commit c73d58a9. Reason for revert: the tests should pass now. Original change's description: > Disable blink_common_unittests on Fuchsia FYI bot > > Some tests are consistently failing > > TBR=jbudorick@chromium.org > > Bug: 934582, 928459 > Change-Id: I405cc5093bb0e28694e332b4a546133507ae94c7 > Reviewed-on: https://chromium-review.googlesource.com/c/1482116 > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634730} TBR=sergeyu@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 934582, 928459 Change-Id: I25a4c2f29db4bd6614374e48c2ff1464bf08a333 Reviewed-on: https://chromium-review.googlesource.com/c/1493258Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#636313}
-
Istiaque Ahmed authored
Update callsites to use the common method. Bug: None Test: Internal only change. Change-Id: I218eb99850f1fc8221626201ee425bb108b5c5ad Reviewed-on: https://chromium-review.googlesource.com/c/1491769 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#636312}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5b0a3cc05375..0d26ace5d6eb Created with: gclient setdep -r src-internal@0d26ace5d6eb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:935596 TBR=mmoss@chromium.org Change-Id: I7af622a20b36eea7b496bbea5f6ea163aee03106 Reviewed-on: https://chromium-review.googlesource.com/c/1492995Reviewed-by:
-
Sam Goto authored
Bug: 878979 Change-Id: I9e54c3a6282e33d8ff5013a894e926f0f1a7831b Reviewed-on: https://chromium-review.googlesource.com/c/1493073 Commit-Queue: Sam Goto <goto@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Sam Goto <goto@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#636310}
-
Noel Gordon authored
Option --debug allows visual inspection: add 2 second delay after each test for those who like to watch. No-try: true Bug: 935285 Change-Id: Iee8dd1c6edccacb867af31e73bd8ec972578f077 Reviewed-on: https://chromium-review.googlesource.com/c/1493337 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Nigel Tao authored
An upcoming commit will introduce an icon cache concept. BUG=826982 Change-Id: I5d2e7e176dc76dc4f0050abc2584607eb8ae2519 Reviewed-on: https://chromium-review.googlesource.com/c/1491058Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I6fbc60e4354ec4b4b05c6de41dce01f98022c0c0 Reviewed-on: https://chromium-review.googlesource.com/c/1492394Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#636307}
-
Nate Fischer authored
No change to logic. These tests are passing in a local run. Tested with 74.0.3718.0. R=jam@chromium.org Bug: 923938 Test: android_webview/tools/run_cts.py \ Test: -f=CookieManagerTest.testRemoveCookies \ Test: :WebViewTest.testSetDownloadListener Change-Id: Id7358b04cda1c43769add8e4a792560742cd08a0 Reviewed-on: https://chromium-review.googlesource.com/c/1489424 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#636306}
-
Alex Danilo authored
Change https://chromium-review.googlesource.com/c/chromium/src/+/1457884 removed the read only check on the current directory model which had the side effect of making the 'delete' button visible when choosing the 'Recent' folder in FilesApp. This CL fixes the regression by reinstating that check. Bug: 935345 Tests: Added testing for delete button in existing integration test. Change-Id: I8e89afd8918778057526671e42d8d776051bc6b9 Reviewed-on: https://chromium-review.googlesource.com/c/1491736Reviewed-by:
-
