- 21 Sep, 2020 40 commits
-
-
Tarun Bansal authored
This allows us to experiment with larger values for retry delay (e.g., value of 5 seconds would ensure that most of the preconnects finish by that time). Larger values would result in subsequent preconnects being not no-op. Change-Id: I0f35fce774ee752ede434806e7b23f3d1b724e4e Bug: 1130607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419556Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#808971}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I214994a5a3dc38959f60ac788bd41e3bcc0a1fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422212Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808970}
-
Haiyang Pan authored
* StartSurfaceLayoutTest#testShowOnlyOneTabSuggestionMessageCard_withSoftCleanup * StartSurfaceLayoutTest#testShowOnlyOneTabSuggestionMessageCard_withHardCleanup Bug: 1130621 Change-Id: I47b1fb54d491fb9973ad2d3be564011775d5505a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422438 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#808969}
-
Devlin Cronin authored
We can migrate extension-apps to web-apps, but should do so only if the user still has the extension-app installed (i.e., hasn't explicitly chosen to remove it previously). Unfortunately, this currently doesn't work - the preinstalled app will still be installed. Add a test for this (with the expectations flipped) so we have it for when it's fixed. Bug: 1130619 Change-Id: Iba936e0311eb24b4d6b6c7460c1790d895df6d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416946 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#808968}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202009210800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/uUASMSmV6UorqpFx9y7e18sqPKALaf9znxQWuHu6J5IC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/152286436,b/159892033 Tbr: help-app@grotations.appspotmail.com Change-Id: Iba980d91ef67e35c1b8e653f78f8300904f5eea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422207Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808967}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/cb4733136992..20186d1be641 2020-09-12 apodtele@gmail.com [raster] Improve the second pass (#58373). 2020-09-12 apodtele@gmail.com [raster] Tune SMART macro (#58352). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: Ib720a2c1b80af9393ba3824247228a2c8d11b22e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408622Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#808966}
-
Aleks Totic authored
Cells with percentage widths have either content or border box sizing. Handling of these is very inconsistent across browsers. This implements my current beliefs, and passes most test: - table-layout: auto ignores content vs border box. - table-layout: fixed distinguishes between content and border box These widths are resolved multiple times inside table layout algorithm: - computing grid_minmax - during table width redistribution Bug: 958381 Change-Id: I93eb167aa4ab9e144d4c44734c04ddbf775ecc2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416843 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#808965}
-
Jeffrey Cohen authored
https://hsv.googleplex.com/5219421888970752 Bug: 1129246 Change-Id: I7d1e16885b4e2b27edbd8fd498ac5f397f7b3bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417308Reviewed-by:
Travis Skare <skare@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#808964}
-
Etienne Pierre-Doray authored
This reverts commit dc3f7433. Reason for revert: AXPlatformNodeAuraLinuxTest.TestAtkPopupWindowActive failures on multiple Linux bots. Original change's description: > Reland: Enhances editing event intents by surfacing the input event type from Blink > > This patch was reverted because it was believed that it had caused > a failure on the Linux Ozone bots. > However, after running this patch through all the Ozone bots, no failures were detected. > > Original description: > > For every editing operation in Blink, this patch exposes to the browser and to automation clients > the "type" property of its input event from Blink. > > The enumeration listing event intents was too long, and it included > intents such as paste, type and replace. > To make using intents simpler, the list of commands is now trimmed down to a few > generic ones, such as insert, delete, format and SetSelection. > For intents attached to text changed and text attributes changed events, more information > is now provided in the intent's input_type member. > Values are provided by a new enumeration that uses the same members as the > W3C Input Events Specification. > This makes the information more detailed, accurate, as well as standard's based. > > The TextBoundary and MoveDirection enums were also modified to add the "kNone" member > so that event intents such as "kClearSelection" that have no boundary information and no directionality > need not use them. > > Finally, the equivalent struct that is used by WebKit for event intents on Mac was added, as well as a conversion function. > > AX-Relnotes: n/a. > > R=dmazzoni@chromium.org, aleventhal@chromium.org, dtseng@chromium.org, rsesek@chromium.org > > Bug: 989156 > Change-Id: I7bc25347e51fc18b730aab84ca01a9eddad8d54f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416459 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808849} TBR=dmazzoni@chromium.org,dtseng@chromium.org,nektar@chromium.org,rsesek@chromium.org,aleventhal@chromium.org Change-Id: I485a6a91e31c69c736b715ba1f570a43419d6160 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 989156, 1130690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422128Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#808963}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/023e1ac7bc8e..d41c2a6b8aeb 2020-09-21 tommi@webrtc.org Remove AsyncInvoker from WebRtcVideoChannel. 2020-09-21 tommi@webrtc.org Remove use of asyncinvoker from WebRtcVideoSendStream. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I88520a7047d4a738b754db325be645818e9a93e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422214Reviewed-by:
-
Lei Zhang authored
They do not have any references in the codebase. The flags are: autofill-reject-company-birthyear cct-target-translate-language enable-webrtc-new-encode-cpu-load-estimator improved-cookie-controls passive-mixed-content-warning Change-Id: I91022655d4659ce3cfec88308fc79156b894624d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415551Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Lei Zhang <thestig@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#808961}
-
Antonio Gomes authored
... and AudioRendererSinkCacheImpl Most files got moved to blink/renderer/modules/media/audio, but audio_device_factory.h. This one is used by Pepper and fuchsia code as well as //chromecast, so it has made it to the Blink public API at blink/public/web/modules/media/audio/. The 'Web' prefix will be added in a follow up. More details: 1/ AudioRendererMixerManager was a RenderThreadImpl variable, so a renderer process level scoped. As part of this CL, DEFINE_STATIC_LOCAL was used in the newly added GetInstance() method. All references to AudioRendererMixerManager were removed from //content. 2/ AudioRendererSinkCacheImpl::ObserveFrame was instantiated in RenderFrameImpl::Initialize. It used to inherit from RenderFrameObserver and deleted itself from its OnDestruct() override. As part of this CL, it now inherits from Supplement<LocalFrame> and get installed by ModulesInitializer::InstallSupplements(). It also inherits from ExecutionContextLifecycleObserver so its existing functionality is kept. 3/ @audio_renderer_sink_cache_test.cc, base::test::TestEnvironment was replaced by base::TestMockTimeTaskRunner. 4/ blink::Platform::GetHungRendererDelay() was added to supply content::kHungRendererDelay. BUG=787252 R=guidou@chromium.org, haraken@chromium.org TBR=spang@chromium.org Change-Id: I3ccfe526632ec5156cc346d6b868287fc45a0a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414551Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#808960}
-
Morten Stenshorne authored
Bug: 829028 Change-Id: I30d3d7349c97b497026141a242209051199c4c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421371Reviewed-by:
-
Sadrul Habib Chowdhury authored
Allow the LayerTreeHostImpl::SetVisible trace-event to be collected in traces, so that we can measure how long a page is visible for. BUG=1125152 Change-Id: I1be619aca28c88f834bbde989872be68e9f94e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422144 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#808958}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4559368cc4a1..8614e4925896 2020-09-21 johnstiles@google.com Replace VariableReference::copy_constant with clone(). 2020-09-21 bsalomon@google.com Stop building GL backend on Android Vulkan builders 2020-09-21 jvanverth@google.com Fix D3D non-dev release build. 2020-09-21 johnstiles@google.com Allow a BasicBlock to be dumped, outside the CFG. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: csmartdalton@google.com Change-Id: I672ee4ade5c45465a096856f34217d7d9aa38c71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422209Reviewed-by:
-
Luke Sorenson authored
Before this fix, we were unable to successfully restart the Media Perception Service and re-connect over Mojo IPC. Bug: 1129628 Test: Verified on-device this fixes the bug. Change-Id: I3eb60d99320c41ff2aef357ed9ae83a18d9d715a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422183Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Luke Sorenson <lasoren@chromium.org> Commit-Queue: Luke Sorenson <lasoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#808956}
-
David Dorwin authored
Also breaks out the multiple cases in the *UserAgent tests into individual WebEngineIntegrationUserAgentTests. Change-Id: I4aab782d55ff327456d6a2b638739b0c4ec86204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421655 Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#808955}
-
Tim Volodine authored
The BundleLanguageTest#testWebLayerString and BundleLanguageTest#testSharedString tests are failing on android-pie-x86-rel. BUG=1130660 TBR=cduvall@chromium.org Change-Id: I6720dddfef3ba936e91685cbb799bda5d297b669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421656Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#808954}
-
Andrew Grieve authored
This reverts commit cac6380f. Reason for reland: Fixed typo in .patch file. Original change's description: > Revert "SuperSize: Update to newer emscripten version" > > This reverts commit be818705. > > Reason for revert: Patch was corrupt. > > Original change's description: > > SuperSize: Update to newer emscripten version > > > > * Fixes an issue with an unrecognized compiler flag. > > * Could not get -flto to work and no good error message from the > > failure. Left a TODO to re-enable it. > > > > Bug: None > > Change-Id: I683119e43e767ff5b228706bc6b6f68c2282f7a7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418993 > > Reviewed-by: Samuel Huang <huangs@chromium.org> > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#808898} > > TBR=huangs@chromium.org,agrieve@chromium.org > > Change-Id: I8cf548eb57ed34b4fd9722ba2843f645c36c3b46 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: None > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421871 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808944} TBR=huangs@chromium.org,agrieve@chromium.org # Not skipping CQ checks because this is a reland. Bug: None Change-Id: Iff705f1de426b219e274d90236b8f8d1c7984550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422166Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#808953}
-
Kyle Horimoto authored
This fixes two issues with tablet navigation button settings: (1) This setting is now shown on all devices with tablet capabilities, even if tablet mode is not currently active. Previously, it was only shown when tablet mode was active. (2) The settings search result for this toggle is now only shown on tablet-capable devices. Previously, it was always shown, even in situations where the setting was not available. This CL also moves the location of the IsBoardTypeMarkedAsTabletCapable() function to //ash/public where it can be accessed by settings. Additionally, it removes accessibility_handler_unittest.cc, since the only thing tested in this file was the previous functionality which would only show tablet navigation button settings when tablet mode was active. Bug: 1111564 Change-Id: Iefa982ab3a28fae6ad40fba827cfd658c09fe98b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420771Reviewed-by:James Cook <jamescook@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#808952}
-
Raymond Toy authored
The threshold for the vector math Zvmul test is a little too tight for mac-arm64. Hence update the threshold from 1.5e-5 to 1.9e-5 but only on mac-arm64. We keep the threshold the same for other mac platforms so we can catch any regressions there. Bug: 1128434 Change-Id: Ib51fa772e27378fb8022e19790ecdfcf1e1a6e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419539Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#808951}
-
Ehimare Okoyomon authored
Bug: 1077766 Change-Id: Ia4ff90e3aedaa1254cedb3b788d506650157907a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421893Reviewed-by:
-
Morten Stenshorne authored
Block-end border and padding are added as part of layout, but if the box is too tall to fit, we'll remove it again. FinishFragmentation() already handles that, but we need to do something similar when column layout is interrupted by a spanner, since block-end padding and border of the spanner's ancestors will be placed after the spanner. Without this fix, we'd also make room for the border/padding before the spanner. Bug: 829028 Change-Id: I85e9dd812bbe96df16ae6ab729f809797a30f905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421495Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a53556930038..71b08cd277f4 2020-09-21 jacktfranklin@chromium.org Fix non-primitive nullable handling in bridges 2020-09-21 tvanderlippe@chromium.org Typecheck network/BlockedURLsPane.js with TypeScript 2020-09-21 changhaohan@chromium.org Enable CSS Grid experiment by default 2020-09-21 jacktfranklin@chromium.org Revert "Fix ElementsBreadcrumbs mutation bugs." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1047356,chromium:1129881 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I416077de0b2ea8debea309505dbf7075606fba47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422208Reviewed-by:
-
Dan H authored
This reverts commit 0048fa4a. Reason for revert: Previous CL was for merging to stable branch only Original change's description: > Disable Feed v2 build flag on stable channel > > Bug: 1129504 > Change-Id: Icb74a2b914c65ba2cfda14409f0d7a7642d132f4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417049 > Auto-Submit: Carlos Knippschild <carlosk@chromium.org> > Reviewed-by: Justin DeWitt <dewittj@chromium.org> > Commit-Queue: Justin DeWitt <dewittj@chromium.org> > Commit-Queue: Carlos Knippschild <carlosk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808013} TBR=dewittj@chromium.org,carlosk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1129504 Change-Id: I119b1221f95d79901af4ae8d6a0fc1259aaf0b26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422298Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#808947}
-
Tim Volodine authored
In particular the test is failing on some Android P bots (timeout). BUG=1130617 TBR=aluo@chromium.org Change-Id: I315c7876e34d180b29b7b69ff94297debda600cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421815Reviewed-by:
-
Alice Wang authored
This CL adds render tests for the screen when user tapped the continue button on the sign-in auth error screen. Bug: 1122942 Change-Id: Ie6e534054a71bb89b98998ecba52623a38e183a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421490Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#808945}
-
Andrew Grieve authored
This reverts commit be818705. Reason for revert: Patch was corrupt. Original change's description: > SuperSize: Update to newer emscripten version > > * Fixes an issue with an unrecognized compiler flag. > * Could not get -flto to work and no good error message from the > failure. Left a TODO to re-enable it. > > Bug: None > Change-Id: I683119e43e767ff5b228706bc6b6f68c2282f7a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418993 > Reviewed-by: Samuel Huang <huangs@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808898} TBR=huangs@chromium.org,agrieve@chromium.org Change-Id: I8cf548eb57ed34b4fd9722ba2843f645c36c3b46 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421871Reviewed-by:
-
Gil Dekel authored
Split Partially Occluded Quads has been enabled by default since 83.0.4103.0 without regressions. Cleaning up flag since there is no plan of removing this feature anytime soon. Bug: 1129155 Change-Id: I45813471ef4cce77fa0bb4f4fd0c18009a775eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422240Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Gil Dekel <gildekel@chromium.org> Cr-Commit-Position: refs/heads/master@{#808943}
-
Benoit Lize authored
This was enabled only when DCHECK_IS_ON() to assess stability. Enable it for regular builds as well to assess performance. Bug: 1125999, 1061437 Change-Id: Ia38c81c95ed0e6ba3fab1754cb4809a08f1fea01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421651Reviewed-by:
-
Ravjit Singh Uppal authored
Bug: 1127074 Change-Id: I99834a4c5efb2dd38ffea9e28f83c8d0592ca9c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405572Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Cr-Commit-Position: refs/heads/master@{#808941}
-
George Burgess IV authored
It seems that this constructor call was intended to be used as a scope guard. In order for that to happen, there has to be a variable name here. Bug: 1130379 Change-Id: I3c5f1ec85cefcfebc6d40ca82488423edb8e7ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420916Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#808940}
-
Collin Baker authored
Bug: 1055150 Change-Id: Iee3d318ff90362a2cc29754b9a118a2a60d5a4c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418809 Commit-Queue: Collin Baker <collinbaker@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#808939}
-
Nela Kaczmarek authored
This change adds LookupAffiliationByHashPrefixRequest and LookupAffiliationByHashPrefixResponse to support requesting affiliations by sending only hash prefixes of facets. It will be used in AffiliationServiceImpl to support users requiring more privacy. Bug: 1108279 Change-Id: I69c6d55520d478f276b76b61a47d89d6d14f5958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421493Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Cr-Commit-Position: refs/heads/master@{#808938}
-
Andrew Grieve authored
Bug: 1130584 Change-Id: I0ad7e220c67f7af029f3e1a4656a832d124b4b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422119 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#808937}
-
David Tseng authored
This change is somewhat of a workaround to shield Chrome from any issues contained within the underlying tts engine. Issues: - the extension system evicts extensions that don't explicitly fire an Activity as defined by extensions/browser/activity.h - audio playback isn't plumbed through as an activity - engines like Espeak work even for long utterances that hit the eviction time, because they trigger the extension api activity via word callbacks - the Google tts engine currently is buggy for some sentences in emitting callbacks All interleavings of increment/decrements were considered: - engine loads, enable ChromeVox/STS, disable ChromeVox/STS - enable ChromeVox, engine loads, enable STS, disable STS/ChromeVox - enable both STS and ChromeVox, engine loads, disable STS/ChromeVox In all cases, the keep alive count will be 0 at the end. R=dmazzoni@chromium.org Fixed: 1128093 Change-Id: I92b3fc32cd777961e4fbba40c5891c49943b9645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416571 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#808936}
-
Benoit Lize authored
Bug: 998048 Change-Id: Ida68e21565a44fee0dc22051892eb10c4c806a45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421890Reviewed-by:
-
James Vecore authored
Previously discovery manager assumed transfer updates would only come after a share target was selected. This is not true and can happen when registering the foreground surface if an existing transfer is in progress or recently completed. Fixed: 1128188 Change-Id: I5de66fd895117e37d8f45c76a346e6edabdc564d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419662 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#808934}
-
Haiyang Pan authored
The graph http://shortn/_OkQ1Rvzvk9 shows the capacity is over OK, only a little bit tight on 09/19. Let's see how it goes after increasing to 60. Bug: 1111436 Change-Id: I65eebf773e9e0ae047ebff7fd0920b7214041483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422261 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#808933}
-
David Bienvenu authored
Change-Id: I6875db3512929aa5671f199acebdd9bbb1d3fefa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422241 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#808932}
-
