GitLab

Previously, we were not setting the color of content setting icons.
In the pre-Material world, this just worked well enough that no one
noticed apparently.

After this CL, the content setting icons will have the same color set
as the other page action icons.

Bug: 876458
Change-Id: Ifec3601478ceb3e65ac999806558416dfe076401
Reviewed-on: https://chromium-review.googlesource.com/1195721Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587280}

A stack trace showed a lot of cpu time spent in FindNodeWithChildTreeId,
which is called from GetParentNodeFromParentTree.

The context in which this is supposed to be triggered is when
calling GetParent() on the root of a child frame the first time.
Previously the strategy was to search the whole parent frame
for the node that has the child frame as its child tree ID,
and then cache that node for the next call.

If the node wasn't found, FindNodeWithChildTreeId would have
been called every single time.

Instead, have AXTree keep track of a map between each unique
child tree ID and nodes that reference that child tree ID. Then
BrowserAccessibilityManager can just query it directly with no
tree search required, whether it's found or not.

Bug: 876315
Change-Id: Iad432f1f43e1e65d1123c231d85f9cd42b1da52f
Reviewed-on: https://chromium-review.googlesource.com/1186191
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587279}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: I0da632224fb6ab6f7ae3887efa33f55762110def
Reviewed-on: https://chromium-review.googlesource.com/1195551Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587278}

This cl changes the button text displayed in the omnibox
for local files. "File" text is added to the chip and
clicking on the button will display the text "You're
viewing a file".

A follow-up cl will elide file:// from the omnibox display.

Screenshot:
https://drive.google.com/file/d/1eiFK6FfonGqihqYCheFZmDtI-Qv8UPPZ/view?usp=sharing

Bug: 818528
Change-Id: Ideb4c8aaefbe50afd2cdfd3236d1c72809d04fe3
Reviewed-on: https://chromium-review.googlesource.com/1187132
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587277}

The ContextualSearchObserver code sometimes sends a Show without any
Hide.  This is because we're sending the Show notification when the
selection changes, instead of when the panel is shown.  This means that
features that suppress showing the panel, like Smart Selection, may
interfere with this notification.

This CL just clarifies when the messages are sent and notes a problem
with test coverage (linking to this bug).

BUG=878006

Change-Id: I7f9b618b84f1633620490fd15f385796f947dfba
Reviewed-on: https://chromium-review.googlesource.com/1192324Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587276}

Previously, if the user was signed-in but opted out of syncing (so no promo would be shown), after saving a card locally, the icon would highlight after the animation ended even if no bubble was showing. This change fixes that.

Bug: 855186
Change-Id: I8aca67c572dafb91f37bcf752a813d3bbcfe14e4
Reviewed-on: https://chromium-review.googlesource.com/1192584Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#587275}

All public users intend to set "ignore events" on an entire
page, but the API was on widget and so it was only ever set
on the top-level widget. Move it to WebContents to allow it
to have the desired effect.

BUG=863582, 725830

Change-Id: I435b9f93160d0d77ad1aa0919757a4acd933768e
Reviewed-on: https://chromium-review.googlesource.com/1194484Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587274}

Added a readme to the chromedriver/log_replay/ directory with usage
and maintenance info for the log replay system.

Bug: chromedriver:2501
Change-Id: I0bef83149cd6be6dd0978d81f2f79600f96cde77
Reviewed-on: https://chromium-review.googlesource.com/1194573
Commit-Queue: Cole Winstanley <cwinstanley@google.com>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587273}

Because of how filters interact with layout and paint (bounds dependency
and filter caching et.c), we need to trigger layout (for bounds) and
paint (for caching) when 'filter' changes. (A 'none' <=> <something>
transition will trigger layout in general, but not a change from one
filter to another.)

Bug: 878591
Change-Id: I8bfad033f962bdfcb5000052ee07db7771428e3d
Reviewed-on: https://chromium-review.googlesource.com/1195485Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#587272}

Not having an available surface to show in SurfaceAggregator is no longer
really an error state because the start of a SurfaceRange is optional.

This CL removes the displaying of a magenta solid color in that case.

Bug: 672962
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Iadb58ac9a0791071df59702afbfe3dd373d9ef62
Reviewed-on: https://chromium-review.googlesource.com/1194959Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587271}

This CL changes the loading panel mask backgrounds to have their images
defined in the main UA CSS instead of the inserted stylesheet. This
fixes an issue where the loading spinner was broken by content security
policy.

Bug: 878415
Change-Id: Iaa78fbe810fe900d3abe39d03302250b7b9fade7
Reviewed-on: https://chromium-review.googlesource.com/1195719Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587270}

R=gogerald@chromium.org

Bug: 806868
Change-Id: Ifaf32d8f82d4c15d1cfd3a6464afcae37827320a
Reviewed-on: https://chromium-review.googlesource.com/1193443Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587269}

1. With use-zoom-for-dsf enabled, root_scroll_offset from metadata
is in physical pixel, it needs to be convert to dip.
2. In blink, the hit test is expecting document point, but x and y
from the devtool front end is in CSS scale. We need to apply the
PageZoomFactor before doing the hit test.

Bug: 876403
Change-Id: I6cd2f7ecd4d908a6aa986c4d1dfdab7e332355cb
Reviewed-on: https://chromium-review.googlesource.com/1183968Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587268}

Conversation starters are now guarded by a feature flag, and each
chip is individually guarded by a feature param.

To test via commandline override on gLinux, use:
https://paste.googleplex.com/4937132372131840

Bug: b:113278721
Change-Id: I2aa9c8bfbd639caaceeb1f7af102d0c1eb054b5f
Reviewed-on: https://chromium-review.googlesource.com/1192220
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587267}

Right now this function either returns the actual allowed touch action
when it has value, or return Auto when it has no value. It is written
this way to temporary fix a crash. Now that the crash is properly fixed,
we can return the actual allowed touch action.

TBR=dtapuska@chromium.org

Bug: 851644
Change-Id: I6ae91f5f26c327377fbb0d0cbbfede925ac59680
Reviewed-on: https://chromium-review.googlesource.com/1189136
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587266}

Also adds the generated output file directory as include directory to
nocompile build targets.

Bug: 878356, 867421
Change-Id: I51a8433a1e5295949f67aaea188444f81c394100
Reviewed-on: https://chromium-review.googlesource.com/1194224Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587265}

It seems some drivers fail to handle that gracefully, so let's always clamp
to be on the safe side.

BUG=877874
TEST=test case in the bug, gpu_unittests
R=kbr@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I6d93cb9389ea70525df4604112223604577582a2
Reviewed-on: https://chromium-review.googlesource.com/1194994Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587264}

https://chromium.googlesource.com/webm/libvpx.git/+log/dbcb89be244e..5de95cb09ff6

$ git log dbcb89be2..5de95cb09 --date=short --no-merges --format='%ad %ae %s'
2018-08-27 jingning Rework enc/dec mismatch detection
2018-08-27 jianj vp9: Fix ref frame update in denoiser in bypass mode.
2018-08-27 marpan vp9-svc: Change default pattern for bypass mode
2018-08-23 huisu Revert "Prevent double application of min rate in two pass."
2018-08-22 jingning Sync prev_frame/last_show_frame update with decoder
2018-08-22 jingning Skip update prev_mi frame in show_existing_frame mode
2018-08-22 jingning Refactor encoder frame count update
2018-08-21 huisu Rework the ref_frame_skip_mask feature in RDO
2018-08-10 jianj SVC: extend api to specify temporal id for each spatial layers.

Created with:
  roll-dep src/third_party/libvpx/source/libvpx
R=johannkoenig@google.com
BUG=b/112292577

Change-Id: Iba79bbb9ab8a281bf4c586a189369fb886112512
Reviewed-on: https://chromium-review.googlesource.com/1195706Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Jerome Jiang <jianj@google.com>
Cr-Commit-Position: refs/heads/master@{#587263}

Right now when the browser receives the OnHasTouchEventHandlers IPC
message, it resets the |scrolling_touch_action_| as long as both of
these are true:
1. it is not in the middle of a gesture sequence.
2. the IPC message indicates that there is a touch event handler.

Consider the following case: we have received the touch start ACK from
the renderer, which assgins a value to |allowed_touch_action_|, then
before GestureTapDown comes, JS removes the touch event listener and
re-added it. In this case, it is not in the middle of a gesture
sequence beause GestureTapDown has not arrived yet, so our code
resets both the |allowed_touch_action_| and the
|scrolling_touch_action_|. Later on when GestureScrollBegin comes,
the browser crashes.

This CL fixes the issue by adding a |active_touch_in_progress_|
member variable. It is true when we receive a touch sequence
started, and false at touch end. When we receive the
OnHasTouchEventHandler(true), we should reset the touch actions
only when there is no active touch and no gesture sequence.

TBR=dtapuska@chromium.org

Bug: 851644
Change-Id: I269d77dff0ae0e577a55734550cc639363267e50
Reviewed-on: https://chromium-review.googlesource.com/1195146
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587262}

BUG=
R=mthiesse

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I4e47915e63ad0485edaf7e252d497fc939f86367
Reviewed-on: https://chromium-review.googlesource.com/1195842Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587261}

This is a speculative fix for a few flaky tests.

For some reason some tests fail on some KitKat devices, probably
due to speed issues with timeouts to prevent double-tap recognition.

This CL just uses a somewhat longer timeout as a workaround.

BUG=878517

Change-Id: I53a8ec93de6eab075a00c89d7edb0f3f15d8b378
Reviewed-on: https://chromium-review.googlesource.com/1194828Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587260}

In chrome VR, we could get GestureScrollBegin without receiving a
GestureTapDown. In this case we should set touch action to Auto.

As a result of this, we need to add a TapDown in many unit tests
because they send GSB without TapDown.

TBR=dtapuska@chromium.org

Bug: 851644
Change-Id: Ifa04259b68524e96b0a4faa2f8e1d0bd9b35c81c
Reviewed-on: https://chromium-review.googlesource.com/1195649
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587259}

This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/profile_resetter.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=engedy@chromium.org

Bug: 874080
Change-Id: Ib5ad110d3469e8813b0df121d88cfe2170de26ac
Reviewed-on: https://chromium-review.googlesource.com/1191131Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587258}

Currently FidoCableDiscovery::transport() returns
FidoTransportProtocol::kBluetoothLowEnergy. Fix this so that it returns
FidoTransportProtocol::kCloudAssistedBluetoothLowEnergy instead.

Bug: 877344
Change-Id: I870e57b747738b5a2608e3c18b71ca46c22818f6
Reviewed-on: https://chromium-review.googlesource.com/1195120
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587257}

SigninManager is being deprecated. Long live IdentityManager.

IdentityManager recently added ClearPrimaryAccount() (aka SignOut())
which unblocks migration of this class and its tests.

A follow up CL will remove the SigninWrapper used to initialize
ProfileSyncService. We now just need the IdentityManager.

Bug: 809031
Change-Id: If7fd07ea1c53ea1ed24daf7ee70b27c67cd7e20c
Reviewed-on: https://chromium-review.googlesource.com/1175911
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587256}

https://chromium.googlesource.com/catapult.git/+log/6443c8dade1c..7dfd811ec106


git log 6443c8dade1c..7dfd811ec106 --date=short --no-merges --format='%ad %ae %s'
2018-08-29 pasko@chromium.org devil: Replace mock asserts with the working ones


Created with:
  gclient setdep -r src/third_party/catapult@7dfd811ec106

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:878777
TBR=sullivan@chromium.org

Change-Id: I2e1436b377593c4c838a80acb6b1eeb5e5e1c66c
Reviewed-on: https://chromium-review.googlesource.com/1195054Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#587255}

This CL migrates the logic of handling connection messages from
clients. The logic was moved from MRP to message handler to
separate all message handling from MRP.

Bug: 711860
Change-Id: I009deda26ee51a9be1d5ea0a31af6af9d3ea6605
Reviewed-on: https://chromium-review.googlesource.com/1194968Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587254}

 - PauseDiscovery on Connect to paired device
 - UnpauseDiscovery when connection is over

Bug: chromium:523176
Test: Manual test to connect paired devices
Change-Id: I7de1e410611b54c7911ef405421789e710997d78
Reviewed-on: https://chromium-review.googlesource.com/1185630
Commit-Queue: Rahul Chaturvedi <rkc@chromium.org>
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587253}

Previously runnables would destroy themselves after running.
This caused leaks when executors were shutdown with unrun
runnables because they wouldn't get destroyed. With this
change executors are responsible for destroying runnables,
whether they are run or not. For internal runnables (the
ones that inherit from Cronet_Runnable) the destroy call
properly invokes virtual destructors.

This is the first of three CLs to fix runnable destruction,
the other two being:
1. when DCHECKs are enabled verify that embedder's executors
   do in fact destroy the runnables.
2. disallow user created runnables as they have no way of
   catching destruction and properly cleaning up.

Bug: 812334
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ifcdb96bd7991b9a5757ff65b150ffd2a3d5f73fe
Reviewed-on: https://chromium-review.googlesource.com/1193966
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587252}

This patch removes one passing paint containment test expectation.
It also fixed an expectation in one other that has an incorrect
word s/digit/number/

R=chrishtr@chromium.org

Change-Id: I756dc10ff49d7b3ef762d9d9733b566501cb2f5e
Reviewed-on: https://chromium-review.googlesource.com/1195678Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587251}

Flips the fieldtrial test config to enable OOP-D for Android bots.

We've worked out all the remaining test failures issues and would like
to turn this on to collect additional data from the perf bots, as well
as to ensure stability while we run our finch trial.

Change-Id: I8b896753b6c64aefa36d355c35c40241ba4f88fd
Reviewed-on: https://chromium-review.googlesource.com/1180574
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587250}

This is a follow-up to:
https://chromium-review.googlesource.com/c/chromium/src/+/1149994

Bug: 785242
Change-Id: Iddd3019d7b6695c4ff6f03364fb9c72a1afee446
Reviewed-on: https://chromium-review.googlesource.com/1170855
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587249}

https://chromium.googlesource.com/angle/angle.git/+log/3e217f65044d..4c3108319e42


git log 3e217f65044d..4c3108319e42 --date=short --no-merges --format='%ad %ae %s'
2018-08-29 jmadill@chromium.org Vulkan: Return VkDeviceSize from DynamicBuffer.


Created with:
  gclient setdep -r src/third_party/angle@4c3108319e42

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: I837b61737c023ff3538ab266ec2369b84f64aceb
Reviewed-on: https://chromium-review.googlesource.com/1195058Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#587248}

Disabling the button would make it become somewhat grayed out which
caused the fading animation to look janky.

Bug: 878549
Change-Id: I17d9fbaee3c2fadd49487f018c6d788ab1c4119f
Reviewed-on: https://chromium-review.googlesource.com/1195001
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587247}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/45e7b57c0467..df4880942b7d


git log 45e7b57c0467..df4880942b7d --date=short --no-merges --format='%ad %ae %s'
2018-08-29 xixuan@chromium.org cbuildbot: move reef-release to skylab and non-important.


Created with:
  gclient setdep -r src/third_party/chromite@df4880942b7d

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: If7328505f2103fa45ce84bdff0586d5c6222b27a
Reviewed-on: https://chromium-review.googlesource.com/1195056Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#587246}

This was introduced in r585571. The cause is that MojoDataPump could be hanging on to an unretained callback to CastTransportImpl::OnReadResult. CastSocketImpl::CloseInternal() would reset CastTransportImpl but not MojoDataPump. Depending on the timing of when the data comes back, a UAF could happen.

Bug: 878021
Change-Id: I1edf4d2bfdc6ed7c47344f715a7323ed6954cbf7
Reviewed-on: https://chromium-review.googlesource.com/1195747Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587245}

The location bar displays a separator between the location icon and the omnibox text when either the location icon has an attached label, or when omnibox text jog is disabled. Previously, the location icon was 1 px too wide (33 px without a label instead of 32 px) when the separator was shown. This cl decreases the location icon width by 1 px when a separator is shown, and increases the text padding by 1 px in order to retain alignment between the omnibox and results popup texts. This change applies to location icons with and without a label. This change only applies with material refresh.

Bug: 865523
Change-Id: I5205a9ee81af6e33bbcb79637c69dd7444fc9b09
Reviewed-on: https://chromium-review.googlesource.com/1188886
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587244}

2906581f1051 win: Fix GYP build of http_transport_test_server
f540abb506ac Treat response codes in [200..203] as successful
e6f26587e435 fuchsia, net: Disable TLS, not currently working for in-
             Fuchsia tests
606368a39341 linux: Use correct handler argument for client FDs
f8b0538406ea fuchsia: Don’t require test certificate setup for disabled
             TLS tests
3ab5d5eff2b9 Update mini_chromium to 8d641e30a8b1
5c6e19f0001e Use std::shuffle instead of std::random_shuffle
7198015c7318 Fix the Chromium build on ChromeOS for aarch64
2c6c0935e226 Fix an implicit 64-bit to 32-bit conversion
255a4e0c0e51 Add "external" dependency mode for Crashpad's GN build
8068e2dd6df7 Remove references to exe_and_shlib_deps
0204fbd38b72 posix: Make DoubleForkAndExec accept an envp parameter
d4d2f8557aac android: Add client methods to start a Java handler
30b8c0dc2aff win: disable string_number_conversion_test for asan/dll

Change-Id: I822b8e83d9be4a251f1c3a816684d2e0a688f286
Reviewed-on: https://chromium-review.googlesource.com/1195670Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587243}

To get correct thread names in Chrome tracing, it's necessary to register
threads with the base::ThreadIdNameManager and set the thread name.

BUG=873377

Change-Id: Icb8d68f941f95f65c53ae19b16e05f0d85c9bfbd
Reviewed-on: https://chromium-review.googlesource.com/1192589Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587242}

This CL wires up 'Activity and interactions' and 'Google activity
controls' entries in SyncAndServicesPreferences. It also updates
strings used for 'Google activity controls' entry.

Bug: 814728
Change-Id: I161bdc0df44d46aba3ad795da2c2a9be5ca543c9
Reviewed-on: https://chromium-review.googlesource.com/1194038Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587241}