- 02 Jul, 2018 40 commits
-
-
Alexandr Ilin authored
Some clients would like to get a unique shared memory region ID without having a mapping to this region. There is no reason to not expose this method that is already implemented in the PlatformSharedMemoryRegion. Bug: 854594 Change-Id: I7e7de1b6c35748c382a1bf99974c53a0472e9b73 Reviewed-on: https://chromium-review.googlesource.com/1117190Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#571884}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/34f0d7e2e45f..3836c556c4c6 git log 34f0d7e2e45f..3836c556c4c6 --date=short --no-merges --format='%ad %ae %s' 2018-07-02 pasko@chromium.org androidStartupMetric: Allow multiple FCP events Created with: gclient setdep -r src/third_party/catapult@3836c556c4c6 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:760498 TBR=sullivan@chromium.org Change-Id: I10d9051ea1022d1a0b1cf64eddf04cd9cbc79113 Reviewed-on: https://chromium-review.googlesource.com/1122436Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571883}
-
Bailey Berro authored
This change adds authentication parameters to SmbProviderClient::Remount so ChromAD Kerberos shares can be remounted by passing in a user's username and workgroup. Bug: chromium:757625 Change-Id: I201a100526cbf1f29188e2b9b7e797c60b929620 Reviewed-on: https://chromium-review.googlesource.com/1098079 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#571882}
-
Oscar Johansson authored
When building using Jumbo namespaces with the same name gets merged and functions with the same name conflict. This happens for the function NetLogEntryCreationCallback in: net/disk_cache/net_log_parameters.h net/disk_cache/memory/mem_entry_impl.cc This commit solves the issue by renaming the function in net/disk_cache/net_log_parameters. Also renames CreateNetLogEntryCreationCallback to keep names consistent. Bug: 772146 Change-Id: Ice0a53054dbf2ded14728d48a7fd7b33bfe0d5a5 Reviewed-on: https://chromium-review.googlesource.com/1120180Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#571881}
-
Oscar Johansson authored
When building using Jumbo namespace aliases with the same name may end up in the same unit, causing a conflict at compilation. This happens for base::File and disk_cache::File in: net/disk_cache/simple/simple_index_file.cc net/disk_cache/simple/simple_synchronous_entry.cc This commit removes "using base::File" and instead call the namespace by its full name. Bug: 772146 Change-Id: I7385edf04bc23d519ee8800bc4941807a85340ad Reviewed-on: https://chromium-review.googlesource.com/1120252Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#571880}
-
Bartosz Fabianowski authored
We changed the enterprise/edu default so that unless the corresponding policies are explicitly set to "let the user decide," Android B&R and GLS are disabled and the corresponding check boxes are grayed out. Unfortunately, the policy handler code that implements this logic runs for consumer users as well. Consumers have no policies set, so the new default behavior kicks in, disabling and graying out the Android B&R and GLS check boxes. This CL fixes consumer behavior by only controlling B&R and GLS if the ArcEnabled policy is set. Since this policy is unset for consumers, they are shielded from the new behavior. Some enterprise users may also have the policy unset, but ArcEnabled unset or false for enterprise users means ARC++ is disabled, so B&R and GLS are N/A anyway. Bug: 849867 Test: ArcServicePolicyHandlerTest and manual verification Change-Id: Id3b785e4cde02716d54391607a64fac58604ed88 Reviewed-on: https://chromium-review.googlesource.com/1120177 Commit-Queue: Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#571879}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b12c0e2e..6856800e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I37c920e69e69cac303e9015a2dadee6bba1a55c8 Reviewed-on: https://chromium-review.googlesource.com/1122159Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571878}
-
Arthur Hemery authored
WebDocumentLoader::ExtraData was passed via raw pointers. Converting it to explicitly state ownership through std::unique_ptr. A comment stated in the code that this is not OK, but I think the comment is outdated since we don't support direct WebKit embedding anymore. Bug: 789577 Change-Id: Id5777b38e7d01ff7086eb6e725710903a691409d Reviewed-on: https://chromium-review.googlesource.com/1118379 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#571877}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fceaca323345..7687ad58b24b git log fceaca323345..7687ad58b24b --date=short --no-merges --format='%ad %ae %s' 2018-07-02 henrik.lundin@webrtc.org Reland "NetEq: Deprecate playout modes Fax, Off and Streaming" 2018-07-02 srte@webrtc.org Removes redundant delay based bwe. 2018-07-02 alessiob@webrtc.org Adding alessiob@ and minyue@ as owners of APM. Created with: gclient setdep -r src/third_party/webrtc@7687ad58b24b The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I302dad6ad8b92cacca9c20ab0b9fdcb54508ddc4 Reviewed-on: https://chromium-review.googlesource.com/1122356Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571876}
-
Koji Ishii authored
This is one missed LayoutBlockFlow-derived class that were not handled yet, either by implementing LayoutNG counterpart or by forcing legacy. This isn't a big class, but since most form controls forces legacy at its cloest BFC ancestor, it's reasonable to handle when we support form controls. Bug: 635619 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I9a9bb1788e9fe8367d6ce8d9439aae3f243335de Reviewed-on: https://chromium-review.googlesource.com/1122028Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#571875}
-
Alexander Semashko authored
This is a prerequisite for switching WindowedNotificationObserver to use base::RunLoop instead of deprecated MessageLoopRunner. This CL is split out from https://crrev.com/c/982612. This CL was uploaded by git cl split. R=finnur@chromium.org Bug: 668707 Change-Id: Idf89660cd9ced8c35a3a8f5b7dab945b57e7d57f Reviewed-on: https://chromium-review.googlesource.com/1120491 Commit-Queue: Alexander Semashko <ahest@yandex-team.ru> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#571874}
-
Antonio Gomes authored
This is a follow up of [1]. URLFetcher instances can be associated with an id (integer). Since this class has moved away from using URLFetcher (in favor of SimpleURLLoader), we can now remove the id's altogether. [1] https://crrev.com/c/1085947/9/components/translate/core/browser/translate_url_fetcher.h@67 BUG=844971 Change-Id: I6b4a9ec8046fe815104cd42f8d79d57eca90559c Reviewed-on: https://chromium-review.googlesource.com/1120506Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#571873}
-
Matthew Cary authored
Uses the new WritableUnalignedMapping class, which changes the ownership semantics. See the bug for details on the overall plan. Bug: 849207 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I84bf28d0da5b6c6d9e764b6f30d48f263550e37f Reviewed-on: https://chromium-review.googlesource.com/1117689Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#571872}
-
clamy authored
This CL is part of a serie of CLs to remove usage of the deprecated method NavigationController::GetActiveEntry. Bug: 273710 Change-Id: Id79dff30a1718ffc18a6470efbd308ed02fdfe18 Reviewed-on: https://chromium-review.googlesource.com/1102515 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#571871}
-
Thomas Tangl authored
When unified consent is enabled and sync is disabled for the signed-in user, the settings people page and the sync setup page should show the sync-disabled UI. Mocks: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZWnUS9sdsb0Q/files/MCHtA7U1iMGr60tih5X-IsS0IMOULEjJwZM Bug: 824546, 811769 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: If941f3432081af54baf1c040315fa055010aaa77 Reviewed-on: https://chromium-review.googlesource.com/1087463 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#571870}
-
Thomas Tangl authored
The service enablers in ChromeUnifiedConsentServiceClient are implemented. This means that when unity settings toggle is enabled, all existing settings toggles are automatically turned on as well. Bug: 857148, 800974 Change-Id: I6e591297c0127a094b5d402ef76ec9ad69d9bfef Reviewed-on: https://chromium-review.googlesource.com/1121459Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#571869}
-
Ulan Degenbaev authored
This is a follow-up to https://chromium-review.googlesource.com/1101020 Bug: 852415 Change-Id: If80d21fcd23749f33d8ca95543e56c8b990ed231 Reviewed-on: https://chromium-review.googlesource.com/1112015Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#571868}
-
Ulan Degenbaev authored
This adds the following metrics: - BloatedRenderer.V8.Heap, - BloatedRenderer.V8.Heap.AllocatedObjects, - BloatedRenderer.V8.Heap.Limit, - BloatedRenderer.V8.NearV8HeapLimitHandling. The metrics are recorded on the main thread when there is only one page running in the bloated renderer process. See "Privacy Considerations" section in go/proompt for privacy review. Bug: 835806 Change-Id: I717c98935fdcd3cc1bfe8cbb9710fa671400165e Reviewed-on: https://chromium-review.googlesource.com/1106142Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#571867}
-
Ramin Halavati authored
The Ephemeral Flash permissions flag is passed from C++ to JS and if Flash permissions are ephemeral, a message is added to the content settings page for Flash. Bug: 850062 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ia68536c59079eba197464fc4a30747871da2d9b1 Reviewed-on: https://chromium-review.googlesource.com/1113537Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#571866}
-
Dominic Battre authored
Report the priority of a PasswordGenerationRequirementsSpec for a generated password. This can be used for debugging as a 0 means that no spec was used, a 10 means that the spec came from autofill and was crowd sourced, a 20 means that it was overrideen per domain and a 30 means that is was overridden for the form. Bug: 846694 Change-Id: Ic64433d23dece4f9d6d511254cc85fdb2a746646 Reviewed-on: https://chromium-review.googlesource.com/1101211 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#571865}
-
Mark Cogan authored
This CL makes all guide names end in 'Guide'. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib9cc011284ffaacb1a9824fc7a13cbcb4e63e3dc Reviewed-on: https://chromium-review.googlesource.com/1114603 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#571864}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3664662e..b12c0e2e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I0f666773a42d063fdb63900627aa7672592c8b6d Reviewed-on: https://chromium-review.googlesource.com/1121974Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571863}
-
Matt Falkenhagen authored
We were skipping recording for the legacy EmbeddedWorkerInstance metrics but not the ServiceWorker.StartTiming.* metrics. It doesn't look like there's been a big effect regardless. Bug: 855952 Change-Id: I4f2804e45e75b6fa4f7bded732e7e472e2033bdf Reviewed-on: https://chromium-review.googlesource.com/1122060Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#571862}
-
Taylor Brandstetter authored
Instead of using a whitelist, which is how non-standard stats objects are being filtered out, this uses an "is_standardized" method on RTCStatsMemberInterface. This will allow us to easily add non-standard stats to WebRTC (or mark previously non-standardized stats as standardized) without needing to update chromium as well every time. Follow up to: https://webrtc-review.googlesource.com/c/src/+/83743 Bug: webrtc:9410 Change-Id: Idd349fedf30aa15db7c6e101115a1171aef33b4f Reviewed-on: https://chromium-review.googlesource.com/1121319Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#571861}
-
Greg Kraynov authored
Bug: 783309 Change-Id: I8a684822743221a4e4f17736fcdd48347bf8e271 Reviewed-on: https://chromium-review.googlesource.com/1120326Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#571860}
-
vitaliii authored
Bug: 781765,856583 Change-Id: Ia7feaf1119cc1f2f402646e66c832f656ca55e35 Reviewed-on: https://chromium-review.googlesource.com/1114612Reviewed-by:
Elijah Taylor <elijahtaylor@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#571859}
-
Deepanjan Roy authored
Delay of an input event is defined as the duration between the hardware timestamp and the start of event processing on the main thread. We report this event once per navigation, and take into account input delays observed in subframes, including OOPIFs. We do not take an input event into account if the page was backgrounded while the input event was queued. Additionally, for UKM, we currently do not take input events into account after the page was first backgrounded, but fixing this requires invasive changes to ukm_page_load_metrics_observer, and will be done in a subsequent CL. UKM Privacy Review: http://bit.ly/input-delay-ukm-privacy Bug: 822412 Change-Id: I1a823a48a1e8d8797ca4ecaa1e19e66c59bf4a2c Reviewed-on: https://chromium-review.googlesource.com/1084058 Commit-Queue: Deepanjan Roy <dproy@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#571858}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5a482847e95b..fceaca323345 git log 5a482847e95b..fceaca323345 --date=short --no-merges --format='%ad %ae %s' 2018-07-02 buildbot@webrtc.org Roll chromium_revision f06b8215..c2072685 (571725:571826) 2018-07-02 deadbeef@webrtc.org Removing deadbeef@ from OWNERS files. Created with: gclient setdep -r src/third_party/webrtc@fceaca323345 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ief0394d003f7aa60ae4e843404022719f4ae6cdc Reviewed-on: https://chromium-review.googlesource.com/1121880Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571857}
-
Yoshifumi Inoue authored
This patch changes |LayoutText::GetFirstLetterPart()| as const member function since this function doesn't change state of |LayoutText| for improving code health. This is the follow-up of the patch[1] which introduces |GetFirstLetterPart()| but it didn't mark it as const function. [1] http://crrev.com/c/1104082 [LayoutNG] Adapt accessibility module to LayoutNG Change-Id: I5f5781bbde91e1383980afc58e2fcb13e8bfc4c6 Reviewed-on: https://chromium-review.googlesource.com/1122023 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#571856}
-
Yoshifumi Inoue authored
This patch changes UA style sheet to make <rp> element has "display:none" to follow the spec[1]. This patch improves pass rate of Element#innerTex spec conformance test to 79 failures to 78 failures. [1] https://html.spec.whatwg.org/multipage/rendering.html#non-replaced-elements Bug: 859416 Change-Id: Ib5f41659d6ff056023dd24946e7c82cc388fba0e Reviewed-on: https://chromium-review.googlesource.com/1122019Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#571855}
-
Hannes Payer authored
Change-Id: Ib9a72f4887103709b02919aa3d894b6394dbb30c Reviewed-on: https://chromium-review.googlesource.com/1122128Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#571854}
-
Alex Clarke authored
We already know |now| so there's no need to create a new LazyNow. Change-Id: I9a483ecdeb537af3ca883598cfe749da3fe4b1a7 Reviewed-on: https://chromium-review.googlesource.com/1121464Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#571853}
-
Oscar Johansson authored
When building using Jumbo unnamed namespaces gets merged and variables with the same name conflict. This happens for the variables kNoPendingResult in: net/socket/ssl_client_socket_impl.cc net/socket/ssl_server_socket_impl.cc This commit solves the issue by renaming the constants to something more file specific. Bug: 772146 Change-Id: I918d551970e249fbb5e0bfadf0ebaeae99ffebcb Reviewed-on: https://chromium-review.googlesource.com/1119916Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#571852}
-
Yoshifumi Inoue authored
This patch changes "newlines-around-floating-or-positioned.html" to utilize w3c test harness for ease of maintenance. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/1114673 Make Element#innerText specification compliant Bug: 859410 Change-Id: Ic582771158dae7d2eb936d1581aa31bdb7b9cd63 Reviewed-on: https://chromium-review.googlesource.com/1122032Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#571851}
-
Yutaka Hirano authored
This reverts commit f2efdfd7. Reason for revert: To see if it's still flaky. Original change's description: > Disable SecurityExploitBrowserTest.InvalidRequestId. > > It's flaky on all operating systems and is affecting the commit queue. > Per comments on related bugs, the test is going to be removed anyway > once Chromium's network service ships. > > BUG=799516 > TBR=mmenke@chromium.org > > Change-Id: I2813e850690ed9b162288abac3e42b3b23d33ad8 > Reviewed-on: https://chromium-review.googlesource.com/866153 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#529171} TBR=kbr@chromium.org,mmenke@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 799516 Change-Id: I9a7fab6e6e1bfe75285a4d6f222b56314b66b9df Reviewed-on: https://chromium-review.googlesource.com/1122096Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#571850}
-
Yoshifumi Inoue authored
This patch changes "inner-text-with-no-renderer.html" to utilize w3c test harness for ease of maintenance. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/1114673 Make Element#innerText specification compliant Bug: 859410 Change-Id: I108b1225a72517d1afa7402f2c184d7b3e5b1043 Reviewed-on: https://chromium-review.googlesource.com/1122035Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#571849}
-
Oscar Johansson authored
When building using Jumbo unnamed namespaces gets merged and functions with the same name conflict. This happens for the function kParseCertificate defined in: net/cert/internal/ocsp.cc net/cert/internal/parse_certificate.cc This commit solves the issue by renaming the function in net/cert/internal/ocsp.cc. Bug: 772146 Change-Id: I071682c8f330183f637a7985061980b6aa34c93a Reviewed-on: https://chromium-review.googlesource.com/1119911Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#571848}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8451daabb23d..00d2e8ebcb13 git log 8451daabb23d..00d2e8ebcb13 --date=short --no-merges --format='%ad %ae %s' 2018-07-02 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@00d2e8ebcb13 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: Iec55b28e9a97ae22a046299f7d440607b6a33b47 Reviewed-on: https://chromium-review.googlesource.com/1121879Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571847}
-
Matthew Cary authored
Use the underlying handle size when wrapping a legacy shared memory instance. Bug: 849207 Change-Id: Ibbf62ebbea5a95d64d84a0faf2042f639be5b820 Reviewed-on: https://chromium-review.googlesource.com/1118268Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#571846}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Ib4acfae0eb7bce7aaaa32bbb8f487e8d177a251b Reviewed-on: https://chromium-review.googlesource.com/1121973Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571845}
-