- 08 Jun, 2018 40 commits
-
-
Tommy C. Li authored
Previously they were 24x24. But in the new Material Refresh spec, they take up 32x24. Bug: 849779, 823535 Change-Id: Ie1f5dfe9e9f2ae88bcf07643fb6b33f6472bdcdf Reviewed-on: https://chromium-review.googlesource.com/1090073Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#565723}
-
Nico Weber authored
These bots used to be on FYI, but they're on the clang waterfall now (and also listed for that waterfall in waterfalls.pyl) Bug: 843511 Change-Id: I5ee01813e2701e1346edb05bbb5d3bae723b9b96 Reviewed-on: https://chromium-review.googlesource.com/1093555 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#565722}
-
Jiaquan He authored
This commit: - removes some TODOs; - uses kGridIconDimension in ash/public/cpp/app_list/app_list_constants.h; - passes a trimmed query string over mojom for searching, since it's smaller and the raw query string in Chrome was only needed by search history, which has been removed. Bug: 733662 Change-Id: I2f8e7f5294079b4a9ac0141384502cc7dda1a806 Reviewed-on: https://chromium-review.googlesource.com/1093388 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#565721}
-
jdoerrie authored
This change partially reverts r550197 which introduced CHECKs to base::Optional's operator*, operator-> and value(). This is done to reduce binary size and to be more standard's compliant, as std::optional also doesn't perform checks for operator* and operator->. Lastly, the CHECKs in value() are kept, as here CHECKing is desired, and also matches std::optional's behaviour. Bug: 832678 Change-Id: I467c7d7623c2880ee761b8a58a74738c09e0ba2a Reviewed-on: https://chromium-review.googlesource.com/1093314Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#565720}
-
Sorin Jianu authored
This change introduces new error codes for these responses. Bug: 850720 Change-Id: I85462e964a573bf310b7b0ae5e9180e2e87eafdc Reviewed-on: https://chromium-review.googlesource.com/1091876Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#565719}
-
Lei Tian authored
This CL fixes Browser Actions bugs includes: 1. Change download menu text to "Download link". 2. Fix flaky test. Bug: 773073, 831306 Change-Id: I4f2bc4d9288c2d96b7d878eb80ac0802e8065fe3 Reviewed-on: https://chromium-review.googlesource.com/1091875Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Lei Tian <ltian@chromium.org> Cr-Commit-Position: refs/heads/master@{#565718}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e4d73cb..7a01ce9 git log e4d73cb..7a01ce9 --date=short --no-merges --format='%ad %ae %s' 2018-06-08 tsepez@chromium.org Update fxjs/README now that context data slots are gone 2018-06-08 thestig@chromium.org Use FPDFText_GetBoundedText() to get the visible text in a test. 2018-06-08 thestig@chromium.org Consolidate repeated constants in FPDFTextEmbeddertest. Created with: gclient setdep -r src/third_party/pdfium@7a01ce9 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I0a02663ad82b0e535c211aa2b792110edcf16b9a Reviewed-on: https://chromium-review.googlesource.com/1093274Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565717}
-
Xiaohan Wang authored
This allows KeySystemConfigSelectorTest to fully depend on the FakeKeySystems. Previously KeySystemConfigSelector calls CanUseAesDecryptor() which calls into KeySystemsImpl which makes the test really confusing. Bug: 727948 Change-Id: Id5536a142285034f1ec589758a171c70d3a77153 Reviewed-on: https://chromium-review.googlesource.com/1092412Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#565716}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8e6f58c..e05f18d git log 8e6f58c..e05f18d --date=short --no-merges --format='%ad %ae %s' 2018-06-08 ehmaldonado@chromium.org Reland "Reland "Expand variables in gclient flattened output."" Created with: gclient setdep -r src/third_party/depot_tools@e05f18d The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:848990 TBR=agable@chromium.org Change-Id: I348ead5c56b9fc1a54cc4b082d318d1d35bc7b21 Reviewed-on: https://chromium-review.googlesource.com/1093275Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565715}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6bfc16d6. With Chromium commits locally applied on WPT: e8832df8 "webrtc wpt: remove test_state_change_event" fbdd17fb "Improve RTCPeerConnection-setRemoteDescription-tracks.https.html tests." c220be7c "Fire RTCPeerConnection.onsignalingstatechange in the correct order." 4049f639 "[LayoutNG] Orthogonal flows need available inline size for min/max calculation." 69af6f38 "webrtc wpt: add cleanup to close peerconnections" ef28de47 "service worker: Add long timeout to registration-updateviacache.https.html." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19209 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: igrigorik@chromium.org, panicker@chromium.org: external/wpt/performance-timeline jsbell@chromium.org: external/wpt/resources panicker@chromium.org: external/wpt/user-timing TBR=foolip No-Export: true Change-Id: Icbf1e91867e9cc114a7dedaaa8b7b9eba52a053f Reviewed-on: https://chromium-review.googlesource.com/1093116 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#565714}
-
Xiangjun Zhang authored
Currently the media::AudioDeviceThread is always created with REALTIME_AUDIO thread priority. However, when calling from the new Mirroring Service running in a sandboxed utility process (coming in future CLs), the REALTIME_AUDIO priority is not allowed due to sandbox syscall restrictions. Also, since the input audio data is buffered, there is no need to use REALTIME_AUDIO thread for mirroring. This CL allows media::AudioDeviceThread to be created with requested thread priority. There should be no change to existing behavior. Bug: 850352 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id9e724b230e14c269f262c1c4c7e2b15ac08a57d Reviewed-on: https://chromium-review.googlesource.com/1090226 Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#565713}
-
Paul Miller authored
Change-Id: Id4c60445a0e394abf2386339801b83b6e1533020 Reviewed-on: https://chromium-review.googlesource.com/1079696Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#565712}
-
Nico Weber authored
Looks like these waterfalls now exist in luci-milo.cfg, so this is now possible. - Remove no-longer-existing bots "Chromium Mac 10.11", "Chromium Mac 10.11 Force Mac Toolchain", "Chromium Win 10 GCE Tests" - "Chromium Win 10 GCE Tests" was the only bot using chromium_win_fyi_gtests, so remove that too (since the bot didn't exist, it wasn't used previously either), which in return was the only user of chrome_cleaner_gtests, so remove that too. - Fix case sensitivity misspellings: We're not consistent about if bots are called ASan (more common) or ASAN (less common, but present). - While here, also remove some remaining references to PGO from mb_config.pyl. Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1061597 Bug: 843511,820422 Change-Id: I70518fdedfab23c807afdcd8bb335a9aeacf09dc Reviewed-on: https://chromium-review.googlesource.com/1093159Reviewed-by:
-
David Roger authored
Bug: 850498 Change-Id: I304084db180fa729ceb5b6ec54e4c955fb4ae401 Reviewed-on: https://chromium-review.googlesource.com/1090838Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#565710}
-
Mustafa Emre Acer authored
U+10D5 (ვ), U+1012 (ဒ) => 3 Bug: 847242, 849398 Test: components_unittests --gtest_filter=*IDN* Change-Id: I9abb8560cf1c9e8e5e8d89980780b89461f7be52 Reviewed-on: https://chromium-review.googlesource.com/1091430Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#565709}
-
Tommy C. Li authored
This CL links many of the Omnibox OWNERS files together. It also specifically adds location_bar to the Omnibox team's ownership to lighten the review load on pkasting@. Bug: NONE Change-Id: I3b8b3a2e50dc2ad96d85e7b5fe02379b558e2bd0 Reviewed-on: https://chromium-review.googlesource.com/1091808 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#565708}
-
Xiaoqian Dai authored
A window's tab(s) should be able to be dragged out and dropped onto an eligible overview window item and merged into the overview window's tabs. See UI mock: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZQkoNXdY_I0T/files/MCHbtQVoQ2HCZU9_w4Gwefkm See recorded video: https://drive.google.com/open?id=1jLFN3Rv59uukVohOxIBsmeGQQolxUoxH From the UI mock, when a dragged window hovers over an overview window item, if the window is eligible to be merged into, a highlight indication will show up to indicate its selection; and when the dragged window hovers out it, the highlight indication will be hidden. The dragged window should not merge into the overview window during dragging, but should wait until the user drops the dragged window onto it (i.e., releases the mouse/tap). Thus TabDragController should defer attaching a dragged window to an overview window until the drag ends. Bug: 823769 Change-Id: I3b0e41d677d41231a4cd5382b33ccb4203351f19 Reviewed-on: https://chromium-review.googlesource.com/1065499 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#565707}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ed51a6e..2d61162 git log ed51a6e..2d61162 --date=short --no-merges --format='%ad %ae %s' 2018-06-08 jonasolsson@webrtc.org Remove stringstreams from media/sctp/ 2018-06-08 jonasolsson@webrtc.org remove unused stringstream import 2018-06-08 buildbot@webrtc.org Roll chromium_revision f9a24d5d..e9fcce49 (564886:565609) 2018-06-08 nisse@webrtc.org Add full stack test with link capacity of 150 kbit/s. 2018-06-08 danilchap@webrtc.org Revert "Move class VideoCodec from common_types.h to its own api header file." 2018-06-08 phoglund@webrtc.org Add R8 to DEPS. 2018-06-08 phoglund@webrtc.org Roll chromium_revision 42930fc8..f9a24d5d (564069:564886) 2018-06-08 nisse@webrtc.org Move class VideoCodec from common_types.h to its own api header file. 2018-06-08 magjed@webrtc.org Android: Add deprecation annotations to VideoRenderer and I420Frame 2018-06-08 kwiberg@webrtc.org Remove test AudioCodingModuleTest.TestAPI 2018-06-08 brandtr@webrtc.org Add simulcastStream output from VideoCodecTestFixture::Config::ToString. 2018-06-08 brandtr@webrtc.org Add bitrate_priority to GetSimulcastConfig call. 2018-06-07 ouj@fb.com Guard the android aaudio headers include with the aaudio preprocessor Created with: gclient setdep -r src/third_party/webrtc@2d61162 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7d04ce26471fcbe6804353f718059174ace44d30 Reviewed-on: https://chromium-review.googlesource.com/1092995Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565706}
-
Moe Ahmadi authored
Bug: 816941 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5fae03657bd3e05ed101b4b85c2904aa28b3611d Reviewed-on: https://chromium-review.googlesource.com/1089857Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#565705}
-
Kyle Horimoto authored
Bug: 824568, 752273 Change-Id: I7bafac91260e56b977caf89738931ad752115b73 Reviewed-on: https://chromium-review.googlesource.com/1093383Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#565704}
-
Tessa Nijssen authored
StatusBubbleViews now calls views::style::GetFont() instead of gfx::FontList(). This allows the passing of a TextContext, in this case CONTEXT_LABEL. When the context is passed on Mac, the font returned has a default size of 12pt. This is more consistent with Safari and other platforms. Since the system font on Mac (without user changes) returns 13pt font, this change now sets the StatusBubbleViews font size to 12pt on Mac. On other platforms, the default font size was already 12pt, so this change does not change the status bubble font size on non-Mac platforms. Bug: 834125 Change-Id: Ic1a9c5f728228341f18ddb41e36ea1e51078f95a Reviewed-on: https://chromium-review.googlesource.com/1079849 Commit-Queue: Tessa Nijssen <tnijssen@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
-
Mark Pearson authored
This reverts commit 73932db2. Reason for revert: caused failure in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests/3347 failures: MSE_ExternalClearKey/EncryptedMediaTest.Playback_VideoOnly_MP4/0 [ RUN ] MSE_ExternalClearKey/EncryptedMediaTest.Playback_VideoOnly_MP4/0 [51235:2819:0608/103709.237938:WARNING:notification_platform_bridge_mac.mm(510)] AlertNotificationService: XPC connection invalidated. 2018-06-08 10:37:09.383 browser_tests[51235:780694] *** Owner supplied to -[NSTrackingArea initWithRect:options:owner:userInfo:] referenced a deallocating object. Tracking area behavior is undefined. Break on NSTrackingAreaDeallocatingOwnerError to debug. BrowserTestBase received signal: Terminated: 15. Backtrace: 0 browser_tests 0x000000010ea3aeac base::debug::StackTrace::StackTrace(unsigned long) + 28 1 browser_tests 0x000000010efd4b45 content::(anonymous namespace)::DumpStackTraceSignalHandler(int) + 229 2 libsystem_platform.dylib 0x00007fff51ad5f5a _sigtramp + 26 3 browser_tests 0x000000010e9b6c3f base::internal::IncomingTaskQueue::PostPendingTask(base::PendingTask*) + 111 4 CoreFoundation 0x00007fff29e9bdc5 __CFRunLoopServiceMachPort + 341 5 CoreFoundation 0x00007fff29e9b117 __CFRunLoopRun + 1783 6 CoreFoundation 0x00007fff29e9a787 CFRunLoopRunSpecific + 487 7 HIToolbox 0x00007fff291a7e26 RunCurrentEventLoopInMode + 286 8 HIToolbox 0x00007fff291a7b96 ReceiveNextEventCommon + 613 9 HIToolbox 0x00007fff291a7914 _BlockUntilNextEventMatchingListInModeWithFilter + 64 10 AppKit 0x00007fff27472f5f _DPSNextEvent + 2085 11 AppKit 0x00007fff27c08b4c -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 3044 12 browser_tests 0x000000010eae2920 __71-[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:]_block_invoke + 64 13 browser_tests 0x000000010e9ab94a base::mac::CallWithEHFrame(void () block_pointer) + 10 14 browser_tests 0x000000010eae2854 -[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 164 15 AppKit 0x00007fff27467d6d -[NSApplication run] + 764 16 browser_tests 0x000000010e9bbc0c base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 364 17 browser_tests 0x000000010e9ba72e base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 110 18 browser_tests 0x000000010e9dee55 base::RunLoop::Run() + 53 19 browser_tests 0x000000010effa3b9 content::WindowedNotificationObserver::Wait() + 153 20 browser_tests 0x000000010efd5959 content::WaitForLoadStop(content::WebContents*) + 105 21 browser_tests 0x000000010ea70771 InProcessBrowserTest::PreRunTestOnMainThread() + 161 22 browser_tests 0x000000010efd4778 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 280 23 browser_tests 0x000000010eae8a45 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4341 24 browser_tests 0x000000010eae784e ChromeBrowserMainParts::PreMainMessageLoopRun() + 62 25 browser_tests 0x000000010d57f283 content::BrowserMainLoop::PreMainMessageLoopRun() + 67 26 browser_tests 0x000000010d96b377 content::StartupTaskRunner::RunAllTasksNow() + 39 27 browser_tests 0x000000010d57dccd content::BrowserMainLoop::CreateStartupTasks() + 813 28 browser_tests 0x000000010d581562 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) + 98 29 browser_tests 0x000000010d57bd4c content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) + 204 30 browser_tests 0x000000010e92fa77 content::ContentMainRunnerImpl::Run() + 615 31 browser_tests 0x000000011060dab5 service_manager::Main(service_manager::MainParams const&) + 2709 32 browser_tests 0x000000010e92ea74 content::ContentMain(content::ContentMainParams const&) + 68 33 browser_tests 0x000000010efd447b content::BrowserTestBase::SetUp() + 2571 34 browser_tests 0x000000010ea6f8d3 InProcessBrowserTest::SetUp() + 723 35 browser_tests 0x000000010ca9350d testing::Test::Run() + 109 36 browser_tests 0x000000010ca941a0 testing::TestInfo::Run() + 320 37 browser_tests 0x000000010ca94717 testing::TestCase::Run() + 279 38 browser_tests 0x000000010ca9fd87 testing::internal::UnitTestImpl::RunAllTests() + 871 39 browser_tests 0x000000010ca9f9fd testing::UnitTest::Run() + 109 40 browser_tests 0x000000010ea89786 base::TestSuite::Run() + 166 41 browser_tests 0x000000010e98b2f5 ChromeTestSuiteRunner::RunTestSuite(int, char**) + 37 42 browser_tests 0x000000010eff5f35 content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) + 389 43 browser_tests 0x000000010e98b7db LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) + 347 44 browser_tests 0x000000010e98b26e main + 94 45 libdyld.dylib 0x00007fff51854115 start + 1 46 ??? 0x000000000000000a 0x0 + 10 Original change's description: > media: MediaBrowserTest not watching for plugin crash > > Now the CDM is not running in a plugin, there's no need for > MediaBrowserTest to watch for plugin crash. > > For the record, see the original CL that added this: > https://codereview.chromium.org/206693004 > > Bug: 772160 > Test: Remove obsolete code. No functionality change. > Change-Id: I8c0a9e74cc4c1d05b153f1e80a0882ee28287ac7 > Reviewed-on: https://chromium-review.googlesource.com/1091888 > Reviewed-by: Frank Liberato <liberato@chromium.org> > Commit-Queue: Xiaohan Wang <xhwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565649} TBR=xhwang@chromium.org,liberato@chromium.org Change-Id: Ib80cd4be4d495c13f19196456ac621168acfa270 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 772160 Reviewed-on: https://chromium-review.googlesource.com/1093514Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#565702}
-
Martin Kreichgauer authored
Revert "chrome/installer/mac: set -x in sign_app and fix unquoted variable expansion" and "//chrome/installer/mac: add entitlements during code signing" This reverts commits a221822f and b69d8c48. Bug: 850890, 848052 Change-Id: I1b34c71d6522a051abc44a00b43b2466edffe51b Reviewed-on: https://chromium-review.googlesource.com/1093119Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
gogerald authored
Use case of this change is for payment request + payment handler (service worker): Users could enter into incognito mode and install a payment handler (service worker) there. Then go to a merchant website to buy with that payment handler, which will open a web page in custom tab to ask inputs. After that the opened web page should be able to find out the service worker to send back the result. So the registered payment handler (service worker) and opened web page must in the same browser context. Below is the test video record, https://drive.google.com/file/d/1CTFw9_-jCOvmV1fEMg8TZHd0inNKdPS2/view?usp=sharing Bug: 848245 Change-Id: Ice00df0b53c40a34108d84c8fa55d8160a03d6e2 Reviewed-on: https://chromium-review.googlesource.com/1080688 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#565700}
-
Robert Ogden authored
This CL adds a content description to the "Details" TextView header over the Data Usage Breakdown table. This content description describes what the current sorting scheme to users using TalkBack. Bug: 849395 Change-Id: I8328a5a41a37a55a532c5955777200df73a44f53 Reviewed-on: https://chromium-review.googlesource.com/1090072Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#565699}
-
sczs authored
- Adds a BlurEffect to the styler. - Makes NavigationBar translucent. Screenshot: https://drive.google.com/open?id=1wW2bL4AP3TusA64yPVgAyGMg4_hncVQT (The blue squares were added so the Visual effect is easier to see) Bug: 838580 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4e03b2dde5633716fbe131893433e6142abfa653 Reviewed-on: https://chromium-review.googlesource.com/1084321 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#565698}
-
edchin authored
A history coordinator that is started from main_controller won't work properly from the tab grid. Using a local coordinator works better when hooked up with a specialized URL loader and tab presentation delegate. This CL introduces a specialized URL loader that behaves differently from the one in BVC. Essentially, BVC's loader navigates the current WebState to the new URL. In tab grid, we need to append a new WebState to the end of the list, because there is no context of a current visible BVC. Also in this CL is a change to how tab presentation is handled. In the stand-alone recent tabs, the BVC is already presented so there is no need to actively present it. However, in tab grid, there is no visible BVC. To show the tab that was tapped in recent tabs, we needed a mechanism that could present BVC when in the tab grid, but NO-OP in the stand-alone case. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id3b8a88e548de14356f997a8154fed9d613b18d0 Reviewed-on: https://chromium-review.googlesource.com/1092510 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#565697}
-
Dmitry Gozman authored
This splits LoadInternal and removes it. Bug: 789577 Change-Id: I4931659a1f50890fcda489e74591d12a2d2c4419 Reviewed-on: https://chromium-review.googlesource.com/1083823Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
-
Max Rebuschatis authored
Bug: 848959 Change-Id: I99c958ba7ae1de5c233e77d085dbd20880baf6ca Reviewed-on: https://chromium-review.googlesource.com/1089812 Commit-Queue: Max Rebuschatis <lincolnfrog@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#565695}
-
Troy Hildebrandt authored
Certain search providers have a search URL that differs on mobile from what we have in prepopulated_engines.json. Using alternate_urls and the google:pathWildcard marker this CL adds/fixes several search URLs. Additionally, all of the Yahoo! are broken across the board, which this fixes. Query in Omnibox is fixed for all currently known broken cases. Bug: 834876 Change-Id: I78955ccbd2079945eeb4542c962fe0673ae4c65c Reviewed-on: https://chromium-review.googlesource.com/1060413 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#565694}
-
Jeremy Klein authored
kEnableUnifiedMultiDeviceSettings should be used here instead of the old flag that was added for SMS sync. This new flag is part of the unified better together effort. R=dpapad@chromium.org, khorimoto@chromium.org Bug: 824568 Change-Id: Id1c21c0905213bcbcf3a18e17d7a51ffc2e57194 Reviewed-on: https://chromium-review.googlesource.com/1092238Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#565693}
-
Sky Malice authored
Bug: 831642 Change-Id: Idd4b8aeb1470482ac2bbd8fdab8ae066ead4d300 Reviewed-on: https://chromium-review.googlesource.com/1087592Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#565692}
-
John Z Wu authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I79b509fc63a011a8dcdfcf040ef694fc4a2170f8 Reviewed-on: https://chromium-review.googlesource.com/1092074Reviewed-by:
-
Ryan Sturm authored
When the DRP config service sends a bool to ignore the previews blacklist for server previews, the long term (host and user) rules will be ignored for server previews. Client previews will still respect those rules. Bug: 849328 Change-Id: I4ef5f6b3e71592cba1eaa9c6e0006780191de6b5 Reviewed-on: https://chromium-review.googlesource.com/1086364Reviewed-by:
Peter Williamson <petewil@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#565690}
-
Allen Bauer authored
UX requested this minor change in advance of a user-study focused on getting direct usability feedback for the new UI changes. Bug: 850981 Change-Id: I1a673fd16bcc1ed736eb35399839ec653a5fb51d Reviewed-on: https://chromium-review.googlesource.com/1092793 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#565689}
-
John Z Wu authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id3ceb16cc07aec0ad376494315db77959806570a Reviewed-on: https://chromium-review.googlesource.com/1091973Reviewed-by:
-
Sidney San Martín authored
Part 1: https://chromium-review.googlesource.com/c/chromium/src/+/1066304 This change picks up from the above CL and adds hooks into the GPU process to coordinate its CATransaction with the browser's on request (e.g. for resize). New GPU IPCs let the browser process, via CATransactionObserver, begin a transaction and then end it while in the post commit phase of its CATransaction. This makes compositor changes display atomically with changes in the browser process. It also fixes the window frame jank described in the above CL when the GPU process assigns new IOSurfaces as CALayer contents. I think this is because the two CATransactions happen as one from the window server's point of view: in a test app, committing the two transactions like this significantly reduced the time to commit. Bug: 837660 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib5b2a3a3cae76640cc9872b7f265cb3bd13143a4 Reviewed-on: https://chromium-review.googlesource.com/1077047Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#565687}
-
Amy Qiu authored
Move pathological_mobile_sites into the rendering folder and refactor to inherit from the RenderingStory class Bug: 849392 Change-Id: Ie34cda5845f73b133e9d1df34430eede20f2d670 Reviewed-on: https://chromium-review.googlesource.com/1089383 Commit-Queue: Amy Qiu <amyqiu@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#565686}
-
Ryan Tseng authored
Bug: 790277, 790274, 790292, 790281, 790269 Change-Id: I48e7869ce0974c36149a18653c39c0c7c2ff5502 Reviewed-on: https://chromium-review.googlesource.com/1092041 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#565685}
-
Sidney San Martín authored
Bug: 849538 Change-Id: Ib04c020dbc50aae398255654f5404fd8904a5326 Reviewed-on: https://chromium-review.googlesource.com/1092232Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#565684}
-
