- 15 Apr, 2020 40 commits
-
-
Colin Blundell authored
This CL eliminates //weblayer's custom implementation of InterceptNavigationDelegate in favor of using the //components-level implementation that Chrome uses. As part of this change, we adapt //chrome's InterceptNavigationDelegateClient implementation as suitable for WebLayer. With this change, WebLayer now eliminates stale navigation entries left on intent launches as Chrome does and also detects cases where tabs should be closed on intent launches as Chrome does. Actual closing of tabs in those cases is left as a followup. As part of this change, we add an implementation of ContentBrowserClient::IsHandledURL() to //weblayer's ContentBrowserClientImpl. This implementation is needed for the shared InterceptNavigationDelegateImpl to behave as expected. The implementation is based on that in //chrome, with Chrome-specific items deleted (notably, the kChromeSearchScheme is not handled in WebLayer). The diff between PS6 and PS8 contains the differences between //chrome's InterceptNavigationDelegateClient implementation and //weblayer's. One of the notable differences is that WebLayer's Tab objects (a) cannot be directly observed and (b) do not change their associated WebContents during their lifetime. Thus, the //weblayer InterceptNavigationDelegateClient implementation observes WebContents directly, with //weblayer's TabImpl additionally calling directly into the client implementation as necessary. Bug: 1031465 Change-Id: I010c4c3ef066bfb2d718f597c654a3ce3df890db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137441 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#759230}
-
Wez authored
This reverts commit 8e795d5b. Reason for revert: Introduces FlingControllerWithPhysicsBasedFlingTest suite, in which ControllerDoesntBoostFinishedFling test flakes across Fuchsia, Windows, Linux, and Mac platforms. Original change's description: > FlingBoost with experimental fling animation curve > > Currently, if physics based fling curve is enabled, even if the fling is > boosted, the scroll distance is capped by upper bound which is three > times the size of viewport. Thus it nullify the effect of fling boosting > and travels the same distance as it would if fling is not boosted. > > This CL fixes fling boosting with physics based fling curve. It does > so by increasing the upper bound every time a fling is boosted. > > Bug: 647137 > Change-Id: Ib2dd51b37df91168ae1f1e8d33888e3b5dc43e23 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118218 > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Reviewed-by: Daniel Libby <dlibby@microsoft.com> > Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#758878} TBR=bokan@chromium.org,nzolghadr@chromium.org,dlibby@microsoft.com,sahir.vellani@microsoft.com Change-Id: Ibfc9e51bf5f86c7d6a626d761c20b3ce97652af6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 647137, 1070776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144087Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#759229}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/93bea5cb50e3..e3f44e3cd6a1 git log 93bea5cb50e3..e3f44e3cd6a1 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 cwallez@chromium.org ShutDownBase, only tick frontend facilities if they have been created 2020-04-15 cwallez@chromium.org Null: Properly fake commands being completed on WaitForIdle Created with: gclient setdep -r src/third_party/dawn@e3f44e3cd6a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1068465,chromium:1068886,chromium:1068887 Tbr: cwallez@google.com Change-Id: I22df67e28904c6733db151505b5bd93cac800e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150420Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759228}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3ebb6e93f417..43245c56b086 git log 3ebb6e93f417..43245c56b086 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 handellm@webrtc.org Remove excessive log spam in large conferences in downstream project. 2020-04-15 mbonadei@webrtc.org Mark static const class/struct members as constexpr. Created with: gclient setdep -r src/third_party/webrtc@43245c56b086 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1062963 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I69448bcc649674b067a036e87fa2b244d028f1be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150422Reviewed-by:
-
Milica Selakovic authored
In this CL password generation is extracted from SetFormFieldValueAction to separate action. Bug: 1064264 Change-Id: If111335c08ec91de250ad8ddc084d15d5ef73cc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146545 Commit-Queue: Milica Selakovic <selakovic@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#759226}
-
Jan Wilken Dörrie authored
This change fixes a minor bug in the Removal Confirmation Dialog resulting in displaying a wrong placeholder. Fixed: 1070878 Change-Id: I4a96715dc29814ca97a0bc3e38b2aefb1caf1593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149430 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#759225}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f130314cc50c..a5bcf59309b5 git log f130314cc50c..a5bcf59309b5 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 szuend@chromium.org Issues affected by network requests delay requestId to request mapping Created with: gclient setdep -r src/third_party/devtools-frontend/src@a5bcf59309b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1070577 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic13c57571a1935031faff1410a3657637a022ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150421Reviewed-by:
-
Yuki Shiino authored
"history.state === popStateEvent.state" should be evaluated to true, however, the result changes depending on their evaluation order. See the bug for details. This patch removes the custom bindings of PopStateEvent.state and reimplements History.state and PopStateEvent.state in a less hacky way, moving caching with V8 private property from Blink-V8 bindings into Blink implementation. WPT failures in this patch are expected. I'll send a fix of WPT separately. Bug: 1070938 Change-Id: Iaf9bdbc6545cdbe18d8f3542944dfce61c443da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147488Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#759223}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I472204f0a9a8b02f9b0645c18ed9f9748f757387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150297Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759222}
-
chrome://discardsdpapad authored
Bug: 720034 Change-Id: I3a6b4a4994930b1da62680672efd181506a5a6f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148845 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#759221}
-
Victor Hugo Vianna Silva authored
In a multi-window scenario, FindBrowserWithProfile has to find the last active one. Since ChromePasswordManagerClient is per WebContents, its browser can be directly retrieved using FindBrowserWithWebContents. Bug: None Change-Id: I8f1cb0c1fe9cf7f8f1a34115a59bdbaf15aa1bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144145Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#759220}
-
Luke Zielinski authored
results viewer. Duplicated from a similar change in crrev.com/c/2140095 Bug: 937369 Change-Id: Ia15291312f41c2b9248c9a7ebc0f214215bf37a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149279Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#759219}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8ab5356c195c..aa333ac7985f git log 8ab5356c195c..aa333ac7985f --date=short --first-parent --format='%ad %ae %s' 2020-04-15 hjd@google.com Merge "trace_processor: Update ExtendWithColumn to use SharedPtr" Created with: gclient setdep -r src/third_party/perfetto@aa333ac7985f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3572023c5756974543c2fef4afb89e0f9a2fc633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150418Reviewed-by:
-
Tal Pressman authored
Change-Id: I0ed01ce85cc0c4bd5e1c9475e47fd19771d714e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147406 Auto-Submit: Tal Pressman <talp@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759217}
-
David Van Cleve authored
A previous CL (crrev.com/c/2120102) implemented preliminary data clearing logic for Trust Tokens [*] persistent state, in a manner such that any data removal action clearing cookies would also clear Trust Tokens state. In particular, this clears Trust Tokens state whenever the browser receives a Clear-Site-Data header specifying that cookies should be cleared. This is a problem because persistent Trust Tokens state includes metadata used to enforce privacy invariants. For instance, it contains lists of token issuers associated with each top-level origin and the statuses of origin-scoped rate limits on issuance and redemption. This CL creates a new data removal type for Trust Tokens and adds it to DATA_TYPE_SITE_DATA, with the effect that Trust Tokens state will be cleared through the UI when the user clears cookies and other site data, but the state will not be cleared through the Clear-Site-Data header. [*] https://docs.google.com/document/u/1/d/1TNnya6B8pyomDK2F1R9CL3dY10OAmqWlnCxsWyOBDVQ/edit R=msramek Bug: 1064747 Change-Id: I9c5fbd0ad660199345ab04a89999731d79fded16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144411 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#759216}
-
Stephen McGruer authored
This test has non-deterministic failure output, which is blocking the WPT importer. Included a Timeout expectation as there are existing entries with Timeout on some platforms. That expectation may now be unnecessary, but trying to unblock ASAP here :) Bug: 1070995 Change-Id: If77956fb5929d842dc76921aaf1b91634b9e3aa2 TBR=robertma@chromium.org Change-Id: If77956fb5929d842dc76921aaf1b91634b9e3aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147010Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#759215}
-
Guido Urdaneta authored
This reverts commit 9f0e99aa. Reason for revert: Suspect of causing test failures in linux-chromeos-dbg First failure: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/18126 services_unittests failed because of: PerfettoIntegrationTest.PacketsEndToEndProducerFirst PerfettoIntegrationTest.ProducerDatasourceInitialized SystemPerfettoTest.MultipleSystemAndLocalSourcesLocalFirst PerfettoIntegrationTest.ClientEnabledAndDisabled ... Original change's description: > Make the producer name include the host_package_name on Android. > > This allows you to trace with perfetto "producer_name_filter" to scope > your system traces to only particular apps (chrome stable/canary/etc). > > Change-Id: I9a677a8d8edfdf6645eb50d9e77e9ffb025ca94d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144135 > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759188} TBR=dcheng@chromium.org,eseckler@chromium.org,nuskos@chromium.org Change-Id: I3cf97d68304aee6fc4afc90b954d02cbb6ce700e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146906Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#759214}
-
Rouslan Solomakhin authored
Before this patch, if both payment method manifest and the web app manifest of a payment app were located in the same file, then Chrome would retrieve the same file twice with two separate HTTP GET requests, when looking for installable service worker based payment handlers. This patch compares the URL of the payment method manifest and the web app manifest and, if the two are the same, uses the in-memory copy of the payment method manifest content as the web app manifest content instead of re-downloading it again. After this patch, when Chrome is looking for installable service worker based payment handlers, if the web app manifest and the payment method manifest files are located in the same file, then Chrome performs only one HTTP GET request to retrieve it. This patch does not modify Android payment app signature verification, which always makes two separate HTTP GET requests for the payment method manifest and the web app manifest, without comparing the two URLs for equivalence. Bug: 1069954 Change-Id: I83f82058caf3153e8ab2807acea05d350abd9b32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148114Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#759213}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2136b569eb2e..3ebb6e93f417 git log 2136b569eb2e..3ebb6e93f417 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 mbonadei@webrtc.org Remove WebRTC-ExcludeTransportSequenceNumberFromFec. Created with: gclient setdep -r src/third_party/webrtc@3ebb6e93f417 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia2bd21b75eaef78a7e2122b22efeb6924c118c24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150414Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5ca2a6d45d61..f130314cc50c git log 5ca2a6d45d61..f130314cc50c --date=short --first-parent --format='%ad %ae %s' 2020-04-15 aerotwist@chromium.org Adds rect highlights to CLS records Created with: gclient setdep -r src/third_party/devtools-frontend/src@f130314cc50c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I068daa6937a353518691b8b75cb8826fcd12e7ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150416Reviewed-by:
-
Rune Lillesveen authored
These tests all pass in Safari. Bug: 838526 Change-Id: Ie94cfb255607747f062fdcd77518c7c0c048e482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144144Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Emilio Cobos Álvarez <emilio@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#759210}
-
Guido Urdaneta authored
virtual/webrtc-wpt-plan-b/external/wpt/webrtc/RTCRtpSender-replaceTrack.https.html is timing out on Mac Bug: 626703 Change-Id: I6344a749f9a7de6653cc266382faf8a9f1116acd TBR: hta@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149325Reviewed-by:
-
Alex Ilin authored
ChromeExtensionsAPIClient::ShouldHideResponseHeader() allows to hide the Dice response header from extension. As opposed to the TODO comment, this code is still needed because the response header may be attached to a regular renderer-initiated navigation. Bug: 890006 Change-Id: I6eb8bd880c4354b604fd0c1f9fd152c332ffd3bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148319 Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759208}
-
Mark Cogan authored
Change-Id: I24aead570e61d9451372f9b4a0a792c12bbe2ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149455 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#759207}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ed70e67c..b7b5fba5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idfce415f66c6121422437c865078dbfaa45db02a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143838Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759206}
-
Antonio Gomes authored
BUG=767015, 1063749 R=rego@igalia.com Change-Id: Ie7b38d16617059f7170c4e01c70ad7bf22cceec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143834Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#759205}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6e0d718a48d8..5e7ef660be4a git log 6e0d718a48d8..5e7ef660be4a --date=short --first-parent --format='%ad %ae %s' 2020-04-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src f89de66a9bcb..da9102fb013d (3 commits) Created with: gclient setdep -r src/third_party/angle@5e7ef660be4a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I73aa14fc2907aeb3804fc1821e5eda6ad8fdd281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150412Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ef991621e00a..5ca2a6d45d61 git log ef991621e00a..5ca2a6d45d61 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 sigurds@chromium.org [devtools] Update protocol Created with: gclient setdep -r src/third_party/devtools-frontend/src@5ca2a6d45d61 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8eccbe74fdb32fd5fabd5327198c6bc766ddd9d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150413Reviewed-by:
-
Abhijeet Kandalkar authored
Migrate this test out of t_p/blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. This test verifies that the border, margin and padding works properly combining RTL direction with different writing-modes. Bug: 1063749, 767015 Change-Id: I001aefe3ad2aa7ab5d75b95a0649ebaa8f5ad1c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145525 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#759202}
-
Patrick Rohr authored
Adding support for casting to 4k Android TV devices. use_goma=true target_os="android" target_cpu="x86"' \ && ninja -j500 -C out/Debug media_base_junit_tests \ && out/Debug/bin/run_media_base_junit_tests Test: gn gen out/Debug --args='is_chromecast=true is_debug=true \ Bug: 1064263 Change-Id: Ibd1fed93af30fd38a2ede189641aa5da0e5225ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117733 Commit-Queue: Patrick Rohr <prohr@google.com> Auto-Submit: Patrick Rohr <prohr@google.com> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#759201}
-
Roman Sorokin authored
This should prevent DCHECKs in wizard_controller on multiple button presses. Fixed: 1069240 Change-Id: Iffc71c7bf0f602ce4d3bf84ff5176afc99b49be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144150Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759200}
-
chromium-autoroll authored
fuchsia/third_party/aemu/linux-amd64/+log/vN52w.....b4mdc... Created with: gclient setdep -r src/third_party/aemu-linux-x64@b4mdc... If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: chonggu@google.com Change-Id: I0a2749ecdcb1ca9082dfeb551cf49d5689930a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150408Reviewed-by:
-
Henrique Ferreiro authored
Migrate this test out of third_party/blink/web_tests/fast/css-grid-layout/ into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749, 767015 Change-Id: I0cb225a60fae7ae40746307983a795cdbfdd35f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148779 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
Anders Hartvoll Ruud authored
When animating font-affecting properties (e.g. font-size) while the base style contains font-relative units (e.g. em), we can not use the base computed style optimization, since the font-relative units in the base must respond to the font animation. A has_font_affecting_animation_ flag was recently added to ElementAnimations to assist in disabling the optimization under these circumstances. However, that was added with an insufficient understanding of ElementAnimation's lifetime, and hence this flag doesn't really work properly. For example, if we have an animation that initially doesn't affect the font, but then suddenly affects the font after all via setKeyframes, we would paint one incorrect frame before discovering that the font is now affected, and then (for frame #2 and subsequent) we'd be able to disable the optimization. This CL instead checks if the EffectStack affects the font when we're considering the base computed style for use. Bug: 437689 Change-Id: If07f1e82559673433be0a80d2c3edea1c1a5165a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139662Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#759197}
-
Clemens Arbesser authored
Bug: b/145043394 Change-Id: Ife128befc4c910b89accd97e505c3864fff51452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145888 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#759196}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I07c94fce6e4a9bfcf91439229d23e3a742ef9b0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150411Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e70d25f6fa5d..c018fc6ae667 git log e70d25f6fa5d..c018fc6ae667 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 afdx@google.com spirv-fuzz: Do not outline regions that produce pointer outputs (#3291) 2020-04-14 afdx@google.com spirv-fuzz: Handle OpRuntimeArray when replacing ids with synonyms (#3292) 2020-04-14 afdx@google.com spirv-fuzz: Handle image storage class in donation (#3290) 2020-04-14 afdx@google.com spirv-fuzz: Respect rules for OpSampledImage (#3287) 2020-04-14 afdx@google.com spirv-fuzz: Fix comment. (#3300) 2020-04-14 stevenperron@google.com Sampled images as read-only storage (#3295) 2020-04-14 alanbaker@google.com Remove implicit fallthrough (#3298) 2020-04-14 stevenperron@google.com Add tests for recently added command line option (#3297) 2020-04-14 dneto@google.com If SPIRV-Headers is in our tree, include it as subproject (#3299) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@c018fc6ae667 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,timvp@google.com Change-Id: I682efd148acd3e3f23bb99ca8fd59cb31ca19ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150409Reviewed-by:
-
Yoshifumi Inoue authored
This patch removes |DCHECK(current_drag_data_.IsNull())| to avoid crash when test scripts don't finish mouse drag, e.g. not to call |eventSender.mouseUp()| because of assertion failure in w3c test scripts for ease of writing test scripts. This patch is suggested in another CL[1]. [1] http://crrev.com/c/2148920 Make editing/selection/drag-in-iframe.html not to crash Bug: 707656 Change-Id: I989c1fe8cceb39566e3f8ddda364b4dc9cc060aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150346 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759193}
-
Ye Kuang authored
https://chromium.googlesource.com/infra/luci/client-py.git/+log/cc958279ffd6..160b445a44e0 $ git log cc958279f..160b445a4 --date=short --no-merges --format='%ad %ae %s' 2020-04-15 tikuta swarming/client: set client and version in User-Agent 2020-04-15 tikuta net: add set_user_agent 2020-04-14 yekuang [swarming] Add user-agent header to the client requests 2020-04-14 tikuta Revert "client: add filename and line in logging" 2020-04-10 yekuang run_isolated.py: Propagate the exceptions from upload_items() to the main thread 2020-04-09 qyearsley Run spellchecker on luci-py. 2020-04-09 tikuta client: add verify_push flag to archive_files_to_storage 2020-04-09 jwata [swarming-client] evict corrupted files in local cache 2020-04-09 yekuang Send SIGTERM to the isolated download process when it times out 2020-04-08 tikuta client: update isolated client 2020-04-08 tikuta client: include relevant logs only in update_isolated.sh 2020-04-01 tikuta client: update isolated client 2020-04-01 tikuta client: update isolated client 2020-04-01 tikuta client: add script to update isolated in run_isolated.py 2020-03-31 tikuta client: check hash of uploaded file 2020-03-30 tikuta client: add filename and line in logging 2020-03-30 yekuang client: update isolated client 2020-03-27 tikuta client: update isolated client 2020-03-27 leilei Update luci_context.py, otherwise it is failed to get LUCI context in Python3. 2020-03-23 leilei Reland "Update Swarming client code to make it work with Python3." 2020-03-23 tikuta Reland "client: remove --extra-variable flag from isolate.py" 2020-03-19 tikuta client: show exception when failed to run command 2020-03-19 mattkot Re-cache free disk space when _load fails 2020-03-18 tikuta Revert "client: remove --extra-variable flag from isolate.py" 2020-03-17 tikuta Revert "Update Swarming client code to make it work with Python3." 2020-03-17 leilei Update Swarming client code to make it work with Python3. 2020-03-12 tikuta swarming: show account id when failed to get oauth_token Created with: roll-dep src/tools/swarming_client Bug: 1070487 Change-Id: I5892e5bb9256037ef48de29d920969dba9f94372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148898Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Ye Kuang <yekuang@google.com> Cr-Commit-Position: refs/heads/master@{#759192}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bce98d0a1b9f..ef991621e00a git log bce98d0a1b9f..ef991621e00a --date=short --first-parent --format='%ad %ae %s' 2020-04-15 tvanderlippe@chromium.org Update Karma to 5.0.1 Created with: gclient setdep -r src/third_party/devtools-frontend/src@ef991621e00a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1068145 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2490de3c80a1b82ea4a21529ad243cf3dfa85502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150410Reviewed-by:
-
