- 01 Mar, 2019 40 commits
-
-
Kyle Milka authored
Move the GoogleURLTracker shutdown from the test destructor to TearDown(). This ensures it gets shutdown before the checks in ~TestBrowserThreadBundle() run. Bug: 937041 Change-Id: I6f43cc369f2e482de02771173d1bf2ae7237f70d Reviewed-on: https://chromium-review.googlesource.com/c/1497220Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#636969}
-
Ben Wagner authored
This will hold out a Skia change until it can be rebased. Change-Id: Ia05b61fda1a3b88038ddea07fee628cc3a648972 Reviewed-on: https://chromium-review.googlesource.com/c/1497352Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#636968}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/727c16174db3..021adeeeb408 git log 727c16174db3..021adeeeb408 --date=short --no-merges --format='%ad %ae %s' 2019-03-01 benjhayden@chromium.org Add TimeseriesMerger for spa Created with: gclient setdep -r src/third_party/catapult@021adeeeb408 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:918193 TBR=sullivan@chromium.org Change-Id: Id2cf91eb270d8f15493935481e014abee07355d4 Reviewed-on: https://chromium-review.googlesource.com/c/1497130Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636967}
-
Marcin Wiącek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values. 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Patch is migrating ScreenCapture into @IntDef using rules similar to other @IntDef inside Chromium project: 1. with @IntDef/@StringDef first, @Retention second and related @interface third 2. with values inside @interface 3. with @Retention(RetentionPolicy.SOURCE) 4. without "static final" in the @interface BUG=919666 Change-Id: If2290da1f0386eb50e00f65de4d3f6559da3e04f Reviewed-on: https://chromium-review.googlesource.com/c/1495975Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#636966}
-
Céline O'Neil authored
This CL adds the possibility of multiple SolidColorDrawQuads in the fuzzed CompositorFrame RenderPass, and also introduces simple fuzzing for the SharedQuadState associated with each quad. One thing in particular to watch out for here is that a non-invertible SharedQuadState Transform will get through message deserialization, but likely cause DCHECKs to fail when drawing the RenderPass. I expect that ClusterFuzz will find a few ways of triggering these checks with different interesting values of |scale_x| and |scale_y|. R=kylechar@chromium.org, riajiang@chromium.org Bug: 923088 Change-Id: Ie51340c45c406d235047f6baabf24f947a51722b Reviewed-on: https://chromium-review.googlesource.com/c/1496096Reviewed-by:
Ria Jiang <riajiang@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Céline O'Neil <celineo@google.com> Cr-Commit-Position: refs/heads/master@{#636965}
-
Edin Kadric authored
This was introduced in crrev.com/c/1466186 which didn't return right after the potential call to CancelAll anymore. Instead it would try to access a member variable and cause a crash. Bug: 937206 Change-Id: I26a210d464e1c57b071f599e64bcb68a09a16c54 Reviewed-on: https://chromium-review.googlesource.com/c/1496557Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Edin Kadric <edinkadric@google.com> Cr-Commit-Position: refs/heads/master@{#636964}
-
Alexei Filippov authored
This is a reland of 684f4185 Original change's description: > [heap profiler] Make use of thread_local instead of base::TLS > > The C++ thread_local is slightly faster while making the code clear. > Besides that calls to TlsGetValue on Windows may alter the result of > GetLastError, thus changing behavior of the underlying code. > > BUG=920440 > > Change-Id: Ic89632f4a54f35d58b93cdecfffc68fc1a94dac1 > Reviewed-on: https://chromium-review.googlesource.com/c/1461681 > Reviewed-by: Vlad Tsyrklevich <vtsyrklevich@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Commit-Queue: Alexei Filippov <alph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#632819} Bug: 920440 Change-Id: I1eb5beee2cdcaa8b23deae4cd06a1e723847f681 Reviewed-on: https://chromium-review.googlesource.com/c/1495452 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#636963}
-
Michael Warres authored
Roll src/net/third_party/quiche/src/ 3cab5a95c..c5db41e3e (3 commits): 2019-02-25 bnc Revert "DO NOT CHECK IN test" 2019-02-25 bnc DO NOT CHECK IN test 2019-02-22 bnc Update references to RFC7540 and RFC7541 in hpack_constants.h. https://chromium-review.googlesource.com/c/chromium/src/+/1496912 Sync flags. https://chromium-review.googlesource.com/c/chromium/src/+/1496911 Deprecate --quic_clear_probing_mark_after_packet_processing. Merge internal change: 235707109 https://chromium-review.googlesource.com/c/chromium/src/+/1496654 Change QuartcEndpoint into an interface with client and server implementations. Merge internal change: 235087155 https://chromium-review.googlesource.com/c/chromium/src/+/1496055 Deprecate FLAGS_quic_reloadable_flag_quic_enable_version_45. Also remove QUIC_VERSION_45 code. Merge internal change: 235041269 https://chromium-review.googlesource.com/c/chromium/src/+/1496012 Add default action to mock WritevData calls in QuicSpdyStreamTest. Merge internal change: 234995172 https://chromium-review.googlesource.com/c/chromium/src/+/1496011 Allow 0-rtt setup with Quartc dispatcher. Merge internal change: 234994150 https://chromium-review.googlesource.com/c/chromium/src/+/1496010 In QUIC, runs one loss algorithm per packet number space. Protected by FLAGS_quic_reloadable_flag_quic_use_uber_loss_algorithm. Merge internal change: 234991403 https://chromium-review.googlesource.com/c/chromium/src/+/1496009 Deprecate QUIC variable length connection ID flags. This CL deprecates the following related flags: quic_restart_flag_quic_connection_ids_network_byte_order quic_restart_flag_quic_variable_length_connection_ids_client quic_restart_flag_quic_variable_length_connection_ids_server Merge internal change: 234892077 https://chromium-review.googlesource.com/c/chromium/src/+/1496007 Move QuicInterval and QuicIntervalSet from platform to shared QUIC code. Refactor only, not protected. Merge internal change: 234867624 https://chromium-review.googlesource.com/c/chromium/src/+/1495866 Put code for HTTP/3 data streams into its own category instead of simply using QUIC_VERSION_99. Code refactoring. Not protected. Merge internal change: 234866055 https://chromium-review.googlesource.com/c/chromium/src/+/1495995 Add support for coalesced packets. This CL adds support for receiving coalesced packets but does not yet make us send them. Merge internal change: 234827025 https://chromium-review.googlesource.com/c/chromium/src/+/1495857 Fix bad retry token length type. Merge internal change: 234698178 https://chromium-review.googlesource.com/c/chromium/src/+/1495855 Add support for long header length field. This CL introduces QuicVersionHasLongHeaderLengths(version) which is currently only true for v99. When that is true, it sends IETF long header lengths and parses them on reception. Merge internal change: 234676268 https://chromium-review.googlesource.com/c/chromium/src/+/1494897 Rename ENCRYPTION_INITIAL to ENCRYPTION_ZERO_RTT Merge internal change: 234667407 https://chromium-review.googlesource.com/c/chromium/src/+/1493475 Use CRYPTO frames for crypto handshake. Gated behind QUIC version 47. Merge internal change: 234633068 https://chromium-review.googlesource.com/c/chromium/src/+/1493474 Connect QuartcSession's visitor to the dispatcher. Merge internal change: 234611305 https://chromium-review.googlesource.com/c/chromium/src/+/1492041 Add DCHECKs to GetStreamType(). Merge internal change: 234235243 https://chromium-review.googlesource.com/c/chromium/src/+/1492736 R=rch@chromium.org Change-Id: I888f49bff6b2e7cd55b03c31b4f8665a9ff298d7 Reviewed-on: https://chromium-review.googlesource.com/c/1496309 Commit-Queue: Michael Warres <mpw@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Steve Anton <steveanton@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#636962}
-
Andrew Xu authored
Split the original CL as code reviewer requests. In this CL, it assumes that DisplayConfigurator is notified when user connects device with excessive displays. Code here mainly focuses on creating the display notification for that event. Design doc link is on the issue page. Introduction of original CL: User may connect more external displays than the number of crtc that the device can provide. On some latest chromebooks (like Pixel book), when it happens, one of connected external displays (randomly chosen) gets disconnected. However there is no notification for it. And this CL tries to fix this problem. Test: ash_unittests Bug: 827406 Change-Id: I6c0e08e54d3b43a89608ce1249f68a569f04e012 Reviewed-on: https://chromium-review.googlesource.com/c/1373110 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Mitsuru Oshima (OOO til 3/4) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#636961}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2997ec9a7a46..ed50e6c7596d git log 2997ec9a7a46..ed50e6c7596d --date=short --no-merges --format='%ad %ae %s' 2019-03-01 srte@webrtc.org Inject TaskQueueFactory in RtpTransportControllerSend. 2019-03-01 titovartem@webrtc.org Intermediate step: Move ownership of rtc::NetworkManager to test code from PC E2E framework 2019-03-01 srte@webrtc.org Removes injection of RtpTransportControllerSend from Call::Create. 2019-03-01 jakobi@webrtc.org Remove field trial include from decision logic. 2019-03-01 philipel@webrtc.org Remove memsets of CodecSpecificInfo. Created with: gclient setdep -r src/third_party/webrtc@ed50e6c7596d The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iec107bd85a5986622c5cfc3fbf2c2cdab0c3eaae Reviewed-on: https://chromium-review.googlesource.com/c/1495731Reviewed-by:
-
Siddhartha S authored
The functions with prefix are only useful internally. So, do not expose them in public api. This reduces the binary size impact of proto db. BUG=870813 Change-Id: I846d351aa6ca54ac25e0bb8c91e0b0d2e032162f Reviewed-on: https://chromium-review.googlesource.com/c/1392171 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#636959}
-
Guillaume Jenkins authored
This adds a new unfillable field type, PRICE, to the heuristics. The idea is that by adding more specific field types instead of using UNKNOWN, it will help reduce cases where fields are detected as the wrong type. For example, go to https://cydemind.bandcamp.com/album/erosion and click "Buy Digital Album". In the popup, there is a "Name your price" input, which gets incorrectly detected as NAME_FIRST. Bug: crbug.com/807748 Change-Id: I8ee3ddbf7bc6928817c7c886e8431a338db1b5b6 Reviewed-on: https://chromium-review.googlesource.com/c/1495200 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#636958}
-
Yuwei Huang authored
The ICE servers printed by the FTL signaling playground should be part of the user interaction flow, rather than logs, so it makes more sense to print them using printf. Bug: 927962 Change-Id: I7253c358067ca552fa1ed58af4ad4907c3e81c56 Reviewed-on: https://chromium-review.googlesource.com/c/1496442 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#636957}
-
Allison Pastewka authored
Added checks to see if the test is being run on windows and if so replaced the backslashes with forward slashes. I also changed the file open to write the file in binary so that line endings are not converted. Change diffing tool being used from diff(1) to Python's difflib module. diff(1) is a Unix diffing tool so it does not run on Windows. Python's difflib module will work on all computers and the speed of the module won't be an issue because there is a fairly small number of test files. Bug: 929019 Change-Id: I24e43f6599a8ce839af4dc2cec18dc56acd13bad Reviewed-on: https://chromium-review.googlesource.com/c/1479309Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Allison Pastewka <alpastew@microsoft.com> Cr-Commit-Position: refs/heads/master@{#636956}
-
Mustafa Emre Acer authored
Bug: 936565 Change-Id: I7314b645e7076b17b08b93ab9353f49c08679712 Reviewed-on: https://chromium-review.googlesource.com/c/1492036Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#636955}
-
Tarun Bansal authored
Change-Id: I8b109f7992797d796495829d16c5db4906587fb8 Reviewed-on: https://chromium-review.googlesource.com/c/1492431 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#636954}
-
Alexei Filippov authored
Extend the implementation of base::SamplingHeapProfiler to support: * PSEUDO and MIXED call stack modes * Allocation context recording * Thread name recording Switch SamplingProfilerWrapper to use base::SamplingHeapProfiler for the in-process mode. TBR=dcheng@chromium.org BUG=923459 Change-Id: I9783a9c60f287332d5fb7410fbe672ee83010ece Reviewed-on: https://chromium-review.googlesource.com/c/1492951 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
-
Nate Fischer authored
This adds a developer guide for the WebView shell. This covers building and installing, but also shows how to interact with the shell via the commandline. This cross-links to the shell's folder (adding a README.md), but keeps primary documentation under android_webview/docs/ to improve discoverability. Bug: 918221 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: I6216bb70a42989910044cfc56e56314a4e2bc781 Reviewed-on: https://chromium-review.googlesource.com/c/1490909 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#636952}
-
Kyle Horimoto authored
The menu item should not be shown in some cases (e.g., for secondary users). Bug: 931608 Change-Id: I81a8bcb57905584c3806738d61c694bfb8d7a6a6 Reviewed-on: https://chromium-review.googlesource.com/c/1470743 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#636951}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1223e7fc0a3c..436d47d5bde9 git log 1223e7fc0a3c..436d47d5bde9 --date=short --no-merges --format='%ad %ae %s' 2019-03-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 1dc32aec..cddf8925 (456 commits) 2019-03-01 halcanary@google.com SkQP: Fix report 2019-03-01 mtklein@google.com update high-contrast color filter for tagged SW destinations 2019-03-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader a1924739029e..dd1e37e31d68 (1 commits) 2019-03-01 ianloic@google.com Clean up SkFontMgr_fuchsia.cpp after FIDL API change 2019-03-01 reed@google.com fix docs for fitsInBytes 2019-03-01 kjlubick@google.com [canvaskit] Roll 0.4.1 2019-03-01 mtklein@google.com fix labels in P3 gm Created with: gclient setdep -r src/third_party/skia@436d47d5bde9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I4f069c211df0f8adeaeb0c8db28748adf74d9a22 Reviewed-on: https://chromium-review.googlesource.com/c/1495730Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/dd1e37e31d68..37c024a6a7fd git log dd1e37e31d68..37c024a6a7fd --date=short --no-merges --format='%ad %ae %s' 2019-03-01 capn@google.com Remove src/Vulkan directory from CMake include path Created with: gclient setdep -r src/third_party/swiftshader@37c024a6a7fd The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ia6a52981644c49da147c8dd29dec29487b85eee8 Reviewed-on: https://chromium-review.googlesource.com/c/1496960Reviewed-by:
-
Tiancong Wang authored
In crc32c BUILD.gn file, it sets -march flag to armv8-a+crc+crypto in order to support some special instructions. However, on Chrome OS, it also sets -march flag for ARM64 which might mask the flag set by GN file. This CL fixes this problem by passing "crc" and "crypto" directly to clang through "-target-feature" flag. As suggested by the reviewers, the CL changes to flag to clang only and applies to all platforms. CL crrev.com/c/1489392 Bug: chromium:934016 TEST: Tested on Chrome OS with tryjobs kevin64 and arm64 with testing Change-Id: Ifb4a50308f230a7d8198f3cd4b92301e63724e6d Reviewed-on: https://chromium-review.googlesource.com/c/1492489 Commit-Queue: Tiancong Wang <tcwang@google.com> Auto-Submit: Tiancong Wang <tcwang@google.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#636948}
-
Kevin Ellis authored
Summary of changes: - Switch from synchronous to asynchronous mutations when called on the compositor thread. - Use appropriate queue strategy depending on which tree is being animation. - Wait until mutation request is resolved before requesting impl frame and draw. - Split status for successful completion of a mutation cycle to include if any updates were performed to avoid unnecessary paints. - Plumbing of mutation callback to the layer tree host and scheduler. Bug: 791280 Change-Id: I9cba2bfe8ac51a541fc63d6dd96df17e0bf67bb9 Reviewed-on: https://chromium-review.googlesource.com/c/1481738 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#636947}
-
Aran Gilman authored
This allows modifying the settings according to the output of ShouldApplyHighContrastSettings() in a follow-up CL. Bug: 925949 Change-Id: I2bff529a360ffd39923e0b3e120f2d07fc3bf3a6 Reviewed-on: https://chromium-review.googlesource.com/c/1490444Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#636946}
-
Antonio Gomes authored
Driven-by CL, and follow up of jbroman's remark in [1]. This CL simplifies TargetIsFrame function in core/input/event_handler.cc, given that it produces two values, and the usage always checks both, even though the function returns true if it produces a non-null value. [1] https://crrev.com.com/c/1487391/3/third_party/blink/renderer/core/input/event_handler.cc BUG=None Change-Id: Ib556803d078fad3fd5b48dbdb1e6a4e5e6a1ed15 Reviewed-on: https://chromium-review.googlesource.com/c/1496215 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#636945}
-
Ehsan Karamad authored
This CL extends the sandbox to feature policy integration by adding support for CSP or any DocumentInit related sandbox flags. These flags are applied with the header policies. The change fixes some WPT/LayoutTests under the virtual suite FeaturePolicyForSandbox. Bug: 812381, 926247, 926248, 926249, 929678 Change-Id: I2ba7d47b4f3d0f70f246a8c0902e2617c7e10332 Reviewed-on: https://chromium-review.googlesource.com/c/1492483Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#636944}
-
rbpotter authored
Splitting up long SetCopies test and moving to a separate file. Also restoring testing of collate checkbox visibility via a new CollateVisibility test. Change-Id: If6891f29e597a2d8dd1e628a946c555b61b1441d Reviewed-on: https://chromium-review.googlesource.com/c/1493393 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#636943}
-
Frank Poole authored
This change implements UIA_FlowsFromPropertyId for IRawElementProviderSimple::GetPropertyValue and adds associated unit and browser tests. Additional test helper methods are introduced to AXPlatformNodeWinBrowserTest. Bug: 844149 Change-Id: I7c88a938e203d04fb2fdb5c83ce8ab4fd90d5746 Reviewed-on: https://chromium-review.googlesource.com/c/1493514 Commit-Queue: Frank Poole <frpoole@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#636942}
-
Khushal authored
R=piman@chromium.org Bug: 889328 Change-Id: I5270d343bbbd48fd250863929e42c47186ef0ff0 Reviewed-on: https://chromium-review.googlesource.com/c/1496597 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#636941}
-
Shimi Zhang authored
addJavascriptInterface() won't be able to inject JavaScript interface soon enough to be called by an immediate evaluateJavascript(). This CL moved addJavascriptInterface() to before loading web page, since we wait until onPageFinished() to call evaluateJavascript(), it should be enough to finish addJavascriptInterface(). Bug: 937116 Change-Id: I8b6a70b32af638921f79648d6924346f31685bd4 Reviewed-on: https://chromium-review.googlesource.com/c/1496451 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#636940}
-
Kevin Bailey authored
When the tab switch button was "focused", the tab key wasn't working because the routine involved was returning true, saying that it had handled the tab key. This CL changes that. Arrow keys still need to return true in this case, so 'AtEndWithTabSwitch()' was broken up into 'BidirAtEnd()' and 'SelectedSuggestionHasTabSwitch()' so that the tab key can ignore the first condition, while arrow keys consider it. Bug: 936851 Change-Id: I84b8b2e41f2601c978d31405b727eb60ea3c78c0 Reviewed-on: https://chromium-review.googlesource.com/c/1495198 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#636939}
-
Karen Qian authored
This allows for branch urls to be added to the CQ. Bug: 922150 Change-Id: Ic4380a87610949fbc0443d0a17b0021821e390e9 Reviewed-on: https://chromium-review.googlesource.com/c/1497180 Commit-Queue: Karen Qian <karenqian@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#636938}
-
Mario Sanchez Prada authored
Bug: 929973 Change-Id: Idbe28468069455b9f460728820bed6a9c4397cf1 Reviewed-on: https://chromium-review.googlesource.com/c/1494891 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Veranika Liaukevich authored
UserInitiatedChromeCleanups was enabled by default in M67. Change-Id: I98b9b3da11bc7bbb44e58e9101b589cf6b666788 Reviewed-on: https://chromium-review.googlesource.com/c/1491852 Commit-Queue: Veranika Liaukevich <veranika@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#636936}
-
chrome://history-framedpapad authored
Since M59, this URL simply forwards to chrome://history. This CL removes the redirect. reached" page. Bug: None Test: Visit chrome://history-frame, should see "This site can’t be Change-Id: I6642b4be8b1b28ba9471b1dc64aa24a444aaeed2 Reviewed-on: https://chromium-review.googlesource.com/c/1496494 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#636935}
-
Victor Fei authored
- Enabled/implemented IsOffscreen property for UIA in AXPlatformNodeWin::GetPropertyValue and assoicated browser tests. GetPropertyValue calculates isOffscreen status by utilizing AXTree::RelativeToTreeBounds, which looks at the bounds of the node relative to its ancestor and rootWebArea bounds to determine the isOffscreen status. - Modified AccessibilityWinBrowserTests::FindNodeInSubtree to take into account of StringAttribute::kValue when finding the node. Bug: 844149 Change-Id: Ied62e00814957a6ca97b1849935ec692f1acf03a Reviewed-on: https://chromium-review.googlesource.com/c/1481800 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/19dd955a0744..b2b876f75ba1 git log 19dd955a0744..b2b876f75ba1 --date=short --no-merges --format='%ad %ae %s' 2019-03-01 chrome-bot@chromium.org Update config settings by config-updater. 2019-03-01 dgarrett@google.com chromeos_config: Change packages for old factorybranches. Created with: gclient setdep -r src/third_party/chromite@b2b876f75ba1 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I4868d817bc7911e01f11b339b6ef66952d40e228 Reviewed-on: https://chromium-review.googlesource.com/c/1496103Reviewed-by:
-
Luum Habtemariam authored
Now checking for nullptr before assigning the char* result from ippGetName. Bug: chromium:935873 Test: Unittests still pass. Change-Id: Ic5d665b69e41821dd44abb41efcee6276655cf13 Reviewed-on: https://chromium-review.googlesource.com/c/1490753Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#636932}
-
Shuotao Gao authored
The URL to the new flake portal will be https://analysis.chromium.org/p/chromium/flake-portal "Flake Portal" refers to the set of tools that Findit provides to deal with flakiness. In Findit, the data in /p/chromium/flake-portal/flakes are flaky tests only, because successful and consistently failed tests are filtered out. Besides, Findit has following features: 1) Flake Report: aggregation of flakiness data by crbug component. 2) Flake Analysis: find the culprit commit for a flaky test; verify flake fixes. 3) Flake bug management: auto-create flake bugs, comment on existing bugs filed by human, auto-merge flake bugs if the root cause is the same culprit, etc. Also reworded the original "Flakiness Dashboard" to "Legacy Flakiness Dashboard". It shows the full history of a specific test. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ChromeVoxLiveRegionsTest.LiveStatusOff Bug: 934569 Change-Id: Ib05c43b67bf0f87307c135ca3f630200a7daf78f Reviewed-on: https://chromium-review.googlesource.com/c/1482113 Commit-Queue: Shuotao Gao <stgao@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#636931}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d7ccfee2ef7c..6ecc5174ac93 Created with: gclient setdep -r src-internal@6ecc5174ac93 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:937214,chromium:937241 TBR=mmoss@chromium.org Change-Id: Ice2f3a35edbd3033d1aaf996e57df32bd7dbed79 Reviewed-on: https://chromium-review.googlesource.com/c/1496959Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636930}
-
