GitLab

- Most visited iframe now uses postMessage() to signal the iframing page that the link has been displayed.
- Refactor most_visited_thumbnail.js to eliminate client-side secondary thumbnail fallback.
- Refactor UMA logging of NTP suggestions events.

The new postMessage() signal is sent whenever the iframe has failed loading the thumbnails, or when the thumbnail has been successfully loaded. This way it's impossible for the iframing page to learn whether the user has a given URL in its TopSites. The iframing page can use that signal to know when it's possible to display a fallback visual under the iframe.

The refactor significantly simplifies the iframe javascript by dropping support for multiple thumbnails, which can now be handled by the iframing page. UMA logging of NTP suggestions related statistics have also been both simplified and augmented. The patch also includes better unit tests for the UMA logging.

BUG=None

Review URL: https://codereview.chromium.org/102433009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245579 0039d316-1c4b-4281-b951-d872f2087c98

Skip DisplayManagerTest.ScreenAfterShutdown on win8 (which doesn't support multiple dislpays on ash)

BUG=NONE
RDANBEAM

R=dbeam@chromium.org

Review URL: https://codereview.chromium.org/142003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245578 0039d316-1c4b-4281-b951-d872f2087c98

Add a flag to disable GLIBCXX_DEBUG which is used in the GYP build on some bots.

TBR=scottmg

Review URL: https://codereview.chromium.org/141703004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245577 0039d316-1c4b-4281-b951-d872f2087c98

Ensure no changes to the JSONSerializer or PrefHashCalculator ever end up producing different hashes for all existing Value::Type.

The current JSON serialization used "appears" to be standard and future-proof (i.e., doesn't use pretty_print or anything silly).

However, the hashing mechanism must be strong in the face of any potential future logic changes to either JSONWriter, JSONStringValueSerializer, PrefHashCalculator. This test protects against that.

As highlighted in code comments these test hashes must never be altered to satisfy a code logic change or PrefHash* breaks.

Kept existing test hashes for list/dict values and expanded the test to all other values.

Review URL: https://codereview.chromium.org/136473008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245576 0039d316-1c4b-4281-b951-d872f2087c98

For foolish consistency. I'll never make this mistake again.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/140503005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245573 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245572 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334796,307841

Review URL: https://codereview.chromium.org/137893023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245571 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245570 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=165311:165317&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/140983006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245569 0039d316-1c4b-4281-b951-d872f2087c98

Along the way, replace the official key check in DriveAppRegistry::IsUninstallSupported
by the new devoted function. (In fact, the macro is available
only during google_apis/ hence the previous code was not working well...)


BUG=332332

Review URL: https://codereview.chromium.org/140783006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245565 0039d316-1c4b-4281-b951-d872f2087c98

BUG=288991
R=bradnelson@google.com
Reland of r245254

Review URL: https://codereview.chromium.org/141053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245563 0039d316-1c4b-4281-b951-d872f2087c98

* Split ScreenAsh to ScreenUtil (set of utility functions) and the screen implementation.
* moved screen_ash from Shell to DisplayManager. Ash specific imp is now hidden in DisplayManager.
* Shell now creates a separate screen object which simply keeps the list of displays for shutdown. This allow all screen operation valid during shutdown.

BUG=None
TBR=hongbo.min@intel.com,sky@chromium.org

Review URL: https://codereview.chromium.org/138003007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245562 0039d316-1c4b-4281-b951-d872f2087c98

BUG=335280
TEST=browser_test --gtest_filter=FirstRunUIBrowserTest.FirstRunFlow

Review URL: https://codereview.chromium.org/141803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245561 0039d316-1c4b-4281-b951-d872f2087c98

This is a prerequisite to adding the incompatible folders check to the
AOSP bot.

BUG=329540
TEST=run tool

Review URL: https://codereview.chromium.org/133073008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245560 0039d316-1c4b-4281-b951-d872f2087c98

This allows us to remove more ExtensionService dependencies, which we need
to do because app_shell doesn't have an ExtensionService.

BUG=334706
TEST=existing unit_tests, browser_tests
TBR=sky@chromium.org for mechanical changes across the non-extensions bits of chrome/browser/

Review URL: https://codereview.chromium.org/139943005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245556 0039d316-1c4b-4281-b951-d872f2087c98

ServiceRuntime::InitCommunication is a large method that does several things:
  - Sets up a command channel.
  - Loads a module (nexe).
  - Sets up a reverse channel.
  - Starts a module (nexe).

This change breaks this up into smaller methods. As part of the trusted plugin
refactor, we'll probably move setting up the reverse channel before loading the
module, and join loading and starting the module into one step.

This change should make the changes to use Chromium IPC easier to follow.

BUG=333950

Review URL: https://codereview.chromium.org/133073005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245555 0039d316-1c4b-4281-b951-d872f2087c98

In accordance with popular opinion.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/133453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245552 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334358

TEST:
On a Pixel, install a downloads extension such as this.
https://chrome.google.com/webstore/detail/download-manager-button/jglgknilkoejnnjngnmoobbhdckpdmem
Either right-click on the browser action button and Inspect Popup, or open the background page console.
If there are no downloads, download a file so that there's a file icon to inspect. One easy way to download a file is to open this data url and click the link:
data:text/html,<a href="data:application/octet-stream," download=test-137043005.txt>download an empty file
Copy this javascript into the Developer Tools console:
chrome.downloads.search({limit:1}, function(items) {matchMedia('screen and (-webkit-min-device-pixel-ratio: 1.5)').addListener(function() {chrome.downloads.getFileIcon(items[0].id, function(icon) {console.log('dpr', devicePixelRatio, icon);});});});
This javascript finds a DownloadItem and listens for the devicePixelRatio to change, then fetches the file icon for the new devicePixelRatio.
Type Ctrl+Shift+- and Ctrl+Shift+= to decrease and increase the screen resolution until the console logs at least one line that begins with 'dpr 1' and another line that begins with 'dpr 2'. You might need to increase and/or decrease the resolution several times. The rest of the 'dpr 1' line should be different from the rest of the 'dpr 2' line. If the rest of those lines are the same, then this fix is broken.

Review URL: https://codereview.chromium.org/137043005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245550 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jamesr

Review URL: https://codereview.chromium.org/141103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245549 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Revert of Enable OrientationEvent only for android. (https://codereview.chromium.org/130053005/)

Reason for revert:
Fixed the original issue and tested content_shell to load and pass orientation test case. https://codereview.chromium.org/141303002/. 

Original issue's description:
> Revert of Enable OrientationEvent only for android. (https://codereview.chromium.org/131913003/)
> 
> Reason for revert:
> Causes crashes on Android on loading a web page, more details in https://code.google.com/p/chromium/issues/detail?id=335258 
> 
> Original issue's description:
> > Enable OrientationEvent only for android.
> > 
> > BUG=181136, 331337
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245210
> 
> TBR=darin@chromium.org,mahesh.kk@samsung.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=181136, 331337
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245310

TBR=darin@chromium.org,thakis@chromium.org,estade@chromium.org,mariakhomenko@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=181136, 331337

Review URL: https://codereview.chromium.org/133173004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245545 0039d316-1c4b-4281-b951-d872f2087c98

R=mark@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/137783024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245544 0039d316-1c4b-4281-b951-d872f2087c98

interactive_ui_tests and browser_tests both now. :/

TBR=dxie@chromium.org
BUG=330432, 309197

Review URL: https://codereview.chromium.org/130433011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245543 0039d316-1c4b-4281-b951-d872f2087c98

BUG=321305

Review URL: https://codereview.chromium.org/134373003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245541 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245538 0039d316-1c4b-4281-b951-d872f2087c98

It turns out there are 2 constructors, and this boolean was only being
initialized to false in one of them. This caused an extension install
verification request to the verification server on every load of the
chrome://extensions page (regardless of whether the user had any
disabled-due-to-verification-failure extensions).

Also add a histogram for tracking the number of ids that we tried to 
verify which the server replied were invalid (ie not known to be in the
webstore). 


BUG=335379

Review URL: https://codereview.chromium.org/137893021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245535 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245534 0039d316-1c4b-4281-b951-d872f2087c98

BUG=n/a
TEST=compile (mechanical changes only)
TBR=michaeln@chromium.orgjochen@chromium.org

Review URL: https://codereview.chromium.org/136573007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245533 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=165309:165310&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/134643020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245532 0039d316-1c4b-4281-b951-d872f2087c98

BUG=329505

Review URL: https://codereview.chromium.org/98773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245531 0039d316-1c4b-4281-b951-d872f2087c98

This caused XP Tests (2) net_unittests
NextProto/HttpNetworkTransactionTest.UploadFileSmallerThanLength/0, /1, /2,
/3, /4, and UploadDataStreamTest.FileSmallerThanLength to time out.

http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29/builds/32723/

> net: Use FileStream asynchronously from UploadFileElementReader
> 
> InitInternal() and ReadInternal() were used to share the same implementation with UploadFileElementReaderSync.
> There is no need to maintain them since UploadFileElementReaderSync is gone.
> Abandon these unneeded functions and use FileStream in an asynchronous way.
> 
> BUG=294797
> TEST=net_unittests
> 
> Review URL: https://codereview.chromium.org/139253002

TBR=hashimoto@chromium.org

Review URL: https://codereview.chromium.org/141843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245529 0039d316-1c4b-4281-b951-d872f2087c98

Speculative. This may have caused flakiness on multiple bots. See bug 335582.

> Unifies LayerTreeHost::SetNeedsUpdateLayers and SetNeedsAnimate -- V2
> 
> [2/2] Unifies LayerTreeHost::SetNeedsUpdateLayers and SetNeedsAnimate
> 
> They basically do the same thing except that SetNeedsAnimate makes the next
> commit non-cancellable. However there is really no reason why SetNeedsAnimate
> need to enforce a commit even if no tiles are updated and no layer properties
> changed.
> 
> SetNeedsAnimate is thus merged into SetNeedsUpdateLayers. The proper use of
> it is when there are potential layout/tile changes, we can use it to defer
> calculation until the next frame. A commit will be scheduled but can be
> cancelled if no updates are needed after calculation.
> 
> This part of the patch changes code behavior slightly.
> SingleThreadProxy::SetNeedsUpdateLayers was originally implemented as
> RenderWidget::ScheduleComposite but now it is RenderWidget::ScheduleAnimation.
> ThreadProxy::SetNeedsAnimate was non-cancellable but is now cancellable.
> 
> [1/2] Cleanup RenderWidget::scheduleComposite/scheduleAnimation
> 
> scheduleComposite has been renamed to ScheduleComposite as it is no longer
> a part of WebWidgetClient API.
> 
> scheduleAnimation has been renamed to ScheduleAnimation. The semantics is to
> schedule a composite and also (potentially) animating WebWidget.
> 
> A new WebWidgetClient API scheduleUpdate has been added, to replace the old
> scheduleAnimation. The semantics is to notify the embedder that something in
> the WebWidget may change in 0 seconds. (i.e. it is allowed to be called
> during a redraw, in such case another redraw will be scheduled after frame
> delay.
> 
> This part of the patch should not change code behavior.
> 
> BUG=316929
> R=danakj,jamesr,jochen
> 
> Review URL: https://codereview.chromium.org/133263004

TBR=trchen@chromium.org
BUG=335582

Review URL: https://codereview.chromium.org/141833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245528 0039d316-1c4b-4281-b951-d872f2087c98

TBR=earthdok@chromium.org
BUG=NONE

Review URL: https://codereview.chromium.org/141533005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245527 0039d316-1c4b-4281-b951-d872f2087c98

This CL will share worker pool threads across LTHI for a single process.
Idea is to reduce the number of threads used per process.
For this, we implement WorkerPool::Inner as singleton, and LTHI/WorkerPool
would share the same instance per process.

Reviewer: reveman@chromium.org
BUG=239423

Review URL: https://codereview.chromium.org/73923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245526 0039d316-1c4b-4281-b951-d872f2087c98

There really is no good reason to poll for something and not fail
in a test (otherwise we're just adding a sleep). I refactored our
test code to use new AwTestBase methods.

BUG=None
TEST=AndroidWebViewTests
// java-only change, trybots happy
NOTRY=true

Review URL: https://codereview.chromium.org/131743020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245525 0039d316-1c4b-4281-b951-d872f2087c98

The content browsertests file for WebRTC was growing a bit large. I
extracted the getUserMedia-focused tests into a test of its own and
left the peerconnection tests.

Also renamed all WebRTC content browsertests to use the WebRtc naming
convention, which seems to be the most common in the production code.

Note: this patch will require some filter renames on the WebRTC bots.

R=tommi@chromium.org

Review URL: https://codereview.chromium.org/131203005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245524 0039d316-1c4b-4281-b951-d872f2087c98

Will require https://codereview.chromium.org/137793008 to land shortly
after this landing to avoid missing to run tests.

R=tommi@chromium.org
NOTRY=True

Review URL: https://codereview.chromium.org/137753004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245523 0039d316-1c4b-4281-b951-d872f2087c98

All the dependencies of these policy handlers have already been moved into
the policy component, and they can now be moved as well. This enables their
usage on ios builds.

BUG=275292

Review URL: https://codereview.chromium.org/140803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245522 0039d316-1c4b-4281-b951-d872f2087c98

BUG=275292

Review URL: https://codereview.chromium.org/140823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245521 0039d316-1c4b-4281-b951-d872f2087c98

DiscardableMemoryAllocator::AshmemRegion used to implement an interface but this
is not the case anymore therefore there is no reason to keep ~AshmemRegion()
virtual (since AshmemRegion is/should never be subclassed either).

TBR=willchan@chromium.org

Review URL: https://codereview.chromium.org/141283006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245520 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245519 0039d316-1c4b-4281-b951-d872f2087c98