- 11 Feb, 2020 40 commits
-
-
Yulun Wu authored
Bug: 1034168 Change-Id: I8193b727e1635b0f5d368c74157f1ca0f1dd8197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025887 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#740385}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cc2257e06aa7..2c9bed613fc5 git log cc2257e06aa7..2c9bed613fc5 --date=short --first-parent --format='%ad %ae %s' 2020-02-11 taylori@google.com Merge "perfetto-ui: Time preview on log hover" Created with: gclient setdep -r src/third_party/perfetto@2c9bed613fc5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id54e50ca27d6612225416dc57c1042e000299d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050517Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740384}
-
James Cook authored
Fixed by adding preprocess=true to the grd entry for sync_account_control.js such that <if expr="chromeos"> directives will be applied in Debug. Original CL description: Browser settings for sync uses a "sign out" dialog to handle when the user clicks "Turn off". Depending on the use case the dialog title and buttons may say "Turn off" or "Sign out". Update the strings for SplitSettingsSync to use "Turn off". Because Chrome OS users cannot sign out, wire the dialog's "Turn off" button to a new method in PeopleHandler. The existing code path for sign out/disconnect assumes DICE, which Chrome OS does not support. Bug: 1050677 Test: manual, button labels are different (and match Linux) Change-Id: Iad8a89e3f9fccdc239d051e405a805a71b20a6c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047765Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#740068} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050610 Cr-Commit-Position: refs/heads/master@{#740383}
-
Alex Newcomer authored
This disables blur during animations, which improves the performance of hotseat animations. Bug: 1031266 Change-Id: I6f0fc2dc4a5a8f552d244ac5bd877761261c6799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044766 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
-
Ahmed Fakhry authored
This is a preparation for desks renaming to be able to replace the mini views' labels with textfields. I'm splitting this as its own small CL because it may cause regressions. BUG=1040980 TEST=Manually, and all existing tests should pass. Change-Id: Idf1ba55382bd29fbd6de596341ea118f737f993e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044644 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#740381}
-
Yu Han authored
This reverts commit b4cb14f3. Reason for revert: Getting ready to re-land The original fix for Bug: 538283 introduced a regression, Bug: 1045433. So it was reverted. This is another fix for the original issue and ensures anchor behavior does not regressed. To recap, the original issue is caused by DOMActivate event generated from inline elements. DOMActivate bypasses anchor, bubbles up to <summary>, and gets handled. The underlying event, click, stops propagating and terminates. The original fix for anchor looks at the underlying event and handles it if it's click. However, this logic is wrong because the anchor can preemptively handle a click that belongs to another element earlier in the event path. This example, in file label-inside-anchor.html, illustrate the problem. <a href="javascript:void(0)" target="_blank"> <label for="peas"><span id="text">peas?</span></label> <input type="checkbox" name="peas" id="peas"> </a> Clicking on 'text' generates DOMActivate, which is handled by <a>. Prior to my original fix, DOMActivate isn't handled, and click event bubbles up until it's handle by the <label> attribute. Bug: 1045433 is another example of the same behavior. Video element wrapped by anchor. In this fix, summary element uses the Node property HasActivationBehavior and does not handle DOMActivate if the target node or any of its ancestors up itself has this property set. This allows the click event to continue propagating until it gets handled by an node with ActivationBehavior. Original change's description: > Revert "Fixes click on inline element embedded in anchor inside <summary> breaks anchor." > > This reverts commit 4eb4df63. > > Reason for revert: Caused crbug.com/1045433. > > Original change's description: > > Fixes click on inline element embedded in anchor inside <summary> breaks anchor. > > > > Previous to this CL, clicking on an inline element embedded in an anchor placed > > inside a <summary> tag will expand the <details> section instead of navigating to > > the anchor's href. However, when the anchor is placed outside of <summary>, > > it behaves correctly. > > > > The error is caused by DOMActivate event generated by the inline element. As > > DOMActivate bubbles up, it bypasses the anchor's event handler, reaches the > > <summary>, and is handled there. Once DOMActivate is handled, the original > > click event stops propagating and terminates. This behavior, however, differs > > from when the anchor tag is placed outside of the summary. DOMActivate isn't > > handled, and the original click event keeps bubbling up till it's handled by > > the anchor. > > > > DOMActivate event is deprecated: > > https://developer.mozilla.org/en-US/docs/Web/API/Element/DOMActivate_event. > > However, since blink still has code that depends on it, replacing it is outside > > of the scope for this fix. Instead, this fix is for the anchor element to > > handle the DOMActivate event as it bubbles up. The anchor event handler checks > > the underlying event of DOMActivate and handles it if it's a click. > > > > I also looked at an alternative fix by trying to prevent the DOMActivate event > > from bubbling up. But calling event.stopPropagation() doesn't work as the > > EventDispatcher::DispatchEventPostProcess doesn't check this status. > > > > > > Bug: 538283 > > Change-Id: I11fb072faa0563279d43a28e5dc19cee89906bf0 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928234 > > Reviewed-by: Kent Tamura <tkent@chromium.org> > > Reviewed-by: Mason Freed <masonfreed@chromium.org> > > Commit-Queue: Yu Han <yuzhehan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#718552} >> > Bug: 1045433 > Change-Id: I14b369beb04171ef846cb3a79ebb3fe268cf5c89 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023267 > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Commit-Queue: Yu Han <yuzhehan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735575} Bug: 1045433 Change-Id: I0cdd7b48a2c4e9bf2b653edef9ce7970d7e64938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028455Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#740380}
-
yilkal authored
Sets the application state to kAlwaysAvailable if the application is whitelisted. Bug: 1034551, 1022093 Change-Id: I51f0cc9ff37eda497a4916126192f8a46597edbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047448 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#740379}
-
Ben Pastene authored
Adds links to trunk, beta, & stable consoles to the header. That should make all 3 discoverable from most every console. Bug: None Change-Id: I269c07ba93f7599b5c9eab588dc1a698cfb9a9f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050867Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#740378}
-
Kyle Milka authored
Track the time taken to open the custom share sheet after a share entry point is clicked. Bug: 1009124 Change-Id: I2e3ffc821856bf606864c4af0865f241422d4f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989693Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#740377}
-
Tim van der Lippe authored
cpu-profiler-save-load.js can timeout as well TBR=aerotwist@chromium.org Bug: 1006759 Change-Id: I96efb3d2cf580e6ee4cc6f903fd1b29c00620870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050322Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#740376}
-
Min Qin authored
If a download is triggered by opaque origin, currently we create an origin from main WebContents' URL to determine if the download should be blocked. However, if main WebContents' URL is also an opaque origin, the newly created origin will be different from the previous origin. And making the download always allowed. This CL fixes the issue by using the originating opaque origin instead if the WebContents' origin is opaque. An alternative solution is to assign a dedicated opaque origin to the main WebContents. BUG=1044277 Change-Id: Ia38280f4237ba5cd35c7afcf350734833fb9d002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048843 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#740375}
-
Christopher Cameron authored
Detect HDR capability and use it to populate DisplayColorSpaces. Add DisplayColorSpaces constructor that takes BufferFormat (we'll need it). Update ui::RecyclableCompositorMac to take DisplayColorSpaces instead of ColorSpace (they were dropping the data on the floor). Update HDRCopierLayer to use PresentsWithTransaction correctly. Bug: 1049334 Change-Id: I17a0f75ac08e75d0b38825a38ee0d738ca634059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049663Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#740374}
-
Scott Violet authored
Bug: 1050857 Change-Id: Idd840a66a7c521784a764bbe3923ad838933c87d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050844Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#740373}
-
yilkal authored
This CL reuses supervised_user_block_interstitial.css for web_time_limit_error_page.html Bug: 1015661 Change-Id: I0874139acf852c411e7cdfa2c8b459bda74f5811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047487Reviewed-by:
-
Reid Kleckner authored
Now that libc++ is always used on Windows, we don't need a dedicated bot to monitor this configuration. R=thakis@chromium.org Bug: 801780 Change-Id: I98916f516cc5d06ef9180efec331be86bbae114b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048007 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Brandon Wylie authored
This will prevent TabPersistentStore from restoring a tab we're in the process of reparenting. Bug: 1042565 Change-Id: I1b7e505c0870e7c6b7d77eaf1012abde8cdd5c9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042681 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#740370}
-
Zhiheng Li authored
Implement method to set interaction ID to cast_content_window_android and pass it to CastWindowManager via intent. Bug: b/149024372 Test: cast_shell_junit_tests Change-Id: I84fcf60967cc77c79aa8c765a8a1d58fdaaa0bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048845Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com> Auto-Submit: Zhiheng(Vincent) Li <vincentli@google.com> Cr-Commit-Position: refs/heads/master@{#740369}
-
Takumi Fujimoto authored
Show a Cast icon at the top left corner of Cast notifications in Global Media Controls to make it easier to distinguish Cast notifications from local notifications, which have no icon. Screenshot: https://drive.google.com/file/d/1701V_-4ufHnYMF-e_pdD20AyC8V4HdC0/view?usp=sharing Bug: 1042008 Change-Id: I244564bef86d4209656cd60b377684dc205f8d45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026413Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#740368}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7a341dac0524..da612b8e3549 Created with: gclient setdep -r src-internal@da612b8e3549 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1049671 Tbr: jbudorick@google.com Change-Id: I590012810349aae3944a7285e77d0d96c616650c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050506Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740367}
-
Max Moroz authored
1) Clarify that it's not always necessary to reproduce a bug yourself. 2) Move the paragraph about components with their own triage processes to the beginning of the triage instruction. 3) Slightly change wording in V8 and Skia guidance. Mention Skia fuzzing bugs explicitly. Change-Id: Ide0bc021675d4f9ea648af3c777470b4cce9975e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048106 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#740366}
-
Stephen McGruer authored
This was missed when updating testharness.js as it is not a CQ-blocking bot. Bug: 1051025 Change-Id: Iebbab23d7ab123d1c4a4cbef9bab4bb5b5c0060f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049907Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#740365}
-
Sammie Quon authored
Test: manual Change-Id: I009b7c2f512ef334788db0d711547a130b092509 Fixed: 1050828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049024Reviewed-by:
-
Jacques Newman authored
GetSelectionOffsets calls GetUnignoredSelection selection several times, and being recursive, these calls add up. This change computes the unignored selection once, and then passes it down the stack. This avoids the added complexity of managing a cached value, especially when the usage is localized. In pages with heavily nested content, this change has a large performance improvement. Bug: 1046439 Change-Id: Id61a7a99717a7ccec091ad060072c895e7b42958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020523Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Jacques Newman <janewman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#740363}
-
Xing Liu authored
The following Android download metrics are deprecated: Android.DownloadManager.NotificationInteraction Android.DownloadManager.ViewRetentionTime.Audio Android.DownloadManager.ViewRetentionTime.Video The following Android download metrics are kept: Android.DownloadPage.OpenSource(expired but still wanted) Bug: 1037585,1036915,1034585 Change-Id: I1d6d224ad94eb23c38c7eb629e5a43ee668811f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039344Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#740362}
-
Mythri A authored
Bug: chromium:1050534 Change-Id: I6c434317ffb670adca63f542563e7c7aa979faa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050319Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#740361}
-
Will Harris authored
https://helpx.adobe.com/security/products/flash-player/apsb20-06.html BUG=412078 TBR=jschuh@chromium.org Change-Id: Ic43fef39a23f07f87daf88a3f2fce519962e5c0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049914Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#740360}
-
Joshua Bell authored
encoding/api-invalid-label.any.js had 3287 subtests encoding/textdecoder-fatal-single-byte.any.js had 7169 subtests Pragmatically, the encoding tests need to sharded down to 1000 or they flakily timeout (e.g. on win debug and MSAN bots). Apply that here, and update expectations. Bug: 862938, 517704 Change-Id: I1b1bd13dd997700791ec25de9d0c75c1e5f72960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045144Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#740359}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/235511fbd715..cb8992a734b2 git log 235511fbd715..cb8992a734b2 --date=short --first-parent --format='%ad %ae %s' 2020-02-11 vapier@chromium.org Revert "Remove ChrootPaths class" 2020-02-11 vapier@chromium.org convert a few dev scripts to wrapper3 2020-02-11 cjmcdonald@chromium.org Remove ChrootPaths class 2020-02-11 vapier@chromium.org cros_env_whitelist: relax Python 3 warning temporarily 2020-02-11 chrome-bot@chromium.org Update config settings by config-updater. 2020-02-10 kimjae@chromium.org build_dlc: Imageloader reads string values for sizes 2020-02-10 saklein@chromium.org flash_ap: Refactor deploy arguments. 2020-02-10 saklein@chromium.org flash_ap: Move flash config into ap_firmware config. 2020-02-10 saklein@chromium.org SdkController: Also clean the chroot's /tmp/. 2020-02-10 lamontjones@chromium.org cbuildbot: drop --reuse_pkgs_from_local_boards 2020-02-10 lamontjones@chromium.org service: drop --reuse_pkgs_from_local_boards 2020-02-10 vapier@chromium.org generate_delta_sysroot: drop old wrapper 2020-02-10 vapier@chromium.org gerrit: move subcommand validation into argparse 2020-02-10 chrome-bot@chromium.org Update config settings by config-updater. 2020-02-10 chrome-bot@chromium.org Update config settings by config-updater. 2020-02-10 vapier@chromium.org contrib: switch to python3 wrapper 2020-02-10 mmortensen@google.com Implement Sysroot.GenerateArchive. 2020-02-08 vapier@chromium.org gerrit: add support for ignore/reviewed settings 2020-02-08 vapier@chromium.org gerrit: add dryrun for private/public helper 2020-02-08 vapier@chromium.org run_tests: switch tool & unittest to be Python 3 only 2020-02-08 yueherngl@google.com licensing: add parade-ps8815a0-firmware package (<=R83) 2020-02-08 ahassani@chromium.org auto_updater.py: Run stateful_update with bash instead of dash 2020-02-08 vapier@chromium.org scripts: convert a few standalone programs to wrapper3 2020-02-07 vapier@chromium.org gerrit: rename label utility funcs 2020-02-07 saklein@chromium.org cros flash: Fix typo in docblock. 2020-02-07 vapier@chromium.org wrapper3: new wrapper that is Python 3 only 2020-02-07 pfagerburg@chromium.org lib/git: break out ChangeId into its own function 2020-02-06 bpastene@chromium.org cros_chrome_sdk: Remove the toolchain dir from PATH when building. 2020-02-06 ahassani@chromium.org Revert "cros-update.py: Execute scripts out of /usr/local/tmp/cros-update" 2020-02-06 lamontjones@chromium.org api: compile protos 2020-02-06 edmanp@google.com image_test: Read symbol files as binary instead of utf-8 Created with: gclient setdep -r src/third_party/chromite@cb8992a734b2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Ib6c98a2c87c1a16a2c87e94de8b25071613a5cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050560Reviewed-by:
-
Yulun Wu authored
Change-Id: I86d204cd52904aaf552bcbc2ff6bf3756464701a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048933Reviewed-by:
-
Reilly Grant authored
This change updates the DetectedBarcode, DetectedFace and DetectedText types to be dictionaries rather than interfaces. This is okay because they have only attributes and no methods. This reduces the amount of manually written code necessary to implement them. This enables implementing a new field for issue 1023177 without having to update the manual serialization and deserialization routines. Spec PR: https://github.com/WICG/shape-detection-api/pull/86 Bug: 1023177 Change-Id: I3b93d1869c5457e2ce3da5b5690a5ff968a3c77c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040378 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#740356}
-
Maciek Kumorek authored
Create the scheduled tasks grouped in a company branded folder. E.g. Chrome updater scheduled tasks land under \\Google\GoogleUpdater. The BRANDING file will be the only change required to avoid collisions between scheduled task registered by the implementers of the new updater. When the tasks are deleted, folders should be deleted as well, assuming no other tasks or sub-folders are present. Bug: 1047747 Change-Id: Id6f9833fdc32e4c0845faa1e5025d08c61dbcc29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036415 Commit-Queue: Maciek Kumorek <makumo@microsoft.com> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#740355}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b5bbcc0078b0..f27be3d65c22 git log b5bbcc0078b0..f27be3d65c22 --date=short --first-parent --format='%ad %ae %s' 2020-02-11 szuend@chromium.org [utilities] Replace {keysArray} with {keys} plus spread operator 2020-02-11 jacktfranklin@chromium.org Add `@types/sinon` as a dependency. Created with: gclient setdep -r src/third_party/devtools-frontend/src@f27be3d65c22 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1050549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7286cfea0175b208b15714265419eff7a808d6db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050511Reviewed-by:
-
Dale Curtis authored
This reverts commit aedef3b1. Reason for revert: Logs found the problem. pa_context_connect() is hanging. Original change's description: > Add debug logging to PulseAudio startup when using ASAN/TSAN. > > I've been unable to trigger this issue with multiple rounds of CQ > attempts, so I need some logs checked in to progress further. > > Bug: 1047655 > Change-Id: I4329f76044687ab8dbb521491ead430b15de581d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048039 > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: John Rummell <jrummell@chromium.org> > Auto-Submit: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: John Rummell <jrummell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740124} TBR=dalecurtis@chromium.org,jrummell@chromium.org Change-Id: Ieda3b9b8c8e6ee06beb2eb9ceecb1cce2de915bb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1047655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050871Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#740353}
-
Rouslan Solomakhin authored
Before this patch, Chrome always set Sec-Fetch-Site header to "cross-origin" when downloading manifests to verify Android payment apps. This patch sets the initiator origin for downloading payment method manifest files and sets that file's origin as the initiator of web app manifest file download when verifying Android payment apps. These origins enable setting the correct Sec-Fetch-Site headers in network request, for example. In addition, this patch uses org.chromium.url.URI objects in the JNI interface of PaymentManifestDownloader.java instead of converting to and from a string. After this patch, Chrome correctly sets Sec-Fetch-Site header to either "cross-origin", "same-site", or "same-origin" when downloading manifests to verify Android payment app. Bug: 1048201 Change-Id: If256926daa4a9e43733d79c8fd3049cfbd65a5c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044710 Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#740352}
-
Jun Mukai authored
The mouse-related events in autotestPrivateAPI is using ui::SystemInputInjector, but it actually assumes the location is in the coordinate of the physical bounds of the DrmWindow. Most of the tests do not meet any problems, but it turns out that fake display bounds has some offset, which confuses the mouse location and leads failing further events. Bug: 1050810 Test: tast.ui.LauncherSearchNativeApps on guado without displays Change-Id: Ie7cab3dd9301aebefec8e2f99f55aabae2219bb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049204Reviewed-by:
-
Kristi Park authored
This reverts commit d5544fc0. Reason for revert: Suspect for continuously failing CrSettingsAnimatedPagesV3Test.All and CrSettings* related tests https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/16982 Original change's description: > Settings: Port settings_menu/ to Polymer 3. > > Bug: 1026426 > Change-Id: Id6b62c39b9184532a8e3e3c34c2bdee98a37240e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045171 > Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> > Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740247} TBR=dpapad@chromium.org,rbpotter@chromium.org Change-Id: I029222c3bee9a354964d4d5fa8d02f724c7c4039 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1026426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050868Reviewed-by:
-
Darin Fisher authored
This test verifies a behavior when javascript is allowed to run on a page that is being prerendered. We don't use that mode anymore, so this test can simply be deleted. Bug: 1050143, 1038053 Change-Id: Icbef41a1b604d80725cf6ea9ee736546636dfea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047516Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#740349}
-
Xiaohan Wang authored
See discussion thread at https://groups.google.com/a/chromium.org/g/cxx/c/h4bdRqbduNY/m/O8Blk8SoEQAJ The recommendation style is as follows: class Foo : public IComIsFun { IFACEMETHODIMP IsFun(BOOL* fun) override; }; HRESULT Foo::IsFun(BOOL* fun) { *fun = false; return S_OK; } Change-Id: I912443b78734ec95a8b79a2210153e1bc1bb970f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048413Reviewed-by:
S. Ganesh <ganesh@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#740348}
-
Anders Hartvoll Ruud authored
BUG=947004 Change-Id: I84356c8ebd4a8563a641cf9de84b2326e394ab08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041752 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#740347}
-
Fredrik Söderquist authored
These tests seems to have accumulated multiple bugs through sherrifing. Dupe the bugs with little or no activity into crbug.com/658305, which is the bug with the most action (although perhaps not the most actionable). Bug: 658305, 758133, 862716, 869364, 873454 Change-Id: Ia16b9eb34d26690e051d49b8703bc315c9c0593d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050691 Commit-Queue: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#740346}
-
