GitLab

Also mark them as Pass/Failure right now, as they'll start failing
with the rebaselines included in this patch but will pass again
after the next v8 roll.

BUG=426543
TBR=mstarzinger@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/671293002

git-svn-id: svn://svn.chromium.org/blink/trunk@184299 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This was causing a NaN assertion further on in FrameView::maximumScrollPosition.

BUG=425757

Review URL: https://codereview.chromium.org/663993003

git-svn-id: svn://svn.chromium.org/blink/trunk@184298 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=184294

BUG=397642
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/675003002

git-svn-id: svn://svn.chromium.org/blink/trunk@184297 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The change removed
RenderTableRow::clippedOverflowRectForPaintInvalidation
but the row's visual overflow doesn't include any cells
spanning several rows, which is required to be able to
invalidate rows correctly.

The fix is to include the spanning cells into the
row's visual overflow. Because they both share the
section's coordinate system, we need to translate the
cell's coordinate into the row's to avoid some wrong
visual overflow (aka over-invalidations).

BUG=417060

Review URL: https://codereview.chromium.org/673533002

git-svn-id: svn://svn.chromium.org/blink/trunk@184296 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We should be doing type checking everywhere, but for back-compat reasons
Blink currently doesn't do "interface" or "unrestricted" enforcement.
Turn it on for all the new SW interfaces (since there's no compat
issue) and to fix a cache where Cache.put()'s second argument went
unchecked.

R=haraken@chromium.org
BUG=426153

Review URL: https://codereview.chromium.org/676563002

git-svn-id: svn://svn.chromium.org/blink/trunk@184295 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://codereview.chromium.org/673443002 changed checkbox and radio
buttons by one pixel on Retina OSX. Rebaselining.

TBR=rsesek@chromium.org

Review URL: https://codereview.chromium.org/676773003

git-svn-id: svn://svn.chromium.org/blink/trunk@184294 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true
TBR=jochen@chromium.org
BUG=

Review URL: https://codereview.chromium.org/675783003

git-svn-id: svn://svn.chromium.org/blink/trunk@184293 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=426237

Review URL: https://codereview.chromium.org/668823005

git-svn-id: svn://svn.chromium.org/blink/trunk@184292 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[1] made such APIs return rejected Promises instead of throwing exceptions,
but overloaded functions were not covered. This CL fixes the problem.

1: https://src.chromium.org/viewvc/blink?view=rev&revision=171450

BUG=359586

Review URL: https://codereview.chromium.org/675693002

git-svn-id: svn://svn.chromium.org/blink/trunk@184291 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=junov@chromium.org

Review URL: https://codereview.chromium.org/672943003

git-svn-id: svn://svn.chromium.org/blink/trunk@184289 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If a service worker registration is passed along to a resolver that's
in a detached/stopping state, the WebServiceWorkerRegistration is
simply disposed of.

Have that dispose step only delete the object if the registration object
isn't attached to a proxy already. If it is, it is responsible for
releasing the resource.

R=haraken
BUG=426321

Review URL: https://codereview.chromium.org/669423002

git-svn-id: svn://svn.chromium.org/blink/trunk@184288 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Rename the following functions:

  NodeTraversal::startsFrom(const Node*) (and Traversal<ElementType>::startsFrom(const ElementType*)
  NodeTraversal::startsFromNextOf(const Node&) (and Traversal<ElementType>::startsFromNextOf(const ElementType&)

to:

  NodeTraversal::startsAt(const Node*) (and Traversal<ElementType>::startsAt(const ElementType*)
  NodeTraversal::startsAfter(const Node&) (and Traversal<ElementType>::startsAfter(const ElementType&)

so that they have more meaningful names.

This patch also removes an unnecessary underlying iterator, TraversalInclusiveNextIterator.

BUG=None
TEST=no layout test failure

Review URL: https://codereview.chromium.org/667403002

git-svn-id: svn://svn.chromium.org/blink/trunk@184287 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=426095

Review URL: https://codereview.chromium.org/645403004

git-svn-id: svn://svn.chromium.org/blink/trunk@184286 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL simplifies Heap::allocate for an upcoming optimization (I'm planning to implement size-aware Heap). This CL doesn't improve performance.

- The key change is in Heap::allocate.

- After this CL, ThreadState::getStats and ThreadState::getStatsForTesting return different stats. ThreadState::getStats returns the size of allocated objects *including* object headers, whereas ThreadState::getStatsForTesting returns the size of allocated objects *excluding* object headers. This is because there is no easy way to know the header size of each object in tests, and thus tests cannot test the size of allocated objects unless ThreadState::getStatsForTesting returns the size of allocated objects *excluding* object headers.

- This CL renames Heap::getStats to Heap::getStatsForTesting because it is used by testing only.

BUG=420515

Review URL: https://codereview.chromium.org/634243004

git-svn-id: svn://svn.chromium.org/blink/trunk@184285 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=184271

BUG=401814
TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/672233003

git-svn-id: svn://svn.chromium.org/blink/trunk@184284 bbb929c8-8fbe-4397-9dbb-9b2b20218538

DevTools: Fix __commandLineAPI is not defined error and remove the with- hack for eval on call frame.

BUG=415578, 110163
R=yurys, pfeldman

Review URL: https://codereview.chromium.org/644403003

git-svn-id: svn://svn.chromium.org/blink/trunk@184283 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=vsevik@chromium.org

Review URL: https://codereview.chromium.org/645513004

git-svn-id: svn://svn.chromium.org/blink/trunk@184282 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Changed column-width such that we're actually using more than one
column. Makes it easier to immediately visually verify that multicol is
being used.

Also changed text contents to be less sensitive to computed font size
across platforms.

R=mstensho@opera.com
BUG=386567

Review URL: https://codereview.chromium.org/643923003

git-svn-id: svn://svn.chromium.org/blink/trunk@184281 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As specced at http://mikewest.github.io/credentialmanagement/spec/#interfaces-credential-types-localcredential

BUG=400674

Review URL: https://codereview.chromium.org/645023005

git-svn-id: svn://svn.chromium.org/blink/trunk@184280 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This methods accept callback which will be called when scripts finished execution.

R=vsevik@chromium.org
BUG=410289

Review URL: https://codereview.chromium.org/660863002

git-svn-id: svn://svn.chromium.org/blink/trunk@184279 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With RenderSVGResource reduced to a common base for paint-servers,
it's possible to get rid of the multiple inheritance on
RenderSVGResourceContainer by instead making it the base of
RenderSVGResource{Gradient,Pattern} while inheriting from
RenderSVGResourceContainer.
Rename the files appropriately and update existing references to
RenderSVGResource. Also take the opportunity to tighten the types
a bit in some places.

BUG=420022

Review URL: https://codereview.chromium.org/673753004

git-svn-id: svn://svn.chromium.org/blink/trunk@184278 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This makes the main thread block and wait for the parser thread when all the
script data has arrived. The goal is to ensure that the script (which can now be
compiled) will get the main thread's attention as soon as possible.

This feature is temporary: The usefulness of blocking will be evaluated with
Finch, and this option will be removed (blocking will be always enabled or never
enabled, based on which option turns out to be better).

R=haraken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/651163002

git-svn-id: svn://svn.chromium.org/blink/trunk@184277 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/634383004

git-svn-id: svn://svn.chromium.org/blink/trunk@184276 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=413249
TBR=loislo@chromium.org

Review URL: https://codereview.chromium.org/666843006

git-svn-id: svn://svn.chromium.org/blink/trunk@184275 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As action system handles global shortcuts asynchronously, it
optimistically captures event to prevent the default browser action.

This behavior results in unfunctioning zoom in/out shortcuts in
hosted mode.

The patch adds a workaround which doesn't let the action system
a chance to step in and prevent default behavior for the zooming
shortcuts in hosted mode.

R=pfeldman

Review URL: https://codereview.chromium.org/670303002

git-svn-id: svn://svn.chromium.org/blink/trunk@184274 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If the entire text is selected, then we can safely share the text blob
with the unselected version.

BUG=377845

Review URL: https://codereview.chromium.org/672713002

git-svn-id: svn://svn.chromium.org/blink/trunk@184273 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=lushnikov

Review URL: https://codereview.chromium.org/667163002

git-svn-id: svn://svn.chromium.org/blink/trunk@184272 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Instead of building an ImageBuffer tile (with all the ills of record
time rasterization), build a DisplayList tile and use Skia's
new SkPictureShader mechanism to fill/stroke the shape.

To facilitate this, Pattern is extended to support both bitmap and
picture shaders (the latter only in repeatXY mode -- the only mode
currently used by SVG).

Patterns (and their SkShaders) are cached per RenderSVGResourcePattern
per client. Internally, SkPictureShader also caches its rasterized tile
so there should be no performance degradation.

A handful of tests (about 9) require minor rebaselining (and a couple
have been updated for incorrect patternUnits).

R=pdr@chromium.org,schenney@chromium.org,fs@opera.com,ed@opera.com
BUG=401814,425278

Review URL: https://codereview.chromium.org/453653003

git-svn-id: svn://svn.chromium.org/blink/trunk@184271 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=vsevik@chromium.org
BUG=424479

Review URL: https://codereview.chromium.org/644073003

git-svn-id: svn://svn.chromium.org/blink/trunk@184270 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds layout invalidation tracking to the invalidation
tracking experiment. Our full design doc is at:
https://docs.google.com/document/d/1BXT3_gD--YdbIYMlTzNGsyUUMBCZJ7V5qGJhMA-pGrs/edit

This patch implements the invalidation tracking logic for layout
events. All layout invalidations are recorded and when a layout
occurs they are collected and displayed to the user. Style invalidations
occurring at the same time are not shown.

This patch is a fairly straightforward extension of [1] but for
layout events. The InspectorTest.findTimelineRecord function has been
added for capturing the N-th event of a specific type and all other
inspector tests updated to use it.

[1] https://src.chromium.org/viewvc/blink?view=rev&revision=184212

BUG=410701

Review URL: https://codereview.chromium.org/671913005

git-svn-id: svn://svn.chromium.org/blink/trunk@184269 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=417275

Review URL: https://codereview.chromium.org/671463002

git-svn-id: svn://svn.chromium.org/blink/trunk@184268 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=pfeldman

Review URL: https://codereview.chromium.org/663083003

git-svn-id: svn://svn.chromium.org/blink/trunk@184267 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also drive-by fixing the CSP ruleset.

TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/671183003

git-svn-id: svn://svn.chromium.org/blink/trunk@184266 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We settled on this compromise in https://src.chromium.org/viewvc/blink?revision=178148&view=revision
and it regressed sometime between then and now. I've added a layout test
(which I should have done in the first place) to ensure that doesn't
happen again.

This CL also changes the test driver to accept '.https.html' as an
HTTPS-by-default toggle. This is a nice addition to the existing functionality
that doesn't force us to put HTTPS-by-default tests into a separate directory.

BUG=422213,318788

Review URL: https://codereview.chromium.org/657353002

git-svn-id: svn://svn.chromium.org/blink/trunk@184265 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Autocompletion controller intialization makes almost half of the time
of SourceFrame initialization.

In order to render editor as fast as possible, this patch defers
autocompletion initialization until the first need.

BUG=425550
R=vsevik

Review URL: https://codereview.chromium.org/670163002

git-svn-id: svn://svn.chromium.org/blink/trunk@184263 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none

Review URL: https://codereview.chromium.org/644663004

git-svn-id: svn://svn.chromium.org/blink/trunk@184262 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/674553002

git-svn-id: svn://svn.chromium.org/blink/trunk@184261 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this CL, "angle -> auto" animation was implemented but "auto -> angle"
animation was not implemented. This CL implements the missing piece as
a discrete animation as specified in the spec.

BUG=425848

Review URL: https://codereview.chromium.org/672853002

git-svn-id: svn://svn.chromium.org/blink/trunk@184260 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes the various leftovers of the original marquee implementation:
- RenderObject::isMarquee
- StyleMarqueeData
- -internal-marquee-*
- EMarquee*

TBR=pfeldman

Review URL: https://codereview.chromium.org/669553002

git-svn-id: svn://svn.chromium.org/blink/trunk@184259 bbb929c8-8fbe-4397-9dbb-9b2b20218538

To facilitate repurposing of RenderSVGResource for paint-server use,
move RenderSVGResource::markForLayoutAndParentResourceInvalidation
to RenderSVGResourceContainer.

For reduced dependencies call through a method with the same name on
SVGElement.

BUG=420022

Review URL: https://codereview.chromium.org/669153002

git-svn-id: svn://svn.chromium.org/blink/trunk@184258 bbb929c8-8fbe-4397-9dbb-9b2b20218538