GitLab

Besides the initial window position and size, the user controls this
behavior. This change makes OverlayWindowViews a views::Widget, which
gives it more control over windowing behavior. Update sizing behavior
and determining window bounds, per UX guidelines.

This change also makes minor cosmetic changes (e.g. window type) to
temporarily make work in progress changes easier.

BUG: 726621
Change-Id: I4cfbacb276a14ea86e00d11dcbfa17781a02533a
Reviewed-on: https://chromium-review.googlesource.com/938580
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541813}

Change-Id: Ic8f7025c8800c7eed57b8df568f33d2ab8f79f2d
Bug: 812533
Reviewed-on: https://chromium-review.googlesource.com/949866Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541812}

https://chromium.googlesource.com/angle/angle.git/+log/ed8b49195844..5164b797cb91

$ git log ed8b49195..5164b797c --date=short --no-merges --format='%ad %ae %s'
2018-03-06 lucferron Vulkan: Support GL_LUMINANCE and GL_LUMINANCE_ALPHA

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: I1f27a8276759009462ddb8d1355c5a05b68ba4fc
Reviewed-on: https://chromium-review.googlesource.com/955665
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#541811}

Adds information about total and free disk space to log events
for which it is relevant.

Bug: b/73277923
Test: unit_tests
Change-Id: I8448ae63ee15b4b4cacbb885bff111912c81ffa3
Reviewed-on: https://chromium-review.googlesource.com/951766Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Bartosz Fabianowski <bartfab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541810}

To make the drop down arrow in the contextual
promos accessible through VoiceOver the code of
DiceSigninButton is refactored.

Instead of making the arrow a child of the signin
button it is made a sibling in the new
DiceSigninButtonView.

Screenshots:
https://drive.google.com/drive/folders/1eHPeM8MtSlT5wFGlNwYCslWSZouE2APG?usp=sharing

Video before highlighting was customized:
https://drive.google.com/file/d/16UqnnqKxRtPCianDSvlqptHVt5ncaSe1/view?usp=sharing

Video after highlighting was customized:
https://drive.google.com/file/d/1BkfBdodNhYLAtcLHSLZQcDkeZuJoWRMw/view?usp=sharing

Bug: 814986, 814807, 818563
Change-Id: I7dd2e77398d84f330114dfb115aea7543ce6afe6
Reviewed-on: https://chromium-review.googlesource.com/949243
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541809}

R=dtrainor@chromium.org,twellington@chromium.org,mdjones@chromium.org,tedchoc@chromium.org,yusufo@chromium.org,bshe@chromium.org,mthiesse@chromium.org,ymalik@chromium.org

Change-Id: I7fcee7cbf2b6e622c3b89cb83d78f5a7320d0de7
Reviewed-on: https://chromium-review.googlesource.com/940130Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541808}

If the user enters a URL with a slash e.g. 'url/', the formatter,
having no context, will reduce it to 'url' and assume that the cursor
is before the slash '/'. This CL clears the bit requesting such ellision,
preserving the slash.

Bug: 809858
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I241fb58a6ff4223818884adf61f07e801e86e851
Reviewed-on: https://chromium-review.googlesource.com/934640Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541807}

On CL https://chromium-review.googlesource.com/c/chromium/src/+/901664 added
a call of function __gCrWeb.autofill.webFormElementToFormData from
password_controller.js. On codereview it was suggested
https://chromium-review.googlesource.com/c/chromium/src/+/901664/27/ios/chrome/browser/passwords/resources/password_controller.js#296
to move this function to fill.js. It makes sense, since fill.js is supposed
to contain common parts between Autofill and Password Manager. This CL moves
webFormElementToFormData and all dependencies to fill.js. The order from
autofill_controller.js is preserved.

Bug: 807623
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic538ac44471d19c4e899d4d3450b92bed7da5c0e
Reviewed-on: https://chromium-review.googlesource.com/951609Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541806}

The call is implemented in the base class's implementation,
ModelTypeSyncBridge::DisableSync(). Without such a call, the
processor never takes care of deleting the metadata.

Because UserEventSyncBridge is a commit-only type (in fact the
only one), it forces initial_sync_done when loading metadata. This
is now moved to the processor, because it's common for all
commit-only types and it also needs to be taken care of if
DisableSync() is followed by enable-sync.

In order to test this, some refactoring of tests was needed (and I
chose to introduce MockModelTypeChangeProcessor), because:
a) The former tests had bugs (didn't actually verify some values,
   because callbacks not being run was treated as success)

b) The DisableSync() flow (currently) destroys and recreates the
   change processor, which requires some forwarding proxy to allow
   tests to verify the state across destructions of the processor.

Bug: 819233
Change-Id: I0f1524850ef65b795b7f7082ce4e85171b8e2898
Reviewed-on: https://chromium-review.googlesource.com/951604
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541805}

It is breaking on only the chrome://version URL, but it's simpler to
disable the whole test rather than just one parameter.

Change-Id: I1341d503640058f18a914e6356de83ef8bb6fc1a
Bug: 820070
TBR: bmcquade@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/955625Reviewed-by: Matthew Cary <mattcary@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541804}

If the custom action icon is particularly small or the toolbar
particularly tall, it would otherwise appear top-aligned.

Bug: 819600
Change-Id: I7dede3da471d4b51b8ce0c290a53397092cd514b
Reviewed-on: https://chromium-review.googlesource.com/955642Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541803}

This reverts commit 70546dc6.

Reason for revert: Causing flaky crashes on waterfall, see https://crbug.com/820075.

Original change's description:
> Fix some tab lifetime management issues in TabLifecycleUnitSource.
> 
> Move the WebContentsObserver from TabLifeCycleUnit to TabLifeCycleUnitSource,
> this allows for a better tracking of the WebContents lifetime, in some
> situation a WebContents might get detached from the TabStrip and then
> destroyed, which mean that we won't get a TabClosingAt notification for
> this tab destruction.
> 
> Another solution would be to implement the TabStripModelObserver::TabDetachedAt
> function and track the tabs which are in a detached state but this is slightly
> more complex because TabDetachedAt might be called for several reasons:
> - A TabDetachedAt usually come after a TabClosedAt event.
> - TabDetachedAt might be followed by TabInsertedAt, or not if it get destroyed.
>   because of this we won't know if we should keep the TabLifeCycleUnit for this
>   WebContents around (i.e. if it'll get re-inserted in a tab strip) or destroy
>   it because it's being destroyed.
> 
> Observing WebContentsObserver::WebContentsDestroyed and moving the logic that
> was in TabClosingAt to this method address these issues, it's the same approach
> than the one we took in TabStatsTracker.
> 
> Bug: 819352, 818454
> Change-Id: Ibd3fe49b2798ade19ee781cb70eb30e52372d686
> Reviewed-on: https://chromium-review.googlesource.com/952405
> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
> Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541540}

TBR=chrisha@chromium.org,sebmarchand@chromium.org

Change-Id: I0aa17b4db9f4c1468e190ef4ec0dc86aeb08c3a8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 819352, 818454
Reviewed-on: https://chromium-review.googlesource.com/955882Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541802}

Bug is identical to the last :/. No idea why it's much more frequent with mojo,
possibly a race is likely to happen when destroying a frame: |callback_| is
destroyed due to frame being destroyed, and authorization is failed for the
same reason. With the per process message filter, authorization wouldn't fail
due to the frame being destructed.

Bug: 819277
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic17dc96d2c83a08732b43094bac2f2c3fa7035ad
Reviewed-on: https://chromium-review.googlesource.com/951774
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541801}

This adds support for encoding the launch id for the context menu item,
in a similar way as for the button index (context menu click is treated
by the Action Center as a button click).

This also removes the check for native notifications being enabled
while processing the command line at startup. Main reason for that
is that the notification activator does not enable native notifications
when it passes the command line to Chrome, but native notifications
are already implied anyway (otherwise the notification activator wouldn't
be used). So, we can remove the check.

Bug: 734095
Change-Id: I629dabaab290fba9043114bf2403daba2b8b7f0c
Reviewed-on: https://chromium-review.googlesource.com/952446
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541800}

This test appears to be causing NewTabPageTest#testRender to flake.
Spectulatively disabling.

BUG=813589

Change-Id: I0bdd566c14d1e6d3521e00e097e55a9f079e76a1
Reviewed-on: https://chromium-review.googlesource.com/954333Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541799}

This CL changes the autofill_agent in iOS so that it expects a vector of

This makes it easier to fiddle the displayed type prediction (e.g., from
overal to server) and makes the interface more similar to that of Desktop.

autofill: :FormDataPredictions instead of a vector FormStructure pointers.
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I79d45ae585d98621b03d2753829405ee47bae8d3
Reviewed-on: https://chromium-review.googlesource.com/953206Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541798}

This OWNERS file was added temporarily to fix a broken OWNERS
chain. Remove now that we no longer need it.

Part two of a two part fix for c/b/ui/views/overlay/OWNERS.

BUG: 819870
Change-Id: I5f3c280c2a97e504b96f7dbad7331ae930324fed
Reviewed-on: https://chromium-review.googlesource.com/954341Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541797}

Bug: 813821
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I82a9c0cc52f783964841ecf3ae656769620b852e
Reviewed-on: https://chromium-review.googlesource.com/954544Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541796}

This CL adds an Earl Grey test to check the interactions between the
infobars and the bottom adaptive toolbar.

Bug: 804747
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ife30026fd1390d4b86896aca2f7f0f33407926cc
Reviewed-on: https://chromium-review.googlesource.com/955023
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541795}

We use count
- CSS.paintWorklet
- PaintWorkletGlobalScope.devicePixelRatio
- PaintWorkletGlobalScope.registerPaint

BUG=578252

Change-Id: I188c980816c3c1f205de0209dd2226e39a7e7475
Reviewed-on: https://chromium-review.googlesource.com/892941
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541794}

This CL shows the sync confirmation dialog before sync actually starts
if the user is enabling sync for a non enterpriser account. This is
acceptable as the sync cannot be disable by administrator for such
accounts.

Bug: 814113
Change-Id: I49dff5c3a4ed10689c022162edd6b84162b3382c
Reviewed-on: https://chromium-review.googlesource.com/951587Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541793}

Bug: chromium:817110
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If267c55bba4880319dbd171b21663928ebc24d20
Reviewed-on: https://chromium-review.googlesource.com/952708
Commit-Queue: Yuqian Li <liyuqian@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541792}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/16d3f07a..dc2d3bb9

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I8045167d204fe57d60e46ae79102061392dbad09
Reviewed-on: https://chromium-review.googlesource.com/955402Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541791}

This OWNERS was missed when moving c/b/ui/overlay to c/b/overlay.
With the previous change (see crbug), c/b/ui/views/overlay/OWNERS
now points to an OWNERS file that no longer exists. Rather than
reverting the previous patch, this will be less disruptive while
fixing the OWNERS chain.

Part one of a two part fix for c/b/ui/views/overlay/OWNERS.

BUG: 819870
Change-Id: I0fb9baf6a65a9e0afbfb2e2e26cfca745b5d984a
Reviewed-on: https://chromium-review.googlesource.com/954325Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541790}

Moves some tests away from the untriaged ones now that they have a bug
assigned to them.

TBR=jam@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I5351246477fe0ed35c5c87b1e937bc27006d354d
Reviewed-on: https://chromium-review.googlesource.com/955583
Commit-Queue: Camille Lamy <clamy@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541789}

Subpixel positioning is not (yet) enabled for all situations in Chrome.
Currently, the choice of enabling this for the UI is made on a platform
specific basis in ui/gfx/font_render_params_*.cc.

Separately, the choice for enabling this for blink is made
in third_party/WebKit/Source/platform/fonts/WebFontRenderStyle.cpp,
third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp,
and third_party/WebKit/Source/platform/fonts/*/FontPlatformData*.

Typically the choice comes down to user and system preferences and
the device scale factor. For example, some hinting algorithms hint
glyphs in the horizontal direction, fitting precisely to the grid.
Subpixel positioning should be disabled in this case. Newer hinting
algorithms hint only vertically, so glyphs should be subpixel positioned.
(See https://www.freetype.org/freetype2/docs/glyphs/glyphs-5.html#section-2)

When subpixel positioning is disabled, we need to round an entire run of
text at a time. Otherwise, spacing between some letters
becomes position dependent.

Offset and extent rounding is currently done with the use of
hb_font_set_funcs, but positions affected by kerning cannot be rounded
unless the font uses a legacy 'kern' table instead of 'gpos'.

Bug: 740385
Change-Id: Ie34134c33b52889b8d7bfcec05fc7d24e0180596
Reviewed-on: https://chromium-review.googlesource.com/933805
Commit-Queue: Adam Goode <agoode@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541788}

To disable on multiple platforms, each disable must be listed
separately as a new entry.

Also update docs to make this a bit more explicit.

TBR=sullivan@chromium.org,nednguyen@google.com
NOTRY=true

Bug: 819552
Change-Id: I0f033a9ea11d8df6a27fcbbfaa5cc98d408ac2f1
Reviewed-on: https://chromium-review.googlesource.com/955682Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541787}

Added the skeleton trigger class, defined the associated ReportType
and ThreatType enums, and plugged the class into TriggerCreator.

This CL is a no-op. The trigger requires quota in order to be instantiated
and the default quota is 0, so it does not get created at the moment.

Bug: 817377
Change-Id: Ied66b2ecf9dc4eaf59b1d3e87d761996eb8a9d85
Reviewed-on: https://chromium-review.googlesource.com/941362Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541786}

Just testing the factory is a bit tricky, so I test it as part of the
audio::OutputStream tests.

Doc: go/audio-service-streams-design

Bug: 803102

Change-Id: I463e7adbda7de1a8a5724fa23fc98015cb425a3c
Reviewed-on: https://chromium-review.googlesource.com/939179
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541785}

The deprecated method GetToolbarVoiceSearchButtonImageId() was
confusing and forced client code to check return value. Instead
use GetToolbarVoiceSearchButtonImages() that always return the
correct value to use.

Bug: none
Change-Id: I80b6a8b493950c054374f5faee8c907c2055d44c
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/952449
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541784}

With NavigationMojoResponse, we are seeing a regression in
Navigation.ReadyToCommitUntilCommit. The method ContinueForNavigation()
is called in a PostTask(). In a busy renderer, it causes the loading of
the main resource to be delayed.

This CL replaces the PostTask by a callback that is called at the end of
RenderFrameImpl::CommitNavigation(). According to local benchmarks, it
should improve the histogram mentionned above (see below).

Links to collaboratory studies:
 * Without patch: https://goo.gl/isFY17
 * With path: https://goo.gl/xWAjqB

Bug: 705744, 820031
Change-Id: I4cac025f74865bf164d618d2afbd92bceeaede1e
Reviewed-on: https://chromium-review.googlesource.com/951243
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541783}

Bug: 786559
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ife4a40e651a08827a0dfe5c500b80a685ff29359
Reviewed-on: https://chromium-review.googlesource.com/946408Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541782}

This reverts commit d52a1146.

Reason for revert: The Vulkan roll has landed in Chrome.

Original change's description:
> Temporarily disable angle_vulkan_deqp_tests.
> 
> Unblocks the Vulkan roll (issues with http://crbug.com/643346).
> 
> Bug: angleproject:2393
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Tbr: kbr@chromium.org
> No-Try: True
> Change-Id: Icd41d0ba9abbbdd5a8d52e9f391716dbef674a34
> Reviewed-on: https://chromium-review.googlesource.com/951648
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541458}

TBR=jmadill@chromium.org,kbr@chromium.org

Change-Id: Iadbb548ed09d8a19cf2f13302c3c790dcec911eb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:2393
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/955542Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541781}

R=rch@chromium.org

Change-Id: Ia026d7497a2a901d231973a03effad0868f547d1
Reviewed-on: https://chromium-review.googlesource.com/953742Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Fan Yang <fayang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541780}

Deletes |WrapPersistent| for wrapper-tracing version of callback
interfaces after https://crrev.com/c/951163 .

Bug: 778580
Change-Id: I16e8c19d1c01f74bc841aa3bcc1f6dacdc2563f8
Reviewed-on: https://chromium-review.googlesource.com/954864Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541779}

Otherwise, we might crash flakily on windows, as we might tear down
the Shell (WebContentsDelegate) before the callback to select a
filename has returned.

BUG=819739
R=battre@chromium.org

Change-Id: I09348f556ee10a9efae738b0ee2721c23641590a
Reviewed-on: https://chromium-review.googlesource.com/954944
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541778}

This is split out from the CL to test all widgets and views for nameless
focusable objects. See crrev.com/c/951933.

Bug: 819350
Change-Id: Iae8c931231d6516cb64abe6386b4c3e343b9870c
Reviewed-on: https://chromium-review.googlesource.com/952329Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541777}

Standard C++ doesn't allow implicit conversion between function pointers
and void*. MSVC does allow that, so clang-cl also allows it but emits a
-Wmicrosoft-cast warning. We want to enable this warning to make the
compiler behave more similar on different platforms, so add an explicit
cast to void*. (GetProcAddress() returns FARPROC, a function pointer type.)

Merges one line from upstream 5d0574bf6473130d25dd296ad30206ccd148590b

Bug: 550065
Change-Id: I54080e807e2106ff084adc6e0f7954a72bdf467f
Reviewed-on: https://chromium-review.googlesource.com/953722Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541776}

This relands commit d690c638.

This time the new test is marked as timeout in MSAN expectation.

Original change's description:
> [heap-profiler] Merge DOM node and its JS wrapper node in heap snapshot.
>
> Each DOM node has a corresponding JS wrapper node. In heap snapshot
> they appear as duplicates.
>
> Example retaining path with duplicates:
> - [1] in InternalNode @2041178784
> - [1] in HTMLDivElement @2041079168  // DOM node
> - [3] in HTMLDivElement @2231// JS wrapper
> - retainer in Window / @2105
>
> The heap snapshot generator now can merge an embedder node with a node
> returned by EmbedderGraph::Node::WrapperNode() function.
>
> This patch implements the WrapperNode() function for each DOM node.
>
> Bug: chromium:811925
> Change-Id: I9ea6bc7e45f8ab3d54828b9ac61f7230d04d8019
> Reviewed-on: https://chromium-review.googlesource.com/928503
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#539132}

Change-Id: I0523477d562c68512a2a92902022826df8a32820
Reviewed-on: https://chromium-review.googlesource.com/955243Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541775}

Remove already existing duplicate tests, and upstream a unified version
of currently existing an + b selector parsing tests.

Bug: 818475
Change-Id: Id889175e0d4df27037ee335d23020c213c148b44
Reviewed-on: https://chromium-review.googlesource.com/952078Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541774}