- 24 Apr, 2018 40 commits
-
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=juliatuttle@chromium.org Bug: 825327 Change-Id: Iddd6fb67987e98cbc4fa6a4b09167124e1f31388 Reviewed-on: https://chromium-review.googlesource.com/1024470Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553356}
-
Kent Tamura authored
New name is merge_web_test_results.py. Note that we decided to rename LayoutTests to web_tests. https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/KKNbuzj-3HY/H8FWgtKrBgAJ Bug: 829697 Change-Id: I24bf833ba794316734d04495e7c1f30f9dad5090 Reviewed-on: https://chromium-review.googlesource.com/1025618Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#553355}
-
Dominic Mazzoni authored
This is a follow-up to http://crrev.com/c/1011229, which introduced AXTableInfo. In this change, Mac and Windows accessibility code uses AXTableInfo to get cell IDs, column headers, and row headers, rather than relying on those attributes from Blink. This speeds up Blink serialization and will make it easier for our table handling code to be even more fast and robust. TBR=estark@chromium.org Bug: 832289, 651614, 789748, 753125 Change-Id: I4d859e0a5973f172b1b3e587ad871607d127f6cd Reviewed-on: https://chromium-review.googlesource.com/1012447 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#553354}
-
Malay Keshav authored
Subpixel positioning was needed because text layout was performed at 1x device scale factor and then rastered to the final display device scale factor leading to glyph artifacts and inconsistent glyph positioning. With pixel canvas enabled on chrome os, the text layout is now always performed at the final display device scale factor. This, coupled with the replacement of ui scale with display zoom, the text on Chrome OS is now always rastered with the correct glyph positioning and it no longer requires subpixel positioning. Bug:835187,824154,716662 Change-Id: Idc0d6c7851308cc26b1d90f74a619e90dadf0112 Component: Text render, subpixel positioning, font TBR=derat@chromium.org Change-Id: Idc0d6c7851308cc26b1d90f74a619e90dadf0112 Reviewed-on: https://chromium-review.googlesource.com/1026636Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#553353}
-
James Wallace-Lee authored
Add the page https://en.wikipedia.org/wiki/File:Rotating_earth_(large).gif to the stories run in power.typical_10_mobile. This tests power usage when an animated GIF is running slower than chrome's 60fps animation speed. Bug: 737101 Change-Id: Ica34e8fb78446a2c61069268a502ac5e031649bc Reviewed-on: https://chromium-review.googlesource.com/1018200Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Cr-Commit-Position: refs/heads/master@{#553352}
-
Kent Tamura authored
* Add "third_party/blink/renderer/" to some values in CoreProbes.json5 and PlatformProbes.json5. * make_instrumenting_probes.py passes a directory name relative to out/$config/gen/, and a template uses it to generate #includes. Bug: 836071 Change-Id: I31ac5efaba5b96914e342d5c4f54a236b5c3fab1 Reviewed-on: https://chromium-review.googlesource.com/1025233Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#553351}
-
Ben Pastene authored
Mostly for humans. The bots should all have kvm installed and available. Also use logging instead of print. Bug: 828607 Change-Id: Ifee1ead435932d6d2752c0a418cd38618a66228e Reviewed-on: https://chromium-review.googlesource.com/1026569Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#553350}
-
Qiyu Hu authored
This was updated quite a while ago in bluez. https://chromium.git.corp.google.com/chromiumos/third_party/bluez/+/48fe55b7610257bdb9ea075f1382440ae013be42%5E%21/#F0 Roll src/third_party/cros_system_api/ dea305b1a..62d5021bb (1 commit) https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/dea305b1a70d..62d5021bb6d4 $ git log dea305b1a..62d5021bb --date=short --no-merges --format='%ad %ae %s' 2018-04-23 qiyuh Update gatt error message in dbus for bluez. Created with: roll-dep src/third_party/cros_system_api BUG=b:69965109 TEST=Pass CtsVerifier test on reading w/o permissions Change-Id: Id0eb9122c02ca255ebbb50caf718d9020fd8d1ab Reviewed-on: https://chromium-review.googlesource.com/1026075Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Commit-Queue: Qiyu Hu <qiyuh@google.com> Cr-Commit-Position: refs/heads/master@{#553349}
-
Kyle Horimoto authored
This CL adds two additional API functions: (1) SetSoftwareFeatureState(): Enables or disables the given software feature for the device with the given public key. (2) FindEligibleDevices(): Finds devices which are eligible for the given feature. This CL adds a SoftwareFeatureManager object to DeviceSyncImpl, which it uses to execute these function calls. Bug: 824568, 752273 Change-Id: I717d7732754dc9fb9bd91aec3eaad81513725fcb Reviewed-on: https://chromium-review.googlesource.com/1018007Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#553348}
-
Theresa authored
BUG=832685 Change-Id: Ie8088a65f8d264de00b8930aea4e16d06317eb98 Reviewed-on: https://chromium-review.googlesource.com/1026649Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#553347}
-
Jonathan Metzman authored
Bug: 769578 Change-Id: Ic4f0adc56337330496020942940c28fc9b0ba89d Reviewed-on: https://chromium-review.googlesource.com/1026708Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#553346}
-
David Jacobo authored
If the user chooses to continue their navigation via 'Use app' on the intent picker, thus escaping Chrome, make sure to either close the current tab or navigate to the previous entry (if any). Opening a desktop PWA reparents the tab which implicitly closes it in the current browser and sends it to an app window, this is why we don't use the new CloseOrGoBack method for the PWA case. Bug: 678141 Test: Build. Change-Id: Ie1bf38db0fce959a13ac94e751a6fa20495b0040 Reviewed-on: https://chromium-review.googlesource.com/756313Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#553345}
-
Fabrice de Gans-Riberi authored
Bug: 835405 Change-Id: I0dc49d7d8dd4c5cb05e93007c020bca4cf7830b0 Reviewed-on: https://chromium-review.googlesource.com/1013061Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#553344}
-
Kent Tamura authored
- PageLoad/ didn't exist. - jquery-1.3.2.js: This file had CRLF line endings until [1], and "-crlf" preserved CRLFs. However now it has LF line endings and we recommend to set "core.autocrlf false" [2], so the "-crlf" setting has no effect. [1] crrev.com/056fd80b [2] http://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/depot_tools_tutorial.html Bug: 829695 Change-Id: I0618beaef25e13304ced653a0adc5c8e35f4c42b Reviewed-on: https://chromium-review.googlesource.com/1025411Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#553343}
-
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:fuchsia_arm64_cast_audio;master.tryserver.chromium.linux:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I9fac1474309082fb09f3f1c610a991c5784540c4 Reviewed-on: https://chromium-review.googlesource.com/1026709Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553342}
-
https://chromium.googlesource.com/angle/angle.git/+log/33e05babbc69..f2807385cbc9 $ git log 33e05babb..f2807385c --date=short --no-merges --format='%ad %ae %s' 2018-04-24 geofflang D3D: Use an alignment of 1 when uploading zero data to initialize textures. 2018-04-24 jmadill Vulkan: Add GetColorComponentFlags. Created with: roll-dep src/third_party/angle BUG=chromium:836131 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I7201098909db555b302a67bd4108eda1b6f30eb8 Reviewed-on: https://chromium-review.googlesource.com/1026559Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553341}
-
Helen Li authored
This CL uses mock proxy sockets so that we can correctly test the proxy fallback behavior. For more info, see linked bug. Bug: 826570 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ie13e36d4b16b32d1e739fb0a7e513d4c6570c3a3 Reviewed-on: https://chromium-review.googlesource.com/1026421Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#553340}
-
Tsuyoshi Horo authored
Bug: 830505 Change-Id: I4c7a6333fc6ac16a53a619700f59838e81f74411 Reviewed-on: https://chromium-review.googlesource.com/1025930Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#553339}
-
wutao authored
This cl adds context menu to internal app at different places: 1. Add context menu to recommended searched results. 2. Add context menu to items in app list. 3. Add context menu to shelf items. Bug: 824437 Test: new tests in AppContextMenuTest and LauncherContextMenuTest Change-Id: I46a16b2a2b78d0027a3ce9a4f0afc94581e0c2b9 Reviewed-on: https://chromium-review.googlesource.com/1023042 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#553338}
-
Kevin Schoedel authored
Cast humbly requests the ability to tweak its own gesture configuration. Bug: b/77490018 Test: no functional change Change-Id: I3db07364313ffaa072109c578b0d88b38498330a Reviewed-on: https://chromium-review.googlesource.com/1026552Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#553337}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/35c78637d354..2337b0d45c46 $ git log 35c78637d..2337b0d45 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal BUG=chromium:722573 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I32421e895b3249b1d0f5eebc45e236f27d2c9b0e Reviewed-on: https://chromium-review.googlesource.com/1026641Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553336}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=jochen@chromium.org Bug: 825327 Change-Id: I95578c8c278000044d7a16c797f8317f562cc51a Reviewed-on: https://chromium-review.googlesource.com/1024632Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553335}
-
arthursonzogni authored
Remove resource_request::resource_body_stream_url. Other CLs: 1) https://chromium-review.googlesource.com/c/chromium/src/+/1015005 2) https://chromium-review.googlesource.com/c/chromium/src/+/1021631 3) https://chromium-review.googlesource.com/c/chromium/src/+/1022790 * 4) https://chromium-review.googlesource.com/c/chromium/src/+/1024038 Bug: 705744 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I6dc6a9b3c1d8577dc1b3662773078bed7ec8e360 Reviewed-on: https://chromium-review.googlesource.com/1024038 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#553334}
-
Boris Sazonov authored
This CL changes OWNERS for Android FRE Java files: 1. Adds bsazonov@ to OWNERS. 2. Links OWNERS in javatests and junit folders to OWNERS in java folder. Bug: None Change-Id: I1358fe3c015763de46f4f3a09d00d6b3aab83897 Reviewed-on: https://chromium-review.googlesource.com/1019441Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#553333}
-
Lei Zhang authored
This reverts commit 4ff78330. Reason for revert: Broke the build. Original change's description: > Disable flaky SitePerProcessHighDPIHitTestBrowserTest on TSAN. > > BUG=833380 > TBR=mcnee@chromium.org > NOTRY=true > > Change-Id: Ia38901113736af2fa923c301769282e834d531c3 > Reviewed-on: https://chromium-review.googlesource.com/1026830 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553322} TBR=thestig@chromium.org,mcnee@chromium.org Change-Id: Ic390442ee654a5ad8a8c4076843d64f461fdb6f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 833380 Reviewed-on: https://chromium-review.googlesource.com/1026435Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#553332}
-
Xiaohui Chen authored
* LibAssistant will make a couple file IO during creation. Moved the creation to background thread to avoid DCHECK. * LibAssistant start will sync wait, this is not allowed in Chromium code and triggers a DCHECK error. Now we created a new start API which takes a callback. This API will be non-blocking and invokes callback when it's done. Bug: 826536, 826462 Test: locally build and run, no DCHECK Change-Id: If6384977838d3056a75df8becbba5257dba71555 Reviewed-on: https://chromium-review.googlesource.com/991458 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#553331}
-
Kenneth Russell authored
Suppress the following tests again: ContextLost_WebGLBlockedAfterJSNavigation ContextLost_WebGLUnblockedAfterUserInitiatedReload They're still failing reliably on these two bots. Also restart the browser after running these two tests; this was forgotten, and appears necessary for any of these tests which tear down the GPU process. Tbr: ynovikov@chromium.org Tbr: sugoi@chromium.org No-Try: true Bug: 832886 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5918e7b731023b8efb8e1202f8c9b57e1089e1bd Reviewed-on: https://chromium-review.googlesource.com/1025112 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#553330}
-
Eric Roman authored
Bug: 512595 Change-Id: Ifdab5416ba41171f07f097910060cc99a08585a4 Reviewed-on: https://chromium-review.googlesource.com/1026642Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#553329}
-
Gabriel Charette authored
Migrate MessageLoop::current() to MessageLoopCurrent in /third_party/blink/renderer/platform/scheduler These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=rmcilroy@chromium.org Bug: 825327 Change-Id: Ic6d3ecfe4aed463c921eee5c1d13f5be2210e38a Reviewed-on: https://chromium-review.googlesource.com/1024435Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553328}
-
James Cook authored
Bug: none Change-Id: If0e57d955483f2ba7e55cc1bae744cfbc4567868 Reviewed-on: https://chromium-review.googlesource.com/1026551Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#553327}
-
Antonio Gomes authored
This CL makes Ozone/Wayland able to exchange clipboard data with other applications on the system. It accomplishes the functionality by making use of wl interfaces like wl_data_source, wl_data_offer, wl_data_device and wl_data_device_manager. In order to bridge the communication between Ozone backends (eg wayland) and the rest of Chromium, CL also introduces a 'delegate' class class named ClipboardDelegate. In practice, clients of ClipboardDelegate (eg Mus' ClipboardImpl) delegate clipboard operations to the active Ozone backend. FakeServer is also extended to support the various compositor side functionalities needed so that tests in wayland_data_device_unittest.cc run. For instance, MockDataDeviceManager, MockDataDevice, MockDataOffer, MockDataSource classes are added, implementing the respective Wayland compositor hooks to communicate with Wayland clients (eg Ozone/Wayland). Last, the CL focuses on the Ozone/Wayland side of the implementation, leaving plumbing with the rest of Chromium for follow up CLs (eg [1]). However in order to test the functionality, wayland_data_device_unittest.cc is introduced and mimics how a client (eg Mus) would use of the functionality. [1] https://crrev.com/c/981372/ API footprint: As mentioned, CL adds a new Ozone public API class: ClipboardDelegate. The API is designed to support "promise scheme" clipboard implementations, like to Wayland's and MacOS' NSPasteboard. Flow: 1) Offer clipboard data (writing) When offering content to the system wide Clipboard (eg Chromium/Wayland user performs a copy or cut operation), WaylandConnection creates a WaylandDataSource instance, which installs listeners, including ::OnSend for actually exchange the data. WaylandDataSource then calls wl_data_source_offer to communicate the compositor the mimetypes available for clipboard operations, and then wl_data_device_set_selection to flag itself as the current active "clipboard owner". By the time data is requested from this client (eg another application on the system "paste" to an editor), the WaylandDataSource::OnSend callback is called with a mime type and a valid file descriptor passed in as parameters. Ozone/Wayland then writes it clipboard data into it. At this point, the application requesting the data is responsible for reading the content from the other end of pipe, and proceed with the editing operation on its side, once data is exchanged. This is exercised by WaylandDataDeviceManagerTest::WriteToClipboard end-to-end, ie client_1 writes data -> compositor -> client_2 reads data. 2) Requesting clibpard data (reading) When requesting data from the system wide Clipboard (eg Chromium/Wayland user performs a paste operation), WaylandConnection calls wl_data_offer_receive. with a valid "WriteIn" file descriptor for the current "clipboard owner" write data into. Once written, the data is read by Ozone/Wayland, from the other end of the same pipe. This is exercised by WaylandDataDeviceManagerTest::ReadFromClibpard end-to-end, ie client_2 request data -> compositor -> client_1 writes data. BUG=578890 Change-Id: Ibfb8c26fe817e7639f32ac4bdc2f106d4b8bb513 Reviewed-on: https://chromium-review.googlesource.com/976461 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#553326}
-
Eugene But authored
GetErrorPage function will be used in ChromeWebClient::PrepareErrorPage. Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id2f9f3e86d9685ad0ac448bc767f7daf4a80e3be Reviewed-on: https://chromium-review.googlesource.com/1024277Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#553325}
-
Robert Ma authored
Most notably we'd like to include https://github.com/w3c/web-platform-tests/pull/10599, which added support for test variants in .any.js tests. Other changes in this roll: * Fixed paths in chromium.patch after the Blink mv. * Added the new wptserve/config.py to the whitelist. This roll also exposed an upstream issue. Filed issue 836377 to track it (fix is under way in the upstream). Bug: 836276, 829697, 836377 Change-Id: I5fc0af49c0149871222eaacd1bf5473b187c38a5 Reviewed-on: https://chromium-review.googlesource.com/1026165 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#553324}
-
Andrey Lushnikov authored
This patch uses OffTheRecord profiles to implement |Target.createBrowserContext| and |Target.diposeBrowserContext| methods for non-headless mode. R=dgozman BUG=836272 Change-Id: Ibd8b33bd9c804b69f17ef9cf1283b8c4bfc405ac Reviewed-on: https://chromium-review.googlesource.com/1023591 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#553323}
-
Lei Zhang authored
BUG=833380 TBR=mcnee@chromium.org NOTRY=true Change-Id: Ia38901113736af2fa923c301769282e834d531c3 Reviewed-on: https://chromium-review.googlesource.com/1026830Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#553322}
-
Michael Spang authored
Migrate ui/events/ozone/evdev to the new callback types as appropriate. Bug: 714018 Test: CQ & run chrome on eve Change-Id: Ic518057debb61cd6dbe297bebb13fec0538063c6 Reviewed-on: https://chromium-review.googlesource.com/1026523 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#553321}
-
Joel Einbinder authored
onTextEditorContentSet is a legacy method from when SourceFrame had many subclasses. Overriding setContent instead is simpler and makes for a cleaner plugin story around dispose/ensure plugins. As a drive-by, the currentSearchResultIndex getter was removed. Change-Id: I7f467da9297288b9f654eaf1cdd73b8be281cbaa Reviewed-on: https://chromium-review.googlesource.com/1020812 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#553320}
-
Joel Einbinder authored
Bug: 778043 Change-Id: I7f80eb1553eb48456441d5ccab6be903875bbcff Reviewed-on: https://chromium-review.googlesource.com/1023033 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#553319}
-
Mikel Astiz authored
This allows more easy testing of the feature under development/ experimentation. Bug: 681921 Change-Id: Ibdf822b04312e794ec2a20051d02f1847275a9f9 Reviewed-on: https://chromium-review.googlesource.com/1024831 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#553318}
-
Erik Chen authored
This CL is a refactor with no intended behavior change. It updates the semantics to explicitly take ownership of the WebContents. Bug: 832879 Change-Id: I62a6945aada916ff9538679934b2b767ea3adeb3 Reviewed-on: https://chromium-review.googlesource.com/1026311 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#553317}
-