GitLab

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/150201

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19799 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jorlow
TEST=layout tests should run again
BUG=15664

Review URL: http://codereview.chromium.org/150200

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19798 0039d316-1c4b-4281-b951-d872f2087c98

My tests show it as not as fast as the old NTP but it is a lot better
than before these changes:

Old NTP:
         208
         223
         211
         205
         211
Average: 211.6

NNTP before this change:
         732
         718
         718
         713
Average: 720.25

NNTP with this change:
         255
         248
         257
         254
         257
Average: 254.2

There is still room for improvements but this brings the NNTP perf
closer to being acceptable.

BUG=13362

TEST=Perf test at http://build.chromium.org/buildbot/perf/xp-release-dual-core/new-tab-ui-cold/report.html?history=200


Review URL: http://codereview.chromium.org/150194

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19797 0039d316-1c4b-4281-b951-d872f2087c98

TBR=hclam, jorlow
BUG=15664
TEST=no more unexpected passes

Review URL: http://codereview.chromium.org/150199

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19796 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/147258

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19795 0039d316-1c4b-4281-b951-d872f2087c98

Add a dependency to the Mac installer build stage so that the postflight.sh script always gets processed before it tries to build the installer than needs it.
Review URL: http://codereview.chromium.org/150184

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19793 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/150196

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19792 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=15780

Review URL: http://codereview.chromium.org/151185

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19791 0039d316-1c4b-4281-b951-d872f2087c98

ConnectJob will only call OnConnectJobComplete() on asynchronous completion.
TCPConnectJob now uses DoLoop() internally.
BUG=http://crbug.com/13289
TEST=none

Review URL: http://codereview.chromium.org/151118

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19789 0039d316-1c4b-4281-b951-d872f2087c98

Most of the changes are cosmetic, but there is also a
memory leak in CreateExpiredServer.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/153001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19788 0039d316-1c4b-4281-b951-d872f2087c98

The initialization of media::PipelineThread needs to
done asynchronously or a lot of dead lock will happen.

Review URL: http://codereview.chromium.org/149123

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19787 0039d316-1c4b-4281-b951-d872f2087c98

stopped_ variable is not initialized in DecoderBase, results in dropping packets.

Review URL: http://codereview.chromium.org/151170

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19786 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/151184

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19785 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/151182

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19784 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/151180

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19783 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/150189

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19782 0039d316-1c4b-4281-b951-d872f2087c98

TEST=Several (all mentioned in said bug)
BUG=15777
Review URL: http://codereview.chromium.org/151174

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19781 0039d316-1c4b-4281-b951-d872f2087c98

crash. Specifically:

. Adds a CHECK to IDMap that evaluates to true if adding NULL. The
  default isn't to do this check.
. browser_shutdown CHECKs if the # RPHs changes while iterating
  through the RPHs.

BUG=15615
TEST=none

Review URL: http://codereview.chromium.org/150181

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19779 0039d316-1c4b-4281-b951-d872f2087c98

into the gyp build.  21 of them fail, but that is only because they don't
have test input yet -- I haven't added the build code that copies
the test inputs into the build dir yet.
Review URL: http://codereview.chromium.org/147129

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19778 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/151172

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19776 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jorlow
TEST=none
BUG=15762
Review URL: http://codereview.chromium.org/151175

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19774 0039d316-1c4b-4281-b951-d872f2087c98

Remove a bunch of low-level keychain helper tests that are now redundant with tests of the newer higher-level methods.
Start collecting the helpers into a cohesive class that serves as a translation layer between keychain items and password forms.

BUG=none
TEST=Keychain passwords should still fill after a username is typed on the Mac (no change in behavior).
Review URL: http://codereview.chromium.org/151164

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19773 0039d316-1c4b-4281-b951-d872f2087c98

using optional parameters to enableForTab.

BUG=http://crbug.com/11906
TEST=None

Review URL: http://codereview.chromium.org/149046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19772 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/150183

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19771 0039d316-1c4b-4281-b951-d872f2087c98

Tested as follows:

Create a new window with two tabs.  Type a bunch of 'a' characters into tab A's omnibox and a bunch of 'b's into tab B.  Then,

1. Select tab A.  Left-click in the omnibox and highlight a few characters in the middle.  Left-click in the empty space to the right of the text to unhighlight it, then middle-click to make sure that the previously-highlighted text still gets pasted.

2. Repeat 1, but hit a key to remove the selection instead of clicking the mouse.  The old highlighted text should still be available as the primary selection.

3. Highlight A's text as in 1.  Select tab B and see that the omnibox is updated to B's string and highlighting is removed.  Middle-click and confirm that the previously-highlighted text from A is pasted.

4. Select A and left-click in the middle of its string to position the cursor there.  Click on tab B and then back on A to check that A's cursor position is restored.

5. Highlight text in A.  Select tab B and then highlight text from a different window.  Switch back to A and middle-click.  The text from the different window, rather than A's previously-highlighted text, should be pasted.

BUG=9225

Review URL: http://codereview.chromium.org/151006
Patch from Dan Erat <derat@google.com>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19770 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/150153

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19769 0039d316-1c4b-4281-b951-d872f2087c98

Also, remove a test we are passing due to backing out of changes upstream.

R=jorlow
BUG=15113
BUG=10474
BUG=15710
BUG=15733
TEST=no layout test regressions

Review URL: http://codereview.chromium.org/151161

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19768 0039d316-1c4b-4281-b951-d872f2087c98

The tests would then not be run by GUnit, polluting the outputs.
This CL makes sure we don't launch the disabled tests.

BUG=None
TEST=Run the browser tests. Look at the output, it should not show disabled tests have been run.

Review URL: http://codereview.chromium.org/150177

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19767 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/151168

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19766 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/151173

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19765 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/150182

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19764 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/150180

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19763 0039d316-1c4b-4281-b951-d872f2087c98

Companion change to https://bugs.webkit.org/show_bug.cgi?id=15457.  Add logging to the layout test plugin and add the expected output (the line number is off by 1 from the WebKit due to some difference in v8).
Review URL: http://codereview.chromium.org/118486

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19762 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/151169

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19761 0039d316-1c4b-4281-b951-d872f2087c98

Mark these two mime-types as supported:
  audio/mpeg
  video/mpeg

Review URL: http://codereview.chromium.org/150047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19760 0039d316-1c4b-4281-b951-d872f2087c98

Diable Broken RenderViewHostManager browsertest from http://src.chromium.org/viewvc/chrome?view=rev&revision=19752

R=ojan

Review URL: http://codereview.chromium.org/150179

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19759 0039d316-1c4b-4281-b951-d872f2087c98

BUG= http://crbug.com/14579
TEST= Install a theme with themed window control buttons.  Observe that WCB's are themed.

Review URL: http://codereview.chromium.org/150041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19758 0039d316-1c4b-4281-b951-d872f2087c98

Some cleanup to rebaselined WebKit layout tests by removing bogus results and those who have same results in Linux as in Windows.


Review URL: http://codereview.chromium.org/150142

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19757 0039d316-1c4b-4281-b951-d872f2087c98

Checked in for Ben Laurie
Original review: http://codereview.chromium.org/150165

Review URL: http://codereview.chromium.org/151166

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19756 0039d316-1c4b-4281-b951-d872f2087c98

Bug=None
TEST=None
Review URL: http://codereview.chromium.org/151158

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19755 0039d316-1c4b-4281-b951-d872f2087c98