GitLab

Reverted CL is in PS1.
New CL is in the latest PS.

Reason for revert: The commit tried to access the scroll_element_id
of a scrollbar layer that was destroyed causing a use-after-free. The
bot that caught this (WebKit Linux ASAN) doesn't run during the DryRun.

[Original CL that got reverted]: https://crrev.com/c/1854534

CL description:
This CL stabilizes a test that fails due to defererencing a freed raw
pointer in cc::ScrollbarController. The fix is to get rid of that raw
pointer entirely and instead, retrieve the ScrollbarLayerImplBase on
demand using the CapturedScrollbarMetadata.

Bug: 1002828, 987115, 1014930
Change-Id: Ica9128f616f6ad83f72f7e94659a9bc81bc3d1c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865529
Commit-Queue: Rahul Arakeri <arakeri@microsoft.com>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707520}

With the NetworkService, InterceptDownloadIfApplicable is always called
on the UI thread.

Remove some overrides that are unnecessary, and unconditionally intercept
downloads --- rather than missing some, and cancelling them in
DetermineDownloadTarget.

Bug: none
Change-Id: Ia85f420d7d7aca3d14823e1d38d597e07bbf3f51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866551Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707519}

Android O fails to correctly set the windowLightStatusBar attribute when
modified via applyStyle, so switch to setting it programmatically on O.

This bug only affects the Preferences activity, where the theme can be
changed.

Bug: 1014844
Change-Id: I5a3dc11a7c5c1aeb8410c2cb12f1c9eb4e49a9f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866991Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707518}

This adds browser tests to verify the behavior of the Legacy
Cookie Access policies, which allow reversion to Legacy SameSite
cookie behavior.

Bug: 978172
Change-Id: I1060978196a25ed8f2e94fc90a27f04238e3c699
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865414
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707517}

https://android.googlesource.com/platform/external/perfetto.git/+log/b78fa92a5114..8fac64fcd1ec

git log b78fa92a5114..8fac64fcd1ec --date=short --no-merges --format='%ad %ae %s'
2019-10-18 fmayer@google.com Merge "Longer tracing session for Java Heapprofd CTS."

Created with:
  gclient setdep -r src/third_party/perfetto@8fac64fcd1ec

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: Idcf62497202f78f6a724f644153e97dca641146e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869435Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707516}

Adds a DCHECK for "$1" style placeholders in WebUI template
replacements.

When WebUI is replacing $i18n{foo} with a string, the string should
already have its own "$1" style placeholders replaced at that point.
Otherwise, the resulting HTML will include those placeholders.

$i18nPolymer is treated as an exception, since those strings might be
used as inputs to computed bindings that will use JS substitutions.

Bug: 987877
Change-Id: Iae02b84775b8a767e905c7528dfc85da6cac20e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721237Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Auto-Submit: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707515}

The displayed current page number in the PDF viewer's page indicator is
incorrect when the custom pages setting input is out of order. Sort
the pages before storing them in the settings so the page numbers are
displayed in the correct order.

Bug: 1015145
Change-Id: I56c0108bf2ae8c6dba9d44d5c0d0046a8b7b6b9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867378
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707514}

https://pdfium.googlesource.com/pdfium.git/+log/94e600d98301..44d038359f4e

git log 94e600d98301..44d038359f4e --date=short --no-merges --format='%ad %ae %s'
2019-10-18 thestig@chromium.org Rename FXFONT_BOLD flag to FXFONT_FORCE_BOLD.
2019-10-18 thestig@chromium.org Do more CPDF_StreamContentParser initialization in the header.
2019-10-18 thestig@chromium.org Replace |CPDF_StreamContentParser::m_DefFontSize| with a constant.
2019-10-18 thestig@chromium.org Do more testing in ByteString.OneCharReverseIterator unit test.
2019-10-18 thestig@chromium.org Rename some Empty() methods to Clear().
2019-10-18 thestig@chromium.org Add a test case for incorrectly rendered Japanese PDFs.

Created with:
  gclient setdep -r src/third_party/pdfium@44d038359f4e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=pdfium-deps-rolls@chromium.org

Bug: None
Change-Id: Ia5308fd66b19b7111c351603a932919e3143725b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869442Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707513}

Add the user actions added in
https://chromium-review.googlesource.com/c/chromium/src/+/1853826
to actions.xml

Bug: 982018
Change-Id: Ib117b2ed12e1810ea23bca143c4311683bc7e5ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868592
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Auto-Submit: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707512}

Also provides BlinkPlatformWithTaskEnvironment::GetTaskEnvironment()
so that unittests can get access to it.  Previously, it was hidden
in //media/blink/run_all_unittests.cc .

Change-Id: Ib2a13045fd377d603f8b08cba9e78da76dc67099
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868838Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707511}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/68efdcdaefe2..a5230910bf2f

git log 68efdcdaefe2..a5230910bf2f --date=short --no-merges --format='%ad %ae %s'
2019-10-18 chrome-bot@chromium.org Update config settings by config-updater.

Created with:
  gclient setdep -r src/third_party/chromite@a5230910bf2f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: If28d7c630e665b898f1c7cf8c62e342a64364dc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869733Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707510}

Due to an unnoticed change in the clang_update script, the |cov_path|
and |profdata_path| paths in the update_clang_coverage_tools.py script
don't point to the actual binaries anymore, which results in that the
script download and unpack the coverage tools every time when users try
to run the scripts.

This CL fixes the issue.

Bug: 1006099
Change-Id: Ib9c330e6e57caa49a8ec98762f187cf67d082423
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868985Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707509}

This change adds a new enum to capture usage of the screen rotation
shortcut on Chrome OS. The pref tracking whether the confirmation
dialog for this shortcut is reset so all users will see this dialog
the first time they hit Ctrl-Shift-Refresh after this CL lands.

This data will be used to inform our decision around the future of the
rotation shortcut.

Bug: 1013349
Change-Id: I3ebc3bb0088426c311f13fba72e2d4322a9252b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863254
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707508}

This reverts commit a6e6a520.

Reason for revert: The original CL had nothing to do with the Spawned test server failing to start, which is https://crbug.com/869227

Original change's description:
> Revert "Add NetworkIsolationKey to HttpAuthCache server (not proxy) entries."
> 
> This reverts commit 3d69076b.
> 
> Reason for revert:
> net_unittests on Intel GPU on Mac failed because of:
> SSLClientSocketReadTest.Read_ManySmallRecords/3
> OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/19
> OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/12
> OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/13
> ...
> https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests
> 
> Original change's description:
> > Add NetworkIsolationKey to HttpAuthCache server (not proxy) entries.
> > 
> > Also add a value to enable it for a particular NetworkSession, though
> > currently nothing enables it. Followup CLs will add field trials and
> > enterprise policies to do so, and also hook up Network Service APIs to
> > correctly add entries to the cache for a particular NetworkIsolationKey.
> > 
> > Bug: 993801
> > Change-Id: I37887a018d9462ecabb80b924b4c44d3ddbee270
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863469
> > Reviewed-by: Christian Dullweber <dullweber@chromium.org>
> > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
> > Reviewed-by: Asanka Herath <asanka@chromium.org>
> > Commit-Queue: Matt Menke <mmenke@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#707327}
> 
> TBR=achuith@chromium.org,alemate@chromium.org,mmenke@chromium.org,asanka@chromium.org,dullweber@chromium.org
> 
> Change-Id: I0fc2915596b281502b409b8914831d661b094666
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 993801
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869753
> Reviewed-by: Lan Wei <lanwei@chromium.org>
> Commit-Queue: Lan Wei <lanwei@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#707504}

TBR=achuith@chromium.org,alemate@chromium.org,mmenke@chromium.org,lanwei@chromium.org,asanka@chromium.org,dullweber@chromium.org

Change-Id: Iedb40bfec50cf5b3e548a1e9bce534f2105214db
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 993801
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869479Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707507}

Stack symbolization is known to not work on CrOS if the test is being
run locally (as opposed to over SSH) and the root filesystem is set to
read-only. So, skip the Telemetry minidump stack symbolization tests
on CrOS if we detect that we're running in local mode.

Bug: 1014177
Change-Id: If2ca8f43b0aa76db47d5feb447501b8fe8f3be6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860760Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707506}

Follow up to issue-1768818. Removes overrides of CanDecodeToYUV() and
instead always returns |allow_decode_to_yuv_| which is false by default.
In the JPEG image decoder, the deciding logic for YUV decoding is moved
to OnSetData().

Moves the HasImagePlanes() check for YUV decoding to after header is
checked. This allows YUV images planes to be set anytime before
decompression.

Additionally, allows the caller of ImageDecoder::Create to explicitly
allow/disallow jpeg yuv decoding.

Bug: 919627
Change-Id: I9e4846077d4b0560e96ad4aeb0a26b1c7d05917d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795664Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707505}

This reverts commit 3d69076b.

Reason for revert:
net_unittests on Intel GPU on Mac failed because of:
SSLClientSocketReadTest.Read_ManySmallRecords/3
OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/19
OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/12
OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/13
...
https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests

Original change's description:
> Add NetworkIsolationKey to HttpAuthCache server (not proxy) entries.
> 
> Also add a value to enable it for a particular NetworkSession, though
> currently nothing enables it. Followup CLs will add field trials and
> enterprise policies to do so, and also hook up Network Service APIs to
> correctly add entries to the cache for a particular NetworkIsolationKey.
> 
> Bug: 993801
> Change-Id: I37887a018d9462ecabb80b924b4c44d3ddbee270
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863469
> Reviewed-by: Christian Dullweber <dullweber@chromium.org>
> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
> Reviewed-by: Asanka Herath <asanka@chromium.org>
> Commit-Queue: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#707327}

TBR=achuith@chromium.org,alemate@chromium.org,mmenke@chromium.org,asanka@chromium.org,dullweber@chromium.org

Change-Id: I0fc2915596b281502b409b8914831d661b094666
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 993801
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869753Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707504}

This was broken by https://crrev.com/8d654258 where
PepperMediaDeviceManager was not updated to acquire the relevant
interfaces from their new location.

Bug: 1013652
Change-Id: I040943975c4638159f788b47e24aa3a20ee729d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869019Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#707503}

Issue: In SDK.NetworkLog._initiatorChain, we potential run into the case where
[initiatorDataSymbol] is not defined yet when we recursively walk up the
initiator chain for the request.

This changes adds initializeInitiatorSymbolIfNeeded in the walking process
and also fix a "typo" in initiatorGraphForRequest networkManager checking.

Change-Id: Ibaa1deec6c2548e149554aa526abf27a61711621
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867412Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Commit-Queue: Junyi Xiao <juxiao@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#707502}

Add comments in the LoggedInUserMixin header file to describe
instructions on how to use the class to log in as child or regular
user within a browser test. Add TODO to LoginPolicyTestBase to
deprecate that class in favor of LoggedInUserMixin.

Bug: None
Change-Id: I1688586cc12fbb21b446fc90bbf6510ec8ced59a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863754Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707501}

We already have a check to ensure that we only send active network
change notifications when an actual change occurrs. This ensures that
we send an update if needed any time the State property changes, e.g.
from portaled to non portaled.

Bug: 1002175
Change-Id: Ia6c594f8513b1870e02ba10c0d44522290c54991
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866922Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707500}

This will ensure the title string will be translated.

Bug: 1014726
Change-Id: Ia173d5f2f46576d1db44ddb52e34ae2a9fb4be46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865625
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707499}

Bug: 1015882
Change-Id: I5aa89bbaa0260281669555aa1a7b369a382620cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866437
Commit-Queue: Charlie Reis <creis@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707498}

Deletes the BatchedOperation mojom struct, which is the last of the
remaining leveldb mojom API surface. All uses are replaced with
equivalent usage of the LevelDBDatbaseImpl/DomStorageDatabase API.

This change is part of a continued effort to remove unnecessary layers
from the DOM storage implementation. The LevelDB backend it uses was
Mojoified at some point in anticipation of mus+ash needs and/or moving
higher-level logic into renderers. Since neither of these are currently
practical to pursue further, migration of DOM Storage into the Storage
Service is a good opportunity to do some cleanup.

Bug: 1000959
Change-Id: I42ac36c160761f2cf5141075424c27d2f1f4823a
Tbr: sky@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866920
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707497}

Bug: 82078
Change-Id: Ia74b3a0b0b0141dbe1408e880d94ea7dd9471acc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867815
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707496}

It tests the Chrome client for CBCM enrollment. The enrollment is tested against our QA server. It also partially covers the communication to the test server by verifying the CBCM status entry,

Change-Id: I6ff2b7bdf1340144a31672a2688c624689866db3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779440
Commit-Queue: Xiang Ji <jxiang@google.com>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707495}

compositing/video/video-poster.html
is flaky from 10/18 on Windows, Mac and Linux.
https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUgsSBUZsYWtlIkdjaHJvbWl1bUBibGlua193ZWJfdGVzdHNfZXhwYXJjaGl2ZUBjb21wb3NpdGluZy92aWRlby92aWRlby1wb3N0ZXIuaHRtbAw

TBR=wangxianzhu@chromium.org

Bug: 1015764
Change-Id: I3701bb7ea8cdacd3324469ab779239c80c903545
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868981
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707494}

Fix an issue triggered on cross-process navigations that would result
in UrlRequestRewriteRulesManager incorrectly keeping track of live
RenderFrameHosts for a given Frame. This happens because cross-process
navigations trigger a RenderFrameCreated even for a FrameTreeNode ID
before the RenderFrameDeleted event for the older RenderFrameHost. The
sequence goes like this:
* Frame creation
  * Tracking RFH IDs: []
* RenderFrameCreated(0x1810) with FrameTreeNode ID 2.
  * Tracking RFH IDs: [2]
* RenderFrameCreated(0xa410) with FrameTreeNode ID 2.
  * Tracking RFH IDs: [2]
* RenderFrameDeleted(0x1810) with FrameTreeNode ID 2.
  * Tracking RFH IDs: []
* RenderFrameDeleted(0xa410) with FrameTreeNode ID 2.
  * At this point, the DCHECK is triggered because there is no RFH
    with ID 2 being tracked.

The map now keeps track of the currently active RenderFrameHost for a
given FrameTreeNode ID so we can now know when it is safe to ignore a
"second" RenderFrameDeleted event for the same FrameTreeNode ID.

Bug: 1014281
Test: Load gmail.com -> Refresh -> No DCHECK triggered.
Change-Id: I82ce437c8c45984c695658d0e2d7deea45aad63e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864023
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707493}

https://webrtc.googlesource.com/src.git/+log/1d6005296701..0e3485c338ff

git log 1d6005296701..0e3485c338ff --date=short --no-merges --format='%ad %ae %s'
2019-10-18 mbonadei@webrtc.org Revert "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."
2019-10-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f29003dd..0d702034 (707259:707387)
2019-10-18 saza@webrtc.org AEC3: Multi channel ERL estimator
2019-10-18 jakobi@webrtc.org Update the minimum bitrate when a stream allocation is removed.
2019-10-18 mbonadei@webrtc.org Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.

Created with:
  gclient setdep -r src/third_party/webrtc@0e3485c338ff

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None,chromium:None
Change-Id: I929bf65f75afabda92991128c86b7f79ffa7de87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869441Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707492}

This change creates InfobarTranslateCoordinator and
implements the basic methods of an InfobarCoordinator and TranslateInfoBarDelegate.
It also creates kInfobarTypeTranslate and expands infobar_metrics_recorder to handle
this case.

Bug: 1014959
Change-Id: I994abf7205f405da3aa20f0fb726a3701b6a145d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864716Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707491}

The new logic was probably more "correct" in an absolute sense but broke
existing themes. The old logic is consistent with existing themes.

See https://chromium-review.googlesource.com/c/chromium/src/+/1847775
for the consolidation and change that removed the old logic.

Fixes: 1013870
Bug: 1013870
Change-Id: I1bed6bd16ac1151110bc07a0fd0d4654b4ae21e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869474Reviewed-by: Caroline Rising <corising@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707490}

Bug: NONE
Change-Id: I30b44520dbd7e69b7ed076afbed964f50e77455a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867123
Commit-Queue: Tim Judkins <tjudkins@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707489}

Change-Id: I0b85c93dd4e257d056e17699966419e6fb839f63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869415Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707488}

Split WebviewController into a generic base class that only
deals with mutating the WebContents. The split allows implementing
a Webview and CastApp controller differently while retaining common
functionality in the base class.


Bug: b/136460199
Test: Compile
Change-Id: I4267e3c6ac4e3904160e7ee34e35d2b220777cad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867189Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Shawn Gallea <sagallea@google.com>
Cr-Commit-Position: refs/heads/master@{#707487}

This reverts commit 60f3e975.

Reason for revert:
WelcomeScreenBrowserTest.WelcomeScreenNext is still flaky on ChromeOS,
https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyTAsSBUZsYWtlIkFjaHJvbWl1bUBicm93c2VyX3Rlc3RzQFdlbGNvbWVTY3JlZW5Ccm93c2VyVGVzdC5XZWxjb21lU2NyZWVuTmV4dAw

Original change's description:
> Revert "Disable WelcomeScreenBrowserTest.WelcomeScreenNext."
> 
> This reverts commit 2aa5da39.
> 
> Reason for revert: reenabling given crrev.com/1864618
> 
> Original change's description:
> > Disable WelcomeScreenBrowserTest.WelcomeScreenNext.
> > 
> > Bug: 1014952
> > Change-Id: I1df1941c2a0a92d243cb4e4624ae920b150c7694
> > Tbr: achuith@chromium.org
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865351
> > Reviewed-by: John Budorick <jbudorick@chromium.org>
> > Commit-Queue: John Budorick <jbudorick@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#706500}
> 
> TBR=achuith@chromium.org,jbudorick@chromium.org
> 
> Change-Id: I86cba6fe329f52b5bdcd7b07d04d1dfb40fa65cf
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1014952
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866407
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#706891}

TBR=achuith@chromium.org,jbudorick@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1014952
Change-Id: I57bebd90ee517d2c2d729fc91dcef9667ea3ebe0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869073Reviewed-by: Lan Wei <lanwei@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707486}

Convert the implementation and all users of the
chrome_cleaner::mojom::TestPUPTypemap interface.

Bug: 955171
Change-Id: I76024a22fbdca21cd5f92927ef70da685f226a68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863806
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707485}

This returns to the current task's task runner. Note there are some
situations where this is not valid:

* When we're not running a task (it will DCHECK).
* When we're in a one-off base::ThreadPool task (it will DCHECK).
* In non-scheduler backed threads (it will DCHECK).

Bug: 835323
Change-Id: I3a789557247240e0c36a47339574350d79746144
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834094
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707484}

Move FrameHostMsg_RegisterProtocolHandler,
FrameHostMsg_UnregisterProtocolHandler messages to mojo. This allows
blink to not expose them on the WebLocalFrameClient API.

BUG=1008432

Change-Id: Ia6a505b9e33a81f6a4c209f275b6344850aeeb0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864397Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707483}

- This is the first step in implementing never-slow-mode in chrome.
- Both flags are disabled by default.
- Blink runtime flag will use the chromium feature state.

Bug: 892672
Change-Id: I2098e435628219ffe5a798d485d73e1e0c590bc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864331Reviewed-by: Jason Chase <chasej@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Rodney Ding <rodneyding@google.com>
Cr-Commit-Position: refs/heads/master@{#707482}

- use base::Optional in all internal AXTreeSourceArc node id usages. This makes it clear where we are setting values and not, forcing the author to think about the id. This also catches various places where optional ids were hard-coded. This change is independent of the broader switch to use kInvalidAXNodeId as an invalid id (which still works), but is not a concern in code internal to AXTreeSourceArc.
- refactor common code from AccessibilityWindowInfoDataWrapper and AccessibilityNodeInfoDataWrapper into base class. I've also renamed it to AccessibilityInfoDataWrapper to align naming.
- align the ordering of function declarations (in .h) with their order in .cc. Also, declare non-overiddenn methods first in each visibility block in .h.
- remove some obsolete forward declares and functions (e.g. Focus()). Unsure why compiler did not catch this.
- it is fine to have some AXTreeSource methods as public and some as private, remove TODO and group methods together.

Bug: none
Test: unit_tests --gtest_filter=AXTreeSourceArc*.*
Change-Id: I39f2ae67a213df450327bc70ef540c0aa6f0510e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860524
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Sara Kato <sarakato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707481}