- 24 Jun, 2019 40 commits
-
-
Hector Carmona authored
Enterprise users will see Navi onboarding unless disabled by the PromotionalTabsEnabled policy. If Navi onboarding is NOT enabled there will be NO onboarding at all. Onboarding can be disabled by: - Setting PromotionalTabsEnabled to false - Disabling the NuxOnboarding feature - Onboarding won't be available on Chromium unless the NuxOnboardingForceEnabled feature is enabled Bug: 956678 Change-Id: I30fd7c688b1d8772659f5872f575a14d9b7f2163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600548 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:Tommy Martino <tmartino@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#671746}
-
Mike Dougherty authored
Remove old feature success metrics for already shipped context menu iframe suppport. Additionally, extend expiry for still useful metrics. Bug: 852488, 975439, 975752, 975833, 975929 Change-Id: I220af00f64d2353613f2ea1c0144535921d1e80a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666712 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#671745}
-
Ahmed Mehfooz authored
Feature Pods page can now be changed by: Swiping touch gesture in the feature pods area Scrolling / Swiping on touchpad while cursor is in feature pods area Mousewheel scroll while cursor is in feature pods area Added unit tests for FeaturePodsContainerView Bug: 914077 Change-Id: I388f4dc2e70484e34c18bf007c455bed33434532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610874Reviewed-by:Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#671744}
-
Yuwei Huang authored
Previously we assumed START_OF_BATCH is always the first event to receive in a ReceiveMessages stream sequence and used it to track the start of the ReceiveMessages stream. This is generally true for most of the time but in rare cases START_OF_BATCH can happen after PONG, which will result in broken state and crash the app. This CL switches to rely on the initial metadata sent by the server to determine if the stream has been started or not. Bug: 976895 Change-Id: I0d075fed4a7cf9e20896b74dab9e37eeab67fc63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672485 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#671743}
-
Emil A Eklund authored
Bug: 591099 Tbr: cbiesinger@chromium.org Change-Id: I03e707a475e685084bdfbe04203b8c53fdadeacd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674219Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#671742}
-
Karan Bhatia authored
Rename is_browser_side_navigation to is_navigation_request in WebRequestInfo. Since PlzNavigate is launched all navigations are "browser-side". BUG=None Change-Id: Ib0b3b4105186a4ef5bbde1e25fd3aad8a44279d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668341Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#671741}
-
Robert Ma authored
The previous attempt (r659717) which used a temporary output directory failed because following steps (at least "archive results for webkit_layout_tests") assume that the merged results live in $PWD/layout-test-results on Swarming: https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/steps.py?l=1328&rcl=0654c98fc1a29640e3a6d99a1350b37efdb9a1df This time, we still use CWD as the output directory but only clearing the `layout-test-results` directory and `output.json` instead of everything in CWD, so that other directories, like `profraw` used by code-coverage won't be affected. While doing so, the flag is renamed to better reflect the behaviour. This change also reverts r658379, which was a temporary workaround from the code-coverage side. A couple of drive-by fixes for temporary output dirs (not related to this bug): * Use a less confusing directory suffix (not ending in .). * Implicitly turn on --allow-existing-output-directory when a temporary output directory is used. Bug: 960994 Change-Id: Ief29562ff3526aaa6ed7ffe364cccb94202bf8d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670152Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#671740}
-
Kevin Babbitt authored
Move the helper functions for loading an accessibility dump expectation file and validating a dump into their own test helper class. This is purely code movement - no changes apart from fixing up dereferences where necessary. I originally wanted to add these methods to AccessibilityTreeFormatter but that failed a presubmit check for LOG(INFO) spam. AccessibilityTreeFormatter isn't test-only code - it's used from the chrome://accessibility page - so I opted for creating a new class for the test helper methods instead. R=nektar@chromium.org Bug: 974397 Change-Id: Ib9d5105747b1418c215c5d11020c92dedade099f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669947 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#671739}
-
Kelvin Jiang authored
Change page title for the extensions details page in chrome://extensions to Extensions - <extension name> Bug: 867053 Change-Id: I3383ff4f3f0105ca10cbd8609ab5a311e03bf4d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669909Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#671738}
-
chrome-bot authored
Bot config was added in https://crrev.com/c/1649302 but our recipe and tests didn't work yet so we disabled the trigger in https://crrev.com/c/1656969. They should now work (tested with our try bot), so restoring the trigger. Change-Id: Iddec92e74ad9d3d608f6e5fdc05b2f58fde1d576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670607 Auto-Submit: Mathieu Binette <mbinette@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#671737}
-
John Budorick authored
also add presubmit pylint & autoformatting to //tools/infra. Bug: 977664 Change-Id: Ib08fc7f6ded5d565cb68a238a5f7839d59496ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673081 Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
-
Xida Chen authored
Right now in PaintRenderingContext2D, the canvas is scaled after the InitializePaintRecorder. This is too late because we already do canvas->save() at the InitializePaintRecorder. Trying to scale the canvas after save operation doesn't apply the scale. This can be seem by zoom in a paint worklet page and seeing that the drawing isn't zoomed in. This CL fixes the problem and added a layout test. Bug: 970783 Change-Id: Ic0c8a84cc22c8cef9b325e134925e482bee1e65d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670439Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#671735}
-
Suzy Li authored
isUVPAA is currently implemented in AuthenticatorImpl.java by using fingerprintManager. GmsCore SDK v26 now provides its own implementation of isUVPAA as part of the FIDO2 APIs, so Clank should call that API instead. This CL is the initial change to support the implementation on clank. It adds isUVPAA interface and callback, but does not actually use the isUVPAA in Gmscore. Once the implementation on clank landed, will add a follow up change to use it. Bug: 976480 Change-Id: Idc939f798720b413e5f62c7269f9771fad7f9111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671707Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Suzy Li <suzyli@google.com> Cr-Commit-Position: refs/heads/master@{#671734}
-
Vadym Doroshenko authored
Bug: 975229, 975768 Change-Id: I22a1680a0beabf2b3604986a1b651026acec6cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674087Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Auto-Submit: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#671733}
-
Kevin Marshall authored
The official builder uses CIPD YAML files that are generated dynamically by GN, so the static files are no longer needed. CIPD documentation is ported to a generic README.md. Bug: 974363 Change-Id: Ia8fd1c1af5fd19ff4a68d36abe0de156d1d5265d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670020 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Auto-Submit: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#671732}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/9d1193b591c5..ad6de6a08a66 git log 9d1193b591c5..ad6de6a08a66 --date=short --no-merges --format='%ad %ae %s' 2019-06-24 asweintraub@google.com Fix ClangTidy-Readability/Naming findings in core/fpdfapi. 2019-06-24 thestig@chromium.org Switch from vector to deque for another CXFA_FFDocView members. 2019-06-24 chinsenj@google.com Fix Heap-buffer-overflow caused by PDF_DataDecode() refactor 2019-06-24 asweintraub@google.com Fix 22 ClangTidy - Readability/Naming findings in fpdfsdk. 2019-06-24 asweintraub@google.com Fix 2 ClangTidy - Readability/Naming findings in core/fdrm Created with: gclient setdep -r src/third_party/pdfium@ad6de6a08a66 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:949425,chromium:977832 TBR=pdfium-deps-rolls@chromium.org Change-Id: Ibae0cc2eab33d9fc235328820b0b550c81857887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674217Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671731}
-
Matt Simmons authored
Address TODO and remove state from TabListOnScrollListener. R=yusufo@chromium.org Bug: 977955 Change-Id: I45b6020ce855fd0b4cd81c25c5af1b3ca491fd93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673538Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Cr-Commit-Position: refs/heads/master@{#671730}
-
Pavel Yatsuk authored
NTP and ES. BUG=977156 R=skym@chromium.org Change-Id: I9eeaec544e61ed3505b9606ca71b6712dedcdcad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672210Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#671729}
-
Mehran Mahmoudi authored
Currently, we use AlertDialogs for displaying the dialog that shows up when there is a missing Android permission. This CL replaces this approach with ModalDialogManager for displaying said dialog. This CL also adds support for generating a touchless version of the dialog model for touchless devices. Bug: 974271 Change-Id: I786e2a7f7e2e48f57abd5d3a4674a51c902be51f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667748Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#671728}
-
Chris Harrelson authored
Change-Id: Ie9adf5ba6dbde516e79db2c2933620675edea43f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669325 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#671727}
-
Mugdha Lakhani authored
changes + few WPT and web_tests. Bug: 925297 Change-Id: I5c8833e236f7cf9b2993e69494ec4dc9797f7120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660446 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#671726}
-
Allen Bauer authored
TBR: azurewei@chromium.org, shuchen@chromium.org Bug: 945335 Change-Id: I386c03f5d06213ec767cf30ee1e9db83ceeed8b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659272 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#671725}
-
Robert Kroeger authored
This reverts commit 62120966. Reason for revert: Consistent failure in Windows FYI GPU bots per https://crbug.com/978026 Original change's description: > Testing for SwapChainFactoryDXGI > > Updated GLImageDXGISwapChain to use EGL Images instead > of pbuffer surfaces, to avoid creating render target view > for front buffer. > > Bug: 939655 > Change-Id: Iec80f399724ee0509dd95d126c0d3dbb883bb87c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663014 > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Commit-Queue: Ashitha Santhosh <ashithasantosh@google.com> > Cr-Commit-Position: refs/heads/master@{#671369} TBR=zmo@chromium.org,sunnyps@chromium.org,ashithasantosh@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 939655 Change-Id: I70034691f129a0ac4ff1146d3a7742c1d3953e07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673837Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#671724}
-
Mohammad Refaat authored
CRWWebController dismissModals calls LegacyNativeViewController dismissModals which calls nativeViewController (the only rememaining is readingList) dismissModal ReadingListController doesn't implement dismissModal anyway. So this is not needed. Bug: 960950 Change-Id: Ia3f253118b8b5fff9a7eb5aecf2709ef26afc7da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672604Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Subsequent CLs will enable the Blink flag and remove dead code paths. Bug: 948807 Change-Id: If8f5b784d4a84aae32817bd91085e1a3c747e84b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672084 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#671722}
-
Natalie Chouinard authored
Migrate Theme settings page from deprecated Framework Preferences to the Preferences Support Library. Bug: 968592 Change-Id: Ib1906faeb230d43870a9243def2b83ba545ff2db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670365Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#671721}
-
Xianzhu Wang authored
We use cc::Layer::ScreenSpaceTransform() when collecting layer tree for devtools in layer list mode. We need to call cc::LayerTreeHost::UpdateLayers() to make sure ScreenSpaceTransform() is up-to-date. Bug: 977578 Change-Id: I82ae3da7edb7cff56ae42ca5acbbbe129ec6ad27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673568Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#671720}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8d5f1ca18339..ab176bd6b58c git log 8d5f1ca18339..ab176bd6b58c --date=short --no-merges --format='%ad %ae %s' 2019-06-24 perezju@chromium.org [Telemetry] Replace SetTelemetryInfo with RecordBenchmarkMetadata Created with: gclient setdep -r src/third_party/catapult@ab176bd6b58c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:973837 TBR=sadrul@google.com Change-Id: Ie6c7adaa0f46dd5a7d13006f7e4e83642af3dee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673458Reviewed-by:
-
Daniel Rubery authored
Bug: 971430 Change-Id: Ibc4e8c636773129e7256da1a0f23599bc7f41ecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649255Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#671718}
-
Marc Treib authored
To allow this test, the infrastructure is extended to also verify the MessageType returned from SetUpDistinctCase. Bug: 977980 Change-Id: I6e6a882315926c9950cbe9dec43ce1ffe3e79872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674152 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#671717}
-
danakj authored
This moves content_browsertests and component_browsertests on Android off the initChromiumBrowserProcessForTests() and onto production code paths for initialization. We use the standard BrowserStartupController startBrowserProcessesAsync() method and wait for it to complete. The BrowserTestBase ui_task waits for the async initialization before running the test, by checking with the NativeBrowserTest.java class. R=avi@chromium.org, boliu@chromium.org, dtrainor@chromium.org, jbudorick@chromium.org Bug: 961849 Change-Id: I6b6ea2225a342e79e1f906d618fdc21c8b97568b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669981Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
-
danakj authored
The |ui_task| is run by the BrowserMainParts::PreMainMessageLoopRun for Shell and Chrome. It is run by BrowserMainParts::MainMessageLoopRun() for Cast. It is run by BrowserMainLoop::MainMessageLoopRun() for Headless and Fuchsia. Make this consistent by having each BrowserMainParts run the |ui_task| as part of the tasks from CreateStartupTasks(), in PreMainMessageLoopRun(). This makes it run as part of BrowserMainRunnerImpl::Initialize() instead of part of Run(), consistently. Then the code in BrowserMainLoop's MainMessageLoopRun() becomes dead and can be removed. In future work we would like to centralize these calls but it needs to be part of the Initialize() step, not part of Run() because Android never does run the BrowserMainLoop. R=sky@chromium.org Bug: 961849 Change-Id: I7441e322ba340047ff836f6055d52f6cb63ade93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669950Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
-
Min Qin authored
Currently the logic is to try to append a link break after each word, and see if the warning dialog length inceases. This is very inefficient as GetPreferredSize() call is very expensive. This CL improves the logic by starting at the middle of the text, and start searching forward or backward. BUG=972090 Change-Id: I5c96e52d44af9d8e82690814e5856381b08ab554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670368Reviewed-by:
-
Tomasz Śniatowski authored
Check use_thin_lto instead of thin_lto_enable_optimizations, as the latter is only defined in a BUILD.gn so can't be checked outside of it. Plus the intent of https://crrev.com/c/1642730 appears to have been to error out on LTO in general anyway. Fixes gn gen --args="is_clang=false target_cpu=\"arm\"" failing with: ERROR at //third_party/zlib/BUILD.gn:105:17: Undefined identifier assert(!thin_lto_enable_optimizations, ^---------------------------- Bug: 819294 Change-Id: Ibbcae447b01043edc8a118f4a3a3923f2d0ae261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667663 Auto-Submit: Tomasz Śniatowski <tsniatowski@vewd.com> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#671713}
-
Lucas Tenório authored
Bug: 977566 Change-Id: Ifd2237ed2e2d8e264c61737b4a9e0430122ded87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669615Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Cr-Commit-Position: refs/heads/master@{#671712}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/90c300fb4ac9..91032f8cd7ea git log 90c300fb4ac9..91032f8cd7ea --date=short --no-merges --format='%ad %ae %s' 2019-06-24 djsollen@google.com Fix typo to track sdk level not release property. Created with: gclient setdep -r src/third_party/skia@91032f8cd7ea The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@google.com Change-Id: Ie1b58753123f11f2a4e2a62e85e4371b380ce77d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673455Reviewed-by:
-
Eric Stevenson authored
Using relative paths was causing build failures. To create this change: * find out/Debug -name *_jni.h -delete * find . -name BUILD.gn -exec sed -i '/jni_package =/d' {} \; * ninja $MOJO_JNI_HEADERS * refactor_jni_includes.py --out-dir out/Debug --repl-dir mojo * fix DEPs files manually See https://groups.google.com/a/chromium.org/forum/?#!topic/java/MEovGrAwbqI for discussion on naming scheme. Bug: 964169 Change-Id: I31e5a8dc6b60ef31e41a8d532de0640e575489d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674186Reviewed-by:Ted Choc <tedchoc@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#671710}
-
Max Moroz authored
The end goal is to delete `base::FuzzedDataProvider` and always use the version from libFuzzer upstream, which in fact has evolved from the initial `FuzzedDataProvider` version that was created in Chromium -- kudos to Chrome networking team who, I believe, have implemented that class originally. Since this is the first migration CL, I've also slightly updated libFuzzer docs to make sure new fuzzer authors won't depend on the class living in //base. Bug: 907103 Change-Id: I7042664142efce97835e09fc6f1d7c9eff3c5a7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671287Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#671709}
-
Adam Raine authored
Since this test case was added to test functionality on PaintWorklet rather than PaintWorkletProxyClient, it made more sense to move it here. Follow up to: https://chromium-review.googlesource.com/c/chromium/src/+/1658950 Bug: 948761 Change-Id: I41adca041cb473cc09ec4f21fe84329fed5308aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672057Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Adam Raine <asraine@google.com> Cr-Commit-Position: refs/heads/master@{#671708}
-
Tanmoy Mollik authored
Files in component build google_apis now uses CoreAccountId instead of std::string. Bug: 959157 Change-Id: Ic621471a8a77bb0628af2631a1305da00cccd63b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670892 Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#671707}
-
