GitLab

http://src.chromium.org/viewvc/blink?view=revision&revision=201140

BUG=252696
TBR=fs@opera.com

Review URL: https://codereview.chromium.org/1306723007 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201162 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A remote frame can be detached by setting its .style.display = 'none'.
  If we attach it again by setting its .style.display = '', the frame
  becomes widget/FrameView-less. This CL sets the widget of the frame.

BUG=517291
Test=With --site-per-process, navigate an <iframe> to cross site.
  See that resizing the frame works correctly, e.g.:
    document.querySelector('iframe').style.width = '400px';
  Now hide the iframe, and then make it visible:
    document.querySelector('iframe').style.display = 'none';
    document.querySelector('iframe').style.display = '';
  See that resizing the frame still works correctly. It will fail
    without this CL.

Review URL: https://codereview.chromium.org/1309343002

git-svn-id: svn://svn.chromium.org/blink/trunk@201161 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201031

BUG=509025
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/1317683004 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201156 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201026

BUG=509025
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/1314013002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201155 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201138

BUG=521768
TBR=jbroman@chromium.org

Review URL: https://codereview.chromium.org/1316723004 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201154 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201025

BUG=510703
TBR=robhogan@gmail.com

Review URL: https://codereview.chromium.org/1302383003 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201153 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201078

BUG=518816
TBR=miletus@chromium.org

Review URL: https://codereview.chromium.org/1318473004 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201152 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201073

BUG=522826
TBR=kojii@chromium.org

Review URL: https://codereview.chromium.org/1314943003 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201151 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is using the new PermissionsHelper.setPermission() method that
prevents race conditions when trying to use testRunner.setPermission.

BUG=519008

Review URL: https://codereview.chromium.org/1314763003

git-svn-id: svn://svn.chromium.org/blink/trunk@201150 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This test was using removed internal methods and didn't set a minimum page
scale which is now needed for position-fixed elements to correctly get their
percentage based size.

BUG=225184

Review URL: https://codereview.chromium.org/1318543005

git-svn-id: svn://svn.chromium.org/blink/trunk@201149 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=
TBR=brucedawson, eae, leviw

Review URL: https://codereview.chromium.org/1305943004

git-svn-id: svn://svn.chromium.org/blink/trunk@201148 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes a long-standing bug where crashing reftests would not
show some crash logs on the layout tests results page.

single_test_runner.py has an optimization to not run reftests when
the base test crashes. This optimization accidentally failed to write
crash logs (done through write_test_result(...)) as well. This patch
fixes this bug and adds a small test.

Review URL: https://codereview.chromium.org/1312693002

git-svn-id: svn://svn.chromium.org/blink/trunk@201147 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=bungeman@chromium.org
BUG=524623

Review URL: https://codereview.chromium.org/1306993006

git-svn-id: svn://svn.chromium.org/blink/trunk@201146 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ScrollableArea maintained its own special path for wheel handlers. This was
duplicating logic with other scrolls that used ScrollableArea::userScroll and
confusing (why isn't there a handleTouch? handleKey?).

I've removed ScrollableArea::handleWheel and its overrides and moved all the
WheelEvelt -> Scroll Delta logic into EventHandler from where it simply calls
ScrollableArea::userScroll like all other scroll paths.

I also made a slight change to the page step size of ScrollableArea: it's now
87.5% of the visible area *including* scrollbars. This was necessary since on
the root frame, the visible area excluding scrollbars is a somewhat arbitrary
calculation when  pinch-zoomed. While it would be possible to come up with some
scheme or make the step size different for root and non-root frames this would
unnecessarily complicate the code for little gain so I just based it off the
size of the frame rect.

BUG=443724

Review URL: https://codereview.chromium.org/1298973004

git-svn-id: svn://svn.chromium.org/blink/trunk@201145 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=521444

Review URL: https://codereview.chromium.org/1304193004

git-svn-id: svn://svn.chromium.org/blink/trunk@201144 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/1307383002

git-svn-id: svn://svn.chromium.org/blink/trunk@201143 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=524594

git-svn-id: svn://svn.chromium.org/blink/trunk@201142 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Using a method is deemed more readable than having a weirdly named
parameter. The "curve25519dh" value still needs to be passed in as the
first and only argument of the getKey() method.

This CL is part of a three-sided patch:
  [1] This CL.
  [2] https://codereview.chromium.org/1314893002/
  [3] https://codereview.chromium.org/1316693002/

BUG=486040

Review URL: https://codereview.chromium.org/1309723004

git-svn-id: svn://svn.chromium.org/blink/trunk@201141 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SVGLengthContext::resolveRectangle would resolve oBB units as uSOU units
if the "viewport" provided was empty.
This would lead to incorrect rendering in certain cases - like with
filters on content with an empty bbox.

BUG=252696

Review URL: https://codereview.chromium.org/1313893003

git-svn-id: svn://svn.chromium.org/blink/trunk@201140 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The Document call was changed to Frame::securityContext() to make the code more
RemoteFrame-friendly. However, callingWindow is guaranteed local. Revert to
getting the SecurityOrigin via Document.

BUG=524074
TEST=http/tests/security/location-change-from-detached-DOMWindow.html

Review URL: https://codereview.chromium.org/1311253005

git-svn-id: svn://svn.chromium.org/blink/trunk@201139 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This restores some logic removed in https://codereview.chromium.org/1030323005/.
This seems to change some of Blink's behaviour back, and will hopefully resolve issues with unclipped render surfaces.

BUG=521768

Review URL: https://codereview.chromium.org/1300213004

git-svn-id: svn://svn.chromium.org/blink/trunk@201138 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=511311,524505
R=tandrii@chromium.org

Review URL: https://codereview.chromium.org/1317653002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201137 bbb929c8-8fbe-4397-9dbb-9b2b20218538

since builds with these checks have inline capacity disabled.

R=thakis@chromium.org, inferno@chromium.org
TBR=thakis
BUG=524162

Review URL: https://codereview.chromium.org/1309153003 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201136 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is needed as a prerequisite to making "visual viewport scrolls first"
the default. Scrolling the page before setting scale means that the layout
viewport is the only one that could scroll.

BUG=443724

Review URL: https://codereview.chromium.org/1301523006

git-svn-id: svn://svn.chromium.org/blink/trunk@201135 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=phajdan.jr@chromium.org
BUG=511311

Review URL: https://codereview.chromium.org/1303063005

git-svn-id: svn://svn.chromium.org/blink/trunk@201134 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make DOMSelection to use VisibleSelection::toNormalizedEphemeralRange() instead of toNormalizedRange()

This patch changes |DOMSelection| class to use |toNormalizedEphemeralRange()|
in |VisibleSelection| class instead of |toNormalizedRange()| as a preparation
of templatizing |VisibleSelection| to use templatized positions instead of DOM
position to represent range.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1315813002

git-svn-id: svn://svn.chromium.org/blink/trunk@201133 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The HTMLSrcsetParser was using a non-compliant float parser (the one used by
WTFString::charactersToFloat which is in wtf/dtoa/double-conversion).
As a result some tests were failing.
This CL switches it to use the decimal parser in HTMLParserIdioms.

BUG=523159

Review URL: https://codereview.chromium.org/1306743003

git-svn-id: svn://svn.chromium.org/blink/trunk@201132 bbb929c8-8fbe-4397-9dbb-9b2b20218538

They failed because custom scrollbar styles didn't work correctly, which was
fixed in http://crrev.com/1274073002.

BUG=487948

Review URL: https://codereview.chromium.org/1312943002

git-svn-id: svn://svn.chromium.org/blink/trunk@201131 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces composed tree version of |nextVisuallyDistinctCandidate()|
by templatizing function to share algorithm.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=webkit_unit_tests --gtest_filter=EditingUtilitiesTest.NextVisuallyDistinctCandidate

Review URL: https://codereview.chromium.org/1317463002

git-svn-id: svn://svn.chromium.org/blink/trunk@201130 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The specification defines that PushEvents can be initialized with a
data member that is of type PushMessageDataInit, rather than an actual
PushMessageData object. This allows us to remove the constructor from
the PushMessageData object entirely, aligning with the specification.

https://w3c.github.io/push-api/#pushmessagedata-interface

This CL also implements the following pull requests, which defines the
PushMessageDataInit type to also encapsulate ArrayBuffer(View)?.

https://github.com/w3c/push-api/pull/160

Note that the PushMessageData object has not shipped to the world yet.

R=mvanouwerkerk
BUG=

Review URL: https://codereview.chromium.org/1311853002

git-svn-id: svn://svn.chromium.org/blink/trunk@201129 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Stabilized after https://codereview.chromium.org/1286093008

TBR=pdr@chromium.org
BUG=521856

Review URL: https://codereview.chromium.org/1317543002

git-svn-id: svn://svn.chromium.org/blink/trunk@201128 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make EditorCommand to use VisibleSelection::toNormalizedEphemeralRange() instead of toNormalizedRange()

This patch changes |EditorCOmmand| class to use |toNormalizedEphemeralRange()|
in |VisibleSelection| class instead of |toNormalizedRange()| as a preparation
of templatizing |VisibleSelection| to use templatized positions instead of
DOM position to represent range and avoid registering temporary |Range|
object into |Document|.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=388681, 513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1315813003

git-svn-id: svn://svn.chromium.org/blink/trunk@201127 bbb929c8-8fbe-4397-9dbb-9b2b20218538

reset() is called from a number of places with the expectation of
putting the controls into the state they would be if created anew.

One such place is via HTMLMediaElement::preDispatchEventHandler, where
the controls are reset when entering or exiting fullscreen. This has a
very strange side-effect, namely that dispatching a synthetic
webkitfullscreenchange event on a video will cause the media controls to
become visible.

It would be rather messy to write a layout test for this, and it would
be slow to run, so instead add unit tests to test this more directly.

R=fs@opera.com

Review URL: https://codereview.chromium.org/1319433003

git-svn-id: svn://svn.chromium.org/blink/trunk@201126 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A simple follow-up of https://codereview.chromium.org/1306793003/.

BUG=509911
R=haraken@chromium.org, oilpan-reviews@chromium.org, sigbjornf@opera.com

Review URL: https://codereview.chromium.org/1314703003

git-svn-id: svn://svn.chromium.org/blink/trunk@201125 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces composed tree version of |localCaretRectOfPosition()|
by templatizing function to share algorithm.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=webkit_unit_tests --gtest_filter=VisibleUnitsTest.localCaretRectOfPosition

Review URL: https://codereview.chromium.org/1317503002

git-svn-id: svn://svn.chromium.org/blink/trunk@201124 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make WebLocalFrameImpl to use VisibleSelection::toNormalizedEphemeralRange() instead of toNormalizedRange()

This patch changes |WebLocalFrameImpl| class to use |toNormalizedEphemeralRange()|
in |VisibleSelection| class instead of |toNormalizedRange()| as a preparation
of templatizing |VisibleSelection| to use templatized positions instead of
DOM position to represent range.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1313013002

git-svn-id: svn://svn.chromium.org/blink/trunk@201123 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces |firstRangeOf()| function as replacement of |firstRange()|
member function of |VisibleSelection| to prepare templatizing |VisibleSelection|
to exclude DOM tree position specific function out from |VisibleSelection|
for ease of templatizing.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1313883002

git-svn-id: svn://svn.chromium.org/blink/trunk@201122 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make EventHandler to use VisibleSelection::toNormalizedEphemeralRange() instead of toNormalizedRange()

This patch changes |EventHandler| class to use |toNormalizedEphemeralRange()|
in |VisibleSelection| class instead of |toNormalizedRange()| as a preparation
of templatizing |VisibleSelection| to use templatized positions instead of
DOM position to represent range.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1311623004

git-svn-id: svn://svn.chromium.org/blink/trunk@201121 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch changes |WebSubstringUtil| class to use |EphemeralRange| instead
of |Range| object to avoid registering temporary |Range| object into |Document|
for Oilpan friendly.

This patch is also a preparation of making selection to handle granularity for
web component, http://crrev.com/1277863002 to reduce DOM position dependency
from |VisibleSelection| for ease of templatization of |VisibleSelection|.

BUG=388681, 513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1311373002

git-svn-id: svn://svn.chromium.org/blink/trunk@201120 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This method only serves to break the cue layout computed by
SnapToLinesLayouter. If we want to factor in margin+border for cues (and
padding for the cue container), then factor that into the cue layout
algorithm instead.

BUG=301580

Review URL: https://codereview.chromium.org/1314613002

git-svn-id: svn://svn.chromium.org/blink/trunk@201119 bbb929c8-8fbe-4397-9dbb-9b2b20218538