GitLab

The bot shows up on https://ci.chromium.org/p/chromium/g/chromium.memory/console
but not on build.chromium.org while all other bots on chromium.memory are
visible. This seems like an oversight.

Bug: none
Change-Id: I14834f4393a651a883741ecad7563eb978548d3d
Reviewed-on: https://chromium-review.googlesource.com/1166429Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581521}

Previously, the UpgradeDetector notified observers that the "low"
annoyance level had been reached after only one hour for canary and dev
channels (the so-called "unstable" channels). This was to entice users
of such to relaunch earlier than is the case for beta and stable (the
so-called "stable" channels). This is all well and good for the color
changes to the app menu, but is a bit too aggressive when it also
triggers the relaunch recommended bubble or the relaunch required
dialog.

This change makes the relaunch notifications follow the beta and stable
schedule for all channels. This is accomplished by the following
modifications:

- A new "very low" annoyance level has been introduced to the
  UpgradeDetector's "update avisory system". This fires for desktop
  Chrome one hour after an update is detected. It is unused on Chrome
  OS, where the "low" annoyance level is fired the moment an update is
  detected.

- There is no longer any notion of "unstable" channels in the desktop
  implementation of UpgradeDetector (UpgradeDetectorImpl), so "very low"
  is always issued after one hour, and "low" is always issued after two
  days (again, desktop Chrome only; barring use of the
  RelaunchNotificationPeriod policy setting).

- AppMenuIconController now takes care of updating the menu when it
  observes "very low" or "low" based on Chrome's channel.

BUG=869757

Change-Id: I1deef28b3986de239df00fe1e806d4404f28fd11
Reviewed-on: https://chromium-review.googlesource.com/1162162
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581520}

Splitting out the Trusted Web Activity logic to make moving it over to
CustomTabActivity easier.

Bug: 871266
Change-Id: If2c86e74e4f40e4354e5e8a5ef2d7a97566ae462
Reviewed-on: https://chromium-review.googlesource.com/1163716
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581519}

https://android.googlesource.com/platform/external/perfetto.git/+log/b19466d75e3f..692b2b85cb67


git log b19466d75e3f..692b2b85cb67 --date=short --no-merges --format='%ad %ae %s'
2018-08-08 primiano@google.com Merge "perfetto-ui: Fix some issues with sidebar"


Created with:
  gclient setdep -r src/third_party/perfetto@692b2b85cb67

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I08c519be71a83713a6d54d2a50ca967f6b18faf0
Reviewed-on: https://chromium-review.googlesource.com/1166863Reviewed-by: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#581518}

Remove the experiment for overriding UI thread priority, making the new
behavior the default.

The data from UMA[1] shows a (statistically insignificant) 8%
improvement in Event.Latency.ScrollBegin.Touch.TimeToScrollUpdateSwapBegin2
(99%ile) and and an 8% drop in
Startup.Android.Cold.TimeToFirstContentfulPaint.Tabbed (also 99%ile).

BUG=841804

[1] https://uma.googleplex.com/p/chrome/variations/?sid=b286e568c610608d39f5d557480c45c5

Change-Id: I55fe266c0101cf4b120c098e90d08bfde7e158a1
Reviewed-on: https://chromium-review.googlesource.com/1165345Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581517}

After https://crrev.com/580489, the code would access the article in the
list before checking for -1, which would crash if the article had been
removed. As it turns out though, it's simpler to just pass the article
itself, as had been the case before.

Also, add a test for this case.

Bug: 871263
Change-Id: I7c1ee932a2f507d13e0e4cda789019e0516dd6b5
Reviewed-on: https://chromium-review.googlesource.com/1165228Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581516}

XRSession has a collection of V8 callbacks that it will call for
animation frame requests.

These callbacks were detected as unreachable from V8's perspective,
even though XRSession was alive from blink's perspective.

The fix is to make XRSession an ActiveScriptWrappable, so it is a
root object from V8's garbage collection while there are active
callbacks.

In discussion about this bug, it was pointed out that a couple places
we keep objects on the stack might also cause V8's garbage collector
to think wrappers are unreachable, so I now keep those objects alive
with explcit traceable references.

BUG=870403

Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I54cfda8597439c0a988acd918a1fcc6904cca340
Reviewed-on: https://chromium-review.googlesource.com/1166187
Commit-Queue: Bill Orr <billorr@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581515}

https://chromium.googlesource.com/catapult.git/+log/5e7ddfe4f2b2..9aa552b15750


git log 5e7ddfe4f2b2..9aa552b15750 --date=short --no-merges --format='%ad %ae %s'
2018-08-08 digit@google.com dependency_manager: Add doc and unittest for LocalPathInfo


Created with:
  gclient setdep -r src/third_party/catapult@9aa552b15750

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ib1d35c373448275e441e951103c652def63fa663
Reviewed-on: https://chromium-review.googlesource.com/1166862Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#581514}

This reverts commit 0ded0728.

Reason for revert: Added test CrSettingsMultideviceSubpageTest.All
is failing on chromeos-dbg:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg

Original change's description:
> [CrOS MultiDevice]: Add browsertests for subpage
> 
> As the multidevice Settings UI subpage fills up, it will need a few
> browsertests, so this CL is just to set that up so the infrastructure
> is there and to add a couple basic tests for the existing contents.
> 
> Change-Id: Ie628de77d6242c521062a0c7a82ad5cb90a79c1a
> Reviewed-on: https://chromium-review.googlesource.com/1165855
> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
> Reviewed-by: Hector Carmona <hcarmona@chromium.org>
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581445}

TBR=khorimoto@chromium.org,hcarmona@chromium.org,jordynass@chromium.org

Change-Id: I219d3f51752d077701a99d725964c9dac4fcf07e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1166943Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581513}

https://webrtc.googlesource.com/src.git/+log/191f46c5c1ce..c1c8b8e83632


git log 191f46c5c1ce..c1c8b8e83632 --date=short --no-merges --format='%ad %ae %s'
2018-08-08 srte@webrtc.org Adds constexpr create functions for units.
2018-08-08 kwiberg@webrtc.org AudioCodingModuleTest.TestAllCodecs: Create audio encoders the new way


Created with:
  gclient setdep -r src/third_party/webrtc@c1c8b8e83632

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I5982906dcbdd3e496e57dcf1ed5134ac7c9eec8e
Reviewed-on: https://chromium-review.googlesource.com/1166624Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#581512}

For audio processing, we want to connect an output stream to an
audio processing module (as a reference signal for echo cancellation).
Reusing the GroupCoordinator makes sense, so this CL makes the
GroupMember a template parameter.

For an outline of the project this CL is part of, see: https://docs.google.com/document/d/1u4POff_ts_1LE3WDLA_wDDFnUswdlsuHL5DsiTE0a3U/edit?usp=sharing
It's accessible to everyone @chromium.org.

Bug: 851959
Change-Id: I0ef16f5d72199ba4d72321d27b978d8e9b26772f
Reviewed-on: https://chromium-review.googlesource.com/1116542
Commit-Queue: Oskar Sundbom <ossu@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581511}

The popup menus have a bottom inset because of the style of the table
view used. This CL prevents its by adding a dummy footer and settings
the footer height to 0.
This only happened on iOS 10.

Bug: 867782
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia05e0a94f136e1cfaffb9e67bbc1bd09c606a5b2
Reviewed-on: https://chromium-review.googlesource.com/1166905Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581510}

Preferences related to Crostini are removed from the persistent storage
list for incognito mode.
After this CL, if these preferences are changed from incognito mode,
they are only stored in memory and won't affect user profile.

Bug: 861722
Change-Id: I115c8fee12d105ebfe56a177d19d95d8e8106357
Reviewed-on: https://chromium-review.googlesource.com/1166825Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581509}

BUG=801969
R=msarda@chromium.org

Change-Id: Ibfc22ab735f62622286def651ae5df065e59ebc7
Reviewed-on: https://chromium-review.googlesource.com/1163620
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581508}

BUG=797948
R=msarda@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ibf031e86d4e7a9385e01ac872566f63bb4564f9a
Reviewed-on: https://chromium-review.googlesource.com/1163668Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581507}

grey_swipeSlowInDirection() was scrolling too far, and according to the
size of the scrollview, cell was moved out of the screen without being
seen.
It is now replaced with grey_scrollInDirection()
Issue introduced with crrev.com/c/1158404

TBR: sczs
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1d4c198b035ed0ddc0acf58af9638c61bb2d9ab2
Reviewed-on: https://chromium-review.googlesource.com/1166902Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581506}

Preferences related to bookmarks are moved to the incognito persistent
storage list.
This CL does not change the current behavior.

Bug: 861722
Change-Id: I03e11cf0a2bb84872db4b96443b9d1d0db4002f5
Reviewed-on: https://chromium-review.googlesource.com/1166830Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581505}

It turned out that we need type Function defined in Web IDL in
order to correctly implement callback-constructor-related
(custom elements, etc.) and also timer APIs (setTimeout,
setInterval).

This patch supports variadic arguments on callback functions
in order to support Function type.
https://heycam.github.io/webidl/#Function

Change-Id: I435053cd770a36e3e993c5bc789f77dc51829cb8
Bug: chromium:871208
Reviewed-on: https://chromium-review.googlesource.com/1163559
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581504}

This allows the datatype to switch during runtime from regular mode
(persists data to disk if full sync is enabled) to ephemeral/in-memory
mode (experimetal feature for certain whitelisted datatypes).

It is achieved by injecting a second delegate to ModelTypeController,
specialized in the in-memory mode, and backed up by a dedicated
AutofillWebDataService instance.

Bug: 866814
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I4017a1603362b2c4381713f07b4bcb0340584836
Reviewed-on: https://chromium-review.googlesource.com/1160854Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581503}

This heuristic is Chrome only, and wasn't even consistently applied in
all cases, so we should just get rid of it.

Websites that wish to control their referrer should use the widely supported
referrer policy instead.

BUG=859218
R=creis@chromium.org

Change-Id: I8161e3760ed05213f703b9d5117dc1eac64a6786
Reviewed-on: https://chromium-review.googlesource.com/1124329
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581502}

As part of http://crbug.com/871637.

This CL also makes EventTarget::KeepNodeInNode a const function.

Bug: 871637
Change-Id: I490359954c6932239429bf78f7ad949496d73d70
Reviewed-on: https://chromium-review.googlesource.com/1166772Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581501}

This reverts commit 581f1e62.

Reason for revert: Found issue causing initial revert, minor fix required.

Original change's description:
> Revert "[Mac] Bring up the audio service sandbox."
>
> This reverts commit dc7c0730.
>
> Reason for revert: suspected of breakage in 'browser_tests' on Mac: crbug.com/871106
>
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28413
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14761
>
>
> Original change's description:
> > [Mac] Bring up the audio service sandbox.
> >
> > This requires --enable-features=AudioServiceAudioStreams,AudioServiceOutOfProcess,AudioServiceSandbox
> >
> > Bug: 850878
> > Change-Id: I9c759b2537483612f9b3106bdf2ec193b343f198
> > Reviewed-on: https://chromium-review.googlesource.com/1152080
> > Reviewed-by: Greg Kerr <kerrnel@chromium.org>
> > Reviewed-by: Avi Drissman <avi@chromium.org>
> > Commit-Queue: Robert Sesek <rsesek@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#580672}
>
> TBR=avi@chromium.org,kerrnel@chromium.org,rsesek@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 850878,871106
> Change-Id: I022d7308ff4e351a2c657c4d2157bd0e3d8fcd89
> Reviewed-on: https://chromium-review.googlesource.com/1163230
> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580793}

TBR=avi@chromium.org,ksakamoto@chromium.org,kerrnel@chromium.org,rsesek@chromium.org


Bug: 850878, 871106
Change-Id: I88ac82097e8cd0af0bc72c7cac3b90f63dcf633b
Reviewed-on: https://chromium-review.googlesource.com/1164983Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581500}

The OcrLine[1] has no BoundingRect properties, so the result of bounding box
need to be calculated by the words in the current line of text.

[1] https://docs.microsoft.com/en-us/uwp/api/windows.media.ocr.ocrline

BUG=866019

Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win10_chromium_x64_rel_ng
Change-Id: I7bcbd527b55b685f03a8c1783ca8c7bf7b090ee2
Reviewed-on: https://chromium-review.googlesource.com/1156054
Commit-Queue: Junwei Fu <junwei.fu@intel.com>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581499}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/1241c4e94ff3..94ec5e5e83b9


git log 1241c4e94ff3..94ec5e5e83b9 --date=short --no-merges --format='%ad %ae %s'
2018-08-08 dgarrett@google.com cbuildbot-launch-pre-cq: New config tests cbuildbot_launch.
2018-08-08 xixuan@chromium.org cbuildbot: Remove unnecessary seeded logdog steps.


Created with:
  gclient setdep -r src/third_party/chromite@94ec5e5e83b9

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I592312affdb6f286b3d26993cc5accfef4a30961
Reviewed-on: https://chromium-review.googlesource.com/1166623Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#581498}

Visual Viewport API shipped to stable in M61
https://chromium-review.googlesource.com/545160
https://www.chromestatus.com/feature/5737866978131968

BUG=635031

Change-Id: I7cdc96d11e7104573de12c0ad0815003b8604ca3
Reviewed-on: https://chromium-review.googlesource.com/1163224
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581497}

To support more types in ToV8().
This will be needed in defining IDL callback functions
in IDL dictoinaries.


Bug: 867875
Change-Id: Id905ed1143899a3b455b5aca24e376e5ac50739c
Reviewed-on: https://chromium-review.googlesource.com/1166618
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581496}

This CL:
 - fixes CheckRedirectLocation implementation so that we can use it
   from CORSURLLoader.
 - fixes CORS flag handling in ResourceLoader so that it can use
   CheckRedirectLocation,
 - removes WebCORS::HandleRedirect, and has it implemented in
   blink::ResourceLoader instead,
 - integrates CheckRedirectLocation with CORSURLLoader, and
 - removes mojom::CORSError::kRedirectDisallowedScheme in favor of
   mojom::CORSError::kCORSDisabledScheme.

Bug: 736308, 800669, 870173
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ib31ab135b03dcc0beca137cbc39592fe3f314790
Reviewed-on: https://chromium-review.googlesource.com/1158089
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581495}

Overwriting deleted values with cleared values potentially revives
buckets in collections. For atomic garbage collections this is not a
problem as those values are filered out in the visitors already. For
incremental garbage collections the deleted values may be introduced by
erasing a value from a container after it has been visited by the
incremental marker.

This reverts commit 460c4724.

Bug: chromium:870196, chromium:757440
Change-Id: I2d4c173a2dc94b3b8615699f81b85e1b61c4c705
Reviewed-on: https://chromium-review.googlesource.com/1165556Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581494}

As part of http://crbug.com/871637.

Bug: 871637
Change-Id: I70ea6c14a9657d9b80b8a66e9c1e663924408c5a
Reviewed-on: https://chromium-review.googlesource.com/1166748
Commit-Queue: Hayato Ito <hayato@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581493}

https://chromium.googlesource.com/native_client/src/native_client.git/+log/821833667ccc..a87b168e08d3


git log 821833667ccc..a87b168e08d3 --date=short --no-merges --format='%ad %ae %s'
2018-08-08 hinoka@chromium.org Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain""


Created with:
  gclient setdep -r src/native_client@a87b168e08d3

The AutoRoll server is located here: https://nacl-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None
TBR=mseaborn@chromium.org

Change-Id: I26fbc347f694d9b9e658f148dab4908f6cd413aa
Reviewed-on: https://chromium-review.googlesource.com/1166006Reviewed-by: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#581492}

This CL is for cleaning up of previous CL below:
https://chromium-review.googlesource.com/1160069
I added early return with checking ScriptState::ContextIsValid(), but
it should be already checked before calling
V8AbstractEventListener::HandleEvent().
https://cs.chromium.org/chromium/src/third_party/blink/renderer/bindings/core/v8/v8_abstract_event_listener.cc?l=110

Bug: 869778
Change-Id: Ied02ee97f855fdd3c4231188e982b452b78bd06b
Reviewed-on: https://chromium-review.googlesource.com/1166607Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Yuki Yamada <yukiy@google.com>
Cr-Commit-Position: refs/heads/master@{#581491}

This Cl unifies buttons layout in the list, and thus makes keyboard focus
highliting look the same for all buttons.

Bug: 822889
Change-Id: Ic7c1795d72a0f07e5137731874fe4a53e70e729e
Reviewed-on: https://chromium-review.googlesource.com/1166294
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581490}

Following bot results are included.
8668 8675 8678 8680 8682 8691 8694 8696 8700

6 lines were removed and 5 lines were deflaked by consecutive
results since 8657.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ic0d504f68afcbf9196a456354f5ab0fcae6837dc
Reviewed-on: https://chromium-review.googlesource.com/1164810
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581489}

Since document markers are only applied on Text nodes, the functions should accept
only them rather than Node.
This patch only mark them const since they're getter.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1ecca57c53ef6a1e7103d16f60c864f79ba1e64f
Reviewed-on: https://chromium-review.googlesource.com/1159548Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581488}

As part of http://crbug.com/871637.

This CL also touches LocalDOMWindow::{EnqueueWindowEvent, EnqueueDocumentEvent} as necessary.

Bug: 871637
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7c21419c27c4a59b2b4de541e5b2cb9a3001e98a
Reviewed-on: https://chromium-review.googlesource.com/1166616
Commit-Queue: Hayato Ito <hayato@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581487}

CL:1104058 added a focus() call internal to this test helper. No other
testcase in the FilesAppBrowserTest suite has ever needed it, and many
tests use test.util.sync.fakeMouseRightClick already.

Suspecting this additional focus() was a hangover to fix problems with
testcases added in CL:1104058 during development. They got fixed later
when the testcases added the correct remote calls to focus the element
before right-clicking that element, we suppose.

Anyhow, litmus test is removing the focus() call, and then running all
tests --gtest_filter="ContextMenu*" in RELEASE and DEBUG 5 times back-
to-back. Result: no problems, this line of code can away.

Test: browser_test --gtest_filter="ContextMenu/FileApps*"
Bug: 871771
Change-Id: I20577b7cbda0b709b40ff83ec96e8be4838a36bb
Reviewed-on: https://chromium-review.googlesource.com/1166754Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581486}

Revert "win: write a deterministic-ish timestamp into the PE/COFF header instead of the current time"

This reverts commit ef36dc19.

Reason for revert: This turns out to break the official android build, which apparently was relying on a broken aspect of the build that this fixed :(. See https://crbug.com/871173.

Original change's description:
> win: write a deterministic-ish timestamp into the PE/COFF header instead of the current time
>
> We used to set the timestamp to a hash of the binary, similar to
> https://blogs.msdn.microsoft.com/oldnewthing/20180103-00/?p=97705
> However, that caused an appcompat warning on Windows 7 to appear, which
> interpreted the hash as a timestamp. (It's possible that https://llvm.org/PR38429
> could help with that, but my guess it won't have an effect on Windows 7,
> which likely always believes that the the coff timestamp field always stores
> a timestamp).
>
> So currently we write the current time during linking in that field, but that's
> bad for build determinism and that in turn is bad for swarming test result cachability.
>
> build/write_build_date_header.py already creates a deterministic BUILD_DATE
> with several tradeoffs. Cachability wants this to change infrequently, but
> things like HSTS need a "real" build date and want this to change frequently.
> The compromise is: The date changes once per day in official builds, and
> once a month in regular builds.
>
> (We could use /Brepro in ldflags instead of /TIMESTAMP for unofficial builds to get
> the binary hash in the timestamp, but having the header timestamp match the BUILD_DATE
> define seems nice.)
>
> So let's use that same time as timestamp in the PE/COFF header. lld-link has a
> /TIMESTAMP: flag we can use to pass in an explicit timestamp.
>
> Since tools can't have deps, we need to compute the timestamp at gn time,
> so split write_build_date_header.py in two pieces: build/compute_build_timestamp.py
> that just prints the timestamp we want to use, and the old write_build_date_header.py, which
> now takes that timestamp and writes the header file.
>
> Call compute_build_timestamp.py at gn time so that we can pass it in ldflags, and
> pass the resultl to write_build_date_header.py which keeps running as an action
> during build time (so that we at least don't need to write a file at gn time).
>
> An additional wrinkle here is that the PE/COFF timestamp is used as one of just two
> keys per binary for uploading PE binaries to the symbol server, the other being file size.
> https://bugs.llvm.org/show_bug.cgi?id=35914#c0 has a good description of this, and
> tools/symsrc/img_fingerprint.py's GetImgFingerprint() is our implementation of it.
> But since we only upload binaries with symbols for official chrome builds to the symbol server,
> a timestamp that changes once a day should be still enough. (32-bit and 64-bit chromes
> have the same filename, and we might rarely build canary and beta and stable all on the
> same day, but them all being the same size seems highly unlikely.)
>
> Bug: 843199,804926,330260
> Change-Id: I1d4193cc537ae0c4b2d6ac9281fad29de754dd6c
> Reviewed-on: https://chromium-review.googlesource.com/1161104
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Hans Wennborg <hans@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580585}

TBR=thakis@chromium.org,hans@chromium.org,dpranke@chromium.org
NOTRY=true

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 843199, 804926, 330260
Change-Id: Ib93697a82f8a9d3fb303b763609e82e0612887cd
Reviewed-on: https://chromium-review.googlesource.com/1166203
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581485}

In FileSystem API level, the "Audio" media view has a directory structure like
Audio/{Artist}/{Song}.aac. We can't limit the level of recursion up to 1 to
find entries for "Audio".

Actually, a file will not be shown in multiple folders in media view hierarchy,
since no folders will be added in media documents provider.
We don't need to limit the level of recursion.

Bug: 870532
Test: Manually tested on arc-enabled kevin with voice recording app installed.
Change-Id: I1087b9c6e11812025d8456eef8dbec9faeb29cd0
Reviewed-on: https://chromium-review.googlesource.com/1164865
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581484}

Preferences related to Variations are moved to the incognito persistent
storage list.
This CL does not change the current behavior.

Bug: 861722
Change-Id: Iff56f55450639bf95848f3c1c97d7452f2c649a8
Reviewed-on: https://chromium-review.googlesource.com/1159369Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581483}

https://skia.googlesource.com/skia.git/+log/c857956fad09..20714bdf90f3


git log c857956fad09..20714bdf90f3 --date=short --no-merges --format='%ad %ae %s'
2018-08-08 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-08-08 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-08-08 caryclark@skia.org add json dump to pathops unittest
2018-08-08 mtklein@google.com make sksg a component
2018-08-08 reed@google.com use VectorValue consistently
2018-08-08 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-08-08 herb@google.com Remove unused TextPathIter
2018-08-08 liyuqian@google.com Update ShouldUseAAA with our better complexity estimation
2018-08-08 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 1bd4bfb0c2d8..b983a4b28b83 (2 commits)


Created with:
  gclient setdep -r src/third_party/skia@20714bdf90f3

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=djsollen@chromium.org

Change-Id: I0afc1e7551f9b7be84ec7ae7e548f4501a636e9d
Reviewed-on: https://chromium-review.googlesource.com/1166502Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#581482}