GitLab

Revert of Implement '--gpu-sandbox-failures-nonfatal' flag. (https://codereview.chromium.org/189313002/)

Reason for revert:
Looks like this broke Linux ChromiumOS Tests (2):
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/22114

Original issue's description:
> Implement '--gpu-sandbox-failures-nonfatal' flag.
> 
> Also, move the flag to content:: instead of chromeos::.
> 
> BUG=327824
> TEST=Chrome compiles, loads with and without the flag.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255564

TBR=jln@chromium.org,piman@chromium.org,jorgelo@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=327824

Review URL: https://codereview.chromium.org/189093008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255578 0039d316-1c4b-4281-b951-d872f2087c98

The changes involved are straightforward.

BUG=348522,348517
R=vabr@chromium.org

Review URL: https://codereview.chromium.org/190453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255576 0039d316-1c4b-4281-b951-d872f2087c98

This is a mechanical change. No new DEPS are
introduced into src/extensions.

clang_format was also applied to all touched
extensions code, for great justice.

BUG=349930
TBR=wez@chromium.org,yoz@chromium.org,rpaquay@chromium.org,erg@chromium.org for mechanical changes

Review URL: https://codereview.chromium.org/182213005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255575 0039d316-1c4b-4281-b951-d872f2087c98

components_unittests now copies test data files as needed on iOS, and thus
these tests (which use test data files) can now be run on iOS.

R=droger@chromium.org

Review URL: https://codereview.chromium.org/190513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255574 0039d316-1c4b-4281-b951-d872f2087c98

Currently cropping is done for Chrome in libjingle. But as part of project Piranha plant we want to make sure local MediaStreamVideoTracks do not depend on libjingle and that the implementation is on par with what libjingle supports.

This cl creates a new wrapped media::VideoFrame with a changed view_rect when cropping is needed.
When the frame is provided to a PeerConnection via WebRtcVideoCapturerAdapter the frame is copied using
libyuv to a tightly packed frame.

Note that libyuv is already used in libjingle from the render process and is used by Chrome in the browser process.

BUG=334241, 349450

TBR Jam for content_tests.gypi change.

R=joi@chromium.org, mflodman@chromium.org, tommi@chromium.org
TBR=jam

Review URL: https://codereview.chromium.org/183113004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255573 0039d316-1c4b-4281-b951-d872f2087c98

Registering the agent on creation of the adapter object can result
in a race condition where the Bluetooth Daemon isn't running to
respond to the method call yet.

Move the registration to the SetAdapter() call, this covers both
the Bluetooth Daemon actually being running on initial startup and
the case where the daemon restarts.

BUG=346975
TEST=restart bluetoothd; verify agent re-registered

Review URL: https://codereview.chromium.org/188163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255571 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349926
TEST=NONE

Review URL: https://codereview.chromium.org/183973039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255570 0039d316-1c4b-4281-b951-d872f2087c98

Relanding 255326 - Implement MRU for AlternateProtocolMap. Persist only the most recently used 200 entries. In memory keep all the entries.

The following is the revert of revert description:

Revert 255326 "Revert of HttpServerProperties - Implement MRU fo..."

> Revert of HttpServerProperties - Implement MRU for AlternateProtocolMap. Persist (https://codereview.chromium.org/182383016/)
>
> Reason for revert:
> Broke compile on a bunch of bots:
> Chromium Linux Builder (valgrind)
> Chromium OS Builder (valgrind)
> Chromium Windows Builder (DrMemory)
> Linux Builder (TSan v2)
>
> Log:
> http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20Builder%20%28valgrind%29/builds/73182/steps/compile/logs/stdio
>
>
> Original issue's description:
> > HttpServerProperties - Implement MRU for AlternateProtocolMap. Persist
> > only the most recently used 200 entries. In memory keep all the entries.
> >
> > BUG=258189
> >
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255323
>
> TBR=rch@chromium.org,rtenneti@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=258189
>
> Review URL: https://codereview.chromium.org/188663002

TBR=rmistry@chromium.org, rch@chromium.org
BUG=258189

Review URL: https://codereview.chromium.org/180743026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255569 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349673
NOTRY=true

Review URL: https://codereview.chromium.org/189093005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255568 0039d316-1c4b-4281-b951-d872f2087c98

chromite was updated to no longer install chrome.pak in
https://gerrit.chromium.org/gerrit/66855 (Aug 2013) and that version was
into chrome already so it should be good to delete it now.

BUG=52609
TEST=None
R=thakis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/189763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255567 0039d316-1c4b-4281-b951-d872f2087c98

Dispatch ConflictResolutionPolicy setting to correct backend.
Also relay sync_enabled flag to V2 backend on initialization.

BUG=347424
NOTRY=true

Review URL: https://codereview.chromium.org/185063004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255566 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349511

Review URL: https://codereview.chromium.org/183923036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255565 0039d316-1c4b-4281-b951-d872f2087c98

Also, move the flag to content:: instead of chromeos::.

BUG=327824
TEST=Chrome compiles, loads with and without the flag.

Review URL: https://codereview.chromium.org/189313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255564 0039d316-1c4b-4281-b951-d872f2087c98

This is primarily for documentation now, but one could imagine using a more
efficient representation for this known-length string once everywhere is
converted to use the same type name.

Review URL: https://codereview.chromium.org/189123005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255563 0039d316-1c4b-4281-b951-d872f2087c98

BUG=350078

Review URL: https://codereview.chromium.org/189113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255562 0039d316-1c4b-4281-b951-d872f2087c98

This patch is a reland of r254749, fixing a way to set the 'playing' attribute.

BUG=chrome-os-partner:26171
TEST=manually
TBR=hirono@chromium.org

Review URL: https://codereview.chromium.org/182733009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255561 0039d316-1c4b-4281-b951-d872f2087c98

Add wait_until to support href_change and navigate.
Remove previous_action for page_actions.RunAction.
Change page_sets that use wait's href_change and navigate to using wait_until instead.

BUG=349584

Review URL: https://codereview.chromium.org/186593007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255560 0039d316-1c4b-4281-b951-d872f2087c98

Add is_timeline_recording_running to web_contents.
Add is_video_capture_running to tab.

BUG=348271

Review URL: https://codereview.chromium.org/176863005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255559 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141426

Review URL: https://codereview.chromium.org/187813007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255558 0039d316-1c4b-4281-b951-d872f2087c98

This CL removes the SearchResultViewDelegate in favor of more directly
calling the code that was being delegated to. It also removes some
methods from SearchResultListViewDelegate.

This is a pure refactor without any functionality changes.

BUG=None

Review URL: https://codereview.chromium.org/179013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255557 0039d316-1c4b-4281-b951-d872f2087c98

Checking whether texture is acquired by main thread or not in
PendingActivationsShouldBeForced() has no meaning because texture is
always acquired by impl thread in pending state. Instead, this check
should be tested in PendingDrawShouldBeAborted().
Also, additional unittest is added for checking pending activation is
forced when context is lost.

R=brianderson@chromium.org
BUG=347797
TEST=cc_unittests

Review URL: https://codereview.chromium.org/184063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255556 0039d316-1c4b-4281-b951-d872f2087c98

This issue was recently uncovered by the interaction of touch-action:none
when disabling the touch timeout.  In that case, the disable command did not
actually take effect until the following touch sequence (if one was active).
Instead, forcefully disable the timeout/timer for the current touch sequence
when the TouchEventQueue is commanded to do so.

BUG=340060

Review URL: https://codereview.chromium.org/188833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255555 0039d316-1c4b-4281-b951-d872f2087c98

We found that extensions which are sideloaded via the registry or other
methods that had migrated to the webstore were not being verified
because we weren't even asking the verification service about them.

In order to fix this, this CL moves to an approach where we keep a list
of not verified ids as well as verified ones, and if we encounter an id
that isn't "known bad", we make sure to check with the server first
instead of immediately refusing to load it.

In testing this I also noticed and fixed a case where we were attempting
to disable COMPONENT extensions (it isn't currently possible to disable 
them, but that could change someday so it seemed better not to try 
disabling them or adding them to the list of invalid ids). 

BUG=344937

Review URL: https://codereview.chromium.org/189003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255554 0039d316-1c4b-4281-b951-d872f2087c98

Filled in Android implementation for navigator.maxTouchPoints defined
in the W3C Pointer Events standard draft:
http://www.w3.org/TR/pointerevents/#widl-Navigator-maxTouchPoints

BUG=248918

Review URL: https://codereview.chromium.org/186943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255553 0039d316-1c4b-4281-b951-d872f2087c98

The NoBarrier_Load operations don't actually guarantee that the singleton data
associated with the pointer is visible to the thread calling get() even if the
pointer is initialized.

R=mark@chromium.org, dvyukov@chromium.org, epenner@chromium.org

Review URL: https://codereview.chromium.org/188603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255552 0039d316-1c4b-4281-b951-d872f2087c98

BUG=313868

Review URL: https://codereview.chromium.org/183693015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255551 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255550 0039d316-1c4b-4281-b951-d872f2087c98

If finch configuration is not available (chromium builds) then this condition had side effect making enhanced bookmarks about flag not show up.

BUG=321393

Review URL: https://codereview.chromium.org/177693004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255549 0039d316-1c4b-4281-b951-d872f2087c98

681ca6b - Force ffmpegsumo.dll to be optimized for size.

BUG=264459

Review URL: https://codereview.chromium.org/186733010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255548 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349158

Review URL: https://codereview.chromium.org/177423015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255547 0039d316-1c4b-4281-b951-d872f2087c98

Different detection strategies are extracted into individual entities,
which can be switched at run-time. Currently we have only two detection strategies:
* login screen strategy: 3 detection attempts, detection timeout is
  proportional to current attempt number.
* error screen strategy: unlimited number of detection attempts,
  detection timeout is fixed.

BUG=240237
TEST=unit_tests:NetworkPortalDetectorImpl*
R=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/183973029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255545 0039d316-1c4b-4281-b951-d872f2087c98

Consolidate the test support code in InvalidationServiceFactory and
compile FakeInvalidationService and P2PInvalidationService only for
tests.

BUG=chromium:269455
TEST=Compiles and passes tests.
TBR=dcheng@chromium.org

Review URL: https://codereview.chromium.org/183803026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255544 0039d316-1c4b-4281-b951-d872f2087c98

Augment the NaCl GDB mask to avoid blocking the PNaCl
translator in addition to secure shell. Make this the
default.

This has the side-effect of identifying the translator as
separate from the application in chrome's task manager,
since the "url" is changed for these helper NaCl modules
from the application manifest to something
like chrome://pnacl-translator/x86-64/pnacl-llc.nexe.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3765

Review URL: https://codereview.chromium.org/176813010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255543 0039d316-1c4b-4281-b951-d872f2087c98

BUG=348881

Review URL: https://codereview.chromium.org/187703004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255542 0039d316-1c4b-4281-b951-d872f2087c98

The PersonalDataManager unittests are the only ones requiring non-trivial
refactoring.

BUG=303083
R=isherman@chromium.org
TBR=jochen

Review URL: https://codereview.chromium.org/180953004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255541 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255540 0039d316-1c4b-4281-b951-d872f2087c98

Only really need to disable on 32-bit windows, but disable
on all for now. It uses debug stub which does not play
well with sandbox reservation on 32-bit.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3765
TBR=bradnelson@chromium.org

Review URL: https://codereview.chromium.org/189993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255535 0039d316-1c4b-4281-b951-d872f2087c98

These workarounds were added a long time ago before Chrome launched. The Microsoft one isn't needed as the download page has a link to the Mac version without the spoof. The Yahoo Japan download page says it's going away in June and just redirects to Microsoft. The gyao.yahoo.co.jp host doesn't use Silverlight now. promotion.shopping.yahoo.co.jp is dead.

BUG=338338
R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/178263007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255534 0039d316-1c4b-4281-b951-d872f2087c98

. Eliminate the implementation of LayerAnimationObserver. It seems no one expects WED to be a LAO anymore.
. Remove WindowTreeHostDelegate. This involves moving some of the functions to WTH, removing some completely, and moving the remainder to the WED public API. A little icky for now, but I plan to take a pass on cleaning up WED's public API once I get it pared down.
. window_tree_host_x11_unittest provided an implementation of WTHD that was not WED. This is not a valid situation now since various functions in WTH now call directly through to WED. Replaced this with a simple EventHandler to test that events are being dispatched.

R=sky@chromium.org
http://crbug.com/308843

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255368

Review URL: https://codereview.chromium.org/188223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255533 0039d316-1c4b-4281-b951-d872f2087c98

BUG=341662
TEST=none

Review URL: https://codereview.chromium.org/183663027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255532 0039d316-1c4b-4281-b951-d872f2087c98