- 06 Nov, 2018 40 commits
-
-
Arthur Sonzogni authored
What we know about the bug: * URLLoaderClient::OnStartLoadingResponseBody is sent before URLLoaderClient::OnReceiveResponse. * Users have one or more ad blocking extensions. * The NetworkService is enabled. * Websites are loading content inside an iframe that has never navigated. Its URL is still about:blank or javascript:* This CL Instrument WebRequestProxyingUrlLoader. The goal is to confirm this bug is about extensions. Bug: 882661 Change-Id: I1ce33cdb703adb1a854c37f46cafd80a85649388 Reviewed-on: https://chromium-review.googlesource.com/c/1319710 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#605730}
-
Lukasz Suder authored
If there are no details inside parameters nothing is being displayed. Bug: 806868 Change-Id: I50ddbbedbe171fbc4d2af0af5426ac334b877d5d Reviewed-on: https://chromium-review.googlesource.com/c/1319591 Commit-Queue: Lukasz Suder <lsuder@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#605729}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5b640e3d331b..cc7964918f7c git log 5b640e3d331b..cc7964918f7c --date=short --no-merges --format='%ad %ae %s' 2018-11-06 rsavitski@google.com Merge "Reduce verbosity of build tool/dep fetching. Mainly to declutter Kokoro logs." Created with: gclient setdep -r src/third_party/perfetto@cc7964918f7c The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I664b7216a1500d240037e63782680c5aae3b2321 Reviewed-on: https://chromium-review.googlesource.com/c/1319813Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605728}
-
David Quiroz Marin authored
Also adding histogram functions to the allowed list of identifiers for third_party/blink/renderer/ to be able to use those functions instead of the macro versions. Change-Id: I9759c075ce2eff5face0d6c4af9758a64b7e1f68 Reviewed-on: https://chromium-review.googlesource.com/c/1308762 Commit-Queue: David Quiroz Marin <davidqu@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#605727}
-
Josh Karlin authored
This is leftover from previous cleanup work to remove the registration id. This corruption checker checked to make sure that the registration id was valid, but since the id is gone the corruption checker should go as well. Change-Id: I226e2ac388c2163d12ad6dbfe8edb95b3682b7fd Reviewed-on: https://chromium-review.googlesource.com/c/1319690Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#605726}
-
Troy Hildebrandt authored
Adds metrics collection at the LevelDB wrapper level for ProtoDatabase, so any current clients of ProtoDatabase will have new metrics recorded for successes/failures and the error status of various LevelDB operations. To allow gathering metrics on the LevelDB status for failures, the parameters to many of the functions have been modified so we can get the leveldb::Status back in addition to the boolean return value. Bug: 870813 Change-Id: I5d8175dbd4e3b3531532d2f3fc0b33ca155f1336 Reviewed-on: https://chromium-review.googlesource.com/c/1288904Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#605725}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f2cc71e5cbea..398f37a2e0e6 git log f2cc71e5cbea..398f37a2e0e6 --date=short --no-merges --format='%ad %ae %s' 2018-11-06 jajones@nvidia.com Add explicit void parameter in libspirv.h again (#2032) 2018-11-06 jbolz@nvidia.com Enable precompiled headers for spirv-tools(-shared) and some unit tests (#2026) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@398f37a2e0e6 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ibc895ce4295c9dcf50ca7e46872685111f04aa0d Reviewed-on: https://chromium-review.googlesource.com/c/1319814Reviewed-by:
-
Findit authored
This reverts commit d4860fed. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 605719 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2Q0ODYwZmVkZTBlMmRjNjNkNjUwMGY5OGJmZTkxMzkyMTk1OWM3OTUM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/Linux%20ChromiumOS%20Full/109223 Sample Failed Step: compile Original change's description: > Update existing Switch Access tests > > Bug: 897365 > Change-Id: Ic8ff1ea5511f3d6cc907a880fffdffa7c5fdbcc9 > Reviewed-on: https://chromium-review.googlesource.com/c/1306787 > Reviewed-by: David Tseng <dtseng@chromium.org> > Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605719} Change-Id: I582f1a3f539ad62742fd4f39e3b004fbc00b974b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 897365 Reviewed-on: https://chromium-review.googlesource.com/c/1320014 Cr-Commit-Position: refs/heads/master@{#605723}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/00b29398901e..7a305a2ef715 git log 00b29398901e..7a305a2ef715 --date=short --no-merges --format='%ad %ae %s' 2018-11-06 halcanary@google.com Enums: specify base 2018-11-06 kjlubick@google.com Add skia-wasm-release image. 2018-11-06 mtklein@google.com make enum santizer fatal Created with: gclient setdep -r src/third_party/skia@7a305a2ef715 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: Id10dc905ccf14abbc8f0c5a65329d7c3edbe926a Reviewed-on: https://chromium-review.googlesource.com/c/1319811Reviewed-by:
-
Daniel Rubery authored
As part of initial data collection for vision-based phishing protection, it would be useful to know how much users zoom in/out. This CL adds a histogram to track that. Bug: 900743 Change-Id: I649bff7213c12c7f9bc37f7cb5ebb4061e43a66a Reviewed-on: https://chromium-review.googlesource.com/c/1311130 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#605721}
-
Daniel Vogelheim authored
With a default policy defined, assignments implicitly call createXXX on the default policy Added ScriptState* to the accessors visible from JavaScript Tests were updated to check string assignment when trusted-types are needed before and after the default policy is defined Bug: 739170 Change-Id: I9bb841d69f324b841602d41abd71f753a9858af8 Reviewed-on: https://chromium-review.googlesource.com/c/1207530Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#605720}
-
Zach Helfinstein authored
Bug: 897365 Change-Id: Ic8ff1ea5511f3d6cc907a880fffdffa7c5fdbcc9 Reviewed-on: https://chromium-review.googlesource.com/c/1306787Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Cr-Commit-Position: refs/heads/master@{#605719}
-
Ehsan Chiniforooshan authored
tasks_per_frame metrics are added in https://chromium-review.googlesource.com/c/catapult/+/1318249. mean_frame_time metrics are deleted since we already frame_times for display compositor frames and we decided to not use renderer compositor frames in crbug.com/888551. Bug: 890757 Change-Id: Ib4d0b9cedc4f1012873f82da01839b9173d4e6dd Reviewed-on: https://chromium-review.googlesource.com/c/1318395Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#605718}
-
John Lin authored
Bug: 882404 Change-Id: Ib880be036386c007e5bbfa6012ef5712451440ee Reviewed-on: https://chromium-review.googlesource.com/c/1290930Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: John Lin <chuanl@google.com> Cr-Commit-Position: refs/heads/master@{#605717}
-
Marc Treib authored
This currently has no practical effect (the only call site also calls RequestStop anyway), but it prevents ProfileSyncService from getting into an inconsistent state. Bug: 867901 Change-Id: Iaaa72405eac6fb81ee739d2cbeea6ddf52960996 Reviewed-on: https://chromium-review.googlesource.com/c/1319716Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#605716}
-
Mohsen Izadi authored
This reverts commit 8dff7904. Reason for revert: Apparently causes crashes on Windows: http://crbug/ 902279. Original change's description: > Change the order of handling inkdrop and dispatch event. > > InkDrop is handled before View::OnMouseEvent() in OnMouseEvent(). > So, If I want to override the functions associated with InkDrop(ex : CreateInkDropHighlight()), > there is a problem with not getting the something appropriate(ex. Button::STATE) > > Bug: none > Change-Id: I8543a1354197a42478075b941671e5c0e59fc0b7 > Reviewed-on: https://chromium-review.googlesource.com/c/1309561 > Reviewed-by: Mohsen Izadi <mohsen@chromium.org> > Commit-Queue: Mohsen Izadi <mohsen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605254} TBR=tapted@chromium.org,mohsen@chromium.org,sangseok.jang@navercorp.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: none Change-Id: I6ac4f8911c946fd600f74570f4ec3c0e00558297 Reviewed-on: https://chromium-review.googlesource.com/c/1319857Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#605715}
-
Manu Cornet authored
Extend the shelf hover area to the edges of the screen. Bug: 899007 Change-Id: I344e80c9c2272ec70d5c638646bd9d5f0086f87a Reviewed-on: https://chromium-review.googlesource.com/c/1318799Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#605714}
-
Mike Frysinger authored
None of these Python modules are executable (lack main funcs), so it doesn't make sense to have +x perms on them. Bug: 747171 Change-Id: I393d7210f4885dc3db506d94ce50ac736e3fe22e Reviewed-on: https://chromium-review.googlesource.com/c/1319170Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#605713}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/9a227bed7a0f..749d64c35e09 $ git log 9a227bed7..749d64c35 --date=short --no-merges --format='%ad %ae %s' 2018-11-05 junyer Optimise the check for large substrings. 2018-11-05 junyer Fix the check for large substrings. 2018-10-31 junyer Improve the "MATCHING WITH SUBSTRING EXTRACTION" comment. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Bug: 902131 Change-Id: Ic281b472f8c68e64c33d026859ed8e3429c015f5 Reviewed-on: https://chromium-review.googlesource.com/c/1319341Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#605712}
-
Max Moroz authored
Integration fuzzer for appcache, focusing on logical behavior, not parsing. Bug: 888926 Change-Id: I5871940f39d191f0b75fad49952961bd312d8a0b Reviewed-on: https://chromium-review.googlesource.com/c/1302101 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
-
Philip Rogers authored
This change enables PaintTouchActionRects by default. This is a new implementation of how the blink->cc logic works for the css touch-action feature. The big idea behind PaintTouchActionRects is to compute touch-action rects during paint, in paint order, as part of the background paint phase. With this change we expect better performance (primarily a drop in ScrollingCoordinator time: Blink.ScrollingCoordinator.UpdateTime) as well as observable bug fixes (e.g., https://crbug.com/826746). This patch has several small parts: 1) runtime_enabled_features.json5 makes PaintTouchActionRects as stable. 2) The paint-touchaction-rects expectations have been made the default. 3) The paint-touchaction-rects virtual test suite has been removed. 4) 6 tests have been marked as passing (fixed with this feature). Bug: 836905 Change-Id: I2bc12b335e8762eafde882bc475982df7e74a7d1 Reviewed-on: https://chromium-review.googlesource.com/c/1313051Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Xianda Sun <sunxd@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#605710}
-
Kush Sinha authored
Add functionality to fetch auth codes for Secondary Accounts in Chrome OS Account Manager. Design doc and sequence diagrams are linked in the bug id. Bug: 871690 Test: browser_tests --gtest_filter="*Arc*AuthService*Test*" Change-Id: I4c317ccce0d22e1cf55728726cdc8dc55f2a49a1 Reviewed-on: https://chromium-review.googlesource.com/c/1228124 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#605709}
-
Friedrich Horschig authored
For unknown reasons, the filling integration tests are failing on clank bots. The flakiness dashboard [1] shows little to no flakiness on all regular bots. This is one attempt to fix it: ensure the feature is enabled on all integration tests. [1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&testType=chrome_public_test_apk&tests=ManualFillingIntegrationTest Bug: 896210 Change-Id: I2d6c56ab6c59c186ed61777aa9b694bcf640a9fd Reviewed-on: https://chromium-review.googlesource.com/c/1318921Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#605708}
-
Boris Sazonov authored
This CL adds subclasses of AppCompatImageView and AppCompatImageButton to work around an issue when ImageView doesn't invalidate the drawable after the state has changed. This CL also replaces all instances of AppCompatImageView and AppCompatImageButton with newly added ChromeImageView and ChromeImageButton. Bug: 894770 Change-Id: I897e157e44c5eddd9602bd97137e0d1592b11c2b Reviewed-on: https://chromium-review.googlesource.com/c/1310273 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#605707}
-
Artem Titarenko authored
Bug: 901324 Change-Id: Ib7efaefaecc54f72dc1a81559e195b20009fb0c1 Reviewed-on: https://chromium-review.googlesource.com/c/1314591 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#605706}
-
Rayan Kanso authored
The test has been consistently failing for the past few runs. More details in the bug. TBR=bsheedy@chromium.org Bug: 902319 Change-Id: I9dbd161610a7bb3d9010e7b7a0e6fed802c74cc9 Reviewed-on: https://chromium-review.googlesource.com/c/1318920Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#605705}
-
Charlie Harrison authored
Right now popups have a strange relationship with TabSpecificContentSettings. Right now: the infobar is opened if: - A global NOTIFICATION_WEB_CONTENT_SETTINGS_CHANGED is received - !IsBlockageIndicated(POPUPS) in TSCS - There are blocked popups At first glance this seems reasonable. However, popups do not abide by the typical TSCS notion of blockage being indicated. On Android, we create a new infobar for every new popup blocked. On Desktop, these new popups do not trigger another animation of the blocked image. So, TSCS has android specific logic which resets the "indicated" bit every time popups are marked as blocked. This CL simplifies this complex interaction by removing it completely. The PopupBlockerTabHelper is now responsible for the straightforward creation of the infobar. This CL has no (%comment) intended behavior change. Bug: 900645 Change-Id: I440b9b3b6f8d160f1b4d34f8fb7f566dc7dfb72d Reviewed-on: https://chromium-review.googlesource.com/c/1308635 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#605704}
-
Alex Clarke authored
This wasn't previously possible but the timing of the callback was changed by patch https://chromium-review.googlesource.com/c/chromium/src/+/1317629 Bug: 902277 Change-Id: I351872539b4ff2ebcb944a6ea76bd2021249f8ae Reviewed-on: https://chromium-review.googlesource.com/c/1319613Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#605703}
-
Karolina Soltys authored
In preparation for removing MessageLoop, we are making ThreadMain invoke SetTimerSlack on the SequenceManager as well as the MessageLoop. Bug: 891670 Change-Id: I5e4fc8af654a62d543e3965603ee15c206a31d93 Reviewed-on: https://chromium-review.googlesource.com/c/1310433Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Karolina Soltys <ksolt@chromium.org> Cr-Commit-Position: refs/heads/master@{#605702}
-
Dianna Hu authored
This CL lands server change 214662680 by bnc. BUG=488484 Change-Id: I09b53752fb3c49082ace4297a89dc331a9abe457 Reviewed-on: https://chromium-review.googlesource.com/c/1289331 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#605701}
-
Rayan Kanso authored
- testDeepLink - testMainIntent - testSourcePropagated - testTargetShareActivityPreserved More details in the bug. TBR=hanxi@chromium.org Bug: 902325 Change-Id: Id290535e5e067bfa5abda7d86a179e08d4296991 Reviewed-on: https://chromium-review.googlesource.com/c/1319676Reviewed-by:
-
Hans Wennborg authored
The purpose of these asserts is to check that the options structs are aligned sufficiently that an int64_t (or similar) could be added to them. The asserts were added in https://codereview.chromium.org/295383012 However, the alignment of int64_t on 32-bit x86 is actually 4 bytes, not 8. So how did this ever work? Before Clang r345419, the alignof() operator (which is what MOJO_ALIGNOF maps to) would return the *preferred alignment* of a type, not the *ABI alignment*. That's not what the C and C++ standards specify, so the bug was fixed and the asserts started firing. (See also https://llvm.org/pr26547) To fix the build, change the asserts to check that int64_t requires 8 bytes alignment *or less*. Bug: 900406 Change-Id: Icf80cea80ac31082423faab8c192420d0b98d515 Reviewed-on: https://chromium-review.googlesource.com/c/1318971 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e4a55fc6dd08..5b640e3d331b git log e4a55fc6dd08..5b640e3d331b --date=short --no-merges --format='%ad %ae %s' 2018-11-06 lalitm@google.com Merge "trace_processor: fix passing partition column constraints to child tables" Created with: gclient setdep -r src/third_party/perfetto@5b640e3d331b The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ib81eb02c8d8b70b18f743af328b79d48460e1eac Reviewed-on: https://chromium-review.googlesource.com/c/1319386Reviewed-by:
-
Bence Béky authored
This CL lands internal change 219482008 by mpw and 220269504 by bnc. Bug: 488484 Change-Id: Ib007d57d277d0b7c21f10e0c6ce4c9f34c42652d Reviewed-on: https://chromium-review.googlesource.com/c/1318853Reviewed-by:
Dianna Hu <diannahu@chromium.org> Commit-Queue: Dianna Hu <diannahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#605697}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9e6bab3a..5597b278 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I52482cd98a2c3afeee390a001016a74e37ca4c90 Reviewed-on: https://chromium-review.googlesource.com/c/1319633Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605696}
-
Guido Urdaneta authored
This CL sends the chrome::NOTIFICATION_WEB_CONTENT_SETTINGS_CHANGED when a device is removed. This fixes a bug that occurs when a navigation occurs on a tab that is capturing audio or video. In this case, it is possible that the navigation will complete before the device has been completely stopped, and the new page will show an icon with the device capture permission corresponding to the previous page on the omnibar. To remove that icon, it is necessary to let the tab know that content settings might have changed. If the navigation completes after the device stops, the bug does not reproduce because completing the navigation sends the notification about the change in content settings. This bug becomes much more frequent when Site Isolation is enabled. Bug: 896211 Change-Id: I6e9d7197d549b00b458ffc84d155487cb3db2fe6 Reviewed-on: https://chromium-review.googlesource.com/c/1319595Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#605695}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/01ed846cb1db..04f1c7dac0fd Created with: gclient setdep -r src-internal@04f1c7dac0fd The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9bd80081a5698a061b429a936af6e5b639890a88 Reviewed-on: https://chromium-review.googlesource.com/c/1319385Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605694}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e70c6b13dd55..00b29398901e git log e70c6b13dd55..00b29398901e --date=short --no-merges --format='%ad %ae %s' 2018-11-06 brianosman@google.com Remove some more GrColor references Created with: gclient setdep -r src/third_party/skia@00b29398901e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: Iec16d6b8eab8b11499cf79f25958ae69940a4734 Reviewed-on: https://chromium-review.googlesource.com/c/1319809Reviewed-by:
-
Jonathan Metzman authored
TBR=mmoroz@chromium.org Change-Id: Ie786c64a581e76fa5737265bbac195597b01cb0d Reviewed-on: https://chromium-review.googlesource.com/c/1319853Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
-
Sam Maier authored
Bug: 898251 Change-Id: Iaaffb966d4cd3da6563bcc321b7db201b124292c Reviewed-on: https://chromium-review.googlesource.com/c/1312341 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
-
