- 07 Dec, 2020 40 commits
-
-
Norman Rosas authored
and removed duplicated metadata from OWNERS files Bug: 1113033 Change-Id: I641b3ae005ee91e9ae264d516dc24c6ffdbdec16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573337 Commit-Queue: Norman Rosas <normando@google.com> Auto-Submit: Norman Rosas <normando@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#834401}
-
Lily Chen authored
This adds a command-line switch for Android Webview which toggles the CookieManager's cookie access semantics to Non-legacy if the switch is present. The current default is Legacy, which disables SameSite-by-default (SSbD) and Schemeful Same-Site (SSS). With the switch present, SSbD is enabled because it is enabled by default in the content layer. The switch additionally enables the base::Feature for SSS (currently disabled by default), so that it enables both SSbD and SSS ("modern" behavior). This also adds the switch to ProductionSupportedFlagList, so that it can be toggled in the Flags UI. Bug: 986319 Change-Id: I0ba85642cee03bf4284983b6f4c252a24bfd020a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570073Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#834400}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bc7e5ac1c908..bb1a28de3cf1 2020-12-07 alessiob@webrtc.org RNN VAD: unit test code clean-up If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifa1da6d8c64fb6be68d5d90015b712cd920969c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574966Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834399}
-
David Tseng authored
This reverts commit 5fe33cf0. Reason for revert: <INSERT REASONING HERE> Bad rebase; included child change. Original change's description: > Define text_to_speech watchlist > > R=dmazzoni@chromium.org > > Change-Id: Ic8c51de3c4ac96cdcc496842a9a3698a976778e6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577543 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: David Tseng <dtseng@chromium.org> > Auto-Submit: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#834339} TBR=dmazzoni@chromium.org,dtseng@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I1f9f572c24ce842c2f260cc652892cdd81e5c4c7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577879Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#834398}
-
Eugene Zemtsov authored
Change-Id: I80204c76bbf20a57923e5b483e10ea0a054357fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573886Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#834397}
-
Aaron Leventhal authored
Bug: 1155881 Change-Id: Ic4f282073b472f3f8245d2b518f5c76878bc5dee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576418Reviewed-by:
Abigail Klein <abigailbklein@google.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#834396}
-
Elly Fong-Jones authored
It appears to be flaky on cros, windows, and linux, and I think it doesn't run at all on Mac, so disabling it everywhere. Bug: 1148741 Change-Id: Ife041d5685b5d59be422eb6e762e3ceda86d4561 Tbr: liviutinta@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577857Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Liviu Tinta <liviutinta@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#834395}
-
Jeroen Dhollander authored
This CL removes the enable_cros_on_device_assistant GN flag. It is no longer used (once crrev.com/i/3424659 lands). Bug: b/171307059 Test: Compiled Change-Id: Ideae2a69e6359a5f98b973b8e53e8e5f5890f429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554910 Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#834394}
-
Elly Fong-Jones authored
These will be reenabled as part of fixing the linked bug, after the bot has been stabilized. Bug: 1154345 Change-Id: Ic11b6bad895bc5cb361a8b5af66949acbae22b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574782Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#834393}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9f2e7d4d1359..816ffa4d4ef7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ellyjones@google.com,avi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1155832 Tbr: ellyjones@google.com,avi@google.com Change-Id: I04053965764c9534a1bd3ae5c84aafef5b45492d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575775Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834392}
-
Dominique Fauteux-Chapleau authored
This adds a pref to track the scope of the Connector prefs. This is in preparation for code that will read this scope to decide which DM token to use with the corresponding pref. Bug: 1147464 Change-Id: Ib40c92fb9532b66f73e9f50e36e3074fbe376c04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568435 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#834391}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c56ea91f6bd1..e1502e7972cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I502349cc728f26d0ad3c24fc59c02933c351c6d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576632Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834390}
-
Mark Yacoub authored
Test-Modeset with preferred modifiers. If it the test passes, save the preferred modifiers to use for full modeset. If it fails, try testing with linear modifiers for every controller. Use empty modifiers list if the platform doesn't support preferred modifiers list. This enables us to launch Intel Rendering Buffer Compression. http://go/cros-intelrbc BUG=979736,1082882 TEST: RBC enabled on (4K eDP with 4K external) and (4K eDP and 2 external monitors), zork, and nautilus Change-Id: I7698d2cc9f13e5293eb0f6579dee775314988037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567263Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#834389}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/f0a0c38623ed..042184128efe 2020-12-07 senorblanco@chromium.org Widen color state support on ES. 2020-12-07 enga@chromium.org Add SPIR-V support for UseTintGenerator toggle 2020-12-07 enga@chromium.org Produce tint::ast::Module in the frontend if UseTintGenerator 2020-12-07 brandon1.jones@intel.com Fix Emulated OOB Index In Primitive Restart Tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I35154a6626c01839801cb083e143daa154df333a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577582Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834388}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I51bf34cbeea9363eca000b1b733c709f12cb9941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576114Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834387}
-
Tom Anderson authored
* Now that every request is made by XProto, x11::Connection::Request::sequence is no longer needed. Now sequences can be determined by (their index in the queue) + x11::Connection::first_request_id_. * This makes it easier to work with requests out-of-order, which will be necessary for creating property/window caches in the future. * Move some xcb calls from xproto_types.cc into connection.cc. I want to dlopen() libxcb in the future to make it possible to run Chrome on systems without any X11 libraries, so having everything consolidated will make that easier. * Add Future::Wait(). Similar to Sync(), this blocks until a response is received, but instead of returning the response, it calls the installed response handler out-of-order. R=sky Bug: 739898 Change-Id: I10c4c18d3c3090ba09d660a5090fd7c0f01830f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565440 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#834386}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/48b2aad780bf..3efbe10ffd42 2020-12-07 marcinoc@google.com Merge "Fix SQL query to compute frames in SysUI CUJs" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie71cbd65782c1121d4af4dd2c75bc83178ae0e88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577796Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834385}
-
Ionel Popescu authored
Bug: 1148986 Change-Id: I816c94a2e12044fad3d8cef762848420f9652488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565393 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#834384}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1607331580-9909f67f911bba407df7ff9d177d8d5f0f5ef14c.profdata to chrome-win32-master-1607353071-d7cc2aeaf74b32bdf69634e0f6483d7e4b0ffed2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I45e40bb2a53eb9ac7f0ddb0f37640a52eb708e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576623Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834383}
-
Aaron Leventhal authored
Don't walk ancestor chain to check if aria-hidden, unless the cached flag is_inert_or_aria_hidden is already set. Bug: None Change-Id: Idbef78dd4f4735d506b7263564056c9ba48560dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551693 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#834382}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7da2cc8b..5a377bcb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I32abc3a436ec3cac8fa0b583ae1a6a8614a617d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576429Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834381}
-
Jun Mukai authored
Fixed: 1142489 Test: none Change-Id: Ia768ab9f25380744f7050c643e5df9dfe9db9cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576940Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#834380}
-
Jeffrey Kardatzke authored
This was checking <= 31 for a bit shift, and it should be <= 30 since we are shifting 1 that many bits and it's a signed integer. BUG=chromium:1155846 TEST=Fuzzer passes Change-Id: Id70dbe809ba4b63ae91217c67e46d2bfc29f092a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575812 Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#834379}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607341806-af6783e2515ff922f8cbb2f88290f0ca953ce5b4.profdata to chrome-win64-master-1607353071-6048a593794456949e3ffd6a87397fecfdc4317e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0781abdde68b2915bc06610623707543d9d18014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577603Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834378}
-
dpapad authored
Bug: 1148478,1155076 Change-Id: I45421d6e0673d4d56b783f843bb12470c7a47202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570992Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#834377}
-
Javier Fernández García-Boente authored
The following tests are now passing thanks to the fix for the issue https://crbug.com/779105. alignment/grid-self-alignment-non-static-positioned-items-009.html alignment/grid-self-alignment-non-static-positioned-items-010.html alignment/grid-self-alignment-non-static-positioned-items-012.html These tests are still failing in Legacy layout, though, since the above mentioned fix affected only LayoutNG. There are still some failures for one of the tests, but they seem unrelated to the root cause described in the issue 779105. Hence, this test still has some failing expected results: alignment/grid-self-alignment-non-static-positioned-items-011.html I've filed issue 1156225 as root cause of these failures: Bug: 1152497 Change-Id: I2ffa920951fb340418939dae53d2a3b12a9d14c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577222Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#834376}
-
Alex Turner authored
This will expand the number of IdentifiableSurfaces trivially constructible from the FontIndexer's output, namely digests with type kLocalFontLoadPostScriptName and kLocalFontExistenceByUniqueNameOnly. Bug: 1155635 Change-Id: I6b602c808f1c22ed3e14d87e91dfdc5d7c77aae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575004 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#834375}
-
Lan Wei authored
Use testdriver Action API to simulate mouse actions in css/selectors/focus-visible-002.html. Bug: 1145677 Change-Id: Iff8d1700db152b97ab3af61a8f3e75d4ca6053bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548723Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#834374}
-
Elly Fong-Jones authored
This reverts commit 28c5ad9b. Reason for revert: suspect culprit for PrecisionSamplerShadersCompile/PrecisionSamplerShaderPixelTest.ShadersCompile/* failures on linux-tests-dbg: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/93470 Original change's description: > Switch cc_unittests/viz_unittests to SwANGLE > > This cl changes the software backend used for > running viz_unittests and cc_unittests from > SwiftShader GL to SwANGLE (ANGLE on SwiftShader > Vulkan). Other tests suites may be affected. > > From this cl, performance expectations for test > runs will likely change. For example, cc_unittests > appears to run faster, while viz_unittests and > views_unittests appear to run slower. Note that > this is still using the validating command decoder, > and once the OOP Raster tests can run on the > passthrough command decoder, we'll be able to use > it and gain some performance on all these test runs. > > Bug: chromium:1060139 > Change-Id: Ia243f05f3e9f54dc6f6dfaa3041021fc28818b2f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532042 > Commit-Queue: Alexis Hétu <sugoi@chromium.org> > Reviewed-by: weiliangc <weiliangc@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> > Cr-Commit-Position: refs/heads/master@{#834246} TBR=sugoi@chromium.org,kbr@chromium.org,weiliangc@chromium.org,khushalsagar@chromium.org,jonahr@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,sugoi@google.com Change-Id: I815d610741c258a66dc360b2d302d2f663a3bf4c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1060139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577957Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#834373}
-
adoneria authored
Use Mac-11.0 only. Remove Mac-10.16 swarming dimension which does not exist anymore. Bug: 1156252 Change-Id: Ie8e146cfa6f7e3d6e78756d34e1d661e7b1c8564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577759Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#834372}
-
Jae Hoon Kim authored
Bug is fixed and stale logging + TODO lingering. BUG=chromium:851151 Change-Id: I9366d12c40a37fb55fa0c099c1dbf89c3dfb740e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575878Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Cr-Commit-Position: refs/heads/master@{#834371}
-
Adam Langley authored
https://github.com/w3c/webauthn/pull/1530 specifies a method for encoding language and direction information in strings that will be stored on authenticators. Since we may start to see this in credentials in the wild, this change adds examples to the UI test so that we see what they'll look like. (On Linux, at least, they at least don't render as garbage or crash. However the zh-Hant example doesn't display, possibly because I'm missing suitable fonts.) Change-Id: I9e778a08df85b8ae34032341c6bcd84291ff210c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576795 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#834370}
-
Ben Pastene authored
Many of these were disabled during failures while the tests were fixed. And after fixing, they were never re-enabled. So this aggressively re-enables any that are now passing. Bug: 1097630 Bug: 1051059 Bug: 1062289 Bug: 1056163 Bug: 1059426 Bug: 1073084 Bug: 1114654 Bug: 1098810 Bug: 1114752 Bug: 1131304 Bug: 11484015 Change-Id: If3270bdfc4f4516af762ae1d92b3215e4b3cffa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570538 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#834369}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607341806-34092e6e948e6283aae1770f567faca0b14a9512.profdata to chrome-linux-master-1607363880-fd3f1baf2a5dc6b74a86d40eb9ec18d09a3815d8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie02b3d373fcf71ed8e53d217a2c2a5602ba83005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575773Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834368}
-
Moe Ahmadi authored
A previous CL with the same title added trial testing config for Desktop only. This CL adds the same config for Android. Prestable experiment: http://shortn/_ZyDTi78UyT Bug: 1096615 Change-Id: I2fb5b8752b814d70e1ad549f95381e3c9aa17947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575041Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#834367}
-
Moe Ahmadi authored
This reverts commit 3bfb8a37. Reason for revert: crbug.com/1156059 Fixed: 1156059 Original change's description: > [realbox] Makes all text in realbox impossible to select > > crrev.com/c/2566505 made all text in realbox dropdown unselectable. > > This CL extends that to the realbox placeholder as well. Note that > non-placeholder text in the realbox input remains selectable after > this change. > > Fixed: 1154576 > Change-Id: I80d13521680a165c56e2a7d98eff82c885ff3da4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572680 > Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833512} TBR=mahmadi@chromium.org,tiborg@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ic569859f08ba8ee7bc0d82cd4671088f3f4348d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577600Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#834366}
-
Morten Stenshorne authored
We *should* indeed consider moving the code for handling hits outside of atomic inlines, but NGPhysicalBoxFragment::PositionForPoint() isn't the right place for it. If we have an inline-block with a child text node that overflows it, and we hit such overflowing text, we'll perform NGPhysicalBoxFragment::PositionForPoint() directly on the inline block (from HitTestResult::GetPosition()), even if it's the text that we hit. We cannot require that we are within the border box of the inline-block in such cases. This check needs to be performed before entering non-atomic inline children - probably in NGInlineCursor::PositionForPointInChild(). At some point, that code should stop calling LayoutObject::PositionForPoint(), and rather call NGPhysicalBoxFragment::PositionForPoint(). That would be a good time to clean up this. Bug: 1155948 Change-Id: I0391f87d4bbf97c7cdd6a15ab2648aefa2d2abbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577199Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#834365}
-
Chris Thompson authored
The new Sogou hostname supports HTTPS without certificate errors. Bug: 869667 Change-Id: I6e8d9e8149bb995be4d91aae12eeda6dfb4d6ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570118Reviewed-by:
Orin Jaworski <orinj@chromium.org> Commit-Queue: Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#834364}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I57985e0d4c6c14f46583b8d882cf232874a52e04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575600Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#834363}
-
Reid Kleckner authored
The compile step currently takes around 10 hours. We get more value from this bot cycling more quickly than we get from the extra coverage of building all targets. Make this bot build the chromium_builder_asan target instead of `all` to match the Windows ASan bots and the main Mac ASan bot. R=aeubanks@google.com, hans@chromium.org Bug: 1151435 Change-Id: I1b954427126e36f5f83826b259d785bd84c8ff86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555699Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#834362}
-