- 13 Feb, 2020 40 commits
-
-
Jeffrey Kardatzke authored
This fixes a DCHECK that would occur if Initialize failed because then in CreateWithOutputMode it would let the unique_ptr for the image_processor fall out of scope and become deallocated; and we have a sequence checker to ensure deallocation only happens on the task runner. I would have used DeleteSoon, but that didn't seem possible because the destructor was not public. BUG=1050852 TEST=image_processor_test no longer DCHECKs on elm w/ 4.19 kernel Change-Id: Ifae96c3a4206d8e94b7fdd6dd3e2ec571cc3465b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051162Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: J Kardatzke <jkardatzke@chromium.org> Cr-Commit-Position: refs/heads/master@{#741148}
-
David Schinazi authored
The following users no longer work on Chrome Networking: rch@ jri@ ckrasic@ bnc@. Change-Id: If828d3be1200ca6bba367f6a71871b71b7998213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053143 Auto-Submit: David Schinazi <dschinazi@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#741147}
-
John Chen authored
While build for android, ChromeDriver can be built using host toolchain. Bug: 1050709 Change-Id: Ifc7b97f4474e73e3025ec33450bdfd29559ba087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050872Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#741146}
-
Min Qin authored
Chrome cannot open zip files. As a result, directing users to the download Home won't help. This CL will check if Files app are present on the device, and then open the files app if no other apps register as the default handler for zip file. BUG=1050632 Change-Id: I052012113c2d38d52c37088839d75af5b206443d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052570Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#741145}
-
Manu Cornet authored
Change-Id: Idae5f3fec0e8fbcbf1dbff9a3982e0a90b64d900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053249 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#741144}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3bf3b92dfab0..55f040bcb943 git log 3bf3b92dfab0..55f040bcb943 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 egdaniel@google.com Revert "Pass origins through the flushSurfaces calls." 2020-02-13 egdaniel@google.com Pass origins through the flushSurfaces calls. 2020-02-13 reed@google.com check for non-finite values in point3 case Created with: gclient setdep -r src/third_party/skia@55f040bcb943 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1050296 Tbr: stani@google.com Change-Id: Id3408057ca486c9046a2d53507b7b247a5d221ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053300Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741143}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/29cc24586074..503b21fd3203 git log 29cc24586074..503b21fd3203 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 swiftshader.regress@gmail.com Regres: Update test lists @ ac4e1d23 Created with: gclient setdep -r src/third_party/swiftshader@503b21fd3203 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ibb3d955986aad25c1fff1e3d66145f64fff643cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053297Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f63b3f36..7db08fd9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib4745ab6e198fcbe2675f9c77fdba66206593f19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054823Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741141}
-
David Grogan authored
Now it won't fail when it expects LayoutFlexibleBox but sees LayoutNGFlexibleBox Fixes compositing/video/video-poster.html paint/invalidation/video-paint-invalidation.html paint/invalidation/image/canvas-composite-repaint-by-all-imagesource.html virtual/android/fullscreen/video-overlay-scroll.html Bug: 845235 Change-Id: I7cad9787294e8f0b9cf233c769028c1bc571c507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053423Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#741140}
-
Tom Anderson authored
Fixes regression in git status after CL [1]: $ git status On branch master Your branch is up to date with 'origin/master'. Untracked files: (use "git add <file>..." to include in what will be committed) third_party/weston/src/ [1] https://chromium-review.googlesource.com/c/chromium/src/+/1962128 BUG=1029241 TBR=sky NOTRY=true Change-Id: I0ae0c757124edbc267a040935f85d203422fc57e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054273Reviewed-by:Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#741139}
-
Christian Biesinger authored
Make it a longhand and remove the -width/-height/-block-size/-inline-size longhands. Bug: 991096 Change-Id: Id5ef3e8a3d4af157eb4e4e9a702523bb73915397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052330 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#741138}
-
Stephen Chenney authored
TBR: noel@chromium.org Bug: 1034283 Change-Id: Icfc01be5a5c0e8c61dd8878065842fe2127a23b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053928Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#741137}
-
Etienne Bergeron authored
This CL is handling the \r character in RenderText. The sequence "\r\n" is a grapheme and is a processed as a newline by RenderText. Bug: 1050607, 1019061 Change-Id: I161d1e08fe65225f78556b861847dd1b1ee22230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051972 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#741136}
-
Matt Jones authored
Bug: 1052024 TBR: rayankans@chromium.org Change-Id: I27da159c3e85b164997be5fa3e8752f96b5eadda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055004Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#741135}
-
Stephen McGruer authored
TBR=chrisha@chromium.org Bug: 1051006 Change-Id: I4a5b4e1ff1b5a837a75f0895022ed338ee070229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054297Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#741134}
-
Daniel Rubery authored
While the comment says "Must shut down last", there's no clear reason why this would be needed. So move it first to see if there's a subtle reason it should be last. Change-Id: I8e778d100aeeba15d88c22e907cb369787e601e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050677 Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#741133}
-
Avery Musbach authored
When you long press the overview button tray in tablet overview, it shall trigger tablet split view without requiring two overview windows. All/SplitViewControllerTest.LongPressInOverviewMode/? Test: ash_unittests Bug: 1045990 Change-Id: I554ed3bf39387d6e42dbb27fe1bdf91c97da1b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052566Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#741132}
-
Filip Gorski authored
This step follows comment #6 on the bug. It moves the library process type from the constructor and adds it to 2 startup methods. At the same time it renames get() to getInstance(). Bug: 841403 Change-Id: I64495840b917534bca623be70f6b8511ab45e90d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039141Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#741131}
-
Tricia Crichton authored
Enable the collection of minidumps on Windows and Mac instead of only on linux. Bug: 1045241 Change-Id: Ib81420783c02b27d1edef2e575bb1b2369da5846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055003Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#741130}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2eb32c696cc8..3a866d1f61a1 Created with: gclient setdep -r src-internal@3a866d1f61a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1045976 Tbr: jbudorick@google.com Change-Id: I114ffa4e90bd938b157ad05faf9bfdd928529d9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053298Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741129}
-
John Z Wu authored
It will be easier to mock/fake the password controller in unit tests. Bug: 1048256 Change-Id: Icaee411736f3a58ca0978a50762a014775deb032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047488Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#741128}
-
Mugdha Lakhani authored
Change-Id: Ic861b9f8cfaab2270f9e62404f9cf5a36dbf09ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050490 Auto-Submit: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#741127}
-
Lan Wei authored
This is a reland of a4cdec69 I checked it does not change the FullscreenControllerTests tests. Original change's description: > Fix orientation change test full-screen-orientation-change.html > > There are two ways to trigger fullscreen, either by user activation or by > a user generated orientation change. When we enter the fullscreen mode, > we should not consume the user activation in the browser side when the > fullscreen is triggered by a user generated orientation change, so we > need to set the orientation change flag in the browser side when we are > calling the mock function setMockScreenOrientation through a mojo > message. > > The CL that consumes the user activation on both the browser and > renderer sides when entering fullscreen: > https://chromium-review.googlesource.com/c/chromium/src/+/1903675 > > > Bug: 1046933 > Change-Id: I1eb86205bc82ac237bc12d63bbdb0c8985c06090 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026170 > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740812} TBR=kenrb@chromium.org,alexmos@chromium.org,lanwei@chromium.org Bug: 1046933 Change-Id: Ieaa57d457edbfe8b432b02df65eed409f40e63dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054844 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#741126}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/02808dc0a181..465b5e722d31 git log 02808dc0a181..465b5e722d31 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 treehugger-gerrit@google.com Merge "perf sampling: minimal UI for stacks as slice columns" 2020-02-13 hjd@google.com Merge "Fix Mac compile of api_integrationtest.cc" 2020-02-13 fmayer@google.com Merge "Remove stale comment." 2020-02-13 lalitm@google.com Merge "tp: make diff testing script run all tests by default" 2020-02-13 lalitm@google.com Merge "tp: cleanup diff test script in preperation for unified execution" 2020-02-13 ddrone@google.com Add frame_tree_node_id to LatencyInfo.Flow event 2020-02-12 treehugger-gerrit@google.com Merge "processor: Override/extend args correctly when merging" 2020-02-12 treehugger-gerrit@google.com Merge "TrackEvent: Register available categories with service" 2020-02-12 treehugger-gerrit@google.com Merge "UI: update logo and sidebar animation" Created with: gclient setdep -r src/third_party/perfetto@465b5e722d31 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:148777631 Tbr: perfetto-bugs@google.com Change-Id: I60adf3a7482a2df1c8419eb6916812a7bfa6035c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053302Reviewed-by:
-
Liviu Tinta authored
Bug: 1041985 Change-Id: Ib0a7a3fd3485c4c264d8b42a93f8363e961ffa0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052594Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#741124}
-
Xiaocheng Hu authored
The |const CSSParserContext*| parameter in certain functions are never null. Hence, this patch replaces them with |const CSSParserContext&| to avoid confusions. Change-Id: I0cc6e501d954862219ee83c436345e4058a7f8ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053614 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#741123}
-
Dmitry Torokhov authored
This teaches event-rewriter about existence of external Chrome OS branded keyboards. Because current Chrome OS keyboards are indistinguishable from generic external USB/BT keyboards from HID perspective, we rely on UDEV to tag relevant devices with CROS_KEYBOARD_TOP_ROW_LAYOUT property. This allows us to make Search->CapsLock and similar mappings work not only for internal keyboards, but external Chrome OS keyboards as well. OS keyboards. Bug: b/144367328 Test: unit_tests, check that Caps lock remapping affects external Chrome Change-Id: I0b3f932e108b43f7aafe51e155923c4f0b6b5975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051211 Commit-Queue: Dmitry Torokhov <dtor@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#741122}
-
Steven Bennetts authored
Briefly: When a ManagedState entry is added to a list, no initial properties have been received, so these entries are *mostly* ignored. In NetworkTypePattern::Matches(), we have a DCHECK to help ensure that uninitialized states are not used. That means that when we are iterating through a list of networks, we need to avoid calling Matches on ManagedState.type_. This adds a convenience wrapper for places where we need this extra test, and uses it in UpdateManagedList which is currently triggering DCHECKs. TBR=vecore@chromium.org Bug: 1049808 Change-Id: I1a159622adb24b221849e1fa1a98ce89a3357744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050759 Auto-Submit: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#741121}
-
Guido Urdaneta authored
Bug: 1044974 Change-Id: Iac196f6fdd64e487f39668ea63590a14c513dcb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054111 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#741120}
-
Stephen McGruer authored
This reverts commit 8495f49a. Reason for revert: Suspected of causing failure in external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-intrinsic-ratio-003v.html on multiple builders, https://crbug.com/1052029 Original change's description: > [Layout] SetNeedsLayout when an flex-item image loads > > Flex layout incorporates an image's intrinsic size even when it has a > specified height and width. > > Bug: 1042329 > Change-Id: I206ba12a07103b4b90c364fb19b70b8ba2784d7a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050821 > Commit-Queue: David Grogan <dgrogan@chromium.org> > Reviewed-by: Fredrik Söderquist <fs@opera.com> > Cr-Commit-Position: refs/heads/master@{#741091} TBR=dgrogan@chromium.org,fs@opera.com Change-Id: I7dbc00b05f9a14b955f5ac9cd89e3aeda1dbba0f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1042329 Bug: 1052029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054296Reviewed-by:
-
Michael Ludwig authored
Bug: 224618 Change-Id: If7edeef0cc8b7970599388150c6d955171f555ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050665Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Michael Ludwig <michaelludwig@google.com> Cr-Commit-Position: refs/heads/master@{#741118}
-
arthursonzogni authored
It used to be a vector of pair (directive_name, source_list) with no duplicated |directive_name|. This is equivalent to a map<directive_name, source_list>. The main reason it wasn't a map was the ContentSecurityPolicy used to be transmitted using the old Chrome IPC system. It is now using mojo. Mojo support map<K,V>. Using a map slightly simplify the logic, there is no more need to loop through the list of directives for instance. std::map::find is used instead. Description of "future" patches relying on this: ------------------------------------------------ [1] https://crbug.com/888079 Browser process (rather than renderer) should calculate the origin to commit. [2] https://crbug.com/1041376 Compute the sandbox policy of a document before loading it. [1], which is blocked by [2]. [2] requires the CSP sandbox directive to be parsed in the network service before loading the document. The sandbox directive doesn't contain a CSPSourceList, but a SandboxFlag. It means we need to store different kind of "Value" for a directive. This can be achieved by declaring: union DirectiveValue { CSPSourceList source_list; SandboxFlag sandbox_flag }; It could potentially be extended for storing "empty" values for UpgradeInsecureRequest or TreatAsPublicAddress. The map<CSPDirectiveName, CSPSource> will become map<CSPDirectiveName, CSPDirectiveValue>. Then we could get access to the Directive value using: - csp->directives[kSandbox].get_sandbox_flag(); - csp->directives[FrameAncestors].get_source_list(); ------------------------------------------------ Bug 1041376 Change-Id: I63979802b15c55452cc8faf13fdeac4c7c29de86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050278 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#741117}
-
Jeffrey Cohen authored
Bug: 1024586 Change-Id: I5f153b14edfe3265cd6724a082494bd8cbf0d4b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048847Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#741116}
-
Rahul Arakeri authored
This CL fixes an issue where a GSB was getting sent without closing an existing scroll. There were some workarounds in place since a known bug (crbug.com/979408) prevented us from using mouseUpAt. Since that bug is fixed, the API mouseUpAt can now be used to send a GSE. Bug: 979408 Change-Id: I571c714b5612f2190828ad0d0b60f790a832bcbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045213Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#741115}
-
Mikel Astiz authored
IsValidIndex() captures the very same preconditions but calling out the validity of the parent in dedicated DCHECKs helps readability and allows understanding user reports better. Bug: 1051614 Change-Id: If10e53fc52b3f6003dba9f9b2bf386ccf75de3e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054165 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#741114}
-
Xiyuan Xia authored
- ui::WaitForNextFrameToBePresented take a timeout when waiting for frame presentation and return true/false based on whether a frame is presented during the wait; - ResizeHistogram flush pending draws until no presented frames for 100ms like https://crrev.com/c/2036873 before checking resize histograms; - Consolidate https://crrev.com/c/2036873 to use the new ui::WaitForNextFrameToBePresented; - Update ui::WaitForNextFrameToBePresented call sites to examine the returned value; Bug: 1047657 Change-Id: Ifcfa495c8bcddee5ad14b7c52d0107e6b6ed1099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052463Reviewed-by:
-
Xiaocheng Hu authored
This patch ensures a non-null CSSParserContext is passed to ConsumeAngle(), so that we can always count usage of min/max/clamp() in <angle> values. Bug: 1047784 Change-Id: I6839b025f09b1efad5c9968e828c3ea9d0574b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053253Reviewed-by:
-
Dave Tapuska authored
Remove some more typemappings that aren't necessary since gfx types can be used natively in blink. Change-Id: If0e6595f0410b7c696f962f45db4a7d3461a137d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050737 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#741111}
-
Jérôme Lebel authored
Adding implementation for -[AddAccountSigninCoordinator interruptWithAction:completion:], and updating SigninCoordinator to call this method when the sign-in should be canceled. Also, when -[AddAccountSigninCoordinator stop] is called, the following instance variable should be nil: - signinCompletion - identityInteractionManager - userSigninCoordinator - alertCoordinator Those variables should set to nil in -[AddAccountSigninCoordinator runCompletionCallbackWithSigninResult:identity:]. Adding [super stop] and [super start] in start and stop methods of AddAccountSigninCoordinator. Bug: 971989 Change-Id: Icdb209a2edab58bd3bc42472534a7f3d4c7b3299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046529 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#741110}
-
Takuto Ikuta authored
subprocess42 is not used by test_runner.py anymore. Bug: 1050466 Change-Id: Ifd064b362d13c778c59cfd3e3d56939f6fe052c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053750Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#741109}
-
