- 22 Jul, 2019 40 commits
-
-
Bret Sepulveda authored
We've had several bugs where tab groups could become discontinuous and it would be nice if we didn't crash when this happens, so the user can recover. This patch adds a tab reference count to groups, so they are guaranteed to not have any tabs in them when they are deleted, even if the group is not continuous. Bug: 905491 Change-Id: If585e0c5169830280efa09b37402dbd3367359e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709160 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#679566}
-
Roman Sorokin authored
This is a quick fix until implemented a proper one. Bug: 955119 Change-Id: I370fff9c4e3a1ebff8b281185914c4c566583b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713184Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#679565}
-
Jérôme Lebel authored
Replacing SettingsMultilineDetailItem by TableViewImageItem, in order to use the full width of the cell to display the detail text. Bug: 948684 Change-Id: Ia2f6c8ece533b9cce435cbe22dcbc979b0582ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712570Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#679564}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8c404fa14a3d..c6983e98aeef git log 8c404fa14a3d..c6983e98aeef --date=short --no-merges --format='%ad %ae %s' 2019-07-22 lamontjones@chromium.org signing: add OWNERS. Created with: gclient setdep -r src/third_party/chromite@c6983e98aeef The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Id45c0f4851284ec41df8d5089f3a185c381d3466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712797Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679563}
-
Guido Urdaneta authored
Change-Id: I905176d260707e0f103ed3be8e44a4ceb214a9f9 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713166 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#679562}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7c01208e7800..ebab03ffbffb git log 7c01208e7800..ebab03ffbffb --date=short --no-merges --format='%ad %ae %s' 2019-07-22 robertphillips@google.com Add Ganesh support for LUM16F (take 2) Created with: gclient setdep -r src/third_party/skia@ebab03ffbffb The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@google.com Change-Id: I825009fe09f7e6c4fbb250e076d65e5919710cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712799Reviewed-by:
-
Javier Ernesto Flores Robles authored
Creates the gradient programmatically and removes the image since it is not longer needed. Bug: 976671 Change-Id: I0c5960183d52383ae5f2ac8362b0f424968e5808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702002 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#679560}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5578fd9f..6459bca2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I99afc06df2b9ea39d75fc375348ea50e11b4ca61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713144Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679559}
-
Steve Kobes authored
Bug: 957035 Change-Id: Ie0bb37a0795fd13fe2dff8410d854edad5b57219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707649Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#679558}
-
Leonard Grey authored
This is a synthetic estimate displayed to users in Activity Monitor, the battery menu, and top. More info at https://blog.mozilla.org/nnethercote/2015/08/26/what-does-the-os-x-activity-monitors-energy-impact-actually-measure/ Bug: 969105 Change-Id: Ie3438307226c3f9a46459948ea88efb6479de0c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707472 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#679557}
-
Jérôme Lebel authored
Removing useless include from GoogleServicesSettingsMediator. Change-Id: I987c441eac676304629166dc4ff57e8b5351ccc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712569 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
Remove Manual Fallback specific colors and uses semantic colors. Bug: 976671 Change-Id: Ie96cac51c86c3d4f3bd508124eed558eba5745b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698539 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#679555}
-
kylechar authored
The non-associated version of this message pipe was only used by mash and that no longer exists, so delete the unused code. viz::Service can be deleted as a follow up. Bug: 938947 Change-Id: I1cd5f6bf82713887f7d614da82eaadd6ef3677b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710719Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#679554}
-
Austin Eng authored
This patch also updates the WebGPU implementation in Chrome to match Dawn API changes. https://dawn.googlesource.com/dawn.git/+log/49aae0f3bde2..c0b8132f5547 git log 49aae0f3bde2..c0b8132f5547 --date=short --no-merges --format='%ad %ae %s' 2019-07-19 yunchao.he@intel.com Implement RenderPassEncoder::SetViewport: impl on backends 2019-07-19 senorblanco@chromium.org Add some missing #includes. 2019-07-19 cwallez@chromium.org dawn.json: Removed unused "face" bitmask 2019-07-19 enga@chromium.org Add wire tests and mocks for the MemoryTransferService 2019-07-19 enga@chromium.org Add MemoryTransfer interfaces to the wire Created with: gclient setdep -r src/third_party/dawn@c0b8132f5547 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@chromium.org Change-Id: Id71009e931970ab92ce65746db2c7af69e39719c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711009Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#679553}
-
Yi Gu authored
This test is flaky due to crrev.com/c/1704389. Currently there is only one occurance on Win7 so just mark it flaky on Linux for now. See https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVySQsSBUZsYWtlIj5jaHJvbWl1bUBibGlua193ZWJfdGVzdHNfZXhwYXJjaGl2ZUBhbmltYXRpb25zL3BsYXktc3RhdGUuaHRtbAw TBR=flackr@chromium.org NOTRY=true Bug: 986019 Change-Id: I637b1f43393cb9d1edd04684b9ac400b16fe348a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712055Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#679552}
-
Dominic Farolino authored
PreloadHelper::LoadLinksFromHeader is currently the only time we consider loading link headers, so in order to count how many of these link headers are not rel=preload, but rel=stylesheet, this seems to be the best place to perform a count. Bug: 19237 Change-Id: I1c5cb5eb2200875a56714484f40e955b27d13746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710505Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#679551}
-
Guillaume Jenkins authored
Adds two telemetry points in preparation for the Windows OS spellchecker integration: - Missing language packs: Counts how many spellcheck locales are currently enabled by the user but are not supported by the Windows OS spellchecker because the user didn't install a language pack for them. This will help us determine the importance of adding logic to fallback to the current spellchecker when we transition to the new one. - Languages unsupported by Hunspell: Counts how many languages are currently added to Chrome by the user but are not eligible for spellchecking because we have no Hunspell dictionaries for them. This will help us determine the current gap in our spellcheck support and measure the impact the OS spellchecker integration would have. Explanation of the changes: - spellcheck_service.cc is the entry point for initializing the spellchecker in the browser process. Added telemetry for the above metrics to the initialization. Also added them to the pref change handlers when the languages and spellcheck languages change. - spellcheck_platform.h is the interface to the native spellchecker of the different platforms. Verifying language packs support must be done through system APIs via the Windows native spellchecker object, so added a Windows-only declaration there. - spellcheck_platform_win.cc is the Windows implementation of the spellcheck_platform interface. It also contains the wrapper class for the native spellchecker object. Added the new telemetry function there, which simply forwards the call to the native spellchecker object. - WindowsSpellChecker is the wrapper class for the native spellchecker. All Windows API calls must be done on the background thread. Added a WindowsSpellChecker method that checks per-language availability on the background thread and records the result via the spellcheck telemetry helper object. Bug: 463364 Change-Id: Ic8730b3e6b97898ea795fdba253f71b1b5f8ca81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706574Reviewed-by:Lei Zhang <thestig@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#679550}
-
Takashi Toyoshima authored
This patch plumbs BundledExchanges information for navigation, and loading. With this patch, Chrome can recognize a given BundledExchanges file by specifying following command line flags. ./out/Release/chrome --user-data-dir=<test_profile_path> \ --trustable-bundled-exchanges-file=<file_abs_path> file://<file_abs_path> BundledExchangesFactory is now empty, and follow-up patches will implement it to make the navigation work. Bug: 966753 Change-Id: I22fd0f1eb4cbbf8e8509694ee3dd00279ff7acc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690635Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#679549}
-
Cammie Smith Barnes authored
When there is no network service, we disable the PlzDedicatedWorker flavor of the following tests in *WebContentsSplitCacheBrowserTestEnabled* because network service is required in order to enable PlzDedicatedWorker. Bug: 983981 Change-Id: Ie2af5f7671855c2a7e4f2b7c336b07af44ee6a35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710705 Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#679548}
-
Yi Gu authored
The test has been flaky recently. Suspecting crrev.com/c/1686728. See bug for details. TBR=rsesek@chromium.org TBR=mark@chromium.org Bug: 986288 Change-Id: I6ddcf1b675871db30e786c0e152debe1a8fdd786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712048Reviewed-by:
-
Robbie Gibson authored
On iOS 13, we can achieve this by using the overrideUserInterfaceStyle property to force the toolbars into dark styling. Then, all the UI elements can be the same UIColor in both modes (because that color is dynamic). This does not fix the problem for iOS 12, which will come in a later CL. Bug: 976643 Change-Id: I76eb50f6484f7ac9a846fb8cb50e5ffc46c0f8a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709322Reviewed-by:
-
Javier Ernesto Flores Robles authored
Bug: 976671 Change-Id: Ib7d0255bb5a21ca3ee3e1109d6a9bbf83dc9687d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700204Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/39483c66626c..6982f6091b5c git log 39483c66626c..6982f6091b5c --date=short --no-merges --format='%ad %ae %s' 2019-07-22 mbonadei@webrtc.org Remove empty OWNERS file. Created with: gclient setdep -r src/third_party/webrtc@6982f6091b5c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I29512036676dd1358feade7a82f1f50c42088c15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713027Reviewed-by:
-
David Benjamin authored
Also a MockSSLConfigService can be replaced with SSLConfigServiceDefaults. Trim some of the easy bits away from another humongous CL. TBR: alph@chromium.org Change-Id: Ib9e107b9f1709e9864ea32158a1ff3d3e0c595e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709169 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#679543}
-
Tanisha Mandre authored
The delete button now appears only while in edit mode. Bug: 984567, 984933 Change-Id: I8ce137f03ac43a4a5289d895863cbd122b1eb75f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704104 Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Jit Yao Yap authored
Sync server-side changes from https://critique.corp.google.com/#review/257650935 to client. Change-Id: If2e6077cc9087724ce800089fc2f5db342e7c5ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702412Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#679541}
-
Yi Gu authored
The three tests are slow on Win10 as well. See https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyawsSBUZsYWtlImBjaHJvbWl1bUBibGlua193ZWJfdGVzdHNfZXhwYXJjaGl2ZUBmYXN0L2NhbnZhcy9jb2xvci1zcGFjZS9jYW52YXMtY3JlYXRlSW1hZ2VCaXRtYXAtZV9zcmdiLmh0bWwM TBR=juanmihd@chromium.org Bug:983642 Change-Id: I55feb35f13ed1af9237aa2d8fe712137d20582d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713028Reviewed-by:
-
Jessica Tallon authored
Currently AtkObject are often created before the ax::mojom::Role and other information is available or stable. This causes the AtkObjects to be repeatidly remade causing issues to screen readers on Linux. A number of things have been done to address the issue: 1. AtkObjects are now only created if the ax::mojom::Role information is known at Init, otherwise it's deferred until after the tree is stable. For non-UI changes this will come by AXPlatformNodeAuraLinux::DataChanged being called on each created/updated node once the update has finished. 2. We no longer call DataChanged (which checks if the AtkObject needs recreating) during a tree update which lead to objects being recreated several times during a single update (often erroneously). These changes will reduce spamming from chromium to ATK screen readers and prevent some of the dead event issues. Bug: 959650 Change-Id: I4e735e6ec62db60ebcca37a13d80951d47c5086b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670882Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Jessica Tallon <jtallon@igalia.com> Cr-Commit-Position: refs/heads/master@{#679539}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/9f2236e58ed0..2bb2da919352 git log 9f2236e58ed0..2bb2da919352 --date=short --no-merges --format='%ad %ae %s' 2019-07-22 cepheus@frii.com SPV: Update to latest SPIR-V header. 2019-07-22 johnkslang@users.noreply.github.com Merge pull request #1845 from greg-lunarg/kg105 Created with: gclient setdep -r src/third_party/glslang/src@2bb2da919352 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,jmadill@chromium.org,jmadill@google.com Change-Id: Ifb591547d656b5c67dfb0d06bc3dd04405bcd9ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713026Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a36fb7e37cd7..459dcc9bf2b3 git log a36fb7e37cd7..459dcc9bf2b3 --date=short --no-merges --format='%ad %ae %s' 2019-07-22 hjd@google.com Merge "trace_to_text: Handle unusual control characters" Created with: gclient setdep -r src/third_party/perfetto@459dcc9bf2b3 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I699714d75616fd121e62cef0b0754641f326ebc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713029Reviewed-by:
-
Vadym Doroshenko authored
Bug: 986091 Change-Id: I3d1542d1dfc361f46a7870ec05410bc4660c2deb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712672Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#679536}
-
Benoît Lizé authored
This is partially a revert of two commits: - 53a10113: "Delete unused file: base/android/linker/android_dlext.h" - fdb31883: "Use the LegacyLinker instead of the ModernLinker" ModernLinker has been reworked, especially the native side. Notable changes: - The library is only loaded once, not twice in the browser process - Relocations are always shared between the browser process and the other ones. This is enabled only on N+ for Chrome.apk, neither for Monochrome nor for TriChrome. on Q, further commit will trim it as well. Binary-Size: Increase due to bringing back ModernLinker. Required to save memory Bug: 979638 Change-Id: Ia76773b58a71854a36ea49ab82daef1af717b606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683245Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#679535}
-
Yi Gu authored
The test is flaky due to some unexpected passes. See bug for details. TBR=yoavweiss@chromium.org NOTRY=true Bug: 986282 Change-Id: If8472002fb084d1e6d78d4e7f758077ac0e7aba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712046Reviewed-by:
-
Antonio Gomes authored
... prior to Onion souping some of the files on these directories. This is important so that we do not whitelist (via DEPS) needless header inclusions in Blink. BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I43375af80f0997e1e0a2e03832c7cd445af7d5a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713044 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#679533}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cfa31022..5578fd9f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibc64cfaa371fb0c9262b685068f952f58c309cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712944Reviewed-by:
-
Yi Gu authored
[Sheriff] Mark test virtual/threaded/animations/web-animations/animation-state-changes-positive-playback-rate.html flaky The fast path test started to be flaky as well. See https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyfAsSBUZsYWtlInFjaHJvbWl1bUBibGlua193ZWJfdGVzdHNfZXhwYXJjaGl2ZUBhbmltYXRpb25zL3dlYi1hbmltYXRpb25zL2FuaW1hdGlvbi1zdGF0ZS1jaGFuZ2VzLXBvc2l0aXZlLXBsYXliYWNrLXJhdGUuaHRtbAw TBR=flackr@chromium.org NOTRY=true Bug: 986019 Change-Id: I81933b76cb2d5f0255427cf8b01c19e2442074d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712514Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ec3580361e62..39483c66626c git log ec3580361e62..39483c66626c --date=short --no-merges --format='%ad %ae %s' 2019-07-22 titovartem@webrtc.org Migrate some Vp8 simulcast and screen share tests on PC framework Created with: gclient setdep -r src/third_party/webrtc@39483c66626c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I112c92ee2ec291f10383af9b61cd6076c9355921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712904Reviewed-by:
-
Yi Gu authored
Test started to be flaky on Mac as well. TBR=majidvp@chromium.org NOTRY=true Bug: 986018 Change-Id: Ic896095e10af871eb7734f3730cfc58317475890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712513Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I7f3490de0fdb1d5ca7cd7d3cff15a8252b7253ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712377Reviewed-by:
-
Edvard Thörnros authored
One argument passed wasn't used in the body of the function, it was thus removed. This change is only a refactor commit and shouldn't change any functionality. Bug: 981522 Change-Id: Ib8a8274c44d32bc1e50f0f6541c58b288dd77b59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710651 Auto-Submit: Edvard Thörnros <edvardt@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#679527}
-
