- 29 Oct, 2019 40 commits
-
-
Abhijeet Kandalkar authored
Type casting related functions like IsHTMLXXXXElement, ToHTMLXXXXElement, and ToHTMLXXXXElementOrNull are being phased out in favor of new downcast helpers in t_p/blink/renderer/platform/casting.h. There is still a long run to fully remove old type casting mechanism, but this CL aims at preventing new uses to take place. Bug: 891908 Change-Id: I6a079b9524d2e94805528bdcf17baaa66fe091da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879628Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#710345}
-
Javier Ernesto Flores Robles authored
Bug: 1017175, 1016367 Change-Id: I0c12c811c347a5f7981ea2985e550aad72167860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886860 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#710344}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0877b946198e..0668f3ddd97f git log 0877b946198e..0668f3ddd97f --date=short --no-merges --format='%ad %ae %s' 2019-10-29 primiano@google.com Merge changes I0d2677c1,If1a8bfcd Created with: gclient setdep -r src/third_party/perfetto@0668f3ddd97f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I605d047538448d7d6eab504200b7c5e5b417c9a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886358Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710343}
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/70f122128c..a2ca5d5c44 TBR=aerotwist@chromium.org Change-Id: I1dace02c1820a41d95e4cda22451126dbd82301d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886678Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#710342}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2c887d9d2df6..b6a2156a1346 Created with: gclient setdep -r src-internal@b6a2156a1346 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I660ba07b9aeca2346538687ee4f661738dc8e9f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886362Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710341}
-
Anna Malova authored
Android side: https://android-review.googlesource.com/c/platform/frameworks/support/+/1138298 Bug: 1012753 Change-Id: I6cc6e045fad9044f72cda7f751390abb39fea94a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848701Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#710340}
-
Andrew Xu authored
As requested by UX team, disable the ink drop effect of the scrollable shelf's arrow button by this CL. Bug: 1019012 Change-Id: I6a7224911cafb70167d4f152b53b93fdd3fa6004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885500 Auto-Submit: Andrew Xu <andrewxu@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#710339}
-
Javier Ernesto Flores Robles authored
Screenshots: https://drive.google.com/open?id=1FtWB0KqauDTnX-PicF1aMets092Jo2rj https://drive.google.com/file/d/1Scn70Xe29D4rno6OmMkif1N64XlswnPR https://drive.google.com/file/d/1mQunVKqxB63hxet8WdmP3BSTLrMsV0Nu Bug: 1014660 Change-Id: I5ea1e7fbb486d49303fbfdf0db995c1792374f4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882322 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#710338}
-
kylechar authored
This is a precursor to adding a new scoped_refptr(std::nullptr_t) constructor. The implicit conversion from NULL to scoped_refptr<T> causes a compilation error with the new constructor. Replace NULL with nullptr in any files where this is a problem. This CL was uploaded by git cl split. R=liberato@chromium.org Bug: 1018887 Change-Id: I589a654b9f76a8e066533ea789fdd9c6f7bb3c14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885079 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#710337}
-
Yang Guo authored
This reverts commit 6089b211. Reason for revert: Failure here: https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/4085 I'm half assuming that this test is a bit flaky? Original change's description: > [devtools] Allow reloading of extension with devtools > > This patches restricts the changes from [1] to pdf embeds. > > [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1659983 > > Bug: chromium:997521 > Change-Id: I8a94c9c1eecf132388508ceed47b426f2c842ed0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798350 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Commit-Queue: Jan Scheffler <janscheffler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708538} TBR=yangguo@chromium.org,wjmaclean@chromium.org,luoe@chromium.org,janscheffler@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:997521 Change-Id: I79849fb39d89d84c4e7a5a9eb72494da13bf5119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886817Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#710336}
-
Mustaq Ahmed authored
With UAv2 shipped, token based user activation state maintenance through a UGI is redundant except for a dependency from extension messaging. Unfortunately we can't remove that dependency right away because of compat implications (crbug.com/957633). For now, we will trim down UGI to a minimal class to prevent new usage as much as possible. This CL trims down UGI to support barebone token functionalities. Bug: 959850 TBR: haraken@chromium.org Change-Id: Ifef73e338cff2f07273bc0faf5208eaa172fcb87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872152 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#710335}
-
Eric Stevenson authored
Previously would fail if another annotation came after @NativeMethods. Bug: 1018296 Change-Id: Id80385d0a0ad0594134d5e04d87f28f9efd77888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885017 Auto-Submit: Eric Stevenson <estevenson@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#710334}
-
Yuki Shiino authored
This patch is exploring how we can implement V8 callback functions in the new bindings generator. Attempts to implement the following utilities: - make_v8_to_blink_value - bind_blink_api_arguments - bind_blink_api_call - bind_return_value - bind_v8_set_return_value Bug: 839389 Change-Id: Ie949eca6119806611125fc4e8265601a6888e52b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880904Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#710333}
-
Mark Cogan authored
This is the final of five CLs breaking crrev.com/c/1860025 into smaller chunks. This CL updates the classes in ui/authentication to accept a Browser instead of a BrowserState, and updates their callers, who at this point all are created with Browsers to pass in. The workarounds in the parent CL are removed, and now all of the inits for SettingsNavigationController use Browser. Bug: 1018746 Change-Id: Iaa6b20279daa64d377730c74c29b14f25c9d1404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883724 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#710332}
-
Mustaq Ahmed authored
With UAv2 shipped, token based user activation state maintenance through a UGI is redundant except for a dependency from extension messaging. Unfortunately we can't remove that dependency right away because of compat implications. For now, we will trim down UGI to a minimal class to prevent new usage as much as possible. This CL removes UGI's token status as part of the cleanup. Bug: 959850 Change-Id: I9b3858b85cf980d879124ed49b18c67b4ec9a566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869118 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#710331}
-
Mikhail Khokhlov authored
Failures during the processing of test results should be marked unexpected. Bug: 1019137 Change-Id: Ib3b880a462a038ea98fc8c56e3ec815ba613ec93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886894 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#710330}
-
Peter Kasting authored
Bug: 82078 Change-Id: Iba91aaf15643c3a3ca9ebbfc930bec634b6eda14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886170 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#710329}
-
kylechar authored
This is a precursor to adding a new scoped_refptr(std::nullptr_t) constructor. The implicit conversion from NULL to scoped_refptr<T> causes a compilation error with the new constructor. Replace NULL with nullptr in any files where this is a problem. This CL was uploaded by git cl split. R=reillyg@chromium.org Bug: 1018887 Change-Id: Id52b62e25cd452a6558c2660c72e1c8d501da2cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884520 Commit-Queue: kylechar <kylechar@chromium.org> Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#710328}
-
Yi Su authored
The feature "Article suggestion UI tweaks - Chrome iOS" has been shipped in M77. The feature flag can be removed now. Bug: 979143 Change-Id: I1be8aaae408236d4141dc61c214b11eba94292aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886613 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#710327}
-
Francois Doray authored
This is a reland of https://crrev.com/c/chromium/src/+/1865405 The difference is that we don't check thread priority in angle_unittest, as these tests change the thread priority on purpose. This CL verifies that the thread priority is normal when a test process is launched and before/after each test. The goal is to avoid having tests that assume they run at normal priority be disabled because of other misbehaving tests (e.g. https://crbug.com/931706). TBR=sky@chromium.org,michaelpg@chromium.org,thakis@chromium.org,eseckler@chromium.org Bug: 931706 Change-Id: I8fb2230cbb9b9203884d1c440696d4ce2968dcaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881707Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#710326}
-
Henrique Nakashima authored
Bug: 1017800 Change-Id: I4dca71596582c6a29c515a035aa507df179331af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885072Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#710325}
-
Mark Cogan authored
This is the fourth CL of several breaking crrev.com/c/1860025 into smaller chunks. This updates SigninInteractionController and Coordinator to accept a Browser instead of a BrowserState. This necessitates updating a few other classes (AccountsTableViewController, GoogleServicesSettingsCoordinator), and, more significantly, SettingsNavigationController. With this CL, SettingsNavigationController is initialized with a Browser instead of a BrowserState, so it can initialize AccountsTableViewController instances. Unfortunately, there is one init path for SettingsNavController that can't yet be updated to use Browser -- the import data controller class init is called from inside AuthenticationFlowPerformer, which is further down in the stack of classes that Browser is being plumbed into. As a temporary measure, internally SettingsNavigationController keeps an initializer that accepts a BrowserState; calling it (which is only done from the import data class init) will create a controller with a nullptr Browser property. If this controller attempts to create an AccountsTableVC, it will DCHECK(). This is rectified in crrev.com/c/1883724 Bug: 1018746 Change-Id: I58e82b6f2cd501d2ac90d48b4545b0eb6c836fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883519Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#710324}
-
Francois Doray authored
As described in https://docs.google.com/document/d/1va_h2uei_-H-AjXMSxdSOat2vkwD4FKREn_CK-wRZes/edit?usp=sharing, clearing the cache in Lighthouse can be slow. This CL fixes the problem by increasing the priority of the WebRtcEventLogManager TaskRunner to USER_BLOCKING when the cache is being cleared. This is the correct priority for an operation on which the user is waiting. Change-Id: If5aea24d2388dd67ecbaead8255886905202daba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882029Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#710323}
-
Henrique Ferreiro authored
Bug: 919392 Change-Id: If8fae8e3045e22ef2aaae47a31203fb5df9c8367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886674Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#710322}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/620154a7dc5c..d4b95d213d6f git log 620154a7dc5c..d4b95d213d6f --date=short --no-merges --format='%ad %ae %s' 2019-10-29 robertphillips@google.com Revert "Implement refPinnedTextureProxy for SkImage_Lazy." 2019-10-29 jcgregorio@google.com Revert "Make GrFillInData use SkRasterPipeline" 2019-10-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 1737a30e3e34..f8f6103eb89f (2 commits) 2019-10-29 fmalita@chromium.org [skottie] Fix layer blend modes under mattes 2019-10-28 fmalita@chromium.org [skottie] Fix skottie2movie after async API change 2019-10-28 herb@google.com Small cleanups 2019-10-28 herb@google.com Inline fallback code 2019-10-28 herb@google.com Only send needed glyph images 2019-10-28 michaelludwig@google.com Blacklist bulkrect benchmarks on chorizo 2019-10-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 8e28e18b5c9e..b118cb0ef477 (1 commits) 2019-10-28 fmalita@chromium.org [skottie] 3D layer parenting refinements 2019-10-28 jvanverth@google.com Implement refPinnedTextureProxy for SkImage_Lazy. 2019-10-28 brianosman@google.com Guard against integer overflow when classifying transfer functions Created with: gclient setdep -r src/third_party/skia@d4b95d213d6f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: chromium:None,chromium:None,chromium:1016183 Change-Id: Ibc0da837c3fdb2ff09a4af3bccd4e6d371fdf300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886357Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710321}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I6ae156036f34b750c20eddcfc2c4a7d8c172075e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886354Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710320}
-
Clemens Arbesser authored
There are two benefits: First, we want to move all logic from Java to native anyway. Second, we are about to add more colors to the overlay (see bug), which exacerbates the problem. This is a refactoring and does not contain any user-facing changes. Bug: b/143452916 Change-Id: Ic418ce6993c1cbfd60746fa6df7f9ec493afdba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881560 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#710319}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/05c47926ff71..9cdc9cc1c48d git log 05c47926ff71..9cdc9cc1c48d --date=short --no-merges --format='%ad %ae %s' 2019-10-29 sprang@webrtc.org Cleanup of deprecated RTPSender code 2019-10-29 gustaf@webrtc.org Remove deprecated Audio Processing APIs 2019-10-29 yura.yaroshevich@gmail.com Fixed MSAN issue with usrsctp reliability test. 2019-10-29 danilchap@webrtc.org Detach H264 sps pps tracker from VCMPacket Created with: gclient setdep -r src/third_party/webrtc@9cdc9cc1c48d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: If232afd3fa7405b885ec6b2d7987a0322a417621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886355Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710318}
-
Alexander Timin authored
Disable bfcache for web authenticator, since on DidFinishNavigation it would cleanup all the authentication data. This would be a problem if we restore the document from back-forward cache, so disabling it. Bug: 1001087 Change-Id: I928a89568fc804c6953099560b0d0cc2916d7ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825220 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#710317}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c3dc1efee35a..2c887d9d2df6 Created with: gclient setdep -r src-internal@2c887d9d2df6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I24de4dbd8a4eebcd710bb3564f9064d0d92b7b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886353Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710316}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/da052ca534fe..0877b946198e git log da052ca534fe..0877b946198e --date=short --no-merges --format='%ad %ae %s' 2019-10-29 taylori@google.com Merge "Revert "perfetto-ui: Add beta search tooltip"" Created with: gclient setdep -r src/third_party/perfetto@0877b946198e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ib315fe6a52e51827e0963d7c5954cb0fe2d0e373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887050Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710315}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2fa0ef25..588b98f2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iebd22fcd49e7c97738ec06b6b454196260fc0550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886372Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710314}
-
Jacobo Aragunde Pérez authored
Highlights: * There are some other changes to the code logic, derived from the usage of PendingRemote in function arguments instead of InterfacePtr. * Shorthands provided by the new Mojo types allowed to simplify some implementations. * Moved initialization of affected members to their declarations, where possible, to comply with coding guidelines. Bug: 955171 Change-Id: Iebdc315dfcfebc671e0c91c9cf4f9fdd9fdf7b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847309Reviewed-by:
Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Cr-Commit-Position: refs/heads/master@{#710313}
-
Sigurdur Asgeirsson authored
Bug: 1017874 Change-Id: I4c48c36574840b10b8a6ac0df4ce3e2643f13cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881722 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#710312}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ba97ef24. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-writing-modes NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ia3051a442d52bca5f1c39e4a42f63c763bc535df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886371Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710311}
-
Austin Eng authored
The WebGL working group decided there is enough WebGL 1 support for instancing that it would be simpler to only expose the instanced version of the extension. This also rolls WebGL 2701c13..69e333c which includes the spec and conformance test changes. Bug: chromium:890539 Change-Id: Ib4dccf56f488cedf8161268ac3467d27c9b371c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881712Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#710310}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3e83dd9cb99c..918853e6112f git log 3e83dd9cb99c..918853e6112f --date=short --no-merges --format='%ad %ae %s' 2019-10-29 perezju@chromium.org [Telemetry] Stop collecting histograms in results object Created with: gclient setdep -r src/third_party/catapult@918853e6112f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:973837 Change-Id: Ia2725ab643b1ef6aad228e6bf375e1717e16ad04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886758Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710309}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9c71e4936bc2..05c47926ff71 git log 9c71e4936bc2..05c47926ff71 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 srte@webrtc.org Removes OnPacketAdded callback from feedback adapter. Created with: gclient setdep -r src/third_party/webrtc@05c47926ff71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I40693deb83acf59549c2042fb06cbc1525b72829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886755Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710308}
-
Piotr Pawliczek authored
This patch adds new entries to chrome://device-log with information about: - the length of a resultant list of print servers calculated from policies - results of querying each print servers (number of printers or error) - the length of a final list of server printers. BUG=chromium:1018552 TEST=tested on nautilus Change-Id: I73516f73e3608e87b59d2a6980fbb52367d45ea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882650Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Luum Habtemariam <luum@chromium.org> Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Cr-Commit-Position: refs/heads/master@{#710307}
-
Aaron Krajeski authored
This reverts commit 4d99f02a. Reason for revert: Started causing an infra failure on the msan_linux bot https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/20157 Original change's description: > DL: Speculative fix for a leak in display_lock_fuzzer. > > This replaces a leaky new with a local static variable for the display > lock fuzzer environment. > > This is a speculative fix for the referenced bug. > > R=schenney@chromium.org > > Bug: 1013486 > Change-Id: I717437eac8d3d6f3d81515e2822209a676047698 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873916 > Commit-Queue: vmpstr <vmpstr@chromium.org> > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709212} TBR=vmpstr@chromium.org,schenney@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1013486 Change-Id: I61dc9ddbc3997c7452e1aef4496b21d6a21c85d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884592Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#710306}
-