- 07 Feb, 2019 40 commits
-
-
Natalie Chouinard authored
Connect Java and native sides of JNI bridge for Get- and SetTokenMappings methods. Bug: 923581 Change-Id: Ia800003a41a1daba5da776183ed5942dde7d9018 Reviewed-on: https://chromium-review.googlesource.com/c/1455109Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#630007}
-
Chris Mumford authored
Switches chromeos::assistant::ChromiumHttpConnection from using //net directly to using the network service (SimpleURLLoader). Bug: 913757 Change-Id: If89b2eb49f66a0279d9b23c1533c15166c322110 Reviewed-on: https://chromium-review.googlesource.com/c/1380541Reviewed-by:
Leo Zhang <googleo@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#630006}
-
Harley Li authored
In Applocation>Cache Storage, to preview a cached response, DevTools needs to call requestCachedResponse() to the backend to fetch it. Originally, DevTools is unable to fetch cached responses for requests that have headers, and this is because in DevTools's beckend, the field 'headers' of mojom::blink::FetchAPIRequest remains unfilled. This patch fixes the issue by filling this field. Bug: 890359 Change-Id: I599cc1393d5c02baa7d7f90fc22fd379b1745090 Reviewed-on: https://chromium-review.googlesource.com/c/1455272Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Cr-Commit-Position: refs/heads/master@{#630005}
-
Mario Bianucci authored
Mask execution closely follows background execution, which results in the size of the mask being reduced to the exact size requested, rather than filling out the dest_rect in BackgroundImageGeography::SetNoRepeatX and ::SetNoRepeatY. This CL puts the mask in the correct location, then when we are creating the shader in image.cc, if the mask doesn't fill out the dest_rect, decal tilemode is used to fill the rest with transparency, which allows the mask to fill the full area. Regarding the change to the fast/backgrounds/mask-composite.html test: This change results in the original test failing, displaying the same thing that it displays when using source-out. Based on my understanding of how the 'copy' Porter-Duff keyword works, I believe this is correct and that the test previously had an incorrect baseline because of this bug. My understanding is that, if mask-composite is 'copy', then regardless of the number of masks, only the first one will be displayed. The PD definition of copy is that only the source mask is displayed, and since this would be applied starting from the last two masks listed, moving up to the first two, the end result is that only the first mask is displayed. And, since this matches what happens when mask-composite:source-out is used (and matches Edge and Firefox using 'subtract'), I just changed it to a likely more commonly used keyword. Bug: 917067 Change-Id: Ic9174ea67d92abe6b78acf9b7f2640796d30d249 Reviewed-on: https://chromium-review.googlesource.com/c/1447261 Commit-Queue: Mario Bianucci <mabian@microsoft.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#630004}
-
Jordan Taylor authored
web_tests/animations/animationworklet/worklet-animation-local-time-after-duration.html -> web_tests/external/wpt/animation-worklet/worklet-animation-local-time-after-duration.https.html web_tests/animations/animationworklet/worklet-animation-local-time-before-start.html -> web_tests/external/wpt/animation-worklet/worklet-animation-local-time-before-start.http Bug: 915352 Change-Id: Ic24945fc071ebc9aada2cf925fcb07b111d23a99 Reviewed-on: https://chromium-review.googlesource.com/c/1446566Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Jordan Taylor <jortaylo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#630003}
-
Ramin Halavati authored
|ObfuscatedFileUtilDelegate| and |ObfuscatedFileUtilMemoryDelegate| are added to support in-memory file system for incognito mode and |ObfuscatedFileUtil| is updated to choose the appropriate delegate based on being incognito or not. To avoid making the CL large, only the skeleton of the |ObfuscatedFileUtilMemoryDelegate| is added in this CL and the actual implementation will be added in a next one. The change is part of the following design doc: https://docs.google.com/document/d/17NV1cGSIEG2i5qm2QU4EzDMKRoyVEbNNq-Re-JhwSB0 Bug: 93417 Change-Id: I47353c656ab70ab6c98c8e06c9e0c3a03319d012 Reviewed-on: https://chromium-review.googlesource.com/c/1452176Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#630002}
-
Toni Barzic authored
Web UI lock screen is not used anymore. BUG=929466 Change-Id: I0984b3f6ccc7bb148784a56d7522393e9ef77a24 Reviewed-on: https://chromium-review.googlesource.com/c/1457656Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#630001}
-
Christopher Grant authored
This flag was added as a means of swapping the ABIs of a 64-bit build, to get a 64-bit browser instead of 32. There are now build targets to achieve the same thing, so the flag can be removed. On a 64-bit configuration, you can now build: - monochrome_public_bundle: 32-bit browser w/ 64-bit WebView - monochrome_64_32_public_bundle: 64-bit browser w/ 32-bit WebView - monochrome_64_public_bundle: 64-bit browser BUG=907640 Change-Id: Id021645ac9b411510fdf23c09428d3d888a857f5 Reviewed-on: https://chromium-review.googlesource.com/c/1458360Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#630000}
-
Stephen Nusko authored
The fix was submitted in https://android-review.googlesource.com/c/platform/external/perfetto/+/874695 So we no longer need to special case this instead we can just delegate the call directly. Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=839074 Change-Id: Ie6d6ee8d94b00f73b59dd95a90d2c29dd3f9a383 Reviewed-on: https://chromium-review.googlesource.com/c/1451942 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#629999}
-
Sigurdur Asgeirsson authored
Bug: 910288 Change-Id: Icfbb9da91d5f15d53839e7a6b3de4dd084a37ab1 Reviewed-on: https://chromium-review.googlesource.com/c/1456977 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#629998}
-
Frank Kastenholz authored
There are no flags to be updated. -------------------------------------------------- Date: Fri Jan 25 19:26:18 2019 +0000 Change SerializeHeadersFrameHeader() to take header frame length. n/a (No functional change.) Change SerializeHeadersFrameHeader() to take header frame payload length instead of entire header frame payload, just like SerializeDataFrameHeaders() already takes a length. Also change SerializeDataFrameHeaders() argument name from |length| to |payload_length| for clarity. Motivation: Just like SerializeDataFrameHeaders(), SerializeHeadersFrameHeader() does not need to know the entire frame payload, only its length. This is in contrast with Serialize*Frame() methods that serialize the payload in addition to the frame header. Merge internal change: 230937339 https://chromium-review.googlesource.com/c/1454132/ -------------------------------------------------- Date: Fri Jan 25 22:34:31 2019 +0000 Set is_current_packet_connectivity_probing_ to false in the end of QuicConnection::ProcessUdpPacket. Protected by default true flag FLAGS_quic_reloadable_flag_quic_clear_probing_mark_after_packet_processing. This should fix the flaky test in b/122963316, see http://b/122963316#comment3 for more details. Merge internal change: 230970486 https://chromium-review.googlesource.com/c/1454134/ Bug: 122963316 -------------------------------------------------- Date: Sat Jan 26 12:14:43 2019 +0000 In QUIC, accept packet number 0 in v99. Protected by version 99 and gfe2_restart_flag_quic_uint64max_uninitialized_pn. Merge internal change: 231039835 https://chromium-review.googlesource.com/c/1455016/ Bug: 121265775 -------------------------------------------------- Date: Sun Jan 27 01:47:29 2019 +0000 Progress towards allowing variable length connection IDs This CL refactors some of the QUIC codebase to plumb the version to more places. It uses that to introduce QuicUtils::CreateZeroConnectionId which currently provides 64bits set to zero but will eventually allow clients like quartc to use zero-length connection IDs. refactoring, no change of behavior, not flag protected NO_BUG=n/a Merge internal change: 231077921 https://chromium-review.googlesource.com/c/1455019/ -------------------------------------------------- Date: Mon Jan 28 19:13:29 2019 +0000 (n/a) Change QUIC_LOG_ to function-like macros, these macros are allowed to 'return' different values based on the current QUIC logging threshold. No bahavior change, not protected. Merge internal change: 231254026 https://chromium-review.googlesource.com/c/1455058/ -------------------------------------------------- Date: Mon Jan 28 19:57:32 2019 +0000 Change frame type values for IETF QUIC This CL changes the frame type values used for IETF QUIC. In doing this, a bug was found in the test code to test the construction of IETF QUIC BLOCKED frames. This error was fixed. After the test was corrected, there were no bugs in the core QUIC code. There are no other logical or functional changes. N/A all code is for version99/IETF QUIC only and is flag protected.fayang Merge internal change: 231263146 https://chromium-review.googlesource.com/c/1455059/ -------------------------------------------------- Date: Tue Jan 29 19:14:31 2019 +0000 Add QUIC v47 which will use IETF draft-17 header format with demultiplexing bit. Protected by BLOCKED FLAGS_quic_reloadable_flag_quic_enable_version_47. Merge internal change: 231437303 https://chromium-review.googlesource.com/c/1455296/ Bug: 118781128 -------------------------------------------------- Date: Wed Jan 30 00:48:40 2019 +0000 Do not include "base/logging.h" to silent BUILD error because of ./base/internal/logging.h:347:32: error: comparison of integers of different signs: 'const int' and 'const unsigned long' [-Werror,-Wsign-compare] n/a (include only change) Merge internal change: 231499804 https://chromium-review.googlesource.com/c/1455298/ -------------------------------------------------- Date: Wed Jan 30 15:40:40 2019 +0000 Actually use IETF draft-17 header format with demultiplexing bit in v47. Protected by BLOCKED FLAGS_quic_reloadable_flag_quic_enable_version_47. Merge internal change: 231592167 https://chromium-review.googlesource.com/c/1455300/ Bug: 118781128 -------------------------------------------------- Date: Wed Jan 30 16:03:14 2019 +0000 Enable quic version 47 for Quartc. Quic version 47 adds draft 17 bit, which will allow for demuxing quic from RTP. n/a (Quartc only) Merge internal change: 231595566 https://chromium-review.googlesource.com/c/1455301/ -------------------------------------------------- Date: Wed Jan 30 16:06:50 2019 +0000 In QUIC, change ParsedQuicVersion(PROTOCOL_UNSUPPORTED, QUIC_VERSION_UNSUPPORTED) to UnsupportedQuicVersion(). (n/a) Refactor only, not protected. Merge internal change: 231596249 https://chromium-review.googlesource.com/c/1455303/ -------------------------------------------------- Date: Wed Jan 30 21:01:47 2019 +0000 remove unused #include base/macros.h in platform api. Merge internal change: 231652158 https://chromium-review.googlesource.com/c/1455066/ -------------------------------------------------- Date: Thu Jan 31 15:00:32 2019 +0000 n/a (No functional change in tests only.) Introduce and use IsVersion99() method in QuicSpdySessionTestBase, QuicSpdyStreamTest, and QuicSimpleServerSessionTest, where long inline comparisons were used before, and in QuicSimpleServerStreamTest, where there was a bool member before. This simplifies a lot of conditionals in these tests. This is particularily beneficial as cr/231494986 is about to add even more. Merge internal change: 231779345 https://chromium-review.googlesource.com/c/1455071/ -------------------------------------------------- Date: Thu Jan 31 15:15:32 2019 +0000 n/a (Test only change, no functional change.) Remove some redundant Times() expectations in three test files that will be touched by a future CL cr/231494986. Only remove redundant Times(1) and Times(AnyNumber) expectation is there is also a WillOnce() or WillRepeatedly() expectation, which implies the Times() expectation according to https://github.com/google/googletest/blob/master/googlemock/docs/CheatSheet.md#setting-expectations. This is true regardless of whether the mock is a StrictMock or not. Also change a Times(1).WillRepeatedly() to WillOnce(). Do not touch any Times(1) or Times(0) expectations if there are no WillOnce() or WillRepeatedly(), because these are there to guide the reader. (Even though Times(1) is implied, and an expectation with Times(0) could be entirely removed on a StrictMock.) Merge internal change: 231781155 https://chromium-review.googlesource.com/c/1455072/ -------------------------------------------------- Date: Thu Jan 31 15:17:58 2019 +0000 In QUIC, let v46 adopt QUIC bit header change, while v47 will be used for CRYPTO frame change. Protected by BLOCKED FLAGS_quic_reloadable_flag_quic_enable_version_46 and FLAGS_quic_reloadable_flag_quic_enable_version_47. Merge internal change: 231781497 https://chromium-review.googlesource.com/c/1455088/ Bug: 118781128 -------------------------------------------------- Date: Thu Jan 31 15:48:32 2019 +0000 Only enable version 46 for Quartc, as v46 supports QUIC bit header now. n/a (Quartc only) Merge internal change: 231785372 https://chromium-review.googlesource.com/c/1455313/ -------------------------------------------------- Date: Thu Jan 31 17:28:16 2019 +0000 Add QpackEncoder and QpackDecoder to QuicSpdySession only when using QUIC version 99. Not flag protected. Merge internal change: 231799718 https://chromium-review.googlesource.com/c/1456278/ -------------------------------------------------- Date: Thu Jan 31 21:13:58 2019 +0000 Use GetInvalidStreamId() instead of hard-coded 0s In several places, the IETF-QUIC/Version99 code used hard coded 0s to indicate an invalid stream id. This is incorrect. The 0s have been replaced with QuicUtils::GetInvalidStreamId() calls so that the correct invalid value is used. N/A, all code is version 99/IETF-QUIC and thereby flag protected. Merge internal change: 231839770 https://chromium-review.googlesource.com/c/1456279/ -------------------------------------------------- Date: Fri Feb 1 17:24:43 2019 +0000 Pass the current connection to QuartcPacketWriter through PerPacketOptions. This is mostly a nicer way to organize the relationship between the connection and packet writer. Under the previous arrangement, the connection registered itself once with the packet writer and the packet writer assumed that it's only used by that connection forevermore. Under the new arrangement, the connection identifies itself whenever it sends a packet. Packets that are not sent by the connection will not cause confusion. For example, the QuicDispatcher may send packets before a connection is created (for version negotiation) or after it closes (rejecting the same connection id for some time before allowing it to be reused). Under the previous arrangement, such packets could cause problems--there might still be a dead connection registered with the packet writer. This makes the QuartcPacketWriter usable with multiple connections. Quartc doesn't really need this (yet), but it's a nice benefit of organizing the code this way. n/a (Quartc only) FIG_CHANGESET=011d79c4fbb12d50a6039d41a2fbad81f03c42be Merge internal change: 231983473 https://chromium-review.googlesource.com/c/1456280/ Bug: 117157454 -------------------------------------------------- Date: Sat Feb 2 00:08:37 2019 +0000 Deprecate FLAGS_quic_reloadable_flag_quic_limit_version_negotiation. Also add a unit tests for doing version negotiation with a full size packet. Merge internal change: 232055257 https://chromium-review.googlesource.com/c/1456281/ R=rch@chromium.org Change-Id: If05c598e85bffe7933e5d404527a2acc358bcc59 Reviewed-on: https://chromium-review.googlesource.com/c/1456979Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#629997}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I17f40d166c9666826defa11278f8b32967fa67f6 Reviewed-on: https://chromium-review.googlesource.com/c/1458687Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#629996}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/cde3da57b9a1..ce4336c2ab60 $ git log cde3da57b..ce4336c2a --date=short --no-merges --format='%ad %ae %s' 2019-02-05 jianj Fix VPX_KF_DISABLED. 2019-02-04 jianj No vpx_img_alloc for y4m input in example encoders. 2019-02-04 johannkoenig enforce some c89 restrictions 2019-02-05 johannkoenig ppc: use c89 loop declaration 2019-02-01 huisu Improve the partition split prediction model 2019-02-04 chiyotsai Fix an inline varible declaration in temporal filter 2019-02-04 marpan vp8: Add extra conditon for overshoot-drop 2019-02-04 chiyotsai Add operator<< to a struct in yuv_temporal_filter_test.cc 2019-01-31 chiyotsai Some cosmetic fixes to temporal filter 2019-02-01 johannkoenig Release v1.8.0 Northern Shoveler (...) 2019-01-31 angiebird Add dist scale in get_mv_dist 2019-01-31 marpan vp9: Adjust intra check for short_circuit_flat_blocks 2019-01-30 angiebird Implement get_mv_cost() 2019-01-25 chiyotsai Add highbd yuv_temporal_filter 2019-01-29 angiebird Add assertion in get_block_src_pred_buf 2019-01-29 angiebird Fix bug in predict_mv_mode 2019-01-29 angiebird Allocate memory for mv_mode_arr[] 2019-01-15 jianj vp9: fix definition for VP9E_SET_POSTENCODE_DROP 2019-01-11 deepa.kg Fix segmentation fault in hbd path 2019-01-08 jianj vp8 dec: Add flag to bring up threads. Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: Ife63df105d9925e81c8faa183ae61d31eed18568 Reviewed-on: https://chromium-review.googlesource.com/c/1456937 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#629995}
-
Matt Falkenhagen authored
In a WIP patch changing sevice worker unit tests, I somtimes get crashes on test exit because ServiceWorkerDevToolsManager is accessed on a thread that doesn't exist (I'm guessing the UI thread has been torn down). I think the manager singleton gets destructed which causes hosts to try to access the manager instance. The problem seems to go away by changing from Singleton to NoDestructor. NoDestructor is preferred anyway as documented in singleton.h. Change-Id: I70eb6435ed7eea1362e115488ae4999dedcba387 Reviewed-on: https://chromium-review.googlesource.com/c/1457883 Auto-Submit: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#629994}
-
Ted Choc authored
Requiring user gesture on form submission broke OAuth providers, so this allows incoming intents bypass this restriction. BUG=927509,839751 Change-Id: I4a46cf0b3bb3fad0f18211b2194dd823d0bdc897 Reviewed-on: https://chromium-review.googlesource.com/c/1456211Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#629993}
-
danakj authored
Remove TODOs lamenting this obsolete behaviour, and branches on frozen in the shown/hidden RenderWidget code. Instead DCHECK the RenderWidget is not frozen when being shown/hidden. Note that when becoming frozen they will stay in whatever shown/hidden state they were before being frozen until after they are thawed. R=dcheng@chromium.org Bug: 419087 Change-Id: I49bc0c4a622485cc0ab5550a11c9f6c07507c7b3 Reviewed-on: https://chromium-review.googlesource.com/c/1455496 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#629992}
-
Jonathan Backer authored
The primary motivation for this CL is to remove the callbacks from GLRendererCopier. When used by GLRenderer, GLRendererCopier executes on the same display compositor thread as GLRenderer and the callbacks are fine. When used by SkiaRenderer, SkiaRenderer will run on display compositor thread and GLRendererCopier will run on GPU main thread. By plumbing the data down, we can avoid synchronization issues. This CL also centralizes the calculations and eliminates a bit of code duplication. Bug: 927335 Change-Id: Ib45fc3d3a515a9e21aaa4638cc5e0b462c498bdd Reviewed-on: https://chromium-review.googlesource.com/c/1456948 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#629991}
-
Henrique Ferreiro authored
Remove the usage of the IdentityManager Mojo API in favor of the C++ API for consistency with other //chrome/browser code. Bug: 928187 Change-Id: Id6431d3ec57c0b7dc872ed5e23d863dd3c96e922 Reviewed-on: https://chromium-review.googlesource.com/c/1454527 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#629990}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0041fe53dcfe..710f3d3e4483 git log 0041fe53dcfe..710f3d3e4483 --date=short --no-merges --format='%ad %ae %s' 2019-02-07 danilchap@webrtc.org Use task queue factory factory as parameter for TaskQueueTest Created with: gclient setdep -r src/third_party/webrtc@710f3d3e4483 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1e764f80fd5681e9160f44c8fad2339f9f4fdfbe Reviewed-on: https://chromium-review.googlesource.com/c/1458420Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629989}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/603ad164a6fc..088e521769f9 git log 603ad164a6fc..088e521769f9 --date=short --no-merges --format='%ad %ae %s' 2019-02-07 syoussefi@chromium.org Vulkan: Suppress flaky test on Nexus5X Created with: gclient setdep -r src/third_party/angle@088e521769f9 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Id17f80392b1330e5df702066c996bef7f7562d60 Reviewed-on: https://chromium-review.googlesource.com/c/1458421Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629988}
-
Boris Sazonov authored
This CL replaces layout_height="36dp" for buttons in the sign-in screen with layout_height="wrap_content". These buttons use TextButton and FilledButton.Flat text styles, so they already have min height set to 36dp. Setting layout_height to wrap_content allows these buttons to grow if font height is larger than 36dp. Bug: 927425 Change-Id: I616c1a952b3a4aa9ab52c46a7c7aff47bc05c301 Reviewed-on: https://chromium-review.googlesource.com/c/1458209 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#629987}
-
Markus Heintz authored
Bug: None Change-Id: I6c923ffd2c5631e21b6964774dd9588573236811 Reviewed-on: https://chromium-review.googlesource.com/c/1458204Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#629986}
-
Raul Tambre authored
The former non-overloaded variants are deprecated. This is a mechanical change; there is no intended behavior change. Change-Id: I326c68bf2910fbbf75db379e08202d5aac4f2ef2 Reviewed-on: https://chromium-review.googlesource.com/c/1456015 Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#629985}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/36651e4e3873..be531eda4378 Created with: gclient setdep -r src-internal@be531eda4378 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibcab6633552856707b155cef818dbad963b10934 Reviewed-on: https://chromium-review.googlesource.com/c/1458419Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629984}
-
Clemens Arbesser authored
Since most existing LOGs were only used for reporting fatal errors, most DVLOGs currently use verbosity 1. Bug: 806868 Change-Id: Ie5819d88975daf8e2a9e8169843b6d39d7fa365b Reviewed-on: https://chromium-review.googlesource.com/c/1449680 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#629983}
-
Ehsan Karamad authored
The test is running in a virtual suite and is flaky most likely due to outstanding work the needs to be done for FeaturePolicyForSandbox. TBR=dpranke@chromium.org, iclelland@chromium.org Bug: 929678 Change-Id: Iedc0bdefc6c376031d48b46fdee68a475d16e319 Reviewed-on: https://chromium-review.googlesource.com/c/1458363 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#629982}
-
kylechar authored
CompositorResizeLock was deleted in https://crrev.com/c/1053588. UI.CompositorResizeLock.* hasn't been recorded since then so mark as obsolete. Bug: 928497 Change-Id: Idcb1473864f9342d797942f1b749ae587c1b2213 Reviewed-on: https://chromium-review.googlesource.com/c/1454222Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#629981}
-
Elly Fong-Jones authored
This program generates a list of all the currently unowned flags. Bug: 897809 Change-Id: Ifc5462557fe16784b792dc4d3811fc447bf566db Reviewed-on: https://chromium-review.googlesource.com/c/1458598 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#629980}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/01a3e9b6383f..3b71e65658cd git log 01a3e9b6383f..3b71e65658cd --date=short --no-merges --format='%ad %ae %s' 2019-02-07 cwallez@chromium.org Make CopyTests_T2B.Texture2DArrayMip suppression more precise Created with: gclient setdep -r src/third_party/dawn@3b71e65658cd The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ie243a8a8388b8f9a10c7bb79f62dc26757ea5a94 Reviewed-on: https://chromium-review.googlesource.com/c/1458418Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629979}
-
jdoerrie authored
This change modifies CommandLine::ParseFromString() to take its param as base::StringPiece16 instead of a const-ref to string16. This allows for a more flexible interface as well as a more efficient implementation. Bug: NONE Change-Id: Ie099afa9be90d2030c72057ce040f6bc16e1df32 Reviewed-on: https://chromium-review.googlesource.com/c/1451941 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#629978}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c19d81acc096..c877ea265759 git log c19d81acc096..c877ea265759 --date=short --no-merges --format='%ad %ae %s' 2019-02-07 reed@google.com Hide setDrawLooper -- deprecate loopers Created with: gclient setdep -r src/third_party/skia@c877ea265759 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I960dcf6ef282cd84f165a6221aa185b4e24c8ea8 Reviewed-on: https://chromium-review.googlesource.com/c/1458417Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629977}
-
Mohamed Amir Yosef authored
Before posting a client to server message, the sync cycle is informed about an upcoming ProtocolEvent. ProtocolEvent's are only consumed in SyncInternalsMessageHandler::OnProtocolEvent() using the ToValue() method. It's basically used to log the data to the sync-internal pages. All other occurrences of ProtoclEvent in the code are just to forward that protocol event across different layers of sync. One issue is the request object used to create the ProtoclEvent is incomplete and some fields that as store_birthday are actually set when posting the message to the server. This CL is splitting the functionality in PostClientToServerMessage() by creating another method to fill in the required fields. Such that, those fields get filled before reporting the ProtocolEvent. Bug: 925839 Change-Id: If6e09dd65acea99619f5ebe82a18492ef3c322ee Reviewed-on: https://chromium-review.googlesource.com/c/1456076 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#629976}
-
Mattias Nissler authored
BUG=None TEST=Compiles Change-Id: I2d87af0d1f4164d9d28621fdefa547ee94896402 Reviewed-on: https://chromium-review.googlesource.com/c/1458198Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#629975}
-
Pavol Marko authored
This is a follow-up to CL:1446226 . Bug: none Test: unit tests Change-Id: Ia3e323a8b5ab9f18d69af944a9b85c479625b055 Reviewed-on: https://chromium-review.googlesource.com/c/1452187 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#629974}
-
vasilii authored
Autofill uses __gCrWeb.fill.setInputElementValue that triggers additional events which React or Angular can use. Now the password manager reuses the function for password forms. Bug: 813175 Change-Id: I8c57bc33b27eba050e8d74d63e8caeee283adb1f Reviewed-on: https://chromium-review.googlesource.com/c/1453439Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#629973}
-
Finnur Thorarinsson authored
Bug: 921425, 656015 Change-Id: Ia5f324ea9c6d3c66c52214af083f597ea55df8b2 Reviewed-on: https://chromium-review.googlesource.com/c/1455950 Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#629972}
-
Daniel Bratell authored
Jumbo, as implemented as a gn template, will naturally hide the original files behind new files target_jumbo_1.cc, target_jumbo_2.cc, .... This breaks the gn analyze step which is used by cq to figure out if it needs to test compile or not. To give gn analyze a chance to see what is going on, put the original sources in the merge action's |input| list. The action won't use the files and it will serialize actions that don't need serializing but it might be a small price to pay. There might be unexpected and unwanted side effects from this. The cleanest solution would be to give gn native jumbo support which would also allow other changes like better IDE support and better error messages, but this is what we got. Bug: 893071 Change-Id: I36aa498795871a63cfcd4e2d27c29e2f59d5ccbb Reviewed-on: https://chromium-review.googlesource.com/c/1455943 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#629971}
-
Marc Treib authored
Callers can instead trigger a reconfigure by grabbing and immediately releasing a SyncSetupInProgressHandle instead. This resolves one of the last reasons for using ProfileSyncService rather than SyncService. Bug: 924508 Change-Id: I2ba2839356e32954d3c655356a60c6398d41adae Reviewed-on: https://chromium-review.googlesource.com/c/1456658Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#629970}
-
Etienne Pierre-doray authored
This CL removes redundant members in base::internal::Task: - delay: Redundant with PendingTask::delayed_run_time - sequenced_time: Redundant with PendingTask::queue_time (unused when sequenced_time is used). This clean up makes Task easier to read, and slightly more lightweight. Change-Id: I7ed16bd3458d61f98d717f2f3dd83124f9f0121f Reviewed-on: https://chromium-review.googlesource.com/c/1448977Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#629969}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromiue.org Change-Id: I5fc899717a00db03daf0a4c5a94e267daa305c0d Reviewed-on: https://chromium-review.googlesource.com/c/1458601Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#629968}
-