- 10 Jul, 2019 40 commits
-
-
Meilin Wang authored
Reused string pairs: IDS_SETTINGS_GOOGLE_ASSISTANT_ENABLE_HOTWORD -> IDS_ASSISTANT_HOTWORD_TITLE IDS_SETTINGS_GOOGLE_ASSISTANT_VOICE_SETTINGS_DESCRIPTION -> IDS_ASSISTANT_VOICE_MATCH_RECORDING IDS_SETTINGS_GOOGLE_ASSISTANT_ENABLE_CONTEXT -> IDS_ASSISTANT_SCREEN_CONTEXT_TITLE IDS_SETTINGS_GOOGLE_ASSISTANT_ENABLE_CONTEXT_DESCRIPTION -> IDS_ASSISTANT_SCREEN_CONTEXT_DESC Bug: b/117182991 Test: local compile and manually test. Change-Id: I1894c6bb9292f01fd8cc72ca1ab59b0b19971d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682620Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#676170}
-
Karandeep Bhatia authored
r672618 added an early return to TestRunnerForSpecificView::SetIsolatedWorldInfo to check for an incorrect world id. This CL corrects that check. This helps prevent a CHECK failure when a fuzzer provides invalid input. BUG=977801 Change-Id: I62e53fdc2854c7e8c5c6500a765af08ba12b1635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688255 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#676169}
-
Jack Steinberg authored
This partially implements the action option for showToast(), as outlined in the explainer at https://github.com/jackbsteinberg/std-toast/blob/32237007b068d690f39002d364367f3c097f1a97/README.md#showtoastmessage-options. For now it only handles the string or undefined cases; the Element case will be handled in a follow-up CL once the action setter is implemented. BUG=972945 Change-Id: I82556801a6586c89cd506669f935488e049c47c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684466 Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#676168}
-
Tim Song authored
Currently, clicking on this notification marks the locale change as accepted, but does not dismiss the notification. When the user interacts with the notification again, it does not work. TEST=manual BUG=937185 Change-Id: Ib510f78d6695bf2916678673a74198df605e5900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693682Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#676167}
-
Matthew Mourgos authored
This change will make it easier to switch the current constants over to the newer dense shelf constants. Bug: 973483 Change-Id: Iac32fe849ab85f2481934089a43b58bd2ef26326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694608 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#676166}
-
Dale Curtis authored
Two issues are fixed: - File was somehow muxed into an invalid configuration. - Not enough was appended to start playback. Also other tests were flaking, so: - Increased append size to 128k - Only start playback after appends complete. - Mark EOS and add ended listener since append size is small. BUG=978045 TEST=test passes Change-Id: I25dc5994044424c53198490d89d3de15f6e5c616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680956 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#676165}
-
Sam Maier authored
Even if a proguard_jar_path is set, someone must manually set use_r8 = false in their GN args to use it. Bug: 908988 Change-Id: I509db915cba46ad694b687eda8a3b0123234847c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689877Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#676164}
-
Yi Xu authored
The drawing buffer is not ready when blink::WebGLRenderingContextBase::commit is called. Added additional check for drawing buffer. Bug: 976830 Change-Id: I810d5ad7c847ff5f5aa3ff850f812cfbd3dbc750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692827Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#676163}
-
Avery Musbach authored
If a user-positionable window is activated during the divider snap animation, and if this window is not already snapped in split view, then split view mode shall end. Regardless of whether the window generally can be snapped in split view, the cannot snap toast shall not appear in this workflow. Test: manual Bug: 982859 Change-Id: I743c361f59f123e02f76f35033e719a33b66cf70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695966Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#676162}
-
Alex Newcomer authored
We call ClearSearch when the AppListView gains focus in tablet mode. This is one of many things we do to reset the AppListView when the it (which is always open) is focused as the last open window is closed. The issue is that ClearSearch actually refreshes the suggestion chips (causing the visible flash). This refresh is unnecessary because the chips are already refreshed after an app is launched. Bug: 979594 Change-Id: I8baec08c78fc8c5439127427de62fddeddfb414c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690723 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#676161}
-
Tom Anderson authored
This is needed in preparation for using DbusMenu in global_menu_bar_x11.cc BUG=981201 R=thestig Change-Id: I84b4ef13fe32eb342e702bedf9309b4e955cebb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688132Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#676160}
-
Rohit Rao authored
The system share menu has a "Close" button instead of a "Cancel" button on iOS 13, so the test is updated accordingly. A bug in the OpenInController is preventing the toolbar from being visible after any VC is presented fullscreen over the BVC. This causes the system share menu to break testOpenIn on iOS 13, but only when compiled with the iOS 12 SDK. This CL disables testOpenIn in this configuration until the underlying bug can be fixed. BUG=977161,982845 Change-Id: I007277fd323da67e6afbdac21c378393d1bd4eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696010Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#676159}
-
Siddhartha S authored
The trace importer can't handle thread descriptors from killed processes. So, do not emit thread names/types in thread descriptors when privacy filtering is enabled. Metadata from trace log is sufficient. BUG=978093 Change-Id: Iff2b870edff1f1c516eec3068489e67a66cc5b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691008Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#676158}
-
Andrew Grieve authored
They are keeping a few unused types for no reason. Bug: 887942 Change-Id: I4460c105b16ecdae504dd85cb185bac7fd4416a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695690 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#676157}
-
Pavol Marko authored
Add a mojo parameter to use the built-in cert verifier on Chrome OS. Pass a SystemTrustStoreProvider to CertVerifyProcBuiltin on ChromeOS which will provide SystemTrustStores that filter trusted certificates based on the NSS slot. Bug: 939344, 978069 Test: browser_tests --gtest_filter=SSLUITestCustomCACerts* Change-Id: I6b3cb864098f6f802c14092871e295b2576e7cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676170 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#676156}
-
vikassoni authored
Update AImageReader in android MediaPlayer path to use max_images of 2 instead of 3. This is a follow up CL of similar changes done in MCVD path - https://chromium-review.googlesource.com/c/chromium/src/+/1678292 This change is to reduce the memory usage footprint. Bug: 981098 Change-Id: I9d9e629f21e38a607c41ff7df951a5ee5d482e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688203 Auto-Submit: vikas soni <vikassoni@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#676155}
-
Liquan(Max) Gu authored
Largest Image Paint used to have a cap on the map & set, containers for the recorded nodes/objects/images. The cap was placed in order to prevent the containers from growing uncontrollably. But actually, if it grows in proportion to the size of the DOM tree, its size should be deemed under controlled. Based on this idea, we should remove the cap of containers in LIP. This CL also fixes the issue that the |invisible_node_ids_| set didn't remove node_id. Otherwise, its size would be grow uncontrollably. Related CL: crrev.com/c/1685325: the text counterpart Bug: 966476,967837 Change-Id: I29462450311b337bf635bc3cfd68379286422e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692199 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#676154}
-
Weiliang Chen authored
When we set up OutputSurface as overlay, it will always have z-order of 0, since z-order 0 is defined as primary plane. R=dcastagna@chromium.org Bug: 963597 Change-Id: I6b399b13ba4d447686b8d957dd50d3ca6011c912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695988Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#676153}
-
Toby H authored
Bug: 943208 Change-Id: I879cccddd6b307bef415727b2e2ca8e837ce4f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682727Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#676152}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/be75ef60754c..198be0a8bff1 git log be75ef60754c..198be0a8bff1 --date=short --no-merges --format='%ad %ae %s' 2019-07-10 treehugger-gerrit@google.com Merge "Add missing include" 2019-07-10 treehugger-gerrit@google.com Merge "processor: Add storage for thread_slices + TrackEvent tts support." 2019-07-10 treehugger-gerrit@google.com Merge "UI: Improved vid-trace sync & features" 2019-07-10 treehugger-gerrit@google.com Merge "Add a simple fuzzer for the traced_producer socket." 2019-07-10 lalitm@google.com Merge "metrics: add unaggregated memory metrics" 2019-07-10 eseckler@google.com Merge "processor: Add storage for virtual tracks" Created with: gclient setdep -r src/third_party/perfetto@198be0a8bff1 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I14dedd9e228f657196a889cc2268667311da8104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695848Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676151}
-
Asanka Herath authored
The quarantine component attaches metadata to files downloaded on Windows and macOS indicating their source. This is done so that the OS and AV products can factor the source of the file into evaluating whether the file is safe. Previously the source URL was presisted in its entirety. This change introduces a sanitization step that removes unnecessary information from the URLs being persisted. See bug for details on what's being removed and why. R: wfh@chromium.org Bug: 917842 Change-Id: I7831d1486b73a7e2858004e719c9680ea7a43d36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1407439Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#676150}
-
Ian Vollick authored
With this change, I've disabled SiteSettingsCounterTest. CountWithTimePeriod (logged crbug.com/981972 for this), and I've updated a few other tests to account for the fact that CONTENT_SETTINGS_TYPE_NOTIFICATION does not expect CONTENT_SETTING_ASK on Android. See SetWebsiteSetting in notification_channels_provider_android.cc Bug: 974405,981972 Change-Id: I28264fe120a4051014c29c4bdf052010d8c842c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691219Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#676149}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/abb5a315af45..cc3264288255 git log abb5a315af45..cc3264288255 --date=short --no-merges --format='%ad %ae %s' 2019-07-10 robertphillips@google.com Fix SkPixmap and SkBitmap dox for computeByteSize 2019-07-10 bsalomon@google.com Reland "Revert "Restore GL_UNPACK_ROW_LENGTH to 0 between MIP levles"" 2019-07-10 fmalita@chromium.org [skottie] Caching motion tile 2019-07-10 nigeltao@google.com Update Wuffs version 2019-07-10 borenet@google.com Revert "[infra] No relative path for infra_tests.isolate" 2019-07-10 robertphillips@google.com Add protected status to SkSurfaceCharacterization 2019-07-10 bsalomon@google.com Revert "Revert "Restore GL_UNPACK_ROW_LENGTH to 0 between MIP levles"" 2019-07-10 borenet@google.com [infra] No relative path for infra_tests.isolate 2019-07-10 brianosman@google.com Interpreter: Disallow recursion Created with: gclient setdep -r src/third_party/skia@cc3264288255 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:981254,chromium:981254 TBR=fmalita@google.com Change-Id: I38318288e330a6afbe96e2587f4c09aaba135c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695625Reviewed-by:
-
Ted Meyer authored
Splitting up the CL for D3D11 reporting max resolutions Change-Id: I087b3b422ac93a17d1fd581236bfc416a40070e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696083Reviewed-by:
-
Christopher Thompson authored
The final UI for showing the certificate org details in Page Info landed in crrev.com/c/1686172. This updates the string description to better match the final string and location, and adds a translation screenshot for the final UI. Screenshot for reference: https://screenshot.googleplex.com/ynwcgisiXgO Bug: 969734 Change-Id: I589a28b03f228d96f52e760c5b29fb7eeeeb5e80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696123Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#676146}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/69e46a186bb7..fba3e64e8086 git log 69e46a186bb7..fba3e64e8086 --date=short --no-merges --format='%ad %ae %s' 2019-07-10 jonahr@google.com Update trigger.py to take extra arguments 2019-07-10 timvp@google.com Vulkan: Fix khr-gles3.shaders.uniform_block.common.name_matching test failure Created with: gclient setdep -r src/third_party/angle@fba3e64e8086 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Id5f554fb49606449d92efd0aeb38ac428e6da220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696202Reviewed-by:
-
Alex Newcomer authored
Some cleanup code is saved until after the AppListView animations are complete. This makes animations smoother. Because there are no animations in side shelf mode, this cleanup is skipped. Do it in SetChildViewsForStateTransition. Also removed some redundant code (L1007 - L1011). This is done in the call at L1001. Bug: 981292 Change-Id: I406cde5bdfb152ab4829e275757c71c3b6f877dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693503 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#676144}
-
Ayu Ishii authored
This changes turns on the experimental SMSReceiver API for the Android platform excluding WebView and for tests on Non-Android platforms. Implementations for desktop are still in discussion and will be detached completely from the implementation and release of the SmsReceiver API release for Android. Bug: 963653 Change-Id: Iefe3b9b135e6a9ae4ed30f00370bb32747481e0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620107Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#676143}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/8aa9a7bb8f74..f970253a5d41 git log 8aa9a7bb8f74..f970253a5d41 --date=short --no-merges --format='%ad %ae %s' 2019-07-10 johnkslang@users.noreply.github.com Merge pull request #1827 from alan-baker/update-spirv-tools Created with: gclient setdep -r src/third_party/glslang/src@f970253a5d41 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,cwallez@chromium.org Change-Id: I72f1cc9d93ce4715da1c5d7d93c4b766fa445c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695898Reviewed-by:
-
Tarun Bansal authored
Change-Id: I3ecf89469653e98afed23f4d6cf8185bde032be8 Bug: 978490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687483 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
-
Nektarios Paisios authored
AccessibilityNotificationWaiter is part of the accessibility browser tests infrastructure. Focus events are fired via a different mechanism in BrowserAccessibilityManager than all other Blink-based or generated events. In order to write effective tests that check if a focus event has been fired, we need to modify AccessibilityNotificationWaiter to watch for focus events too. R=aboxhall@chromium.org Change-Id: I1e8730442cd733f51b7510592e0f9f0bc6f3c2a3 Bug: 982776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692104 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#676140}
-
Eric Roman authored
Historically the capture mode had aspirations for more complex parameterization, but in practice it just an enum. Refactored the code to reflect this, and also simplified the symbolic names. This is strictly a code refactor, except for one user-visible change: The command line switch --net-log-capture-mode now accepts both the old and new names. TBR: peter@chromium.org,seantopping@chromium.org,garykac@chromium.org,torne@chromium.org,scottmg@chromium.org Change-Id: I9bce3f7425bf47e8b24063dc922c534c2aa1f21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685684Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#676139}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios/+log/2801e6969bfd..a53be27c2404 git log 2801e6969bfd..a53be27c2404 --date=short --no-merges --format='%ad %ae %s' 2019-07-10 rsmoore@google.com Merge branch 'release-candidate' into stable Created with: gclient setdep -r src/ios/third_party/material_components_ios/src@a53be27c2404 The AutoRoll server is located here: https://autoroll.skia.org/r/material-components-ios-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:ios-internal-mdc TBR=bling-p10-rolls@google.com Change-Id: Iaffd3119f93219a724b908180bcd274a26c4f2d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696164Reviewed-by:
-
Erik Luo authored
DevTools agents rely on getting specific computed styles via getComputedCSSValueInternal(). After a refactoring [1], this method stopped accepting platform property names as strings, and started using IDs. This CL migrates those callsites to use IDs, which fixes the broken style tooltips on hover during 'inspect mode'. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1676647 Bug: 982396 Change-Id: Iebe59024659a8ee90db1396cfb9b83796a9689b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694404Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#676137}
-
Findit authored
This reverts commit 5e7eacc6. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 676033 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNWU3ZWFjYzZlYTU1ZjJhNTA2OTNkMzJhMGZhYzNiMjM3MGRmMWQwNAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29/81695 Sample Failed Step: webkit_layout_tests Sample Flaky Test: fast/events/layout_change_after_update_hover.html Original change's description: > Reset hover dirty flag before RecomputeMouseHoverState function > > MouseEventManager::RecomputeMouseHoverState may change the hover dirty > flag because it sends mouse boundary events such as mouseover, > mouseout, mouseenter and mouseleave, which may change the layout. We > need to reset |hover_state_dirty_| before we call > RecomputeMouseHoverState, so that we make sure that the hover is > updated for all the layout change. > > Bug: 877132 > Change-Id: Id6ec90e8f6ced06a68dffa1a31cd34b92294af37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689959 > Commit-Queue: Lan Wei <lanwei@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#676033} Change-Id: I875b1ebda88b4a802b18bb5e8dabef5f139e83df No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 877132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696524 Cr-Commit-Position: refs/heads/master@{#676136}
-
David Bokan authored
This CL fixes Blink unit tests when the FractionalScrollOffsets flag is turned on. This flag enables storing floating point scroll offsets inside Blink's ScrollableArea objects. This means that fractional offsets are now visible to JS and test code; some tests need to be adjusted to the new expectations. The typical test here performed something like a ScrollIntoView which should land on a fractional offset when trying to center an element. Prior to FractionalScrollOffsets, this would be floored. I've adjusted these tests to either change the page slightly so that we naturally land on an integral offset or provided a new expectation behind the runtime enabled feature. This is ok since these tests are just checking that an element is scrolled into view, we don't care about exact pixel offsets. For the smooth scrolling tests, I allowed a 1px difference in the expectation since these are checking a scroll offset mid-animation. After this CL, all Blink unit tests pass with FractionalScrollOffsets enabled. Bug: 414283 Change-Id: Ief639a780d0780ab74ca11718c05921ed8a4670d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690221 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#676135}
-
Andrew Grieve authored
This checks in a .txt copy of the broken license. Also enables a --debug flag to debug issues like this in the future. Bug: 982846 Change-Id: I015e7d0a1155d3d5cc55b9a1556b2ce5ec706d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695817 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#676134}
-
Adam Raine authored
Added extra test statements to detect if a CSSPaintImageGenerator is notified before all the registrations and cross thread checks are finished. Follow up to: https://chromium-review.googlesource.com/c/chromium/src/+/1688641 Bug: 948761 Change-Id: Ia82fd1390465a96fbd97e4c0c7016f894fe0dd77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689784Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Adam Raine <asraine@google.com> Cr-Commit-Position: refs/heads/master@{#676133}
-
Marijn Kruisselbrink authored
Actually hooking this up to a blocklist etc will be done in future CLs. See https://storage.cloud.google.com/chromium-translation-screenshots/8f6df1b3e036b7d1ff3f02ffb177ce99865ad7cb for what this dialog looks like. Bug: 968851 Change-Id: I20930d63e1e799da92dd9784678bb12f6b8e2f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680950 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#676132}
-
Jun Mukai authored
When the app list is expanded by drag, it should update the opacity of the items at the bottom of the screen. This logic has been lost as a side effect of r672145. It's a bit complicated that since the layer should be created only when it's necessary. Also UpdateControlVisibility() does not have to control the visibility of individual items, since those items are the only children of AppsGridView. Instead it updates its own visibility. This CL seems not changing LauncherDragTest performance numbers, as far as I tested in nocturne. Bug: 982404 Test: manually / ash_unittests Change-Id: I28780cdeb403724a5fefa35134261b656ce81edd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693739 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#676131}
-
