- 10 Nov, 2018 40 commits
-
-
Andrew Comminos authored
When we have a single-line definite height row flexbox with a column flexbox as its child, we always relayout all children of the column flexbox during LayoutLineItems with a zero-sized height being set. This patch leverages the definite height of the row flexbox in order to avoid a relayout of the column flexbox children. Bug: 703512 Change-Id: I1f67efff3ebc67cdcce57dce2d2567e2abe13625 Reviewed-on: https://chromium-review.googlesource.com/c/1306404Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#607090}
-
David Black authored
Previously AnswerCardContentsRegistry was used by AppList and Assistant to embed WebContents in Ash, although this would not work in Mash. Assistant used AnswerCardContentsRegistry in conjunction with WebContentsManager to embed Assistant cards. Now, we have migrated to Content Service which renders these classes no longer needed. AppList was transitioned in: https://chromium-review.googlesource.com/c/chromium/src/+/1269622 Assistant was transitioned in: https://chromium-review.googlesource.com/c/chromium/src/+/1313745 https://chromium-review.googlesource.com/c/chromium/src/+/1321861 Bug: b:78078693 Change-Id: I5b855b6ff24722524b600eb1032960210c0233f7 Reviewed-on: https://chromium-review.googlesource.com/c/1325430 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#607089}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7adddc2268b1..f768692bdef0 git log 7adddc2268b1..f768692bdef0 --date=short --no-merges --format='%ad %ae %s' 2018-11-10 tsepez@chromium.org Enable more field property tests. 2018-11-09 thestig@chromium.org Fix JS event.value behavior. 2018-11-09 tsepez@chromium.org List annots in page annotation dict for JS field tests 2018-11-09 thestig@chromium.org Add CPDF_DocRenderDataTest. 2018-11-09 tsepez@chromium.org Add better tests for AFSimple_Calculate(). Created with: gclient setdep -r src/third_party/pdfium@f768692bdef0 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idb3b239df8b74ad143fda91a02f9e838b099b3d9 Reviewed-on: https://chromium-review.googlesource.com/c/1330118Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607088}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8ecbd57f8e89..83560374fb95 Created with: gclient setdep -r src-internal@83560374fb95 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie9c10c2e2e81e1069c0d52240d329004e3ebeef5 Reviewed-on: https://chromium-review.googlesource.com/c/1330120Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607087}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2bb343c5e822..303a38c86077 git log 2bb343c5e822..303a38c86077 --date=short --no-merges --format='%ad %ae %s' 2018-11-09 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-09 reed@google.com Revert "rm legacy flags for hinting enum" 2018-11-09 jvanverth@google.com Verify YUVA channel information and add premultiplied alpha 2018-11-09 caryclark@skia.org fix bookmaker 2018-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 5d2dfa46c05c..50bf0429394d (1 commits) 2018-11-09 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@303a38c86077 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I1b7fa5d77e8098d419ced8d604972d53fbd93a12 Reviewed-on: https://chromium-review.googlesource.com/c/1330111Reviewed-by:
-
Ben Pastene authored
Will go on chromium.android.fyi, and be a copy of the O WebView bot w/ the NetworkService feature. Going to try swarming it since the L WebView bot appears to be working on swarming. I can always undo that if it doesn't work. Bug: 880623 Change-Id: Ic57bce51c3c70325a2b4038976bb85552723fd0e Reviewed-on: https://chromium-review.googlesource.com/c/1327414Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#607085}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ffec6a8edd68..7dbd8f071016 git log ffec6a8edd68..7dbd8f071016 --date=short --no-merges --format='%ad %ae %s' 2018-11-09 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@7dbd8f071016 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Iefa53c29d7aea2c277980ca6c05fe33dbd6f2d92 Reviewed-on: https://chromium-review.googlesource.com/c/1330767Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2b973a56..9d6971eb Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic6efee8344158737ea1a4a725f01e7ff9f412128 Reviewed-on: https://chromium-review.googlesource.com/c/1330832Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607083}
-
Ken Rockot authored
Changes Identity's instance ID field from a free-form string to a base::Token. Prior to this change, the default instance ID was the empty string. Now it's a zero-valued token. BindInterface attempts which do not specify an instance ID implicitly connect to the instance with a zero-valued instance ID. All usage of GUIDs where relevant to instance isolation (namely media CDM and various data decoder helpers) have been changed to Tokens. Bug: 895591 Change-Id: Id14c19402f0fd924a2f467bee40860293a5abe16 Reviewed-on: https://chromium-review.googlesource.com/c/1327526 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#607082}
-
Owen Min authored
profiles::OpenBrowserWindowForProfile uses IsSigninRequired flag as a hack to unblock all extensions during Profile unlocking process. Remove the hack and add a new parameter to unblock all extensions. IsSigninRequired needs to be set to false before open the browser window. If not, UserManager will be shown with selected Profile. Bug: 901430 Change-Id: I959dc21daa92f29bca7a279563015b168256762b Reviewed-on: https://chromium-review.googlesource.com/c/1327236 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#607081}
-
Khushal authored
Transfer cache is the OOPR equivalent of a shared image cache for all renderers. Make sure it uses the same budget. Also cleanup for transfer cache entry types which are not used anymore. R=ericrk@chromium.org Bug: 903775 Change-Id: I48741f1c8385eb64cf1a9f34f06a63673ee3d7c3 Reviewed-on: https://chromium-review.googlesource.com/c/1330763Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#607080}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 899324 Test: none Change-Id: I997296b1712ddebfe3ceacc69aa25e8b5fed4395 Reviewed-on: https://chromium-review.googlesource.com/c/1330835 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#607079}
-
Alexei Filippov authored
Place timing markers next to each other rather that make them overlap. BUG=901165 Change-Id: Iac9d544d6b5e5238767c3451aa9ace9f27126cc9 Reviewed-on: https://chromium-review.googlesource.com/c/1324378 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#607078}
-
Jon Kunkee authored
This commit is otherwise empty because the corresponding contributions are in other repos. Bug: 893460 Change-Id: I95ae29c6293e52da62573ae6f6e9a10f31fc48c9 Reviewed-on: https://chromium-review.googlesource.com/c/1330793Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#607077}
-
Sam McNally authored
DriveIntegrationService uses NetworkConnectionTracker to detect that it's offline and should defer retrying DriveFS mounting until that changes. This works well for no network at all, but doesn't handle isolated networks or captive portals. NetworkPortalDetector does handle these cases so use it instead for deciding whether to defer retries until online again and for detecting when it is online again. Bug: 902771 Change-Id: Ic3b84305b0fc8927b2b1ac64ee9c28a12b07a20a Reviewed-on: https://chromium-review.googlesource.com/c/1325574 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#607076}
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: Ifd7489aeeef3f7249f9d0c7c56456c6d0bb3f445 Reviewed-on: https://chromium-review.googlesource.com/c/1328635Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#607075}
-
Martin Kreichgauer authored
This adds a UserVerificationRequirement enum field to CtapMakeCredentialRequest. The existing "effective" user verification bool is removed and the computation of the effective value (required vs discouraged) is moved into FidoDeviceAuthenticator, in parallel to how this is handled for GetAssertion requests. This change makes the full uv requirement available to the Windows authenticators, and at the same time fixes a bug for device authenticators where requests with uv="preferred" would result in CTAP device requests with uv=false even for authenticators with UV support. Also rename CtapMakeCredentialRequest::resident_key_supported() to resident_key_required(). Bug: 898718 Change-Id: I80ba3f052f871dce711c15ed8659812ad7cab10b Reviewed-on: https://chromium-review.googlesource.com/c/1324379 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#607074}
-
Steven Bennetts authored
This CL updates a couple of browser tests to use ChromeKeyboardControllerClient instead of direct calls into ui/keyboard to simplify DEPS exceptions. Bug: 876138 Change-Id: I7874cee278a3b9439efb4e4056390951eac6705c For keyboard specific changes to c/b/policy and c/b/ui/views tests: TBR=sky@chromium.org Change-Id: I7874cee278a3b9439efb4e4056390951eac6705c Reviewed-on: https://chromium-review.googlesource.com/c/1316248 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#607073}
-
John Budorick authored
This reverts commit 32758758. Reason for revert: causes compile failures on windows similar to the ones that appeared in the CQ runs, e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win%20x64%20Builder/58688 Original change's description: > Remove menu_marker from MenuButton. > > This is always false except for in tests and menu_example.cc which is > not used. This helps simplify MenuButton for the Button cleanup task. > > Bug: 901183 > Change-Id: If5a3cf7b6ba1ce5618548d112df1c4404b2ae181 > Reviewed-on: https://chromium-review.googlesource.com/c/1324375 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Commit-Queue: Charlene Yan <cyan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607061} TBR=msw@chromium.org,flackr@chromium.org,oshima@chromium.org,tapted@chromium.org,cyan@chromium.org Change-Id: I9c311a3c8cea56c7670b2dace3e0410618151034 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 901183 Reviewed-on: https://chromium-review.googlesource.com/c/1330841Reviewed-by:
-
Ben Pastene authored
This reverts commit 4971af60. Reason for revert: "ImportError: No module named httplib2" on CQ bots https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.ci/Headless%20Linux%20%28dbg%29/70541 Original change's description: > infra: remove no longer needed LUCI options. > > They became the default ones, no need to specify them. > > R=iannucci, vadimsh > > No-Try: True > Change-Id: Iebc66d8291fdebab72fcdb334e26befdc6d90bf3 > Reviewed-on: https://chromium-review.googlesource.com/c/1330288 > Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607024} TBR=iannucci@chromium.org,vadimsh@chromium.org,tandrii@chromium.org Change-Id: Iee3d547f36dd6d583be555d6b35a3067ef592db4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1330840Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#607071}
-
Sunny Sachanandani authored
LayerTreeHostContextTestLayersNotified was changed recently to attach root layer after first activation, but it does a static_cast on impl layers before the layers are propagated to impl tree. Bug: 903931 Change-Id: I824a5fe5f9915156090098f7c8b2306c32a9db23 Reviewed-on: https://chromium-review.googlesource.com/c/1330722 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#607070}
-
Andrew Comminos authored
Test that propagated definite heights of flexboxes avoid a reflow of wrapping text. With the definite height optimization, the benchmark runs twice as fast in my local testing. Bug: 703512 Change-Id: Ib5fbf14c90735504007883c874e71f7461fe1d11 Reviewed-on: https://chromium-review.googlesource.com/c/1330289Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#607069}
-
Sorin Jianu authored
The "required" attribute name in the update manifest is ignored by the update checker, and it can be removed to eliminate confusion and for simplicity reasons. This has been discovered when implementing the updater JSON protocol. Bug: 881076 Change-Id: Ie8ad8ad816c380375d85b6402f1270f21d7b3b20 Reviewed-on: https://chromium-review.googlesource.com/c/1330700Reviewed-by:
Minh Nguyen <mxnguyen@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#607068}
-
Christian Biesinger authored
R=ikilpatrick@chromium.org Change-Id: I8671ab92cb0c043dc9a3dc3509d92586ee78779c Reviewed-on: https://chromium-review.googlesource.com/c/1330829Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#607067}
-
Tarun Bansal authored
In incognito profiles, do not predict the next navigation, either at the time of load, or at the time of element click. Bug: 899406 Change-Id: Iccddf772ed8fc5de63233e427e7eab35d8a3f20c TBR: ryansturm@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1330702Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#607066}
-
Christian Biesinger authored
It needs to return at least border_scrollbar_padding_, or else this can lead to a DCHECK failure in ng_length_utils.cc Found by running ScrollbarsTest.AutosizeAlmostRemovableScrollbar with LayoutNG enabled. R=ikilpatrick@chromium.org, mstensho@chromium.org Change-Id: I9635ef98274bf573151756d19b3879fb6d33080a Reviewed-on: https://chromium-review.googlesource.com/c/1330348Reviewed-by:
-
Mason Freed authored
Change-Id: Icf9fd7a9ebd1f9753ef2e26d74bb91bd9598650f Reviewed-on: https://chromium-review.googlesource.com/c/1330697Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#607064}
-
Jao-ke Chin-Lee authored
Bug: 790286,790294,790309 Change-Id: I78efe19f06591cb2964068ab290a5f1b6856b65b Reviewed-on: https://chromium-review.googlesource.com/c/1330357Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#607063}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 899324 Test: none Change-Id: I00093b332711218ac96cca78fdfe17ab8ae7f1e7 Reviewed-on: https://chromium-review.googlesource.com/c/1330720Reviewed-by:
-
Charlene Yan authored
This is always false except for in tests and menu_example.cc which is not used. This helps simplify MenuButton for the Button cleanup task. Bug: 901183 Change-Id: If5a3cf7b6ba1ce5618548d112df1c4404b2ae181 Reviewed-on: https://chromium-review.googlesource.com/c/1324375Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#607061}
-
Oystein Eftevaag authored
Pass JSON strings to the callback (and hence Mojo) once they reach 100kb, rather than passing one giant string all at once. BUG=902064 Change-Id: If95811d3ac907d23d2f882e869d88e933ff5d7b0 Reviewed-on: https://chromium-review.googlesource.com/c/1330068 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#607060}
-
Min Qin authored
As we moved the download id generation logic to DownloadManagerImpl, but incognito download is still using regular profile's DownloadManagerDelegate to generate the id. So it is possible that incognito download may have the same id as a regular download. In theory this shouldn't be an issue as incognito and regular download belongs to different DownloadManagerImpl. However, Chrome's download home and extensions use id to uniquely identify a download. Thus causing the issues when accessing these downloads from the download home and extensions. BUG=902336 Change-Id: I3591153e4f453c75d4877f5ce1088c096d3edf1e Reviewed-on: https://chromium-review.googlesource.com/c/1330214Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#607059}
-
John Budorick authored
This CL: - renames "Fuchsia {ARM64,x64} Cast Audio" -> fuchsia-{arm64,x64}-cast - renames fuchsia_{arm64,x64}_cast_audio -> fuchsia-{arm64,x64}-cast - drops is_cast_audio_only=true from all of the above Requires crrev.com/c/1325090 Bug: 877264 Change-Id: I4cf02d4719caf3ec7fff43b51f77ce64b644d7f8 Reviewed-on: https://chromium-review.googlesource.com/c/1324457Reviewed-by: -
Ken Rockot authored
Changes Identity's instance group ID from a free-form string to a base::Token. Updates the 25-billion things which depend on this field. Some more details: - This removes kRootUserID in favor of a new C++ constant, kSystemInstanceGroup, a base::Token with a more approrpiate name given its purpose. - Also removes kInheritUserID. Because the instance group field is optional in an outgoing request Identity, nullopt is used to mean "inherit". - Not all conceptual references to "user ID" have been removed yet, since this CL is big enough as it is. For example, we still have a test-only service name "user_id", which no longer makes sense. Follow-up CLs will also change the instance ID field to a Token and clean up remaining conceptual references to "user ID". Bug: 895591 Change-Id: Idef13a269c6935123db68fa2621cecaca345974c Reviewed-on: https://chromium-review.googlesource.com/c/1325944 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Daniel Rubery authored
Since the original request may have been cancelled, the original_request_url is not reliable, and should be overwritten with the search_url in referrer chain attribution. Bug: 903996 Change-Id: Ie04f9fe60665ebae83054eccdab0719d0840721c Reviewed-on: https://chromium-review.googlesource.com/c/1330754 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#607056}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 899324 Test: none Change-Id: I7c06a44ad5aa7bc3dc9ff2249fa819551b942088 Reviewed-on: https://chromium-review.googlesource.com/c/1330807 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
-
Yue Li authored
Bug: b/116166191 Test: Local build Change-Id: I0d4280ea21a194d7f37df95fa269781f758a24d2 Reviewed-on: https://chromium-review.googlesource.com/c/1330787Reviewed-by:
-
Christian Biesinger authored
I have to use N?G? instead of (NG)? because gtest does not support the latter on Windows. R=chrishtr@chromium.org Change-Id: Ia62d1ec85447a351b8abc341203c3dcdc17fc63b Reviewed-on: https://chromium-review.googlesource.com/c/1330695 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#607053}
-
Eric Karl authored
Previously, we'd rely on an ApplicationStatusListener to deliver background notifications. This was racy with sending the synchronous command to tear down the RootCompositorFrameSink / Display, and if it failed to trigger before teardown, we'd fail to disable the watchdog for the expensive teardown operation. This change ensures we always send the background signal before tearing down the Display / RootCompositorFrameSink. Bug: 899705 Change-Id: I2b5e5787f94ab1f392c5ec4c4063ef6664de2a3f Reviewed-on: https://chromium-review.googlesource.com/c/1327468Reviewed-by:
-
James Hawkins authored
R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: I45d7f04e97a914596cd1bffd5e2ea73543064810 Reviewed-on: https://chromium-review.googlesource.com/c/1329889 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
-
