- 28 Aug, 2020 40 commits
-
-
Marijn Kruisselbrink authored
This reverts commit e0309342. Reason for revert: doesn't compile on for example https://ci.chromium.org/p/chrome/builders/ci/win-chrome/14113 ../../chrome/browser/ui/webui/policy_ui_handler.cc(1298,30): error: no viable overloaded '=' updater_status_provider_ = std::make_unique<UpdaterStatusProvider>(); ~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../buildtools/third_party/libc++/trunk/include\memory(2551,15): note: candidate function not viable: 'this' argument has type 'const std::unique_ptr<PolicyStatusProvider>', but method is not marked const Original change's description: > Policy WebUI: 'Reload Policies' button reloads google update policies > > Bug: 1119703 > Change-Id: Ib91b37dc1da4f06782caea7b67ecc6d0c8c87b2d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367673 > Commit-Queue: Yann Dago <ydago@chromium.org> > Reviewed-by: Owen Min <zmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802644} TBR=zmin@chromium.org,ydago@chromium.org Change-Id: I6c3b3bb79801e5aae68ab97f5ba79e5b8d10509a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1119703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381300Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#802668}
-
David Landell authored
The patch set in https://crrev.com/c/2267919 refactored the processing of additional_readme_paths.json files but introduced the change that such paths will be absolute instead of relative to the root. Other paths found by walking the directory tree are relative. This makes such additional paths relative. Bug: N/A Change-Id: Ia2b8cfe99d5e704ed423a17f791aea43a94a8d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379771 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#802667}
-
Noah Rose Ledesma authored
This change adds an action to the MediaSessionAction enum for signaling if audio output device switching is possible for that session. A session supports switching audio devices if and only if the session has at least one player and all of the players support audio device switching. When the audio output device cannot be changed, the Global Media Controls UI should not display a device picker. This change is a part of a series of changes for appropriately hiding this UI. Bug: 1120620 Change-Id: If03ef110ff32fa0db3463c63a6a1730da60d2278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369440 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#802666}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I43b1d1fd403bf302e7190dd5ccf3f3f21a6c3048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381595Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802665}
-
Mohsen Izadi authored
In a gesture scroll sequence, generally speaking, nothing much happens on scroll-begin and most of the interesting updates happen in response to scroll-updates. It would be useful to report event latency metrics for the first scroll-update in the sequence separately from the rest so it can be used in determining the latency of starting a scroll. This also matches the behavior of existing Event.Latency metrics which report the latency of the first scroll-update as ScrollBegin and the rest as ScrollUpdate. For now, we use LatencyInfo to determine whether a scroll-update is the first one or not. As a follow-up we will move this off of LatencyInfo and calculate it in the renderer as there is no need to pass it around between process along with the LatencyInfo. Bug: 1079116 Change-Id: I6f4181f927215226692161a365d2e42f32712193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356651Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#802664}
-
Rushan Suleymanov authored
SendTabToSelfBridge::SetTargetDeviceInfoList checks that there is recent local cache GUID in device info tracker. However it might still not be initialized during browser startup. In that case it is possible that TrackedCacheGuid() returns non-empty value and it is not in recent local cache GUID list. This leads to DCHECK vialoation. This patch adds check that device info tracker is syncing and has actual list with recent cache GUIDs. Bug: 1023457 Change-Id: I8261551859a3cf75109b3dcac9d1559a5bec4a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379733Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#802663}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d385091edd58..43c78abe0440 2020-08-28 reed@google.com Remember to track convexity/direction for IsA shapes (e.g. oval, rrect) 2020-08-28 johnstiles@google.com Fix a handful of remaining C-style casts in IRGenerator. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: Ibb8a44003c685976228be4d598b489c1a586818e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381445Reviewed-by:
-
Michael Chang authored
In testing it was observed that when the control plist and the corresponding job was removed first, uninstall did not proceed afterwards. This change reorders the control plist to be deleted last and for the plist to be deleted before the job. Bug: 1122201 Change-Id: I658e0599005d26ee5dfa4d4ec19a70124af9366f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378002 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#802661}
-
Nicholas Verne authored
To do this as cleanly as possible, added CanMinimizeDialog method to WebDialogDelegate. This is used by WebDialogView. The default return value is false. This should only be used when there is a corresponding shelf item for the dialog. Bug: 1122481 Change-Id: Id0da680c4c88ac7462f8cc3d4111cda767ea4bfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379450 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
David Munro <davidmunro@google.com> Auto-Submit: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#802660}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a1be3faad1c6..d7c4e9418e36 2020-08-28 treehugger-gerrit@google.com Merge "tp: fall back to using read() if AIO fails" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I47bcb619b0050631675c9dfa03f5db2c2f0c2867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381597Reviewed-by:
-
Sundoo Kim authored
There is no change in behavior. ui: :ImageModel should be preferred to gfx::ImageSkia. Bug: 1100034 Change-Id: If5d9d7b4a6ee7cf2fc3d39bdfa503a1ca2554d44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362495 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#802658}
-
Guillaume Jenkins authored
The current implementation of policy::GetMachineName returns a value that isn't very useful on most iOS devices (things like "J", "D", "F"). This change uses the hardware model name instead, which looks like "iPad6,11". Note that this function wasn't called on iOS before CBCM cloud reporting, so there shouldn't be any side effect. Bug: 1122130 Change-Id: Ib6a48e29175c57abcb6809ecbdf9a0c2f81c365e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380671Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#802657}
-
Guido Urdaneta authored
This CL adds verification that the deprecated additionalData field in video frames can be constructed based on the frame's metadata. Bug: 1069295 Change-Id: I9b6c06a9e6126d4461cb1c15ce8981312def07c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378310Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#802656}
-
Charlie Hu authored
Change-Id: Ie794be96fd36e96ceadc3a21ac2572b8f34c604c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381133Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#802655}
-
Rob Buis authored
Set rspace internal style property instead of lspace. Bug: 6606 Change-Id: If9d3fe5c2bb233dda789868467e11be20e7f25d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379683Reviewed-by:
Frédéric Wang <fwang@igalia.com> Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#802654}
-
Alex Ilin authored
This reverts commit bee04852. Reason for revert: culprit for WebView test failures in https://crbug.com/1122996 Original change's description: > WebShare: Enabled for Android in runtime_enabled_features.json5 > > runtime_enabled_features.json5 previously only had a comment indicating > WebShare is shipped on Android. > > Change-Id: I9eac95bfb77aef8154cd637a089b528568a7c38f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379422 > Commit-Queue: Kentaro Hara <haraken@chromium.org> > Auto-Submit: Eric Willigers <ericwilligers@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802542} TBR=ericwilligers@chromium.org,haraken@chromium.org Bug: 1122996 Change-Id: I0ecf0b8df2a23825214188f7d3c16d531269c99f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379920 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#802653}
-
Mike Reed authored
See https://skia-review.googlesource.com/c/skia/+/313837 Bug: skia:10670 Change-Id: Ibe6a918abf3f43741bdf24977c7850323cb017df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381256Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#802652}
-
Gauthier Ambard authored
This CL adds gambard as OWNER for ios/chrome/browser/ui. I have contributed to multiple refactoring and features work in the directory. Bug: None Change-Id: I0bc3c723cae43c6ab5be80db566d43062ea0b9ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380284Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#802651}
-
Maksim Moskvitin authored
This CL adds access token fetching functionality, that can be used on trusted vault backend sequence. Implementation consists of: TrustedVaultAccessTokenFetcherFrontend: * this class must be used on the UI thread * it allows asynchronous access token fetching * it supports multiple ongoing FetchAccessToken() calls (e.g. the method can be called before |callback| passed to the previous one was run) * it observes primary account changes and reply with empty access token to callbacks which correspond to non-primary account TrustedVaultAccessTokenFetcherImpl: * created on the UI thread and its ownership transferred to the backend sequence * plumbs backend FetchAccessToken() attempts to the frontend * handles invalidation of TrustedVaultAccessTokenFetcherFrontend WeakPtr Bug: 1113597 Change-Id: I72d5962c374b3141d8a20a2ad2a4b42a378bbfde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379734 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#802650}
-
Alex Ilin authored
This reverts commit 7d8ab070. Reason for revert: NavigationBrowserTest.DestroyTabInNavigation fails on Android P, https://crbug.com/1123021 Original change's description: > weblayer: make it possible to delete tab in OnNavigationFailed... > > and OnNavigationCompleted. > > Content does not allow WebContents to be deleted from > WebContentsObserver::DidFinishNavigation(). Unfortunately we > keep seeing crashes because of this restriction, so I'm > inclined to provide some mitigation. > > This patch takes the approach of detecting this scenario > and delaying deletion of the WebContents. All the surrounding > WebLayer classes are deleted/destroyed and ownership of the > WebContents is passed to the Profile and deleted from a > post-task. > > Doing this may introduce it's own set of problems. For example, > if a callback/notification is still in flight from content that gets > processed before the deletion, and the code assumes there is a Tab > associated with the WebContents, then there will be problems. > > My preference is still to fix this in content, but in the mean > time this should work. > > BUG=1111127 > TEST=covered by test > > Change-Id: I9dbd9f90b88cbdbdfbab9aab81840b986fcdc410 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377552 > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802416} TBR=sky@chromium.org,jam@chromium.org Change-Id: I3a52b345d649e48ae0d9b6a4e480cf602214d2c4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1111127, 1123021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380657Reviewed-by:
-
Brendan Shanks authored
When running 64-bit Windows binaries on macOS using Wine, there is a conflict between macOS's use of GS to point to pthread thread-specific data, and Windows' use of GS to point to the TEB. Apple has reserved some TSD slots for use by Wine to store commonly-used TEB members (such as 0x30, the 'Self' pointer to the TEB). But, other direct GS accesses by Windows programs (such as to 'StackBase') will return macOS pthread data rather than the TEB member. This was causing 64-bit Chrome to crash on macOS under Wine. Using NtCurrentTeb() gets the 'Self' pointer first, then dereferences it to access the correct 'StackBase', fixing the crash. This turns GetStackStart() from one instruction into two. Crashpad also uses NtCurrentTeb(). The 32-bit change isn't needed, but is just for consistency. Bug: 1121842 Change-Id: Id794030eb22b292530865f940bef8f0705bfd542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380425 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#802648}
-
Fredrik Söderqvist authored
Add forward declarations for almost all SVGAnimated* types - the notable exception being SVGAnimatedEnumeration, which because of its templated setup is slightly more complicated to deal with. Switch SVGScriptElement to using LegacyHrefString() - which it can do because its 'href' reference should not be animated (this enforces this even more strictly). This allows making SVGURIReference::href() return a SVGAnimatedString rather than the slight more specific SVGAnimatedHref, allow the latter to be forward declared as well. Change-Id: I6e48226520c8e7e800c971111e8ddbb1a2d09611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379835Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#802647}
-
Renato Silva authored
Make the PIN input field on the login screen read only during an authentication attempt. Correctly focus the PIN input field when the login screen is shown. Bug: 663982, 1122694 Change-Id: Ib7f25e190281ce78ca9e33d19c06e4e574c7ef6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379772Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#802646}
-
Marc Treib authored
Bug: none Change-Id: I5d0aedcef0e54707c3f10376b2ca48524353358a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379895 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#802645}
-
Yann Dago authored
Bug: 1119703 Change-Id: Ib91b37dc1da4f06782caea7b67ecc6d0c8c87b2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367673 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
-
danakj authored
This moves a big chunk of BlinkTestRunner out to TestRunner (for global stuff) or WebViewTestProxy (for stuff tied to each view for now). R=avi@chromium.org Bug: 866140 Change-Id: Ife09e15ed65abedfeb462546bfb0fb0498d8b32d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378635Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#802643}
-
Ben Mason authored
This reverts commit dbecad0d. Change-Id: I032d41a62c0a0072bab3383404604d1ea572b7cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375690Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#802642}
-
Bill Carr authored
Updating the expiry date and ownership for Net.MediaCache.Response.EnabledOrDisabled histogram. Bug: 1109936 Change-Id: Ifa13dc1de3aad161387a29fb4386aaad34836db7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380740 Auto-Submit: William Carr <wicarr@microsoft.com> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#802641}
-
Ben Mason authored
This reverts commit 2cb22072. Change-Id: Idf50820ec0e3898bf0e6bc722315e4aa7931d56e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375929Reviewed-by:
-
Jan Krcal authored
This CL tweaks the logic on startup that decides whether the profile picker should be displayed. After this CL, it is skipped in these cases: - Guest mode is requested, - a incognito window is requested, - a concrete profile is requested (such as by Windows shortcuts), - a notification for a concrete profile is handled (Win), - a concrete URL is requested. Bug: 1122553 Change-Id: I1b3cbdf4ef74b84ffe687978b6b293e9e6ff4e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379913 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#802639}
-
Alan Cutter authored
This CL is a mechanical change that renames launch_url to start_url in the WebAppSpecifics proto. This is to make "start_url" more closely match the app manifest field and to make room for a separate "launch_url" in a follow up CL that includes additional query params added to the start_url. Bug: 1045537 Change-Id: I76c079d3b2b930ecc781536b95977591529b2438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374189 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
Oleh Lamzin authored
Bug: b:158658869 Change-Id: I7ecc0518bedfdea0768f6e47d50864dd9e29c73c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377982Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#802637}
-
Benoit Lize authored
The direct-mapped allocations' metadata layout was only explained in comments, but relied upon in several places. Document it by introducing a new struct for the metadata. Note that the comments were previously wrong, and the layout strange as well: there was a hole in the metadata (in the new struct, this would be equivalent to adding an empty PartitionPage-sized hole before |direct_map_extent|). This was not a correctness issue as the whole page can be used for metadata, but is still confusing, undocumented and strange. Also removes an outdated comment which came as part of a rebase in https://chromium-review.googlesource.com/c/chromium/src/+/2335443 in the unit tests. Bug: 787153, 1092288 Change-Id: Ibe0024ac94008ad94b3706d9f9bd754b6f07977f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379912 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#802636}
-
Eric Willigers authored
The web-share policy is currently only for use counters https://groups.google.com/a/chromium.org/d/msg/blink-dev/fgme9KOd8CU/0xJW9MAPAgAJ We ensure it is not visible by introspection using document.featurePolicy Bug: 1121034 Change-Id: I3ff271efa45eca43055e975fefc4a8db43960b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371447Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/33a6332a9232..a1be3faad1c6 2020-08-28 fmayer@google.com Merge "Make all wire protocol structs stable across ABI." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0c445e61ab026dfbfc2e6655aca14ca3ee525dc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381442Reviewed-by:
-
Antonio Gomes authored
This is a follow up of https://crrev.com/c/2353116 ([ozone/wayland] zaura_shell initial support). BUG=1113900 R=msisov@chromium.org Change-Id: I547f66e49e8ae4161ed15a7359f91b8b7ea17019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381253Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#802633}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fde4d2f7457e..5c8601ed8285 2020-08-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from cac2574c240a to af56d31487bb (5 revisions) 2020-08-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 0654095b63fb to d846ea5a2427 (4 revisions) 2020-08-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from c472fa2f0330 to 1b0bbd1550ed (1 revision) 2020-08-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 1f48854dae26 to ec3650f56ca2 (1 revision) 2020-08-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from bceab9fab4bc to 08291a3a9e22 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I78c4b1bc7430b4ddda789f58473ee7828bc1b4a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381438Reviewed-by:
-
nohe@chromium.org authored
This adds a ChromeOS feature flag disabled-by-default. This will allow users the capability to copy images to the clipboard as an experiemental features from the ChromeOS Files App. This will be enforced in the javascript chrome.fileManagerPrivate API. Bug: 827333 Change-Id: Ic04ebd75ac2d38e527f2682fbe1ab4a87c644853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375702 Commit-Queue: Alexander Nohe <nohe@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#802631}
-
Hans Wennborg authored
TBR=thakis Bug: 1122969 Change-Id: Iee48f90cb68ea8088101bfdf37b432f99729af95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380655Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#802630}
-
Yunke Zhou authored
Bug: 1122717 Change-Id: I960a3bdffda9f0a2f19cca30dfc6c15acdb33dd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379842 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
-
