- 08 Sep, 2014 2 commits
-
-
jrummell authored
To support CDM_6, make the following changes: - add SetServerCertificate - add GetUsableKeyIds - rename ReleaseSession to CloseSession - add RemoveSession - add SessionKeysChange event - add SessionExpirationChange event Includes changes to cdm_adapter for the new functionality. Changes to use these new interfaces in blink in a future CL. BUG=358271 TEST=existing EME tests still pass + manual testing Review URL: https://codereview.chromium.org/496143002 Cr-Commit-Position: refs/heads/master@{#293672}
-
cjhopman authored
The content_shell_apk does not have the full native part that it should. It builds, installs, starts, loads the native library, and then crashes when it tries to access missing native parts. This requires fixes to a bunch of little things: 1. Should only extract java files to compile from srcjars. 2. The way we were creating the single combined resources zip was wrong because we were clobbering xml files (we should only clobber images, xml files need to be handled more carefully). Instead of trying to properly handle xml files, the combined zip now just puts all the different dependencies in different folders (0/, 1/, etc) and then when packaging we detect that type of zip and pass all the subdirs to aapt. 3. java_cpp_template with multiple sources needs to have a unique depfile path for each source 4. jni_generator needs to clear the classlist variable in each loop of foreach (otherwise gn complains about assigning to non-empty list) 5. a couple parts of apk native lib handling was not skipped for an apk with no native lib This adds a bunch of targets: //base:base_java_test_support //content/public/android:content_java_resources //content/public/android:content_java //content/public/android:content_strings_grd //content/public/android:gesture_event_type_java //content/public/android:page_transition_types_java //content/public/android:popup_item_type_java //content/public/android:result_codes_java //content/public/android:selection_event_type_java //content/public/android:speech_recognition_error_java //content/public/android:top_controls_state_java //content/public/android:screen_orientation_values_java //content/public/android:content_gamepad_mapping_java //content/public/android:content_jni_headers //content/shell/android:content_shell_jni_headers //content/shell/android:libcontent_shell_content_view (partial) //content/shell/android:content_shell_java_resources //content/shell/android:content_shell_java //content/shell/android:content_shell_apk_resources //content/shell/android:content_shell_apk //net/android:net_java //net/android:remote_android_keystore_aidl //net/android:net_java_test_support //net/android:net_javatests //net/android:net_errors_java //net/android:certificate_mime_types_java //net/android:cert_verify_status_android_java //net/android:private_key_types_java //net/android:net_unittests_apk (disabled) TBR=yfriedman,thestig BUG=359249 Review URL: https://codereview.chromium.org/507523002 Cr-Commit-Position: refs/heads/master@{#293671}
-
- 07 Sep, 2014 29 commits
-
-
jamescook authored
It doesn't need to run as part of Chrome's unit_tests BUG=397164 TEST=extensions_unittests Review URL: https://codereview.chromium.org/548653002 Cr-Commit-Position: refs/heads/master@{#293670}
-
jamesr authored
media/base/user_input_monitor_linux.cc depends on //ui/gfx/x and //ui/events:events_base Review URL: https://codereview.chromium.org/547533006 Cr-Commit-Position: refs/heads/master@{#293669}
-
jamesr authored
This stuff is needed to get blink linking in android. R=brettw@chromium.org,fbarchard@chromium.org Review URL: https://codereview.chromium.org/541953002 Cr-Commit-Position: refs/heads/master@{#293668}
-
sebmarchand authored
Let's let the compiler do its job :). As mentionned in https://codereview.chromium.org/532533002/ this preprocessor precondition is useless as the linker will removed the unreferenced code anyway, and this break the PGO build. TBR=magjed, tommi NOTRY=true Review URL: https://codereview.chromium.org/546043003 Cr-Commit-Position: refs/heads/master@{#293667}
-
hashimoto authored
BUG=387288 Review URL: https://codereview.chromium.org/547593002 Cr-Commit-Position: refs/heads/master@{#293666}
-
noel authored
Revert of Cast: Re-factor rtcp_sender.cc into rtcp_builder.cc and do some cleanup (patchset #3 id:40001 of https://codereview.chromium.org/513313004/) Reason for revert: Caused cast_unittest rtcp test failures on Linux Asan Lsan builders (memory leaks). http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/7132 Original issue's description: > Cast: Re-factor rtcp_sender.cc into rtcp_builder.cc and do some cleanup > > Committed: https://chromium.googlesource.com/chromium/src/+/6217e450d9e75037c62fff773c94aebe7f3ed2e6 TBR=miu@chromium.org,hubbe@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/541293004 Cr-Commit-Position: refs/heads/master@{#293665}
-
chrome-tpm authored
Cr-Commit-Position: refs/heads/master@{#293664}
-
torne authored
To support unbundled updates we need to stop depending on system libraries. Disable using the system version of libjpeg and instead link Chromium's libjpeg_turbo. This increases binary size by ~120KB. BUG=409851 Review URL: https://codereview.chromium.org/548513002 Cr-Commit-Position: refs/heads/master@{#293663}
-
skia-deps-roller authored
https://skia.googlesource.com/skia/+log/ce23aaee8dfb3dff1acc2294f775e4f3fcf002ba..9f8cab153878f6e88190c5e2ef572ee708791177 CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=fmalita@google.com Review URL: https://codereview.chromium.org/549923002 Cr-Commit-Position: refs/heads/master@{#293662}
-
megjablon authored
Removing LOG(WARNING) from DataReductionProxyUsageStats that made it in https://codereview.chromium.org/510353004/ BUG=409934 Review URL: https://codereview.chromium.org/547753003 Cr-Commit-Position: refs/heads/master@{#293661}
-
chromeos-commit-bot authored
Cr-Commit-Position: refs/heads/master@{#293660}
-
hubbe authored
Review URL: https://codereview.chromium.org/513313004 Cr-Commit-Position: refs/heads/master@{#293659}
-
thestig authored
BUG=409705 Review URL: https://codereview.chromium.org/545683003 Cr-Commit-Position: refs/heads/master@{#293658}
-
thestig authored
Review URL: https://codereview.chromium.org/535773002 Cr-Commit-Position: refs/heads/master@{#293657}
-
danakj authored
If a mask layer's width or height are larger than the max texture size, we do not use the contents of the mask layer. So if we're not going to use the contents, there's no reason to make tiles and allocate memory for them. This changes PictureLayerImpl to return an empty tile size for masks that are too large to have tiles. Then changes PictureLayerTiling to use the empty tile size as a signal to make the whole tiling an empty size. Last, we use the empty tile size to also signal not making a low res tiling, so that masks continue to not get a low res tiling if they are large. R=enne, vmpstr BUG=409984 Review URL: https://codereview.chromium.org/547463002 Cr-Commit-Position: refs/heads/master@{#293656}
-
tfarina authored
They are: - app_locale_settings.h - ui_unscaled_resources.h - webui_resources.h BUG=401588 TEST=None R=thestig@chromium.org,thakis@chromium.org TBR=darin@chromium.org Review URL: https://codereview.chromium.org/530623002 Cr-Commit-Position: refs/heads/master@{#293655}
-
andresantoso authored
behind the fullscreen and profile buttons. Calculate the maximum number of times we can show and hide the rest, similar to how it works on Linux and Windows. Also changed so that only the one active tab has a bigger minimum width (and draws the close button) instead of potentially multiple selected tabs. This also matches Linux and Windows. BUG=392137 Review URL: https://codereview.chromium.org/476313003 Cr-Commit-Position: refs/heads/master@{#293654}
-
noel authored
Revert of [Mac] Shut down connections to WindowServer before engaging the sandbox. (patchset #1 id:1 of https://codereview.chromium.org/545603002/) Reason for revert: Speculative revert: seems this change caused 135 layout tests failures on the webkit mac builders, from OSX 10.6-10.9 http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20%28deps%29/builds/30830 Original issue's description: > [Mac] Shut down connections to WindowServer before engaging the sandbox. > > The connection is only needed during sandbox warmup to initialize the default > color space. It was formerly needed by scrollbar NSAnimations, but that was > replaced via https://codereview.chromium.org/529103002/. > > BUG=397642,306348 > TEST=Manually tested on 10.6-10.10. > R=avi@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/d9707172e540487d14c53363c5d1c2151999c2d8 TBR=avi@chromium.org,rsesek@chromium.org NOTREECHECKS=true NOTRY=true BUG=397642,306348 Review URL: https://codereview.chromium.org/550763002 Cr-Commit-Position: refs/heads/master@{#293653}
-
thakis authored
BUG=411648 TBR=hans@chromium.org Review URL: https://codereview.chromium.org/548083002 Cr-Commit-Position: refs/heads/master@{#293652}
-
skia-deps-roller authored
https://skia.googlesource.com/skia/+log/a1ae66d252edf6da932caed1fe43d11216e56c0e..ce23aaee8dfb3dff1acc2294f775e4f3fcf002ba CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=fmalita@google.com Review URL: https://codereview.chromium.org/550743002 Cr-Commit-Position: refs/heads/master@{#293651}
-
huangs authored
In https://chromiumcodereview.appspot.com/473583002/ we removed a 'shadow' element in thumbnail <iframe> to improve customization. A side effect is that this exposes the thumbnail image, thereby alow the user to futilely access the chrome-search://thumb/#/# image below. This CL adds back a transparent "blocker" in front of the thumbnail to restore old behavior. Also making 2 CSS changes to: - Fix fake box text positioning for RTL. - Move top-margin back from #ntp-contents to #logo, for correctness. BUG=411005 Review URL: https://codereview.chromium.org/542033002 Cr-Commit-Position: refs/heads/master@{#293650}
-
ListeDeGarde authored
BUG=411565 Review URL: https://codereview.chromium.org/549723002 Cr-Commit-Position: refs/heads/master@{#293649}
-
rch authored
BUG=411473 TBR=rtenneti@chromium.org Review URL: https://codereview.chromium.org/554453002 Cr-Commit-Position: refs/heads/master@{#293648}
-
vitalybuka authored
Should help to investigate sandbox failures on user side. Logs from the attached bug have records about failed start of utility process, but without clues about cause. BUG=408184 Review URL: https://codereview.chromium.org/546903002 Cr-Commit-Position: refs/heads/master@{#293647}
-
brettw authored
Content/public/app was messed up and didn't link everything properly, so this separates it out into browser and child like content/app is. R=jamesr@chromium.org Reland of https://codereview.chromium.org/545313002/ but with public/utility dependency added TBR=jamesr@chromium.org Review URL: https://codereview.chromium.org/549863004 Cr-Commit-Position: refs/heads/master@{#293646}
-
chrome://helpvitalyp authored
Typecheck chrome://help using CompilerPass.java, everything except dependency to options and Element.prototype.contains(Node) R=dbeam@chromium.org BUG=393873 TEST=GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/help/compiled_resources.gyp && ninja -C out/Default Review URL: https://codereview.chromium.org/443553002 Cr-Commit-Position: refs/heads/master@{#293645}
-
jamescook authored
It doesn't need to run in Chrome's unit_tests suite. BUG=397164 TEST=extensions_unittests Review URL: https://codereview.chromium.org/546933002 Cr-Commit-Position: refs/heads/master@{#293644}
-
jamescook authored
They don't need to run in Chrome's unit_tests BUG=397164 TEST=extensions_unittests Review URL: https://codereview.chromium.org/545293002 Cr-Commit-Position: refs/heads/master@{#293643}
-
benm authored
Also ensure that if we don't post the callback to the java side to run the js dialog callback in the embedding app that we run the callback. BUG=411399 Review URL: https://codereview.chromium.org/545963002 Cr-Commit-Position: refs/heads/master@{#293642}
-
- 06 Sep, 2014 9 commits
-
-
ajwong authored
BUG=405765 Review URL: https://codereview.chromium.org/546673002 Cr-Commit-Position: refs/heads/master@{#293641}
-
tnagel authored
Rename private methods for consistency: Start*() for something that invokes an async operation and Handle*() for something that gets called back by such an operation. That leaves On*() reserved for observers. Also update some comments. Lastly, use the current state key from the parameter passed to HandleStateKeysResult() instead of requesting it again from the broker (line 222). EnrollmentHandlerChromeOS and EnrollmentScreen: Don't report metrics on unreached code paths. Generally, remove some obsolete instances of NOTREACHED() after switches over enums: The compiler ensures that all enum values are covered, there's no need to complicate the code by checking the same thing again. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290841 Review URL: https://codereview.chromium.org/465413002 Cr-Commit-Position: refs/heads/master@{#293640}
-
jaekyun authored
On android platform, it often fails to fetch searchdomaincheck url right after network changes because of conflict between DNSObserver::OnDNSChanged event and NetworkChangeObserver::OnNetworkChanged event. This patch enables re-fetching when such conflict happens. BUG=407442 Review URL: https://codereview.chromium.org/544833002 Cr-Commit-Position: refs/heads/master@{#293639}
-
brettw authored
Currently this is either a list or a string. However, this is causing some problems because templates can't add to the invoker's visibility list without knowing if the original is a string or a list. In an effort to make this consistent, I'm converting all visibiltiy to be lists, and will remove support for strings in a future build. This exempts cld from header checking since it was confusing GN's header checker. It adds a ppapi header target as well that will be used by libyuv (that requires a roll). TBR=scottmg Review URL: https://codereview.chromium.org/544423002 Cr-Commit-Position: refs/heads/master@{#293638}
-
ahest authored
chrome.tabs.onUpdated may fire when the listener is not set up yet. BUG= Review URL: https://codereview.chromium.org/537953002 Cr-Commit-Position: refs/heads/master@{#293637}
-
chrome://settingsvitalyp authored
R=dbeam@chromium.org BUG=393873 TEST=GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/options/compiled_resources.gyp && ninja -C out/Default | grep WARNING Review URL: https://codereview.chromium.org/517413002 Cr-Commit-Position: refs/heads/master@{#293636}
-
Nico Weber authored
BUG=411648,82385 TBR=hans@chromium.org Review URL: https://codereview.chromium.org/550713002 Cr-Commit-Position: refs/heads/master@{#293635}
-
reveman authored
content: Make sure GpuProcessHost replies to all outstanding CreateGpuMemoryBuffer requests when GPU process dies. BUG= R=piman@chromium.org Review URL: https://codereview.chromium.org/547073002 Cr-Commit-Position: refs/heads/master@{#293634}
-
oshima authored
BUG=None Review URL: https://codereview.chromium.org/542413002 Cr-Commit-Position: refs/heads/master@{#293633}
-