- 08 Sep, 2020 40 commits
-
-
David Black authored
This CL: * Adds drag-and-drop behavior to holding space views * Adds a new base class for holding space browsertests * Adds browsertests to verify drag-and-drop behavior Still TODO: * Add drag image Bug: 1124581 Change-Id: I4a2e7fe63b26b10b7a7563adcfe7569d095ea7fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392263 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#805094}
-
Becca Hughes authored
The NTP team have raised concern with loading data on the NTP that takes a few seconds so this adds a feature that will load the data the first time but hide the module and then on the second load and beyond show the cached data. BUG=1121360 Change-Id: Ib1288dfccc026c5a6b37814c32a1d0561bfded0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393176Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#805093}
-
Sammie Quon authored
Adds a way to pipe data from WmGestureHandler -> DeskController -> DeskAnimationBase -> RootWindowDeskSwitchAnimator in preparation for the touchpad continuous desks gestures feature. This CL will remove the touchpad animation temporarily, if the feature is on, but will still switch desks. Done in this CL: 1) WmGestureHandler uses different path if the feature is enabled. 2) DesksController has 3 new functions for WmGestureHandler to use. 3) DesksAnimationBase has Update and End functions. Test: manual, with and without feature Bug: 1111445 Change-Id: I08af31452a6614de3d72c42433d1dde8b5704cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388276 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#805092}
-
Dan Harrington authored
This was testing code previously removed Bug: 1115745 Change-Id: I68ce48491f7529c88ab29a915837eedb5b8bfc88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398900 Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#805091}
-
Torne (Richard Coles) authored
When we're not expecting an error but we get one, fail stating the actual error we received, not just the error count. Bug: 1106472 Bug: 1117289 Change-Id: I355b307a9dcf2ba0ecf24191541d6e74db761ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399522 Commit-Queue: Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#805090}
-
Adrienne Walker authored
Bug: 1114430 Change-Id: I8379fe033e39ffc898e8799cd3c1e1e8e1743984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393188 Commit-Queue: enne <enne@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#805089}
-
Connie Wan authored
We have approval to launch to 100% in crbug.com/1022943. Per go/finch-best-practices, enabling on ToT before launching to 100%. Bug: 905491 Change-Id: Ie3dbdab198a01289a749daf19b8495c0c41272ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398962 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#805088}
-
cfredric authored
Change-Id: I9b5a18cf21d5ee465466c0a66501ef8a6c88bc5a Bug: 1126207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398957 Commit-Queue: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805087}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c107c7e93630..0e8358a4dead If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic3ddce15183cf71efea80d9fea247a9d358473e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399017Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805086}
-
Jimmy Gong authored
- ConnectionManager exposes SendMessage to send a message through the client channel. - Adds the OnMessageReceived() to ConnectionManager's observer to notify clients of new messages from the client channel. Bug: 1106937 Test: unit_tests Change-Id: I9b2de4c7c05855deaf1ea8cebf2d01b2d4e3c69c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390972 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#805085}
-
Pranav Batra authored
Add unit tests for SettingsToCupsOptions() in printing_context_chromeos.cc. Also refactor the code a bit to expose this function for testing. Bug: 1001398 Test: ./printing_unittests Cq-Depend: 2390967 Change-Id: Id0c0765e5ce6a3f3cde3d294afce33c9720f215a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389102 Commit-Queue: Pranav Batra <batrapranav@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#805084}
-
Etienne Bergeron authored
This CL is fixing a race condition that can happen when two threads are trying to load a DLL at the same time. The problem was that the priority boost may happen on the wrong thread (see: https://crbug.com/1124759). The solution is to add a std::atomic_bool already_loaded and set the flag when exiting the scope. It is fine that two threads enter the scope and try to load the DLL at the same time. Both thread will have and increased thread priority. R=gab@chromium.org, fdoray@chromium.org Bug: 1124759 Change-Id: I650ff99f56f1abeba6175024909cf344cad6bc61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392746Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#805083}
-
Matt Jones authored
This patch replaces the custom tab supplier used in the LayoutManager with the standard ActivityTabProvider. The fact that the top toolbar overlay now uses a 'push' model to update instead of a passive 'pull' means the tab sends the correct information immediately when ready instead of the guessing that needed to happen before. This simplifies the logic and reduces the number of tab sources. Bug: 1100332 Change-Id: I49667aebed4de36fd34be957a5fbf421e510713d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354996Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#805082}
-
Hesen Zhang authored
- This CL implements persistence layer of video tutorial metadatas. Bug: 1115755 Change-Id: Ic86d088cc0ad2934d172abc50e35f134e612f8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391932 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#805081}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6b0afc48ae3d..9d7944292456 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If390c64139c1b24b220b4c0866bb26f9e6fb0db5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399439Reviewed-by:
-
Akihiro Ota authored
This patch only changes the text content on the screen. There are no functionality changes as a result of this patch. Also, we are adding these strings so they can be tested before finalizing them as official string resources. Please see the follow-up change that implements localization: https://chromium-review.googlesource.com/c/chromium/src/+/2254345 Bug: 1124066 Change-Id: Id83e67a6b610a54627c01a395e197c760f98f094 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390959 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Auto-Submit: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#805079}
-
James Vecore authored
Adds a mojo interface and implementation that will allow the receive ui to enter high visibility mode and accep/reject incoming shares. See https://crrev.com/c/2392396 for usage. Bug: b:163148440, b:163147818 Change-Id: I141193fcd622c186f326fc158528ac62df8cf77c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391737 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
-
Owen Min authored
Disable SitePerProcessBrowserTest. TwoSubframesCreatePopupMenuWidgetsSimultaneously on Linux and Chrome OS due to flaky. Bug: 1126165 Change-Id: I56b956c03578a1ecf55e79cead3a6f1b676a379f Tbr: kenrb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399307Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805077}
-
Hans Wennborg authored
Otherwise a bad match can be chosen by longest_match, since it assumes that match[2] and scan[2] are equal when the hashes and the other bytes match. That assumption doesn't hold when using CRC hashing and a low number of hash bits (which can be set by via the 'memLevel' parameter). For example, the two hex byte sequences 2a 14 14 14 and 2a 14 db 14 have the same lower 9 bits CRC, and only differ in the third byte. This could cause longest_match to consider them as matching. This was already handled for x86; do the same for ARM and add a test. Bug: 1113596 Change-Id: I251150594264f401e4d8bc6e91b44b39998ab029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392457Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#805076}
-
Yusuke Sato authored
BUG=chromium:1085456 TEST=./testing/xvfb.py ./out/Release/chrome Change-Id: Ibdfb20f03846266033e55956d10a2552f5529640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398892Reviewed-by:
Long Cheng <lgcheng@google.com> Auto-Submit: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#805075}
-
Stephanie Kim authored
Bug: 1072012 Change-Id: Ibc69569b5dd521be8a02cfaffac469c83fe6727a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393060 Commit-Queue: Stephanie Kim <kimstephanie@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#805074}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e659214bc6cf..b6030fb2c818 2020-09-08 jlavrova@google.com Direct paint by default; remove save/translate/restore 2020-09-08 jvanverth@google.com Use Microsoft's ComPtr to wrap D3D12 objects. 2020-09-08 bsalomon@google.com Don't set BASE/MAX mip map level on PowerVR. 2020-09-08 borenet@google.com [infra] Fix Git package for Housekeeper-PerCommit-InfraTests_Win 2020-09-08 jvanverth@google.com Close disabled warning pragmas If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1123874 Tbr: reed@google.com Change-Id: I19a6d7006c94cd7ca37aa653d6d5d2f1c25a2c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399279Reviewed-by:
-
Yuly Novikov authored
This is the proper configuration in order to upload data to perf dashboard in LUCI world per bit.ly/perf-dashboard-machine-group Bug: 1126174 Change-Id: I7dee106c574a94db027c6079012dedab944998f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399441 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
Lei Zhang authored
As suggested in a private email, update the entire row for the Debian entry with more relevant and up-to-date info. Change-Id: Ifd400f8b1766de0758f4c97906e56fc318d48789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398973Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#805071}
-
Joel Hockey authored
Fixes crrev.com/c/2337411 which inadvertently changed file scheme downloads to only work when a RenderFrameHost exists. Bug: 1106995 Change-Id: I9f87c6c2b1b8719e1c78b2aa670b02ff8ac65381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397041Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#805070}
-
Arnaud Mandy authored
These files need to be accessible when running wpt outside chromium environment. see: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md#mojojs This is the first step towards making these tests pass outside the Chromium CI Bug: 1123990 Change-Id: Id96a3a2ae01beb6d9fd37eb41acad1ab0ebacf76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396219 Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#805069}
-
James Darpinian authored
Bug: 1084495 Change-Id: Iecf9fdc4a60f6e5639bd4a8b5ca465f183b80eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390961Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#805068}
-
Oleh Lamzin authored
It helps us to don't wait until OnDisconnect method will be invoked after destructing fake cros_healthd client. We can invoke OnDisconnect manually without blocking test. Change-Id: I9f0f675710f8c331fabd27ea806999599595311c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390662 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#805067}
-
Sonny Sasaka authored
The powerd battery info was designed to be a periodic signal. This was fine because the need was for low battery warning. Now that we want to display the Bluetooth battery values continuously, there is a problem where Chrome does not have the battery values after Chrome restarts (for example when signing out) until powerd's next battery poll. A workaround for this is to have an API in powerd for Chrome to request a signal for a Bluetooth device. This lets Chrome sync with powerd's battery values when Chrome starts up. This workaround will be removed when we migrate to go/bluez-battery-provider-api. Corresponding powerd change: CL:2378569. BUG=b:166530001 Change-Id: Ibceb1f44f808c6bfa9752cb62f23a8fba236b60b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378788 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
rbpotter authored
Bug: 1120279 Change-Id: I20894d22ca27fff91235b50b03d73c0445d18ed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390974 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Arnaud Mandy authored
use of test-only-api.js in preparation for launching official MojoJS support in WPT. This would not change the test results on Chromium waterfall (everything should continue to pass) or upstream WPT (tests currently fail because MojoJS isn't enabled). Bug: 1123992 Change-Id: I513e6d432f6c74a62109ea09ce0dbaeefc63b0c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391224 Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#805064}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2d00262a1459..e5882825af72 2020-09-08 cwallez@chromium.org Texture::copyImage: Correctly compare against FBAttachment If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1125354 Tbr: ianelliott@google.com Change-Id: I0cae6175b339ac151fb8066e681ad572f38ee26b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399064Reviewed-by:
-
Michael Crouse authored
This change adds a threshold for the number of rebuffer events per frame before LiteVideos stop throttling requests attached too the frame. Bug: 1111348 Change-Id: I236fd7f647f81e45114315eb3e0dcc4c0e32083e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393012 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#805062}
-
Gang Wu authored
Test flaky, disable for now and fix it later. TBR=tedchoc@chromium.org Bug: 1126145 Change-Id: Ie6b947dc7d9b1735d25c5f1e7db2fa4cb95c3e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398975Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#805061}
-
Ben Pastene authored
This adds the standard set of Tast tests to new betty-arc-r bot. But unlike other CrOS VM tests, we can't run these in GCE since the Android VM (inside the CrOS VM (inside the GCE VM)) doesn't work well on GCE. However, they could theoretically run on KVM-enabled baremetal machines in the lab, which removes the extra GCE VM layer that interferes with the tests. So we'll try running them on CrOS device hosts. A bot's device will be unused during the tests, which is unfortunate. But there's plenty of head room in the pools, and they're already running CrOS tests, so adding these fits well to their purpose in life. Bug: 1120109 Change-Id: I09e6c40935df7d95126e9848bc7f26ac70be2b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392943 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#805060}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599544645-2607fe83108ec346cd143f52f7129c53aeca332a.profdata to chrome-mac-master-1599587571-75a79fa48b42004db7f7ebb181ae53e5f370e716.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I2608647fa6fdaeaee4ed0d1e45f5886cd7b38de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399362Reviewed-by:
-
Owen Min authored
Disable RenderWidgetHostViewChildFrameBrowserTest. VisualPropertiesPropagation_DisplayMode on Mac and Linux due to flaky. Bug: 1126153 Tbr: kenrb@chromium.org Change-Id: If31a8b4ede074539f250b2869307e36add8b4c1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399302Reviewed-by:
-
Rahul Arakeri authored
This CL fixes an issue where autoscroll may be called on a scrollbar layer that is deleted. When the pointer is pressed down, an autoscroll task is scheduled to be executed after ~250ms. The task will execute if the pointer remains held down. In LayerTreeImpl::UnregisterScrollbar, DidUnregisterScrollbarLayer only gets called after both scrollbars are removed. So if you go from 2 to 1 scrollbar while an autoscroll task is queued, the autoscroll task won't get cancelled. At this point, the ScrollbarController tries to access the deleted scrollbar and that leads to an access violation. The fix here is to ensure that the call to DidUnregisterScrollbarLayer happens for each scrollbar. Bug: 1106612 Change-Id: I4f1d684830012db8fdd73258c9a9e5231807bcb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356809Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#805057}
-
Wojciech Dzierżanowski authored
Adding a player to MediaSessionImpl automatically requests the audio focus. We need to fix this up in case a paused player is added due to entering Picture-in-Picture. Bug: 1117390, 1117397 Change-Id: I1c8b69dbefe19f6d8a99a3b8d2a01fa2123a47f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387643Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#805056}
-
Liquan (Max) Gu authored
Revert CL: https://chromium-review.googlesource.com/c/chromium/src/+/2391598 Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2372888 Context: The revert was done because the waterfall had test failures. It was later found to be caused by another CL. So the original CL was wrongly reverted. This CL is to reland it without change. Bug: 978471, 1102522 Change-Id: I24bfe5815c34cd7fb2ffbcbe33f839334ac08d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392763Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#805055}
-
