- 27 Jul, 2020 40 commits
-
-
Hitoshi Yoshida authored
After shipping the new code generator for IDL dictionaries, some tests fail with accessing missing dictionary members. This CL fixes them. Bug: 839389 Change-Id: I0d09a4c73edaf5f3195872f21cefe93a65970a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310272Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#791740}
-
Alice Wang authored
This CL moves GoogleServiceAuthError from sync package to the signin component package and mirrors the fields in the native class, so that we can use it when implementing IdentityManager.Observer#onAccountsInCookieJarUpdated. Bug: 1093741 Change-Id: I2b0c9b1824e032284f6d3511d38513b6849d3838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307332Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#791739}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595807480-d008dd705c9cf90df13ad0e43c19aa435d2837a8.profdata to chrome-mac-master-1595829164-c22b50893110427f86ce6cde1b20f409df22cb84.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: Iec516c709f72f7c6d2b2f3fc8fe2dd1b8f3d3386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319977Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791738}
-
Honglin Yu authored
Also roll the edits on mojom in CL: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2291868 BUG=chromium:1086044 TEST=on device (eve), can call langid function TEST=in the chrome://machine-learning-internal webpage. Change-Id: I8abdeac7e318397069bf7961ad4ae43667df15eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289573Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Honglin Yu <honglinyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#791737}
-
sauski authored
Extends Access Context service and database to delete access records with timestamps that fall within an observed history deletion time range. Bug: 1101675 Change-Id: I49e0fdfc4d638c6d065d63a188da57ae5ab9ffca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312699 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#791736}
-
Jit Yao Yap authored
This CL merges AppListClient::OnFolderCreated() and OnPageBreakItemAdded() into OnItemAdded() which triggers when any AppList item (app, folder or page break) is added. AppListModelUpdater::OnFolderCreated() and OnPageBreakItemAdded() are merged into OnItemAdded() accordingly. Bug: 1101208 Change-Id: I5973eed4778e8fd98d04ce5b36c49bbe476b6bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306039 Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#791735}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e490afec61da..e5505fa8a8ca 2020-07-27 changhaohan@chromium.org Use filter value autocompletes for backdrop-filter If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1014289 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I92ed0560128115544cde13f9e144ab08d5267a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319969Reviewed-by:
-
Gavin Williams authored
To comply with GAR4 standards, this change adds the current error printer status to the aria-description. So when the element is navigated to in ChromeVox, the status will be announced as well. Also fixed destination and See More label by adding single quotes. This will pass the values into i18n as a string and not a variable. Bug: 1059607 Change-Id: I7a5c6e715eb056534b15295d913d85e3621b9d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317777 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#791733}
-
Alan Cutter authored
This CL fixes the web app shelf context menu to say new window/tab based on the user's launch preference rather than the app's display mode. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=458355&signed_aid=aSdrvahZRLm3LzIlT4Lw_Q==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=458354&signed_aid=mhKi9zbHVVMVIsNjtGjytQ==&inline=1 Bug: 1100016 Change-Id: I7c488be8e78fc76a73b5fd95d1d40bdcf137778e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319928 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#791732}
-
Viviane Yang authored
This change allows to save and retrieve an optional expiration time property in the PushMessagingAppIdentifier and specifically in the profile preferences. It is saved in the same preference map as the (origin, SWR id) and will be converted in a string as seconds from Windows epoch. BUG: 1104215 Change-Id: I37d7f7cbc7d4160c049d72935b7d6d9bb308170e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315682 Commit-Queue: Viviane Yang <viviy@google.com> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#791731}
-
Theodore Olsauskas-Warren authored
Enforces state of enableSecurityKeysSubpage feature flag during tests Bug: 1108551 Change-Id: I858fdb78096c31640a7ce50aa73468df58dab5e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317206Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#791730}
-
Yuzu Saijo authored
ServiceWorker has now been supported properly for bfcache, and no longer needs to be blocklisted. This CL removes the blocklisting and removes the test. Bug: 1105351 Change-Id: I3dbcefa9400fc9d443e087ac2bd7854981924c94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296553 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791729}
-
Hitoshi Yoshida authored
Defines new lists of generated files for IDL dictionaries which are generated by the new code generator. Plus, refactors some ambiguous GN variables which were used for both old/new code generators. Bug: 839389 Change-Id: I42b603e8e58cc632420620d6f657105b7e5b4691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301536Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#791728}
-
Daniil Lunev authored
Adds vendor, product, hardware and firmare revisions of the device to reporting. Corresponds to the following platform CL: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2241216 BUG=b:151176984 TEST=unittest Change-Id: I42971baa07ace1e29f17de74bc5da35247185a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294743Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Commit-Queue: Daniil Lunev <dlunev@chromium.org> Cr-Commit-Position: refs/heads/master@{#791727}
-
Alex Rudenko authored
Amstelvar has many font variation axes so it's better to use it in a test. Bug: 1101236 Change-Id: Ic15f80b9adcee826b7f0fb30904f3a4f8bfbb2cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319986 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#791726}
-
Jit Yao Yap authored
This CL adds kRemote to AppService's AppType enum to represent Remote Apps. Bug: 1101208 Change-Id: I406ada51944643e070f39e03a7e18152975d907c DD: go/cros-remote-apps Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275882 Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#791725}
-
Brandon Goddard authored
This cl fixes a bug where scale was not applied to the positioning of the computed track size labels for CSS Grid overlay, causing them to be misplaced on high dpi monitors. Before: https://imgur.com/B970mXx After: https://imgur.com/GLR5s2l Bug: 1109014 Change-Id: Id762b7ef04041ff8fffe9db958dfc58585858cd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316793 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#791724}
-
Kent Tamura authored
Bug: 1108270 Change-Id: I7f2e5e9cc547342f580f8c87bae768981fa3341d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318952 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#791723}
-
Takashi Sakamoto authored
This is a sub-variant of ENABLE_TAG_FOR_MTE_CHECKED_PTR. At first, the tags in the bitmap have to be initialized for an entire slot span upon allocation (rare operation) and then subsequently set to a new value for an entire slot (not slot span) every time that slot is freed. Bug: 1092288 Change-Id: I0c2f06ab580e941f3db1a4c51dfa8e4617acd1e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308554 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#791722}
-
sauski authored
CL enables the deletion of access records which effectively contain browsing history by extending the AccessContextAuditService as a HistoryServiceObserver. Access records are deleted for top frame origins when the service is notified that no more history entries exist for that origin. Bug: 1101675 Change-Id: If98eda4d27f35a92f6580231d7a4c67179aa3dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288085 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
-
Renato Silva authored
Extend the Quick Unlock Private API to support two additional methods - setPinAutosubmitEnabled - canAuthenticatePin setPinAutosubmitEnabled will allow Chrome OS settings to control the PIN auto submit behaviour. canAuthenticatePin is a simple method that checks whether it is still possible to authenticate using a PIN. This only adds the skeleton for the extension and does not call any code yet. It only returns with false for now. Bug: 1107367 Change-Id: I0c961b2d2cf236e05b9bf959603d4e4a459b6f88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306040 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#791720}
-
Yuki Shiino authored
Ports a temporary support of @@asyncIterator introduced at https://crrev.com/c/2248414 to the new IDL interface implementation. Bug: 839389 Change-Id: Ib0ea64ec8c8fbc582ba5472ab8d10ee4b43e0e07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312456Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#791719}
-
Hiroki Nakagawa authored
As a part of the Onion Soup project, this CL moves InternetDisconnectedWebURLLoader from content/renderer/loader to blink/public/platform/. Change-Id: I67883a154da02deeff3a64d12614c28c93e77e59 Bug: 860403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317585Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#791718}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/53453f76b5d0..befe11cae7c1 2020-07-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 0d158ac68107 to d5a4775cfc77 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I8ec2359242ec0f8843c8c95c6741e646c766309a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319900Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ca17e785dd06..c0b2923dc9d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC johannkoenig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: johannkoenig@google.com Change-Id: Id61e80ea3d4b28df1365ef582dd14f0c51de8ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319898Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791716}
-
Chris Harrelson authored
This removes a reference to IsPaintInvalidationContainer in LayoutTable, which in turn removes a dependency of PrePaint on compositing. The need to paint on the table's DisplayItemClient appears to no longer be necessary. The code was added in: https://chromium-review.googlesource.com/c/chromium/src/+/540178/ Change-Id: Ib1066d176511cfa4adc16579cc8aa7fc7475868f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317848Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#791715}
-
Mario Sanchez Prada authored
This test has been disabled in https://crrev.com/c/2303433 due to it being flaky. However its stack trace matches the one observed recently in production code (crbug.com/1107103) so we're re-enabling it now and adding some extra debugging information in order to help us fix the issue, as it hasn't been possible to reproduce it locally so far. Bug: 1107103 Change-Id: Ifeee8483c83e72b52a232b71ef2437ecab6bf305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316101Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Auto-Submit: Mario Sanchez Prada <mario@igalia.com> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#791714}
-
nancylingwang authored
ARC apps use arc::IconDecodeRequest to decoding images safely in a sandboxed service for the security reason, so modify app_icon_factory to call arc::IconDecodeRequest to decode ARC icons. Modify AppServiceAppWindowArcTracker::OnTaskDescriptionChanged to use the unified apps::ArcRawIconPngDataToImageSkia interface. BUG=1083331 Change-Id: Iea350de985ff60203e0acd7a427fe0a9e34c098e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318846Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/07ae186b5ed8..3f851efa2adc 2020-07-27 syoussefi@chromium.org Vulkan: Fix overflow in maxCombinedUniformComponents If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I9fcce09e69c5109b77611ef85b8383baa330dcd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319895Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1c1a51ad. With Chromium commits locally applied on WPT: 9c2ef271 "[COOP report] Add support for report-only" 78eb43f6 "Fix hit-testing culled inline for atomic inlines" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I0033df4748ca13054cc0123b52fe5824a889b25b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318530Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791711}
-
Johann authored
Sometimes this file shows up in the chromium sheriff-o-matic as an ongoing failure for webkit_lint. It's very flaky which is probably why it has not been resolved before. This clears these warnings: TestExpectations:2728 Expectation 'virtual/system-color-compute/external/wpt/css/css-color/t425-hsla-basic-a.xht' is redundant with 'external/wpt/css/css-color/t425-hsla-basic-a.xht' in line 2736 TestExpectations:2733 Expectation 'virtual/system-color-compute/external/wpt/css/css-color/t32-opacity-basic-0.6-a.xht' is redundant with 'external/wpt/css/css-color/t32-opacity-basic-0.6-a.xht' in line 2730 TestExpectations:2734 Expectation 'virtual/system-color-compute/external/wpt/css/css-color/t32-opacity-basic-0.6-a.xht' is redundant with 'external/wpt/css/css-color/t32-opacity-basic-0.6-a.xht' in line 2731 TestExpectations:2735 Expectation 'virtual/system-color-compute/external/wpt/css/css-color/t32-opacity-basic-0.6-a.xht' is redundant with 'external/wpt/css/css-color/t32-opacity-basic-0.6-a.xht' in line 2732 TestExpectations:2737 Expectation 'virtual/system-color-compute/external/wpt/css/css-color/t422-rgba-a0.6-a.xht' is redundant with 'external/wpt/css/css-color/t422-rgba-a0.6-a.xht' in line 2729 TestExpectations:6844 Expectation 'virtual/prefer_compositing_to_lcd_text/scrollbars/custom-scrollbar-adjust-on-inactive-pseudo.html' is redundant with 'scrollbars/custom-scrollbar-adjust-on-inactive-pseudo.html' in line 6845 I chose to remove the 'virtual' versions because of the way the lint warning is worded. BUG=chromium:1108689 Change-Id: I851f971fa6f7e421a4a4c8d8b710175e99c6adcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319490 Commit-Queue: Johann Koenig <johannkoenig@google.com> Auto-Submit: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#791710}
-
Joe DeBlasio authored
This CL adds a feature param to let us selectively disable suspicious site safety tips. It also introduces another test parameter for this case. This significantly impacts test runtime, but still seemed like something we should test. Fixed: 1107583 Change-Id: I25d9bae52a5850f3aaedf37dc8f2b303bfeb2ab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316891 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#791709}
-
Gavin Williams authored
Reduce the font size and remove the weight to bring in line with standard for error text. http://screen/akhrO8wiP8o Bug: 1059607 Change-Id: I75e857bcdd49cb8c042aabab985812bb949ee89c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315920Reviewed-by:
-
Owen Rodley authored
These aren't used right now, but having them at the ready will make it easier for sheriffs or troopers who want to stop a builder from closing the tree (temporarily or otherwise). Change-Id: Iec0b12b460d54da1413f578a2b8f350fb31c9070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315719 Auto-Submit: Owen Rodley <orodley@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Owen Rodley <orodley@chromium.org> Cr-Commit-Position: refs/heads/master@{#791707}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e1b484c6ce52..ca17e785dd06 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC johannkoenig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: johannkoenig@google.com Change-Id: I63b72820efd04d66bf9499c896aaa1a488f62ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319890Reviewed-by:
-
Gavin Williams authored
Enable Printer Status flag by default Bug: 1059607 Change-Id: Ic8706b815905f9ff9208158f2657d980ad013796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315919 Auto-Submit: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#791705}
-
Miyoung Shin authored
This CL converts FrameHostMsg_Detach to content's FrameHost and RenderFrameProxyHost Mojo interface. Bug: 1093911 Change-Id: I07e762be86dc2cc0ed8981a429d4345ec2971a71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282625 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#791704}
-
My Nguyen authored
Updated according to UX designer. Bug: 1109570 Change-Id: I0a39e294dd023241680a936e2551f160307402b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319806Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#791703}
-
Yoshifumi Inoue authored
This patch renames "tools/win/DebugVisualizers/webkit.natvis" to "blink.natvis" because we use term "blink" instead of "webkit" for ease of locating file. Bug: 843412 Change-Id: Ifd3150bba001b122b3ad52a88aba60ab6076e9a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309321Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791702}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/342ad5228da2..0606ae6f9a56 2020-07-27 fancl@chromium.org Add subscription name to issue summary If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1108677 Tbr: wenbinzhang@google.com Change-Id: I30039a707bb39ff143492e5ccaf24298b1c536d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319886Reviewed-by:
-
