GitLab

Fills out more targets in the Android build.

BUG=
R=cjhopman@chromium.org

Review URL: https://codereview.chromium.org/297793004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272574 0039d316-1c4b-4281-b951-d872f2087c98

I accidentally passed an empty string here and got a weird error processing the path.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/292123012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272573 0039d316-1c4b-4281-b951-d872f2087c98

and removed unwanted extension:: prefix.

BUG=None

Review URL: https://codereview.chromium.org/290293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272572 0039d316-1c4b-4281-b951-d872f2087c98

I "cleverly" used std::copy assuming it would not malloc or lock, but it does in the debug build of the STL (at least) to do some verification. This causes the fork to hang on Posix.

This version matches the base code.

BUG=
R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/299003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272571 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373325

Review URL: https://codereview.chromium.org/297803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272570 0039d316-1c4b-4281-b951-d872f2087c98

A Views textfield hides touch text selection handles on command
execution. Omnibox overrides command execution for some commands without
calling textfield's implementation; so, it needs to hide the handles for
those commands.
Also, introduced TextfieldTestApi class for accessing private members of
Textfield class in tests.

BUG=373532

Review URL: https://codereview.chromium.org/297733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272569 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY because comments only.

BUG=None
NOTRY=1

Review URL: https://codereview.chromium.org/297043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272567 0039d316-1c4b-4281-b951-d872f2087c98

SimpleGeolocation unittest should less depend on timings.

BUG=245075
TEST=unittest

Review URL: https://codereview.chromium.org/296853009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272566 0039d316-1c4b-4281-b951-d872f2087c98

Instead of creating an infinite number of sync queries, which will
eventually cause performance issues, log an error message and block
until oldest query has passed when reaching 16 pending queries.

BUG=371530,373360

Review URL: https://codereview.chromium.org/280543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272565 0039d316-1c4b-4281-b951-d872f2087c98

Build failure looks like it was actually unrelated.

> Revert 272371 "Add UMA Counts for number of IPv4 and IPv6 interf..."
>
> Reason: build failure on Mac ASan 64
>
> > Add UMA Counts for number of IPv4 and IPv6 interfaces detected for PeerConnection.
> >
> > R=sergeyu@chromium.org
> > BUG=N/A
> >
> > Review URL: https://codereview.chromium.org/299103002
>
> TBR=mallinath@chromium.org
>
> Review URL: https://codereview.chromium.org/299843008

TBR=mallinath@chromium.org

Review URL: https://codereview.chromium.org/296903010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272564 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduces no semantic change, only renames PasswordManagerLogger
to LogReceiver, to better reflect the purpose of that interface.

BUG=347927

Review URL: https://codereview.chromium.org/264793010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272563 0039d316-1c4b-4281-b951-d872f2087c98

The added test failed on Mac 10.7.

> Add test for action_runner.BeginInteraction and action_runner.EndInteraction.
> 
> BUG=368767
> 
> Review URL: https://codereview.chromium.org/294943006

TBR=nednguyen@google.com

Review URL: https://codereview.chromium.org/284183014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272560 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=zhaoqin@chromium.org

Review URL: https://codereview.chromium.org/294283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272558 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=sky@chromium.org

Review URL: https://codereview.chromium.org/292423004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272557 0039d316-1c4b-4281-b951-d872f2087c98

Added api into privet/info response. 

NOTRY=true

Review URL: https://codereview.chromium.org/296303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272556 0039d316-1c4b-4281-b951-d872f2087c98

The CL introduced unit test failures on Chromium OS ASan LSan Tests(3)
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29/builds/1499

Failing tests:
EventRewriterTest.TestRewriteFunctionKeys
EventRewriterTest.TestRewriteModifiersDisableSome

> Add native event testing to chromeos::EventRewriter unit tests.
> 
> Most tests (not having state) are converted to a table-driven form,
> so that multiple test operations can be done on the same test data.
> Additional tests based on X11 native events are done on these cases.
> 
> The fallback X11 keycode to keysym mapping is expanded, because the
> X server used by some automated tests does not support some of the
> keycodes used by ChromeOS top-row special keys.
> 
> 
> R=sadrul@chromium.org
> 
> Review URL: https://codereview.chromium.org/270633012

TBR=kpschoedel@chromium.org

Review URL: https://codereview.chromium.org/295243004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272553 0039d316-1c4b-4281-b951-d872f2087c98

BUG=376814
TBR=jbauman@chromium.org

Review URL: https://codereview.chromium.org/298463004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272552 0039d316-1c4b-4281-b951-d872f2087c98

This really should be in nacl-newlib, but it's easier to land here now and
remove it later when it lands in newlib and rolls into the SDK.

This implementation does not support symlinks, but neither does nacl_io
currently.

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/295933009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272551 0039d316-1c4b-4281-b951-d872f2087c98

This removes a significant amount of code from the trusted plugin and
simplifies the callbacks that are used in PluginReverseInterface.

I was confused at first by the existing use of url_file_info_map_; it looks
like it was intended to serve as a cache for retrieved files, but I think the
files would be reopened every time, even if the file was already open. For
simplicity, I didn't try to add any caching behavior in this change.

Note that this changes progress events to be rate limited at 10ms per-file,
not 10ms per-plugin. It's a bit simpler to write this way, but I can
change that limit to be per-plugin if that makes more sense.

BUG=370556
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/294633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272550 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368767

Review URL: https://codereview.chromium.org/294943006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272549 0039d316-1c4b-4281-b951-d872f2087c98

Allow strike register to ensure we have high probability of 0-RTT connects,
and proceed toward using Connection ID to track connections.
r=rch
BUG=376108

Review URL: https://codereview.chromium.org/294903011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272548 0039d316-1c4b-4281-b951-d872f2087c98

Whitelisting an extension per: crbug.com/374965

BUG=374965
TEST=None
R=miket@chromium.org

Review URL: https://codereview.chromium.org/297603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272547 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
NOTRY=True

Review URL: https://codereview.chromium.org/296153010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272546 0039d316-1c4b-4281-b951-d872f2087c98

Adding automatic tests to the password manager to simulate user interaction with websites.

BUG=369521

Review URL: https://codereview.chromium.org/273523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272545 0039d316-1c4b-4281-b951-d872f2087c98

BUG=354051

Review URL: https://codereview.chromium.org/291893011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272544 0039d316-1c4b-4281-b951-d872f2087c98

Previously PPAPINaClNewlibTest.PostMessage SendInInit was flaking. The problem seems to be that the messages that are sent in Init() may be replied to and handled in HandleMessage() before RunTests() is run (Init() and RunTests() are called asynchronously). When this is the case, WaitForMessages() can return 0, even though the message from Init() is properly received, because the value of message_data_.size() is 1 before and after the function returns. There is actually no need to check the return value of this function, checking the size of message_data_.size() (which we already do) should be sufficient.

BUG=372630

Review URL: https://codereview.chromium.org/299893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272542 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370448
NOTRY=true

Review URL: https://codereview.chromium.org/296983008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272541 0039d316-1c4b-4281-b951-d872f2087c98

On Win7 Tests (dbg)(2) these tests

FocusElementCallsFocusedNodeChanged
GetCompositionCharacterBoundsTest
MessageOrderInDidChangeSelection
OnExtendSelectionAndDelete
OnImeTypeChanged
OnSetTextDirection
SendCandidateWindowEvents
SetEditableSelectionAndComposition

fail with timeout.
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%282%29/builds/21101/steps/content_browsertests/logs/stdio

> Destroy all rtc peer connection handlers before shutting down blink
> 
> The connection handlers will otherwise continue to call into blink which
> is bound to crash after it was shut down.
> 
> BUG=337572
> R=perkj@chromium.org,adamk@chromium.org
> 
> Review URL: https://codereview.chromium.org/292163002

TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/296213007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272540 0039d316-1c4b-4281-b951-d872f2087c98

Add a flag to all of the registry related work items to specify whether to operate on the 64-bit or 32-bit hive on a WOW64 system.

Make DeleteRegKeyWorkItem call down into RegKey so WOW64 support works for delete work items.

All calls changed to use the Wow64_Default (0) parameter, so the behavior is identical.

This is prep for adding 64-bit support to the installer.

BUG=348626,338706
R=grt@chromium.org, grt
TBR=sky
TEST=installer_util_unittests

Review URL: https://codereview.chromium.org/282363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272539 0039d316-1c4b-4281-b951-d872f2087c98

Use stub implementations of all D-Bus clients when
--dbus-stub is passed instead of only using the stub
implementation of PowerManagerClient.

BUG=371289

Review URL: https://codereview.chromium.org/282873005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272538 0039d316-1c4b-4281-b951-d872f2087c98

This will affect the cocoa and views versions of the profile_chooser.


BUG=357693

Review URL: https://codereview.chromium.org/297803007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272537 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370433
TEST=None
R=sky@chromium.org

Review URL: https://codereview.chromium.org/297833006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272536 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272528 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366850

Review URL: https://codereview.chromium.org/276433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272526 0039d316-1c4b-4281-b951-d872f2087c98

The code this is referring to has moved. It's now checked as part of testing
whether metrics reporting is enabled, internally to the metrics code.

BUG=none
TEST=none
R=asvitkine@chromium.org
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/295103010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272525 0039d316-1c4b-4281-b951-d872f2087c98

R=bulach@chromium.org

Review URL: https://codereview.chromium.org/298973005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272524 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272523 0039d316-1c4b-4281-b951-d872f2087c98

a3f590b  Add Matt Giuca to AUTHORS.
4db62f5  Fixed or silenced all warnings and turned on warnings-as-errors.
2c4b046  cf2hints: Fix early loop termination causing hints to be ignored.
4fbe779  Add some blank lines at the end of 3 files to remove the "no newlines at end of file" warning.
6f9095f  Add my @chromium account in the AUTHORS file.
54c1825  Remove "using namespace agg" to make it clear which code is using agg, and also so we can turn compiler warnings into errors.
5ce98f5  Fix warning on Mac.
41f0590  Remove "using namespace v8" in header. This allows us to turn all warnings into errors. It also makes it clearer to find usage of v8 in the library.

R=thestig@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271905

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272277

Review URL: https://codereview.chromium.org/295983005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272522 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272520 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174635:174659&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/296953004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272519 0039d316-1c4b-4281-b951-d872f2087c98