- 10 Aug, 2020 40 commits
-
-
Fred Mello authored
https://docs.google.com/document/d/1q7MxrwLlI7EOeKDap3ubrGjGUlKAcHq7pWn9G6pRXE4/ Bug: 1112872 Change-Id: I80c79343dd32b9fe38967c476584e92a228d4e50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339797Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Fred Mello <fredmello@chromium.org> Cr-Commit-Position: refs/heads/master@{#796370}
-
Peter Kasting authored
It already had *, and the underlying TimeDelta has long had /(T), so this just makes the API a little less asymmetric. This simplifies one callsite. Bug: none Change-Id: I49fe5f69a36c53c7857e623f17f7c5b4e66346f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344815 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#796369}
-
Gauthier Ambard authored
The TabGridAdaptor was used for the migration from the old TabSwitcher. Bug: none Change-Id: I9d5991bdbcbafad70da6dc856627b738aa1fd885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341645 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#796368}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a4cba6578f09..577cc158d1e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I15b42ae3bc02ff495db088562127736d9fe27585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345946Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796367}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/577cc158d1e2..01e0ccdc9b8b 2020-08-10 lalitm@google.com Merge "perfetto: add unit and description for GpuMemTotal events" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I8de476aa0efed4dc106bc4b89b8ed47e996da7a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346240Reviewed-by:
-
Alexander Dunaev authored
The selection clipboard is available on Linux/X11 but Ozone hides the platform so it is only known at run time what is it. Because of that, Ozone/X11 could not use the selection clipboard. This CL introduces a new call into the ClipboardHost Mojo interface so the renderer can query the host for whether the selection clipboard is available. Change-Id: I64fc8ca66509c2b12f3d03fb53aad3e986772153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307234 Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#796365}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0fd4513a30ec..623cf68b45ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC andypaicu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: andypaicu@google.com Change-Id: Ifeeaaa7157dc3b1a720a3b4bc435805120339f79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346231Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796364}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4c2f9c90f425..0bb27fe504d2 2020-08-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 61491ae4..cfbe56f1 (795944:796058) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie7f7d736245c358e12558e8a0a7b7c61ff020a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346238Reviewed-by:
-
Xi Han authored
Bug: 1103838, 1092642 Change-Id: Ic2aeceb824c7fb39dc475c72fbe0f897f6dcbf59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325248Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#796362}
-
Christian Dullweber authored
Use CookieControlsMode and simplify some code paths. Bug: 1104836 Change-Id: I67f893bf8eb6dcfc1d39eb7a1f2b5942ab28eeb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339415Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#796361}
-
Antonio Sartori authored
This change adds logic to the AncestorThrottle and the RenderFrameHostImpl for: - validating the parsed content of the frame 'csp' attribute as stored in the FrameTreeNode; - setting the Sec-Required-CSP header accordingly on outgoing requests; - store the validated required csp context in the RenderFrameHost after the navigation is committed. Bug: 1094909 Change-Id: Iaf2c733047b4a153f0dfaccf1d5d018f83d7cc8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330051 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#796360}
-
Xi Han authored
Bug: 1103838, 1092642, 1076274 Change-Id: Ia44be7834b698bd37f0d6bd80de31257ea38eecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325249Reviewed-by:
-
Alex Ilin authored
The flag is no longer needed since the Gaia endpoint has been rolled out to prod. The only consumer of Reauth feature is backed by its own feature flag. Bug: 1045515 Change-Id: Ia12aa2abfc064a431c1a24ab85de231c07e8ebfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339530 Commit-Queue: Alex Ilin <alexilin@chromium.org> Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#796358}
-
Renato Silva authored
Add strings and screenshots for the upcoming switch button on the login/lock screen. Bug: 1075994 Change-Id: Ic5aa9b083dc2251edda7ad7a634bf93f17f1981b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346264 Commit-Queue: Renato Silva <rrsilva@google.com> Auto-Submit: Renato Silva <rrsilva@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#796357}
-
Maksim Sisov (GMT+3) authored
This reverts commit 81dab1d6. Reason for revert: Found a better solution Original change's description: > X11 and Ozone: Fix screen initialization for Ozone config > > The tests that use ClientHintsBrowserTest override FeatureList > during ::SetUp call, which results in erasing UseOzonePlatform > from that, and InProcessBrowserTest::SetScreenInstance cannot > check the status of the feature flag during ::SetUp call. And, > as a consequence, fail to decide what path it must use. Append > the UseOzonePlatform feature flag back to the scoped feature list > so that initialization happens properly. > > ----- > > PS: Please note that this is a temp solution that will help to choose > between ozone and non-ozone X11 build. The switch that will be used > to choose the path is --enable-features=UseOzonePlatform. Once > non-Ozone X11 path is removed (hopefully by Q1 2021 depending on how > the finch trial goes), the wrapper will be removed. > > Please also note that it's impossible to build use_x11 && use_ozone > without some hacks in PlatformCursor code. The changes to that are > on their way to upstream. > > ---- > > Bug: 1085700 > Change-Id: I995a434a25b6e1a0db3d16bb516184c0d3bc87de > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333843 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#796341} TBR=sky@chromium.org,msisov@igalia.com Change-Id: I2f04fc98b373303ee5ea131f3c79550cfa3c0e8f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1085700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346427Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#796356}
-
Omar Morsi authored
This CL 1) moves all key permissions files under platform_keys folder to platform_keys/key_permissions folder, 2) makes sure all key permissions classes are under chromeos::platform_keys namespace. Bug: 1113121 Change-Id: I45a2a9aaaff9b8dc2cf27e96355b435d2814fb7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338215 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Edman Anjos <edman@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#796355}
-
Victor Hugo Vianna Silva authored
TBR=vasilii@chromium.org Bug: None Change-Id: Ia4211f62e5fcd73a52f374c87cc56e7f8762faee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346269Reviewed-by:
Victor Vianna <victorvianna@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#796354}
-
arthursonzogni authored
There are no reasons to use kFollowRedirect. Using it make the reports contains less data. Bug: 1113163 Change-Id: Ifc66cf29da71d53b2bea11a0da1a7724c6a6756f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339748 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#796353}
-
Matt Jones authored
Prior to the refactor in https://crrev.com/c/2288909 the navigation handler was null checked. Since the handler is now owned by a new coordinator, the coordinator is checked instead of the handler itself, this patch re-adds that extra layer of checking. Bug: 1113548 Change-Id: I29e938ead6ed11a71e46441b3e00c7ccab13ab23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343575Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#796352}
-
Maksim Sisov authored
The use_x11 && use_ozone config breaks compositor_unittests. Basically, we need to decide on runtime what test compositor host we need to use - X11 or Ozone. This CL fixes that using the same approach I used in other CLs. For example, https://crrev.com/c/2247719 ----- PS: Please note that this is a temp solution that will help to choose between ozone and non-ozone X11 build. The switch that will be used to choose the path is --enable-features=UseOzonePlatform. Once non-Ozone X11 path is removed (hopefully by Q1 2021 depending on how the finch trial goes), the wrapper will be removed. Please also note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. ---- Bug: 1085700 Change-Id: Id5442da33def3cdf8f00deffc59e11d76dbf60a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335284Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I3060245837948adb305900bbcf21dcc51ecd36d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345945Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796350}
-
Maksim Sisov authored
Atm, that case is only handled for !defined(USE_X11). Instead, it must be handled for !defined(OS_LINUX) as OS_LINUX can mean either USE_X11 or USE_OZONE now. Bug: 789065, 578890 Change-Id: I95d140cb515e833e5b195b1e746671db2cb57b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336600Reviewed-by:
-
Maksim Sisov authored
When use_x11 && use_ozone are set, vulkan tests start to use SkiaVulkan backend (that is actually used only for non-Ozone X11 builds on Linux). To suppress the crashes, default to a default backend for Ozone. Also, added a bug to enable that for Ozone/Linux. Bug: 1085700 Change-Id: Ib8e99caf046dc91e90a954b4665e241ed9c80f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336083Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#796348}
-
Greg Thompson authored
This reverts commit 67667a8e. Reason for revert: This change increases the failure rate from the mini_installer. Original change's description: > Stop leaking files extracted by mini_installer. > > With this CL, mini_installer now holds the files it creates open with > FLAG_DELETE_ON_CLOSE so that they are automatically deleted by the > filesystem when they are no longer needed. > > The most risky operation is the multi-step process to drop write > permission on the files so that they can be opened for consumption by > parties that do not allow writers. New process exits codes have been > introduced to track whether or not this operation fails in practice. > > BUG=516207 > > Change-Id: Ic5e25692cf3dca0fcc7cd01faf5759648f5c6890 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307250 > Reviewed-by: Will Harris <wfh@chromium.org> > Commit-Queue: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790735} TBR=forshaw@chromium.org,wfh@chromium.org,grt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 516207 Change-Id: I7da5dbbdf02aa1499f96b40af7f76f0b7ee0ed24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346344Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#796347}
-
Gauthier Ambard authored
The flag has been enabled for one release. Bug: none Change-Id: I75316536f01acd2d924da01f754dc4505ca98412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343035Reviewed-by:
-
Zakhar Voit authored
Fixes browser crash when the --force-device-scale-factor flag is used on 4K monitors and the user is trying to open a popup window. Cause of the crash: ui_scale()/buffer_scale division here https://source.chromium.org/chromium/chromium/src/+/master:ui/ozone/platform/wayland/host/wayland_popup.cc;l=159;drc=1e3319e24d05bef56bcf40b2cacf256e285e1342 resulted in 0 because both methods return integer. This CL also simplifies scaling logic in WaylandPopup and WaylandAuxiliaryWindow. These classes used to convert pixel bounds to DIP before changing them to the coordinates relative to the parent (by applying mixed ui_scale/buffer_scale arithmetic). It's not necessary and doesn't work sometimes when ui_scale != buffer_scale. This CL was tested with --force-device-scale-factor flag as well as on single monitor setups with different scaling. Fixes for multi-monitor setups will be added in a separate CL, because at the moment scaling is not always correctly propagated to each window on them. Bug: 1052685 Change-Id: I6259e62c640e6f9cd6aeee45f27377dfa34d1ee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318230Reviewed-by:
-
Peter Conn authored
This reverts commit a1ac648d. Reason for revert: Test failures were caused by a problem with one of the bots - https://crbug.com/1094008 Original change's description: > Disable DigitalGoodsTest#jsToTwaConnected > > Seems to be failing somewhat consistently for some of the bots > > BUG=1111906 > > Change-Id: I887a121bb77afdf8abedb39144727b7dddf88753 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332306 > Auto-Submit: Yusuf Ozuysal <yusufo@chromium.org> > Commit-Queue: Peter Conn <peconn@chromium.org> > Reviewed-by: Peter Conn <peconn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794457} TBR=yusufo@chromium.org,peconn@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1111906 Change-Id: I8ab059aa93fe6b8b362c9aabd6478eede10ddff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346268Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#796344}
-
Richard Stotz authored
This CL implements a flush function that attempts to flush any write buffers, including device buffers, by calling base::File::Flush(). This comes with the intent to evaluate developer feedback. Note that a future version of the API might include a faster, less reliable variant of flush. Bug: 914488 Change-Id: I556cea0f4872e5536e413b91df575c4f6a00a55e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257934 Commit-Queue: Richard Stotz <rstz@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Eric Seckler authored
Adds a feature-list-controlled experiment to restrict execution of all Chrome processes/threads to LITTLE-cores only (on big.LITTLE-like architectures). We intend to run a limited experiment on Canary/Dev to estimate the potential power savings of running on the more efficient little cores, as well as the impact of this on system health metrics. We also plan to add a similar experiment for WebView. However, since WebView shares a process with the hosting app, we may need to be more careful about which threads we opt into little-core-only execution. TBR: dcheng@chromium.org Bug: 1111789 Change-Id: If2bc8c811692f7e716428398db3e5d0649da42d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332715Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#796342}
-
Maksim Sisov authored
The tests that use ClientHintsBrowserTest override FeatureList during ::SetUp call, which results in erasing UseOzonePlatform from that, and InProcessBrowserTest::SetScreenInstance cannot check the status of the feature flag during ::SetUp call. And, as a consequence, fail to decide what path it must use. Append the UseOzonePlatform feature flag back to the scoped feature list so that initialization happens properly. ----- PS: Please note that this is a temp solution that will help to choose between ozone and non-ozone X11 build. The switch that will be used to choose the path is --enable-features=UseOzonePlatform. Once non-Ozone X11 path is removed (hopefully by Q1 2021 depending on how the finch trial goes), the wrapper will be removed. Please also note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. ---- Bug: 1085700 Change-Id: I995a434a25b6e1a0db3d16bb516184c0d3bc87de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333843Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3bb048b167cc..c7ca0c496689 2020-08-10 szuend@chromium.org Remove pre-built from issues/BUILD.gn 2020-08-10 aerotwist@chromium.org Reland "Reland "Updates elements to devtools_module"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I03cf07546942efbe0027c78723d7cc841faf4269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346226Reviewed-by:
-
Peter E Conn authored
TBR=meacer@chromium.org Change-Id: Iea493c1f49bc6180d8806988b38bae2f50aa4bf7 Bug: 1114659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346324Reviewed-by:
-
Alex Rudenko authored
Since M84 the inspector overlay shows additional a11y information that is retrieved via getters on the Element instances. The getters create new instances of AXContext which give access to the cached information about a11y in a document. When a document has no more active AXContexts, the cache is destroyed. In this case, a single context was being created and destroyed when invoking the Element getter resulting in cache misses. This CL fixes caching by making sure that the inspector overlay agent holds AXContexts for active documents. Fixed: 1112066 Change-Id: I0a006a7145cf52c9e81ccf9c30b25f2b202e6157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344345 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#796338}
-
chromium-internal-autoroll authored
Release_Notes:http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008090800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/sQ-pH6rZbDHAmfK-kjBe53-R0rfRl9r_ObSKY2g81kUC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/140700011,b/154289703,b/159394049,b/159394333,b/159394534,b/159863346,b/159964708,b/160203781,b/160646592,b/160930327,b/161170553,b/161179660,b/162207388,b/162207736,b/162209337,b/162211731,b/162901119 Tbr: help-app@grotations.appspotmail.com Change-Id: Ic8a8d3745ad2ae66a746b5daf388b1fc1bbb9b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344230Reviewed-by:
-
Andy Paicu authored
TBR=davidmunro@google.com No-Presubmit: true Bug: 1114654 Change-Id: I5fd08f1532e091654e3ebb601df7e04f06569c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346244Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796336}
-
Antonio Sartori authored
This CL adds a new mojo call from blink to the browser for sending the parsed value of the frame 'csp' attribute. If the feature OutOfBlinkCSPEE is enabled: - blink parses the 'csp' attribute and sends it to the browser which will store it in the FrameTreeNode; - the required_csp FrameOwnerProperty is not being used anymore; - the required_csp frame owner attribute is not being synced between renderers anymore; - as a consequence, blink does not set the Sec-Required-CSP header on outgoing requests anymore. In a successive CL, the AncestorThrottle will use the parsed 'csp' attribute for setting the Sec-Required-CSP header on outgoing requests. Bug: 1094909 Change-Id: Idaa65d7eccde1ced19a75a86a889913071c71d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329892 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by: -
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/48ba75ac6845..e9cc27752c42 2020-08-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from a6d08c75d219 to 8446db62f194 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I1be8259819a90e9ca3157376767471a68b3cb8e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346068Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a4cba6578f09..577cc158d1e2 2020-08-10 eseckler@google.com Merge "Adds graph processor to Perfetto" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2885178e666651d1df27271cfd03b1b8d6b6d218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346066Reviewed-by:
-
Anders Hartvoll Ruud authored
This CL is a step towards improving the suboptimal ergonimics of the current CSSProperty API. The situation is this: Whenever you call CSSProperty::Get(CSSPropertyID::kVariable), the call will succeed, but the instance you get in return is an entirely useless instance of CSSProperty known as "the static Variable instance". This subclass, beyond being a NOTREACHED minefield, simply returns the wrong information "silently" in some cases. For example, CSSProperty::Get(CSSPropertyID::kVariable).GetPropertyName() unhelpfully returns "variable", which is not even a valid property name. There is a (slow) ongoing effort to remove the static Variable instance, and this CL eliminates some potential uses of it. In InspectorCSSAgent::setEffectivePropertyValueForNode, there is a lookup from a string to a CSSPropertyID, and then a CSSProperty::Get using that ID. This will not work for custom properties for the reasons already mentioned. This CL replaces that with a call to CSSPropertyName::From instead, which *does* handle custom properties correctly. In InspectorAnimationAgent::CreateCSSId, PropertyHandle::GetCSSProperty is called via the CSSTransition. The returned instance may be the static Variable instance, so we avoid this call, and instead use CSSPropertyName in this function. It is possible to get a CSSProperty instance that is valid for custom properties (see CSSPropertyRef), but since FindEffectiveDeclaration only cares about the name of the property anyway, it's more appropriate to use CSSPropertyName. Bug: 980160 Change-Id: I2291b650767b17870fc6d33e1062ea127213b757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340039 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#796332}
-
Christoph Schwering authored
FormStructure::GetServerTypes() created a vector that was always passed to data_util::DetermineGroups(). This CL removes FormStructure::GetServerTypes() and moves the relevant computation of the server into the loop in data_util::DetermineGroups(). We need to keep an overload data_util::DetermineGroups() that takes a vector because of one reference in LabelFormatter::Create(). Bug: 1007974 Change-Id: Idea5c2d4ea484701ac6a898b4eb6b667859de488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266173 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#796331}
-
