GitLab

The focus of this CL is to get widget_unittest.cc compiling on MacViews.

To achieve this, aura::test::EventGenerator is moved to ui/events/test
and constructed with a delegate class that abstracts away the
platform-specific event targeting and coordinate conversions.

ui::test::EventGenerator::CreateDefaultPlatformDelegate(..) allows a default
platform-specific EventGeneratorDelegate to be provided so that
this detail is hidden from tests.

On Mac, this delegate wraps a single NSWindow and targets NSEvents at
that window. On Aura, the delegate is a thin wrapper to find and target
events at an aura::Window, using the aura root window as the initial
target.

For Mac, NativeWidgetPrivate::IsMouseButtonDown and NSView mouse event
handling in BridgedContentView is implemented to put the Mac event
generator in context.

Adds views_unittest WidgetTest.MouseEventTypesViaGenerator to ensure
event generation is consistent across platforms (which currently passes
on Mac). Allows an additional 67 tests to compile on Mac (49 pass).

After this, widget_unittests.cc compiles on Mac. views_unittests has:
Before: 358 tests run 10 tests failed 16 tests crashed.
After: 425 tests run 24 tests failed 20 tests crashed.

BUG=378134
TEST=views_unittests

Review URL: https://codereview.chromium.org/322893005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283694 0039d316-1c4b-4281-b951-d872f2087c98

Adding a step to the check-in process that ensures the correct account information is present before device
check-in happen, in order to maintain a relationship
between signed in accounts and the device.

Behavior of the check-in is not symmetric:
* Adding an account converges slowly - newly added
account will be associated to device with next periodic
check, to avoid checking in too often.
* Removing account triggers check-in immediately to ensure
users privacy.


BUG=374969

Review URL: https://codereview.chromium.org/378643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283693 0039d316-1c4b-4281-b951-d872f2087c98

Send reject reason to client for debugging purposes.

Merge internal change: 70366491

R=wtc@chromium.org

Review URL: https://codereview.chromium.org/388333005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283692 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283691 0039d316-1c4b-4281-b951-d872f2087c98

$ git log c8437bfa4..2cbc12487 --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//'
2014-07-16 maruel Fix a crash in run_isolated.py when the cache is not used.
2014-07-14 maruel Enforce the use of --priority in run_on_bots.py.
2014-07-11 maruel Fix run_on_bots.py to not assume id == hostname.

R=csharp@chromium.org
BUG=

Review URL: https://codereview.chromium.org/397043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283690 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392435
TEST=manually tested

Review URL: https://codereview.chromium.org/393303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283689 0039d316-1c4b-4281-b951-d872f2087c98

Sometimes, zoomed image covers others. It doesn't look good.

BUG=393870
TEST=manually

Review URL: https://codereview.chromium.org/387313010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283688 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds basic support for equality testing of system call
arguments, and conjunctive and disjunctive combinations of tests.

Reland of https://codereview.chromium.org/299743002/

BUG=375497

Review URL: https://codereview.chromium.org/396323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283687 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283686 0039d316-1c4b-4281-b951-d872f2087c98

1951: Fixes bug in path handling of analyzer

BUG=383609
TEST=none
R=mark@chromium.org

Review URL: https://codereview.chromium.org/398903004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283685 0039d316-1c4b-4281-b951-d872f2087c98

- Add explicit support for EnormousTest
- Warn at runtime if a test size annotation isn't recognized
  (see: http://www.chromium.org/developers/testing/android-tests)
- Remove EnormousTest annotation from a test that wasn't actually using it
  (it was effectively using the SmallTest timeout value at runtime).
- Add SmallTest annotation to InstallerDelegateTest (it was the only
  set of tests that did not include these annotations).

TEST=ChromeShellTest instrumentation tests
BUG=392297

Review URL: https://codereview.chromium.org/376873008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283684 0039d316-1c4b-4281-b951-d872f2087c98

This code is subtle. Since killing the host forwarder is a global operation, it
keeps a temp file with the shared pid and process start time so that it knows
whether the forwarder is the correct one that should be shared or a stray one
that should be killed.

This failed because not all of the sharded perf test processes had the same
parent pid. This caused the sharded tests to stomp on the global forwarder.

We didn't notice this previously because we only had narrow sharding, and 3
retries so the flake was papered over. When we added 8-way sharding on
chromium.perf, the flake rose to the level where it appeared every run.

This patch fixes it by using the process group instead of using the parent
process ID as a proxy.

BUG=163503

Review URL: https://codereview.chromium.org/391383005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283683 0039d316-1c4b-4281-b951-d872f2087c98

This prevents a crash if a WebContents has no WebContentsDelegate.

BUG=391202

Review URL: https://codereview.chromium.org/395753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283682 0039d316-1c4b-4281-b951-d872f2087c98

Only content/common and webkit/common/blob/ include from
webkit/common/data_element.h and thus need to depend on webkit_common
target.

BUG=338338
TEST=None
R=jamesr@chromium.org
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/390983006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283681 0039d316-1c4b-4281-b951-d872f2087c98

Updated mojo spy to use the newly added function MojoIsMessagePipe to check if the handle
coming back from the ReadMessageRaw call is a message pipe. If yes we go ahead and intercept it.

Removed the hacks added in the previous patch which assumed that the first handle coming back from
the vendor is a message pipe.

BUG=360188

Review URL: https://codereview.chromium.org/391233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283680 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392901

Review URL: https://codereview.chromium.org/390233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283679 0039d316-1c4b-4281-b951-d872f2087c98

src/extensions depends on chrome::NOTIFICATION_PROFILE_CREATED to support deferred loading of extension background pages when the profile isn't ready yet. This is a layering violation.

* Remove Chrome concepts like "browser window ready" and "profile created" from ProcessManager. Introduce ProcessManagerDelegate with a general concept of deferring background page loading.
* Consolidate all the tricky Chrome-specific background page loading rules into ChromeProcessManagerDelegate. This keeps all the rules in one place. Annotate each block of special case code with the bug that inspired it.
* Extend unit test coverage for ProcessManager.

This will make it easier to eliminate chrome::NOTIFICATION_PROFILE_DESTROYED in ProcessManager in a later CL.

BUG=392658
TEST=unit_tests ProcessManagerTest, browser_tests ProcessManagerBrowserTest, manual

Review URL: https://codereview.chromium.org/381283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283678 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283677 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283676 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178289:178301&mode=html
TBR=falken@chromium.org,abarth@chromium.org,eseidel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/397203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283675 0039d316-1c4b-4281-b951-d872f2087c98

When collecting upon resume from suspend or session restore, don't always
collect right away. Introduce a random delay before collecting.

BUG=chromium:358778
TEST=Do the following:
- Add logging to ParseProtoIfValid().
- Set kResumeSamplingFactor=1 and kRestoreSessionSamplingFactor=1. This makes
  collection happen 100% of the time.
- Set kPerfProfilingIntervalMs=20000. This makes the periodic collection happen once every 20-second interval.
- Trigger both types of collections, resume and restore:
  = Suspend and resume the system.
  = Open some tabs in ChromeOS, log out of Chrome, and then log back in so that
    the session is restored.
- Should see the logging trace displayed in /var/log/ui/ui.LATEST after a
  random delay.
- Should also see the periodic collections take place.
  = Open an incognito window. It should continue to attempt to collect. (Add a trace to ScheduleIntervalCollection to see that this is the case).
Signed-off-by: Simon Que <sque@chromium.org>

Review URL: https://codereview.chromium.org/364913007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283674 0039d316-1c4b-4281-b951-d872f2087c98

In preparation of removing RootView::DispatchGestureEvent(),
replace its two overrides with overrides of
ui::EventProcessor::OnEventFromSource() and then make
the function DispatchGestureEvent() non-virtual.

BUG=353641
TEST=none

Review URL: https://codereview.chromium.org/395563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283673 0039d316-1c4b-4281-b951-d872f2087c98

minor changes
- print offset/mask info when printing layer hierarchy.
- copy the offset when cloning layer.

BUG=391822
TEST=Added new tests in layer_unittests and views_unittests

Review URL: https://codereview.chromium.org/375693006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283672 0039d316-1c4b-4281-b951-d872f2087c98

This patch just adds the API to get a download URL with an drive read only token.

BUG=305511
TEST=manually teste
R=asargent@chromium.org, hashimoto@chromium.org, kinaba@chromium.org
TBR=isherman@chromium.org

Review URL: https://codereview.chromium.org/371883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283671 0039d316-1c4b-4281-b951-d872f2087c98

In a previous design iteration we planned to have the sync server assign
an attachments id after receiving an attachment upload. We have since
changed the design so the client is responsible for assigning the
attachment id before upload occurs.

Remove comments related to updating attachment id after upload.

Rename UpdateAttachmentIdWithServerInfo to MarkAttachmentAsOnServer.

Rename UpdateEntriesWithAttachmentId to
UpdateEntriesMarkAttachmentAsOnServer.

BUG=371522

Review URL: https://codereview.chromium.org/394293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283670 0039d316-1c4b-4281-b951-d872f2087c98

Set up message passing between C++ and JavaScript for end-to-end testing of print preview. Allows preview settings, such as the page range, to be set during a browser test.

BUG=388517

Review URL: https://codereview.chromium.org/381453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283669 0039d316-1c4b-4281-b951-d872f2087c98

As far as I can tell, these defines shouldn't have any effect. I'd like to make
the trusted plugin build more similar to what we have for the renderer so that
the transition will be easier when we get rid of the trusted plugin shared
library.

This mirrors a change made to native_client in 2012:
  http://git.chromium.org/gitweb/?p=native_client/src/native_client.git;a=commitdiff;h=c0a9077e3a604521f67f35c9bec3be031dd21465

BUG=394497

Review URL: https://codereview.chromium.org/391343006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283668 0039d316-1c4b-4281-b951-d872f2087c98

This CL follows https://codereview.chromium.org/392783003, and will be followed by another CL to remove redundant fields & methods in blink.

BUG=350531

Review URL: https://codereview.chromium.org/393653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283667 0039d316-1c4b-4281-b951-d872f2087c98

R=dmazzoni@chromium.org
BUG=393489

Review URL: https://codereview.chromium.org/395023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283666 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160586

Review URL: https://codereview.chromium.org/397793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283665 0039d316-1c4b-4281-b951-d872f2087c98

This implements RAII semantics so that when the destructor runs, the source
is cancelled and event handler blocks cannot call methods on a destructed
object.

BUG=382931
R=mark@chromium.org

Review URL: https://codereview.chromium.org/392273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283664 0039d316-1c4b-4281-b951-d872f2087c98

This resulted in needing to make structural changes. For example, if
connection 2 has a root of A, and A has the children B and C then if A
is assigned to another connection (by way of the owner calling Embed
again), then connection 2 is told A has been deleted and B and C are
removed as children of A.

Because this does structural changes the server change id is advanced.

BUG=389339
TEST=covered by unit tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/397803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283663 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160586

Review URL: https://codereview.chromium.org/399493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283659 0039d316-1c4b-4281-b951-d872f2087c98

BUG=181277
TEST=Everything still works
TBR=shess@chromium.org, gab@chromium.org
(shess@ for logins_table, gab@ for profile_writer both file-moves)

Review URL: https://codereview.chromium.org/380023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283658 0039d316-1c4b-4281-b951-d872f2087c98

Add a bunch more baked-in configs, and update the existing ones.
Also, improve bake_in_configs.py so it will display multiple errors before
failing, and re-enable the unit test that failed when the existing configs
expired.

BUG=

Review URL: https://codereview.chromium.org/391383003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283657 0039d316-1c4b-4281-b951-d872f2087c98

Allow a menu to stay open when a child View (not a MenuItemView) is doing a drag-and-drop operation.

We need this in order to allow the wrench menu to stay open during browser action drag-and-drop when the extension action redesign switch is enabled.

BUG=393038

Review URL: https://codereview.chromium.org/378333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283656 0039d316-1c4b-4281-b951-d872f2087c98

It seems this file doesn't exist anymore, so the exclusion
rules aren't also necessary. And GN reports error for 
excluding non-existing files.

BUG=None
R=brettw@chromium.org, szym@chromium.org
TEST=None

Review URL: https://codereview.chromium.org/399723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283655 0039d316-1c4b-4281-b951-d872f2087c98

Moved all files from remoting/jingle_glue to remoting/signaling and
remoting/protocol.
The new remoting/signaling directory contains signaling layer implementation
for remoting that can be used independently of remoting/protocol.

TBR=rch@chromium.org

Review URL: https://codereview.chromium.org/390983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283654 0039d316-1c4b-4281-b951-d872f2087c98

BUG=47554

Review URL: https://codereview.chromium.org/394703004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283653 0039d316-1c4b-4281-b951-d872f2087c98

This is breaking ipc fuzzer build.
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/391373005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283652 0039d316-1c4b-4281-b951-d872f2087c98