- 30 Jan, 2018 40 commits
-
-
Tommi authored
This class links together Chromium's ScopedAllowBaseSyncPrimitives and WebRTCs. Now that WebRTC is starting to use Chromium's sync primitives, this allows us to continue reduce locking inside of WebRTC that can cause slowdown on Chromium threads, while guarding against regressions. Bug: 796889, 795340 Change-Id: Icd71c13e04433aa67e3f22f5d510aa724b413fa9 Reviewed-on: https://chromium-review.googlesource.com/871631Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#532920}
-
David Bokan authored
Bug: 801381 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I27e9f0ac5d372400bc2c72e7904a3908fc546454 Reviewed-on: https://chromium-review.googlesource.com/887647Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#532919}
-
David Tseng authored
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I364949b358db73b125d7687b73bf2239648352d1 Reviewed-on: https://chromium-review.googlesource.com/887426Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#532918}
-
Jennifer Apacible authored
Only one interstitial (of media remoting and picture in picture) will be shown at a time. This change renames IDs for elements in the interstitial element with the same styling. This change also pulls out the CSS into a separate file, per TODO. Expected further work here includes some more styling updates with an interstitial icon for picture in picture. BUG: 805516 Change-Id: I6c2151f2166b4dbbf2aaa0be83f8492369008a11 Reviewed-on: https://chromium-review.googlesource.com/890025Reviewed-by:
Mounir Lamouri (slow) <mlamouri@chromium.org> Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#532917}
-
Vasilii Sukhanov authored
Previously the following happened: - a background tab decided that it should pop up a password bubble. - the bubble was suppressed as the tab is inactive. - another event changed the state of the controller but the flag to open the bubble was still on. - the tab became active and the bubble was popped up despite the state was unexpected. With this CL the bubble is not gonna open automatically when the state has changed in the mean time. Bug: 805556 Change-Id: Ia66054889550b1b26b3abeb5926acbb8d7ceea05 Reviewed-on: https://chromium-review.googlesource.com/893381 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#532916}
-
Mythri Alle authored
Bug: chromium:799080, chromium:804828 Change-Id: Ia53c46840b47086dd55f989d190b063af54eb2a4 Reviewed-on: https://chromium-review.googlesource.com/892442Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#532915}
-
Ramin Halavati authored
'empty_policy_justification' field in traffic_annotation.proto is not used in any annotation and doesn't seem to be needed. It is removed. Bug: 656607 Change-Id: Iddde9ea668690b7a684d6f320b2cf952faa60e0c Reviewed-on: https://chromium-review.googlesource.com/892880 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#532914}
-
Jan Krcal authored
This CL introduces a retry mechanism in RemoteSuggestionsProvider when suggestions are cleared while a request is in flight. This change does not violate the previous contract that all fetches are triggered by the scheduler. From the point of view of the scheduler, the original fetch and the retry seem as one single fetch. Bug: 802179 Change-Id: I6138e16cc68d2a1f4b93576002ce241829255c18 Reviewed-on: https://chromium-review.googlesource.com/873034 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#532913}
-
Andrew Wilson authored
Updated the policy code on Chrome OS to track whether a given user requires policy in the known_users DB and via a SessionManager-provided cmd line flag for ephemeral users. Also added logic in UserCloudPolicyManagerChromeOS to enforce that policy is indeed loaded when known_users says it should be loaded. Bug: 676624 Change-Id: Ib2aaa9fdee8c3cccf84b3ec370618215f78d4fc6 Reviewed-on: https://chromium-review.googlesource.com/719838 Commit-Queue: Drew Wilson <atwilson@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#532912}
-
Douglas Creager authored
There are separate sampling rates for reports about successful and failed requests. Even though we're not currently reporting anything for successful requests, this plumbs through both sampling rates from the NEL header into the OriginPolicy instance. (A future change will add reports for successful requests; doing the patches in this order ensures that we never upload reports for 100% of successful requests unless specifically instructed to do so by the origin.) Bug: 748549 Change-Id: I66d9d0c0544372e642d3a146deb0a06f7973452d Reviewed-on: https://chromium-review.googlesource.com/891741 Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Cr-Commit-Position: refs/heads/master@{#532911}
-
Raymond Toy authored
Remove dezippering from all of the attributes. The value will now change immediately instead of gradually changing from the old value to the new value. Chromium Feature: https://www.chromestatus.com/features/5287995770929152 Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/YKYRrh0nWMo/aGzd3049AgAJ Bug: 752986 Test: BiquadFilter/dezipper.html Change-Id: I86840159709158fd52a69a7c3c5f279267277d44 Reviewed-on: https://chromium-review.googlesource.com/612104 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#532910}
-
Hannes Payer authored
Bug: chromium:804279, chromium:633030 Change-Id: I47f3b5ae087971105e64262cfe2e65495f99f3ca Reviewed-on: https://chromium-review.googlesource.com/893181Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#532909}
-
https://webrtc.googlesource.com/src.git/+log/49456a5b3327..79d331b09102 $ git log 49456a5b3..79d331b09 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=NONE The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I68ab9f5881ff7000a546339be136b954755c9598 Reviewed-on: https://chromium-review.googlesource.com/893205 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#532908}
-
Sylvain Defresne authored
Xcode 8 required that code implements initializer methods marked as NS_UNREACHABLE but this was fixed with Xcode 9. Remove those methods as they just add visual clutter. Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic18320e7a8059688413fa09c26feb99d0a3e995c Reviewed-on: https://chromium-review.googlesource.com/891024 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#532907}
-
Tommy Steimel authored
This CL changes the scrubbing check in MediaControlsImpl::State to only return the scrubbing state when the video is actually scrubbable. This fixes a bug where the video CSS class would have a ready state when no video source was available. Bug: 802155 Change-Id: Ib7dfd26cb1be98dde2fc53ea6e230103162f64b1 Reviewed-on: https://chromium-review.googlesource.com/884262Reviewed-by:
-
Matt Morehouse authored
Enabling this option prevents fuzzers/sanitizers from setting the -gline-tables-only and -gcolumn-info flags, and instead uses the symbol level defined by symbol_level. This is particularly useful for reducing binary sizes when building with use_clang_coverage=true, where stack traces are unneeded and line numbers for coverage are determined from the coverage mappings. Bug: 759795 Change-Id: Iae3ea9ede10281c9f29c461ed5d6eec503a661cd Reviewed-on: https://chromium-review.googlesource.com/887285Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#532905}
-
Nico Weber authored
This CL was uploaded by git cl split. R=junov@chromium.org Bug: 177475 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I377f439e850f0b26bc1c50f9bbb1f97a7d7dc8e1 Reviewed-on: https://chromium-review.googlesource.com/890003Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#532904}
-
Ramin Halavati authored
GetNinjaPath() function in 'tools/clang/pylib/clang/compile_db.py' did not return the path to ninja correctly. This is fixed. Bug: 807146 Change-Id: Ie149b4d5a2684454b6fdbbd59598421e008136fd Reviewed-on: https://chromium-review.googlesource.com/892918Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#532903}
-
https://pdfium.googlesource.com/pdfium.git/+log/95b232f79123..af9f83656f98 $ git log 95b232f79..af9f83656 --date=short --no-merges --format='%ad %ae %s' 2018-01-30 dsinclair Combine more combo and list code Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I84bab8b8a3f045bd1bab3b8f9754eb9684c464c3 Reviewed-on: https://chromium-review.googlesource.com/893201 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#532902}
-
Chong Zhang authored
This CL removes unnecessary cross-origin requests from the test. Bug: 780956 Change-Id: I7835d6363d8e1b5862889c5fd9992fdb1e064dac Reviewed-on: https://chromium-review.googlesource.com/891550Reviewed-by:
-
Gauthier Ambard authored
This CL changes the creation of the URL used to get the favicon at the root of the WebSite (www.website.com/favicon.ico), which is used to get a favicon if non is provided in the html of the page. It strips the query part of the URL, to avoid re-downloading a new favicon everytime the query part of the URL changes. Bug: 804077 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1d6224af357065ab749031ca3533d5f5a5d092ff Reviewed-on: https://chromium-review.googlesource.com/889739 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#532900}
-
Lukasz Anforowicz authored
instance. Extensions violate browsing instance boundaries. The UMA metrics added in this CL should help confirm or deny the theory that violating browsing instance boundaries is only needed for looking up background contents / pages (of VIEW_TYPE_BACKGROUND_CONTENTS type). Bug: 718489 Change-Id: I69246c7d38962c85c55b2e4d271b19eaae1dae1e Reviewed-on: https://chromium-review.googlesource.com/766469 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#532899}
-
Eric Boren authored
I missed this account on my last CL. Bug: 799919 Change-Id: I8cd866cfed3c0a846cc20e2135a4a92b372bf608 Reviewed-on: https://chromium-review.googlesource.com/893440Reviewed-by:
-
Tommy Steimel authored
This CL makes use of the size_ member of the MediaControlsImpl when updating the overflow menu for modern media controls. This fixes a bug where a video of normal size will have all controls in the overflow menu because it thinks the size is 0x0. Bug: 805690 Change-Id: I11dc8f991696d4771f517d6cca585b3e293bb57a Reviewed-on: https://chromium-review.googlesource.com/886656Reviewed-by:
-
Marton Hunyady authored
Bug: 785275 Change-Id: I30e401025d78ef5e9771c9ee11b3570b8968beb6 Reviewed-on: https://chromium-review.googlesource.com/888624Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Marton Hunyady <hunyadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#532896}
-
Ashley Enstad authored
Turns out pylib is needed to discover all the benchmarks in benchmark_runner Bug: 758632 Change-Id: I1b4d1106c8c32ab87b7431fa9331d67777a925a9 Reviewed-on: https://chromium-review.googlesource.com/893208Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#532895}
-
Jungshik Shin authored
A couple of fuzzers that rely on url/ didn't initialize ICU. Because url/ depends on ICU for IDN handling, this results in an assertion failure when ICU's IDN class is initialized. Initialize ICU in a test enivornment for the following fuzzers: payment_method_manifest_parser_fuzzer csv_reader_fuzzer In addition, print a human readable error message instead of a numeric error code. Bug: 754996 Test: The two fuzzers above do not fail the assertion about UIDNA. Change-Id: I942d339d1ef1d71dd5c9c4e79a774f2c2980555d Reviewed-on: https://chromium-review.googlesource.com/871350Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Eugene But authored
Some web sites return HTML page instead of PassKit object if request's User Agent is not a known iOS browser. Bug: 806759 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I566fe85eadb889dd715ddf858b07b6cef4a736c5 Reviewed-on: https://chromium-review.googlesource.com/891760Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#532893}
-
Danyao Wang authored
I believe this is a latent bug. NSURLReuest should reflect the actual URL to be loaded in the web view, not the virtual URL that is meant to be displayed to the user. Using virtual URL here breaks WKBasedNavigationManagerImpl::Restore(), which creates a NavigationItem whose URL is restore_session.html and whose virtual URL is the to-be- restored page for display in omnibox. The virtual URL usage was introduced in https://codereview.chromium.org/2581193002. The CL description indicates that virtual URL may not have been the correct value to use here in the first place. Bug: 807102 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5d40be25ee26e370ffa960b6acb2fb7e74ee91d6 Reviewed-on: https://chromium-review.googlesource.com/892285 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
-
Mounir Lamouri authored
This is allowing us to compute a MEI score during the warm up period and cut down the warmup period if we know that the score would at worse already be high enough. For example, with minimum visits at 10 and MEI threshold at 3, after 3 visits with playback, a website could get MEI privilege instead of waiting for the 7 following visits. Bug: 807268 Change-Id: Id5f65f2d97375ed7507b99925459ab11139c2ae4 Reviewed-on: https://chromium-review.googlesource.com/893263Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Mounir Lamouri (slow) <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#532891}
-
vitaliii authored
Expect external/wpt/html/syntax/parsing/html5lib_tests16.html?run_type=uri to flakily timeout on Mac and Linux (in addition to Win). TBR=nednguyen@chromium.org,robertma@chromium.org Bug: 803943 Change-Id: I20e5af250cccf8efec2673ee390a2eae892d4aea Reviewed-on: https://chromium-review.googlesource.com/893399Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#532890}
-
David 'Digit' Turner authored
A small cleanup and/or improvement to the way global data is managed in the crazy linker library: - Replace ScopedGlobalLock with ScopedLockedGlobals which allows reducing the number of Globals::Get() call performed at runtime. - Provide property accessors to the globals that don't call Globals::Get() on each call, e.g. the static Globals::GetLibraries() is replaced by the non-static Globals::libraries() call. - In crazy_linker_api.cpp, Fix a minor bug where the ScopedDelayedCallbackPoster is constructed before the global lock is acquired (i.e. a thread-race). Note that there are still other thread-related issues with deferred tasks / callback handling but these will be addressed in a future CL. - Don't use heap allocation for the Globals instance storage. This is mostly because there were suspicion of invalid pointer addresses being passed through callbacks, causing runtime crashes (see http://crbug.com/796938 for more details). A fixed address in the .bss section would be easier to spot in minidump CPU register dumps. BUG=801548 R=agrieve@chromium.org,pasko@chromium.org,rmcilroy@chromium.org Change-Id: I68cba5360c5b5a3aaa7847172a6e73a87a64d44b Reviewed-on: https://chromium-review.googlesource.com/893259Reviewed-by:agrieve <agrieve@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#532889}
-
Colin Blundell authored
This CL reverts d8bd981f, in effect relanding the changes to have RemoteSuggestionsFetcherImpl and its unittest use IdentityManager. In the interim I have landed a fix to the bug that necessitated reversion of those CLs, i.e. the raciness between IdentityManager getting updated on signin/signout and other SigninManager::Observers getting updated on those same events (fix is here: https://chromium-review.googlesource.com/c/chromium/src/+/883347). To test this change, do the following: - Sign in to Chrome on Android (in a chrome_apk build if building locally) - Observe that there are personalized suggestions on the NTP - Sign out - Observe that there are different, generic suggestions on the NTP You can also more generally that the suggestions get updated on various transitions between a signed-out state and a signed-in state. TBR=gambard@chromium.org Bug: 798413 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I37d182718ef0b53a85be1a083f203aa0acdb3d8d Reviewed-on: https://chromium-review.googlesource.com/888617 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#532888}
-
Finnur Thorarinsson authored
Earlier I fixed a crash in updateSelectionState by returning early. That, however, isn't enough because onSelectionState also calls isPictureTile, when it is not safe to do so (because initialize hasn't been called). A better way is to move the early return up one function in the callstack (from updateSelectionState to onSelectionState), which should catch both of these issues. To be sure, I also checked if updateSelectionState could be called outside of onSelectionState and found two variants: 1) It is called after initialize (when it is safe). 2) It is called after we call isPictureTile (e.g. in setChecked), in which case we would already be seeing crash stacks for that (but we're not). Bug: 760785, 656015 Change-Id: I0f200b16cd34698e103dc4c2b07b3f86c948adad Reviewed-on: https://chromium-review.googlesource.com/892886 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#532887}
-
https://skia.googlesource.com/skia.git/+log/7f861927fcd4..6da98f10951f $ git log 7f861927f..6da98f109 --date=short --no-merges --format='%ad %ae %s' 2018-01-29 borenet Update DEPS to use googlesource mirrors Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I1f22855cdcd6699dc5752be4a31e6fda0c93b8ed Reviewed-on: https://chromium-review.googlesource.com/893200Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#532886}
-
Changwan Ryu authored
Adding missing isValid() checks from https://codereview.chromium.org/2752113005/ Also removing mInitialized which can be misleading. BUG=806724 Change-Id: I872b3ce27d6efb57dda65b6ae7b84abdf26c250c Reviewed-on: https://chromium-review.googlesource.com/892106Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#532885}
-
Gabriel Charette authored
(removed constexpr for In*() methods found in earlier patch sets as the inlining incurred too big of a code size increase) Bug: 761570 Change-Id: Iced714ec5541fa67fcafe0c0dbbc56c9353418c1 Reviewed-on: https://chromium-review.googlesource.com/883126Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#532884}
-
Andrii Shyshkalov authored
This is a reland of 38feaec8. It was reverted because of suspicion of causing red "git commit' failure builds. However, that was due to a Gerrit bug. Hence, relanding. Original change's description: > [CQ.cfg] 50% of chromium_presubmit builds will now run on LUCI. > > R=dpranke@chromium.org, jbudorick@chromium.org > > No-Try: True > Bug: 731553 > Change-Id: I12cd97bfee4d1cc7bf81f5c990014a27335a1c50 > Reviewed-on: https://chromium-review.googlesource.com/891666 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532539} Bug: 731553 No-Try: True Change-Id: I89844ce9ae99ae2d2fadb19e6d0db5ab2f759415 Reviewed-on: https://chromium-review.googlesource.com/893538Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#532883}
-
Yi Gu authored
This is a reland of 5978ffa4. Original change's description: > Reland Group effects support in cc::AnimationPlayer > > Patch https://chromium-review.googlesource.com/c/chromium/src/+/742162 > got reverted because it caused cc_unittest failure on CFI bot. This > patch fixed the bug. > > Commit message from the original patch: > > The current cc/animations logic assumes a single animation has a single > keyframe effect and can only affect a single layer. To enable animations > with multiple keyframe effects, cc::AnimationPlayer need to support > multiple AnimationTickers each corresponding to one keyframe effect. > > Currently there is a 1:1 relationship between AnimationPlayer and > AnimationTicker. This patch is to extend it to 1:n. Here is a summary of > changes: > - Introduce a sub-class of AnimationPlayer, a.k.a > SingleTickerAnimationPlayer, to handle the existing logic (single > effect). SingleTickerAnimationPlayer owns only one AnimationTicker as > the AnimationPlayer does today. > - Currently a AnimationTicker is created upon creating AnimationPlayer. > In this patch, tickers are created separately and added to the player > afterwards. Tickers that the player owns may belong to different targets > therefore the player needs to coordinate with AnimationHost regarding > this situation. > - Adjust existing unit tests according to the changes above. > > Bug: 767043 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > Change-Id: If21bad1285c35bbc048fef6b619c8272c0760551 > Reviewed-on: https://chromium-review.googlesource.com/890724 > Reviewed-by: Ian Vollick <vollick@chromium.org> > Commit-Queue: Yi Gu <yigu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532519} Bug: 767043 Change-Id: I5e6e7d796ff03cf76c3e2b0de3c4df5b506bf12d Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/893338Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#532882}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9ea6a24f..3c62a1ec Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I9a3a4bfcbc3ec27290947976788471b768d0c9aa Reviewed-on: https://chromium-review.googlesource.com/893278Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#532881}
-
