GitLab

The additional callbacks caused the SupervisedUserUrlFilter to update its filter unnecessarily, which in turn flakily quit the observer run loop too early.

This CL fixes the flakiness by using the main thread message loop for the SupervisedUserUrlFilter (removing non-determinism), spreading out the synchronization points for site list updates and URL filter updates, and adding additional sanity checks about observed changes.

BUG=452071

Review URL: https://codereview.chromium.org/875423002

Cr-Commit-Position: refs/heads/master@{#313483}

BUG=None

Review URL: https://codereview.chromium.org/882023004

Cr-Commit-Position: refs/heads/master@{#313482}

Revert of PlzNavigate: Add a browser test for basic navigations (patchset #6 id:100001 of https://codereview.chromium.org/715203004/)

Reason for revert:
Broke the build:

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN/builds/7409

http://build.chromium.org/p/chromium.webkit/builders/Linux%20GN/builds/18976

http://build.chromium.org/p/chromium.webkit/builders/Win%20Builder/builds/73255

Original issue's description:
> PlzNavigate: Add a browser test for basic navigations
>
> This CL adds a browsertest that checks that basic browser initiated navigations
> work with browser side navigations enabled.
>
> BUG=376014,376006,376091
>
> Committed: https://crrev.com/cd857adbb07fb2e889fa24282648e1f64ede2c95
> Cr-Commit-Position: refs/heads/master@{#313480}

TBR=carlosk@chromium.org,nasko@chromium.org,clamy@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=376014,376006,376091

Review URL: https://codereview.chromium.org/884683002

Cr-Commit-Position: refs/heads/master@{#313481}

This CL adds a browsertest that checks that basic browser initiated navigations
work with browser side navigations enabled.

BUG=376014,376006,376091

Review URL: https://codereview.chromium.org/715203004

Cr-Commit-Position: refs/heads/master@{#313480}

BUG=None
TEST=user_manager GN ninja build (debug|official; is_component_build=yes|no)
TBR=oshima

Review URL: https://codereview.chromium.org/880203003

Cr-Commit-Position: refs/heads/master@{#313479}

BUG=450167

Review URL: https://codereview.chromium.org/847163002

Cr-Commit-Position: refs/heads/master@{#313478}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e57f7c1..f55332d

TBR=leviw@chromium.org,rjwright@chromium.org

Review URL: https://codereview.chromium.org/882033002

Cr-Commit-Position: refs/heads/master@{#313477}

- expose RunUnitTestsSerially and RunUnitTestsBatch
- hide private static ProcessTestResults in anonymous namespace

This will be used to implement ios-specific unit test
relaunch logic. Exposing the helpers makes it possible
to re-use them in ios code.

BUG=426870
R=sky@chromium.org

Review URL: https://codereview.chromium.org/879883002

Cr-Commit-Position: refs/heads/master@{#313476}

This reverts the removal of the kUseGpuInTests flags done in
https://crrev.com/cf04d9696a7f1f321294bc0970037ddb23c1204d
since it seems this affected performance results.
It also adds it to the new chrome/browser/media/chrome_webrtc_simulcast_browsertest.cc
test.

BUG=452654,452655

Review URL: https://codereview.chromium.org/879223002

Cr-Commit-Position: refs/heads/master@{#313475}

Main changes are:
- Layout change.
- Selected tree item's color is not inverted now.
- Use core-icon's preset icons for for subfolders.
- Add touch feedback.

BUG=402344
TEST=run browser_tests

Review URL: https://codereview.chromium.org/884653002

Cr-Commit-Position: refs/heads/master@{#313474}

With the display configuration now asynchronous, we can't immediately read the display size. We need to wait until the hardware is probed.

Also the VSyncProvider cannot trigger the given callback until the PlatformWindow is properly setup with the display. We need to wait for it the actually be resized.

BUG=447798
TEST=run video_decode_accelerator_unittest on freon

Review URL: https://codereview.chromium.org/835653005

Cr-Commit-Position: refs/heads/master@{#313473}

BUG=452799

Review URL: https://codereview.chromium.org/885563002

Cr-Commit-Position: refs/heads/master@{#313472}

Previously, this unit test was consistently failing because DOM wrappers were
retained at the time of detecting Document leaks. This patch adds a call to
V8's gc() before the leak check to make sure the DOM wrappers are freed.

BUG=422244
R=kouhei@chromium.org

Review URL: https://codereview.chromium.org/882913002

Cr-Commit-Position: refs/heads/master@{#313471}

Registration info and its version attributes owned by SWProviderContext can be
accessed from both the main thread and the worker thread, so they are protected
by a lock operation. However, getter functions for those info and attributes are
separated and returned values could be in an invalid state due to interleaved
operations.

This CL merges getter functions (registration() and GetVersionAttributes()) into
GetRegistrationInfoAndVersionAttributes() and avoids such an unexpected state.

BUG=437677
TEST=should pass all existing tests

Review URL: https://codereview.chromium.org/885443006

Cr-Commit-Position: refs/heads/master@{#313470}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/cb45ad8..e57f7c1

TBR=leviw@chromium.org,rjwright@chromium.org

Review URL: https://codereview.chromium.org/870263003

Cr-Commit-Position: refs/heads/master@{#313469}

TopSites was created and owned by profile.

This patch creates a TopSitesServicefactory which is keyedService.
So now instead of calling GetTopSites() from profile, can get the TopSites from
TopSitesFactory.

BUG=435501

Review URL: https://codereview.chromium.org/815983002

Cr-Commit-Position: refs/heads/master@{#313468}

The test was disabled because it was flaky.  This CL tries to address that
and reenables the test.

BUG=346797
R=dtseng@chromium.org

Review URL: https://codereview.chromium.org/866713002

Cr-Commit-Position: refs/heads/master@{#313467}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/879203003

Cr-Commit-Position: refs/heads/master@{#313466}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c042635..cb45ad8

TBR=timloh@chromium.org,leviw@chromium.org

Review URL: https://codereview.chromium.org/885573003

Cr-Commit-Position: refs/heads/master@{#313465}

This is part of a series moving IO on evdev devices to a fast thread,
since UI thread is too slow for the cursor.

EventModifiersEvdev is a UI thread object, so move all remaining
ui::Event construction outside of the device-specific objects. Devices
no longer get a EventModifiersEvdev* since they will execute on a
different thread.

This completes the series moving ui::Event construction out of device
objects and into EventFactoryEvdev.

BUG=449710
TEST=boot link_freon & click mouse

Review URL: https://codereview.chromium.org/867803004

Cr-Commit-Position: refs/heads/master@{#313464}

On some platforms, we run part of the media pipeline in the browser process. For example, on ChromeCast and on Android,  audio/video buffers are decoded in the browser process. Currently, there are some ad-hoc IPC mechanism implemented for these platforms to support hosting  the decoders in the browser process. This CL aims at providing a common mojo based path to support this scenario.

This CL makes it possible to host a mojo::MeidaRenderer service in the browser process. By default, it's using media::RendererImpl and some default audio/video decoders. In later CLs, I'll update this so that we can support embedder specific media::Renderer implementation in MojoRendererService.

Note that media playback is NOT working yet due to DataPipe is not working out-of-process.

Test steps:
1, Change "enable_media_mojo_renderer" to true in media/media_options.gni.
2, Build a GN build of Chrome.
3, Play <video> in Chrome.

BUG=431776
TEST=See above test steps.

Review URL: https://codereview.chromium.org/712463004

Cr-Commit-Position: refs/heads/master@{#313463}

Move the polymer.html into the individual custom elements (such as viewer-progress-bar) from index.html and index-material.html.

Review URL: https://codereview.chromium.org/869013002

Cr-Commit-Position: refs/heads/master@{#313462}

Before this patch, information about renderer that crashed
at startup (i.e. failed to start) was not forwarded to WebContents, etc...

BUG=452812

Review URL: https://codereview.chromium.org/879533006

Cr-Commit-Position: refs/heads/master@{#313461}

Cr-Commit-Position: refs/heads/master@{#313460}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/334b845..c042635

TBR=timloh@chromium.org,leviw@chromium.org

Review URL: https://codereview.chromium.org/880203002

Cr-Commit-Position: refs/heads/master@{#313459}

Some audio input devices don't generate caputure data in a continuous basis, and
instead only generate when some event happens. This may be an indefinite amount
of time. However, |AudioSink::OnSetFormat| is only called whenever new samples
come in. For pepper plugins, this means that |MediaStreamAudioTrack::Configure|
can be blocked indefintely on these devices. To work around this, get the
format before attaching to the audio track.

BUG=403138

Review URL: https://codereview.chromium.org/857093002

Cr-Commit-Position: refs/heads/master@{#313458}

BUG=

Review URL: https://codereview.chromium.org/874393003

Cr-Commit-Position: refs/heads/master@{#313457}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7fa6ed7e..334b845

TBR=timloh@chromium.org,leviw@chromium.org

Review URL: https://codereview.chromium.org/880193002

Cr-Commit-Position: refs/heads/master@{#313456}

searchFilesByHashes
computeChecksum

BUG=None

Review URL: https://codereview.chromium.org/883993003

Cr-Commit-Position: refs/heads/master@{#313455}

BUG=none

Review URL: https://codereview.chromium.org/880123002

Cr-Commit-Position: refs/heads/master@{#313454}

Add metric to log whether or not wake on WiFi is disabled
in the duration of a single suspend because of excessive
dark resume wakes.

BUG=chrome-os-partner:35518
TEST=None.

Review URL: https://codereview.chromium.org/876373002

Cr-Commit-Position: refs/heads/master@{#313453}

Swarming uses the command baked into the isolate (via test_env.py) for running
test instead of using the runtest.py script.  Hence, test_env.py needs to
learn everything runtest.py already knows -- for example, that tests can't
run with the sandbox in asan/win yet.

BUG=451741,382867
TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/882913004

Cr-Commit-Position: refs/heads/master@{#313452}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/25b7611..8b0a05a

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/884623002

Cr-Commit-Position: refs/heads/master@{#313451}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7f3bd0d..7fa6ed7e

TBR=timloh@chromium.org,leviw@chromium.org

Review URL: https://codereview.chromium.org/876343005

Cr-Commit-Position: refs/heads/master@{#313450}

Bad things happen if you delete the profile that started the Metro
process (at best, you crash), since relaunching Metro with a new user
is not supported. Hiding the button selectively depending on the
profile selected is a bit weird, so in Metro mode, hide it for all
profiles.

BUG=448352

Review URL: https://codereview.chromium.org/863063002

Cr-Commit-Position: refs/heads/master@{#313449}

This CL is split off from http://crrev.com/785463002 and
Window::GetFocusedTextInputClient is necessary in that CL.

BUG=290701

Review URL: https://codereview.chromium.org/860983004

Cr-Commit-Position: refs/heads/master@{#313448}

This pulls in the following Native Client changes:

939a13a (teravest@chromium.org) Provide an irt_core_lib GN target.
dbf2af4 (sbc@chromium.org) Remove include of build_config.h from nacl_exception.h
e205317 (jfb@chromium.org) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
7c8a96b (jfb@chromium.org) Update revision for PNaCl
3d00a54 (jfb@chromium.org) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
1de8ba8 (mseaborn@chromium.org) Update codereview.settings following the switch from SVN to Git
7a6cf46 (jfb@chromium.org) Update revision for PNaCl
bc28c0b (jvoung@chromium.org) Fix the native_client URL in the PNaCl REV file.
f8aa9dc (bradnelson@google.com) Adding le32-nacl build of pnacl tools.
cfda521 (teravest@chromium.org) Explicitly include build_config.h.
61b7ba9 (teravest@chromium.org) Output depfile from build_nexe.
2d65c23 (jfb@chromium.org) PNaCl: Update LLVM and Subzero revision in pnacl/COMPONENT_REVISIONS
5f5cd88 (sbc@chromium.org) Fix PNaCl redirectors for i686-nacl-xx -> x86_64-nacl-xx
1baa204 (jvoung@chromium.org) Remove some more dead code and variables from pnacl/build.sh.
f116471 (dschuff@chromium.org) Update revision for PNaCl
01f3d97 (teravest@chromium.org) Always define product_dir in build_nexe.
8a5a846 (mseaborn@chromium.org) Remove the IRT's now-unneeded call to NaClSrpcModuleInit()
c14b58a (mseaborn@chromium.org) Remove NaClPluginLowLevelInitializationComplete() (caller of "init_done" SRPC)
c5d8394 (bradnelson@google.com) Change driver bash scripts to work in devenv.
490e554 (dschuff@chromium.org) PNaCl: Update Clang revision in pnacl/COMPONENT_REVISIONS
2a7391a (sbc@chromium.org) Fix several issues with update_pnacl_tool_revisions.py
fbc3b5c (dschuff@chromium.org) Support filenames with spaces in the PNaCl driver scripts.
4f726e8 (sbc@chromium.org) PNaCl: Update Clang revision in pnacl/COMPONENT_REVISIONS
28a1341 (dschuff@chromium.org) Move pnacl driver test runs from buildbot_pnacl.sh to buildbot_pnacl_toolchain.py
9f9d773 (sbc@chromium.org) Update GCC revision in tools/REVISIONS
29ae54a (jfb@chromium.org) Update revision for PNaCl

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_nacl_sdk_build

Review URL: https://codereview.chromium.org/881893003

Cr-Commit-Position: refs/heads/master@{#313447}

The CL dumps gesture property values for touch devices that run
with the CrOS gesture library. The format is designed to be
backward-compatible with the X11 behaviour.

Contributed by sheckylin@chromium.org

BUG=450159
TEST=samus ChromeOS build

Review URL: https://codereview.chromium.org/864253002

Cr-Commit-Position: refs/heads/master@{#313446}

This CL refactors the check for invalid render_frame_message_source_ to a common method and uses it in all of the relevant IPC handlers. Ideally it will all be removed once RenderViewHost disappears or all of its IPC handling is removed.

BUG=451932, 449777

Review URL: https://codereview.chromium.org/877203002

Cr-Commit-Position: refs/heads/master@{#313445}

Previously, the PDF extension UI was zoomed to the default zoom level
and the PDF was inversely affected (due to various calculations using
zoomed and not zoomed sizes). This resets the zoom level for extensions
used as mime handlers on mime handler WebContents creation and for print
preview (as the PDF extension zoom as controlled by the embedding print
preview dialog WebContents.

BUG=450910

Review URL: https://codereview.chromium.org/881553003

Cr-Commit-Position: refs/heads/master@{#313444}