- 10 Jul, 2019 40 commits
-
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iab73f67cb4b7c9700ce824fddd88bb8e3706d2c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695841Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676036}
-
arthursonzogni authored
There are two code paths for loading about:srcdoc: 1) browser-initiated: It happens during history navigations to about:srcdoc. This is the same code path used by every other "normal" navigation. 2) renderer-initiated: Used whenever the iframe.srcdoc attribute is set or modified. The new document is loaded without going through the browser process. The browser process receives DidCommitProvisionalLoad for a navigation is has never seen before. The two code paths are not necessary equivalent. The implementations can differ a bit and leads to bug. See https://crbug.com/949510. It is hard to test for both code path every time. All navigations should uses (1). This CL removes the about:srcdoc edge case (2). Bug: 936696 Change-Id: Ia14f4bf572af976356e8c21665dac70dd612f603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547522 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#676035}
-
Jared Saul authored
Also removes 5 tests that only have relevance as long as the checkbox exists (which it no longer does) Bug: 941664 Change-Id: If61fb91ed2c9b8b8d2e15f2d60733f4195845b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682429Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Anne Lim <annelim@google.com> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#676034}
-
Lan Wei authored
MouseEventManager::RecomputeMouseHoverState may change the hover dirty flag because it sends mouse boundary events such as mouseover, mouseout, mouseenter and mouseleave, which may change the layout. We need to reset |hover_state_dirty_| before we call RecomputeMouseHoverState, so that we make sure that the hover is updated for all the layout change. Bug: 877132 Change-Id: Id6ec90e8f6ced06a68dffa1a31cd34b92294af37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689959 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#676033}
-
Rouslan Solomakhin authored
Before this patch, 41 error strings were auto-generated for Java, but only 14 of them were used on Android. This patch separates the strings that are used only from native C++ code into their own native_error_strings.h/cc files, which are not auto-generated into ErrorStrings.java. After this patch, only the 14 error strings referenced from Java are generated into ErrorStrings.java. Bug: 977145 Change-Id: Id3652179c124ba1742b52aa2beaaca3d499d5d90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692113Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#676032}
-
Jan Wilken Dörrie authored
This change implements TouchToFillController::Show() and hooks it up with AutofillPopupController::OnSuggestionAccepted(). In particular, TouchToFillController::Show() will construct a AccessorySheet from the passed in autofill suggestions, ignoring suggestions that do not directly correspond to usernames and passwords. TBR=ftirelo@chromium.org Bug: 957532 Change-Id: I6c27d9841bd173ae59f81ea92f019703f050eb80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674158 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#676031}
-
Clemens Arbesser authored
Bug: b/133725664 Change-Id: Ifc03bfc11dec8f6cc24456a4fca71b89d8471acc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687398 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#676030}
-
Hector Carmona authored
Tests that were disabled: WebRtcAudioBrowserTest.CanMakeVideoCallAndThenRenegotiateToAudio WebRtcAudioBrowserTest.EnsureLocalVideoMuteDoesntMuteAudio WebRtcAudioBrowserTest.EnsureRemoteVideoMuteDoesntMuteAudio WebRtcAudioBrowserTest.EstablishAudioOnlyCallAndEnsureAudioIsPlaying WebRtcAudioBrowserTest.EstablishAudioVideoCallAndEnsureAudioIsPlaying WebRtcAudioBrowserTest.EstablishAudioVideoCallAndVerifyUnmutingWorks WebRtcAudioBrowserTest.EstablishIsac16KCallAndEnsureAudioIsPlaying Bug: 982421 Change-Id: Idfc98ac075aa33436e4d2a8db47b62049162648f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694242Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#676029}
-
Javier Ernesto Flores Robles authored
Bug: 974255 Change-Id: I8da5bed54634cefe5df41f22fa6abdc9a0916094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695365Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#676028}
-
Ruslan Burakov authored
Modify Size method so it accounts only for whitelisted stats in RTCStatsReport. This is not an issue currently but may become one once if more unwhitelisted stats are added. Bug: 908072 Change-Id: Ie9ec6bd815b8d8c5556b36b1c96bae247bb52e1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692180 Commit-Queue: Ruslan Burakov <kuddai@google.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#676027}
-
Andrew Grieve authored
Script can be used with .csv files downloaded from telemetry in order to identify commits that grew/shrank by significant amounts. Change-Id: I719b4edf06a1982890b1410b5211b79cf35e710e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694095Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#676026}
-
Sylvain Defresne authored
Change the sign-in workflow on iOS to 1. load all accounts from the SSO library, 2. set the primary account. With this change, semantic of sign-in is similar between iOS and desktop as the account infos are available when PrimaryAccountMutator::SetPrimaryAccount() is called. This required removing the DCHECK in ReloadAccountsFromSystem() as the primary account is not set when invoked as part of the sign-in. This is safe as all the caller of ReloadAccountsFromSystem() either correspond to sign-in workflow or check that the primary account is set before calling the method. With https://crrev.com/c/1687254, the hosted_domain that has been fetched before invoking AuthenticationService::SignIn() is returned by DeviceAccountsProvider. Thus CHECK that the primary account has the expected value after calling LegacyReloadAccountsFromSystem(). Bug: 926940 Change-Id: I98e4a02b6b077c41d8f51e19a5536d4661d9396f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667346 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#676025}
-
Alexei Svitkine authored
Removes some metrics that are not needed and also revamps Variations.SeedStore metrics to log the two things we really care about: - Breakdown of payload types - Total size The detailed ratio metrics are not really needed. These can be computed server-side when issuing the response if needed. Other updates: - Ensures at least two owners set on all current Variations.* histograms. - Sets expiry to M90 for variations histograms without expiry and those expiring in M77 that should be kept. Bug: 975515, 975466, 975546, 975655, 975694 Change-Id: I35c38cce390c4bdf05b2459e272ac1df32448703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692763Reviewed-by:Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#676024}
-
Sophie Chang authored
Bug: 969558 Change-Id: I6b94d42b47b68a5cf07bc5ad4a5ebe60798d5455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693393Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#676023}
-
sczs authored
- configureModalViewController now returns true or false depending on the modal being configured successfully. - Adds a completion parameter that only gets executed if the Modal is presented successfully. - Reduces the tap animation time. Bug: 981822 Change-Id: I89058d2342aee0190f7796e9e3b8576d7936b392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692756Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#676022}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b42af2f2cc97..abb5a315af45 git log b42af2f2cc97..abb5a315af45 --date=short --no-merges --format='%ad %ae %s' 2019-07-10 bsalomon@google.com Revert "Restore GL_UNPACK_ROW_LENGTH to 0 between MIP levles" 2019-07-10 borenet@google.com [infra] Fix WASM Gold aggregator build 2019-07-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 5dfad811ce32..4e71b2bc2546 (11 commits) 2019-07-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 9a8eb165..9d81bd85 (434 commits) 2019-07-09 benjaminwagner@google.com Fix test TextBlob_serialize 2019-07-09 bungeman@google.com Fix header name in build file. 2019-07-09 jlavrova@google.com Adding locale 2019-07-09 bsalomon@google.com Restore GL_UNPACK_ROW_LENGTH to 0 between MIP levles 2019-07-09 egdaniel@google.com Move last few uses of SkColorType out of GrCaps. 2019-07-09 bsalomon@google.com Fix up row bytes for single level texture in GrResourceProvider. 2019-07-09 brianosman@google.com Only include angle in default configs when it's enabled 2019-07-09 borenet@google.com [infra] Make infra tests idempotent 2019-07-09 borenet@google.com Revert "[infra] No task deduplication" 2019-07-09 fmalita@chromium.org Remove onMakeBurstPipelineContext 2019-07-09 fmalita@chromium.org Optional local matrix for SkShaders factories 2019-07-09 robertphillips@google.com Make Mock GrBackendFormat use GrColorType (instead of GrPixelConfig) 2019-07-09 michaelludwig@google.com Reland "More optimizations for CropToRect, for axis-aligned quads that have not been inverted" 2019-07-09 borenet@google.com [infra] No task deduplication Created with: gclient setdep -r src/third_party/skia@abb5a315af45 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:98125,chromium:98125,chromium:980608 TBR=fmalita@google.com Change-Id: Ic50a5764cb8d15a3aa3b928202492f9eae95fbff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695705Reviewed-by:
-
Fredrik Söderquist authored
Bug: 969402 Change-Id: Ia69847c76d6585108c7be8dbc98370c38276f9d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695408 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#676020}
-
Omer Katz authored
Created a pre-finalizer to reset accessor_ and permission_service_. Bug: 981043 Change-Id: Ie91a044f5991f4b082f8a6c3092a0f8f6a80e029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693009 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#676019}
-
Colin Blundell authored
CoreAccountInfo is exposed in the Identity Service mojo interfaces (via typemapping). However, it is actually part of the browser-side IdentityManager C++ interfaces, and thus it should not be exposed as part of the cross-process Identity Service mojo interfaces. This is a concrete blocker to an upcoming restructuring of //components/signin that will move account_info.h to //components/signin/public/identity_manager, which depends on //services/identity/public:cpp_types. This CL eliminates this problem by expanding the identity_accessor.mojom interfaces in question to simply pass the CoreAccountId, gaia ID, and email address explicitly. I judged that this approach was better than either using a naked Mojo struct for the Identity Service's core_account_info.mojom or creating a duplicate CoreAccountInfo C++ type to typemap it to. The former approach is unwieldy and the latter would introduce unnecessary confusion into the codebase. Bug: 952788 Change-Id: I27be60cdc95687b201be03069d1e7f41c431d4b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688840 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
-
Sergey Poromov authored
Currently log files are uploaded one by one non-compressed. Later these logs are always archived on server side when requested. This change add ability (behind a feature flag) to create a zip archive of the logs on client side and upload as a single file. See: go/fss_zip_log Bug: 940648 Test: Manual, unit tests to be added. Change-Id: I9613a21e8e5b600c4a3dfd935b6865d8ca56ebd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645306 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#676017}
-
Jeremy Roman authored
Tbr: alemate@chromium.org No-Try: true No-Presubmit: true Bug: 982161 Change-Id: I8b57c9bb8abc2ae91b6615f540517ecd1c1cd3a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695886Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#676016}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e46877813496..ef089bcde1e6 Created with: gclient setdep -r src-internal@ef089bcde1e6 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=mcnee@google.com,hcarmona@google.com,hajimehoshi@google.com Change-Id: I7ff65dd998652c5b557a58a0d93c1744091a2c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695704Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676015}
-
Edvard Thörnros authored
The method has been renamed to SVGSMILElement::CheckForNewRestartInterval() and now returns the new interval instead of setting it directly. This is to make it easier to track state changes and follow the flow of the program. It will also make it easier to track down some bug. This is the third step in a series of commits to be able to separate the timing logic from the updating logic. This aims to make it easier to make upcoming edits. No changes should be made with this commit in how the application functions or the runtime, there is however one slight change in the updating of syncbases. If this change has any effects is unknown, but it might cause some syncbases to not update correctly. Bug: 981522, 641437 Change-Id: I23f8d641d22234e16a6434d6025ea558a13e1fae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692576Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Edvard Thörnros <edvardt@opera.com> Cr-Commit-Position: refs/heads/master@{#676014}
-
Xianzhu Wang authored
TBR=wangxianzhu@chromium.org Bug: 918155, 524134 Change-Id: I51e0b365cae7d5f5fd732e7c21d11b9a494f0d35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694249Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#676013}
-
Omer Katz authored
Because XMLHttpRequestProgressEventThrottle is a subclass of TimerBase, the pre-finalizer needs to stop the timer. Also added a is_stopped_ flag to make sure that if Stop is called twice, the second time will be noop. Bug: 981043 Change-Id: Iefc1b92e00a42f2b4ea134a7da121ab838c2aa4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692411 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Alan Cutter authored
This CL addresses use-after-free crashes when observers of the AppBannerManager outlive it. Bug: 982454 Change-Id: Id9a85f3be7b5129d14774923bd90473679cb48e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695321 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#676011}
-
Manuel Rego Casasnovas authored
This reverts commit 9b4b071c. Reason for revert: Similar issues related to CompositingInputsRoot optimization have been appearing. Sadly we still need to disable the optimization for sticky elements. Modified the test case so it includes something extra to make it fail without this code. Original change's description: > [css-contain] Re-enable CompositingInputsRoot optimization for sticky > > This was disabled in r650009 as it was causing some crashes, > however it seems not needed anymore. > > BUG=957250,949887 > > Change-Id: If66879d801c36bf96426d336479913880f3490ae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686671 > Reviewed-by: vmpstr <vmpstr@chromium.org> > Commit-Queue: Manuel Rego <rego@igalia.com> > Cr-Commit-Position: refs/heads/master@{#674975} TBR=vmpstr@chromium.org,rego@igalia.com,chrishtr@chromium.org Bug: 957250, 949887, 982153 Change-Id: Iced199461913d71bab57e88c5605779c8f75d249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693641Reviewed-by:
Manuel Rego <rego@igalia.com> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#676010}
-
Guido Urdaneta authored
The first DCHECK checks that the stream argument has tracks, but since this constructor is called from JS, there is no way to guarantee that. The condition is now explicitly handled in the start() method. Previously, it produced the same error but it nevertheless changed the state to recording. The second DCHECK is incorrect because the DCHECKed condition is actually handled by the code. A test was added for the case of starting a MediaRecorder with a stream containing no tracks. Bug: 980597 Change-Id: I76eebe0a5f1cd51474a5ba2664b3e4397c49f8ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695545 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
Bug: 976640 Change-Id: I973711f79529998b33626b0af9e146271e8b1a80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695411 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#676008}
-
Omer Katz authored
Eager sweeping was used to ensure dtor has access to fields for assertion checking. Replaced the whole dtor with a pre-finalizer. Bug: 981043 Removing EagerSweeping from ScriptPromiseResolver Eager sweeping was used only in debug to assure the dtor has access to fields for assertion checking. Replaced the whole dtor with a pre-finalizer. Bug: 981043 Change-Id: I25fb7caaeab9360510ea129a9d16fb0b92a053ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692415Reviewed-by:
-
Alex Clarke authored
This will let us annotate things which are lower priority than the the navigation associated interface tasks which are all USER_BLOCKING. Bug: 863341 Change-Id: I8983a177530e7071c636ccee2cdb943e0229b004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680265Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#676006}
-
Gabriel Charette authored
R=thakis@chromium.org Bug: 982423 Change-Id: Ic051da1ad281198d3c3e594c9ded63e5802895f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695681 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#676005}
-
Jack Steinberg authored
BUG=972945 Change-Id: Ifa92c598f9d2a8a939aa58d0719f39b25431ed8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685526 Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#676004}
-
Vasilii Sukhanov authored
They are: - PasswordManager.PresavedUpdateUIDismissalReason tracks interaction with the bubble. - PasswordGeneration.PresaveConflict tracks if there was a conflict. Bug: 936011 Change-Id: Ice460d8ec4deba48ce5d24efd18118336a925b6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693008 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Guido Urdaneta authored
Change-Id: If30673a257a48b254738435af086781db0fac671 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695295 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Anthony Vallee-Dubois authored
Running with the geo language model enabled caused a DCHECK on startup because of a pref update happening on the wrong sequence. This moves the offending call to the correct sequence. Bug: 982428 Change-Id: Ib4e1bd641cceb9c035473e37a7ed0636096fc7ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693563Reviewed-by:
Alexandre Frechette <frechette@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#676001}
-
Stephen McGruer authored
This CL adds support for asynchronously painting PaintWorklets for the pending tree in LayerTreeHostImpl. Dirty PaintWorklets are gathered during UpdateSyncTreeAfterCommitOrImplSideInvalidation and dispatched to the worklet thread. When the results are available, the pending tree is marked as painted and life goes on. Note that this CL does not yet use the results for PaintWorklet content; the existing raster-thread path is still in use. That will be switched over in the next patch. Bug: 907897 Change-Id: I9f2921931631144ad8f2ef95e42a9ce1fb888a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649720Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#676000}
-
Rohit Rao authored
The previous implementation was inadvertently calling +setUpForTestCase once per test module, rather than once per XCTestCase. BUG=922813,977161 Change-Id: I49d0f5bc442c4bd793b85f932149699d24f5e665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692527Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#675999}
-
Miyoung Shin authored
This is a follow-up CL of https://crrev.com/c/1692661 that replaced std::unordered_map with WTF::HashMap in layout_shift_region.cc. This CL uses int64_t which is larger than real |int| since the empty value of the key is |max| and deleted value of the key is |max - 1| in HashMap and updates the comment. Bug: 952716 Change-Id: I3c756982f86f148f9d730d8c375a4e6625a4b738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692727Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#675998}
-
Dave Tapuska authored
A few presumbits were failing to be detected that didn't have the prefix. BUG=945971 Change-Id: Ib741b4f10bfcdd6efc12a223444081dec5c4f7e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693398Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#675997}
-
