GitLab

TBR=treib@chromium.org

Bug: 860200
Change-Id: Id0a9b33a4dc185ab7834fbf0dbf478ae3d6e8d26
Reviewed-on: https://chromium-review.googlesource.com/1126101Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572548}

Exits the preedit state upon appending a suggestion.

Bug: 859011
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I65809145b1f846157b24e1cc0b74035f235f834f
Reviewed-on: https://chromium-review.googlesource.com/1120025
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572547}

This reverts commit 4e4521b8.

Reason for revert: This broke the code search builder.

Reverting since everyone in the US is OOO, so this wouldn't be fixed for at least two days.

Bug: 860239

Original change's description:
> Reland "Add luci-go tool to be fetched via CIPD"
> 
> This is a reland of 3bcc71d8
> 
> Original change's description:
> > Add luci-go tool to be fetched via CIPD
> > 
> > Do not remove the adhoc mechanism on GCS that predates CIPD yet, as the recipes
> > need to be updated.
> > 
> > Change analyze to not ignore changes to isolate.
> > 
> > R=tandrii@chromium.org
> > 
> > Bug: 851596
> > Change-Id: Ic068db83dea4c3a0f17b55181de523b16c9838a5
> > Reviewed-on: https://chromium-review.googlesource.com/1097623
> > Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> > Reviewed-by: John Budorick <jbudorick@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#569688}
> 
> Bug: 851596
> Change-Id: I27382d97370376dcca8110c9225c16dada182256
> Reviewed-on: https://chromium-review.googlesource.com/1125000
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#572435}

TBR=maruel@chromium.org,tandrii@chromium.org,ehmaldonado@chromium.org,jbudorick@chromium.org

Change-Id: Ia95f851c24fab175827fc2a7d5d1472713b909af
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 851596
Reviewed-on: https://chromium-review.googlesource.com/1125900Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572546}

After https://chromium.googlesource.com/catapult.git/+/484f9f764dc58973a0466e4bdf1bfd50c75165e2 fix to set the correct value of traffic settings (and makes each of them 1024X slower),
many 3g tests are timed out after 166s.

For now disabling all those tests. Future fix would probably replace these with
better traffic settings like REGULAR_4G or Wifi.


NOTRY=true
TBR=kouhei@chromium.org, ksakamoto@chromium.org

Bug: 859597
Change-Id: I311d598c5e7e83475a5558c5f53d4a9953559a9d
Reviewed-on: https://chromium-review.googlesource.com/1126079Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#572545}

Most service workers will need CacheStoragePtr in a performance
sensitive way. We discovered there is slowness using InterfaceProvider
to get the ptr on first use after worker startup.

Bug: 854905
Change-Id: Iefcd8910d1b8b6ba1cfcc4df79c213abde0f9e3a
Reviewed-on: https://chromium-review.googlesource.com/1124130
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572544}

Bug 751952 has been fixed a while ago, so I think we can remove the
failure expectation for the forwardDelete.html test.

Additionally, there are some comments in bug 698135 that indicate the
crash is not reproducible anymore, which was the reason why there
was a failure entry for the delete.html test.

This CL removes the related entries in the TestExpectations file and
provides a new expected file for the delete.html test. It keeps,
though, a Failure entry for Mac only in the case of the delete.html,
since there are clear interoperability issues with Mac for these use
cases.

BUG=698135

Change-Id: I973b84eb1ea19fa72ba4011001aa750b73e87b0c
Reviewed-on: https://chromium-review.googlesource.com/1124461
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572543}

Previously "Sync Everything" settings switch disabled user consents
datatype. In this CL, the datatype is always enabled (like device info).

Bug: 859825
Change-Id: I345465be97d8b2d95c503130bb2e1274a96f48e1
Reviewed-on: https://chromium-review.googlesource.com/1124330
Commit-Queue: vitaliii <vitaliii@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572542}

Move all the implementation except the test code (to be moved next).

Bug: 783309
Change-Id: Ib79a1bf7e5cc5a5231dcba81b55d78285d5ececf
Reviewed-on: https://chromium-review.googlesource.com/1122126
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572541}

Instead of Chromium IPC macro-defined messages or Mojo, Chrome on Linux
uses hand-pickled IPC messages through a special purpose file descriptor
to send messages from the renderer to the browser host in order to
access FontConfig for font matching and font fallback. This system is
described in docs/linux_sandbox_ipc.md.

For the "Font Matching by Full Font Name / PS Name" effort, see issue
828317, additional out of process font methods are needed. Instead of
adding them to this legacy hand-written IPC, we modernize the Linux
Sandbox IPC mechanism and upgrade it to using Mojo interface definitions
and a service architecture, in which a font service running in an
unsandboxed utility process answers FontConfig requests from the
renderer.

Previous CLs [1], [2] prepared the Font Service to have testing and
additional font fallback and render-style-for-strike methods. Now we can
move Blink over to using this Mojo interface and remove the traditional
sandbox IPC handlers since we do not use the file descriptor based IPC
anymore for FontConfig acces.

For more details, please refer to the design doc in issue 839344.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1091754
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1087951

Bug: 855021
Change-Id: I0f30a726621026566f50402afed00c92940b702c
Reviewed-on: https://chromium-review.googlesource.com/1109964
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572540}

Followup to
https://chromium-review.googlesource.com/c/chromium/src/+/1124320.

TBR=bsazonov@chromium.org

Change-Id: I903bdb3ab076d2e5aec2c5748fd0f1d0c7fdec16
Reviewed-on: https://chromium-review.googlesource.com/1125853Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572539}

script_state.h is used in 4,500+ compilation units, and this CL reduces
its estimated pre-processed size from 2.13MB to 0.79MB.

* Move |kV8ContextPerContextDataIndex| from v8_per_context_data.h to
  script_state.h.
  Also, it should not be an enum item.

* Generated binding code doesn't include v8_per_context_data.h by
  default. So we need to include it if necessary.

Bug: 242216
Change-Id: Icb219357585ccb55a8932131473fe0a9b3bc1484
Reviewed-on: https://chromium-review.googlesource.com/1125592Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572538}

Normally they are created on the signaling thread and initialized in a
PostTask to the main thread, so they are implicitly initialized if you
don't do anything. This is still true.

This CL introduced InitializeOnMainThread() which can be called
explicitly, meaning you don't have to wait for the posted task to run.

This is only relevant if the main thread is doing a blocking call to
the webrtc signaling thread and obtains the adapter earlier than is
possible with a PostTask. This needs to be doable when we have
transceivers and remote tracks are created when you synchronously add
tracks (addTrack, addStream, addTransceiver).

Bug: 777617
Change-Id: I22400466acb925221dff1a6f4db4eeb333936b66
Reviewed-on: https://chromium-review.googlesource.com/1113756
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572537}

BUG=832569
R=mstenshoe@chromium.org,eae@chromium.org

Change-Id: I3405923d394b4d14a509ac28d84358ca6a58e846
Reviewed-on: https://chromium-review.googlesource.com/1125335
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572536}

Bug: 860189
Tbr: eroman@chromium.org
Change-Id: I3e5010f851cf1f502cdca42d1065b24b7ad61523
Reviewed-on: https://chromium-review.googlesource.com/1125803Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572535}

This is only called by ServiceWorkerVersion::StartInternal, which
already assumes the context is alive (since it passes it to
ServiceWorkerProviderHost which uses it).

The motivation is removing the callback passed to Start. This is
currently invoked in only two places:
* When context_ was null (removed in this CL)
* When a OnScriptEvaluated IPC is received from the renderer.

The callback isn't invoked when startup failed before script evaluation,
and in success cases it is invoked before startup finishes (OnStarted()).
It can even be invoked with failure when startup succeeds, when an
uncaught runtime error occurred during script evaluation. I aim to
improve the code by first eliminating the callback then adding back one
when the implementation is capable of calling it in a more sensible
manner.

Bug: 859912
Change-Id: I74643f1a64ef6a637ccd9db6bf1f9e889c814b3a
Reviewed-on: https://chromium-review.googlesource.com/1124722
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572534}

- "Use password for:" title isn't used anymore in the password dropdown.
- The dropdown should have a footer "Manage passwords" leading to the settings.

Bug: 851021
Change-Id: I24696fffa7c2db7bc21c6b9ec7fcb3aa9c277429
Reviewed-on: https://chromium-review.googlesource.com/1125061
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572533}

NOTRY=true
TBR=perezju@chromium.org
CC=johnchen@chromium.org,crouleau@chromium.org
BUG=859175

Change-Id: I9fe4d4d5f2b28c13b8840a0a8c1b4567f1512512
Reviewed-on: https://chromium-review.googlesource.com/1125060Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572532}

Bug: 850437
Test: manually tested
Change-Id: I36952d2962dc46ea0d9867fd89a7841d02fc1bbe
Reviewed-on: https://chromium-review.googlesource.com/1125583Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572531}

NOTRY=true
TBR=perezju@chromium.org
CC=wangxianzhu@chromium.org
BUG=859979

Change-Id: Iaf61159ca9115ecced3c1598fd1934bae54461de
Reviewed-on: https://chromium-review.googlesource.com/1125059Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572530}

Also added integration tests for checking this in the context menu.

Test: browser_test --gtest-filter="ContextMenu/FilesApp*"
Bug: 719959
Change-Id: Ieea3d5d97a4ce47b47812ef64a79325c6d1f1b7a
Reviewed-on: https://chromium-review.googlesource.com/1105211
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572529}

This CL adds namespace unified_consent to all c++ files in folder
//components/unified_consent

Bug: NONE
Change-Id: I93dbfe89f97b69e23d4da3cc5f770c03a56b47c0
Reviewed-on: https://chromium-review.googlesource.com/1122861
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572528}

Makes it possible to --use-live-sites when invoking from command line.

Support for tools/perf/record_wpr was not tested, hence placing an
assert there to avoid surprises at a later stage. Documentation about
record_wpr [1] seems outdated as it does not mention wprgo, but I am not
sure how much outdated it is, could be only this tiny detail.

[1] Documentation page: "Telemetry: Record a Page Set"
    https://www.chromium.org/developers/telemetry/record_a_page_set

Bug: 760498
Change-Id: I2278eba06eeceb724c5ae6779409df00add90a4e
Reviewed-on: https://chromium-review.googlesource.com/1124857Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572527}

When we're in a nested RunLoop we can't run tasks in a batch.
This comment update explains why.

Bug: 828835
Change-Id: I8dcdf7f06d519f0e8087232b2d3c660e26510b60
Reviewed-on: https://chromium-review.googlesource.com/1124694Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572526}

UnifiedSystemTray should not be hidden on the last notification removal,
which is different behavior from old NotificationTray.

TEST=manual
BUG=857336

Change-Id: I083d48455be19d591833a17c9514ca1dbfe6903b
Reviewed-on: https://chromium-review.googlesource.com/1124261Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572525}

This is more aligned with what other data types have and also better
describes what this method is actually doing.

Bug: 516866
Change-Id: I8eb93d645f49427f4e8bf071aaaaa527d63d6772
Reviewed-on: https://chromium-review.googlesource.com/1124855
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572524}

This CL adjusts animation curves of some UnifiedSystemTray elements so
that the animation looks more natural and elements would not overlap
each other.

Detailed spec of the animation curves is still WIP on UX side.

TEST=manual
BUG=858941,857346

Change-Id: Ibdcf9371d5436c5bd7ad6e094dab4b6b88bcf945
Reviewed-on: https://chromium-review.googlesource.com/1124259Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572523}

This CL fixes an issue where the search field was not focused on load
after a CSS change. This seemed to happen because the transition caused
a frame of 'visibility: hidden' to race with the toolbar focus() call.

Bug: 857370
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Id4ac3b15e1f1a886b6fb1c3af4512a878fb87150
Reviewed-on: https://chromium-review.googlesource.com/1122027Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572522}

Prior to this CL, MediaStreamTrackMetrics hooked up to streams, tracking
not only all of the streams' tracks (CONNECTED/DISCONNECTED) but also
any tracks that might be added or removed from the stream.

This has not been necessary to do for a long time, since the RTP Media
APIs are track-based, not stream-based, and the legacy
addStream()-streams are shimmed on top of addTrack(). Adding a track to
such a stream causes addTrack(), and there is no need for the
MediaStreamTrackMetrics class to observe the streams.

With this CL, MediaStreamTrackMetrics only care about tracks (direction,
kind and id). This also covers the Unified Plan use case of tracks not
necessarily belonging to any stream.

There is room for improvements in this area, such as counting tracks
added through replaceTrack(), but that should be handled separately.
This CL removes the dependency on streams which unblocks
RTCRtpTransceiver/Unified Plan work.

Bug: 810708, 777617
Change-Id: I347e729560717be83b7b1a3571f25a8497d65e46
Reviewed-on: https://chromium-review.googlesource.com/1117691Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572521}

It seems awfully strange that location_bar_coordinator_unittest.mm is
testing LocationBarLegacyCoordinator. It might have been a copy/paste
error from http://crrev/c/941131

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0b9bf8d1cfa800fc2075618f9f98cb56ccfa86fd
Reviewed-on: https://chromium-review.googlesource.com/1125399
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572520}

This patch introduces |TextIteratorTextState::GetTextForTesting()| as
replacement of |Substring()|, because it is called only one place and it takes
whole text, for improving code health.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Id71f35c82c1906dfea9503a77506a6a437246bae
Reviewed-on: https://chromium-review.googlesource.com/1125584Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572519}

* Add setBottomBarHeight to IActivityHost
* Hide the bottom bar shadow for dynamic modules

Bug: 859819
Change-Id: Iab6e0d61326a76d32b4cd913061f85797197d7cc
Reviewed-on: https://chromium-review.googlesource.com/1123837Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572518}

CreateLoaderAndStart used in TryCreateDuplicateRequestIds created
network::mojom::URLLoaderPtr and network::TestURLLoaderClient in it and
hence the request got aborted. That will lead to flakiness because on
a slow system the first request got aborted before the second request
arrives. This CL fixes that.

Bug: 799516
Change-Id: I4767d7f98185e633f229315074a9361b14e47e3b
Reviewed-on: https://chromium-review.googlesource.com/1125581Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572517}

Putting this CL through to help because orodley@ can't TBR on the
following CL.
https://chromium-review.googlesource.com/c/chromium/src/+/1125704

TBR=dcheng@chromium.org

Bug: 860168
Change-Id: I3673161fbfcd6940bbb508c149fa68c63c546822
Reviewed-on: https://chromium-review.googlesource.com/1125706Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572516}

A space between two sentences was missing in a comment, so this CL adds it.

Bug: 795462

Change-Id: Iaa1e92b411f919e34cd8a3737dcd289f85fecdf6
Reviewed-on: https://chromium-review.googlesource.com/1125660
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572515}

This CL extracts the logics for handling remote updates and committing
local updates into BookmarkRemoteUpdatesHandler and
BookmarkLocalChangesBuilder respectively.

This is to simplfy the BookmarkModelTypeProcessor.

Before this CL: processor scheduled metadata save only if there is a
change in the metadata without change in the model, because the model
would trigger the save in such cases.

After this CL: processor schedules metadata save every time  remote
updates are processed regardless from they entailed a change in the
model or not. This simplifies the code, and the bookmark storage
should squash subsequent save requests, so consecutive save requests
from the model and the processor should result in only one actually
save on disk.


Bug: 516866
Change-Id: I7918086b31b11f7a72804b152f23af2b059cca3d
Reviewed-on: https://chromium-review.googlesource.com/1124854
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572514}

This is amazing. Essentially if an element has "default" quirky start
margins, and it is an empty block, the end margin (regardless of if it
is quirky or not), becomes quirky.

This doesn't propagate to other elements however, see:
https://www.software.hixie.ch/utilities/js/live-dom-viewer/?saved=6016

A bigger fix might be to change the default stylesheet to make all of
these elements with quirky margins to have quirky margins on each side,
then change the logic for the bottom quirkyness. But this is a pretty
scary change. (This may however match other browsers better eventually).

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I5895a148211a5a1291e9b0a935fea08e094d4ec0
Bug: 635619
Reviewed-on: https://chromium-review.googlesource.com/1124071Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572513}

Prior to this change, the lower illustration would change position
when label strings changed size or the progress bar became visible.

This is prevented by creating two container views, the lower of which is
"bottom aligned", and in which the illustration is the only child view.

Bug: 848118
Change-Id: I17ff9309152482ea718ed1eb13bf65d823a79bcf
Reviewed-on: https://chromium-review.googlesource.com/1125597
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572512}

We expect the precreated AppCacheHost to exist in
AppCacheNavigationHandleCore once navigation starts on the IO thread.
But we know it doesn't exist at some point.  This CL add more logging to
try to narrow down possibilities of where the host was lost, if it was
ever created.

Bug: 857005
Change-Id: I0804b6dd972daf6e28e6ee5bf403e30b94df0b1a
Reviewed-on: https://chromium-review.googlesource.com/1125649Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572511}

TBR=luoe@chromium.org
NOTRY=true

Bug: 859064
Change-Id: I2c8478e61a3680d2a170afa70bd5e689e7e2e97e
Reviewed-on: https://chromium-review.googlesource.com/1125657Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572510}

This CL replaces most MockTimer with MockOneShotTimer or
MockRepeatingTimer as a preparation of OnceCallback support of
base::Timer.

Bug: 850247
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I949bc78c5e103baa610a8a2d1197901ceb090c50
Reviewed-on: https://chromium-review.googlesource.com/1105812
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572509}