- 30 Oct, 2019 40 commits
-
-
Richard Knoll authored
After Chrome UI implementation review we decided that the origin looks better in the footer. This CL moves it there. We can also drop the scheme from the origin as it does not add value here. Before: https://imgur.com/EdtdTB3 After: https://imgur.com/PSIfHmz Bug: 1019323 Change-Id: I8c17372fba5ec6e6eed6aa666bd779aa6b31afde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887792Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#710716}
-
Himanshu Jaju authored
Moves callbacks run on receiving ResponseMessage to a new class. This will be useful for p2p connection changes. Upcoming patch will move logic from SharingService to SharingFCMSender, so now PeerConnectionManager (in the future) can avoid dependency on SharingService for signalling messages. Bug: 1018274 Change-Id: I39ebfe0ef1862b6caa8a0c387e92ff0da797b1ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882320Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#710715}
-
Vasilii Sukhanov authored
The reason for flakiness of EditableComboboxTest on Mac was the 'focus lost' event coming from the OS. It happens due to multiple tests running and creating windows simultaneously. On Mac ScopedFakeNSWindowFocus tries to mock the focus logic of the OS. However, when the window really loses focus, the test gets 'resignKeyWindow' message and it can make the test fail. The CL consumes that message. As checked locally, EditableComboboxTest isn't flaky anymore. Bug: 965601 Change-Id: I1695e466a74da1508f1c54d1697ae6b8e6546c55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879292Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#710714}
-
Chih-Yu Huang authored
Originally when changing resolution, V4L2SVDA just abondoned the surfaces at the image processor. This CL changes V4L2SVDA wait for image processor flushed all surface before changing resolution. Bug: b:143263138 Test: Run video_decode_accelerator_tests on kukui Test: Pass CTS mentioned at issue on kukui Change-Id: I5fb4dc164ba9b1d25a78694e706afdfd7d2acd6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888866 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#710713}
-
Manas Verma authored
Logging the number of times the opt-in promo is shown, and logging the user's decision. Bug: 949269 Change-Id: I18b01686a877c86199de5bf6248c04ad959e7433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867709 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#710712}
-
Sigurd Schneider authored
This test was not flaking because V8 forced a GC to suppress non-deterministm. Temporarily disabling to fix the issue. Bug: chromium:1019613 Change-Id: If0b4e8bbc135cd815e9f8a6765098cfa57a8eb96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889651Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#710711}
-
Ramin Halavati authored
The hard limit for incognito quota is removed and the quota is dynamically set based on a Finch controllable ratio of the amount of physical memory. Bug: 1017120 Change-Id: I218295f661a9080b61bfd0e1487f58678e3bfe1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878190 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#710710}
-
Koji Ishii authored
Following bot results are included. 87 88 89 95 TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Iccc444f5cba4ad8414697de0042fb59b13232ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888231Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#710709}
-
Koji Ishii authored
This patch adds |NGInlineCursor::CursorForDescendants()|, which returns an |NGInlineCursor| that traverses descendants of the current item. This is needed to compute ink overflow of an inline box (WIP: crrev.com/c/1771360), but is likely to be needed in some other places too. Bug: 982194 Change-Id: I3432b3b73580f5b63591c7fc52c35e4b7e3576f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888868Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#710708}
-
Rakina Zata Amni authored
We don't need them, and they're also causing failures in the bfcache bot. Change-Id: I60ed51a01efd0938192969d9cf116915f01df70b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886071Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#710707}
-
Jacobo Aragunde Pérez authored
OzonePlatformScenic used to own a mojom::ScenicGpuHostPtr, but it was actually only used to initialize other objects. Instead, we moved ownership of this object to ScenicSurfaceFactory. Bug: 955171 Change-Id: Iad1bd211e543c663faab050b488578311a0b232a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886616Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Cr-Commit-Position: refs/heads/master@{#710706}
-
Takashi Sakamoto authored
Bug: 1007769 Change-Id: I8b864634100fecbb9cfd6ba9a97dd035c1e6da61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883472Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#710705}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/51a8c8c56e15..00bd42717766 git log 51a8c8c56e15..00bd42717766 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 perezju@chromium.org [Telemetry] Stop collecting legacy values in results object Created with: gclient setdep -r src/third_party/catapult@00bd42717766 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:992427 Change-Id: I9e94f072fd2442c118e5dde4bce0a5a45b39f20d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889343Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710704}
-
Sergio Villar Senin authored
In order to remove the dependency, the web_media_player_action.h file was moved to public/common/media. Since the file is no longer in the public/web directory we are also renaming it to media_player_action.h (and the struct defined in that file to MediaPlayerAction). Bug: 1008303 Change-Id: Ic1a07733acf9e550b1fad717b891f81de16677a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884672Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#710703}
-
Austin Tankiang authored
When there is a forced directory change (e.g. through unplugging a usb), if the gear menu is currently open, the menu items do not update their status with the new directory. This can cause, for example, the 'Format device' item to still be active. This change forces an update on directory change. Modify the formatDialogGearMenu test to test this behaviour too. Bug: 1007566 Change-Id: I8158a2630e6711fb9b8e371faf7f689325043cdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859810 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#710702}
-
Fredrik Söderquist authored
'to' animation is sufficiently special that we may as well treat separately altogether. Sink that part of the check out and clean up code using IsAccumulated(). Bug: 1017723, 231517 Change-Id: I27c63a423fa3ac24896bd4cf8f15f5aa101c4499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886813 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#710701}
-
Tom Tan authored
The instruction 'BRK #F000' does trap on Windows ARM64 which is different from other ARM64 platforms. Calling __debugbreak() which will produce the right encoding and always supported by MSVC and clang. Bug: 893460 Change-Id: I54e2d8de6ae7d9ba5929dc8e382e18a99d5aaeb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879677Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Tom Tan <Tom.Tan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#710700}
-
Martin Robinson authored
This version adds protected memory support to handle calling ATK methods dynamically on the CFI bot. Original change's description: > Reland "Fix emission of AtkValue property change signal" > > This version checks at runtime for atk_value_set_value during testing. > This should allow the change to work on bots running trusty. > > Original commit message: > > > The introduction of text-change signals for the omnibox included a > > regression that prevented the emission of AtkValue property change > > signals. Fix this error and also add an implementation of > > atk_value_set_value. The implementation is used in a test to verify the > > correct behavior. > > > > The fix is that we correct the misuse of a logical operator and now > > always try to emit AtkValue property change events when receiving the > > kValueChanged event in AXPlatformNodeAuraLinux. Bug: 1015387 Bug: 1017177 Bug: 1017548 Change-Id: Iadaea4569944ad0a1be0e1211bbce4ed2c4f6935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879255Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#710699}
-
Nikita Podguzov authored
This CL adds: * chrome.printing API setup including new "printing" permission and printing.idl API description, * One event: OnJobStatusChanged() and its implementation, * Unit tests for this event, * New print job source: EXTENSION. It's not used in print job creation yet but is required for correct implementation of the event. This CL doesn't add any API test since it's impossible yet to create print job via API. API test covering this event will be added together with submitJob() function implementation in follow-up CL. Bug: 996785 Change-Id: I1708631caffdde2395a3d07f2ea7de392d09a63f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824948Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#710698}
-
Carlos IL authored
The DefaultInsecureContentSetting policy had a typo (a quotation mark instead of a period at the end of the sentence), an unrelated CL removed the quotation mark, this adds a period. Change-Id: Ia498560a368f8f8def09bf32eb1fab1d64a1b8a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887650 Auto-Submit: Carlos IL <carlosil@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#710697}
-
Takashi Sakamoto authored
This reverts commit 9dc83eeb. Reason for revert: causes bot_update failure on Win x64 Builder (dbg). Sample build: https://ci.chromium.org/p/chromium/builders/ci/Win%20x64%20Builder%20%28dbg%29/99428 --- error: unable to create file third_party/blink/web_tests/flag-specific/enable-blink-features=CompositeAfterPaint/virtual/controls-refresh/fast/forms/controls-new-ui/color-scheme-validation/color/color-suggestion-picker-appearance-with-scrollbar-expected.png: Filename too long --- Original change's description: > [CompositeAfterPaint] Rebaseline tests > > Most of these rebaselines are for the mock scrollbar change which missed > rebaselining for CAP. > > The other rebaselines are for new tests added for > virtual/controls-refresh. > > TBR=schenney@chromium.org > > Change-Id: Ia710bd0bf371eae8367c1ee3739691985f314840 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888572 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710590} TBR=wangxianzhu@chromium.org,schenney@chromium.org Change-Id: Ic072356ff05e5c738f9b830a3ac398d0d8cb4f73 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889710Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#710696}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c3a51a5e47ba..ebdae1144978 git log c3a51a5e47ba..ebdae1144978 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 95a736bd3347..bb35bb4e5379 (18 commits) Created with: gclient setdep -r src/third_party/skia@ebdae1144978 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: chromium:None Change-Id: I48775ae792e27fcaf0e06fffcae1a5e6b3e85b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889337Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710695}
-
Yoshifumi Inoue authored
This patch gets rid of unused function |SelfFragmentsOf()| for improving code health. Change-Id: Ic900ea5921307c92c59a96c9dfae5655a673a60f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888624 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#710694}
-
Michael Lippautz authored
MatchedPropertiesCache was the single user of custom weakness using HashTraits. Supporting custom weakness in hash tables is responsible for a lot of complications in the tracing protocol. MatchedPropertiesCache was using weakness to hold alive a cached entry as long as all of its matched properties are alive. Once a single matched property dies the entry was removed. This can be modeled using a custom weakness callback that performs the same logic. Cached entry don't have any outgoing edges except for their cached matched properties, so ephemeron semantic is not required. Using a custom weak callback is also faster because the callback is only executed once and not part of the ephemeron fixed point protocol. The cached entry is unlinked using the weak callback and collected on next GC cylce. After this conversion, custom weakness can be removed from hash traits. Weakness should always go through already supported types (e.g. WeakMember). Bug: 1019191 Change-Id: I52b7b24dcba8a3aaca896f86a351da665667fcf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886611 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#710693}
-
Alan Cutter authored
This CL makes the contents separator line conditional on whether the browser window is for a PWA or not. This line was accidentally added to PWA windows by: https://chromium-review.googlesource.com/c/chromium/src/+/1845600 Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=418318&signed_aid=qDxxx-0Dy7v7DRzG1X2IKw==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=418319&signed_aid=foBwMWJfjX_2Kp905p0F6Q==&inline=1 This issue seems to only affect Chrome OS as other platforms happen to position the separator line behind the web contents area: https://bugs.chromium.org/p/chromium/issues/attachment?aid=418333&signed_aid=Yca--FaV3JB8AIOY8YuyYA==&inline=1 Bug: 1012979 Change-Id: I0190e55862636354c63f6256bd55c2cf642db178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885147 Auto-Submit: Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#710692}
-
Hiroshige Hayashizaki authored
Follow-up of https://chromium-review.googlesource.com/c/chromium/src/+/1788876. The spec validator requires `source_context_schema` to contain all supported source contexts, so this CL adds entries for `iframe-blank`, so that generators/validators successfully run. This CL keeps generated test files unchanged. Bug: 1001422 Change-Id: Ic49379a57503cd716badeb4655d64e2985e8916e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889477Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#710691}
-
Yoshifumi Inoue authored
This patch changes implementation of |LayoutReplaced| to utilie |NGInlineCursor| instead of |NGPaintFragment| for preperation of migrating |NGFragmentItem|. Bug: 982194 Change-Id: I55de0f4c050fdd0883bd79bd4e695ee2a9e6aae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883452 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#710690}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2cbe458ddd0e..76abb20f3770 git log 2cbe458ddd0e..76abb20f3770 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 gbiv@google.com afdo: allow merging of branch profiles; merge profiles by version Created with: gclient setdep -r src/third_party/chromite@76abb20f3770 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ifc472053cf1b11f035290953478cd9dc82d6af2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889434Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710689}
-
Michael Lippautz authored
- Virtual Visit methods are always called through base class Visitor using Trace methods. There's no need to keep them in the header file. - Drive-by: Move inlined definitions out-of-line to allow skimming the class header more easily. - Only mark definition as inline as this is an implementation detail. Change-Id: I44993d515eb18498105b0e592e282fcd536c82ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884731Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#710688}
-
Eric Willigers authored
The code in app_browser_controller.cc is within the web_app namespace, so qualifying names with 'web:app::' is redundant. Change-Id: I8852005ec93db644aa9034115d5f6dcafe2f9ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888238 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#710687}
-
Jason Lin authored
Bug: 951132 Test: Enable ChromeVox and open Crostini Installer from settings Change-Id: I703d77cc91177b048f5de0fafdee783611288f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885144Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#710686}
-
David Munro authored
Flag is currently disabled by default, if toggled on it means that enabling linux will install a Debian Buster container instead of a Debian Stretch one. Doesn't affect the default container you get if you start a new container via vmc container start. Bug: chromium:930901 Test: Enable Linux with flag set, cat /etc/os-release to confirm buster Change-Id: I40dea30b019e13301abf081696584162f6a1a7c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883351 Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Auto-Submit: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#710685}
-
Darin Fisher authored
This is a precursor to defining ContentSettingsType via mojom. That change will require more work as Clank depends on an Java definition of this type that is auto-generated from content_settings_types.h. Change-Id: Ieec565c6332528e6fc5112ad04c675d9b6137f1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885973Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#710684}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fb5cf40a8b13..a660eacc675c Created with: gclient setdep -r src-internal@a660eacc675c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ie9d482705fae13118b66bfecf15f31ca1c12e82f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889432Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710683}
-
Jinsuk Kim authored
The only caller of these methods is ChromeActivity class. This CL folds them into the call site. Bug: 995903 Change-Id: If11c291d8c366f173fbcb02e8dba5bb81dc5b29b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884397Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#710682}
-
Anand K. Mistry authored
SmbFs is a FUSE-based filesystem that provides access to SMB file shares. It will have similar capabilities to DriveFs, such as server-side copies, hence the need for a new filesystem type. Bug: 939235 Change-Id: Ibbc21a3211013259a715a9e07760d8050b7bda97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885850Reviewed-by:
Sergei Datsenko <dats@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#710681}
-
Gavin Williams authored
-Creating a new ARIA specific string for the Browse button as the text already displayed next to the button($i18n{selectDriver}) would not make sense spoken out loud. Bug: 987087 Change-Id: I00a3d28672b0ffb85ddc00b49b605975b5e5b182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869478Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#710680}
-
Manas Verma authored
Logging the number of times an UpdateAutofillUserPreference call is made to payments with the intention to switch opt-in status. Bug: 949269 Change-Id: I97c4c907079b7d953b4fc0104ca093777a84dbfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867411 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#710679}
-
Yoshifumi Inoue authored
This patch changes |NGCaretPositionTest| to utilize |NGInlineCursor| instead of |NGPaintFragment| and |NGPhysicalTextFragment| for prepration of migrating to |NFragmentItem|. Bug: 982194 Change-Id: I0bba9a20e4ff9150d65632f5c30892c43cf54887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888622 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#710678}
-
Yoshifumi Inoue authored
This patch changes |InspectorCSSAgent::CollectPlatformFontsForLayoutObject()| to utilize |NGInlineCursor| for preparation of migration to |NGFragmentItem|. Bug: 982194 Change-Id: Id8550ce0d70def5b1eb1f7d442e0e97152cc7fba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880360 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#710677}
-