Commits · 1ef2e0e284c309ffd5f4c7312893eea1b07e2e05 · eriksson monteiro / tangled

12 Mar, 2020 40 commits

[scheduler] Update blink scheduler whitelists · 1ef2e0e2

Alexander Timin authored Mar 12, 2020

R=shaseley@chromium.org

Change-Id: Ib8c97e8f2303ff862cb88dde153c55d73be4bf0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099151Reviewed-by: Scott Haseley <shaseley@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749707}

1ef2e0e2

Revert "[COEP] Report CacheStorage/CORP violations in service workers" · 7909edf0

Oksana Zhuravlova authored Mar 12, 2020

This reverts commit c4f44550.

Reason for revert: this change blocks reverting https://crrev.com/c/2096687 for blink_web_tests failing on Mac10.14 Tests: https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/2403 and  Win7 Tests (1): https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/100679


Original change's description:
> [COEP] Report CacheStorage/CORP violations in service workers
> 
> Do not call BindCacheStorageInternal until we have a COEP reporter to
> pass to RPH::BindCacheStorage.
> 
> Change-Id: I25fd317cbcd6fd84d924472ca73facc007b50c71
> Bug: 1060980
> Cq-Do-Not-Cancel-Tryjobs: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100056
> Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
> Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#749644}

TBR=yhirano@chromium.org,shimazu@chromium.org

Change-Id: Ife904e199a931e0e19963526d88f7c31578a12bb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1060980
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100711Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749706}

7909edf0

Rename IsBlockFormattingContextRoot to IsFormattingContextRoot · fac3c377

Koji Ishii authored Mar 12, 2020

Morten pointed out[1] that this could be other formatting
context, such as when it is an `inline-table`.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2098165/4#message-5be3c0480ce8feff69ae49fffb8613bb02a4876a

Bug: 591099, 982194
Change-Id: I43d12b29ae4ab13a449c11cafb21dacc79c00561
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100407Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749705}

fac3c377

Worker: Create inside settings security origin from constructor origin · 9d6f483b

Eriko Kurimoto authored Mar 12, 2020

This CL changes how to create security origin in inside settings.
Previously, the security origin was created from request script url.
After this CL, it will be created from constructor origin if script url
is not data url, and set to an unique opaque origin if it is data url.

This CL focus on the behavior clearly defined in HTML spec. As for
chrome-extension who is not included in the spec, we still need further
discussion before deciding its behavior, so we keep the previous
behavior in this CL.

See the doc for more information:
https://docs.google.com/document/d/1Vfrvow1PO2OBr_3yI08aHYBl_YW1fQ87enqiHrdlqeA/edit?usp=sharing

Bug: 1053390
Change-Id: I64a2b63979e3ba2bb59673018b7cb89c0ef498f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060224
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749704}

9d6f483b

Roll src/third_party/perfetto a31b0a0fbc1c..9699c560e2c2 (1 commits) · 9eff4ddd

chromium-autoroll authored Mar 12, 2020

https://android.googlesource.com/platform/external/perfetto.git/+log/a31b0a0fbc1c..9699c560e2c2

git log a31b0a0fbc1c..9699c560e2c2 --date=short --first-parent --format='%ad %ae %s'
2020-03-12 hjd@google.com Merge "ui: Rename heap_profiler data source icon to match other icons"

Created with:
  gclient setdep -r src/third_party/perfetto@9699c560e2c2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I32bdb100db607baef90273ac5c06e3191511c660
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100573Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#749703}

9eff4ddd

Reland "Merge blink-specific video_capture_types typemap into the original" · 4e64dc97

Antonio Gomes authored Mar 12, 2020

This is a reland of a9816cf6 (unchanged).

Reason: the failing test seems flaky, failing even before the original
CL was merged, eg

- https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/2362

TBR=guidou@chromium.org

Original change's description:
> Merge blink-specific video_capture_types typemap into the original
>
> This is inspired on [1], by kinuko@.
>
> [1] https://crrev.com/c/2016524
>
> BUG=704136
> R=dcheng@chromium.org, guidou@chromium.org
>
> Change-Id: Ib51d558858d831aa1d3ba96345d3986b5afc0c54
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096387
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#749108}

Bug: 704136
Change-Id: I9c244716bf4c3a4e35f6e926d53da9ec6176fe52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100648Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#749702}

4e64dc97

[Kiosk] Terminate kiosk session when in unrecoverable state · 1fd4399f

Anatoliy Potapchuk authored Mar 12, 2020

When browser process crashes, we end up in the state of kiosk mode when
we are simply showing the black screen without any way to exit it. Let's
terminate the user session at this moment for now. In future cls, we
will add proper restart logic.

Bug: 1054382
Change-Id: Ib35ef0582dd5627c59b8851d3072a67e0c7e3b47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093481Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749701}

1fd4399f

Move app dialog code to app_dialog directory, and add owner. · 52e767de

nancy authored Mar 12, 2020

This CL moves below app dialog related files to app_dialog directory:
app_block_dialog_view.h
app_block_dialog_view.cc
app_dialog_view.h
app_dialog_view.cc
app_dialog_view_browsertests.cc
app_pause_dialog_view.h
app_pause_dialog_view.cc
app_uninstall_dialog_view.h
app_uninstall_dialog_view.cc
app_uninstall_dialog_view_browsertests.cc

And add owners for app_dialog directory.

BUG=1016159

Change-Id: Ie24ef8345835f8132ef106ec1d829f62db0abca6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098180
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749700}

52e767de

media: Convert remaining base::Bind in media/formats to rep. callback. · 9cce311a

Jose Lopes authored Mar 12, 2020

All these callbacks are defined as repeating callbacks:
* https://source.chromium.org/chromium/chromium/src/+/master:media/base/demuxer.h;drc=e7dbf40a24290957eabd0a71ce60bfdc01fd71a0;l=59
* https://source.chromium.org/chromium/chromium/src/+/master:media/formats/mp2t/es_adapter_video.h;drc=b62ae460e39369b0ad7d394149e41759a5472629;l=36
* https://source.chromium.org/chromium/chromium/src/+/master:media/formats/mp2t/es_adapter_video.h;drc=b62ae460e39369b0ad7d394149e41759a5472629;l=38

This is part of the base::Callback migration.

Context: http://doc/1J4N3V5UmzZL9BZGNrn95E4xJu4cz3ynbg21zXR-J_qA#heading=h.uxpxu8vg4k4r

Bug: 1007806
Change-Id: I42c5da3650ef76661acc58d1498d96134e92aa53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098630
Auto-Submit: Jose Lopes <jabolopes@google.com>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749699}

9cce311a

Replacing AcceleratedResourceUsage in WebGL to individual methods · feb29fb4

Juanmi Huertas authored Mar 12, 2020

Removing usage of the fallback method of CreateProvider to the actual
Creation of a SharedImageProvider and if that fails, a BitmapProvider.


Bug: 1035589, 1021287
Change-Id: I2bafd874478022718a725489387709aaace60656
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095341
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749698}

feb29fb4

[Trusted Types] Ignore `require-trusted-types-for` in non-secure contexts. · bb2b2cbf

Mike West authored Mar 12, 2020

Bug: 1059554
Change-Id: Ib92e3ebfb3148aa4634a4f1f29cbbfd8d45fdfdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098076
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749697}

bb2b2cbf

media: Replace base::Bind with Bind{Once,Repeating} depending on callee. · 25ba7b36

Jose Lopes authored Mar 12, 2020

This CL has been automatically generated by running the clang tool
base_bind_rewriters on media/.

This clang tool automatically updates base::Bind calls to match the type
expected by the callee.

This is part of the base::Callback migration.

Context: http://doc/1J4N3V5UmzZL9BZGNrn95E4xJu4cz3ynbg21zXR-J_qA#heading=h.uxpxu8vg4k4r

Bug: 714018

Change-Id: I8fd73eefc84f6421c3f622339d129db7e36d2f33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098903Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Auto-Submit: Jose Lopes <jabolopes@google.com>
Cr-Commit-Position: refs/heads/master@{#749696}

25ba7b36

Support install flow of Plugin VMs from an ISO instead of VM image · e5a3e5df

Dmitry Torokhov authored Mar 12, 2020

This adds support for creating a new Plugin VM and attaching a setup
media to it if image specified in the policy is not a VM image, but an
ISO image.

Bug: b/149619851
Change-Id: I861f11d24d38db1c29ebe6631d6a89dc490a3d98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068871
Commit-Queue: Dmitry Torokhov <dtor@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749695}

e5a3e5df

Update callbacks and bind sites to Once/Repeating in //remoting/client · b36ca0a5

Evan Stade authored Mar 12, 2020

Bug: 1007821
Change-Id: I5d5934b2e4e45f9c615267416a2092ae73f8abf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093167Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749694}

b36ca0a5

Add RenderFrameHost::FromJavaRenderFrameHost(). · c7bdca4a

Danyao Wang authored Mar 12, 2020

This CL adds the plumbing to pass a RenderFrameHost reference from Java
to native. This is modeled after WebContents::FromJavaWebConents().

This new interface is needed for web payments's Java code to send a
RenderFrameHost to native in crrev.com/c/2100013.

Bug: 1055360
Change-Id: I0ce861f0686afca5dc37845d5851469698869832
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099767Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749693}

c7bdca4a

Update media/ directories in PRESUBMIT.py according to command. · 2a59a2d2

Jose Lopes authored Mar 12, 2020

$ for i in `find media/ -maxdepth 1 -type d|sort`; do    echo -n "-- $i ";    (cd $i; git grep -nP 'base::(Bind\(|(Callback<|Closure))'|wc -l);  done
-- media/ 294
-- media/audio 0
-- media/base 26
-- media/blink 17
-- media/capabilities 0
-- media/capture 0
-- media/cast 77
-- media/cdm 19
-- media/device_monitors 4
-- media/ffmpeg 0
-- media/filters 55
-- media/formats 5
-- media/fuchsia 0
-- media/gpu 41
-- media/learning 0
-- media/midi 0
-- media/mojo 48
-- media/muxers 0
-- media/parsers 0
-- media/remoting 0
-- media/renderers 2
-- media/test 0
-- media/tools 0
-- media/video 0
-- media/webrtc 0

This is part of the base::Callback migration.

Context: http://doc/1J4N3V5UmzZL9BZGNrn95E4xJu4cz3ynbg21zXR-J_qA#heading=h.uxpxu8vg4k4r

Bug: 714018
Change-Id: Ifb26a1ea4dc1ac170695b178343f33293883fe41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098686Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Jose Lopes <jabolopes@google.com>
Cr-Commit-Position: refs/heads/master@{#749692}

2a59a2d2

Safety check: starting password check if one is not running already · 23761c42

Andrey Zaytsev authored Mar 12, 2020

Bug: 1015841
Change-Id: I2bc245d1a50e7ef3ef66467f4b849461e13bf40b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100310Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Andrey Zaytsev <andzaytsev@google.com>
Cr-Commit-Position: refs/heads/master@{#749691}

23761c42

Update Pin Request Dialog to current specs. · aba41ee2

Fabian Sommer authored Mar 12, 2020

This concerns the height of the dialog, the handling of multiline titles
and descriptions, and the space between back button and lock icon.

Fixed: 1059858
Change-Id: I182c2329417feb4d2a50e183115e5a8cb7211fc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089684
Commit-Queue: Fabian Sommer <fabiansommer@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749690}

aba41ee2

Fix X-Client-Data being sent for incognito subresource requests. · 52161418

John Abd-El-Malek authored Mar 12, 2020

This regressed in r745404.

Bug: 1060744
Change-Id: I983224321214f6ce43490c4de1f0788f3e3160e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099363
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Auto-Submit: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749689}

52161418

Roll src/third_party/dawn 421684f9438d..0338b7ae194a (1 commits) · 636334f6

chromium-autoroll authored Mar 12, 2020

https://dawn.googlesource.com/dawn.git/+log/421684f9438d..0338b7ae194a

git log 421684f9438d..0338b7ae194a --date=short --first-parent --format='%ad %ae %s'
2020-03-12 brandon1.jones@intel.com Residency 3: Track Resource Heap Usages

Created with:
gclient setdep -r src/third_party/dawn@0338b7ae194a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: Ibd8625019bb64cbadb5a20460864ad922cacb031
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100571Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#749688}

636334f6

Remove network::ResourceRequest custom_proxy_use_alternate_proxy_list · d5f72937

Robert Ogden authored Mar 12, 2020

This field is no longer used since DRP removed non-core proxies, so
let's clean it up.

Bug: 945364
Change-Id: Ica6ba2dbaffcca3db1fd366edf725784b63e89c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096100
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749687}

d5f72937

Replacing AcceleratedResourceUsage in imageBitmapTest · fa666ef8

Juanmi Huertas authored Mar 12, 2020

Removing usage of the fallback method of CreateProvider to the actual
Creation of a SharedImageProvider and if that fails, a BitmapProvider.

Bug: 1035589, 1021287
Change-Id: Iacc44c19ccb8cc9931923bf4cc51bf8b00d71b68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095342
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749686}

fa666ef8

Write to startup sentinel file once per process · e12bd6b0

Emre Kanlikilicer authored Mar 12, 2020

Bug: 1054268: GCPW startup sentinel file is updated 3 times per process (LogonUI)
Change-Id: I3156fe8c51c4d3b2baed16b532dfd5002068fa0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066079Reviewed-by: Tien Mai <tienmai@chromium.org>
Commit-Queue: Emre Kanlikilicer <emreknlk@google.com>
Cr-Commit-Position: refs/heads/master@{#749685}

e12bd6b0

Remove some unnecessary #includes of touch_ui_controller.h. · c41d1fb9

Peter Kasting authored Mar 12, 2020

Bug: none
Change-Id: I2d63751b0b5a000c3ea16155eba77cbfa28a99d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100015
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749684}

c41d1fb9

SelectionController: Rename/remove functions for clarity. · 937fa6d1

Mustaq Ahmed authored Mar 12, 2020

Change-Id: Ie75d61d71fef780c84c25b70c4fddab395ea4ab8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088229Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749683}

937fa6d1

Roll src/third_party/devtools-frontend/src 559b7c953589..3181426885c3 (1 commits) · 7540e8ba

chromium-autoroll authored Mar 12, 2020

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/559b7c953589..3181426885c3

git log 559b7c953589..3181426885c3 --date=short --first-parent --format='%ad %ae %s'
2020-03-12 petermarshall@chromium.org [test] Add an e2e test for console let re-declaration

Created with:
gclient setdep -r src/third_party/devtools-frontend/src@3181426885c3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I39e2dcd89a1bb3e9fbfa21890f08f042ab14cddd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100574Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#749682}

7540e8ba

Refactor to propagate access type through page load metrics. · 5c243308

Justin Miron authored Mar 12, 2020

This change renames OnDomStorageAccess to OnStorageAccess from
MetricsWebContentObserver->PageLoadMetricsObserver. It adds a new
parameter access_type denoting what storage medium is being accessed.

This change is a precursor change to new metrics measuring third party
storage usage. OnStorageAccess is currently used for LocalStorage and
SessionStorage but will be expanded to cover other types of storage
in future changes.

BUG=1059915

Change-Id: I8fe5e6ed8d934723b1d31b6459bd77c4b8baf700
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094213Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: John Delaney <johnidel@chromium.org>
Reviewed-by: Yao Xiao <yaoxia@chromium.org>
Commit-Queue: Justin Miron <justinmiron@google.com>
Cr-Commit-Position: refs/heads/master@{#749681}

5c243308

Removing AcceleratedResourceUsage from CanvasResourceProviderTest · 6aa40e05

Juanmi Huertas authored Mar 12, 2020

Refactoring a test to better test individual type of canvas resource
and replacing instances of AcceleratedResourceUsage for SharedImage and
Bitmap resource providers.

Bug: 1035589, 1021287
Change-Id: I8731cc59aed59a3f56eaeff49845cb9e8f6a0da1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095369
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749680}

6aa40e05

Disable RemoteCopy progress notification tests · dd737a9d

Richard Knoll authored Mar 12, 2020

These seem to cause flakiness so disable them until we find the cause
for that. This feature is behind a flag so disabling the test seems fine
for now.

Bug: 1060869
Change-Id: I49d9841c1122660355b4b57018dbcd09f2b829e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100808Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749679}

dd737a9d

Fix a typo in the PGO config · 53e6560c

Sebastien Marchand authored Mar 12, 2020

Bug: 1056189
Change-Id: I8929621e4ecef829fa83d13e4973d4cefda8574e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100108
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749678}

53e6560c

Remove unnecessary condition · f0da358f

Aaron Leventhal authored Mar 12, 2020

Image <map> already disallows children via CanHaveChildren().

Bug: None
Change-Id: I156f1f33e5864eb5459ccaf252d5afb34cb1329a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100488Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749677}

f0da358f

Wait for extensions in ChallengeResponse · 9a8f4aae

Fabian Sommer authored Mar 12, 2020

ChallengeResponseAuthKeysLoader now waits until force-installed login
screen extensions are installed before requesting a certificate from
these extensions, avoiding an incorrect error message.

In order to know which extensions to wait for, stored
ChallengeResponseKeys now contain the id of the extension that signed
them.

ChallengeResponseAuthKeysLoader will only wait for 5 seconds, then the
error is displayed anyway (e.g. if the extensions failed to load).

Bug: 1052404
Change-Id: I8a24b87cb63f4d899d36a3b0ab30237a6d82f691
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078584Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Fabian Sommer <fabiansommer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749676}

9a8f4aae

Android: Fix incorrect variable names in comments · 988bffd2

Peter Wen authored Mar 12, 2020

Found by errorprone. I'm surprised that they were not caught earlier.

Tbr: Comment changes.
Bug: None
Change-Id: Ia26be03885df3a416978686ad6581be9cd1ec376
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100708Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749675}

988bffd2

Mark MSAN idlharness tests as [Skip]. · 6c8a6a34

Daniel Vogelheim authored Mar 12, 2020

These tests have a very high flakiness because they bump
against the timeout limit, and they are also run on other
bots. So we can just save the effort and drop them from MSAN.

Bug: 1060138, 856601
Change-Id: I7861f65721747334bbc925d48dd4669aedebb5d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096736
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749674}

6c8a6a34

[iOS] Add logging for user sign-in operations in architecture migration. · 13134db6

Nohemi Fernandez authored Mar 12, 2020

Adds logging for first run and sign-in flows.

Bug: 971989
Change-Id: Ieec769b0db013959396be3ee533eb84f206cb9cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087403
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749673}

13134db6

Revert "Move //chrome/android/public/ to //chrome/browser/android/" · eddf4f01

Theresa authored Mar 12, 2020

This reverts commit a8ed939a.

Reason for revert: Moving to different directory

Original change's description:
> Move //chrome/android/public/ to //chrome/browser/android/
> 
> Change 1 of 2. The next CL will update downstream dependencies.
> 
> Note that this will break the downstream build temporarily. Since there
> are JNI files generated, unless the package is updated we cannot keep
> a temporary mirrored build target as was done in
> https://chromium-review.googlesource.com/c/chromium/src/+/2095444
> 
> BUG=1052382
> 
> Change-Id: Ib4d2e6f8143a7c0c6ead75d7701fea69a21db3a3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095760
> Commit-Queue: Theresa  <twellington@chromium.org>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#749666}

TBR=dtrainor@chromium.org,twellington@chromium.org

Change-Id: Ieb5026e18ccbc629be00c6a10762253908a98ae2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1052382
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100709Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749672}

eddf4f01

[iOS] Update Chromium OWNERS for Chrome sign-in iOS. · 3748a163

Nohemi Fernandez authored Mar 12, 2020

Streamlines the existing OWNERS files and adds fernandex@ to sign-in.

Bug: 1060993
Change-Id: I20e91d74fc6d6013904aa5d9faea502b1ee66985
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098629
Auto-Submit: Nohemi Fernandez <fernandex@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749671}

3748a163

milestone_apk_sizes.py - Update for TriChrome · 2ebcde7b

Andrew Grieve authored Mar 12, 2020

Plus resource_sizes.py tweaks:
* Fixes failed sanity check for TrichromeWebView.apk
* Teaches it that TrichromeLibrary is a shared apk

Plus converts milestone_apk_sizes.py to python3

Bug: 1056320
Change-Id: I7691e9ccd7498dab180e104428ed7fe909c18fc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099765Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749670}

2ebcde7b

Disable GOMA for problematic robolectric targets · a1cd2fe4

Andrew Grieve authored Mar 12, 2020

The robolectric_processor annotation processor need extra data files
for it to operation, which GOMA has no way to know to make available.

Easiest fix is to just disable GOMA for the three targets that use the
annotation processor.

Bug: 726475
Change-Id: Idb9c6d6edd9f199a3430499d4835051a4db9ca2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098762
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749669}

a1cd2fe4

Print connector ID not it's pointer · 6f06f0f7

Daniel Nicoara authored Mar 12, 2020

Bug: None
Test: Compiled
Change-Id: I70c10e9c03f937c0e383df55a75014020214d92d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100707
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749668}

6f06f0f7