- 17 Nov, 2020 40 commits
-
-
Marijn Kruisselbrink authored
This reverts commit a3bfafb1. Reason for revert: Breaks compilation, for example on https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux%20%28dbg%29/19608 [14678/62398] ACTION //tools/privacy_budget/blink_apis:blink_apis(//build/toolchain/linux:clang_x64) FAILED: blink_apis.textpb python ../../tools/privacy_budget/blink_apis/generate_blink_api_db.py --web_idl_database gen/third_party/blink/renderer/bindings/web_idl_database.pickle --output blink_apis.textpb --path ../../third_party/blink/renderer/bindings/scripts:../../third_party/blink/renderer/build/scripts:pyproto/tools/privacy_budget/blink_apis/proto:pyproto:pyproto/google/third_party/six Traceback (most recent call last): File "../../tools/privacy_budget/blink_apis/generate_blink_api_db.py", line 74, in <module> main() File "../../tools/privacy_budget/blink_apis/generate_blink_api_db.py", line 66, in main from blink_api_proto import BlinkApiProto File "/b/s/w/ir/cache/builder/src/tools/privacy_budget/blink_apis/blink_api_proto.py", line 10, in <module> import blink_apis_pb2 as pb File "pyproto/tools/privacy_budget/blink_apis/proto/blink_apis_pb2.py", line 22, in <module> create_key=_descriptor._internal_create_key, AttributeError: 'module' object has no attribute '_internal_create_key' Original change's description: > [third_party] Uprev protobuf to v3.13.0.1+ > > Followed process in //third_party/protobuf/README.chromium > Highlights: > * Some protobuf APIs started being deprecated. Moved sources in > //chromecast and //components to start using the non-deprecated > versions. > * Removed most of the patches and updated the ones that are still > needed. No new patches. > * //components/subresource_filter/core/common/unindexed_ruleset.h: > HadError is not const anymore. > > Size increase is caused by protobuf mainlining 2 > functions to Serialize and Parse inside each *pb.cc file. This new > methods are now the way protobuf serializes and deserializes messages > so no way to avoid those without substantially changing protobuf > internals. > > Binary-Size: Unavoidable. Increase intrinsic to new protobuf. > Bug: 1144985 > Change-Id: I23ce43f07da82fdda60575934a4b039200164f48 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518036 > Commit-Queue: Andres Medina <medinaandres@chromium.org> > Auto-Submit: Andres Medina <medinaandres@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828263} TBR=pkasting@chromium.org,caitkp@chromium.org,blundell@chromium.org,halliwell@chromium.org,medinaandres@chromium.org Change-Id: I856a83d283bcf9453cfdd604a4ee7dba539d2b68 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1144985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544866Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#828302}
-
Daniel Hosseinian authored
Now that bookmarks::BookmarkNode stores a base::GUID instead of a std::string, return a base::GUID. Modify the code around callers to make them compatible with the new API. Bug: 1026195 Change-Id: I68968cda23ae48c2c45413ad752e50330c9869df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523745 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#828301}
-
Dave Tapuska authored
These methods are only called from the browser and we can assert they are executed for subframes. BUG=1097816 Change-Id: I152102fc55360769ebec3594aed03d3d452ccbfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537574Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#828300}
-
Nate Chapin authored
BatteryManager can adequately be its own Supplement<Navigator>, reducing boilerplate. Bug: 1147612 Change-Id: I15cfaa7b2778f34a1bc754a8ca54a5361b075ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523362 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#828299}
-
dpapad authored
When PDFViewerUpdate is on, |topToolbarHeight| is always zero. The code that uses |topToolbarHeight| in calculations is effectively a no-op and can be deleted. This CL reverts a subset of the changes in r789720, as they are no longer needed. Bug: None Change-Id: Icd6a6b7b91ae2137e9a81dd68c3c53ad031a3840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541607Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#828298}
-
Peng Huang authored
The meet.google.com rendering issue is because shared_quad_state->mask_filter_info is not transformed correctly. Fix the problem by transform it into the new allocated overlay backing's coordinates. Bug: 1148477 Change-Id: I016c0c01c4e60262d197c7b24f37f1df522859c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542949 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#828297}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5160aada22ed..5035b8f92a0e 2020-11-17 brianosman@google.com Minor cleanup in the intrinsics GMs 2020-11-17 johnstiles@google.com Disallow opaque types in structs and interface blocks. 2020-11-17 johnstiles@google.com Code cleanup: remove macros from AST node creation. 2020-11-17 kjlubick@google.com Update Go Deps 2020-11-17 adlai@google.com Move GrOpsTask::addOp and addDrawOp out of header 2020-11-17 adlai@google.com Remove bulk GrDrawingManager::appendTasks 2020-11-17 robertphillips@google.com Connect DDL offsets in the testing harness to the new ddlTask 2020-11-17 robertphillips@google.com Move SkTTopoSort to src/gpu and rename it to GrTTopoSort 2020-11-17 scroggo@google.com Reland "SkAnimatedImage: Use fSampleSize" 2020-11-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e4c1a25cc679 to 04515da400d5 (3 revisions) 2020-11-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 60570b859f7c to 4f96bf19941b (15 revisions) 2020-11-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 575729e8dd25 to f2bc3b3edd6f (5 revisions) 2020-11-16 nifong@google.com Move SKP version extraction into JS 2020-11-16 jlavrova@google.com Added SK_PARAGRAPH_LIBTXT_SPACES_RESOLUTION to flutter_defines.gni 2020-11-16 herb@google.com clip more cases using the CPU allowing more op merges 2020-11-16 robertphillips@google.com Change UnrefDDLTask to just be the DDLTask (take 2) 2020-11-16 johnstiles@google.com Detect unsupported types for MemoryLayout and report errors. 2020-11-16 mtklein@google.com roll back minimum picture version to 73 2020-11-16 robertphillips@google.com Revert "Remove SkBaseDevice::flush" 2020-11-16 mtklein@google.com make I32a less ambiguous If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: lovisolo@google.com Change-Id: Idce79d55c6dbabee8aa1f7732832e534de5857c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542655Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828296}
-
Ben Pastene authored
Bug: 1146481 Change-Id: I6fb9f2902f38e4c237902681c71d22db0940fe6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542725Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#828295}
-
Steven Bennetts authored
The Service.Error property gets set when running on a VM, which is fine, but it is causing logs.NetworkEventLog to incorrectly fail. We should not be using ERROR for property changes anwyay. BUG=b/167581118 Change-Id: I3a6014876789d2811db6fb1b788dbcec1c76987e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544842 Auto-Submit: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#828294}
-
Peng Huang authored
Rewrite SkiaRenderer::PrepareRenderPassOverlay() to fix the rendering problem. Seems the problem is related to clipping and transforms. Bug: 1147933 Change-Id: I813aee2634aad8691f80527c8d24cd7324d2827f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537067Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#828293}
-
Ben Pastene authored
Some files (like system logs) apply to a test run as a whole, and not necessarily to a single test case. These artifacts can be uploaded to RDB as "invocation-level" artifacts. So this crawls the system_logs and crash dirs after a Tast test and uploads them as "invocation-level" artifacts. Bug: 1129654 Change-Id: I27f4cd27b4293a69364d37aa4be89a4185aa4900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541747Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#828292}
-
Dave Tapuska authored
In http://crrev.com/261e76876c we used the FocusedCoreFrame and this is not necessarily correct for OOPIFs as it might find the selection for another LocalFrame that is not rooted by widget in question but another widget. Go back to the WebFrameWidgetImpl code but fix a few tests which were not setting focus for text selection calculation. BUG=1149653 Change-Id: I6ecbaf3d70cc356bbb1bd1073ac768ba34ffef3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543128Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#828291}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2e8c7015c00a..384b05891b9b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC gogerald@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: gogerald@google.com Change-Id: I228d09581eafe7b5400e6f8e68dbc6faf75df9cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544257Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828290}
-
Bailey Berro authored
Adds the ability to bind the SystemRoutineController interface. Bug: 1128204 Change-Id: Id729b624018fef5dbec273a562ca76a120fcc026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541648 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#828289}
-
Nate Fischer authored
No change to logic, only docs. This expands on the existing CTS docs: * Links to the AOSP source code * Failures must be ReleaseBlock-Dev * How to change test logic * How to run tests locally Fixed: 1138051 Test: Upload to gerrit > open file > click "gitiles" Change-Id: I635718e5d1e4327a1964e617279282a157f14d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542679 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#828288}
-
Jesse McKenna authored
This change removes DISALLOW_COPY_AND_ASSIGN from the IllegalCharacters class, and makes member functions that don't modify the class instance `const`. Change-Id: I3b49140c4fb52aa6ae4982ed0bc6563dad6bd3a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459637Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#828287}
-
Alex Newcomer authored
In Multipaste, show a static string instead of the raw html. Raw HTML used to be shown when: - HTML is not rendered (No IMG or Table tags) - No plain-text content UX does not like this, so instead show "HTML Content". Bug: 1139062 Change-Id: Ic4b164b1449c0ad13ef6a539a4d747b8208a9e04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543084 Auto-Submit: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#828286}
-
Xiaocheng Hu authored
The function is deprecated as it doesn't support custom counter styles. This patch changes some callers to call GetListStyleType() instead. Bug: 687225 Change-Id: I130d09ecdcc9d896cefba1590b9793732bb552c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543369 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#828285}
-
Joe Mason authored
Instruments HTMLFrameOwnerElement to notify RendererResourceCoordinator whenever the content frame changes. If the new content frame is a RemoteFrame, RendererResourceCoordinator will notify PerformanceManager of the frame's RemoteFrameToken and some attribution information for the iframe. PerformanceManager stores this information in V8ContextTracker. Also updates frame_test_helpers::CreateProvisional to accept local frames since the underlying WebLocalFrame::CreateProvisional now allows this. Bug: 1085129 Change-Id: I43d7d7f1309db9c4b1760ca32983c0e8a2f51a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363710Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#828284}
-
Joon Ahn authored
Type annotations must begin with "/**" even if it's a single line. JSC also doesn't seem to infer array destructuring. Bug: 1125150 Test: browser_tests --gtest_filter=Diagnostics* Change-Id: I320080ec0ef4baa0807e07af10f4b9d70d226128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542730 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#828283}
-
Sammie Quon authored
Close the tray bubble when entering capture mode via the tray bubble. Do not close app list or any tray bubbles in capture mode on click or touch. Test: manual Fixed: 1137889, 1141496 Change-Id: Idd231f28be3d58dba823d5f371d630c28c6afc9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487876 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#828282}
-
Xi Han authored
Bug: 1016952 Change-Id: I6707bf7a5e5caef6e002751f7759815f94f14e92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543687Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828281}
-
Renato Silva authored
The custom element used for the Assistant screen now has a proper "-element" suffix to discern the dom-module from the rest of its uses throughout the code. This is a necessary change for using the HTMLImports polyfill in order to avoid clashes in the names. Bug: 1111387 Change-Id: Ib4ec56b74e2c9f035dc1a3166be8fd9b80a24b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544543 Commit-Queue: Renato Silva <rrsilva@google.com> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#828280}
-
Joe Downing authored
This CL moves some formatting code into EventTraceData so it can be shared between the file logger and Windows event logger. I've also fixed a few small things that I noticed (PLOG, comment changes). Change-Id: I3eeb4a9f581efebd2eeb19880b32af3c2df29422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544742Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#828279}
-
Evan Stade authored
AppBannerInProductHelp is not slated for componentization. This moves the jni code which invokes the IPH UI from AppBannerManager.java, which is slated for componentization, to AppBannerInProductHelpControllerProvider.java, and thus removes some //chrome dependencies from the former class. Bug: 1147268 Change-Id: If8eb505ec32081b6c85f2b901eac4887b2a49543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541062 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#828278}
-
Joon Ahn authored
http://screen/5gd92ktsmdrZMQv Bug: 1125150 Test: screen/5gd92ktsmdrZMQv Change-Id: I2f517a58766730752866d940424e049c4501b6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541670 Auto-Submit: Joon Ahn <joonbug@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#828277}
-
Renato Silva authored
OOBE initialization was being executed in the middle of the chain of JS files in cr_ui.js. This commit moves this initialization to its own file that gets included at the end of oobe.js and md_login.js. These changes are necessary for adopting the HTMLImports polyfill because this initialization part was being executed only later by waiting for the DOM content loaded event. Since we now guard the execution of JS until the polyfill is ready, cr_ui.js would be executed entirely when reached, creating some errors. Bug: 1111387 Change-Id: I6e08456fa29f0179eeba347c3c8b6831fa642265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527173 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#828276}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f0f126063145..f69ec827f69b 2020-11-17 andoli@chromium.org Sets up infrastructure to migrate extensions of type 'setting' 2020-11-17 tvanderlippe@chromium.org Typecheck profiler/HeapSnapshotProxy.js with TypeScript 2020-11-17 alexrudenko@chromium.org Roll deps and update protocol definitions 2020-11-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-11-17 szuend@chromium.org [ts] Replace UI.__editingCount and Element.__editing with Set 2020-11-17 bmeurer@chromium.org [wasm] Add informative console messages when loading debug symbols. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1083146,chromium:1126328,chromium:1134103,chromium:1136484,chromium:1145997,chromium:1148495 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I43489237c1179bc5e81bc7dcb7aad29552c87d24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544254Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828275}
-
Nnamdi Theodore Johnson-Kanu authored
- Fix issue where next button is not disabled in selection flow - Fix issued where next button does not navigate to esim/psim flows Bug: 1093185 Change-Id: If88329108eb094b5aed18fc8e0dc74930415ddb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541818Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#828274}
-
Donn Denman authored
Removes the demo-level UI for Related Searches. The demo allowed a single tap to trigger Related Searches while preserving longpress as a regular Touch to Search. Going forward the Related Searches UX will be triggered by the same gesture as TTS. This is a partial rollback of https://crrev.com/c/2200437 with minor changes. BUG=1148874,1119585 Change-Id: Ifdefea88e23d189bd6347745fc96a733545a77bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538335 Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#828273}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f2ba36a7. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: guidou@chromium.org, armax@chromium.org: external/wpt/mediacapture-streams guidou@chromium.org, emircan@chromium.org, emircan@chromium.org: external/wpt/screen-capture NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I7b2b0e189389ee8dd4495db90627b46d096ed82f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544366Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828272}
-
Klaus Weidner authored
WebXR AR DOM overlay mode no longer needs the local frame view's background color to be changed, this is now handled by CSS for the :xr-overlay pseudoclass. Remove this code to avoid potential complications such as incorrect background color restoration. Bug: 1149708 Change-Id: I130842a80eff6d56f58590c8611b2c5e5f7f2878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543484Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#828271}
-
Sean Harrison authored
Project is taking a different approach that neccessitates a change to the flag name for accuracy. Change-Id: I45ce6026963c9fda614cc3f1b1c14645b1051405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544542 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#828270}
-
Evan Stade authored
Feature has been launched to stable. Bug: 1147291 Change-Id: I326292a7b38aba0f5a8d71f1dab908f4707c78b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542848 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#828269}
-
Christos Froussios authored
This metric tracks usage of backends and is useful long-term Bug: 1140055 Change-Id: Ie672922dd8d465da30472fec947582c216ef46f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540611Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#828268}
-
Patrick Monette authored
This class was also slightly refactored to get rid of the logic in VoteData. Bug: 971272 Change-Id: If10c30d44371ebb00df5507e78dc4dcbd7a165e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533141 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#828267}
-
Gauthier Ambard authored
This CL fixes navigating back to offline pages with the new error page workflow. It is allowing navigating to WebUI from the error page. It is also removing the decoding in the JavaScript of the error page as it was decoding the parameters of the URL which might create issue in parsing the URL. Bug: 1138228, 1138894 Change-Id: I8da6b84b295b3f9cbaf53c28fd3f766938409815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540982 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#828266}
-
Ian Wells authored
Bug: 1115463 Change-Id: I32a0f1c6efb76adc99e6182876541881753212b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541571Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#828265}
-
Gayane Petrosyan authored
Bug: None Change-Id: Ia92791c401c483d2dff98ca3583f087baa9e4bcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543691 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Auto-Submit: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#828264}
-
Andres Medina authored
Followed process in //third_party/protobuf/README.chromium Highlights: * Some protobuf APIs started being deprecated. Moved sources in //chromecast and //components to start using the non-deprecated versions. * Removed most of the patches and updated the ones that are still needed. No new patches. * //components/subresource_filter/core/common/unindexed_ruleset.h: HadError is not const anymore. Size increase is caused by protobuf mainlining 2 functions to Serialize and Parse inside each *pb.cc file. This new methods are now the way protobuf serializes and deserializes messages so no way to avoid those without substantially changing protobuf internals. Binary-Size: Unavoidable. Increase intrinsic to new protobuf. Bug: 1144985 Change-Id: I23ce43f07da82fdda60575934a4b039200164f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518036 Commit-Queue: Andres Medina <medinaandres@chromium.org> Auto-Submit: Andres Medina <medinaandres@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#828263}
-