- 15 Dec, 2017 40 commits
-
-
Adithya Srinivasan authored
While some input types (like checkboxes) don't need a shadow subtree for their implementation, they do need a shadow root to hide any children that may be appended by script. This CL makes input elements lazily create a shadow root when children are appended. Bug: 794484 Change-Id: I4dfeecd33b7ff39c9cfe94192b3f9ac8aa5a779d Reviewed-on: https://chromium-review.googlesource.com/826426Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#524384}
-
Elly Fong-Jones authored
Otherwise, the page info bubble hides when an iframe on the page navigates, which happens dozens of times on some JS-heavy pages, or when the page navigates itself using a meta-refresh or similar. Bug: 788301 Change-Id: I10e4676bc3e0b4c688e5e435d243799a831c5bc3 Reviewed-on: https://chromium-review.googlesource.com/793230Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#524383}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/9eedea7c5075..2b4bc3c31636 $ git log 9eedea7c5..2b4bc3c31 --date=short --no-merges --format='%ad %ae %s' 2017-12-15 mtklein Don't set /GS- on Windows builds. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: I257f7d418cf05da9cf7e65f5f665253878db400f Reviewed-on: https://chromium-review.googlesource.com/829454Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524382}
-
Olivier Robin authored
onFormDataFilled can have some non trivial behavior particularly when there are multiple fields with the same name. Bug: None Change-Id: I89e5eacf658cf7c82b0c6dd01725f497b1c856e1 Reviewed-on: https://chromium-review.googlesource.com/822073 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#524381}
-
Yash Malik authored
Before this CL, we would hide the keyboard before releasing the button, which is incorrect behavior. This CL also makes the background unfocusable so clicking on it doesn't steal focus from text fields and hide the keyboard. Bug: Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0a74c7f3d036e8bff6fc4daa2ce6b47f33f2a2e3 Reviewed-on: https://chromium-review.googlesource.com/828120Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#524380}
-
Chris Nardi authored
When computing the RGBA channels for HSL/HSLA values, we currently multiply by 256 and truncate the value. However, this can cause miscalulations for alpha values, and can cause each channel to be nearly 1 unit away from what was intended. This changes the behavior to multiply by 255 and round, having the same behavior as Edge and Firefox. Bug: 786139 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iad92dc6f7b110e250c7cf9987832c94eec4c930e Reviewed-on: https://chromium-review.googlesource.com/818629 Commit-Queue: Chris Nardi <hichris123@gmail.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#524379}
-
Marina Ciocea authored
AudioDebugFileWriter's constructor no longer takes a file thread as parameter since [1]. Remove file thread from unit tests. [1] https://chromium.googlesource.com/chromium/src/+/4d7742ed008b3b749a757d52f75133dfd5d7f44c Bug: 689520 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0d824f83818893750775ad4e1b80443e2dcd2c2d Reviewed-on: https://chromium-review.googlesource.com/827129 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#524378}
-
Hiroki Nakagawa authored
This CL introduces WorkerOptions for module workers. This is not exposed on the ctor of any workers yet to avoid making developers confused about unimplemented features. This also passes the option from DedicatedWorker::Create() to DedicatedWorkerMessagingProxy::StartWorkerGlobalScope(). Following CLs will implement the remaining parts and add tests. This CL doesn't change the existing behavior. Rough design doc about module workers: https://docs.google.com/a/chromium.org/document/d/1IMGWAK7Wq37mLehwkbysNRBBnhQBo3z2MbYyMkViEnY/edit?usp=sharing Bug: 680046 Change-Id: I571e8f540d842bb06878e13d4b383eddc2df42f1 Reviewed-on: https://chromium-review.googlesource.com/813314Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#524377}
-
Allen Bauer authored
Bug: 773979 Change-Id: I1a2bc9a86e898c3a91fcdfdc97296972dbdff723 Reviewed-on: https://chromium-review.googlesource.com/825627Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#524376}
-
Gauthier Ambard authored
This fixes the QR Code scanner animation when presenting and dismissing it. The animation was animating frames, which was causing problem with the topLayoutGuide. Using translate transformation fixes this. Bug: 793829 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibd38205dbe15fe0edef44a44e30b5ed36f0c28b1 Reviewed-on: https://chromium-review.googlesource.com/828833 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#524375}
-
Denis Kuznetsov authored
Split "enable_background" to "enable_background_mode" and "enable_background_contents" (latter one is used in chrome). Bug: 527045 Change-Id: Ia8d96379b74ecc5fb54fe0e6688a79e0ef9fa767 Reviewed-on: https://chromium-review.googlesource.com/822475Reviewed-by:
Drew Wilson <atwilson@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#524374}
-
Kinuko Yasuda authored
After the main resource loader is bound to a loader request the loader shouldn't be deleted when the request handler is deleted. (The loader should be able to outlive as far as the loader's Mojo pipe is held by its client) Bug: 790933 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I81dab1599d1b0af3aa03f2acfed5f8edc4dd53dd Reviewed-on: https://chromium-review.googlesource.com/828225Reviewed-by:
-
Tsuyoshi Horo authored
Bug: 794089 Change-Id: If6c0093d6fcea03aa57ea8f8dd9b089765f0ede5 Reviewed-on: https://chromium-review.googlesource.com/822016 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
Bug: 794498, 795217, 795219 Change-Id: I48011892452379f432119b5a8bb3bc4a4c48ee06 Reviewed-on: https://chromium-review.googlesource.com/828974 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#524371}
-
Xi Han authored
Bug: 665549 Change-Id: I89109434b4d9491c479667e86e9df543fb52a801 Reviewed-on: https://chromium-review.googlesource.com/827730Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#524370}
-
Mirko Bonadei authored
WebRTC is moving away from public_deps and CL https://webrtc-review.googlesource.com/c/src/+/33180 will remove them from the //third_party/webrtc/media package. This CL applies a forward compatible fix to avoid to break Chromium. Bug: webrtc:8603 Change-Id: I89a4421362a9451633de2b23fd9ed3fd57ecf0cd No-Try: True Reviewed-on: https://chromium-review.googlesource.com/829139 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
-
Balazs Engedy authored
As of crrev.com/c/536543, it's an error to call ExecutionContext::From() on an invalid |context|. Update guards in request/notification callbacks in blink::CredentialsContainer to instead rely on ScriptPromiseResolver being a ContextLifecycleObserver, which is able to safely return the Frame (i.e. browsing context) associated with its ExecutionContext (here always a document) if it is still active, and a nullptr otherwise. This CL also removes a useless copy of |web_credentials|. Bug: 794278 Change-Id: Iefe3557dbc374a81964be7f5f51a9f8b73e93e51 Reviewed-on: https://chromium-review.googlesource.com/824267 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Henrik Grunell authored
Update test expectations for failing virtual/scroll_customization/fast/events/touch/gesture/gesture-tap-hover-state-iframe.html on Win7. TBR= rbyers@chromium.org Bug: 795250 Change-Id: I1af8aadac484d5c03fa352aecd133e7cba5de868 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/829140Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#524367}
-
Morten Stenshorne authored
This algorithm is now only invoked when laying out an inline formatting context root, not at every inline layout box (such as SPAN, B, etc.). Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I789c424310636292ebca4aa117683e562ff9a318 Reviewed-on: https://chromium-review.googlesource.com/828873Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#524366}
-
Greg Kraynov authored
Add heap_profiling.* (contrib) benchmarks to chromium.perf.fyi Android Nexus 5X Perf FYI builder and enable results uploading. Bug: 783201 Change-Id: I2ef81e2326ed2c06ab787110b0ac9c2cc5c3b41a Reviewed-on: https://chromium-review.googlesource.com/828976 Commit-Queue: Greg Kraynov <kraynov@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#524365}
-
Henrik Grunell authored
TBR=chenwilliam@chroimum.org Bug: 794869 Change-Id: Ifd17f87b95a0ebd2977d9cdb24608b32fe9c449a No-Try: true Reviewed-on: https://chromium-review.googlesource.com/829133Reviewed-by:
-
Karl Wiberg authored
In this CL: https://webrtc-review.googlesource.com/c/src/+/24140 Bug: webrtc:8254 Change-Id: I869609676979f6f4dcfb36a3eb1f0645720654fd Reviewed-on: https://chromium-review.googlesource.com/778840Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Commit-Queue: Karl Wiberg <kwiberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#524363}
-
Jan Krcal authored
This CL wraps-up recent Stable experiments and updates the default values of parameters for the scheduler and for the user classifier. It also prepares the testing_config for another Beta/Stable experiment. Bug: 792274 Change-Id: I6c7f1ad395181d64d5a25d2ab8604454c35d372f Reviewed-on: https://chromium-review.googlesource.com/826638Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#524362}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/800f5541bb0f..9eedea7c5075 $ git log 800f5541b..9eedea7c5 --date=short --no-merges --format='%ad %ae %s' 2017-12-15 angle-deps-roller Roll skia/third_party/externals/angle2/ f414121d4..195be9424 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: I7a4223a8804dd7f878677ea0d9f2752215e14f55 Reviewed-on: https://chromium-review.googlesource.com/829014Reviewed-by:
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/51f8305b51e9..846f7660e7d5 $ git log 51f8305b5..846f7660e --date=short --no-merges --format='%ad %ae %s' 2017-12-14 perezju [Telemetry] Fix browser_backend.pid for Android Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Id4168aae51d2ce72a3eb8f0ff161a7159980268c Reviewed-on: https://chromium-review.googlesource.com/828029 Commit-Queue: <catapult-deps-roller@chromium.org> Reviewed-by: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524360}
-
Yuta Kitamura authored
We'd like to use base::Location and FROM_HERE in Blink instead of blink::WebTraceLocation and BLINK_FROM_HERE. Regarding a DEPS change in public/platform/scheduler, the only reference of those names in public/ is in that directory, so I updated the DEPS file there instead of the one in public/. Bug: 794845 Change-Id: I4249abcb727186281229f41a0c81df649de8fbf7 Reviewed-on: https://chromium-review.googlesource.com/826924Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#524359}
-
Henrik Grunell authored
This reverts commit 613ce4af. Reason for revert: Breaks linux-chromeos-dbg bot (https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/3205) Original change's description: > Remove |mode| from ChromeVox > > ChromeVox Classic is no longer available to users. > This allows us to remove some complexity surrounding the idea of the various modes for ChromeVox (classic, next, etc). > > This change mostly is meant to be cleanup, but it also addresses some bugs. Namely, we unintentionally relied upon onModeChanged to trigger specific behaviors such as installing command handlers. This made sense when mode changes had to be supported. However, with this in a limbo state now that there is no classic mode, we can no longer invoke commands with an empty desktop. > > > Bug: > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: Ic9270ab7e3cc3ba734f21bc84c00738bb0d43e56 > Reviewed-on: https://chromium-review.googlesource.com/825169 > Commit-Queue: David Tseng <dtseng@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#524343} TBR=dmazzoni@chromium.org,dtseng@chromium.org Change-Id: Ic60ba55115d1788dd392fde31997beee13f5fe3f No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/828735Reviewed-by:
-
Daniel Bratell authored
To avoid clashes between test data variables and similar changes, this patch puts tests that would collide in custom namespaces following a pattern used successfully in Blink. content unittests needs about 60 CPU minutes to compile normally. With jumbo that can be brought down to 4-6. Bug: 746953 Change-Id: Ic573361fed81bbd46a97823e9761f94088d51814 Reviewed-on: https://chromium-review.googlesource.com/826637 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#524357}
-
Daniel Cheng authored
This allows mocking of TimeTicks inside Blink once WTF::TimeTicks is merged into base::TimeTicks. base::TimeTicks::Now() will be explicitly disallowed in Blink to ensure that there is a consistent global view of the mocked time ticks. Bug: 763980 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I356da09d27694c4d4323a8b494a2afef6a80baf3 Reviewed-on: https://chromium-review.googlesource.com/827545Reviewed-by:
-
Siddhartha authored
There is flakiness on bots that show features in gmail failed to load. So, re-record in case the bug was fixed in gmail. BUG=750147,776889 Change-Id: Ie9d6be28d5d6e8de3bda54ed5418786665d67c4d Reviewed-on: https://chromium-review.googlesource.com/822510 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
-
Olivier Robin authored
When autofilling credit card, the CVC prompt View disables the webState. JS processing may be different when view is not visible. This makes some sites like walgreens.com flaky. This CL queue the JS if the webState is not visible and executes it after |webStateWasShown| is called. Bug: 728606 Change-Id: I7a9ffd5e15d403a7faf9f7f4f4151371474676d5 Reviewed-on: https://chromium-review.googlesource.com/817277 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#524354}
-
yoshiki iguchi authored
Previously the width was 362px, which is 360px (notification width) plus 2px (notification border). This CL removes the border and shrinks the width of sidebar by 2px. Bug: 726250 Change-Id: Iae5a14a9057561223e5e2afe39fee840a3073de1 Reviewed-on: https://chromium-review.googlesource.com/825042 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#524353}
-
Aleks Totic authored
The reason for this change is test failure: fast/block/positioned-bottom-margin.html <style> #abs { position:absolute; width:auto; height:auto; top:0px;bottom:0px;left:0px;right:0px; min-height:200px; } #mrg { height: 1000px; margin-top: 50px; margin-bottom: 50px; } </style> <body> <div id="abs"><div id="mrg"></div></div> </body> In this document, #mrg margin affects body overflow. The overflow is computed by Legacy code ComputeOverflow() ComputeOverflow() uses margin structs stored on Legacy. I've talked to Ian about it, and he suggested this change. It fixes this bug, and lots of grid ones, with 2 new border-image failures. I do not understand this code well, WDYT about always calling SetMargin() Bug: 740993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I29816e4bea210d63874124a50a65b7001525d752 Reviewed-on: https://chromium-review.googlesource.com/827548Reviewed-by: -
Jens Widell authored
This avoids collisions in jumbo/unity builds. Change-Id: Ibd47b3c0be950c6f9fb5baf206612203c99e9b35 Reviewed-on: https://chromium-review.googlesource.com/827132Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Jens Widell <jl@opera.com> Cr-Commit-Position: refs/heads/master@{#524351}
-
Zhuoyu Qian authored
This patch makes EFillSizeType to be an enum class for better type safety. Bug: 684966 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I61fd98a1fd15ae4b1dbbd39bfe68d1776cfb4df1 Reviewed-on: https://chromium-review.googlesource.com/828182Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#524350}
-
Donna Wu authored
Define mojo format MtpFileEntry to mirror the MTP protobuf message. Use this struct in MediaTransferProtocolManager and related code. This is a preparation work for MTP servicification. BUG=769630 Change-Id: Ia01f5bc7c00fdcc258f50ae02e7a375caa83d6c9 Reviewed-on: https://chromium-review.googlesource.com/812964 Commit-Queue: Ke He <ke.he@intel.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#524349}
-
Zhuoyu Qian authored
As the comment in PluginView.h by joelhockey@, The only implementation of class PluginView is WebPluginContainerImpl, remove PluginView, use WebPluginContainerImpl directly. BUG= Signed-off-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/069dd4fa6b05..41d9d87e9653 $ git log 069dd4fa6..41d9d87e9 --date=short --no-merges --format='%ad %ae %s' 2017-12-14 iannucci [recipe_modules/depot_tools] Add on_path helper. Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I380050b47934f68e2f6045ce1bff050a286d05d3 Reviewed-on: https://chromium-review.googlesource.com/827572Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524347}
-
chromeos-commit-bot@chromium.org authored
TBR=chrome-os-gardeners@google.com Change-Id: I41835980c53b4a509f339a0af71868724633b152 Reviewed-on: https://chromium-review.googlesource.com/827986Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#524346}
-
Thomas Guilbert authored
The ChromeCastSessionManager's purpose is to manage the lifetime of CastSessions, and to notify the appropriate MediaRouteProvider when their CastSession's state changes (via the ChromeCastSessionObserver interface). This CL adds the ChromeCastSessionManager, decouples CastSessionImpl from CastMediaRouteProvider, decouples MediaRouteProviders from CreateRouteRequest, and extracts CastListener from CreateRouteRequest. It also moves the logic of stopping the current session out from the MediaRouteProvider into the manager. Bug: 790766 Test: Added UTs Change-Id: I2177c9f6918fc572b0c70df01411c574cda98fec Reviewed-on: https://chromium-review.googlesource.com/794711 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Zhiqiang Zhang <zqzhang@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Anton Vayvod <avayvod@chromium.org> Cr-Commit-Position: refs/heads/master@{#524345}
-
