GitLab

BUG=none

Review URL: https://codereview.chromium.org/517313002

Cr-Commit-Position: refs/heads/master@{#292773}

The WhispernetClient object provided by the CopresenceDelegate passed to the
CopresenceManager has a lifetime exceeding that of the CopresenceManager. We
explicitly want to decouple their lifetimes since we may have lifetime
restrictions imposed on WhispernetClient which may require it to outlive the
CopresenceManager. For this reason, when passing a callback to the
WhispernetClient from CopresenceManager, we were using a WeakPtr. This is
unnecessary since the same can be accomplished by passing a CancelableCallback
to the WhispernetClient and Canceling the callback in the CopresenceManager
destructor.

R=derat@chromium.org, willchan@chromium.org
BUG=None.

Review URL: https://codereview.chromium.org/517753002

Cr-Commit-Position: refs/heads/master@{#292772}

https://skia.googlesource.com/skia/+log/4ee3e529e2756275a978ae5e4763955a703191f2..2fe2ce41e3e5647c7aead4d76d75f5500f573fde

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/523363002

Cr-Commit-Position: refs/heads/master@{#292771}

Hidden buttons are no longer accessible by pressing TAB.
Cookie buttons are no longer accessible by pressing TAB.
  The cookie buttons are still accessible by pressing left/right.
  The "Remove" button is still accessible by pressing TAB.

BUG=408470

Review URL: https://codereview.chromium.org/521643003

Cr-Commit-Position: refs/heads/master@{#292770}

https://chromium.googlesource.com/chromium/blink/+log/54017a561ca598448bfc4ec9dd341f4b68fe9279..cc9283bc767fca02bdf6dec984311a32d8fe65ba
TBR=mlamouri@chromium.org,hclam@chromium.org

Review URL: https://codereview.chromium.org/526623002

Cr-Commit-Position: refs/heads/master@{#292769}

the pattern of SwapBuffers, for example, GLRenderer always issues
SwapBuffers calls with a specific IPC message patterns, it should always
be SetLatencyInfo->AsyncFlush->Echo sequence.

Instead of posting a task to message loop, it could avoid the possibility
of being blocked by other channels, and make SwapBuffers executed as soon
as possible.

BUG=407529

Review URL: https://codereview.chromium.org/495313003

Cr-Commit-Position: refs/heads/master@{#292768}

A function is also added to check the type of the network the user is
connected to.

CL originally written by radhikabhar@ as 400323002, but not landed before
her internship ended.

BUG=395295
TBR=meacer@chromium.org, dcheng@chromium.org

Review URL: https://codereview.chromium.org/516373003

Cr-Commit-Position: refs/heads/master@{#292767}

A couple of the tests are close to the 120s limit on the Debug bots.

BUG=409118

Review URL: https://codereview.chromium.org/524033002

Cr-Commit-Position: refs/heads/master@{#292766}

Most of these events are infrequent yet very useful when debugging.

Review URL: https://codereview.chromium.org/520593006

Cr-Commit-Position: refs/heads/master@{#292765}

The buffering controller serves two purposes:
- for URL playback, this will smooth playback when network
  condition is not good enough. This basically avoids continuous
  stuttering in that case.
- for MSE playback, it stops playback when either audio or video
  underruns (which is a special case of the low buffer level state).

BUG=408189

Review URL: https://codereview.chromium.org/509213002

Cr-Commit-Position: refs/heads/master@{#292764}

NOTRY=True
TBR=dtu@chromium.org
BUG=

Review URL: https://codereview.chromium.org/526643002

Cr-Commit-Position: refs/heads/master@{#292763}

BUG=406659
R=isherman@chromium.org

Review URL: https://codereview.chromium.org/505683004

Cr-Commit-Position: refs/heads/master@{#292762}

This creates a (GL)SurfaceView overlay on top of the shell
container view which runs its own thread for rendering.
It calls into the native draw functor through a small
dynamic library (drawgl.so).

Committed previously: https://chromium.googlesource.com/chromium/src/+/09acbf59e7e8f1de574498ee5ba8eae0b0775438

Review URL: https://codereview.chromium.org/414503004

Cr-Commit-Position: refs/heads/master@{#292761}

R=thakis@chromium.org
BUG=409318,82385

Review URL: https://codereview.chromium.org/525703002

Cr-Commit-Position: refs/heads/master@{#292760}

BUG=403380
R=mukai@chromium.org

Review URL: https://codereview.chromium.org/520273002

Cr-Commit-Position: refs/heads/master@{#292759}

BUG=372857

Review URL: https://codereview.chromium.org/491403003

Cr-Commit-Position: refs/heads/master@{#292758}

BUG=404334

Review URL: https://codereview.chromium.org/522053002

Cr-Commit-Position: refs/heads/master@{#292757}

Before we work on transfering from MediaPlayer to MediaCodec, we want to get some statistics on the current mobile video types to see the impacts.
We want to know how many video are HLS(which will still use MediaPlayer) and how many videos are using MediaSource(which already uses MediaCodec)

BUG=401795

Review URL: https://codereview.chromium.org/505233002

Cr-Commit-Position: refs/heads/master@{#292756}

BUG=399775

Review URL: https://codereview.chromium.org/519203002

Cr-Commit-Position: refs/heads/master@{#292755}

As we never shipped a CDM based on CDM_5, we can remove the code.
CDM_4 will be removed later, once all clients are upgraded to CDM_6.

BUG=401815
TEST=existing EME tests still pass

Review URL: https://codereview.chromium.org/518353002

Cr-Commit-Position: refs/heads/master@{#292754}

TBR=jam@chromium.org
BUG=409285

Review URL: https://codereview.chromium.org/524943003

Cr-Commit-Position: refs/heads/master@{#292753}

These are not appropriate for CastBrowserMainParts to manage.

R=lcwu@chromium.org,byungchul@chromium.org
BUG=336640

Review URL: https://codereview.chromium.org/521753002

Cr-Commit-Position: refs/heads/master@{#292752}

In order to fetch a resource using multiple byte range requests, the cache
has to make sure that the resource has not changed, and strong validators
are needed for that.

However, if the cache only has to return data without talking to the server
again, strong validators are not required.

It used to be the case that the cache will not return content from sparse
entries without revalidating tnem with the server first. But that changed a
long time ago to allow regular reuse policies, even for sparse/range requests.

This CL allows caching of partial responses that don't have strong validators,
as they are useful as described above.

BUG=407923

Review URL: https://codereview.chromium.org/509783002

Cr-Commit-Position: refs/heads/master@{#292751}

BUG=407021

Review URL: https://codereview.chromium.org/503093002

Cr-Commit-Position: refs/heads/master@{#292750}

The functionality was always broken, so remove it until it gets fixed.
We already do not show Searh google for * keyword item anyway.

BUG=407897
Test=In a chrome app, open a <webview> that loads an image.
Right click on that image.
"Search Google for this image" context menu item shouldn't appear.

Review URL: https://codereview.chromium.org/523023003

Cr-Commit-Position: refs/heads/master@{#292749}

Currently, selection handle taps are detected using a basic, hard-coded
timeout threshold. Update this logic to use the platform tap timeout and
scroll slop values, ensuring tap detection consistentcy with the
platform.

BUG=394093,407963

Review URL: https://codereview.chromium.org/516573003

Cr-Commit-Position: refs/heads/master@{#292748}

BUG=374321

Review URL: https://codereview.chromium.org/517193003

Cr-Commit-Position: refs/heads/master@{#292747}

https://skia.googlesource.com/skia/+log/9bd5bbf9102b164bb5fb0fb0fa0ce065179bbf3f..4ee3e529e2756275a978ae5e4763955a703191f2

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/522723003

Cr-Commit-Position: refs/heads/master@{#292746}

Fix typos related to which functions send or receive data. Some of these
were already resolved in 1816af67d3fb992ff49fb22b2b8fc8908d6ee6b1. Also
document where the opaque device ID and connection IDs should be used
and how errors are reported.

BUG=392036

Review URL: https://codereview.chromium.org/518133004

Cr-Commit-Position: refs/heads/master@{#292745}

https://chromium.googlesource.com/chromium/blink/+log/a70eaece73b718e58ad26a2271e8b99dd1727043..54017a561ca598448bfc4ec9dd341f4b68fe9279
TBR=mlamouri@chromium.org,hclam@chromium.org

Review URL: https://codereview.chromium.org/523963002

Cr-Commit-Position: refs/heads/master@{#292744}

BUG=338338
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/520913003

Cr-Commit-Position: refs/heads/master@{#292743}

TEST=none
BUG=none

Review URL: https://codereview.chromium.org/521713002

Cr-Commit-Position: refs/heads/master@{#292742}

This change replaces RenderThreadImpl calls in WebMediaPlayerImpl with
calls on the WebMediaPlayerParams passed into the constructor. This
removes another content/ depencency so that this code can be moved to
media/blink.

The EncryptedMediaSupport creation was moved to RenderThreadImpl and
passed via WebMediaPlayerParams to avoid linking problems that would
occur if WebMediaPlayerImpl was in media/blink.

BUG=408338

Review URL: https://codereview.chromium.org/517003002

Cr-Commit-Position: refs/heads/master@{#292741}

BUG=NONE

Review URL: https://codereview.chromium.org/519143002

Cr-Commit-Position: refs/heads/master@{#292740}

BUG=409119
TEST=Tested on Linux and Windows.

Review URL: https://codereview.chromium.org/516103004

Cr-Commit-Position: refs/heads/master@{#292739}

BUG=None
Test=None, internal cleanup.

Review URL: https://codereview.chromium.org/522563005

Cr-Commit-Position: refs/heads/master@{#292738}

R=byungchul@chromium.org,lcwu@chromium.org
BUG=336640

Review URL: https://codereview.chromium.org/517213005

Cr-Commit-Position: refs/heads/master@{#292737}

R=lcwu@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/521943002

Cr-Commit-Position: refs/heads/master@{#292736}

This is to figure out which link in RAF is broken to cause flakiness.

My current guess is the compositor scheduler issue, and these logs can confirm.

BUG=393331
TEST=bots
R=kbr@chromium.org
TBR=brianderson@chromium.org

Review URL: https://codereview.chromium.org/516663004

Cr-Commit-Position: refs/heads/master@{#292735}

This adds a browser type 'android-webview-shell' for the test
shell activity (AndroidWebView.apk), which is different from the existing
'android-webview' target that uses the device's system WebView for
testing.

Review URL: https://codereview.chromium.org/517573004

Cr-Commit-Position: refs/heads/master@{#292734}