- 15 Nov, 2018 40 commits
-
-
Eric Seckler authored
Adds support for legacy_ftrace_output and legacy_json_trace fields, which will later be filled by the respective system tracing agents. Bug: 900603 Change-Id: I1fd201bf7c1d9110c5f8c1b7df6209948d11787a Reviewed-on: https://chromium-review.googlesource.com/c/1335603 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#608314}
-
Jun Choi authored
This reverts commit 5ed5b3f4. Reason for revert: <Fails build "Deterministic Linux" ( https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Deterministic%20Linux/17798)> Original change's description: > IndexedDB: Remove redundant Web* enums > > The following structs were redundant with structs that Mojo > auto-generates: > - WebIDBCursorDirection > - WebIDBDataLoss > - WebIDBOperationType > - WebIDBPutMode > - WebIDBTaskType > - WebIDBTransactionMode > > This CL updates those references to refer to the equivalent > blink::mojom:: type, instead. > > References to kWebIDB* values are updated to point to the > equivalent value in the associated Mojo enum type. > > Bug: 717812 > Change-Id: Ie4bf482e4437ec9e5fa61c78086256bc84f8c6df > Reviewed-on: https://chromium-review.googlesource.com/c/1303634 > Commit-Queue: Chase Phillips <cmp@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607823} TBR=cmp@chromium.org,dmurph@chromium.org,reillyg@chromium.org,pwnall@chromium.org,dominickn@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 717812 Change-Id: I0a0abf71de45643dba0328ff8fe4b94c26aae750 Reviewed-on: https://chromium-review.googlesource.com/c/1337609Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#608313}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c25d23445748..7af4ac893721 git log c25d23445748..7af4ac893721 --date=short --no-merges --format='%ad %ae %s' 2018-11-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4ffd688e..92e84c81 (608180:608282) Created with: gclient setdep -r src/third_party/webrtc@7af4ac893721 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I9ab4adab58c625d638e59678a8c80502a20874c2 Reviewed-on: https://chromium-review.googlesource.com/c/1337471Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608312}
-
Findit authored
This reverts commit ad793ba0. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 608003 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYWQ3OTNiYTAzYjA3M2U0N2U4NjVhYTI2MjVjOWJkMTIxMThkNmU3Nww Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/linux-xenial-rel/4906 Sample Failed Step: sync_integration_tests on Ubuntu-16.04 Sample Flaky Test: USS/TwoClientWalletSyncTest.ServerAddressConvertsToSameLocalAddress/1 Original change's description: > [AF] Integration tests for changing additional info for wallet metadata > > This CL adds more integration tests; it also fixes a bug that > stopped local changes of billing address and local changes of > has_converted to get propagated to sync. > > Bug: 894001 > Change-Id: Idd91e6799afd3c936b76ac8b1a6851abc67b5ad7 > Reviewed-on: https://chromium-review.googlesource.com/c/1333819 > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608003} Change-Id: I6a879efbc643e4aa282ebe8d94c9e43566ab9eba No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 894001, 905606 Reviewed-on: https://chromium-review.googlesource.com/c/1337631 Cr-Commit-Position: refs/heads/master@{#608311}
-
Andreas Haas authored
SetSystemPagesAccess is more or less a wrapper around mprotect on posix systems, and VirtualFree and VirtualAlloc on Windows. We see crashes, e.g. in the referenced issue, where the return value of mprotect is not equal to 0. However, because we do not CHECK the return value of mprotect directly, we cannot see the reason why mprotect failed. With this CL I move the CHECK of the return value of mprotect to the mprotect, so if the CHECK fails, we also see the error reason. Some caller of SetSystemPagesAccess do not CHECK the result of SetSystemPagesAccess but deal with it or forward it. For these callers I introduced a new function, TrySetSystemPagesAccess, which does exactly the same as SetSystemPagesAccess did until now. Bug: chromium:839036 Change-Id: I774e648cc6968202805a495fc0b3c3b7d9974b02 Reviewed-on: https://chromium-review.googlesource.com/c/1336130Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#608310}
-
Hiroki Nakagawa authored
Bug: 879306 Change-Id: Ibecaadbe13f27aa887426279efccaeab06defa2c Reviewed-on: https://chromium-review.googlesource.com/c/1334671Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#608309}
-
arthursonzogni authored
Flaky tests: org.chromium.components.sync.notifier.InvalidationPreferencesTest.testReadWriteAndReadData org.chromium.components.sync.notifier.InvalidationPreferencesTest.testReadWriteAndReadData Bug: 905233 Change-Id: Iad0e641c19adf4d21eb37f2642d104537fdc2f48 Reviewed-on: https://chromium-review.googlesource.com/c/1337331 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#608308}
-
Benoît Lizé authored
Bug: 904538 Change-Id: If4099acc9e699c7d6dfc4478b24786cbf931133e Reviewed-on: https://chromium-review.googlesource.com/c/1335606Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#608307}
-
Marek Haranczyk authored
Change-Id: Ie5725cd32fff43807e6f4129d7234ecf1143e14b Reviewed-on: https://chromium-review.googlesource.com/c/1335575Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Marek Haranczyk <mharanczyk@opera.com> Cr-Commit-Position: refs/heads/master@{#608306}
-
Dean Liao authored
It overloads operator==, !=, << for VideoFrameLayout. Also, it removes VideoFrameLayout.ToString() as operator<< can replace it. BUG=b:110815424 TEST=pass media_unittests --gtest_filter=VideoFrameLayout.* Change-Id: I634846e456a516695a8f792bebf726d1cea80465 Reviewed-on: https://chromium-review.googlesource.com/c/1333016 Commit-Queue: Shuo-Peng Liao <deanliao@google.com> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#608305}
-
Hiroki Nakagawa authored
This CL renames test files for TaskWorklet and WorkerTaskQueue from foo_bar.html to foo-bar.html based on the layout tests guide: "File names should use snake-case, but preserve the case of any embedded API names. For example, prefer document-createElement.html to document-create-element.html." https://chromium.googlesource.com/chromium/src/+/HEAD/docs/testing/layout_tests_tips.md#file-names Bug: 879306 Change-Id: I704665e48c3697205f079a2d2ba28428aa0cffa5 Reviewed-on: https://chromium-review.googlesource.com/c/1334673Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#608304}
-
Clemens Hammacher authored
So far, v8 only implemented Liftoff on x86 and x64, and enabling it on other platforms basically did not have any effect. Now we start porting to arm. Until this is complete, we do not want this to be used in the wild. R=titzer@chromium.org, hablich@chromium.org, jochen@chromium.org Bug: chromium:787421 Change-Id: Ie7978dc579cbc9203647ea5395302cda57fc0403 Reviewed-on: https://chromium-review.googlesource.com/c/1331388Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#608303}
-
Matthew Cary authored
It is no longer necessary to build without symbols to keep the instrumented library size under 4G (a recent local instrumented build with symbol_level=0 had an unstripped library size of ~500M). Removing this custom arg will make future debugging of orderfile issues easier as there will be fewer variations to account for. Change-Id: I84078e7f0a2f3033031755e884c3e72049b2beed Reviewed-on: https://chromium-review.googlesource.com/c/1317571Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#608302}
-
Zinovy Nis authored
And few minor things Bug: <none> Change-Id: Ib5ecffb725bfe5843acd3c46f34956a763b91876 Reviewed-on: https://chromium-review.googlesource.com/c/1329676 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#608301}
-
Yutaka Hirano authored
Bytes greater than 0x7f should not be considered as unsafe. This CL also replaces "utf8" character conversions in blink/renderer/platform/loader/cors/cors.cc to "latin1" as it's what's done when actually converting blink::HTTPHeaderMap to net::HttpRequestHeaders. Bug: 824130, 902681 Change-Id: I01aacf814f1fc8a3ab8f191e1a9ec2bd01c1efee Reviewed-on: https://chromium-review.googlesource.com/c/1335049Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#608300}
-
Pavol Marko authored
The goal is to make it obvious that the browser test testing policy-provided CA certificates which are used as trust anchors does not depend on device policy. Use InProcessBrowserTest instead of DevicePolicyCrosBrowserTest as base class for the test to achieve this. To make this easier, move the common 'user policy provided CA cert' test functionality to its own class, used by multiple tests. Bug: 874937 Test: browser tests Change-Id: I2be87daeafa7e21dd08de97958c2b66a8cb43271 Reviewed-on: https://chromium-review.googlesource.com/c/1178047Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#608299}
-
Khushal authored
Add class comments and some renames for PaintCache. Following up from: https://chromium-review.googlesource.com/c/chromium/src/+/1321190/4 R=enne@chromium.org Bug: 894200 Change-Id: Ie8a0629071f8156e26945be7e9c61e04742158e5 Reviewed-on: https://chromium-review.googlesource.com/c/1336040Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#608298}
-
Alessio Bazzica authored
Bug: webrtc:7494 Change-Id: I0cdcf1ac0bb0726913a4fdd15fcdaa324c4e86b7 Reviewed-on: https://chromium-review.googlesource.com/c/1335488Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Ale Bzk <alessiob@chromium.org> Cr-Commit-Position: refs/heads/master@{#608297}
-
David Jean authored
Bug: 845472 Change-Id: Iac666731ad90f3ac69ed668406ca80e722c9c5cb Reviewed-on: https://chromium-review.googlesource.com/c/1335574Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#608296}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e36f46461df6..1315333b6bfb git log e36f46461df6..1315333b6bfb --date=short --no-merges --format='%ad %ae %s' 2018-11-15 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@1315333b6bfb The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: I3da15f0b1e9b621ef6fa6b2191c1d319099ffd05 Reviewed-on: https://chromium-review.googlesource.com/c/1337274Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5ad919faea83..52d757db392f Created with: gclient setdep -r src-internal@52d757db392f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iedd6a593d23a1e26a7bce0f372d6625f74eeac87 Reviewed-on: https://chromium-review.googlesource.com/c/1337469Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608294}
-
Noel Gordon authored
Ash immersive mode is not quite right anymore: remove it. Bug: 839243 No-Try: true Change-Id: If25f8e3411006c694825a38841fd1ae92f287623 Reviewed-on: https://chromium-review.googlesource.com/c/1336951Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#608293}
-
Koji Ishii authored
This patch moves the flag whether to force to create a box fragment for LayoutInline or not from NGInlineItem to LayoutInline. This is part of an effort to reduce re-collecting NGInlineItem when styles were changed. Re-collecting is rather an expensive operation that changes in, for instance, background should not require it. Note, this patch itself does not reduce the collection, because we require re-collection whenever NeedsLayout is set. It is planned in future patches, but this change is needed to make it happen. Also benefits to keep the flag turned on once it's on, until the LayoutInline is reattached. The change has minor performance gain in most blink_perf.layout https://pinpoint-dot-chromeperf.appspot.com/job/15f8c74be40000 Bug: 636993 Change-Id: I8d4e7c421d5fad26fee60832cdfbacd575f7ad34 Reviewed-on: https://chromium-review.googlesource.com/c/1333588Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#608292}
-
Nigel Tao authored
Change-Id: I7ddbabf86c83256d608bd0f97736e8ead373a81d Reviewed-on: https://chromium-review.googlesource.com/c/1337217Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#608291}
-
Joel Hockey authored
Unshares a path previously shared, and removes path from prefs. Bug: 878324 Change-Id: I9655c16851eed2eccca225fc3d9642db21b51dde Reviewed-on: https://chromium-review.googlesource.com/c/1317212 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#608290}
-
Benoît Lizé authored
The following sequence is racy with the current ASAN checks in ParkableString, on the main thread: Park() Lock() ToString() Unlock() Park() poisons the string, ToString() unpoisons it, and Unlock() poisons it again. If this last call happens while the compression is in progress, then this is a use-after-poison. This is not a real issue, merely an overaly eager poisoning, still making using ASAN builds painful. Fix it by making sure the string stays unpoisoned during compression. Also adds a regression test. Bug: 905137,877044 Change-Id: I5276b9ae6eee4abe2f2bf041818d1ba17358a80a Reviewed-on: https://chromium-review.googlesource.com/c/1335585Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8a6451c727a2..d098799efb32 git log 8a6451c727a2..d098799efb32 --date=short --no-merges --format='%ad %ae %s' 2018-11-15 sabbakumov@yandex-team.ru Fix race condition while handling errors Created with: gclient setdep -r src/third_party/catapult@d098799efb32 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I4e4286213e559250c206b596b98fc3b0ab4343ef Reviewed-on: https://chromium-review.googlesource.com/c/1337309Reviewed-by:
-
Koji Ishii authored
This patch changes LayoutInline to use |IsInLayoutNGInlineFormattingContext()| to determine whether it's in LayoutNG inline formatting context or not. This was revealed in crrev.com/c/1333588, tests will fail with the CL without this fix. Bug: 636993 Change-Id: I6ae4fb3bcaf18afceb4ab3486618a031b4a895c9 Reviewed-on: https://chromium-review.googlesource.com/c/1337212Reviewed-by:
-
Marc Treib authored
It's a simple test implementation of SyncUserSettings that mostly forwards calls to the TestSyncService. It is not actually used yet, but it unlocks the migration of tests over to SyncUserSettings. Bug: 884159 Change-Id: Id9d9c03f639c6523bb6d6592517ba46d1f8f4566 Reviewed-on: https://chromium-review.googlesource.com/c/1335565 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#608286}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb18f19dce17..5ad919faea83 Created with: gclient setdep -r src-internal@5ad919faea83 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie26dfafd1271a82eb4bea28cae1d65ed76a7e4f0 Reviewed-on: https://chromium-review.googlesource.com/c/1337310Reviewed-by:
-
Kent Tamura authored
Error -> Warning. Bug: 697443 Change-Id: Ib4e88bb64cd5f1a533ae88306c47e91ca0606085 Reviewed-on: https://chromium-review.googlesource.com/c/1337216Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#608284}
-
Joel Hockey authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/693e848cded9..9a5d5fab32aa $ git log 693e848cd..9a5d5fab3 --date=short --no-merges --format='%ad %ae %s' 2018-11-06 joelhockey vm_tools: seneschal: Add support for Unshare 2018-11-01 chirantan vm_tools: concierge: Remove StartContainer method Created with: roll-dep src/third_party/cros_system_api Change-Id: I73b23667ce4168d6a6d5c184376eda856ab15b14 Reviewed-on: https://chromium-review.googlesource.com/c/1337137Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#608283}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6b0ab168. With Chromium commits locally applied on WPT: f482e77e "Add report-only mode to Feature Policy" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I622df7e594bbff38c9752638e80a1ca926bbecb0 Reviewed-on: https://chromium-review.googlesource.com/c/1337291 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608282}
-
John Abd-El-Malek authored
Reland "Remove remaining components/domain_reliability dependency on content/ and components/keyed_service." This is a reland of bd611e3e Original change's description: > Remove remaining components/domain_reliability dependency on content/ and components/keyed_service. > > This way it can run in the network process, similar to Network Error Logging. > > Bug: 853251 > Change-Id: I403a5dcc3cae12b592a444c7e23f71c552b58e1f > Reviewed-on: https://chromium-review.googlesource.com/c/1334848 > Reviewed-by: Misha Efimov <mef@chromium.org> > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608175} TBR=mef@chromium.org Bug: 853251 Change-Id: Iee089ae0cd422e242df53604da6dcb8ef25b74cb Reviewed-on: https://chromium-review.googlesource.com/c/1337373Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#608281}
-
Alexandre Courbot authored
User-allocated memory can be passed to some hardware (like video encoder). Such hardware is generally not happy if the memory is not page-aligned. This patch adds a new member to VideoFrameLayout that specifies the desired alignment of the buffer, and make VideoFrame comply to it when allocating memory. It also makes use of it by specifying a page-alignment to formats returned by V4L2Device. Other users of VideoFrame/VideoFrameLayout are not affected by this CL. BUG=b:80274650 TEST=Made sure the VEA unittest was working on Hana and Cheza. Change-Id: Id615ca1ba3f9b253ba774573146a3428c144f57f Reviewed-on: https://chromium-review.googlesource.com/c/1154769 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
Makoto Shimazu authored
Previously ServiceWorkerObserver::WaitForState(STOPPED) starts to observe the state when it's called, but sometimes it's too slow and restarting the worker is already happening when starting to wait for state STOPPED. This CL fixes it by keeping all state changes and returning from WaitForState() if the observer saw the state previously at least once. Bug: 889855 Change-Id: Ide180fa49c9f47f68e1482b9a368b386648a3d4e Reviewed-on: https://chromium-review.googlesource.com/c/1337214Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#608279}
-
Kentaro Hara authored
This reverts commit 21216eb0. Reason for revert: I'm 20% sure but this CL is suspicious for the failure on Linux Chromium OS ASan LSan Tests. Let me try to revert it and see how it goes. If it's innocent, let me reland! https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/30100 Original change's description: > cros: Turn LoginBubble flags into a LoginBaseBubbleView member function > > This prevents us from having to mutate the flags variable each time a bubble is > shown or hidden. > > Bug: 905436 > Change-Id: Ia40f2d0b9aa949fd6c67b46dcf22a5e5272f60a7 > Reviewed-on: https://chromium-review.googlesource.com/c/1336254 > Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608151} TBR=jdufault@chromium.org,qnnguyen@chromium.org Change-Id: Iebf03b66402b61999a53a1db372fbc36d9a91c0c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 905436 Reviewed-on: https://chromium-review.googlesource.com/c/1337141Reviewed-by:
-
Joel Hockey authored
I saw some flakiness today in the QuickView UI test where a volume can be unmounted whilst a rescan is in progress. Then when it is finally complete, this call to getLocationInfo fails. Change-Id: Ie29e551b980b3e4bacea7b6bd39746c8c140e1aa Reviewed-on: https://chromium-review.googlesource.com/c/1337136Reviewed-by:
-
Lei Zhang authored
TBR=halliwell@chromium.org,kbr@chromium.org,kinuko@chromium.org,marq@chromium.org, olka@chromium.org,thakis@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I40a84a602bfa25f6f38c8a9b1d8fc4015906563b Reviewed-on: https://chromium-review.googlesource.com/c/1279182 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#608276}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2eccd58916ee..e36f46461df6 git log 2eccd58916ee..e36f46461df6 --date=short --no-merges --format='%ad %ae %s' 2018-11-15 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-15 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@e36f46461df6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: Ifb7138c0396e5a0f6ba8b378dac95e2046beecd6 Reviewed-on: https://chromium-review.googlesource.com/c/1337273Reviewed-by:
-
