GitLab

The PiP window has a simple layer tree and triggers the FSLP code path.
But, this path didn't previously consider the video layer part of the
area that needs a backdrop, so the backdrop layer (the root layer) was
made too small.

It would be better if this code just had access to the size of the page
instead of having to guess by looking at the layer tree, but I don't
think it does right now.

Bug: 863580
Change-Id: Ib2e9ae24e98932b77b365a985dc956aa08287eb7
Reviewed-on: https://chromium-review.googlesource.com/1140923Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576182}

This change is in preparation for creating the Switch Access context
menu, which we want to behave similarly to the ChromeVox Panel.

Bug: 864796
Change-Id: I7d3c4828d1de7165ce4e3cab99fa779b3f5dcd1d
Reviewed-on: https://chromium-review.googlesource.com/1141341
Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576181}

freeGpuResources evicts harder to regenerate Skia caches, so use the
slightly lighter weight purgeUnlockedResources when idle for oop raster.
This matches the behavior of gpu raster (see: ContextCacheController).

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ia954629b13f8d5fcb50cbd314976e8558b1609d4
Reviewed-on: https://chromium-review.googlesource.com/1141102Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576180}

Change-Id: Ia275f1610f1e654937fec6eb2dca93928e203107
Reviewed-on: https://chromium-review.googlesource.com/1137847Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576179}

https://android.googlesource.com/platform/external/perfetto.git/+log/510bbe089b53..9ee65033ce97


git log 510bbe089b53..9ee65033ce97 --date=short --no-merges --format='%ad %ae %s'
2018-07-18 treehugger-gerrit@google.com Merge "Add --reset-guardrails option"
2018-07-18 primiano@google.com Add --reset-guardrails option


Created with:
  gclient setdep -r src/third_party/perfetto@9ee65033ce97

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:72378055
TBR=perfetto-bugs@google.com

Change-Id: I14049248810c32270a63acf9ead832c71af711de
Reviewed-on: https://chromium-review.googlesource.com/1142244
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#576178}

R=avi@chromium.org

Bug: 419087
Change-Id: I46b6451680a15696b8bc5881b40a6389860a46ab
Reviewed-on: https://chromium-review.googlesource.com/1142131Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576177}

GpuCrash_GPUProcessCrashesExactlyOncePerVisitToAboutGpuCrash should no
longer be flaky, at least not for the previous reason.

Bug: 861956
Tbr: bsalomon@google.com
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I37a34caf9b5725ddc877ac81a1760ad72dfbb261
Reviewed-on: https://chromium-review.googlesource.com/1142233
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576176}

R=nparker

Bug: 837707,836359,831563
Change-Id: Ice5c619948e47a3df6a257fc062ab9d38928bbab
Reviewed-on: https://chromium-review.googlesource.com/1139032Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576175}

- Migrates the code from LegacyHistoryCollectionVC and LegacyHistoryEntryItem into
HistoryTableVC and HistoryEntryItem to add support for custom accessibility actions.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I73d9a35a31822e98fb09d5828f7eee37211d06d5
Reviewed-on: https://chromium-review.googlesource.com/1125328Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576174}

This reverts commit 0062abf0.

Reason for revert: Fixing...

Original change's description:
> Revert "VR: Ensure we remove black overlay if VR is exited while entering."
>
> This reverts commit 9f8158c1.
>
> Reason for revert: Culprit of failed VR tests https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Nougat%20Phone%20Tester/6884
>
> Original change's description:
> > VR: Ensure we remove black overlay if VR is exited while entering.
> >
> > This fixes a failure mode where we shutdownVR after handling the VR NFC
> > broadcast, and fail to properly cancel VR entry.
> >
> > Also does some other random cleanup of comments/visibility.
> >
> > Bug: 862829
> > Change-Id: Ic382692d7255aa5893391a602a6c949b4b4d498b
> > Reviewed-on: https://chromium-review.googlesource.com/1138726
> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#575388}
>
> TBR=mthiesse@chromium.org,tiborg@chromium.org
>
> Change-Id: Ibe67ee8c09dc44ac34d40c3eaf890884b400fc24
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 862829
> Reviewed-on: https://chromium-review.googlesource.com/1140813
> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575725}

Change-Id: I71738aafff0b703083f465085fb71f54d047729b
Bug: 862829
Reviewed-on: https://chromium-review.googlesource.com/1142167Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576173}

@IntDef/@StringDef annotation are preferred way for declaring
set of String/int values:

1. they need less space in APK than enum, see
https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
2. they give more control over allowed values than "static final" values

Main goal of patch is writing "static final" values, enum
and some classes in one common @IntDef/@StringDef form:

1. with @IntDef/@StringDef first, @Retention second
   and related @interface third
2. with values inside @interface
3. with NUM_ENTRIES declaring number of entries if necessary
4. with comment about numbering from 0 without gaps when necessary
5. with @Retention(RetentionPolicy.SOURCE)
6. without "static final" in the @interface

Additionally there are done some other trivial cleanups.

Change-Id: Id50845175a85cb5fc5919c8b79c1cd492f0d994d
Reviewed-on: https://chromium-review.googlesource.com/1136879
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576172}

SDP semantics can be passed in to the PC as kPlanB, kUnifiedPlan or
kDefault.

This CL does the translation from kDefault to kPlanB (default) or
kUnifiedPlan (if a flag is used to overwrite the default) at
construction once and for all. This eliminates assumptions about what
kDefault may mean in different parts of the code or layers.

RTCPeerConnectionHandler is also updated to keep track of the SDP
semantics. Also passes down "sdp_semantics_requested" for the sake of
UMA counters which is the exception where we do care if "kDefault" was
used or not by the application.

This CL also updates some Plan B-only methods to DCHECK SDP semantics
or renames them to "...PlanB()".

// Bots have already been successful, skipping remaining bot which is
// inactive.
NOTRY=True

Bug: 777617
Change-Id: If88017360fa577297796bac4faf4e7bc56bd99d0
Reviewed-on: https://chromium-review.googlesource.com/1141880
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576171}

No change to logic.

This adds a gitignore file to ignore *.iml files, which are created by
Android Studio. We add the rule at this level so that it gets picked up
when we mirror this folder into Android (same reason we have proguard
rules at this specific level).

This is not expected to affect Chromium (other than it ignores *.iml
files in this subtree, which should not cause issues for developers).

Based off sergeyv@'s CL http://ag/4570535.

R=torne@chromium.org

Change-Id: I015e29269923054afffb9288c37170cc124be7c2
Reviewed-on: https://chromium-review.googlesource.com/1142368Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576170}

A browser might shutdown, for example, when a request moves to the
active state, but before we delete the pending entry.
This CL modifes the initialization DatabaseTask to delete such
inconsistencies.

Change-Id: Icefcac3789d299c83bbda2b7b1dc117ca4e1a5e0
Reviewed-on: https://chromium-review.googlesource.com/1140164
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576169}

Visibility is already stablished by parent element.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8c8494a5137cc09b3ef7eab355c8016c2b14f541
Reviewed-on: https://chromium-review.googlesource.com/1140506Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576168}

https://chromium.googlesource.com/chromium/llvm-project/compiler-rt/lib/fuzzer.git/+log/873dc11d9a52..2f72894d302e

$ git log 873dc11d9..2f72894d3 --date=short --no-merges --format='%ad %ae %s'
2018-07-17 dor1s [libFuzzer] Mutation tracking and logging implemented.
2018-07-17 morehouse libFuzzer: prevent irrelevant strings from leaking into auto-dictionary
2018-07-16 dor1s Revert r337194 (https://reviews.llvm.org/D48891) due to compilation errors.
2018-07-16 phosek [CMake] Use cxx-headers as a depedency for C++ headers
2018-07-16 dor1s [libFuzzer] Mutation tracking and logging implemented.
2018-07-16 dor1s [libFuzzer] Implement stat::stability_rate based on the percentage of unstable edges.
2018-07-16 dor1s Revert r337175 (https://reviews.llvm.org/D49212) due to unintentional format changes.
2018-07-16 dor1s [libFuzzer] Implement stat::stability_rate based on the percentage of unstable edges.
2018-07-10 morehouse Revert "[Fuzzer] Afl driver changing iterations handling"
2018-07-10 delcypher [CMake] Add compiler-rt header files to the list of sources for targets when building with an IDE so that header files show up in the UI. This massively improves the development workflow in IDEs.
2018-07-09 morehouse [libFuzzer] Make -fsanitize=memory,fuzzer work.
2018-07-09 morehouse Revert "[libFuzzer] Mutation tracking and logging implemented"
2018-07-09 morehouse [libFuzzer] Mutation tracking and logging implemented
2018-07-06 kcc libFuzzer: always print line-break for NEW_FUNC/PC output
2018-07-04 george.karpenkov [libFuzzer] [NFC] Inline static variable to avoid the linker warning.
2018-07-03 kcc [libFuzzer] add one more value profile metric, under a flag (experimental)
2018-07-03 kcc [libFuzzer] remove stale code, as suggested in https://reviews.llvm.org/D48800
2018-06-26 morehouse [libFuzzer] Do not turn unittest warnings into errors.
2018-06-25 morehouse [libFuzzer] Use Vector rather than std::vector.
2018-06-18 phosek [Fuzzer] Set an explicit libc++ dependency when needed
2018-06-17 vitalybuka [fuzzer] Python 3 print fixes
2018-06-17 vitalybuka [fuzzer] Fix collect_data_flow.py for python 3
2018-06-15 phosek [Fuzzer] Don't hardcode target architecture for Fuzzer tests
2018-06-14 george.karpenkov [libFuzzer] [NFC] Support multi-arch and multi-OS building and testing
2018-06-13 phosek Reland "Passthrough additional flags to custom libcxx CMake build"
2018-06-12 morehouse Revert r334458, r334220, r334212, r334139.
2018-06-12 devnexen [Fuzzer] Afl driver changing iterations handling

Created with:
  roll-dep src/third_party/libFuzzer/src

Change-Id: I829245a79191c8bf78e0ba19ac7e7fa03bd96cd6
Reviewed-on: https://chromium-review.googlesource.com/1141988
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576167}

NOTRY=true # Test covered by PRESUBMIT

Bug: 865092
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: Ia8a505965fef699e5e0653db94006a0dee3f0b8a
Reviewed-on: https://chromium-review.googlesource.com/1142235
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576166}

When computing whether a float can fit in the line or not,
NGLineBreaker needs to know the current width after trailing
spaces are collapsed. The current logic removes trailing
spaces before computing it, but only at the end of the block.

To compute this correctly on each wrapped line, this patch
adds TrailingCollapsibleSpaceWidth() that computes without
removing it, so that it can be removed only when the float
fits. This allows us to check whether the float can fit or
not for each wrapped line.

In many cases, the computed trailing spaces will be removed.
This patch also adds a cache to avoid computint it twice,
because it may involve re-shaping.

Rather large refactoring in order to split computing and
removing, to avoid computing twice, and to avoid failures
due to rewinding positioned floats.

Bug: 862066
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ica6ce94fca63d5bdcf7784eead53dba6e680e177
Reviewed-on: https://chromium-review.googlesource.com/1133599
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576165}

Handle network, auth, and service errors that can occur when
communicating with the Backdrop and Photos APIs. Display these errors
in the UI. Add the 'message-box' that functions similarly to the
'mv-notice' element.

Redirect the user to sign-in if they are signed-out when selecting
Google Photos.

If the user has no Google Photo albums, link them to the page where
they can create an album.

Bug: 848981, 854418, 854420, 864011
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ie9d8d246ac9cd0275646c99632f15feb958e423a
Reviewed-on: https://chromium-review.googlesource.com/1136839
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576164}

glClear appears to crash on this device. Enabling the "gl_clear_broken"
workaround.

BUG: 860418
Change-Id: I06ff00e2aa7523b43e283bcdc09b2d36ceacf4e4
Reviewed-on: https://chromium-review.googlesource.com/1137784Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576163}

This CL adds an 8dp right-padding to the match cell of suggestions.

This CL also makes the right-padding of the tab-switch to be the same as
the match cell. Previously it was set to be the same as the vertical
padding.

That should also increase layout predictability in the face of very
tall glyphs.

Bug: 863982
Change-Id: I1bdbfc0062d1ddeba57d21cc2813ed30d42548c7
Reviewed-on: https://chromium-review.googlesource.com/1141288
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576162}

Also only change the current context if it is necessary (jank has been
observed during context switch in traces).

Also also re-arrane the individual fence-polls to only do one poll,
and to trace each individual poll.

Bug: 863817
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Iaa7c4046d2bb59e4abdd27b9e2e4b311e85b7c99
Reviewed-on: https://chromium-review.googlesource.com/1141182Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576161}

RegisterUMAObserver is soon to be deprecated in PeerConnectionInterface
in WebRTC.

Bug: None
Change-Id: Iad9fe987ee9dcd1512c332a7084e2d1ae5cc4774
Reviewed-on: https://chromium-review.googlesource.com/1141173
Commit-Queue: Qingsi Wang <qingsi@google.com>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576160}

Jumbo isn't compatible with "using namespace" since those cause
compiler warnings unless in the top level file, but "using namespace"
is also prohibited by the code style guide (see:
https://google.github.io/styleguide/cppguide.html#Namespaces )

This makes the code a bit more verbose, but it also makes it
more self consistent since the gles2:: prefix was already
occasionally used.

Bug: 864986
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7c2111e70407a7ddf65473cb83e7f63b70b18747
Reviewed-on: https://chromium-review.googlesource.com/1141882Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#576159}

R=fdoray@chromium.org

Bug: 848255
Change-Id: Ic47d338fb15e0bf3579ecd9d1acca67099c6d570
Reviewed-on: https://chromium-review.googlesource.com/1137849Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576158}

This reverts commit 62973d1b.

Reason for revert: results in more churn in
base::Time::ActivateHighResolutionTimer()
without much benefits (decreased 97th and 98th percentile of
Windows.HighResolutionTimerUsage from 100% to 97% and 99%
respectively). See crbug.com/863938

Original change's description:
> [MessageLoop] Disable hi-res timers when not sleeping
> 
> Time::ActivateHighResolutionTimer(bool activating) is a per-thread vote
> for a system-wide side-effect. For a given thread, hi-res timers are
> only useful when going to sleep (if it has pending hi-res tasks).
> 
> Deactivating a thread's vote while it's active will prevent other
> threads on the system which do not have hi-res requirements from
> being forced to use hi-res timers in that period.
> 
> Bug: 854237
> Change-Id: I1393e184cac6c9321d13b92b6077a38c62b1f590
> Reviewed-on: https://chromium-review.googlesource.com/1107110
> Reviewed-by: danakj <danakj@chromium.org>
> Reviewed-by: kylechar <kylechar@chromium.org>
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574259}

TBR=danakj@chromium.org,gab@chromium.org,kylechar@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 854237, 863938
Change-Id: I7c26646cac8548ae7b02c90e045bc857ae890ce7
Reviewed-on: https://chromium-review.googlesource.com/1140753Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576157}

This enables the table-based Reading List UI to be released with the
rest of the Phase 1 UI Refresh features.

This CL also updates Reading List EGTests to use a11y identifiers for
toolbar buttons rather than labels.  In the UI Refresh, the toolbar
buttons are based on UIBarButtonItems, which are rendered using
multiple views with the same a11y label.  Since EGTests couldn't find
matchers for the label, IDs are used instead.

Bug: 864378
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I223469771314907b614120a6b98f9bb92ce40b25
Reviewed-on: https://chromium-review.googlesource.com/1139901
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576156}

This CL simplifies the threading of class VideoCaptureCamera2.java
and by doing so resolves potential issues caused by concurrent
access to member variables and Android video API calls.

See https://bugs.chromium.org/p/chromium/issues/detail?id=857530 for
details on issues.

The simplified model is to (still) have the constructor and public API
calls happen on a native thread, and to use a single dedicated thread
owned by the class instance to post to, do work on, and call back into
the native code.

This CL is part of a series, see Design Doc at
https://docs.google.com/document/d/1h1kva4VR1gaV3HVXaSYZFY41icfaB58j-WnHmJdyqc8/edit?usp=sharing

Bug: 857530
Change-Id: I75ffcc4a14f2395d833d80f300acef7b456676e8
Reviewed-on: https://chromium-review.googlesource.com/1117857
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576155}

This CL is a step toward unifying the canvas and OffscreenCanvas
presentation code paths by making WebGL contexts use CanvasResource
to pass frames for OffscreenCanvases

This change revamps mechanisms for triggering calls to PushFrame()
The mechanisms was change to reference OffscreenCanvas object instead
of rendering contexts.  This fixes a destruction race condition where
redereng contexts were failing to de-register themselves when their
host is disposed first.  We also stop requesting BeginFrames in
OffscreenCanvasDidDraw in cases where the draw happens from within
a rAF callback on a worker.

BUG=788439
TBR=zmo@chromium.org
NOTRY=true

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I36965c4a0a892484a9ede966b268c91c7a34548f
Reviewed-on: https://chromium-review.googlesource.com/1135637
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576154}

This is a refactor-only change that cleans up namespaces in
Select-to-Speak, for NodeUtils, ParagraphUtils, WordUtils, and RectUtils.

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Iff4adaf10a2bee1f6c777505f1e0acadb1ab60d0
Reviewed-on: https://chromium-review.googlesource.com/1140893Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576153}

https://chromium.googlesource.com/catapult.git/+log/a824624071cc..941ac6857d71


git log a824624071cc..941ac6857d71 --date=short --no-merges --format='%ad %ae %s'
2018-07-18 dtu@chromium.org [pinpoint] Add android-go-perf and android-go_webview-perf bots.


Created with:
  gclient setdep -r src/third_party/catapult@941ac6857d71

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:863767
TBR=sullivan@chromium.org

Change-Id: I2e8c37e442665f03348b83ce6d4813d3a73159d1
Reviewed-on: https://chromium-review.googlesource.com/1142005Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#576152}

This is to remove the last usage of NeedsManualRebaseline

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1bc7e63d41acf1f7813d8ac5fba4ae29f3b6691b

BUG: 865039, 621126
Change-Id: I1bc7e63d41acf1f7813d8ac5fba4ae29f3b6691b
Reviewed-on: https://chromium-review.googlesource.com/1142194
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Reviewed-by: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576151}

Changes cast system gesture handling so that events which happen on
the side swipe margin are replayed when the finger is lifted before
leaving the margin area, allowing UI elements to be accessed in the
margin.

Note: A refactoring of the side swipe detection into an EventRewriter
was necessary to allow for the redispatching of the stashed
events. The side swipe detection was factored out into a separate
class, leaving the tap/press handling in the EventHandler.

Bug: internal b/111304882
Test: manual and unit tests
Change-Id: If446ed0d97bc9e5f127c311e98f0ed8289071dd3
Reviewed-on: https://chromium-review.googlesource.com/1141060Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org>
Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Ryan Daum <rdaum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576150}

Aligns values used for text with the ones requested by the spec.

Bug: chromium:863586
Change-Id: I0e9b4c32bd672e38ab2b6a7831fc62fdefe0f650
Reviewed-on: https://chromium-review.googlesource.com/1141359
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576149}

This CL is part of the effort to remove usage of iron-icons/* iconsets
to reduce size of resources loaded.

Bug: 855205
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ibc118f02603e735cc1f3adff66a4fb3fdaace2ce
Reviewed-on: https://chromium-review.googlesource.com/1135990
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576148}

Bug: 753416
Change-Id: If99e2fd12cec42eb3c6a6d464df98f67177ba746
Reviewed-on: https://chromium-review.googlesource.com/1142139Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576147}

BUG=853900

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7e53ddd44240c46e0de1742ece470827eb4fcc10
Reviewed-on: https://chromium-review.googlesource.com/1139016Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576146}

This Cl fixes the spacing between the grid cell title and the close
button. When setting a constant offset for a trailing anchor, a positive
constant results in the trailing anchor being further in the trailing
direction, so a negative constant is needed to ensure the trailing anchor is on
the leading side of the anchor it is constrained to.

Per UX, the offset between the label and the button is set to 4 points.

Bug: 862343
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I01fc0e927c281ea5b174af4126c7e44fd3fc4f7f
Reviewed-on: https://chromium-review.googlesource.com/1140316Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576145}

This CL changes the constructor for CountDownLatchImpl to use a DCHECK
to disallow initialization counts less than 0. An initialization count
of exactly 0 is still allowed, in which case countDown() will never
Signal() its WaitableEvent, and all calls to Await() will immediately
return.

Bug: 861813
Change-Id: Ic7807544c792be010f46ca58391a02f64ab1638e
Reviewed-on: https://chromium-review.googlesource.com/1141101
Commit-Queue: Kyle Qian <kyleqian@google.com>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576144}

Unfortunately some Linux apps don't abide to the desktop specification.
This change add some hard coded mapping so that those apps can be
identified.

BUG=chromium:854911
TEST=Manually tested on a eve device.

Change-Id: Id53c889d46337766b77802682d964d5e2bda85dd
Reviewed-on: https://chromium-review.googlesource.com/1141055
Commit-Queue: Tim Zheng <timzheng@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576143}