- 06 Feb, 2020 40 commits
-
-
mark a. foltz authored
https://chromium-review.googlesource.com/c/chromium/src/+/1985812 added a generated include to chrome/ui/browser.h, which we can't depend on directly for reasons. This adds the dependency directly to fix the Open Screen try bots. Bug: 1030821 Change-Id: Ic2b97bab07f57b8512097bcb2803c9cbc233f377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040735Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#738800}
-
Yoichi Osato authored
This CL has it generate same result both on Linux and Windows while avoiding line-end mismatch. Change-Id: I99636aa42f5e386208f92dcfe9b0480ebd803caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033061Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#738799}
-
Mohamed Heikal authored
Change-Id: I49587bae7c1a7a3284ffe8563b694d84539e09a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039981 Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#738798}
-
Gyuyoung Kim authored
As a second step to convert the content shell test harness, this CL converts the below messages to Mojo by using WebTestClient interface. - WebTestHostMsg_SimulateWebNotificationClose - WebTestHostMsg_SimulateWebContentIndexDelete - WebTestHostMsg_InspectSecondaryWindow - WebTestHostMsg_TestFinishedInSecondaryRenderer WebTestClientImpl class implements the methods of WebTestClient interface. Other WebTestHostMsg conversions will be prepared after this initial CL. Bug: 1039247 Change-Id: I3f021e7c17a5239c4eb1467d464a312411347b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032697Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#738797}
-
Fergus Dall authored
Bug: 1031512 Change-Id: I28f8f06c57365a4c5178f3c94db2f8fd3910f806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037183Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#738796}
-
Xiaohan Wang authored
By default it's enabled. No effect if ENABLE_CDM_HOST_VERIFICATION buildflag is false. To disable this feature for testing, type the following in the command line: --disable-features=CdmHostVerification Bug: 658036 Test: Manually tested with the feature disabled Change-Id: Ia2d077436a1a8445aec29163a88d1bb4539c4811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036257Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#738795}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/44ea3ffa40fe..fff0fe4deadd git log 44ea3ffa40fe..fff0fe4deadd --date=short --first-parent --format='%ad %ae %s' 2020-02-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@fff0fe4deadd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I9f1f6b31ad62c93559be473c3c00d7fc127841f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040670Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738794}
-
Ken MacKay authored
Allows disabling the amp when streams are 'playing' at 0 volume. Bug: internal b/145634794 Change-Id: I994b23d3be7d0a1bac27b4ab347eb7f03d6f9a18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040614Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#738793}
-
Fergal Daly authored
This is not public and not shared with the renderer. Bug: 981339 Change-Id: Iad7201c371135027280c814326e154cb10858f4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035815Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#738792}
-
Dominic Mazzoni authored
VoiceOver was incorrectly reading links that contained absolute-positioned text inside. As a workaround, expose the text of a link in AXDescription instead of AXTitle. That forces VoiceOver to treat it similarly to a link that has an aria-label on it, so it favor's Chrome's accessible text, rather than treating it as a link containing visible text and using its own (broken) heuristics to describe what's inside. It's possible this could have a side effect, if VoiceOver was announcing more detailed information inside a link. But it'd still be possible to access the contents of the link, so this is probably okay. Bug: 1048782 Change-Id: I2764afe80af1f6afc4c191cf7f98bbcb6b3c025f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037710 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#738791}
-
Ana Salazar authored
For http://crrev.com/c/1963102 we changed the histogram suffixes but didn't update the definition in histograms.xml Change-Id: I966721a70fa3ca8b864bd2af180afb39ea9b063d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036797Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#738790}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/cba278682002..a2e5f0a6a4fa git log cba278682002..a2e5f0a6a4fa --date=short --first-parent --format='%ad %ae %s' 2020-02-06 jophba@chromium.org Remove pthatcher@ from reviewers list Created with: gclient setdep -r src/third_party/openscreen/src@a2e5f0a6a4fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I5014df8ff7fed88096240206fb77bd8460cb8788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040017Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738789}
-
Mark Pearson authored
Expanded to make it more precise and detailed. If this description reads well, I'll revise the other two analogously. Change-Id: I069fef0a0714e3fa3ec6e2eb693b3c24f6cceeeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036282 Commit-Queue: Mark Pearson <mpearson@chromium.org> Auto-Submit: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#738788}
-
Yury Semikhatsky authored
WebContents dispatches RenderProcessGone only for the main frame's process. To receive such notifications for out-of-process iframes we now subscribe to the frame's process events directly. Bug: none Change-Id: I3cd4b4b7f9a69ed749e624ac82c6feb94111f207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040051 Commit-Queue: Yury Semikhatsky <yurys@chromium.org> Auto-Submit: Yury Semikhatsky <yurys@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#738787}
-
Yoshifumi Inoue authored
This patch changes |TextOffsetMapping::FindBackwardInlineContents()| to skip ancestors when current position is first child for avoiding looping by backward word caret movement. IN below example (assume we are in "div3"), before this patch we attempt to find inline contents for "div2" and "div1", after this patch we use previous sibling of "div1". <div id=div1><div id=div2><div id=div3>|abc</div></div></div> Bug: 1039829 Change-Id: I04a79bcb07c74658927a8eec40b4dead2cdf2fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037303 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#738786}
-
Haiyang Pan authored
When set, graphical window display on the emulator is enabled Bug: 922145 Change-Id: Idabc3bfee289ce2ec505a607e825ea81fab97229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040612Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#738785}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7e44d3cbb30e..5b6a7487a412 Created with: gclient setdep -r src-internal@5b6a7487a412 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1012659 Tbr: jbudorick@google.com Change-Id: Ia9608fb6f1fb2b48b756574c415a0796a0b97bce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040388Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738784}
-
Tommy Steimel authored
This CL splits the Kaleidoscope resource ID allotment into includes and messages sections. Bug: 1045435 Change-Id: If21442a8404a2e924424ebe62aeb9b2b29524bfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032407Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#738783}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a44d96dcd676..20b1259ae94e git log a44d96dcd676..20b1259ae94e --date=short --first-parent --format='%ad %ae %s' 2020-02-05 jmadill@chromium.org Vulkan: Command graph linearization (Step 2). 2020-02-05 jonahr@google.com Extend ANGLE_iosurface_client_buffer to Vulkan backend for Swangle 2020-02-05 julien.isorce@chromium.org Move generic code from rx::DisplayAndroid/Ozone to rx::DisplayEGL Created with: gclient setdep -r src/third_party/angle@20b1259ae94e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1015454 Tbr: cnorthrop@google.com Change-Id: I65d1f64f148ad9167dff326e3a4a2d3785e71a02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040014Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738782}
-
rbpotter authored
- Add Polymer 3 versions of settings_page/* files to the grdp - Autogenerate tests for Polymer 3 versions of settings-subpage and settings-animated-pages Bug: 1026426 Change-Id: I73dd675aa3f2b765c1149679bd657a8d63c7aea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038456Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#738781}
-
Collin Baker authored
Bug: 967603 Change-Id: I6f1df832c83f70d236d3acdec3a215e8ba0df514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033638Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#738780}
-
Alex Danilo authored
Changes some -webkit prefixed properties to real CSS properties. Disables tex-align:right warning for our RTL special casing of direction for file names. No functional change. Bug: 1049413 Change-Id: I07828075820519630f3fd5d87e7855603ee8f46d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040634 Auto-Submit: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#738779}
-
David Black authored
This is achieved by flattening the existing AssistantWebView into AssistantWebContainerView. Note that a follow up CL will take the name 'AssistantWebView' and reassign it to what is now called 'AssistantWebView2'. Bug: b:146520500 Change-Id: I242085c039317936047341193ba05c857a144182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040199Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#738778}
-
Yoshifumi Inoue authored
Make NGInlineCursor::PositionForPointInChild() to call NGFragmentItem::PositionForPoint() with child local offset This patch changes |NGInlineCursor::PositionForPointInChild()| to call |NGFragmentItem::PositionForPoint()| with child local offset instead of offset in container because |NGFragmentItem::PositionForPoint()| expects local offset as |NGPaintFragment:: PositionForPointInText()|. This patch fixes following tests (at least): - fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-user-select-none.html - fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-with-before-style.html - fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-with-first-letter-style.html Failure counts is decreased to 206 from 215. Bug: 982194 Change-Id: I839e9f480bb98501fb463da0dae6b42b2eb2b0e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038590 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#738777}
-
Brandon Wylie authored
Replace the regular grey mic with the colorful one. This will allow experimenting the following configurations: - Regular voice search, grey mic. - Assistant voice search, grey mic - Assistant voice search, colorful mic To support this addition, I needed to factor out the logic into its own service which can be used by NewTabPageLayout and LocationBarLayout. It also increases the modularity of the feature, which will make merges easier. Bug: 1046170,1045203 Change-Id: I728beffa69d0db75eeafd48dcf1918cfacfcbf27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023300 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#738776}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d2b2837f5716..989bb5e74cd4 git log d2b2837f5716..989bb5e74cd4 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 treehugger-gerrit@google.com Merge "traced_perf: feed samples through libunwindstack" Created with: gclient setdep -r src/third_party/perfetto@989bb5e74cd4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iedbf4a5704c1603b75e0db6b367e6286b8be8483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039376Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738775}
-
Changwan Ryu authored
Bug: 975908 Change-Id: I066741b274f2f64b81197e44f97a0c20ebc957fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036364Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#738774}
-
Patrick Monette authored
ModuleDatabase::GetInstance() may only be called on ModuleDatabase::GetTaskRunner(). DisableThirdPartyBlocking() is a static method that can be called from any sequence which internally calls GetInstance() on the correct sequence. Bug: 1049211 Change-Id: Ie99d93eeaded2e8e90cb9ba1f99457b55b70a78e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039772 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#738773}
-
Darwin Huang authored
Miscellaneous spellfixes. No functional changes. Instances of "necessary" and "board". Change-Id: Ib3c9031ca98cdd2f7ebc661a62692b9ebba8c9b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040063 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#738772}
-
Robert Sesek authored
DelaySandboxInitialization() is not called anywhere and is dead code. ProcessRegistersWithSystemProcess() was used under the V1 sandbox architecture to warm-up access to various IOKit services. Under the V2 sandbox architecture, there is no warm-up phase and the sandbox profiles simply allow access to those resources where needed. This allows base::PowerMonitorDeviceSource to be simplified, since the IOServices can be directly connected to rather than pre-allocated. Change-Id: I56769c90bd7fd9d8a5c3b8d16dc8166a53b5ce03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039390 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#738771}
-
Thomas Guilbert authored
Currently, we jump to the compositor thread in order to set the new frame presented callback on the VideoFrameCompositor. This CL is a small change that allows us to set that callback from the main thread. This should help minimize the amount of frames we miss in video.rAF calls. Bug: 1012063 Change-Id: I521eb0bf0a6e71f59552c60276006e1884c1f989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040436 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#738770}
-
Ben Pastene authored
The PRE_* test fails, while the non-PRE test passes, causing browser_tests to fail on bots (but the build remains green): https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/34103 See crbug.com/1045100 for fixing the build status report. Bug: 1035156 Change-Id: I70d28db7cc800a40e5f7d6ca8312510a3bf95c65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017670Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#738769}
-
Kenichi Ishibashi authored
* Let WriteToDiskCache{A,S}sync() assign resource ID internally * Add WriteToDiskCacheWithIdSync() that works as the same as the previous WriteToDiskCacheSync() NewResourceId() call will become async once we move ServiceWorkerStorage to the storage service. This CL reduces NewResourceId() calls so that we don't have to make all call sites async in the future. Bug: 1046335 Change-Id: I9ad57f8920bd5e157bd4ba8262699f72148b5bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035637 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#738768}
-
Tim Song authored
This is a first pass, adding the plumbing and implementing a simple subset of the detailed notification interaction metrics. Follow-up CLs will implement the rest of the metrics. BUG=1047053 Change-Id: Idafc1cdf804097710a53f5d312fd9a30a7bcfa45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037025Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#738767}
-
Sujie Zhu authored
We add FIDO auth toggle on Clank Autofill Payment settings page. The toggle is shown only when 1) autofill is enabled 2) sync is enabled 3) feature flag is enabled. The requirement check is accomplished by adding one more PersonalDataManager bridge function. We reuse FIDOAuthEnabled preference to show current user's status and record user's intention (intent to opt in/out). The preference is exposed to Java side in order to get/set the preference via PrefServiceBridge. Local tested video (Googlers only): https://drive.google.com/a/google.com/file/d/1nJ1pSJZu1e5oV6qle_Piog6-a-v7kmZs/view?usp=sharing For more detailed background (Googlers only): go/autofill-auth-clank-settings Bug: 949269 Change-Id: Iefad4c953eee4dc00ec54627810b135c1eec6206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029255 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Manas Verma <manasverma@google.com> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#738766}
-
Ehimare Okoyomon authored
Implement a bridge to connect Java UI to the CookieControlsService for a consistent backend with the web implementation. Bug: 1040091 Change-Id: I023e96d39c14aad20d3d82ff46e560916e595115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035894 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#738765}
-
shrekshao authored
Bug: 1013369 Change-Id: I04a8ce5ce11fb6a5d67acc782c2e297224b8685b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029236 Commit-Queue: Shrek Shao <shrekshao@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#738764}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/01005814aa9a..2fe6351af3c1 git log 01005814aa9a..2fe6351af3c1 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 John.Emau@microsoft.com Console: fix no scroll bug in context selector 2020-02-05 Rob.Paveza@microsoft.com Mismatched SASS source maps cause Performance recording to fail 2020-02-05 aerotwist@chromium.org [e2e] Updates separaters 2020-02-05 aerotwist@chromium.org [e2e] Moves hosted mode server to JS side 2020-02-05 tvanderlippe@chromium.org Remove hello world e2etest 2020-02-05 tvanderlippe@chromium.org Add remaining console startup tests 2020-02-05 khamu@microsoft.com High contrast fix in Console tools panel 2020-02-05 aerotwist@chromium.org [e2e] Moves shared logic out of e2e 2020-02-05 aerotwist@chromium.org [e2e] Fix exit code and paths for bots. 2020-02-05 rayankans@google.com [BackgroundService] Show tooltip over `other domains` checkbox Created with: gclient setdep -r src/third_party/devtools-frontend/src@2fe6351af3c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1040254,chromium:1047671,chromium:1048378,chromium:1048978,chromium:1049155 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If4a5055ceddfc99536987fbf78148ee9a6befa39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040250Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738763}
-
Isabella Scalzi authored
Add a test that tests deleting an item from Quick View that is part of a check selection. Bug: 803259 Change-Id: Icf9c77eee2fbeb400a981a0ecbe481addffaae2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038295 Commit-Queue: Isabella Scalzi <isabellascalzi@google.com> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#738762}
-
Avery Musbach authored
They were for OverviewController::OnOverviewButtonTrayLongPressed which was moved to SplitViewController in https://chromium-review.googlesource.com/c/chromium/src/+/2024447 Bug: None Change-Id: Id1e0b88c50f05d292040a7a9f04d83bd762c2d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040382Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#738761}
-