GitLab

Adds HeapCompaction as a FeatureList flag so it can be enabled from a Finch experiment.

BUG=678923

Review-Url: https://codereview.chromium.org/2624693002
Cr-Commit-Position: refs/heads/master@{#443210}

BUG=chromium:663353

Review-Url: https://codereview.chromium.org/2488933002
Cr-Commit-Position: refs/heads/master@{#443209}

Currently, the ConnectionEventTracker keeps a buffer in memory of events
which still need to be sent to GCM. If there is a shutdown, those events
are discarded without reaching GCM. This CL adds a metric to track the
event count at shutdown to give an estimate of how many events are being
lost and whether a persistence layer needs to be added.

BUG=662983

Review-Url: https://codereview.chromium.org/2594373002
Cr-Commit-Position: refs/heads/master@{#443208}

This patch gets rid of |CaretBase::m_caretLocalRect| to reduce number of states
in |CaretBase| to simplify class hiarachity for improving code health.

After this patch, |CaretBase| represents |DisplayItemClient| for caret.
Following patch will rename |CaretBase| to |DisplayCaretItemClient| and
|DragCaretController|, which should rename to |DragCaret| is derived from
|DisplayCaretItemClient| and makes |DisplayCaretItemClient| had no public
member except for destructor.

This patch is a preparation of [1]

[1] http://crrev.com/1958093002 On-demand visible selection canonicalizataion

BUG=680384
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2623053006
Cr-Commit-Position: refs/heads/master@{#443207}

mostForward/BackwardCaretPosition should be, but are currently not,
called with clean layout.

This patch ensures that they are called with clean layout at
several places in editing/commands

BUG=679991

Review-Url: https://codereview.chromium.org/2628693003
Cr-Commit-Position: refs/heads/master@{#443206}

New media view volumes are added to chromeos::VolumeManager so that they are
available to Files.app. UI patches are coming later, so at this point it looks like
unusable unknown volumes appear in Files.app. To hide them from users for now,
the feature is guarded with base::FeatureList. Once UI is ready I will make them
enabled by default.

BUG=chromium:671511
TEST=New (unusable) volumes are shown with --enable-features=ArcMediaView
TEST=Media views work with local pending UI patches

Review-Url: https://codereview.chromium.org/2580303002
Cr-Commit-Position: refs/heads/master@{#443205}

This patch fixes setting of css-wide keywords on registered custom
properties, which was broken by crrev.com/2607403002.

BUG=679627

Review-Url: https://codereview.chromium.org/2624213004
Cr-Commit-Position: refs/heads/master@{#443204}

Remove virtual/mojo-loading/http/tests/navigation/image-load-in-unload-handler.html from TestExpectations

The test looks no longer flaky.

BUG=674048

Review-Url: https://codereview.chromium.org/2624993002
Cr-Commit-Position: refs/heads/master@{#443203}

Clearing the whole font-cache without considering css-connected fonts
could be cheaper. This is a speculative fix for issue 677415.

BUG=677415

Review-Url: https://codereview.chromium.org/2622673003
Cr-Commit-Position: refs/heads/master@{#443202}

WritableStreamFinishClose would fail if the writer had been
detached. Add checks to stop this happening.

This updates the implementation to match Streams Standard version

https://github.com/whatwg/streams/commit/347667724b8a4b83fcc379b730603cf4cd0d6e91

which is current as of 12 Jan 2017.

Also update the tests to the same commit.

BUG=658144

Review-Url: https://codereview.chromium.org/2625873008
Cr-Commit-Position: refs/heads/master@{#443201}

The check as it is now was spamming too many unrelated changes.
Also make output of the check more precise by showing the line
number affected.

BUG=none

Review-Url: https://codereview.chromium.org/2622083006
Cr-Commit-Position: refs/heads/master@{#443200}

Changes the Reading List icon for the empty state with the new offline icon.

BUG=680152

Review-Url: https://codereview.chromium.org/2622003007
Cr-Commit-Position: refs/heads/master@{#443199}

As it is possible to specify multiple value for target_os in
.gclient, update the script build/mac_toolchain.py to download
the file for the hermetic build on all those OSes. Change the
path where the hermetic files are downloaded to use different
path for each OS.

BUG=680069

Review-Url: https://codereview.chromium.org/2626063002
Cr-Commit-Position: refs/heads/master@{#443198}

Fix compilation for removed files.

BUG=

Review-Url: https://codereview.chromium.org/2622263003
Cr-Commit-Position: refs/heads/master@{#443197}

Restore manual formatting in the kSimplePolicyMap array initializer and
add clang-format off and clang-format on sentinels to prevent accidental
reformatting in the future.

BUG=none

Review-Url: https://codereview.chromium.org/2628653003
Cr-Commit-Position: refs/heads/master@{#443196}

We will collect per allocator memory usage metrics for the renderer at DidFinishLoad and Shutdown.

GetRendererMemoryMetrics generalizes the memory info collection that was used in RecordPurgeAndSuspendMetrics for use with my new metrics.

GetRendererMemoryMetrics is in RenderThreadImpl because it accesses discardable_shared_memory_manager_.

BUG=

Review-Url: https://codereview.chromium.org/2566043004
Cr-Commit-Position: refs/heads/master@{#443195}

The API on action_runner to run JavaScript now supports safe and simple
interpolation of values into code templates. This CL fixes and cleans
up many of the callers which weren't using robust methods for quoting
such values.

BUG=catapult:#3028

Review-Url: https://codereview.chromium.org/2618333006
Cr-Commit-Position: refs/heads/master@{#443194}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/a048ce1..076b7ae

$ git log a048ce1..076b7ae --date=short --no-merges --format=%ad %ae %s
2017-01-12 sakal@webrtc.org Remove some Android lint suppressions.
2017-01-11 skvlad@webrtc.org Move MetricsObserverInterface out of peerconnectioninterface.h
2017-01-11 glaznev@google.com Initial implementation of Android audio recording error handling.
2017-01-11 deadbeef@webrtc.org Reland of: Adding error output param to SetConfiguration, using new RTCError type.
2017-01-11 michaelt@webrtc.org Add overhead to audio bwe min, max.
2017-01-11 henrika@webrtc.org Removes FATAL() from MicrophoneVolumeIsAvailable() on Android.
2017-01-11 sakal@webrtc.org Update Android instrumentation tests to use JUnit4.
2017-01-11 sakal@webrtc.org Update AppRTCMobile tests to use JUnit4.
2017-01-11 nisse@webrtc.org Replace ASSERT(false) by RTC_NOTREACHED().
2017-01-11 sprang@webrtc.org Remove backwards compatibilty path for OpenH264 v1.4
2017-01-11 sprang@webrtc.org Rename incoming_framerate_ to capture_framerate_ in screenshare_layers.
2017-01-11 hbos@webrtc.org RTCMediaStreamTrackStats.ssrcIds removed.
2017-01-11 magjed@webrtc.org Revert of Android: Add field trial for Intel HW Vp8 encoder (patchset #1 id:1 of https://codereview.webrtc.org/2614373004/ )
2017-01-11 philipel@webrtc.org Don't detect a new frame if a previous packet is used in a previous frame.
2017-01-11 magjed@webrtc.org Android: Add field trial for Intel HW Vp8 encoder
2017-01-10 nisse@webrtc.org Make OverheadObserver::OnOverheadChanged count RTP headers only
2017-01-10 magjed@webrtc.org Android: Wrap webrtc::field_trial::FindFullName in Java
2017-01-10 nisse@webrtc.org Move VideoFrame and related declarations to webrtc/api/video.
2017-01-10 brandtr@webrtc.org Reduce FlexFEC logging severity in two places.
2017-01-10 philipel@webrtc.org EndToEndTest.ReceivesAndRetransmitsNack now handles reordering.
2017-01-10 brandtr@webrtc.org Reorder assignments in WebRtcVideoChannel2::ConfigureReceiverRtp to match definition in VideoReceiveStream::Config.
2017-01-10 sakal@webrtc.org Add a check for CameraCapturer being initialized before calling startCapture.
2017-01-10 johan@webrtc.org Reland of Rename RTPVideoHeader.isFirstPacket to .is_first_packet_in_frame.
2017-01-10 nisse@webrtc.org Drop unneeded includes of base/stream.h.
2017-01-10 magjed@webrtc.org Final removal of webrtc/api/android
2017-01-10 ivoc@webrtc.org Fix for left shift of potentially negative value.
2017-01-10 kthelgason@webrtc.org Update bitrate adjustment with true buffer used size.
2017-01-10 kthelgason@webrtc.org Disable some filesystem tests that don't make sense on iOS.
2017-01-10 kwiberg@webrtc.org Add advice about Optional function arguments
2017-01-10 sprang@webrtc.org Revert of Fix BitrateProber to match the requested bitrate more precisely (patchset #4 id:60001 of https://codereview.webrtc.org/2613543003/ )
2017-01-10 kwiberg@webrtc.org Move FilePlayer and FileRecorder to Voice Engine
2017-01-09 deadbeef@webrtc.org Merge RTCConfiguration with RTCMediaConstraints in Java/Obj-C wrappers.
2017-01-09 deadbeef@webrtc.org Reland of: Separating SCTP code from BaseChannel/MediaChannel.
2017-01-09 sergeyu@chromium.org Fix BitrateProber to match the requested bitrate more precisely
2017-01-09 noahric@chromium.org Ensure internal_source is false for internal encoders.
2017-01-09 hnsl@webrtc.org Add disabled certificate check support to IceServer PeerConnection API.
2017-01-09 ivoc@webrtc.org Fix for left-shift of potentially negative values in NetEq.
2017-01-09 nisse@webrtc.org Delete final remnants of the buzz namespace.
2017-01-09 palmkvist@webrtc.org Lower bad call logging severity
2017-01-09 magjed@webrtc.org AVFoundationVideoCapturer: Fix apply_rotation() logic
2017-01-09 brandtr@webrtc.org Temporarily remove SSRC DCHECK in RTPSender::SendToNetwork.
2017-01-09 magjed@webrtc.org Make magjed@ owner of webrtc/sdk/objc
2017-01-09 stefan@webrtc.org Clean up ramp-up tests and make sure they all pass.
2017-01-09 mbonadei@webrtc.org Reland of Fixing package-boundary violation with srjar_deps (patchset #1 id:1 of https://codereview.webrtc.org/2617533005/ )
2017-01-09 kthelgason@webrtc.org Remove duplicate implementations of string conversion methods.
2017-01-09 kthelgason@webrtc.org Reland of Delete unused code from systeminfo. (patchset #1 id:1 of https://codereview.webrtc.org/2584563004/ )

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2626163003
Cr-Commit-Position: refs/heads/master@{#443193}

R=jochen@chromium.org
BUG=chromium:575167

Review-Url: https://codereview.chromium.org/2627923002
Cr-Commit-Position: refs/heads/master@{#443192}

Only supports ARM for now.

BUG=620034

Review-Url: https://codereview.chromium.org/2622133004
Cr-Commit-Position: refs/heads/master@{#443191}

Removes ThreadHeapMode enum and makes per thread heap mandatory.

Remove HeapTests.{GCParkingTimeout,RecursiveMutex,ObjectDeadBit} because they test threads attached to the main thread's heap.

BUG=591606

Review-Url: https://codereview.chromium.org/2625293002
Cr-Commit-Position: refs/heads/master@{#443190}

This patch makes Blink not to insert a character at selection if selection
doesn't have focus to align with other browser's behavior.

The test expectation of "keypress-focus-change.html" is changed for moving focus
on "keydown" event handler. In Firefox, it still insert a character at selection
but Blink and Edge don't. On manual focus moving, Firefox also doesn't insert
character.

To unblock CL[1] as soon as possible, this patch uses ugly test case. Following
patch will fix it.

[1] http://crrev.com/2616623002: Do not send redundant
ViewHostMsg_TextInputStateChanged-message

BUG=89026
TEST=LayoutTests/editing/input/keyboard_event_without_focus.html

Review-Url: https://codereview.chromium.org/2628763003
Cr-Commit-Position: refs/heads/master@{#443189}

A recent patch crrev.com/2607403002 introduced a 10% regression in
setters and getters for CSSOM style objects. This patch fixes this
by removing the additional binding to access the registry, instead
using already existing members to access it.

BUG=679511

Review-Url: https://codereview.chromium.org/2625303002
Cr-Commit-Position: refs/heads/master@{#443188}

Functions declared in this file return GURL by value.

BUG=

Review-Url: https://codereview.chromium.org/2627883003
Cr-Commit-Position: refs/heads/master@{#443187}

BUG=674052
TEST=manually tested as the issue describes
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2622403003
Cr-Commit-Position: refs/heads/master@{#443186}

When valid matching rules are available and user is signed-in to Chrome,
a synthetic field trial is created with GWS ID retrieved from field trial.

BUG=648651

Review-Url: https://codereview.chromium.org/2505343002
Cr-Commit-Position: refs/heads/master@{#443185}

This also fixes a problem introduced by
994db999.

BUG=649017

Review-Url: https://codereview.chromium.org/2597003002
Cr-Commit-Position: refs/heads/master@{#443184}

https://skia.googlesource.com/skia.git/+log/e4ca362259a3..e7a364d43584

$ git log e4ca36225..e7a364d43 --date=short --no-merges --format='%ad %ae %s'
2017-01-11 senorblanco GrTessellator: fix artifact with exactly-1-px-wide edges.

BUG=680260

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=kjlubick@google.com

Review-Url: https://codereview.chromium.org/2630443004
Cr-Commit-Position: refs/heads/master@{#443183}

The ExecutionContext parameter of loadWithCallback() was a leftover from
the FontLoader cleanup (http://crrev.com/1829403002).

No behavior changes.

Review-Url: https://codereview.chromium.org/2620343003
Cr-Commit-Position: refs/heads/master@{#443182}

BUG=None

Review-Url: https://codereview.chromium.org/2621143003
Cr-Commit-Position: refs/heads/master@{#443181}

This patch rewrites the detection logic for composited animations that
have neutral keyframes.

The previous code was relatively expensive and failed a DCHECK when
custom properties were used. This patch moves the use counting down into
where we actually handle compositing neutral keyframes.

BUG=679994

Review-Url: https://codereview.chromium.org/2620303002
Cr-Commit-Position: refs/heads/master@{#443180}

and it is false.

It was confusing that the flag seemed to check if enable some
specific members (attributes, methods, and constants), but it
should check everything of the interface.
It means if the flag is false, we don't have to check all
members, e.g. indexed properties and iterators.

BUG=None

Review-Url: https://codereview.chromium.org/2620153004
Cr-Commit-Position: refs/heads/master@{#443179}

[layout-tests] Anticipate a manual rebaseline for imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions.html

R=jochen@chromium.org
BUG=chromium:575167

Review-Url: https://codereview.chromium.org/2621373002
Cr-Commit-Position: refs/heads/master@{#443178}

BUG=670617
TEST=Show the on-screen keyboard on non-touchable display and
     switch to another IME; then check that the on-screen keyboard
     remains on the same display.

Review-Url: https://codereview.chromium.org/2546963002
Cr-Commit-Position: refs/heads/master@{#443177}

[Presentation API] (1-UA) Split PresentationServiceDelegateImpl(PSDImpl) into ControllerPSDImpl and ReceiverPSDImpl

(Splitting of https://codereview.chromium.org/2379703002/)

In an offscreen presentation, we have controlling frame (page that starts a PresentationRequest with url) and receiver frame (page corresponding to the url, rendered as offscreen tab). They talk to MR extension and OffscreenPresentationManager (OPM) in different ways. It makes sense to split them.

- create ReceiverPSDImpl class
- PresentationServiceImpl (PSImpl) class takes controller_delegate_ and receiver_delegate_ objects. For controlling frame, receiver_delegate_ = nullptr; For receiver frame controller_delegate_ = nullptr
- Added PSImpl::SetPresentationConnection() - will be called in PresentationDispatcher::OnSessionCreated(), PresentationDispatcher::OnReceiverConnectionAvailable(); will call OPM::RegisterOffscreenPresentationController()
- Added PSImpl::OnReceiverConnectionAvailable() - will be registered to OPM as receiver callback

PSImpl.receiver_delegate_ is always nullptr now (make sure things wont break). It will be set in offscreen_tab.cc in next CL.

More details in code comments and design doc (use chromium.org account): https://docs.google.com/document/d/1XM3jhMJTQyhEC5PDAAJFNIaKh6UUEihqZDz_ztEe4Co/edit#heading=h.hadpx5oi0gml

BUG=525660

Review-Url: https://codereview.chromium.org/2477573002
Cr-Commit-Position: refs/heads/master@{#443176}

RenderThreadImpl::Shutdown has been shutting down Blink and V8 gracefully,
but the graceful shutdown has caused tons of use-after-free bugs
(and many engineers has spent lots of time fixing ordering issues around the shutdown).

As discussed in chromium-dev@ (https://groups.google.com/a/chromium.org/d/topic/chromium-dev/OLS4JSZvowI/discussion) and
platform-architecture-dev@ (https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/Zc12k91NTFk/discussion),
there is no reason we have to shut down the renderer gracefully.
It's just causing use-after-free bugs and wasting performance.

Hence this CL removes RenderThreadImpl::Shutdown and instead calls _exit(0) in ~ChildProcess.
We need a couple of special handling in a single-process mode. See the comment in ~ChildProcess
for more details.

BUG=639244

Review-Url: https://codereview.chromium.org/2309153002
Cr-Commit-Position: refs/heads/master@{#443175}

The reland adds a fix for a crash in window animation code when restoring
a session that has a minimized window. The animation tries to compute a
shelf item position before the shelf is initialized. The animation is not
visible to the user. Returning an empty rect results in a default target
position, which is fine in this case.

Added guards for access to ShelfView before shelf is initialized.

Original CL description:

Previously chrome --mash would always create the shelf on startup, even at
the login screen. Now it waits until login is complete, like classic ash.

Ash watches for SessionState::ACTIVE via a SessionStateObserver to create the
shelf, rather than NOTIFICATION_LOGIN_USER_PROFILE_PREPARED. For most login
flows this doesn't matter, but for supervised user creation it means that the
shelf is not created until the flow is completed. This is an improvement
because in the old code the shelf would be created too early and had to be
explicitly hidden.

Always create a SessionControllerClient in chrome, even in classic ash. This
allows classic ash to use the mojo pathway via ash::SessionController.

Remove WmShell::ShowShelf(), which was introduced in crrev.com/10693003 to
delay showing the shelf until post-login OOBE (like avatar picture select)
was complete. It does not seem to be needed anymore, either in production or
in tests.

Change AshTestImplMus to simulate a user logging in which is required to
create the shelf on the primary display and also to have a non-zero user
count to create the shelf on additional displays.

Remove some unnecessary OS_CHROMEOS ifdefs in //c/b/ui/ash.

BUG=666021, 679513
TEST=ash_unittests and chrome browser_tests

Committed: https://crrev.com/7f99e933e595824281102ff6737075dccbbc4d5c
Cr-Commit-Position: refs/heads/master@{#439845}

Reverted:

Review-Url: https://codereview.chromium.org/2619943002
Cr-Original-Original-Commit-Position: refs/heads/master@{#442484}
Review-Url: https://codereview.chromium.org/2625733003
Cr-Original-Commit-Position: refs/heads/master@{#443106}
Committed: https://chromium.googlesource.com/chromium/src/+/75298de72cf7c25e137c3c5e63e4d01aa0569c1c
Review-Url: https://codereview.chromium.org/2625733003
Cr-Commit-Position: refs/heads/master@{#443174}

The mojo responses can be reached to the callback even after the PendingRequest
is removed. That didn't happen on the legacy IPC because the receiver object was
owned by PendingRequest. This patch is to allow the situation that the
PendingRequest is null when the response has received.

BUG=676984

Review-Url: https://codereview.chromium.org/2628553002
Cr-Commit-Position: refs/heads/master@{#443173}

https://crrev.com/2627543002 removes the non-mojo path. Let's remove the
non-mojo tests and the flag to run non-mojo path.

BUG=629701

Review-Url: https://codereview.chromium.org/2619883004
Cr-Commit-Position: refs/heads/master@{#443172}

The metadata stands for the pixel size of the image or the video.
Dimension is more appropriate name for this than resolution.

TEST=manually.
BUG=680011
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2622393003
Cr-Commit-Position: refs/heads/master@{#443171}