- 29 Oct, 2020 40 commits
-
-
Nick Harper authored
Change-Id: I432f63e305fdf9e9d6ad5303ddb1cbe41752934b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505940 Auto-Submit: Nick Harper <nharper@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#822110}
-
Rune Lillesveen authored
Test is flakily timing out. Bug: 1133412 Change-Id: I5689bbf030931731c4e3122fffa938a22e5f3571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506432Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#822109}
-
Rayan Kanso authored
This reverts commit 9593ee49. Reason for revert: Breaking tests on Android. Looks like Mockito is failing to mock 'WindowAndroid' Sample build: https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/27576? Bug: 1143640 Original change's description: > [SharingHub] Changed the way firstPartyOptions are created. > > They will not be created on demand. This simplifies the logic to decide > which options are relevant given the current state of the Chrome app. > > Change-Id: I9b3ebf3030cfaa48088d7c1d0082d659b47f28cd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485838 > Commit-Queue: Tanya Gupta <tgupta@chromium.org> > Reviewed-by: Kyle Milka <kmilka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821914} TBR=kmilka@chromium.org,tgupta@chromium.org,sophey@chromium.org Change-Id: I904fb819d2fd37899faefb6c71140cd9c54ad419 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506576Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#822108}
-
Wei Lee authored
We should fix the circular dependencies to avoid potential wrong order when importing modules. For example, if the dependencies of modules are like: A --> B --> ... --> A If we import B but A needs B when loading A, it might hit "access before initialization" error. Bug: 1121457 Test: tast run [DUT] camera.CCAUI* Test: npx madge --circular main.js Test: (Replace some js with SWA version and run "npx madge" again) Change-Id: Ib41b85425fc256a3394b31a8c573f68177d45c3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505397 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#822107}
-
Sergey Poromov authored
According to the latest mocks we need to show a notification instead of a toast when printing is blocked due to Data Leak Prevention configuration. See mocks: https://docs.google.com/presentation/d/1v0GM-lwHCznFJ6hnZlUH37eBOuAkJMw5Q6UnSkcKOgA/edit?hl=en#slide=id.ga3a0b63111_0_321 Bug: 1124651 Change-Id: I3bf1f73610d2f2723f75b9801bb131c7b2bf77b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505790Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#822106}
-
Antonio Gomes authored
This CL is a preparation CL, where the final goal is to move away from using chromeos::TabletState, embedding its functionality into //display/ScreenBase class. The first step to to dismantle this enum from it, so that it can be referenced to independently. TBR=jamescook@chromium.org BUG=1113900 R=jamescook@chromium.org, oshima@chromium.org, rjkroege@chromium.org Change-Id: I4d907b9d322723f581bfc1a278577088028795ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505944 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#822105}
-
Danila Kuzmin authored
When user tries to enroll their CBEdu into a non-EDU account (e.g. enterprise) they will see a new error message, added in this CL. Bug: 1113395 Change-Id: Ib73244dc65e98be6c3497e9b711dae67411b897c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465746Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Cr-Commit-Position: refs/heads/master@{#822104}
-
Robbie Gibson authored
This reverts commit 7ffe1230. Reason for revert: Disabled test on iOS 12 devices (test passes on other OS versions). Original change's description: > Revert "[iOS] Fix tab strip views when using FullscreenProvider" > > This reverts commit c756c75c. > > Reason for revert: Suspected cause of crbug.com/1142873 > > Original change's description: > > [iOS] Fix tab strip views when using FullscreenProvider > > > > When the FullscreenProvider is used, the layout of the browser views is > > slightly different. Instead of having the web content views start from > > the bottom of the toolbar, the web content extends all the way to the > > top of the BrowserContainerViewController, behind the tab strip. > > > > This means that the prior approach of making all the top background > > views clear does not work when using FullscreenProvider. Instead, this > > CL uses the following approach: set these background views to have > > the same background color as the tab grid. As soon as the panning > > gesture starts, make them clear so the tab grid shows through and the > > animations appear correctly. At the same time, move the web content > > views down so they don't obstruct the animations either. > > > > Bug: 1094335 > > Change-Id: Ieea7d268e781da5e1ccd4c2c0ad3c0925407d133 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489898 > > Reviewed-by: Mark Cogan <marq@chromium.org> > > Commit-Queue: Robbie Gibson <rkgibson@google.com> > > Cr-Commit-Position: refs/heads/master@{#821200} > > TBR=marq@chromium.org,rkgibson@google.com,mouraroberto@google.com > > Change-Id: I2b026d35000d34b29de9235ed2752273f6f7dd33 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1142873 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502574 > Reviewed-by: Stefan Zager <szager@chromium.org> > Commit-Queue: Stefan Zager <szager@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821278} TBR=szager@chromium.org,marq@chromium.org,rkgibson@google.com,mouraroberto@google.com # Not skipping CQ checks because this is a reland. Bug: 1142873, 1143299 Change-Id: I052c3b730e92855b3edcbfac17b7bdf5c8c305f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502347 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#822103}
-
Mark Cogan authored
The New Window overflow menu item wasn't setting a window origin, so no metrics were recorded for it. This CL adds the appropriate origin. Bug: 1143280 Change-Id: I4a85fff19b72d35cbc8d0254086553042fb5d273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505873Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#822102}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I18816e9d92da591d92867b58ebb01ac49d40467f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506347Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822101}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cd60eacd..74cd21ef Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If09955db5d75ee0abdff859033948944947c1981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506364Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822100}
-
Yunke Zhou authored
Bug: 1141307 Change-Id: I6a5499592dccc9a3eaffb35fe15e7c194cd8dc04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490005Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#822099}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2bb8035ddc14..a584311a6a73 2020-10-29 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 5ede1190cf97 to d2fa57d26dff (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I5c7e917b4464755b7cef545035858e6e80f1e649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507090Reviewed-by:
-
Wolfgang Beyer authored
Frontend CL: https://crrev.com/c/2502288 Bug: chromium:1108501 Change-Id: I14fa19c8e9ee5c95ec5281e32dc9877f1678085d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502428Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#822097}
-
Wolfgang Beyer authored
DevTools CL: https://crrev.com/c/2485085 Re-enable Tests CL: https://crrev.com/c/2485068 Design doc: https://goo.gle/devtools-si Bug: chromium:1035309 Change-Id: I9e77685dc09ec4d6c569712067bbda778755c5fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487269Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#822096}
-
Sigurd Schneider authored
Bug: chromium:1140445 Change-Id: I369d9b05e1808090bcc1eba07a6801eb336037ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497444Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#822095}
-
Rune Lillesveen authored
This reverts commit 1bfcd597. Reason for revert: suspected culprit for Linux MSAN failures for ProofVerifierChromiumTest.PKPReport See: https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/26005 Original change's description: > Make net::ReportSender take a NetworkIsolationKey. > > And update all consumers to pass one in. > > Bug: 1082280 > Change-Id: I97e2559616f01d600848025a16b916d583759504 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497463 > Reviewed-by: Emily Stark <estark@chromium.org> > Reviewed-by: Daniel Rubery <drubery@chromium.org> > Commit-Queue: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821789} TBR=mmenke@chromium.org,estark@chromium.org,drubery@chromium.org Change-Id: I69881567c2d33bcfac11b72321f4f6ecc0b5e9fb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1082280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505982Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#822094}
-
Ted Meyer authored
This also changes the print behavior for media logs for media::Status objects, since we're using them in more places now. They tend to be a bit spammy in stdout. Bug: 1141954 R=liberato Change-Id: Ie40995eb10e8961233e333dc5aa7fdd7a02f6b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504580Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#822093}
-
Saurabh Nijhara authored
The extension reporting enums in device_management_backend.proto have extra newlines between the values which are not needed/helpful, hence removing them. Bug: 1142957 Change-Id: I115eacd9906e35e88649f070bef0599180e4eb67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504310Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Swapnil Gupta <swapnilgupta@google.com> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#822092}
-
Ewann authored
This CL disables the top toolbar of the tab grid the 'Close All Tabs' Confirmation action sheet is displayed. Bug: 1140518 Change-Id: I6e6d8f5103554e79b40f7ab1cdb8e962e43822a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502478 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
-
Darren Shen authored
Add Mojo and protobuf messages for Chrome to send input method changes to the IME service. Bug: b/161490915 Change-Id: Ie1ec9a50f6c0c4daaa6e28af9f669ea7c469b9ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497942Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#822090}
-
Daniel Cheng authored
This also converts the various metric enums to be scoped enums, which allows: - clang to enforce kMaxValue correctness - autodeduction of the max value by UMA_HISTOGRAM_ENUMERATION. Bug: 742517, 1047547 Change-Id: I3d7c4476d0001fd9984527918f7c2494332653a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506359 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#822089}
-
Rune Lillesveen authored
This reverts commit 9de8d0a8. Reason for revert: Causes compile error on win-chrome builders See e.g.: https://ci.chromium.org/p/chrome/builders/ci/win-chrome/16430 Original change's description: > [NTP][RQ] Moves ntp_features.* from c/b/search to components/search > > Allows using NTP features in MostVisitedSites and related services in > components/ > > Fixed: 1143475 > > Change-Id: I673bed5c25651acca3ef7c44512567599bb6b9f5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504639 > Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> > Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> > Reviewed-by: Alex Gough <ajgo@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821986} TBR=sky@chromium.org,mahmadi@chromium.org,ajgo@chromium.org Change-Id: I9abc3b7addd2a1f6e5c0d3abfc721acbb86fa3e1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507070Reviewed-by:
-
Jenny Zhang authored
Add a GetActiveTabUrl crosapi in LacrosChromeService to allow ash to get the URL of active lacros tab. Show active lacros tab's URL in feedback dialog when user press alt-shift-i from an active lacros window. TEST: 1. Launch lacros chrome, invoke feedback by alt-shift-i. Make sure the URL field of the feedback dialog shows the url of active lacros tab. 2. Launch lacros chrome, deactivate it by minimizing it, or activate another app, invoke feedback by alt-shift-i. Make sure the URL field of the feedback dialog is empty. 3. Launch both lacros chrome and ash chrome, minimize lacros chrome or keep it in background, have ash chrome in the foreground, invoke feedback by alt-shift-i. Make sure the URL field of the feedback dialog shows the url of the active ash chrome tab. Bug: 1142541 Change-Id: I3edc15db3fdda22214f3b849b24d4b619b219f59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505736 Commit-Queue: Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#822087}
-
Sergey Poromov authored
In order to support pausing media streaming for Data Leak Prevention feature, MediaStreamManager should be able to pause (mute) and resume (unmute) existing media streams. Bug: 1134566 Change-Id: I0a5bea9483e1ddeb8ac99e1e7b13a05a2babd4cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445610 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Auto-Submit: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#822086}
-
Gauthier Ambard authored
Update default-browser-setting and desktop-version-default Bug: none Change-Id: Ie58c2e6fa30b2b4688b5ca3b720b61dc7cfd9cb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506177 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#822085}
-
Rune Lillesveen authored
This reverts commit 83e275fd. Reason for revert: ShareServiceUnitTest.Multimedia started failing on multiple Windows bots. This is likely the culprit. Original change's description: > WebShare: Windows Implementation > > Completing the implementation of navigator.share() for Windows by > hooking in the relevant components and updating the corresponding tests. > > Originally committed as part of https://crrev.com/c/2443757, but > reverted due to test issues. Patchset 1 is a cherry pick of this > original change (reduced to the files relevant to this portion) for > easy comparison. > > Bug: 1035527 > Change-Id: Ic83fa002601cce5e6c03eee9ec214f7c4c209096 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505603 > Reviewed-by: Eric Willigers <ericwilligers@chromium.org> > Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#821941} TBR=ericwilligers@chromium.org,mhochk@microsoft.com Change-Id: I04727e14ee724e8526b4ee8b79ed0705c37dd8b5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1035527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506574Reviewed-by:
-
Hiroki Kumazaki authored
I want to collect information about mobile friendliness as UKM. In this patch, I implemented UKM only on Viewport metrics as a first step. Other metrics (font sizes, tap targets, plugins, contents outside viewport width) will follow as separate patches. Bug: 1113750 Change-Id: Ib5c386ac7ceaef68384db36f2d61a435f567b921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398448 Commit-Queue: Hiroki Kumazaki <kumagi@google.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#822083}
-
Henrique Ferreiro authored
This function isn't used elsewhere. Change-Id: I9f009bfb5376b64fdfdd9eb165084663d4f7f38d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505136Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#822082}
-
Maria Kazinova authored
This metric is added to ensure that using unique renderer IDs for form filling will not result in additional filling failures. Bug: 1131038, 1075444 Change-Id: If3314f265ab0104f1f64297fe1e5cea63c58698d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506032Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#822081}
-
Viktor Semeniuk authored
This change adds confirmation message to the delete dialog for non compromised passwords. Bug: 1141331 Change-Id: I831192aa6adbda67354882d63f25f8f51f955b91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504232 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#822080}
-
Peter Marshall authored
DevTools is intending to share Chrome's HaTS implementation, but we have a slightly different use-case as we are presenting 'persistent' surveys, which are triggered by user interaction like clicking a link to take a survey. These surveys are always triggered on the server-side, and don't have a client-side rate limit. DevTools' surveys will be triggered by the user clicking on a link. If we know that a survey won't succeed, we want to avoid showing the link in the first place. We've extended the HatsService API with CanShowSurvey() to indicate whether we already know a survey will fail. We also want to know whether a survey has failed to show to the user, even after the initial CanShowSurvey check, which is possible. To get a signal for this we've added success and failure callbacks to LaunchSurvey(). As DevTools will use persistent, user-prompted surveys, we've added the notion of user-prompted to the SurveyConfig struct. This changes some survey triggering behavior: - We remove the minimum profile age check. - We remove the last started time for this survey check. - We remove the last started time for any survey check. We still trigger the UMA stats in CanShowSurvey(), even though they will be duplicated in LaunchSurvey. The reasoning is that the UMA stats are only recorded for 'failed' cases where CanShowSurvey() returns false - the expectation is that the caller will not then call LaunchSurvey and trigger a 2nd UMA stat which would potentially skew results. Doc: https://docs.google.com/document/d/1wMRb1hI2zJ1mzOSJjjF46C2hToGksQf2AxurorxaiTg Bug: 1112738 Change-Id: Id48fb9296fbce898fc6428cd562990e25e96457b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485940 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#822079}
-
Matt Falkenhagen authored
This adds UseCounter for local storage being first used before fcp and after fcp. For prerendering, we expect to cancel the prerender on a local storage access, because it uses a synchronous IPC. Note that while getAll() is the only sync method in blink::mojom::StorageArea, any initial use of local storage uses that to populate Blink's in memory cache. This adds a page load metrics observer which logs to Blink UseCounter on Local Storage access. This is somewhat an abuse of the UseCounter, as it's a targeted use case, but the UseCounter has good properties like defining what a page load is. This will eventually be replaced with Prerendering cancellation metrics when Prerendering is actually implemented. Bug: 1126305 Change-Id: If719c21115481d93930101e95d6fe86701f30523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497965 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#822078}
-
Evan Shrubsole authored
In the kWebRtcLibvpxEncodeNV12 feature, avoid converting the scaled image to I420. This saves an allocation in creating the NV12ToI420 scale, and a copy of the scaled UV plane. Bug: 1134165 Change-Id: I6b4e433ae0ea4b22c49cc5f14904b1a67439f34b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483828Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Evan Shrubsole <eshr@google.com> Cr-Commit-Position: refs/heads/master@{#822077}
-
Kuo Jen Wei authored
Add check to early return from taking process of camera intent view if the underlying camera view ends the take process earlier(e.g. timer canceled) and produce no take result. Bug: b/171874692 Test: Manually Change-Id: I7aa8c70680e6c59fa013a0ced4738a200388b30d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505321 Commit-Queue: Inker Kuo <inker@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#822076}
-
Zhaoliang Ma authored
Bug: None Change-Id: I82107c410e016c1303828a91be1fd2e277b9333d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506277 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#822075}
-
Colin Blundell authored
The test was expecting events in the wrong order: upon reload and click on the form it was expecting to see a CANCEL event followed by a VIEW_EXITED event, but the latter event is fired first as part of focus moving off of the current form, followed by the former event as part of starting the new autofill session. I did not detect this problem in my local testing because the CANCEL event is not sent (/listened for by the testing infrastructure) on Android versions > O. I verified locally that the test fails on an O emulator before the change in this CL and succeeds after the change. One thing that's not clear is how this test ever succeeded on the O trybot, e.g. on this run: https://ci.chromium.org/p/chromium/builders/ci/Android%20WebView%20O%20%28dbg%29/12151 This CL also changes the test to do the reload via AwActivityTestRule#reloadSync() rather than AwActivityTestRule#loadUrlSync() to reflect production behavior. That change, however, does not impact the above logic. Bug: 1142486 Change-Id: Id2e9d6dbb44615356b43603afb11a2b4de40467e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502043Reviewed-by:
Michael Bai <michaelbai@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#822074}
-
Bartek Nowierski authored
Bug: 1092288 Change-Id: Iabef18be7e80d36ca6242d869a66a8c684c66472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505320 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#822073}
-
Wei Lee authored
This reverts commit e9e022ce. Reason for revert: Per UI review, camera folder should be non-modifiable. Original change's description: > [Files App] Makes Camera folder modifiable > > Per discussion with Files team, we agree that Camera folder should still > be modifiable. > > Bug: 1127587 > Test: Manually > Change-Id: I22a9e3eca0b7fb71bd883c37bb0e6a30509e8b80 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477707 > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Commit-Queue: Wei Lee <wtlee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820680} TBR=lucmult@chromium.org,wtlee@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1127587 Change-Id: Iaaa95f90958b3a539c3f32254d784c75dd8ad39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505705Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f418c109094a..3591997b58bf 2020-10-29 syoussefi@chromium.org Roll Vulkan-Loader from 8e2b7d03ccfd to 8308d6744d50 (2 revisions) 2020-10-29 jmadill@chromium.org Revert "Tests: Update COD:Mobile trace" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: I066c5e92f6e60ea2a41aa5a8d85f02a352e62335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506665Reviewed-by:
-
